- 18 Aug, 2020 40 commits
-
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/6f74415e2f74..cbfd396756c6 2020-08-18 sugoi@google.com Control Flow Integrity (cfi) fix If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: chromium:1116053 Tbr: swiftshader-team+autoroll@google.com Change-Id: I45e2a4d8fbc2eb5eaa615db6ffba21d47ce79c2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363332Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#799317}
-
Michael Crouse authored
Privacy doc: https://docs.google.com/document/d/133SsQTd3L5ryQaI-q1rZsh6EeTsE_HxDFlthjlXi4CU/edit?ts=5f3c1ca0# Bug: 1117645 Change-Id: Ifc3229de5e19cc78269cd6e6c3ae2d4ae1f1c11c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363693Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Michael Crouse <mcrouse@chromium.org> Auto-Submit: Michael Crouse <mcrouse@chromium.org> Cr-Commit-Position: refs/heads/master@{#799316}
-
Steven Bennetts authored
Chrome OS sets the Error state when a network disconnects, e.g. during suspend. This causes the UI to show the configuration UI instead of attempting a connection when the network is connected to. This addresses that issue by recognizing a new kErrorDisconnect state (that only occurs during a non user initiated disconnect), and ignoring the error when attempting a connection. BUG=1112814 Change-Id: I2220395d4035495182a6b0f25fcc0313ae2e1750 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350315 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Azeem Arshad <azeemarshad@chromium.org> Reviewed-by:
Jon Mann <jonmann@chromium.org> Cr-Commit-Position: refs/heads/master@{#799315}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/d5044cd209a6..9d0f7dea2a59 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I79d0df129775dd5fd3d4b0ae597a0b7325bf6003 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363001Reviewed-by:
-
Gayane Petrosyan authored
This CL also adds fragment identifier to the url that was ommited before. Bug: 1102382 Change-Id: I175c409cef5a90a3e8e2958c66a90e779dbad0fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363347Reviewed-by:
Gayane Petrosyan <gayane@chromium.org> Reviewed-by:
Tommy Martino <tmartino@chromium.org> Commit-Queue: Gayane Petrosyan <gayane@chromium.org> Cr-Commit-Position: refs/heads/master@{#799313}
-
Filip Gorski authored
Change-Id: I81effcfed2342a4a5eaddcbefb4a4581ecc744ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363167Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Filip Gorski <fgorski@chromium.org> Cr-Commit-Position: refs/heads/master@{#799312}
-
Daniel Classon authored
Change the remove restricted user button to use dom-if instead of hidden. Relevant to deep linking as its easier to deep link to visible buttons if hidden buttons aren't rendered. Bug: 1084154 Change-Id: I831dc8f69ab00ffc51771a327b2fdf8ea47ab559 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363551Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Daniel Classon <dclasson@google.com> Cr-Commit-Position: refs/heads/master@{#799311}
-
phillis authored
WebAppInstallFinalizer::OnFallbackInstallFinalized is not used anymore, remove it and mark the metric as obsolete. Bug: None Change-Id: I7bdb18a1b8a137669c0554e59faf1a839471e0e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350327Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Commit-Queue: Phillis Tang <phillis@chromium.org> Cr-Commit-Position: refs/heads/master@{#799310}
-
James Cook authored
Rename LoginPerformer::IsUserWhitelisted() to IsUserAllowlisted(). I didn't call this IsUserAllowed() because there might be other reasons a user isn't allowed to log in. This ends up affecting a bunch of impl classes in //chrome/browser/chromeos Bug: 1097644 Change-Id: I30a44761e62b9277deed1469189f2b3b2b8bce0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363633 Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Auto-Submit: James Cook <jamescook@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#799309}
-
Mason Freed authored
There is already some debug output available for origin trials, which can be enabled with: % chrome --vmodule=origin_trial_context=1 --enable-logging=stderr This CL adds a bit more human-readable debug output, plus it adds the appropriate flags to the documentation, so it is easier to find. TL/DR now: % chrome --vmodule=trial_token=2,origin_trial_context=1 --enable-logging=stderr Change-Id: I27d08055f460287e02531886593c696e700bbe3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347385Reviewed-by:
Jason Chase <chasej@chromium.org> Commit-Queue: Mason Freed <masonfreed@chromium.org> Auto-Submit: Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#799308}
-
Lei Shi authored
When converting nodes into NodeGroup, we check each word one by one. If the word is out of the bound of its parent, we replace the word with equal length space characters. The resulted text have the same length of the original text, and TTS will ignore overflow texts as they are empty now. Bug: 775659 Change-Id: Iec3a296344b1c522ec255d56bfcbf51a68d50f5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342127Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Lei Shi <leileilei@google.com> Cr-Commit-Position: refs/heads/master@{#799307}
-
Robert Ogden authored
Bug: 1115259 Change-Id: I3e352ce08e93609e047f13f519dede7f9f7296ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358035Reviewed-by:
-
Takumi Fujimoto authored
Currently the feature is exposed only to allowlisted origins. This CL adds a flag to chrome://flags that will allow developers to test the feature on non-allowlisted origins. Bug: 1111916, b/162437760 Change-Id: I9a702f3560b9414b572de2a6544704cc092b7a39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342114 Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Reviewed-by:
John Williams <jrw@chromium.org> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Cr-Commit-Position: refs/heads/master@{#799305}
-
David Trainor authored
Change the config to refer to the beta configuration. Bug: 1108002 Change-Id: I54df3a07cd40695a7f8fcac42784e7c999265962 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360606 Auto-Submit: David Trainor <dtrainor@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#799304}
-
Filip Gorski authored
Switches the default state of the flag to enabled. Deletes OmniboxSuggestionsRecyclerView from fieldtrial testing config. Bug: 1075602 Change-Id: I38efb6702eb253a316a756c99af9cf53e5858d6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362091Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/b6a272ffee65..9d0f7dea2a59 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I5dabe0f1a816c43df5f4d157c368b97c8c849af0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363000Reviewed-by:
-
Etienne Pierre-doray authored
Concurrency checks gives bogus worker_count values since https://chromium-review.googlesource.com/c/chromium/src/+/2304972 The thread that just returned from worker task will still count as active. This can cause races that will trigger dcheck. This could be fixed probably by tweaking worker_count similar to https://chromium-review.googlesource.com/c/chromium/src/+/2355297 Since this is dcheck-only code that adds significant complexity however, it makes more sense to strip the code: - dcheck can trigger in valid use cases - The issues that the dcheck will catch would also cause Join to never return. This should be easy enough to detect without the dcheck. Bug: 1114823 Change-Id: I1181ba7f530cf81624f578ed0f324849ad930e41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363074 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#799301}
-
Caitlin Fischer authored
This change paves the way for limiting the set of experiment IDs included in X-Client-Data headers sent in third-party contexts. Bug: 1094303 Change-Id: Ib5b094e1fa9aa1e508d9b8f14886d69ce18cbfa4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363076Reviewed-by:
-
zhaoyangli authored
iOS is going to build with Xcode 12 sdk in trunk builders, but branched ci/try builders have to use Xcode 11. There are issues when using Xcode 11 & Xcode 12 on one machine. Thus, we need to separate the machines for iOS trunk and branched builders. This CL adds an argument to builders.star to generate builder dimension with project & bucket and uses the argument for iOS branched builders. Credit to gbeaty@ for the change in "infra/config/lib/builders.star" (patched from crrev/c/2360500) Bug: 1115022 Change-Id: Ic682e3014073e07a9526e14997dd4c170f11d9de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363691Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org> Cr-Commit-Position: refs/heads/master@{#799299}
-
Patrick Monette authored
Bug: 1075553 Change-Id: I538dc87123f87bc1688cb12eba8d3b9922815a8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357089Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/0d421b6025ff..c4a82aaabbdd 2020-08-18 cnorthrop@google.com Tests: Add COD:Mobile trace If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: cnorthrop@google.com Test: Test: angle_perftests --gtest_filter=TracePerfTest.Run/*cod_mobile* Change-Id: I600d89f6d77e0a6be12a45696cd68e628c895484 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362994Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/7929aebd9197..560b983ff5a9 2020-08-18 jacktfranklin@chromium.org Disable ESLint on bridge files 2020-08-18 jacktfranklin@chromium.org Component bridges: error if using TS built-in type If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ib5d219209b4145eccbcb3a961c162048e4d95755 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363627Reviewed-by:
-
Nnamdi Theodore Johnson-Kanu authored
Bug: 1045266 Change-Id: I662beb3eb8b7b472c5364afe50f860e0e40b0720 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359407 Commit-Queue: Nnamdi Theodore Johnson-kanu <tjohnsonkanu@google.com> Reviewed-by:
-
Yao Xiao authored
Previously, we log the floc when it's computed and has a valid value. Change it to be: log whenever the status changes, i.e. valid->invalid, invalid->valid, or valid->different-valid. Why: 1) This makes it more natural to understand. 2) This allows the server to know when the floc is disabled. This is not necessary as of now, because currently the only updating trigger is the scheduled update, so if the server sees no event after 24 hours since the last event, the server could infer that the floc is disabled. However, if we introduce new updating trigger like history-delete, then the server would have insufficient knowledge. Thus, switch to the new logging condition. Bug: 1062736 Change-Id: I8796c2af89a4de5c5f8831e1c00693224927fcd5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357613 Commit-Queue: Yao Xiao <yaoxia@chromium.org> Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Cr-Commit-Position: refs/heads/master@{#799294}
-
David Maunder authored
We now enforce tab attributes cannot be acquired if tab is uninitialized. Bug: 1117396 Change-Id: Ie928bbc6f23cab3ebab7d4e11fe085658010bece Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363128 Commit-Queue: David Maunder <davidjm@chromium.org> Reviewed-by:
Jeffrey Cohen <jeffreycohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#799293}
-
Stephanie Kim authored
Both `otool` and `atos` commands needed to be run with the hermetic xcode paths. The code will first check that the hermetic xcode paths exists before using that path. Bug: 1113466 Change-Id: I11304f1981faf55946d3aa6fde44af631c87dc3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340795 Commit-Queue: Stephanie Kim <kimstephanie@google.com> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#799292}
-
Klaus Weidner authored
Pass in a Document instead of Element since the internal methods just use the Document. Change-Id: If7a1d65b86cab1344ef336b955d5769b8f37a0b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358492 Auto-Submit: Klaus Weidner <klausw@chromium.org> Commit-Queue: Piotr Bialecki <bialpio@chromium.org> Reviewed-by:
Piotr Bialecki <bialpio@chromium.org> Cr-Commit-Position: refs/heads/master@{#799291}
-
Stefan Zager authored
BUG=1116788 Change-Id: I60c721d84b7c21406259ad8345d0290cb52ee940 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358603 Commit-Queue: Stefan Zager <szager@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#799290}
-
Maksim Sisov authored
When use_x11 && use_ozone are set to true at the same time, compiler throws an error about multiple definitions of the CreateUIControlsAura. Thus, to fix that, create a separate source file for is_linux case that will choose what class to use based on the IsUsingOzonePlatform feature flag. Please note that this is a temp solution and it will be removed once use_x11 goes away. PS: this patch uses the same approach used in other patches. For example, https://crrev.com/c/2247719 PPS: I didn't spot that in the beginning as linux-rel bot couldn't compile use_x11 && use_ozone because of failures in the chrome installer step. But after we fixed the sysroot, I spotted some problems and fixing them now. Bug: 1085700 Change-Id: I1c2f3a0762df4b195775d30f580df09090f13999 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362698Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Maksim Sisov (GMT+3) <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#799289}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1597751915-4ae12f45519e9d683fdf6edd45cc3e8b84e80d22.profdata to chrome-mac-master-1597773485-0de81363c6e29d47e12bedb85e74c4f66df8cd46.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: I47bb2b650f7dc7542d7bccd2ab6e96a0e9b0e3b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363293Reviewed-by:
-
Maksim Sisov authored
There are some tests that create own cmdline that results in missing kEnableFeatures and kOzonePlatform switches. As a consequence, the browser parts start with a wrong config, which results in failures and usage of the non-Ozone path for the use_x11 && use_ozone config, and also in usage of the wrong OzonePlatform as it doesn't know what platform the test has been launched with (linux-ozone-rel testers pass headless/wayland/x11 to the cmdline, for example). Solution is to copy all the previous switches. Bug: 1115055 Change-Id: Ia7a1f2688b1d697073a96c6527145342deb13778 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346355 Commit-Queue: Maksim Sisov (GMT+3) <msisov@igalia.com> Reviewed-by:
Jonathan Ross <jonross@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#799287}
-
Dan Harrington authored
If the user signs out, and then signs back in, Chrome was showing an unpersonalized feed. Bug: 1117535 Change-Id: I5b247f1d4641bbfbc7e3d9f80623d6afb08909b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362991 Auto-Submit: Dan H <harringtond@chromium.org> Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Commit-Queue: Carlos Knippschild <carlosk@chromium.org> Cr-Commit-Position: refs/heads/master@{#799286}
-
Andrew Grieve authored
The flag is guarded by treat_warnings_as_errors=false so that it will apply only to local developer builds. Results from //tools/android/build_speed/benchmark.py base_java_sig: With change: base_java_sig: 68.0s avg (68.8s, 67.2s) base_java_sig: 68.4s avg (68.6s, 68.2s) Without change: base_java_sig: 69.4s avg (69.3s, 69.5s) base_java_sig: 69.7s avg (69.7s, 69.7s) time out/Debug/bin/run_base_junit_tests: With Change: real 0m22.741s real 0m23.543s Without change: real 0m23.176s real 0m24.328s Bug: 1117222 Change-Id: I4bfd742165468bf9538e6fa0dc8f35daa9e0f23f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2313299 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#799285}
-
Matthias Körber authored
The CL migrates profiles with a legacy name structure when they are imported from profile specifics. Change-Id: Ib8ddda534d36d542d1328d1cbd24d05e0da86e12 Bug: 1099202 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362808 Commit-Queue: Matthias Körber <koerber@google.com> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#799284}
-
Alex Rudenko authored
This CL adds calls to FramePointToViewport when generating absolute label positions to ensure that labels are properly positioned within iframes. Screenshot: https://i.imgur.com/DDMvChr.png Fixed: 1116324 Change-Id: I7ae1e720eb99e3e0b0394b838a7d0b7e660901dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359033 Commit-Queue: Alex Rudenko <alexrudenko@chromium.org> Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#799283}
-
David Bokan authored
This CL consolidates the commit steps for input data to pass a complete object back to LayerTreeHostImpl. We also rename ScrollAndScaleSet to CompositorCommitData since the commit carries other information like top controls delta and SwapPromises. Bug: 915926 Change-Id: I254ac32a271a264d0b36485e3015cc7d504b4d04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358480Reviewed-by:
Xida Chen <xidachen@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Auto-Submit: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#799282}
-
Leonid Baraz authored
A conversation with experts gave a recommendation to not use streaming ciphers - instead, accumulate data and do encyption/decryption at the end (in place). Bug: b:153649905 Change-Id: I1a146fcf571089c648a75c4d4cbd1b75a6900ff0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363392Reviewed-by:
Zach Trudo <zatrudo@google.com> Commit-Queue: Leonid Baraz <lbaraz@chromium.org> Cr-Commit-Position: refs/heads/master@{#799281}
-
Ben Pastene authored
This increases verbosity by a single level. Practically, that just means boards' SDKs that take a while to fetch will be printed. For example, it will print statements like: WARNING: It took 3m48.535s to fetch the SDK for amd64-generic. Consider removing it from your .gclient file if you no longer need to build for it. Bug: 1034063 Change-Id: I7407bb503f4145e5de6d0e6d39b596a50ea46009 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363314Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@google.com> Reviewed-by:
Erik Chen <erikchen@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#799280}
-
Sahel Sharify authored
This cl adds an enum-based metric for payment request checkout flow. Each bucket in the flow corresponds to one step during the checkout process and each payment request may be counted in multiple buckets one for each completed step. Motivation: This metric will be subscribed for Chirp alerts to catch ressions/improvements on the number of transactions using Web Payments APIs. The reason for adding this metric is that both PaymentRequest.Events and PaymentRequest.TimeToCheckout.* metrics are numerical metrics. This means that adding Chirp alerts for these metrics will only track changes in different percentiles of sample values rather than changes in sample counts. Bug: 1091471 Change-Id: I7f43df9cc373b0662a7d269de4d577e677005180 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353149Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Danyao Wang <danyao@chromium.org> Commit-Queue: Sahel Sharify <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#799279}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a651373fa953..5012a13f63ac If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC tommycli@google.com,csharp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: tommycli@google.com,csharp@google.com Change-Id: I5f3288e7afd032cb4813769cb3bd22d89242c1a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363313Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#799278}
-
