- 18 Oct, 2017 40 commits
-
-
Yuwei Huang authored
Chromoting is planning to bump up iOS deployment target to 10.0. However, one of our dependency, //third_party/usrsctp has used some OSAtomic* functions that have been deprecated on 10.0 SDK. After some discussions with the usrsctp people, we would like to suppress the deprecation warning on usrsctp for now because: * Replacing the OSAtomic* functions with atomic_fetch_add is nontrivial and requires replacing some int32_t with _Atomic(int32_t) globally in their codebase, which is challenging for an engineer who isn't familiar with it. * The OSAtomic* API works all the way up to deployment target 11, if ignoring the warnings. * Filed a bug in their repo but they don't plan to fix that soon. * They have already suppressed the warning in their configure.ac file. This is replicating their change. Bug: 774483 Change-Id: Ie7f65edb767cc241a8b5fe7dc6074ef37387d89f Reviewed-on: https://chromium-review.googlesource.com/726619Reviewed-by:
Rohit Rao (ping after 24h) <rohitrao@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Reviewed-by:
Taylor Brandstetter <deadbeef@chromium.org> Commit-Queue: Yuwei Huang <yuweih@chromium.org> Cr-Commit-Position: refs/heads/master@{#509905}
-
bsheedy authored
Adds an isolate target to gn_isolate_map.pyl for running vr_common_perftests on the VR perf bot. Bug: Change-Id: Icc61fd0824bfa093fff2f683e52e94731d2bd78e Reviewed-on: https://chromium-review.googlesource.com/726269Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#509904}
-
Zhenyao Mo authored
BUG=759634 TEST=startup.warm.blank_page R=kbr@chromium.org Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I050ced97dbba071b5fb32324239d45d43dd72f6d Reviewed-on: https://chromium-review.googlesource.com/726499Reviewed-by:
ccameron chromium <ccameron@chromium.org> Commit-Queue: Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#509903}
-
Eric Karl authored
Re-land of https://chromium-review.googlesource.com/c/chromium/src/+/544102 The GPU Image Decode Cache now uses GPU discardable so it can share texture limits with other controllers in other processes. This allows us to put an upper limit on the amount of GPU memory that will be used for image decodes - previously this was only limited per-renderer and could grow unbounded. This was originally reverted due to a texture leak in discarding Skia owned textures. This change relies on a new Skia API: SkImage::MakeBackendTextureFromSkImage, which allows us to to take ownership of the GL texture from Skia and safely discard it. TBR=isherman@chromium.org Bug: 438325 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I4a0dcb48d6353f9b914e0ee00ddae12ee23d916c Reviewed-on: https://chromium-review.googlesource.com/706593 Commit-Queue: Eric Karl <ericrk@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#509902}
-
Tom Sepez authored
Finish separation of GPU from sandbox. In turn, this allow us to move content/common/sandbox_init_gpu_linux.cc closer to its buddies in content/gpu. Change-Id: If604d306bba0b336f6302dd68e559d34b828539c Reviewed-on: https://chromium-review.googlesource.com/721857 Commit-Queue: Tom Sepez <tsepez@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#509901}
-
Stephen Martinis authored
Also adds a unittest to the perf data generator script to ensure that any lists in the file are alphabetized. Bug: 767262 Change-Id: I8e08159728aa7e574dc40f306d747bd4c4a9f72f Reviewed-on: https://chromium-review.googlesource.com/716848 Commit-Queue: Stephen Martinis <martiniss@chromium.org> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Reviewed-by:
Sean McCullough <seanmccullough@chromium.org> Cr-Commit-Position: refs/heads/master@{#509900}
-
chaopeng authored
Rietveld Code Review: https://codereview.chromium.org/2910843002/ Bug: 727044 Change-Id: I64e25142632f42144b66f041ad1c9ffb8ae553f5 Reviewed-on: https://chromium-review.googlesource.com/665657 Commit-Queue: Jianpeng Chao <chaopeng@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#509899}
-
Corentin Wallez authored
https://chromium.googlesource.com/angle/angle.git/+log/2d88e9b..d042fba BUG=,chromium:774309 TBR=geofflang@chromium.org TEST=bots CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Merge branch 'master' of https://chromium.googlesource.com/chromium/src gpu/config: Return partial info from angle::GetSystemInfo A filure in angle::GetSystemInfo will still return a gpu info collection failure but partial results will be shown in about:gpu which will help diagnosing problems. BUG=chromium:774748 Change-Id: I000b9f83dc35389beeb14657460baed22ac25daa Reviewed-on: https://chromium-review.googlesource.com/726020Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org> Cr-Commit-Position: refs/heads/master@{#509898}
-
Zentaro Kavanagh authored
- The default is currently that NTLMv2 is disabled (ie. using NTLMv1) - A future release will make the default NTLMv2 enabled. Bug: chromium:22532,chromium:775518 Change-Id: Icb554af932ef1d30b0e9a3cc8cedfea915bd2074 Reviewed-on: https://chromium-review.googlesource.com/673206 Commit-Queue: Zentaro Kavanagh <zentaro@google.com> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Reviewed-by:
Drew Wilson <atwilson@chromium.org> Reviewed-by:
Asanka Herath <asanka@chromium.org> Cr-Commit-Position: refs/heads/master@{#509897}
-
David Reveman authored
Request first frame of user image to avoid animations. Bug: 775988 Test: manual Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I47df758d0ce63f0d1f51cefa1e8d90340ad3ef67 Reviewed-on: https://chromium-review.googlesource.com/726303Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: David Reveman <reveman@chromium.org> Cr-Commit-Position: refs/heads/master@{#509896}
-
Sergey Ulanov authored
Moved audio-processing code that doesn't have dependency on alsa out of chromecast/media/cma/backend/alsa to chromecast/media/cma/backend . This will allow to use this code on other platform that don't use ALSA Bug: 772488 Change-Id: I142557999d7bb0046f8a9de2143a66b1e06ca963 Reviewed-on: https://chromium-review.googlesource.com/716807 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#509895}
-
Dave Tapuska authored
Once WillShutdown is called the InputHandlerProxy object should be destroyed since it is no longer valid. BUG=775483 Change-Id: I3dc1cf7d7295ff08bbcec3d8ee2b12690961af2e Reviewed-on: https://chromium-review.googlesource.com/725860Reviewed-by:
Mustaq Ahmed <mustaq@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#509894}
-
Alex Clarke authored
Bug: Change-Id: I0305f69e2473c4a7d845c8f71a77df9e5d07a04d Reviewed-on: https://chromium-review.googlesource.com/725729Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Alex Clarke <alexclarke@chromium.org> Cr-Commit-Position: refs/heads/master@{#509893}
-
Charlie Andrews authored
TBR=rnephew@chromium.org Bug: 776092 Change-Id: Ie0e1cc1cd0f33adff4ca9049ea181d7e05a3f020 Reviewed-on: https://chromium-review.googlesource.com/726275Reviewed-by:
Charlie Andrews <charliea@chromium.org> Reviewed-by:
rnephew <rnephew@chromium.org> Commit-Queue: Charlie Andrews <charliea@chromium.org> Cr-Commit-Position: refs/heads/master@{#509892}
-
Brian Salomon authored
https://skia.googlesource.com/skia.git/+log/079e50bbdeeb..c4f93cab667b Suppress several layout tests (1 due to apparent swiftshader bug) Rebaseline LayerTreeHostFiltersPixelTest.BackgroundFilterBlurOutsets CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Bug: 775957,775958 Change-Id: I41ff979a446f7410a5caf78db594d5219f84e090 Reviewed-on: https://chromium-review.googlesource.com/726103 Commit-Queue: Brian Salomon <bsalomon@chromium.org> Reviewed-by:
Florin Malita <fmalita@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#509891}
-
Stefan Zager authored
Another batch using the heuristic from: https://chromium-review.googlesource.com/699752 BUG=417782 R=pdr@chromium.org,skobes@chromium.org Change-Id: I2ebb1b05666e5fa55dbb28e61f4f5b283ff9e70b Reviewed-on: https://chromium-review.googlesource.com/726494Reviewed-by:
Steve Kobes <skobes@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#509890}
-
khmel authored
This CL fixes issue when InkDrop animation stays on shelf button after the click. This was due item controller was replaced during the ItemSelected call and calling callback with action back to ash was dropped. Bug: 771655 Test: Manually Change-Id: I8af7dc844a441ada91c4e35b04847a09ebd582db Reviewed-on: https://chromium-review.googlesource.com/724201 Commit-Queue: Yury Khmel <khmel@google.com> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#509889}
-
Mathieu Perreault authored
Changing the method names in anticipation of future change. Moving a class to the implementation Bug: 767931 Change-Id: Id386a7708f05c501c7f44321dfa0b116215118cd Tbr: mahmadi@chromium.org Reviewed-on: https://chromium-review.googlesource.com/726370 Commit-Queue: Mathieu Perreault <mathp@chromium.org> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#509888}
-
Miriam Gershenson authored
Change-Id: I0dda4e286af4f3fde7e6ddc246c10bf6887fb536 Reviewed-on: https://chromium-review.googlesource.com/726021 Commit-Queue: Miriam Gershenson <mgersh@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#509887}
-
Yi Gu authored
We do not need the metric since the experiment of not compositing small scrollers is done. See crbug.com/684631. Bug: 775643 Change-Id: Ieff65345931a35cb278d25a7d574944585907304 Reviewed-on: https://chromium-review.googlesource.com/723675Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#509886}
-
Will Chen authored
This eliminates a lot of the code duplication between the new and legacy integration test frameworks by making security-test.js a small wrapper to load the new security_test_runner modules. I made the old test framework initialization processs sequential (i.e. promise chain) instead of concurrent (i.e. Promise.all(...)) because origin-view-then-interstitial.html test didn't work if the Security module was already loaded before showing the Security panel. I spent a while debugging but couldn't figure out the root cause. Bug: 667560 Change-Id: I74a2a783a5a6e8d81c1e592774928c400131691a Reviewed-on: https://chromium-review.googlesource.com/726367Reviewed-by:
-
smut authored
Bug: 756270 Change-Id: I615a5dba2f50ebadf8a9851fe4e40dce60165392 Reviewed-on: https://chromium-review.googlesource.com/724667Reviewed-by:
Andrii Shyshkalov <tandrii@chromium.org> Cr-Commit-Position: refs/heads/master@{#509884}
-
catapult-deps-roller@chromium.org authored
https://chromium.googlesource.com/catapult.git/+log/75257303afa9..79f62e6c96d8 $ git log 75257303a..79f62e6c9 --date=short --no-merges --format='%ad %ae %s' 2017-10-18 wkorman Reland 'Fetch external images in snap_page.' 2017-10-18 perezju Revert "Fetch external images after processing DOM." 2017-10-18 perezju [Telemetry] On debug mode (-vv) log every subprocess command 2017-10-17 dtu [pinpoint] Handle None values. 2017-10-17 wkorman Fetch external images after processing DOM. Created with: roll-dep src/third_party/catapult Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I220b6ec18fe6273385fbf9a03c86b5a283f02490 Reviewed-on: https://chromium-review.googlesource.com/726323 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#509883}
-
spqchan authored
Refactor SSLErrorHandler by moving the protobuf logic into a new class: SSLErrorAssistant. BUG=773478 Change-Id: I2e72bd4151bee6fe8f406df411c715d65afbaf54 Reviewed-on: https://chromium-review.googlesource.com/696030 Commit-Queue: Sarah Chan <spqchan@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#509882}
-
Sylvain Defresne authored
In preparation of allowing WebStateObserver to observe multiple WebStates, pass the WebState as first parameter to all of the methods of WebStateObserver. Bug: 775684 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I041f66d1bc4a5f905acbf68aafea8b5a11efe306 Reviewed-on: https://chromium-review.googlesource.com/724521 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#509881}
-
Francois Doray authored
s/ThreadRestrictions::ScopedAllowIO allow_io;/ ScopedAllowBlockingForTesting allow_blocking;/ in files that have the word "test" in their path. ThreadRestrictions::ScopedAllowIO instances that are not named |allow_io| are not changed by this CL. TBR=jam@chromium.org Bug: 766678 Change-Id: Ie809d1b39d50c1669cd36399cdfe5657cf072c21 Reviewed-on: https://chromium-review.googlesource.com/718983Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#509880}
-
Vladimir Levin authored
This patch plumbs PaintImage decoding state from recorded paint images to checker image tracker and merges them into a map. R=khushalsagar@chromium.org Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ic6ed4462c82e4ac5917f5d5bc0abdc9df2756150 Reviewed-on: https://chromium-review.googlesource.com/723587 Commit-Queue: vmpstr <vmpstr@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#509879}
-
Xiaohui Chen authored
This is a reland of 6ccb7931 Original change's description: > Fix PAI not delay bug in Assistant runtime setup > > BUG=b:67384302 > TEST=build and flash, disable play, run through assistant OOBE, see > play auto installs are delayed until OOBE finishes. > > Change-Id: I458e06e6131313ef24de375550ebd3dff048fb2b > Reviewed-on: https://chromium-review.googlesource.com/706178 > Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> > Reviewed-by: Luis Hector Chavez <lhchavez@chromium.org> > Reviewed-by: Yury Khmel <khmel@chromium.org> > Cr-Commit-Position: refs/heads/master@{#508772} Bug: b:67384302 Change-Id: Iaa18e6b9544a466d3fada2a745783ae2153aaaa3 Reviewed-on: https://chromium-review.googlesource.com/719500Reviewed-by:
Yury Khmel <khmel@chromium.org> Reviewed-by:
Luis Hector Chavez <lhchavez@chromium.org> Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#509878}
-
Muyuan Li authored
If ARC is not enabled or assistant value prop is not accepted, an "Enable" button will be shown and the runtime flow will be launched if user clicks it. BUG=b:65161403 TEST=manually test by: 1. Disabling play store 2. Clicking "Enable" button in assistant section. Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I7ffba0d8828a4b673504d77dd3512be28da241a5 Reviewed-on: https://chromium-review.googlesource.com/719599 Commit-Queue: Muyuan Li <muyuanli@chromium.org> Reviewed-by:
-
Sylvain Defresne authored
The Tab snapshot should only be deleted when the Tab is closed due to user action (or when the Tab is replaced by another in reaction to user action). In particular, the snapshot should not be deleted when the application is terminated. Change WebStateList CloseWebStateAt to take a flagset allowing to inform the observers whether the Tab was closed due to an action initiated by the user or not and use it to decide whether the Tab snapshot should be deleted or not. Remove global IsShuttingDown() from ApplicationContext. Bug: 753290 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ie626042e0b16215fd44f9631fb4e14f68c015e86 Reviewed-on: https://chromium-review.googlesource.com/723826 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
-
Robert Liao authored
This completes the migration from ScopedComPtr to Microsoft::WRL::ComPtr. BUG=638327 TBR=dcheng@chromium.org Build file change. Change-Id: Iec1047e69dea9913db80cd0cfac50ea36b7fc947 Reviewed-on: https://chromium-review.googlesource.com/726461Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Scott Graham <scottmg@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#509875}
-
Reilly Grant authored
Like mojo-loading, the mojo-blobs virtual test suite is redundant when running LayoutTests on the Network Service builder because the MojoBlobs flag is implied by enabling the Network Service. TBR=jam@chromium.org Bug: 729849 Change-Id: I6a9d1a7ca6a019fff49994d104da0379627f9644 No-Try: true Reviewed-on: https://chromium-review.googlesource.com/726699Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#509874}
-
Hans Wennborg authored
The issue was fixed in Clang r313905, which we rolled past in #508804. TBR=zentaro Bug: 769759 Change-Id: Id6af77871f3696c5d54fa5b9bedc528479096c0b Reviewed-on: https://chromium-review.googlesource.com/724231Reviewed-by:
Hans Wennborg <hans@chromium.org> Reviewed-by:
-
Stephen McGruer authored
This class was only instantiated in tests now, and can be replaced in those tests with TransitionInterpolation. Bug: 725385 Change-Id: I11ae5099bdb8a9596d09c06b75842d142efae37b Reviewed-on: https://chromium-review.googlesource.com/723660 Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#509872}
-
Ryan Sturm authored
See https: //chromium-review.googlesource.com/c/chromium/src/+/720057 Bug: 735991 Change-Id: Ica1181a0102a22d8a29061c5e23e9289551a6f09 Reviewed-on: https://chromium-review.googlesource.com/724141Reviewed-by:
Jian Li <jianli@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#509871}
-
depot-tools-roller@chromium.org authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/f6a588095f8a..e6e0641b1536 $ git log f6a588095..e6e0641b1 --date=short --no-merges --format='%ad %ae %s' 2017-10-18 maruel gclient: print an error message instead of crashing 2017-10-18 machenbach Make authors-check error out instead of warn on commit Created with: roll-dep src/third_party/depot_tools Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls TBR=phajdan.jr@chromium.org Change-Id: Ibd40f5766a5ec716a3965207050cd2bc774f4946 Reviewed-on: https://chromium-review.googlesource.com/726311Reviewed-by:
depot-tools-roller . <depot-tools-roller@chromium.org> Commit-Queue: depot-tools-roller . <depot-tools-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#509870}
-
Robert Ogden authored
Also adds basic framework for a connection emulation server for future use. Bug: 766866 Change-Id: I8c34a80d65cb614f4833d962b9cafbe02b0075b2 Reviewed-on: https://chromium-review.googlesource.com/721696 Commit-Queue: Robert Ogden <robertogden@google.com> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#509869}
-
Yoland Yan authored
This removes ChromeActivityTestCaseBase, ChromeTabbedActivityTestBase, ChromeActivityTestCommon, ChromeTabbedActivityTestCommon. The CL also refactors ChromeActivityTestRule and remove APIs from ChromeTabbedActivityTestRule Bug: 711517 Change-Id: If0ce4acd4859cb01a011f9d1707209b847f75df9 Reviewed-on: https://chromium-review.googlesource.com/722064 Commit-Queue: Yoland Yan <yolandyan@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#509868}
-
Nathan Bruer authored
Fixed a bug if a call to UISourceCode.saveAs() would sometimes save the content of the file as empty if the content has not yet been loaded into the UISourceCode. It should now wait for the content to load if it has not loaded then save the working copy. R=lushnikov,pfeldman BUG=771826 Change-Id: I2d3d3176ea3ab73ec8062a9230860f567244930a Reviewed-on: https://chromium-review.googlesource.com/701625 Commit-Queue: Blaise Bruer <allada@chromium.org> Reviewed-by:
Joel Einbinder <einbinder@chromium.org> Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#509867}
-
Ian Kilpatrick authored
This was something I found yesterday, while looking at the remaining ng-bot failures for the line-by-line patch. We weren't calculating the NGFragment::Offset correctly (impossible without a parent size), so I removed it in favour of: NGPhysicalOffset::ConvertToLogical. Bug: 635619 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I88196b26d6702acf4c3b65a386eba04e2d4d1d33 Reviewed-on: https://chromium-review.googlesource.com/726299 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#509866}
-
