GitLab

Made the 'entry-box' label into a div.
Made the 'time' div into a label and assigned it for the checkbox.
Updated the code that selects the checkbox to prevent introduction of bug
where clicking the row would not toggle the checkbox.

VoiceOver after change:
checkbox: "<history item timestamp> <checked/unchecked> checkbox"
url: "visited link <name of link>"
drop down: "actions pop up button"

The exact words will be different depending on TTS program used,
but should be similar for the controls in the list.

There are no tests uploaded because these changes rely on VoiceOver to validate.

BUG=404870

Review URL: https://codereview.chromium.org/492083002

Cr-Commit-Position: refs/heads/master@{#291274}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291274 0039d316-1c4b-4281-b951-d872f2087c98

mojo/application_manager/application_loader.h #includes a generated
header from mojo_network_bindings. This means any target that uses this
header (and thus depends on application_manager) must declare a hard
dependency on mojo_network_bindings so that the generated header exists
before that target tries to compile. This exports the hard dep (via
gyp's export_dependent_settings) and from other targets with similar needs.

R=viettrungluu@chromium.org

Review URL: https://codereview.chromium.org/496813002

Cr-Commit-Position: refs/heads/master@{#291273}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291273 0039d316-1c4b-4281-b951-d872f2087c98

gyp changes are made to filter out toolkit-views browser_tests that
aren't yet compiled in to a toolkit-views Chrome binary on Mac.

One, WebDialogBrowserTest.SizeWindow, was a disabled test (disabled for
4 years :o). It was preventing browser_tests compiling on MacViews
because it was passing a gfx::NativeWindow to CreateWindowWithParent,
which takes a view.

The parent isn't important for the test - it's just adding widget
context. This CL changes the parent to be web_contents->GetNativeView()
instead so the test compiles.

To ensure nothing breaks, the test needs to be enabled. According to the
comment, the reasons for it being disabled on Windows still seem
relevant. However, on Linux the test was just timing out due to a quirk
of the test. So the quirk is fixed, and WebDialogBrowserTest.SizeWindow
is enabled on Linux Aura.

The test is also enabled on Mac, but currently fails because
NativeViewHost isn't implemented yet. That's coming, and leaving the
test enabled will ensure we check it.

With this change browser_tests compiles and links on toolkit-views Mac.

BUG=404979, 399191, 52602
TEST=browser_tests

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290998

Review URL: https://codereview.chromium.org/486063002

Cr-Commit-Position: refs/heads/master@{#291272}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291272 0039d316-1c4b-4281-b951-d872f2087c98

This moves the Safe Browsing and SSL interstitial HTML/JS into a single new
folder: chrome/browser/resources/security_warnings/. It also moves some
common code out of the SSL-related JS file and into the general interstitial JS
file.

BUG=402540

Review URL: https://codereview.chromium.org/480393002

Cr-Commit-Position: refs/heads/master@{#291270}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291270 0039d316-1c4b-4281-b951-d872f2087c98

The rollback tests now listen to both the ProfileSyncService state as well as
for the completion of the browsing data remover. The shutdown observer now
also listens directly to the ProfileSyncService, rather than polling every
second.

BUG=406005

Review URL: https://codereview.chromium.org/483883003

Cr-Commit-Position: refs/heads/master@{#291269}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291269 0039d316-1c4b-4281-b951-d872f2087c98

BUG=395376

Review URL: https://codereview.chromium.org/495213002

Cr-Commit-Position: refs/heads/master@{#291268}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291268 0039d316-1c4b-4281-b951-d872f2087c98

Disable PluginTest.VerifyNPObjectLifetimeTest and PluginTest.CreateInstanceInPaint since they're flaking.

BUG=406184
TBR=avi@chromium.org

Review URL: https://codereview.chromium.org/494243003

Cr-Commit-Position: refs/heads/master@{#291267}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291267 0039d316-1c4b-4281-b951-d872f2087c98

It's not used anywhere.

BUG=399506

Review URL: https://codereview.chromium.org/438843002

Cr-Commit-Position: refs/heads/master@{#291266}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291266 0039d316-1c4b-4281-b951-d872f2087c98

BUG=405985
R=rogerta@chromium.org

Review URL: https://codereview.chromium.org/496753002

Cr-Commit-Position: refs/heads/master@{#291264}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291264 0039d316-1c4b-4281-b951-d872f2087c98

This CL is one part of the effort to change chrome to use gaiaid instead of
email address as the unique id for an account.

BUG=341408

Review URL: https://codereview.chromium.org/425823002

Cr-Commit-Position: refs/heads/master@{#291263}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291263 0039d316-1c4b-4281-b951-d872f2087c98

These files aren't used or referenced anywhere, delete them.

Review URL: https://codereview.chromium.org/495203002

Cr-Commit-Position: refs/heads/master@{#291262}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291262 0039d316-1c4b-4281-b951-d872f2087c98

This CL exposes a much simpler content/public method:
void RenderView::AttachToBrowserPlugin(blink::WebNode&)

This removes BrowserPlugin's usage of NPAPI method bindings.
This will hopefully help us move towards using OOPIFs.

BUG=330264

Review URL: https://codereview.chromium.org/444813002

Cr-Commit-Position: refs/heads/master@{#291261}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291261 0039d316-1c4b-4281-b951-d872f2087c98

If the Avatar Bubble (profile chooser) is open and the Avatar Button
is clicked, the bubble should disappear.

BUG=402014

Review URL: https://codereview.chromium.org/488253002

Cr-Commit-Position: refs/heads/master@{#291260}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291260 0039d316-1c4b-4281-b951-d872f2087c98

Cr-Commit-Position: refs/heads/master@{#291259}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291259 0039d316-1c4b-4281-b951-d872f2087c98

Two things going wrong:
- the Windows new avatar button wasn't listening to avatar changes, so
its display would be out of sync with the avatar bubble
- when saving the avatar photo, this was also considered a name save
(even though the name wouldn't change), which made the default name an
explicit user decision (which it wasn't)

BUG=405750

Review URL: https://codereview.chromium.org/493113002

Cr-Commit-Position: refs/heads/master@{#291258}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291258 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=180709:180728&mode=html
TBR=dglazkov@chromium.org,wibling@chromium.org
BUG=

Review URL: https://codereview.chromium.org/493193002

Cr-Commit-Position: refs/heads/master@{#291257}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291257 0039d316-1c4b-4281-b951-d872f2087c98

Currently, the .cc is included in multiple targets. In incremental builds this results in errors like:

[609->8104/8713 ~0] LINK_EMBED unit_tests.exe
FAILED: d:\src\depot_tools\python276_bin\python.exe gyp-win-tool link-with-manifests environment.x86 True unit_tests.exe "d:\src\depot_tools\python276_bin\python.exe gyp-win-tool link-wrapper environment.x86 False link.exe /nologo /OUT:unit_tests.exe @unit_tests.exe.rsp" 1 mt.exe rc.exe "obj\chrome\unit_tests.unit_tests.exe.intermediate.manifest" obj\chrome\unit_tests.unit_tests.exe.generated.manifest ..\..\build\win\compatibility.manifest
content_app_both.startup_helper_win.obj : error LNK2005: "void __cdecl content::InitializeSandboxInfo(struct sandbox::SandboxInterfaceInfo *)" (?InitializeSandboxInfo@content@@YAXPAUSandboxInterfaceInfo@sandbox@@@Z) already defined in test_support_content.startup_helper_win.obj
content_app_both.startup_helper_win.obj : error LNK2005: "void __cdecl `anonymous namespace'::InvalidParameter(wchar_t const *,wchar_t const *,wchar_t const *,unsigned int,unsigned int)" (?InvalidParameter@?A0xc496daa2@@YAXPB_W00II@Z) already defined in test_support_content.startup_helper_win.obj
content_app_both.startup_helper_win.obj : error LNK2005: "void __cdecl `anonymous namespace'::PureCall(void)" (?PureCall@?A0xc496daa2@@YAXXZ) already defined in test_support_content.startup_helper_win.obj
content_app_both.startup_helper_win.obj : error LNK2005: "void __cdecl content::RegisterInvalidParamHandler(void)" (?RegisterInvalidParamHandler@content@@YAXXZ) already defined in test_support_content.startup_helper_win.obj
content_app_both.startup_helper_win.obj : error LNK2005: "void __cdecl content::SetupCRT(class base::CommandLine const &)" (?SetupCRT@content@@YAXABVCommandLine@base@@@Z) already defined in test_support_content.startup_helper_win.obj
unit_tests.exe : fatal error LNK1169: one or more multiply defined symbols found

when incremental_chrome_dll=1 used in Release build.

By putting the .cc in a static_library target and depending on it as necessary, rather than including the .cc into multiple places, this is avoided.

R=jam@chromium.org
TBR=sky@chromium.org
BUG=404809

Review URL: https://codereview.chromium.org/470523005

Cr-Commit-Position: refs/heads/master@{#291256}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291256 0039d316-1c4b-4281-b951-d872f2087c98

Previously our handling of ignored touches would put the gesture recognizer into a very confused state.

BUG=405519
TEST=GestureRecognizerTest.IgnoredEventsDontPreventFutureEvents

Review URL: https://codereview.chromium.org/489213003

Cr-Commit-Position: refs/heads/master@{#291255}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291255 0039d316-1c4b-4281-b951-d872f2087c98

BUG=394869

Review URL: https://codereview.chromium.org/488163003

Cr-Commit-Position: refs/heads/master@{#291254}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291254 0039d316-1c4b-4281-b951-d872f2087c98

Cr-Commit-Position: refs/heads/master@{#291253}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291253 0039d316-1c4b-4281-b951-d872f2087c98

TBR=nduca@chromium.org

Review URL: https://codereview.chromium.org/489243002

Cr-Commit-Position: refs/heads/master@{#291252}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291252 0039d316-1c4b-4281-b951-d872f2087c98

Also removed dependent switches --disable-scripted-print-throttling and --renderer-print-preview.

BUG=374321

Review URL: https://codereview.chromium.org/488853002

Cr-Commit-Position: refs/heads/master@{#291251}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291251 0039d316-1c4b-4281-b951-d872f2087c98

Now is up to the component embedding the SystemInfo API to implement
the DisplayInfoProvider. The motivation for this change is we want to
move the SystemInfo API to extensions/ but DisplayInfoProvider depends
on ash/, which will link with ui/views/, and that is way too big.

The ultimate goal is to have SystemInfo on the app_shell without increasing its
footprint considerably.

BUG=392842

Review URL: https://codereview.chromium.org/476103002

Cr-Commit-Position: refs/heads/master@{#291250}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291250 0039d316-1c4b-4281-b951-d872f2087c98

Add unittest that fails crbug/399671 but pass with the fix.

BUG=399671

Review URL: https://codereview.chromium.org/488763004

Cr-Commit-Position: refs/heads/master@{#291249}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291249 0039d316-1c4b-4281-b951-d872f2087c98

Previously, we flattened all the iterations and reported one number. Now we
report the geo mean of each iteration so that the dashboard can display the
stddev.

BUG=405719

Review URL: https://codereview.chromium.org/493153002

Cr-Commit-Position: refs/heads/master@{#291248}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291248 0039d316-1c4b-4281-b951-d872f2087c98

While we're here, remove silly DCHECKs on pointers that are
dereferenced in the next line anyway.

R=asanka@chromium.org,jsbell@chromium.org
TBR=falken@chromium.org,dominicc@chromium.org
BUG=None

Review URL: https://codereview.chromium.org/461343006

Cr-Commit-Position: refs/heads/master@{#291247}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291247 0039d316-1c4b-4281-b951-d872f2087c98

BUG=401180

Review URL: https://codereview.chromium.org/461043003

Cr-Commit-Position: refs/heads/master@{#291246}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291246 0039d316-1c4b-4281-b951-d872f2087c98

BUG=387122
TEST=none
R=keybuk@chromium.org

Review URL: https://codereview.chromium.org/495763004

Cr-Commit-Position: refs/heads/master@{#291245}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291245 0039d316-1c4b-4281-b951-d872f2087c98

BUG=393873
R=dbeam@chromium.org
TEST=gyp --depth . third_party/closure_compiler/compiled_resources.gyp && ninja -C out/Default

Review URL: https://codereview.chromium.org/490213003

Cr-Commit-Position: refs/heads/master@{#291244}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291244 0039d316-1c4b-4281-b951-d872f2087c98

BUG=393873
R=dbeam@chromium.org
TEST=./third_party/closure_compiler/runner/build_runner_jar.py && gyp --depth . chrome/browser/resources/history/compiled_resources.gyp && ninja -C out/Default

Review URL: https://codereview.chromium.org/454223004

Cr-Commit-Position: refs/heads/master@{#291243}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291243 0039d316-1c4b-4281-b951-d872f2087c98

We don't draw layers with non-invertible transforms, so this check is
a waste. Especially in the case where we don't even use the inverse
transform.

R=enne

Review URL: https://codereview.chromium.org/492953002

Cr-Commit-Position: refs/heads/master@{#291242}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291242 0039d316-1c4b-4281-b951-d872f2087c98

Extension options pages often have links to external pages as well as
internal extension pages. When embedded in an <extensionoptions> element
open external links in a new tab, and internal links in the embedded
view (unless specified otherwise).

BUG=386838

Review URL: https://codereview.chromium.org/471053003

Cr-Commit-Position: refs/heads/master@{#291241}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291241 0039d316-1c4b-4281-b951-d872f2087c98

BUG=359249

Review URL: https://codereview.chromium.org/465713002

Cr-Commit-Position: refs/heads/master@{#291240}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291240 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/491733002

Cr-Commit-Position: refs/heads/master@{#291238}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291238 0039d316-1c4b-4281-b951-d872f2087c98

Adding support for PpapiHostMessage_OpenResource to SFI mode is tricky.
Validating the file tokens requires that a message to be sent to the browser
(!) to validate that information in the case of a compromised renderer.

This change is one step to allowing processing for the reply of the
PpapiHostMessage_OpenResource message to send a message to the browser for
constructing a NaClDesc properly.

This makes the encapsulation of NaClMessageScanner a bit worse, but also
reduces the amount of code for which the critical section under lock_ must be
held.

BUG=394130

Review URL: https://codereview.chromium.org/472073003

Cr-Commit-Position: refs/heads/master@{#291234}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291234 0039d316-1c4b-4281-b951-d872f2087c98

Delaying launch of multi-profile for managed accounts to M38, so setting
the default policy to "not-allowed".

BUG=405983

Review URL: https://codereview.chromium.org/469003010

Cr-Commit-Position: refs/heads/master@{#291233}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291233 0039d316-1c4b-4281-b951-d872f2087c98

(Chrome part).
This patch adds code for removing spelling markers under words on 
chrome's side.

BUG=3506

Review URL: https://codereview.chromium.org/411393004

Cr-Commit-Position: refs/heads/master@{#291232}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291232 0039d316-1c4b-4281-b951-d872f2087c98

BUG=405950

Review URL: https://codereview.chromium.org/495123002

Cr-Commit-Position: refs/heads/master@{#291231}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291231 0039d316-1c4b-4281-b951-d872f2087c98

Adjusted DS2784PowerMonitor, DumpsysPowerMonitor, and MonsoonPowerMonitor 
to extend SysfsPowerMonitor to get CPU data. Also cleaned up a little bit
of SysfsPowerMonitor.

BUG=

Review URL: https://codereview.chromium.org/470803006

Cr-Commit-Position: refs/heads/master@{#291230}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291230 0039d316-1c4b-4281-b951-d872f2087c98

BUG=405682

Review URL: https://codereview.chromium.org/495723002

Cr-Commit-Position: refs/heads/master@{#291228}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291228 0039d316-1c4b-4281-b951-d872f2087c98