- 06 Mar, 2020 40 commits
-
-
Yuichiro Hanada authored
It can happen that KeyboardUIController notifies the old bounds of the virtual keyboard if the call of ShowKeyboard() is followed by HideKeyboard*(). A tast integration test will be added for this case in a follow up CL. Bug: b/148483295 Change-Id: I3222852532f7c0bb685a75d0bb0888cbddc44a5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089195Reviewed-by:
Darren Shen <shend@chromium.org> Commit-Queue: Yuichiro Hanada <yhanada@chromium.org> Cr-Commit-Position: refs/heads/master@{#747555}
-
Brad Huang authored
Add a new routine, floating_point_accuracy. This routine executes millions of floating-point operations within a desired time period, the result must match expected result. Bug: b:146513388 Test: chromeos_unittests --gtest_filter=CrosHealthdServiceConnectionTest.* unit_tests --gtest_filter=DeviceCommandRunRoutineJobTest.* Change-Id: I9bcb7eaf938da3ecd6fecfab0f2cfe57ef3fbb23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2045291 Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Reviewed-by:Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Victor-Gabriel Savu <vsavu@google.com> Reviewed-by:
Oleh Lamzin <lamzin@google.com> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Paul Moy <pmoy@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#747554}
-
Jeff Yoon authored
There are a lot of variants that are repeatedly defined. To minimize duplication in test_suites.pyl, and to keep it readable, I've extracted the definitions into a variants.pyl. All variants defined as a string will look for a reference in variants.pyl. Change-Id: I5bfc206ead0fd10c3d497d6557761c2795ba76f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090871 Commit-Queue: Jeff Yoon <jeffyoon@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#747553}
-
Toni Barzic authored
Shelf config change may cause hotseat state change, so we should update the hotseat state (which is done in ShelfLayoutManager::SetState) when the shelf config changes, otherwise, the hotseat state change may lag behind the shelf layout change. For example, layout may hide the opaque shelf background if config changes to non-in-app shelf, and animating background animation starts when the hotseat state changes. So, if the hotseat state change lags after the shelf layout change for long enough, we might see a flash of animating shelf background after the opaque shelf background has been hidden. This was noticed while implementing swipe to overview/home with VK shown (when swiping to go home, the animating shelf would occasionally pop up with a delay) - added a test for sequence of events in that case. (Note that this means that the hotseat state may get calculated before app list visibility on tablet mode change, so add back logic that moved hotseat in kShownHomeLauncher state if the home should be visible at that point in time). BUG=b:145704293 Change-Id: I4e6ce883eed8674159b03c25336fd82c9d20c50d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090757 Commit-Queue: Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Manu Cornet <manucornet@chromium.org> Cr-Commit-Position: refs/heads/master@{#747552}
-
dalyk authored
The phrase "Network Sign-in" will be included in the window title to indicate the purpose of these windows. The position of the phrase depends on the platform so that existing window title formatting patterns are preserved. Bug: 10161646 Change-Id: If49bb5fef304346488cb56cf11d5a043ccb473c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2081333 Commit-Queue: Katharine Daly <dalyk@google.com> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#747551}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 07febed2. With Chromium commits locally applied on WPT: d5cd6b98 "SharedWorker: Assign unique names to SharedWorkers to avoid unintentional matching" acf33020 "Add testing for the scrolling attribute" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=smcgruer No-Export: true Change-Id: If053e9a9f8ddbca028783daa57f77ac8030b7586 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089718Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#747550}
-
Avi Drissman authored
BUG=1058951 Change-Id: Ic214033241655ac1653810fe78bfa92376c629fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089998Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#747549}
-
Darwin Huang authored
Add huangdarwin@ and dcheng@ to OWNERS and specify TEAM for triage/emails. As per `git log --oneline --author=huangdarwin@chromium.org ui/base/dragdrop`, huangdarwin@ has 10 CLs in ui/base/dragdrop. As per `git log --oneline --author=dcheng@chromium.org ui/base/dragdrop`, dcheng@ has 22 CLs in ui/base/dragdrop. Change-Id: I39bafac9a350a02e5edbddfa9786e5f4aabe5a6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088647Reviewed-by:
-
Peng Huang authored
The problem is because the original vulkan helper template methods pull types from arguments. So when a vulkan template method is called with VK_NULL_HANDLE like: VkQueueSubmit(device, count, subbmits, VK_NULL_HANDLE) The VK_NULL_HANDLE is defined as 0, so the template pulls the type int from VK_NULL_HANDLE, and then uses the int to call VkQueueSubmit function pointer. The compile can not cast an int to VKFence, so error is reported. This CL fixes the problem by pulling arg types from vulkan function type defined in vulkan header file instead of using arg type from where the template method is called. Bug: 1058616 Change-Id: Iec8ab990df7dd32985c0d840d49fbf81c710a09d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088832Reviewed-by:
Michael Spang <spang@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Auto-Submit: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#747547}
-
Darwin Huang authored
Bug: 897289 Change-Id: I26335e58672e915a452dc6ae04dac6d712ccac6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090914 Auto-Submit: Darwin Huang <huangdarwin@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#747546}
-
Mustafa Emre Acer authored
This CL changes the IDN lookalike logic to use the Safety Tip config proto to allowlist sites. We currently don't have an allowlist mechanism and there have been cases where it would be useful. The CL uses the |allowed_pattern| field in safety_tips.proto. This is shared with Safety Tips, so a pattern added to this field will cause a to not show a lookalike interstitial or a safety tip. The IDN lookalike logic operates on eTLD+1 only, so any pattern targeting the interstitial should only contain eTLD+1. Bug: 1056755 Change-Id: I65e856eb118b0d20dd366fc0d09a95def1a5ab1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082904Reviewed-by:
Joe DeBlasio <jdeblasio@chromium.org> Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#747545}
-
Wenyu Fu authored
Mockito does not work for some of the bots for unknown reason so that policy related tests in HomepageSettingsFragmentTest all failed. Changing HomepageTestRule and use AppRestrictionProvider to provide test policy settings; re-enabling those tests to strengthen our test coverage. Bug: 1049557 Change-Id: I93514c020498d9b26c53b2c3f76cf819bd0bba7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2047353 Commit-Queue: Theresa <twellington@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#747544}
-
Maggie Cai authored
This reverts commit 5d31525d. Reason for revert: This CL causes build failure for https://ci.chromium.org/p/chromium/builders/ci/Linux%20ASan%20LSan%20Tests%20%281%29/73445 and https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-dbg/17413 Original change's description: > Add more unit tests for url_lookup_service. > > Add tests for the StartLookup method. > > Bug: 1050859 > Change-Id: Idfc261cdd5fbc75d359cfa40b0be5621e57f8c0d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2086812 > Reviewed-by: Daniel Rubery <drubery@chromium.org> > Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#747497} TBR=drubery@chromium.org,xinghuilu@chromium.org Change-Id: Iea165caa159779b08ffe42fa245b39bcf4fd6d89 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1050859 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089440Reviewed-by:
Maggie Cai <mxcai@chromium.org> Commit-Queue: Maggie Cai <mxcai@chromium.org> Cr-Commit-Position: refs/heads/master@{#747543}
-
Maggie Cai authored
This reverts commit e2ff113c. Reason for revert: This CL makes mac-builder-perf build flaky and continusly have compile error. Original change's description: > Roll src/third_party/swiftshader a095711c5d77..51b2800bb317 (1 commits) > > https://swiftshader.googlesource.com/SwiftShader.git/+log/a095711c5d77..51b2800bb317 > > git log a095711c5d77..51b2800bb317 --date=short --first-parent --format='%ad %ae %s' > 2020-03-05 capn@google.com Support launching PowerVR samples from Visual Studio using SwiftShader > > Created with: > gclient setdep -r src/third_party/swiftshader@51b2800bb317 > > If this roll has caused a breakage, revert this CL and stop the roller > using the controls here: > https://autoroll.skia.org/r/swiftshader-chromium-autoroll > Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human > is aware of the problem. > > To report a problem with the AutoRoller itself, please file a bug: > https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug > > Documentation for the AutoRoller is here: > https://skia.googlesource.com/buildbot/+/master/autoroll/README.md > > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel > Bug: None > Tbr: swiftshader-team+autoroll@google.com > Change-Id: Ie79b6461aa9c2c778cdedb03e51f6d3d7bc8383f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090076 > Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#747352} TBR=chromium-autoroll@skia-public.iam.gserviceaccount.com,swiftshader-team+autoroll@google.com Change-Id: Ic1b18034af1867e7bc26a075d2bb98f9320c8f41 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: None Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090991Reviewed-by:
-
Alex Kalugin authored
WeakPtr functionality was improperly used in WeakPtrs from this factory was checked on another thread. This could lead to DCHECK failure in WeakPtrFactory d-tor. InProcessUtilityThreadHelper: WeakPtrFactory lived on one thread and Change-Id: I0fdb9a584853bee7dba417c951d99c2f0ec85026 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2086114Reviewed-by:
-
Mohamed Heikal authored
This rolls in the new version 3.11.4 of the protobuf javalite runtime. The package name changed so this also fixes all references in gn files. A similar internal commit exists at crrev.com/i/1676922 This also changes how protoc is called to ask for the java lite runtime. The protoc javalite code gen plugin is no longer needed and will be removed in a followup cl. but reduces them per generated proto. Binary-Size: new runtime increases the number of methods in the runtime Bug: 988512 Change-Id: I8dd2ba97badea0b7dbaa8282afeb1da40636aee5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762684 Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Reviewed-by:Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Reviewed-by:
-
Mei Liang authored
Before this change, after changing StartSurface variation with a local debug build, Chrome crashes during restart with the following error: chromium: [FATAL:feature_list.cc(185)] Check failed:!Contains(overrides_, feature_name) || !overrides_.find(feature_name)->second.field_trial. Feature StartSurfaceAndroid has conflicting field trial overrides: StartSurfaceAndroid / ChromeStart This CL fixes the crash, and updates the log message to be more specific. Change-Id: I0f4dedb43c9fd12133e363375a8de5a0cb3eb3e8 Bug: 1059081 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083855 Commit-Queue: Mei Liang <meiliang@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#747539}
-
Eric Willigers authored
We now use nullptr instead of null https://google.github.io/styleguide/cppguide.html#0_and_nullptr/NULL Change-Id: If1dfab9f77ca09f3d5a5cbe922646886d7517ec0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089186 Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#747538}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/2e60acad147c..b3bfbaa3217f git log 2e60acad147c..b3bfbaa3217f --date=short --first-parent --format='%ad %ae %s' 2020-03-05 bsheedy@chromium.org Fix CrOS minidump pulling on certain devices Created with: gclient setdep -r src/third_party/catapult@b3bfbaa3217f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC wenbinzhang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1055225 Tbr: wenbinzhang@google.com Change-Id: I51fb92d8080442e97c69005496c94b6e333782d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090633Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#747537}
-
dalyk authored
We want to be able to rollout the secure DNS setting independently from the privacy page redesign rollout. Bug: 1040145 Change-Id: Iaf9b5e6a7ee5e4b6da442bd10e0107b569f122aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090096Reviewed-by:
dpapad <dpapad@chromium.org> Commit-Queue: Katharine Daly <dalyk@google.com> Cr-Commit-Position: refs/heads/master@{#747536}
-
Daniel Rubery authored
The Chrome Safe Browsing team depends on these metrics for continuous measurement of the effectiveness of download warnings, so we should own them. This CL takes ownership of them, extends the expiry, and re-implements Download.DangerousFile.DangerousDownloadValidated, this time using the Safe Browsing enum so we don't need to maintain a separate enum within component/download/ Bug: 1053772 Change-Id: If9bb9539b02560484295af462c3bf0b842eb9bcb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2081268 Commit-Queue: Daniel Rubery <drubery@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Xinghui Lu <xinghuilu@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#747535}
-
Alexander Timin authored
We do not and should not use kNavigation task type. Remove it to eliminate the risk of the potential misuse. R=nasko@chromium.org,gab@chromium.org Change-Id: I900a7115224a6ca431167a3698e11ea6bd1ed180 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063021Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Alexander Timin <altimin@chromium.org> Auto-Submit: Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#747534}
-
Aga Wronska authored
Add new method that returns current time limit for the app. Rename interface to reflect that it does not only apply to web time limits. AppService needs the information about current time limit to display the paused dialog when user clicks paused app's icon. AppService is already using the interface to communicate with AppTime component. Bug: 1056466 Test: AppActvitiyRegistryTest Change-Id: I4c663387a26d256f3c66b9ae5efaecc2f25b1725 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2086264Reviewed-by:
Yilkal Abe <yilkal@chromium.org> Reviewed-by:
-
Chong Gu authored
Bug: 1058255 Change-Id: Ic42f11923c0426d62e7274d908dd8e872dce154d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090627Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Chong Gu <chonggu@google.com> Cr-Commit-Position: refs/heads/master@{#747532}
-
Marijn Kruisselbrink authored
Also enabled the new permission model by default, as that is what we want to ship in M82. Bug: 984769 Change-Id: Iaa73376cdf893a2bb7c7f3e42336f8a2675c3609 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090600Reviewed-by:
Olivier Yiptong <oyiptong@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#747531}
-
Scott Violet authored
This makes block flow's line-clamp handling correctly add ellipsis when if clamping happens on a line where are the text fits, but there are subsequent lines. Common case for this is when using 'white-space:pre'. This does not give the exact same behavior as old. In particular, external/wpt/css/css-overflow/webkit-line-clamp-008.html is an example of a case that now renders differently (nested divs). See https://test-results.appspot.com/data/layout_results/mac-rel/302753/webkit_layout_tests%20%28with%20patch%29/layout-test-results/results.html for the set of failures. BUG=none Change-Id: Ie188d5b3efc1817377f7ba5523815ba6bdc4a986 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050093 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#747530}
-
Jason Lin authored
Bug: 1055647 Change-Id: I7a7f197b18979bfd885a79c2fc2f96c665b8d6f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089188 Auto-Submit: Jason Lin <lxj@google.com> Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#747529}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/56f1678437ba..1d54767364a8 git log 56f1678437ba..1d54767364a8 --date=short --first-parent --format='%ad %ae %s' 2020-03-05 natlee@microsoft.com Query if Texture subresource has been initialized Created with: gclient setdep -r src/third_party/dawn@1d54767364a8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: chromium:1036080 Tbr: cwallez@google.com Change-Id: I8b7fbf64e6730ff6f1b751f030e336319ecbfc2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090634Reviewed-by:
-
Behnood Momenzadeh authored
Bug: 1037049 Change-Id: I51bcdd26a6f5551a661f0c974c48b1f44709c009 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090721 Auto-Submit: Behnood Momenzadeh <behnoodm@google.com> Reviewed-by:
Christopher Thompson <cthomp@chromium.org> Reviewed-by:
-
Josh Simmons authored
Treat video files on DriveFS as if they were local when launching Quick View. This results in auto-play (where the media is decodable). DriveFS streams large files so if the user cancels / pauses the playback there will not be unnecessary data transferred. Bug: 1059072 Test: browser_tests --gtest_filter="openQuickViewVideoOnDrive" Change-Id: I0bd6020acdaad8980c7fcf6f48891389d20e8a27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089439Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Commit-Queue: Josh Simmons <simmonsjosh@google.com> Cr-Commit-Position: refs/heads/master@{#747526}
-
Victor Hugo Vianna Silva authored
The feature has been successfully launched, so this CL removes it and cleans up HistoryUiFaviconRequestHandler. In particular, it: eliminates plumbing that was needed for feature experimentation; removes unit tests checking the influence of "field trial parameters" of the feature; updates the class documentation to remove mentions to the feature. Sync code is still exercised if user settings do not allow querying the favicon server, as before. Bug: 978775 Change-Id: Ibf474014f0f0a845c150c5ad64d2f13c72782493 Fixed: 978775 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2085374 Commit-Queue: Victor Vianna <victorvianna@google.com> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#747525}
-
yilkal authored
This CL corrrects the blocking page ui for websites for web time limit. This CL also corrects an error in web_time_limit_navigation_throttle.cc where a nullptr browser is being dereferenced. Bug: 1056480 Change-Id: I5b8b0ce29718015d26cb983e865c3d08238d0d56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079857 Commit-Queue: Yilkal Abe <yilkal@chromium.org> Reviewed-by:
Aga Wronska <agawronska@chromium.org> Cr-Commit-Position: refs/heads/master@{#747524}
-
Jun Cai authored
This CL converts base::Bind and base::Callback in //ppapi/tests to Once or Repeating Bug: 1007818 Change-Id: I0613c200a4e5a7fe397bdf9d49193c7d2ea45066 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083382Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/55228e53750d..9acaf6626042 git log 55228e53750d..9acaf6626042 --date=short --first-parent --format='%ad %ae %s' 2020-03-05 jmadill@chromium.org Add timer query support to TracePerfTests. Created with: gclient setdep -r src/third_party/angle@9acaf6626042 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: ianelliott@google.com Change-Id: I1baccdcd91af2877a27e5e927799182bbbcf9b06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090638Reviewed-by:
-
Mike Wittman authored
Adds an interface to allow unwinders to update the modules they're responsible for in the ModuleCache at each sample, prior to unwinding. To be used by the V8 unwinder after updating to the new V8 async unwinding API, to update its current set of modules after they are recorded in OnStackCapture(). Bug: 1035855 Change-Id: If6fb08fb91323d748facab0557e02a8f2a971c5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2086297 Commit-Queue: Mike Wittman <wittman@chromium.org> Reviewed-by:
Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#747521}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/456f9b5fe9d2..8c1ae63310cb git log 456f9b5fe9d2..8c1ae63310cb --date=short --first-parent --format='%ad %ae %s' 2020-03-05 reed@google.com simplify SkDraw by passing down SkVertices as a whole 2020-03-05 mtklein@google.com re-enable fnma 2020-03-05 reed@google.com remove bone variant of drawVertices (unsupported) 2020-03-05 mtklein@google.com disable fnma peephole 2020-03-05 mtklein@google.com print colors which fail the asserts when they do 2020-03-05 csmartdalton@google.com Change the argument ordering for GrOpsRenderPass::bindTextures Created with: gclient setdep -r src/third_party/skia@8c1ae63310cb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC herb@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: herb@google.com Change-Id: Id187271d35332f6bca92b914ae2a6005df6f61f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090636Reviewed-by:
-
Ted Choc authored
Mark MobileStartup.ColdStartupIntent obsolete. Extend MobileStartup.DailyLaunchCount and MobileStartup.LaunchType. LaunchType is being used for analysis right now, and DailyLaunchCount is a good durable proxy for whether we're seeing additional engagement. BUG=1055427,1053055 Change-Id: I8ac1d0851f490c1b0b06ce9255f87b560410f8de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087425 Commit-Queue: Ted Choc <tedchoc@chromium.org> Reviewed-by:
-
Clark DuVall authored
This file was added in http://crrev.com/c/2083714. This fixes the tools/translation/upload_screenshots.py tool. Bug: 1025609 Change-Id: I5c70e17ecc0e264b56f965108063efaa8316ee1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090712 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
-
Torne (Richard Coles) authored
Change how extra headers provided through loadUrl(url, extra_headers) are handled in WebView: 1) Remove any extra headers from the request if the request is redirected to a different origin, since they might be sensitive. 2) Don't attempt to add any extra headers for the redirect target URL when we encounter a redirect; this is likely to be surprising and unwanted. 3) Record metrics on when we add headers and what was done with them on redirect. 4) Add an additional test verifying that the extra headers are cleared if the app loads the same URL again via loadUrl(url). Bug: 1038002 Change-Id: Ib39e2938f7b76d212cd20773aab56da138088b63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1999229Reviewed-by:
Tobias Sargeant <tobiasjs@chromium.org> Commit-Queue: Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#747517}
-
Brandon Tolsch authored
This reverts commit c401a7d6. Reason for revert: Added test fails on Mac 10.12 and 10.14 Original change's description: > [tbmv3] Add an integration test for run_tbmv3_metric > > Adding a simple smoke test to make sure run_tbmv3_metric does not break > silently. > > Change-Id: I54f4d525e221eef403678034efde505ee19cbc1e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078736 > Reviewed-by: Caleb Rouleau <crouleau@chromium.org> > Reviewed-by: Deep Roy <dproy@chromium.org> > Reviewed-by: Mikhail Khokhlov <khokhlov@google.com> > Commit-Queue: Deep Roy <dproy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#747385} Bug: 1059109 TBR=crouleau@chromium.org,dproy@chromium.org,khokhlov@google.com Change-Id: I390c1e121e7dc26cb7d9b16af89c772afc0b623a No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090361Reviewed-by:
Brandon Tolsch <btolsch@chromium.org> Commit-Queue: Brandon Tolsch <btolsch@chromium.org> Cr-Commit-Position: refs/heads/master@{#747516}
-
