- 10 Oct, 2019 40 commits
-
-
Dominic Mazzoni authored
Bug: none Change-Id: Ifee79eca593238e0f85cd2d5d4b07ea98c9e256b Tbr: aleventhal@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1852419Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#704742}
-
Erik Chen authored
This CL is a refactor with no behavior change. In the future, undead RenderWidgets won't exist. By returning nullptr, we prevent accidentally uses from cropping up. Bug: 419087 Change-Id: Ie71c7c818921f1d0a464003e69d6cf267f8fe3fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1850575Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Auto-Submit: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#704741}
-
Steven Bennetts authored
This CL uses a unuion for type specific properties in ConfigProperties. Since the config properties are typically generated on the fly and passed from UI -> the CrosNetworkConfig implementation, the union type is used to specify the network type (i.e. no explicit type is required). Bug: 853953 Change-Id: I08ae054f8d5554727c4d9422ca325b284c3927e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1850724 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#704740}
-
David Benjamin authored
It was only used by tests at this point. Bug: 340460 Change-Id: I1a52c17d439bfb5a198a908aee0fe7600bb7845d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846468Reviewed-by:
Matt Mueller <mattm@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Auto-Submit: David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#704739}
-
Aaron Krajeski authored
This mostly means that we need to be more explicit about when we finalize frame. This is covered in prior CLs: https://chromium-review.googlesource.com/c/chromium/src/+/1848934 https://chromium-review.googlesource.com/c/chromium/src/+/1814457 Next step is to create a CanvasDeferral class that mixes in to the generic CanvasRenderingContext class and manages deferral for all types of canvases. Also, finding a way to get write pixels within deferral by using putImageData would be nice. Bug: 1002523 Change-Id: Ia5aa50e3082177df1f422d14fc7899f8d173a874 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762467 Commit-Queue: Aaron Krajeski <aaronhk@chromium.org> Commit-Queue: Fernando Serboncini <fserb@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/master@{#704738}
-
Yuwei Huang authored
Chromoting is now fully on FTL signaling, so this CL removes LCS support in SignalingAddress and cleans up the code. We can't remove XMPP yet since IT2ME still uses it to communicate with the website. Bug: 983282 Change-Id: I6d1a6d110a7f04ad28e963e7ab7c31c8bcc707be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1851226Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Commit-Queue: Yuwei Huang <yuweih@chromium.org> Cr-Commit-Position: refs/heads/master@{#704737}
-
Ian Wells authored
Bug: 1001506 Change-Id: Ice31c3588d42038ebe7728739189e69710557dc9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815084Reviewed-by:
Peter Williamson <petewil@chromium.org> Commit-Queue: Ian Wells <iwells@chromium.org> Cr-Commit-Position: refs/heads/master@{#704736}
-
Yun Liu authored
Bug: 985581 Change-Id: I53edb1be6c0761e0f52868119576c7dff6b2a3c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1850737Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Yun Liu <yliuyliu@google.com> Cr-Commit-Position: refs/heads/master@{#704735}
-
Adrienne Walker authored
This code is currently in content/browser/loader but is useful to other features. Bug: 1012869 Change-Id: Ie129d975d0d381f2ec8e98670efc8ed52c39d40a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848055Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: enne <enne@chromium.org> Auto-Submit: enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#704734}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/01cfdcb21734..b21973d2c0c9 Created with: gclient setdep -r src-internal@b21973d2c0c9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I656518a05a1558d434755887f419e751eb56daf6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1852195Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#704733}
-
Jack Lynch authored
This adds an axe tests for the Sources panel global listeners pane. Bug: 963183 Change-Id: Iba5ef2bdc927439604f01d91c1e8b9966c43fdf8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1666329 Commit-Queue: Jack Lynch <jalyn@microsoft.com> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#704732}
-
Antonio Gomes authored
It is now possible after mock_peer_connection_dependency_factory.h|cc move [1]. [1] https://crrev.com/c/1816789 BUG=787254 R=guidou@chromium.org, haraken@chromium.org Change-Id: I76ea8c3477467f5b4956af64cc4b76cc28c20775 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816792 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#704731}
-
Jack Lynch authored
This CL adds context menu items to each listener to reveal its source code, remove it, or toggle whether it is passive or blocking (when applicable). This improves the accessibility of the event listeners view in the Elements panel as well as the global listeners view in the Sources panel, as previously the passive toggle and delete buttons were available only on hover. Previously reviewed at https://chromium-review.googlesource.com/c/chromium/src/+/1665298, split into this CL as it impacts multiple parts of the UI. Screenshot: https://gyazo.com/dc1b54b5e0ae1f9b67f89b0400a168a8 Bug: 963183 Change-Id: I497e96ee3eb5d58358f904dd7e9ac92b15840baf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716462 Commit-Queue: Jack Lynch <jalyn@microsoft.com> Reviewed-by:
Lorne Mitchell <lomitch@microsoft.com> Cr-Commit-Position: refs/heads/master@{#704730}
-
Xida Chen authored
Bug: 900581 Change-Id: Iafa4c8d546e1de8eb540deb17d82b7c055854cf8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1853132 Commit-Queue: Xida Chen <xidachen@chromium.org> Reviewed-by:
Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#704729}
-
Marc Treib authored
article_entry.h/cc contained a bunch of code for converting from Sync types (SyncData/SyncChange/EntitySpecifics) to dom_distiller types. After recent changes, all that code isn't used anymore and can go. This also lets us remove special workarounds for the deprecated ARTICLES data type that we had in sync code. Bug: 1007942 Change-Id: Ic9e4d243dd7a4276973398149fd14da61bf5fe05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835367 Commit-Queue: Marc Treib <treib@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Auto-Submit: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#704728}
-
Stephen Chenney authored
The name of Paint Holding has replaced the original name of AvoidFlashBetweenNavigation. Renaming it allows a forthcoming finch study to use the current name. Also update the description etc. Bug: 1012732 Change-Id: Ia5994207e5d8e8b1f6a136ae709c1c8c773d418d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849145Reviewed-by:
Peter Boström <pbos@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#704727}
-
Collin Baker authored
This implements triggering the native tab context menu from the WebUI tab strip. To do so, it adds an interface that TabStripUI requires and WebUITabStripContainer implements. Design doc: https://docs.google.com/document/d/1KIasUON6Jd2gRiQ6gDXiOWVqBL4vE5vu4I6Vb61BAp8 Bug: 997887 Change-Id: Id9dc48709250545dcc20f3fc7acdf17a11ed6446 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838678Reviewed-by:
Peter Boström <pbos@chromium.org> Reviewed-by:
John Lee <johntlee@chromium.org> Commit-Queue: Collin Baker <collinbaker@chromium.org> Cr-Commit-Position: refs/heads/master@{#704726}
-
Ken Rockot authored
ScopedFeatureList is unsafe to use after browser threads have been started. This constraint will imminently be enforced by DCHECK to prevent further erroneous usage from landing. This CL corrects usage within browser tests for predictors and various features related to data reduction. This is split from a larger CL where in some rare cases, correction was too complex to resolve before landing the DCHECK, so corresponding test(s) may be disabled instead of fixed. Bug: 846380 Change-Id: I95e319ed19778bfd563bf3a0f65b88ae7420452c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849980 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Egor Pasko <pasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#704725}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/cd0eedb2483b..f17976d01993 git log cd0eedb2483b..f17976d01993 --date=short --no-merges --format='%ad %ae %s' 2019-10-10 kcwu@google.com Use single thread vp9 decoder for fuzzing 2019-10-10 kwiberg@webrtc.org Remove the unused `receive_timestamp` arg to NetEq::InsertPacket 2019-10-10 kcwu@google.com Cap vp9 fuzzer frame size to prevent OOM Created with: gclient setdep -r src/third_party/webrtc@f17976d01993 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:1009073,chromium:1009073 Change-Id: I4db6bc3540865fd49b13a46845f66f6288ae7387 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1851688Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#704724}
-
Greg Daniel authored
We are trying to remove ComputeTextureSize in Skia so this shifts the current uses of it to the new API. Change-Id: Ia2fa7598c5a36bf4c674efc5da8f134fcda5de61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1853106Reviewed-by:
Robert Phillips <robertphillips@google.com> Reviewed-by:
Khushal <khushalsagar@chromium.org> Commit-Queue: Greg Daniel <egdaniel@chromium.org> Cr-Commit-Position: refs/heads/master@{#704723}
-
Aga Wronska authored
This reverts commit 479f1be6. Reason for revert: The issue that caused flakiness is fixed (https://crbug.com/1005723). Original change's description: > Disable flaky/failing ScreenTimeControllerTests. > > TBR: michaelpg > Bug: 1007954, 1008289, 1008288, 1008286, 1008284, 1008282, 1008280, 1008273, 1008272, 1008269 > Change-Id: Ic611a4f597d2ddf9aaac66ff77fda64e3e4da8a4 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827277 > Reviewed-by: Finnur Thorarinsson <finnur@chromium.org> > Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> > Cr-Commit-Position: refs/heads/master@{#700186} TBR=finnur@chromium.org,michaelpg@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1007954, 1008289, 1008288, 1008286, 1008284, 1008282, 1008280, 1008273, 1008272, 1008269 Change-Id: I2f01ef970dc13c08820ea7baff3e6fd950da91af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1852417Reviewed-by:
Aga Wronska <agawronska@chromium.org> Commit-Queue: Aga Wronska <agawronska@chromium.org> Cr-Commit-Position: refs/heads/master@{#704722}
-
Miriam Zimmerman authored
BUG=None TEST=tast -verbose run 100.127.92.23 arc.AppCrash Change-Id: I04b8f0f91230802861c14cb67d2a16c901550db8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848552Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Ian Barkley-Yeung <iby@chromium.org> Commit-Queue: Miriam Zimmerman <mutexlox@chromium.org> Cr-Commit-Position: refs/heads/master@{#704721}
-
Nicolas Arciniega authored
While testing the related bug on a debug version of the auditor, I found that a DCHECK is missing a case. It is possible to have an AuditorResult with an empty message of type ERROR_MUTABLE_TAG. An AnnotationInstance will specifically create an AuditorResult of type ERROR_MUTABLE_TAG without a message. The detailed text provided by the AuditorResult itself should give sufficient context. Bug: 1005537 Change-Id: I39d66e758ed5b847430a7385e1d15bd33470d0ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849990Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Nicolas Ouellet-Payeur <nicolaso@chromium.org> Commit-Queue: Nicolas Arciniega <niarci@microsoft.com> Cr-Commit-Position: refs/heads/master@{#704720}
-
Xiaohui Chen authored
Bug: b:141751193 Test: locally build and unittests Change-Id: I1eb5ccfecb83723e54f67997283885c7f85c0fc1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845795Reviewed-by:
Tao Wu <wutao@chromium.org> Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#704719}
-
Xida Chen authored
The test is actually using width interpolation to test that the 'vh' value is computed correctly. Bug: 900581 Change-Id: Icfffb6bd06e1d89a25110727fab8b3107f2c5613 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1852580 Commit-Queue: Xida Chen <xidachen@chromium.org> Reviewed-by:
Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#704718}
-
rbpotter authored
If more than one page was visible in the viewport, getPageAtY_(y) fell through to returning 0 when y was the bottom of the document, because in the last iteration of the loop, where max = min = page = N-1 (for an N page document), the bottom of the page was exactly equal to y, rather than strictly > y. This resulted in the most visible page being set to N-1 rather than N when the document was scrolled to the bottom in this case. Bug: 1000121 Change-Id: I541204141d1fb7891f1df1bc95d00be28d39bbfd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1851086 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#704717}
-
Yuta Kitamura authored
This CL adds more tests for Agent generation. They test the following cases: * HTTP frame loading a same-origin HTTPS child frame * iframe loaded as data: URL * iframe loaded with srcdoc attribute Bug: 961186 Change-Id: I21eae63c9b6e3d5a2be911cb4cce1eb975e48cb8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1852325 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Auto-Submit: Yuta Kitamura <yutak@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#704716}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/e6b95e45544d..14bf0b9d8122 git log e6b95e45544d..14bf0b9d8122 --date=short --no-merges --format='%ad %ae %s' 2019-10-10 fmayer@google.com Merge "Improve tslint presubmit message." Created with: gclient setdep -r src/third_party/perfetto@14bf0b9d8122 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: I88a6c4d24b8f5e0c69e3a97faa5d4f9f6e78df64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1851687Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#704715}
-
John Budorick authored
Built after crrev.com/c/1849429 landed: https://ci.chromium.org/p/chromium/builders/ci/android-avd-packager/9 Bug: 922145 Change-Id: I6bafd36290f01faf89c8e3770b6a1553e30ba8c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1853108 Commit-Queue: John Budorick <jbudorick@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Auto-Submit: John Budorick <jbudorick@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#704714}
-
Ioana Pandele authored
Bug: 1013125 Change-Id: Ib1c5b60d62ec6d6c16f4600c7690149ed45ffa4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1852428 Commit-Queue: Ioana Pandele <ioanap@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#704713}
-
Lijin Shen authored
This CL updates tab indicator style on downloads, translate infobar and clear browsing data tab layouts. Bug: 945924 Change-Id: Ic034af92ca78aae0e6813e29d3f6a2d78006b064 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849210Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Lijin Shen <lazzzis@google.com> Cr-Commit-Position: refs/heads/master@{#704712}
-
Xianzhu Wang authored
Previously cc::Layer::DebugName() called LayerClient::TakeDebugInfo() which has side-effect to clear some debug information (e.g. raster invalidation tracking), causing layer name dump to interfere with raster invalidation tracking. Add the new method to avoid the problem. R=pdr@chromium.org TBR= # trivial change under ui/compositor. Change-Id: Ia4850298f8bc5a2a003dc92a00bda903a3b099d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1850964 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#704711}
-
Yutaka Hirano authored
This reverts commit fe5510cf. Reason for revert: This has been successfully merged to M78. Let's revert this on M79. Original change's description: > Disable "HtmlImportsRequestInitiatorLock" > > We see some breakage on M78, so we are disabling the feature. After > merging this change to M78 I will revert this change. > > Bug: 1006292 > Change-Id: Ie56d2ac5cdd6ed8ea0fdf8c124a3f01c24731eed > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846832 > Commit-Queue: Yutaka Hirano <yhirano@chromium.org> > Reviewed-by: Matt Falkenhagen <falken@chromium.org> > Cr-Commit-Position: refs/heads/master@{#703615} TBR=falken@chromium.org,yhirano@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1006292 Change-Id: I1adfa65ca6680f8677ac7342cecece16bb042f37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1852353 Auto-Submit: Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#704710}
-
Jack Lynch authored
In response to feedback on [1], this CL refactors the Watch expressions and Scope pane to keep all of their respective objects in one tree each instead of one tree per object. This allows simple keyboard navigation between watch expressions or scopes and creates more clarity for screen reader users. This change also allows users to edit watch expressions and editable object properties by pressing the enter key in order to make that functionality keyboard-accessible. There is still an issue where data-keyboard-focus is not applied when the tree element is selected after exiting a text prompt or context menu, but I believe that is an unrelated issue with treeoutline or UIUtils that can be fixed separately. Before: https://gyazo.com/656714c5e92b268e8a8a988d155bd592 After: https://gyazo.com/02e0df16e66c188c3c8f8d5b38dd3b42 Navigation gif: https://i.imgur.com/I5qT0UW.mp4 [1]: https://chromium-review.googlesource.com/c/chromium/src/+/1646644/9/third_party/blink/renderer/devtools/front_end/sources/WatchExpressionsSidebarPane.js#463 Bug: 963183 Change-Id: Iedb6d941364c457cef7614dae6a75ca6b8165c56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1719852Reviewed-by:
Lorne Mitchell <lomitch@microsoft.com> Commit-Queue: Jack Lynch <jalyn@microsoft.com> Cr-Commit-Position: refs/heads/master@{#704709}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/232e3301c726..b484e7ce24c9 git log 232e3301c726..b484e7ce24c9 --date=short --no-merges --format='%ad %ae %s' 2019-10-10 mtklein@google.com hand off frames to encoder as they come 2019-10-10 robertphillips@google.com Pass GrProgramInfo further down Vulkan call chain 2019-10-10 jvanverth@google.com Draw perspective text as paths. 2019-10-10 robertphillips@google.com Add computation of requestedFeatures to GrProgramInfo and use it 2019-10-10 kjlubick@google.com [debugger] Use alternate buffer 2019-10-10 nigeltao@google.com Update Wuffs version to 0.2.0-rc.1 2019-10-10 fmalita@chromium.org [SkVideoEncoder] Allow clients to control the color type Created with: gclient setdep -r src/third_party/skia@b484e7ce24c9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC kjlubick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=kjlubick@google.com Bug: None Change-Id: Ia75206ef802bc5f797bb52861c4961bef75b315b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1851689Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#704708}
-
Eric Orth authored
Add a simple CancelForContext mechanism that cancels probes iff the context being used matches the one being shutdown. Mostly the same as a solution implemented earlier in crrev.com/c/1823998 except no longer using the IsDohEnabled() mechanism to go out of the way to avoid changing when the experiment is disabled. Planning a subsequent CL to cleanup at least the API on this as SetRequestContextForProbes()/CancelProbesForContext() is not the greatest API for creating/cancelling cancelable actions and annoyingly inconsistent with the rest of HostResolver. Some minor fixes in dns_transaction_unittest.cc as there was some accidental method hiding of TearDown() that was otherwise breaking new tests. Bug: 1006902 Change-Id: I1e638f9f3d39b18b3443e4ddf478d2c2d37f2570 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841241 Commit-Queue: Eric Orth <ericorth@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Auto-Submit: Eric Orth <ericorth@chromium.org> Cr-Commit-Position: refs/heads/master@{#704707}
-
Albert Chaulk authored
Turns out this was just being directed into the wrong EventHandler, we need to go into the RenderWidgetHostView's handler instead This also runs touch inputs through the gesture recognition pipeline, web content typically wants to interact with gestures and not raw touch events Bug: b/141992733 Test: local build Change-Id: I5e0722f7d268f936c92d25215ef85707d94e5289 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1850632Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Reviewed-by:
Alex Sakhartchouk <alexst@chromium.org> Commit-Queue: Alex Sakhartchouk <alexst@chromium.org> Commit-Queue: Albert Chaulk <achaulk@chromium.org> Cr-Commit-Position: refs/heads/master@{#704706}
-
Mikhail Khokhlov authored
Bug: 981349 Change-Id: I1a47afea1dedcd352a0d6999f7119246b74b737f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849855 Commit-Queue: Mikhail Khokhlov <khokhlov@google.com> Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#704705}
-
Joe Mason authored
Add section on blocklist/allowlist. Bug: 842296 Change-Id: I520835e8bc028407418943ea8c421208892a1e2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848912Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Joe Mason <joenotcharles@chromium.org> Cr-Commit-Position: refs/heads/master@{#704704}
-
Scott Violet authored
This coverts from using the LayoutBox function to the StyleRef function, which works regardless of the implementation. After this there is only one call to IsDeprecatedFlexibleBox(), which has a cast to LayoutDeprecatedFlexibleBox. BUG=993813 TEST=covered by various layout tests Change-Id: I6a5569067a0acf492ef687dd07ae74da6910733b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849585 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#704703}
-