GitLab

This CL moves the VideoTutorialServiceFactory and the JNI bridge into
the internal target. A corresponding public factory class is generated
from the internal factory using android_library_factory function. The
JNI function lives in video_tutorial_service_bridge_factory.cc which is
included in chrome/browser target while still living in
chrome/browser/video_tutorials/internal.

Bug: 1120097
Change-Id: I4cbc7e2763012e3780a28f58bf14e3374464e20e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368474Reviewed-by: Henrique Nakashima <hnakashima@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Shakti Sahu <shaktisahu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#801312}

Lacros used to use mojo_base::mojo::Binder to establish the
Mojo connection between Lacros and Ash chromes,
preferring the plataform independent way.
However, it is too late for passing initializing parameters,
which needs to be passed before starting the main message loop.

This CL directly binds the LacrosChromeService,
so that parameters can be available at earlier timing.

Bug: 1115092
Test: Ran Lacros locally.
Change-Id: I5345fa4bfe57b9a922e2d6c389c579266893d03b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353976
Commit-Queue: Hidehiko Abe <hidehiko@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Ken Rockot <rockot@google.com>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#801311}

This CL introduces a check to verify that the SODA binary and language
pack components are downloaded before launching the speech recognition
service. In the event where the files are not yet downloaded, a generic
error message will be shown to the user indicating that speech
recognition is not available.

Bug: 1121384
Change-Id: Iff628202884869a04ce54761137aca4d40497fc3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2373388Reviewed-by: Abigail Klein <abigailbklein@google.com>
Commit-Queue: Evan Liu <evliu@google.com>
Cr-Commit-Position: refs/heads/master@{#801310}

This is a reland of 19a1e60d

Original change's description:
> Add tracing support for mojo handle kinds
>
> Support tracing of mojo handle and remote/receiver kinds. Thus provide
> more precise debugging information for developers. Also avoid
> generating fallback literals for base::trace_event::ValueToString.
>
> Bug: 1103623
> Change-Id: Ib01e79f7ae0aba64cabda3aea87cc1d1aed3b921
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2356005
> Commit-Queue: Karel Král <karelkral@google.com>
> Reviewed-by: Ken Rockot <rockot@google.com>
> Reviewed-by: Alexander Timin <altimin@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#798588}

Fix crbug.com/1117192 by not tracing interface kinds as these have
incompatible API (either have is_bound or is_valid).

Bug: 1103623
Change-Id: Id126e143e478054e1aacc9f3fa48df3f9dbf113f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368556Reviewed-by: Ken Rockot <rockot@google.com>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Commit-Queue: Karel Král <karelkral@google.com>
Cr-Commit-Position: refs/heads/master@{#801309}

Test was recently added, flaky on various windows builders.

TBR=justinmiron@chromium.org

Bug: 1121444
Change-Id: I962811e829051da2a9ff00c015613357b3d0664e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2371729Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Fergal Daly <fergal@chromium.org>
Commit-Queue: Fergal Daly <fergal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#801308}

The test RTCRtpTransceiver.https.html was written wrong.

Bug: chromium:1115087
Change-Id: If6961ac8ec33605ecf97da10d97e4c35281cc6cf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2374446Reviewed-by: Henrik Boström <hbos@chromium.org>
Commit-Queue: Harald Alvestrand <hta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#801307}

This makes it easier to track the remaining usages of Xlib.  I plan on
removing headers from x11.h a couple at a time.  Once we're down to
just Xlib.h, I'll remove the Xlib.h include and replace it with manual
declarations for all the types and functions we need (XOpenDisplay(),
etc).  Then I'll continue incrementally removing types and functions
from there.

BUG=1066670
R=msisov,sky,penghuang

Change-Id: Ia80e911eb540f99c2a4aa3edf396f1e1cc982e5d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2373227Reviewed-by: Maksim Sisov (GMT+3) <msisov@igalia.com>
Reviewed-by: Peng Huang <penghuang@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#801306}

Previous patch:
https://chromium-review.googlesource.com/c/chromium/src/+/2364492
Added a WebFeature.

Unfortunately, this isn't observable from the content/ layer. This is
because the ContentBrowserClient::LogWebFeatureForCurrentPage() is currently
left blank.

Every content/ embedders copy-pasted almost all the same implementation, using
the page_load_metrics::MetricsWebContentsObserver::RecordFeatureUsage()
function.

Instead of adding the tests into content/browser, this adds them to
chrome/browser/

Bug: 1116413
Change-Id: I635eb004653c737403544b324c47ca7ef6b884d4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2366936Reviewed-by: David Roger <droger@chromium.org>
Reviewed-by: Camille Lamy <clamy@chromium.org>
Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#801305}

This reverts commit 44f5ba08.

Reason for revert: This strategy doesn't work, so let's go back to the previous strategy. It doesn't work today, but will in an upcoming Google Update release.

Original change's description:
> [mini_installer] Move the fallback reporting to InstallerError.
> 
> https://crrev.com/798844 attempted to send up a signal regarding whether
> or not the fallback temp directory was used. Unfortunately, Omaha does
> not include the ExtraCode1 value for successful installs. It does,
> however, send up success HRESULTS in the InstallerError value. This CL,
> therefore, switches to that. The two values to look out for are
> 0x00044001 and 0x00044002 (two success HRESULTS in FACILITY_ITF that
> otherwise appear to be unused).
> 
> BUG=516207,1100280
> 
> Change-Id: I319c5dbe7162543a71465238c5320719225fa1f7
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368353
> Auto-Submit: Greg Thompson <grt@chromium.org>
> Commit-Queue: S. Ganesh <ganesh@chromium.org>
> Reviewed-by: S. Ganesh <ganesh@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#800584}

TBR=ganesh@chromium.org,grt@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 516207
Bug: 1100280
Change-Id: I38f6d27904d8f822c949fb07285ae63830ce533a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2374206Reviewed-by: Greg Thompson <grt@chromium.org>
Commit-Queue: Greg Thompson <grt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#801304}

SVGImageForContainer::PaintImageForCurrentFrame() doesn't pass on zoom,
and will thus produce a result an image that differs from how the same
image would look if it was painted using a more direct code-path - such
as Draw().
Add a |zoom| argument to
SVGImage::PopulatePaintRecordForCurrentFrameForContainer and adjust
callers to pass a relevant zoom-factor. Re-order the order of the
arguments to match other methods that accept zoom.

Bug: 1121177
Change-Id: If2e1abe8ee3f9f29e176044b1ea3261bc300a87f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368593Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#801303}

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll
Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast
Tbr: cr-fuchsia+bot@chromium.org
Change-Id: Iab3c70ec38b82e32a40af23e645ffae506d60052
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2374225Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#801302}

Change-Id: Ie572954f1ad75a50b12a1f0c268bd2d2919b0e71
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2371947
Commit-Queue: Jecelyn Yeen‎ <jec@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#801301}

Explicitly remove the copy constructor and assignment operator with
the delete keyword.

Bug: 1010217
Change-Id: Ic3450e3f9b42d3ee530460f34f42e0def6b42ab9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368572Reviewed-by: Koji Ishii <kojii@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#801300}

https://pdfium.googlesource.com/pdfium.git/+log/e8bde89026d6..42aaf8bd7f23

2020-08-25 thestig@chromium.org Simplify CFX_Font's CharsetFontMap code.
2020-08-24 nigi@chromium.org Enable FPDFEditEmbedderTest.PathOnTopOfText for Skia/SkiaPaths.
2020-08-24 thestig@chromium.org Abstract some raw data tables in CFX_Font.
2020-08-24 thestig@chromium.org Simply _CheckIncludeOrder() presubmit check.
2020-08-24 tsepez@chromium.org Introduce class EmbedderTestEnvironment
2020-08-24 thestig@chromium.org Add ReverseCopy3Bytes() utility function.
2020-08-24 thestig@chromium.org Switch to memcpy()/std::fill()/std::swap() in image processing code.
2020-08-24 thestig@chromium.org Switch to memcpy()/memset() in image conversion code.
2020-08-24 thestig@chromium.org Remove dead code in CJpegContext.
2020-08-24 tsepez@chromium.org Introduce CFX_GEModule::PlatformIface::CreateDefaultSystemFontInfo().
2020-08-24 pdfium-autoroll@skia-public.iam.gserviceaccount.com Roll Code Coverage from af90718d311e to 2d8a12dca47a (2 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pdfium-autoroll
Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: pdfium-deps-rolls@chromium.org
Change-Id: If9a1dc83ce19f2cc580d5041bc1f3ed74b5d2988
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2374346Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#801299}

This CL rename Web IDL |OverrideBuiltins| to |LegacyOverrideBuiltins| to
make its usage more clear.

Bug: 1072773
Change-Id: I0068fe21136dc3ccf68c5a34e293fffab99a3ec3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359880Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Commit-Queue: Zhuoyu Qian <zhuoyu.qian@samsung.com>
Cr-Commit-Position: refs/heads/master@{#801298}

Bug: b/161674018
Change-Id: If93e5eaab7391fad3af8b29d4030a6cc43d47737
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360070
Commit-Queue: Michele Mancina <micantox@google.com>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Clemens Arbesser <arbesser@google.com>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#801297}

disable tests for non-X11 (ozone and non-ozone) backends. Otherwise,
they can be ran for wayland backend, which is incorrect.

Bug: 789065
Change-Id: Ia2956a1e9137e77968a193182c7db675470ca307
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2372463
Commit-Queue: Maksim Sisov (GMT+3) <msisov@igalia.com>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#801296}

On Windows we grab the raw mouse movements and stop actually moving the
mouse when in unadjusted movement so moving to the center does not make
sense.  However, on ChromeOS and Linux we temporarily turn off mouse
Acceleration in the settings and keep the mouse moving like normal so
The move to center calculation should not change.

Bug: 1119468
Change-Id: Ib318627340df98f55205f4489084d88c89a7fd37
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2373447Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Commit-Queue: James Hollyer <jameshollyer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#801295}

It was reenabled in https://crrev.com/c/2008079 but it is still flaky
when run with leak detection.

https://ci.chromium.org/p/chromium/builders/ci/WebKit%20Linux%20Leak?limit=100

TBR=cassew@google.com,rakina@chromium.org

Bug: 833655
Change-Id: I4268307e0549d38c6e653217776a5f31309badbe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2371948
Commit-Queue: Fergal Daly <fergal@chromium.org>
Reviewed-by: Fergal Daly <fergal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#801294}

Explicitly remove the copy constructor and assignment operator with
the delete keyword.

Bug: 1010217
Change-Id: I209ebbcb89a616c91284c170ef251bbb4fd3091e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2371382Reviewed-by: Koji Ishii <kojii@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#801293}

https://skia.googlesource.com/skia.git/+log/bcca52ab84df..9ad0c9e91a7d

2020-08-25 skia-autoroll@skia-public.iam.gserviceaccount.com Roll dawn from ef7447334713 to c3e3c30b0d7f (1 revision)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC mtklein@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Cq-Do-Not-Cancel-Tryjobs: true
Bug: None
Tbr: mtklein@google.com
Change-Id: I154391e92e0f06e5ee3a01bcd6da69e567d367b9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2373748Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#801292}

Two tests each installed 8 PWAs. These tests are now split in half,
so we never install more that 4 PWAs in a single test.

Flakiness Dashboard
https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=All%2FWebAppBrowserTest_DisplayOverride.HasMinimalUiButtons%2FWebApps&testType=browser_tests

Bug: 1120504
Change-Id: I5a853d65ad396c2f822edef9d8a7e805ad99662d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368697
Auto-Submit: Eric Willigers <ericwilligers@chromium.org>
Reviewed-by: Glen Robertson <glenrob@chromium.org>
Commit-Queue: Eric Willigers <ericwilligers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#801291}

Bug: 982964
Change-Id: I095c1ae1828208dc797913e7ceb6fc4361afd0b9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2372344Reviewed-by: Dana Fried <dfried@chromium.org>
Commit-Queue: Dana Fried <dfried@chromium.org>
Cr-Commit-Position: refs/heads/master@{#801290}

This histogram records the time that the user spends on a page with a
delayed warning until the interstitial shows or the user leaves the
page.

Bug: 1111078
Change-Id: Ice9cd219fed35386fd62e3dc4a86050ca3e8343f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368449Reviewed-by: Daniel Rubery <drubery@chromium.org>
Reviewed-by: Christopher Thompson <cthomp@chromium.org>
Reviewed-by: Mustafa Emre Acer <meacer@chromium.org>
Commit-Queue: Emily Stark <estark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#801289}

If the user has manually set a proxy in the network settings, a warning
is shown in the tray to let them know that traffic may be monitored.

This CL implements showing the proxy privacy disclosure message
regardless of the proxy source or configuration mode (PAC, WPAD etc).

Bug: 1119754, 919691
Test: unittest
Change-Id: I6da49a72650614c1bd58c76e7bdb474ed4881c50
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367042Reviewed-by: Denis Kuznetsov [CET] <antrim@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Andreea-Elena Costinas <acostinas@google.com>
Cr-Commit-Position: refs/heads/master@{#801288}

Using wpt-import in Chromium 163a87b7.
With Chromium commits locally applied on WPT:
9f52c7e4 "COOP: add reporting to redirects"
d18db804 "Fix test flake in animation-state-changes-positive-playback-rate.html"


Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
hbos@chromium.org, hta@chromium.org, guidou@chromium.org, philipp.hancke@googlemail.com:
  external/wpt/webrtc

NOAUTOREVERT=true
TBR=robertma@google.com

No-Export: true
Change-Id: Ia27bcdfd162ef150f661e427b77853b25709a1a0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2374085Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#801287}

This CL adds subtitle and button strings for web sign-in auth error.

Screenshot: https://crbug.com/1116952#c3
Bug: 1116952
Change-Id: I251f3c6f24e98e3198828d8f25ae5eafd8c684dc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368557Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Tanmoy Mollik <triploblastic@chromium.org>
Commit-Queue: Alice Wang <aliceywang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#801286}

This CL converts PrintHostMsg_DidShowPrintDialog message to
DidShowPrintDialog() in mojom::PrintManagerHost.

Bug: 1008939
Change-Id: I1c73eb64fa7031ce2f2a35c12435e949d837dbf4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362489
Commit-Queue: Julie Kim <jkim@igalia.com>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#801285}

Implement scope objects to open / close a dictionary or array in their
constructors / destructors. Thus provide an alternative and hopefully
less bug-prone syntax for opening / closing of containers.

Bug: 1043616
Change-Id: Ie9a51d2ac1b0cae7f95bae3906c253a44013ccdb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2372442Reviewed-by: Eric Seckler <eseckler@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Commit-Queue: Karel Král <karelkral@google.com>
Cr-Commit-Position: refs/heads/master@{#801284}

Some tests are still flaky. Use content::RunAllTasksUntilIdle()
instead of RunLoop().RunUntilIdle() to try to run all scheduled
mojo callbacks.

Bug: 1115172
Change-Id: I0146698b9092b2aac48a357b69f4d2d7818d367c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2374187Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Kenichi Ishibashi <bashi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#801283}

This CL is a sanity check on ChromeContentRulesRegistry::AddRulesImpl()
which will help diagnose system inconsistency issues.

Bug: 1010336
Change-Id: Id4be21a63e966e2b0a81f74183489217b0768ad7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368613
Commit-Queue: calamity <calamity@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#801282}

should not affect the internal layout"

In LayoutNG, we use LayoutNGBlockFlow for input[type=file]. If
flex/grid is specified, NGBlockLayoutAlgorithm is applied but children
are blockified. So the internal [Choose File] button and
"No file chosen" text were placed on different lines.

This CL fixes it by skipping children blockify if the parent box is
input[type=file].
The original approach was wrong because it exposed adjusted 'display'
value via getComputedStyle().


Original change's description:
> input[type=file]: display:inline-flex/flex/inline-grid/grid should
> not affect the internal layout
>
> In LayoutNG, we use LayoutNGBlockFlow for input[type=file]. If
> flex/grid is specified, NGBlockLayoutAlgorithm is applied but children
> are blockified. So the internal [Choose File] button and
> "No file chosen" text were placed on different lines.
>
> This CL fixes it by adding "display" adjustment code.
>
> Bug: 1119312
> Change-Id: Id15bfa5a047f56ee00adb43d74e6b3d09f1f6433
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2371066
> Reviewed-by: Koji Ishii <kojii@chromium.org>
> Commit-Queue: Kent Tamura <tkent@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#801209}

Bug: 1119312
Change-Id: I1df3580882dff125d1860dab9754d6707d4eedc4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2371727
Auto-Submit: Kent Tamura <tkent@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#801281}

The last position index is items.count-1 not items.count.

Bug: 1115486
Change-Id: I6e9072d15dfbee0cc161d81c22441bb0c82bcb87
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2373297Reviewed-by: Sergio Collazos <sczs@chromium.org>
Commit-Queue: edchin <edchin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#801280}

Only crashes on ASAN. There's no good way to express that in the test
expectations so it's [ Pass Crash ]

TBR=smcgruer@chromium.org

Bug: 1121429
Change-Id: Ia702dbbcf3175e17098c07f8f3b5271b4e2379be
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2371831Reviewed-by: Fergal Daly <fergal@chromium.org>
Commit-Queue: Fergal Daly <fergal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#801279}

Currently, ChromeOS defines the OS_LINUX directive as well as
OS_CHROMEOS.  We're working to separate these two, so we're
making the fact that OS_LINUX == OS_LINUX || OS_CHROMEOS
explicit.

This is changes for /extensions/browser/api/app_window

This CL was uploaded by git cl split.

R=calamity@chromium.org

Bug: 1110266
Change-Id: I188590d228e449aaebed57a919b175cb2f7674de
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2371294Reviewed-by: calamity <calamity@chromium.org>
Commit-Queue: calamity <calamity@chromium.org>
Cr-Commit-Position: refs/heads/master@{#801278}

The packaging script previously would generate environment variables
with lots of ..\.. entries in environment variables, which is difficult
to read and increases the odds of hitting MAX_PATH limits.
crrev.com/c/2372727 changes the packaging and this change to
setup_toolchain.py adjusts the setup code to handle both the old and new
systems.

Bug: 1120785
Change-Id: I7c3449a54cf6fba9f70f52db83d940ffd4c32573
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2370604
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
Reviewed-by: Scott Graham <scottmg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#801277}

This CL changes ResourceFetcher::GetCacheIdentifier() to use the
bundle's URL as the cache identifier, when the resource is listed in the
resource= attribute of <link rel="webbundle">,


Bug: 1082020
Change-Id: I2035f9ef37bf40c8a636baecf38031ed1a585813
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2371424Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Hayato Ito <hayato@chromium.org>
Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org>
Commit-Queue: Tsuyoshi Horo <horo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#801276}

Currently, ChromeOS defines the OS_LINUX directive as well as
OS_CHROMEOS.  We're working to separate these two, so we're
making the fact that OS_LINUX == OS_LINUX || OS_CHROMEOS
explicit.

This is changes for /components/safe_browsing

This CL was uploaded by git cl split.

R=drubery@chromium.org

Bug: 1110266
Change-Id: Id895b4785eeea1828e2e2c753d24872412cf5984
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2370292Reviewed-by: Daniel Rubery <drubery@chromium.org>
Commit-Queue: Sean McAllister <smcallis@google.com>
Cr-Commit-Position: refs/heads/master@{#801275}

Because we don't return any value for it, following warning is printed:
.../wtf/casting.h: In static member function
  '.. bool DowncastTraits<T>::AllowFrom(const U&)':
.../wtf/casting.h:60:3:
  warning: no return statement in function returning non-void [-Wreturn-type]
Used compiler: gcc 8.2.0

To fix the warning, this CL returns false value.

Change-Id: I19d7eef907619c272bdd790770a791aec4a5f03b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362348Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: JunHo Seo <junho0924.seo@lge.com>
Cr-Commit-Position: refs/heads/master@{#801274}

Currently, ChromeOS defines the OS_LINUX directive as well as
OS_CHROMEOS.  We're working to separate these two, so we're
making the fact that OS_LINUX == OS_LINUX || OS_CHROMEOS
explicit.

This is changes for /chrome/browser/notifications

This CL was uploaded by git cl split.

R=yoshiki@chromium.org

Bug: 1110266
Change-Id: Ia3805830c319754c760ddf58fddba687f33d68c7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2371256Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
Commit-Queue: Sean McAllister <smcallis@google.com>
Cr-Commit-Position: refs/heads/master@{#801273}