GitLab

In C++, it's not legal to call member functions on objects that are null
pointers.

R=esprehn@chromium.org

Review URL: https://codereview.chromium.org/215773002

git-svn-id: svn://svn.chromium.org/blink/trunk@170245 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=adamk@chromium.org
BUG=355658,178319,161068

Review URL: https://codereview.chromium.org/209363002

git-svn-id: svn://svn.chromium.org/blink/trunk@170243 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Controlled by explicit API now, per
https://codereview.chromium.org/210243004 and must land after https://codereview.chromium.org/212953007/ .

R=eae@chromium.org, jamesr@chromium.org
BUG=333029

Review URL: https://codereview.chromium.org/213173003

git-svn-id: svn://svn.chromium.org/blink/trunk@170242 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This lets us re-land http://crrev.com/208393008 without breaking
AwSettingsTest.testLayoutAlgorithmWithTwoViews.

Without http://crrev.com/208393008, style recalc would always reset the
autosizing multiplier to 1, so the bug in recalculateMultipliers was not
noticed.

BUG=353309,356960

Review URL: https://codereview.chromium.org/215063004

git-svn-id: svn://svn.chromium.org/blink/trunk@170241 bbb929c8-8fbe-4397-9dbb-9b2b20218538

- web-animations-api/change-in-animation-frame.html [ Failure Pass ]
- compositing/plugins/invalidate_rect.html [ Failure Pass ]
- virtual/softwarecompositing/plugins/invalidate_rect.html [ Failure Pass ]
- svg/custom/js-late-pattern-and-object-creation.svg [ ImageOnlyFailure Pass ]

BUG=357437,357438,357439
TBR=enne@chromium.org

Review URL: https://codereview.chromium.org/216023002

git-svn-id: svn://svn.chromium.org/blink/trunk@170240 bbb929c8-8fbe-4397-9dbb-9b2b20218538

These are the remaining tests that call display() directly and also do
not need actually need a paint phase to test what they intend to.

BUG=345027

Review URL: https://codereview.chromium.org/196573042

git-svn-id: svn://svn.chromium.org/blink/trunk@170239 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Chromium now sends ctrl+wheel events to webkit first before using them for zooming. Rather than prevent scrolling for these events in EventHandler::handleWheel, push that check a couple levels deeper into ScrollableArea::handleWheelEvent.  In addition to EventHandler, this code is also called by WebPluginScrollbarImpl and so will fix some additional cases.

This is mostly already tested by the fast/event/wheelevent-ctrl.html test I added in http://crrev.com/183403002.  I've extended that test to cover document and div scrolling cases and ensured it fails reliably if either the ScrollableArea or EventHandler::defaultWheelEventHandler check is removed. 

BUG=352474, 111059

Review URL: https://codereview.chromium.org/212913002

git-svn-id: svn://svn.chromium.org/blink/trunk@170238 bbb929c8-8fbe-4397-9dbb-9b2b20218538

All of these tests don't seem to depend on minimizing repaints and are
more trying to make sure that something has repainted.  Therefore,
change them all to just use rAF rather than repaint.js and make them
pixel tests where applicable.

BUG=345027

Review URL: https://codereview.chromium.org/207383002

git-svn-id: svn://svn.chromium.org/blink/trunk@170237 bbb929c8-8fbe-4397-9dbb-9b2b20218538

- inspector/sources/debugger/script-formatter-breakpoints-2.html [ Pass Timeout ]

- http/tests/workers/terminate-during-sync-operation.html [ Crash Pass Slow Timeout ]

BUG=357004,357427
TBR=enne@chromium.org

Review URL: https://codereview.chromium.org/215153008

git-svn-id: svn://svn.chromium.org/blink/trunk@170236 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Per request of haraken:
https://codereview.chromium.org/212593008/#msg4

TBR=haraken

Review URL: https://codereview.chromium.org/214283002

git-svn-id: svn://svn.chromium.org/blink/trunk@170235 bbb929c8-8fbe-4397-9dbb-9b2b20218538

When calling RenderLayerClipper::backgroundClipRect on the
RenderLayerClipper object corresponding to the RenderLayer
which is equal to clipRectsContext.rootLayer, it first calls
parentClipRects on the clipper of that RenderLayer's parent.
In turn, this starts a recursive walk up the RenderLayer
tree in updateClipRects. This is incorrect, since a
RenderLayerClipper object is unable to clip above rootLayer
in the render tree. In particular, the recursion condition
in updateClipRects
depends on the recursion starting at a layer which is below
or equal to rootLayer.

BUG=336563

Review URL: https://codereview.chromium.org/211683003

git-svn-id: svn://svn.chromium.org/blink/trunk@170234 bbb929c8-8fbe-4397-9dbb-9b2b20218538

A bunch of code was needlessly null-checking enclosingLayer. That function can
only return zero for RenderObjects that are outside of the render tree.

R=esprehn@chromium.org

Review URL: https://codereview.chromium.org/215843002

git-svn-id: svn://svn.chromium.org/blink/trunk@170233 bbb929c8-8fbe-4397-9dbb-9b2b20218538

In Skia r13323, I changed Skia's image filter clipping behaviour to
expand clip bounds to accommodate filter margins. However, the legacy
Blink DAG already makes such accommodation, which means we're creating
an offscreen with redundant pixels. The fix is to specify the computed
bounds directly in saveLayer(), which overrides (well, actually
intersects) the clip, giving the correct bounds. This does give
different results for large blur sigmas, but I believe the new results
are spec-correct: the intermediate buffers used by filters should
never exceed the size of the filter region.

Covered by marked svg tests.

BUG=
R=schenney@chromium.org

Review URL: https://codereview.chromium.org/214693008

git-svn-id: svn://svn.chromium.org/blink/trunk@170232 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=357004
TBR=vsevik
NOTRY=true

Review URL: https://codereview.chromium.org/215913002

git-svn-id: svn://svn.chromium.org/blink/trunk@170231 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Sample of the new output:
    InlineFlowBox       0x397ffa898130          RenderInline 0x397ffa840170 {pos=30,13 size=212.271,15} baseline=24/20


R=ojan@chromium.org
BUG=

Review URL: https://codereview.chromium.org/215583003

git-svn-id: svn://svn.chromium.org/blink/trunk@170229 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Revert of Add runtime feature and property names for unprefixed CSS Transforms (https://codereview.chromium.org/211033002/)

Reason for revert:
Breaks perf test: src/tools/perf/tough_animation_cases/transform_transition_js_block.html

BUG=356859

Original issue's description:
> Add runtime feature and property names for unprefixed CSS Transforms
> 
> Adds a runtime flag (enabled only for testing) and defines property names
> for each property defined in CSS Transforms[1]. Future patches will make
> these properties functional.
> 
> [1] http://www.w3.org/TR/css3-transforms/
> 
> BUG=154772
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170005
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170149

TBR=eseidel@chromium.org,esprehn@chromium.org,dstockwell@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=154772

Review URL: https://codereview.chromium.org/215773003

git-svn-id: svn://svn.chromium.org/blink/trunk@170228 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Reason for revert:
Breaks perf test: src/tools/perf/tough_animation_cases/transform_transition_js_block.html

BUG=356859

Original issue's description:
> CSS Transforms: Implement transform-style
> 
> Implements transform-style as defined in CSS Transforms[1]. Behavior is
> identical to -webkit-transform-style.
> 
> Note, this property is guarded by the CSSTransformsUnprefixed runtime feature
> (enabled only for testing).
> 
> [1] http://www.w3.org/TR/css3-transforms/
> 
> BUG=154772
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170013
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170166

TBR=eseidel@chromium.org,dstockwell@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=154772

Review URL: https://codereview.chromium.org/215843003

git-svn-id: svn://svn.chromium.org/blink/trunk@170227 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Apparently, runOnOpenPopup1() function was being called again after invoking
iframe.contentWindow.location.reload(), right between finishing the execution of
runOnIFrameLoad() and finishJSTest(), in the Mac platform.

This patch avoids the issue by using one global flag to early return in
that function when the iframe has already been reloaded.

BUG=357176
R=tkent@chromium.org,eae@chromium.org

Review URL: https://codereview.chromium.org/214603003

git-svn-id: svn://svn.chromium.org/blink/trunk@170226 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=tkent@chromium.org
BUG=58719

Review URL: https://codereview.chromium.org/214693004

git-svn-id: svn://svn.chromium.org/blink/trunk@170225 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Having both ::compare() and ::diff() was really confusing, this patch
renames them to stylePropagationDiff() and visualInvalidationDiff()
making their purpose more clear.

Review URL: https://codereview.chromium.org/214473004

git-svn-id: svn://svn.chromium.org/blink/trunk@170223 bbb929c8-8fbe-4397-9dbb-9b2b20218538

We were missing the xcode_settings OTHER_CFLAGS.

R=oilpan-reviews@chromium.org, tkent@chromium.org, zerny@chromium.org
BUG=

Review URL: https://codereview.chromium.org/214403002

git-svn-id: svn://svn.chromium.org/blink/trunk@170222 bbb929c8-8fbe-4397-9dbb-9b2b20218538

When the background of the table row is changed we repaint the entire table.
This CL adds a layout test showing the issue.

BUG=357291

Review URL: https://codereview.chromium.org/214513008

git-svn-id: svn://svn.chromium.org/blink/trunk@170221 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Code to update the blending status in the RenderLayer hierarchy when a child is added or removed current invokes paintsWithBlendMode which calls compositingState() when it should not. This patch removes the compositing state check in this case, which means we may do more work.

All existing tests pass.

R=senorblanco@chromium.org
BUG=343759

Review URL: https://codereview.chromium.org/211103007

git-svn-id: svn://svn.chromium.org/blink/trunk@170220 bbb929c8-8fbe-4397-9dbb-9b2b20218538

In certain rare cases, history.{push,replace}State are called when during
plugin detach. In this case, it's possible for the state modification to be
requested on a frame that is half-way detached. The Document is still live,
but the DocumentLoader is gone. Exit early in this case.

BUG=356424

Review URL: https://codereview.chromium.org/215183002

git-svn-id: svn://svn.chromium.org/blink/trunk@170219 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Revert of Make start/stop loading notifications per-frame (https://codereview.chromium.org/183793002/)

Reason for revert:
Possibly causing content_browsertests EndToEnd to fail.

See: http://build.chromium.org/p/chromium.webkit/builders/Linux%20Tests%20%28dbg%29/builds/2095/steps/content_browsertests/logs/stdio

Output:
[20917:20917:0327/122353:3268961829:INFO:CONSOLE(0)] "Uncaught TypeError: Cannot convert undefined or null to object", source: http://127.0.0.1:34379/files/web_ui_mojo.html (0)
[20917:20917:0327/122353:3269022437:INFO:CONSOLE(28)] "Uncaught TypeError: undefined is not a function", source: http://127.0.0.1:34379/files/web_ui_mojo.js (28)
BrowserTestBase signal handler received SIGTERM. Backtrace:
#0 0x000000a593be base::debug::StackTrace::StackTrace()
#1 0x000002bfc17b content::(anonymous namespace)::DumpStackTraceSignalHandler()
#2 0x7f9c3e4ab4a0 <unknown>
#3 0x7f9c3e55da43 __poll
#4 0x7f9c42aabff6 <unknown>
#5 0x7f9c42aac124 g_main_context_iteration
#6 0x000000aaaf5f base::MessagePumpGlib::RunWithDispatcher()
#7 0x000000a8e802 base::RunLoop::Run()
#8 0x00000058256e content::(anonymous namespace)::WebUIMojoTest_EndToEnd_Test::RunTestOnMainThread()

Original issue's description:
> Make start/stop loading notifications per-frame
> 
> Also, make ProgressTracker a frame-level concept rather than a page-level concept and merge it with FrameLoader's FrameProgressTracker helper. Send per-frame progress change notifications accordingly.
> 
> This depends on https://codereview.chromium.org/180113003/ landing in chromium.
> 
> BUG=347643
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170192

TBR=abarth@chromium.org,japhet@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=347643

Review URL: https://codereview.chromium.org/215533004

git-svn-id: svn://svn.chromium.org/blink/trunk@170218 bbb929c8-8fbe-4397-9dbb-9b2b20218538

It's possible that MemoryCache::replace will try to evict a resource that has
already been evicted. If there is another resource present in its place, it
won't get evicted, but will get partially overwritten. In that partial
overwrite, we leave references to it in the LRU lists, leading to later
crashes.

BUG=357174
TEST=MemoryCacheTest.RemoveDuringRevalidation

Review URL: https://codereview.chromium.org/214773004

git-svn-id: svn://svn.chromium.org/blink/trunk@170217 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Use didNotifySubtreeInsertionsToDocument instead.

BUG=356095
TEST=automated
R=morrita@chromium.org

Review URL: https://codereview.chromium.org/212793007

git-svn-id: svn://svn.chromium.org/blink/trunk@170216 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=345027

Review URL: https://codereview.chromium.org/207153002

git-svn-id: svn://svn.chromium.org/blink/trunk@170214 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=352282

Review URL: https://codereview.chromium.org/214963003

git-svn-id: svn://svn.chromium.org/blink/trunk@170213 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Traverse the selectorList() like we do for :host to find features for
invalidation sets. Relevance for 351613 is that we need to support this in
order to implement efficient invalidation sets for :hover with
childrenAffectedByHover due to UA stylesheet rules.

R=esprehn
BUG=356125,351613

Review URL: https://codereview.chromium.org/210973004

git-svn-id: svn://svn.chromium.org/blink/trunk@170212 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Add Traversal<*Element>::firstAncestor() API to traverse elements of a specific
type. It is a common pattern in our code base to traverse the ancestors of a
Node until we find an Element of a specific type. This new firstAncestor() API
makes the code much simpler. This CL already makes use of the new API in
several places.

R=esprehn, eseidel
BUG=346733

Review URL: https://codereview.chromium.org/201293002

git-svn-id: svn://svn.chromium.org/blink/trunk@170211 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This is a revert of https://src.chromium.org/viewvc/blink?view=rev&revision=168627.

BUG=254020

Review URL: https://codereview.chromium.org/215173003

git-svn-id: svn://svn.chromium.org/blink/trunk@170210 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Chromium-side changes to parse and use optional WebM TrackEntry
DefaultDuration, derive simpleblock frame durations from subsequent
frame duration, or estimate missing frame duration as the maximum
duration seen so far cause changes in mediasource buffered range tests.

This change updates the tests relative to the new WebM frame duration
parsing/derivation/defaulting.

Also includes TestExpectations update to allow these tests to fail until Chromium side lands.

BUG=351166
TBR=acolwell@chromium.org
TEST=All media layout tests pass locally on Linux (with the Chromium prereq CLs applied), and failure is allowed by TestExpectations (without the prereq CLs applied)

Review URL: https://codereview.chromium.org/212593007

git-svn-id: svn://svn.chromium.org/blink/trunk@170209 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This is a commit to make https://codereview.chromium.org/205263004/
apply cleanly.

TBR=jamesr@chromium.org
BUG=345027

Review URL: https://codereview.chromium.org/215353003

git-svn-id: svn://svn.chromium.org/blink/trunk@170208 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=356839

Review URL: https://codereview.chromium.org/214983002

git-svn-id: svn://svn.chromium.org/blink/trunk@170207 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch changes SetPropertyTextAction to use setStyleText method
instead of setPropertyText for the undo operation. This
makes it possible to successfully undo multiple property insertions.

BUG=341506

Review URL: https://codereview.chromium.org/211193006

git-svn-id: svn://svn.chromium.org/blink/trunk@170206 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This is a follow-up to r170203 to remove even more carriage returns.

TBR=jamesr@chromium.org
BUG=345027

Review URL: https://codereview.chromium.org/215403002

git-svn-id: svn://svn.chromium.org/blink/trunk@170205 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This is a pre-commit for https://codereview.chromium.org/205263004/ to
change the line-endings this file in that patch so that the patch can be
applied cleanly in rietveld.

TBR=jamesr@chromium.org
BUG=345027

Review URL: https://codereview.chromium.org/215383002

git-svn-id: svn://svn.chromium.org/blink/trunk@170203 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The previous behavior was to select all on mouse down and clear on mouse up. This matched the Cocoa NSSearchField behavior.
On Android the button may be so small users couldn't tap it reliably and only mousedown would fire.

BUG=329326

Review URL: https://codereview.chromium.org/93863007

git-svn-id: svn://svn.chromium.org/blink/trunk@170202 bbb929c8-8fbe-4397-9dbb-9b2b20218538

wrap-unwrap.html becomes these files:

 * wrapKey-unextractable.html
 * wrapKey-lacks-usage.html
 * wrapKey-badParameters.html
 * unwrapKey-lacks-usage.html
 * unwrapKey-badParameters.html

BUG=245025

Review URL: https://codereview.chromium.org/214263002

git-svn-id: svn://svn.chromium.org/blink/trunk@170201 bbb929c8-8fbe-4397-9dbb-9b2b20218538