- 21 Sep, 2020 40 commits
-
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/ef916081..d56d50c3 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ibfb481c3f298339e0122357e2615b5bcd92117cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421831Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#809008}
-
Xida Chen authored
Now that we have deprecated the Universal throughput tracker, the aggregated throughput is no longer useful and this CL removes related code. Bug: 1128993 Change-Id: I96f95a9cba1f99d8e42ccdbc1c266c41b721d08d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421760Reviewed-by:
vmpstr <vmpstr@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#809007}
-
Ryan Hansberry authored
Before this change, Nearby advertising, even in "low power" mode, was always advertising over Bluetooth Classic -- poor for battery performance, and dangerous for users' privacy. Bug: 1128179 Change-Id: Idfeab6e02c442183ec03acb9b00cc048750611e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2413175 Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
James Vecore <vecore@google.com> Reviewed-by:
Alex Gough <ajgo@chromium.org> Cr-Commit-Position: refs/heads/master@{#809006}
-
Prashant Nevase authored
Renaming lab_color_space* files to dark_mode_lab_color_space* will help identify dark mode module files easily and also help in running the all related tests using --gtest_filter=*Dark* filter. Bug: None Change-Id: I56408d6bc3c9973b03407e4265614bd1549e97bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421978Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Prashant Nevase <prashant.n@samsung.com> Cr-Commit-Position: refs/heads/master@{#809005}
-
Tommy Li authored
This spacing was provided by the designer and matches the realbox. Bug: 1128160 Change-Id: Ia5b4af4cbab04cf1b3a07eb2fa49e40a579d82be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422478 Auto-Submit: Tommy Li <tommycli@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#809004}
-
Akihiro Ota authored
This change adds a test for each type of nudge given by the tutorial. Currently there are two types, general and practice_area, so there are two tests in this patch. These tests confirm that nudges given in the general tutorial context differ from those given in the practice area. Bug: 1127045 Change-Id: I3019917f7ae5d618e976422b0fc25f54e74ef45d AX-Relnotes: N/A Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410675 Commit-Queue: Akihiro Ota <akihiroota@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#809003}
-
Austin Eng authored
In other parts of the WebGPU API, we flush lazily at the end of the task because the page needs to yield back to the browser for pending callbacks to resolve anyway. Queue submissions however may be holding lots of data which the GPU process can begin working on promptly. Frequent queue submissions will have poor command throughput if we don't flush eagerly. In the future, the WebGPU command buffer should have a better way for the Renderer process to ask the GPU process to begin processing work, and update the GPU process (in a non-blocking way) of the latest command it has finished writing. This would yield better throughput without requiring frequent flushes. Bug: 1128293 Change-Id: I19903dffc946865b11512d100b711409857b025f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417639Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Commit-Queue: Austin Eng <enga@chromium.org> Cr-Commit-Position: refs/heads/master@{#809002}
-
minch authored
Bug: 1128763, 1107058 Change-Id: Iba395be1240214924279dc3c928991b6a513d09f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419918Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Min Chen <minch@chromium.org> Cr-Commit-Position: refs/heads/master@{#809001}
-
Xinghui Lu authored
This change affects the password check row, the Safe Browsing row, and the extension row. When the state is SAFE, make the entire row clickable and display a clickable icon in the row. When the row is clicked, direct the user to its corresponding settings page. before: http://screen/ArPirizGoZhfiYz after: http://screen/76CN4UQ4a4rbk4p screen record: http://dr/file/d/1E6tBzL62Yfci7M4QqcWQm25cRX8O_7xl/view Bug: 1103015 Change-Id: I545207019b52962e0b53dd1455b2e1108c4e2b20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401812Reviewed-by:
Rainhard Findling <rainhard@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Reviewed-by:
Theodore Olsauskas-Warren <sauski@google.com> Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> Cr-Commit-Position: refs/heads/master@{#809000}
-
Jamie Madill authored
Requires an update to the Fuchsia test runner to support isolated script args. Also tweaks the arguments to the standalone tests on non-Fuchsia platforms so we can directly invoke the Fuchsia test runner. Bug: angleproject:3162 Change-Id: I8617cbcd903f0a172d5f796eb381663f2b7d5be8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418972Reviewed-by:
Dirk Pranke <dpranke@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org> Cr-Commit-Position: refs/heads/master@{#808999}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1600689096-42a268e21a38ce243e34c88881f4529ac993701d.profdata to chrome-linux-master-1600711078-15e6465f6b9c8d99add6c7e09aa1cb16b33babfa.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com,chrome-brapp-engprod@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com,chrome-brapp-engprod@google.com Change-Id: Idd60db73692a5606b158e9ea2beefa6f97103063 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422542Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#808998}
-
Betul Soysal authored
https://crrev.com/c/2327149 added a histogram to track the time taken to perform the user encrypted directory mounts. Track this on the Chromium side to see them in UMA. BUG=1074735 TEST=validate_format, pretty_print. Change-Id: Ic7f52f37f659c00818cd1eff0c00a84e894382ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2381591Reviewed-by:
Jorge Lucangeli Obes <jorgelo@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Betul Soysal <betuls@google.com> Cr-Commit-Position: refs/heads/master@{#808997}
-
Jonathan Backer authored
Certain builds of Fuchsia set low-end device flag, which forces SysInfo::AmountOfPhysicalMemory to return 512 MB. This corrects an ordering issue introduced in crrev.com/c/2419555 Bug: 1126490, 1130036 Change-Id: I8d0520cc0393864265b2ad8c4646b146b7bcf547 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421300Reviewed-by:
Peng Huang <penghuang@chromium.org> Commit-Queue: Jonathan Backer <backer@chromium.org> Cr-Commit-Position: refs/heads/master@{#808996}
-
Charlene Yan authored
Bug: 1095784 Change-Id: Ia03bd437d2339933dfa7b87ed52be79d10c58a7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386555Reviewed-by:
Taylor Bergquist <tbergquist@chromium.org> Commit-Queue: Charlene Yan <cyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#808995}
-
Xida Chen authored
This CL creates a new canvas frame tracker to track canvas invalidations in the current frame. Bug: 1111392 Change-Id: I7707720d4749ea4ceb8928a624ec86ef831610bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417249Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#808994}
-
Dave Tapuska authored
The PluginContainer loses focus when the tab is changed which makes this variable redundant. As it would assume that has_content_area_focus_ could be false while has_webkit_focus_ could be true, but that is impossible. Removing this concept simplifies the code and removes another widget callback. BUG=1097816 Change-Id: I3f1557be666b07a05b71d2be2ad756af91ccc2c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419113 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Bill Budge <bbudge@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#808993}
-
chromium-autoroll authored
Roll ChromeOS Airmont AFDO profile from 87-4247.0-1600077656-benchmark-87.0.4265.0-r1 to 87-4262.0-1600690455-benchmark-87.0.4265.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-airmont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I11bfd67898e3b42aedb682a8bc47c09c99ac11b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422307Reviewed-by:
-
Yue Li authored
Extend the expiry milestone of Quick Answers related feature flag. Bug: None Test: Locally build and test Change-Id: I2df16ed1037d5f333cf864c1d697b0ec8c636587 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419752 Auto-Submit: Yue Li <updowndota@chromium.org> Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#808991}
-
Mason Freed authored
NOTRY=true TBR=tkent@chromium.org Change-Id: I5dfae4f34113699296028eb0566b3b479ad16959 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422443Reviewed-by:
Mason Freed <masonfreed@chromium.org> Commit-Queue: Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#808990}
-
Ian Vollick authored
Looks like AddressAccessoryController::GetIfNeeded is not currently being called. Bug: None Change-Id: I4e717c1b481958b79a77bee4615b2d25c9663ee8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416808Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
sebsg <sebsg@chromium.org> Commit-Queue: sebsg <sebsg@chromium.org> Auto-Submit: Ian Vollick <vollick@chromium.org> Cr-Commit-Position: refs/heads/master@{#808989}
-
Yusuf Sengul authored
Bug: 1114381 Change-Id: Ia5b0ae4e408ae770cbed0086dc6ff269793ea876 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343955Reviewed-by:
Rakesh Soma <rakeshsoma@google.com> Commit-Queue: Yusuf Sengul <yusufsn@google.com> Cr-Commit-Position: refs/heads/master@{#808988}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/05f0bbb70bde..37f4b38fcbc4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC hesen@google.com,etiennep@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: hesen@google.com,etiennep@google.com Change-Id: I299cec8fba8c4a215e9802438372d136829fc825 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422216Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#808987}
-
Matt Jones authored
Since SceneOverlays are no longer a per-layout construct, it is possible for the layer tree to become stale. Overlays may continue holding a layout's SceneLayer post being hidden. This patch adds the ability of a SceneLayer to remove itself from its parent. This happens after the layout has been hidden. Bug: 1128279 Change-Id: Iab8f1f36487bf021868591d9013c4852141ae690 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414614Reviewed-by:
Mei Liang <meiliang@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#808986}
-
Brian Sheedy authored
Fixes an issue in the Skia Gold Python code where if initialization failed the first time, subsequent attempts would fail due to trying to use a potentially deleted JSON file. This is fixed by making a copy on object creation that is used instead of the provided file. Bug: 1077274 Change-Id: I03ca402ed27bfedf81de320863c6c1946733b46e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419691 Auto-Submit: Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#808985}
-
Kartik Hegde authored
When the socket connections don't need to be made, return early. BUG=chromium:956783 TEST=unit_tests --gtest_filter=HttpFirewallRoutineTest* Change-Id: I51f2a42fd141742d89f1f75e91b02e14242ae666 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2420569Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Kartik Hegde <khegde@chromium.org> Cr-Commit-Position: refs/heads/master@{#808984}
-
chromium-autoroll authored
Roll ChromeOS Broadwell AFDO profile from 87-4247.0-1600076215-benchmark-87.0.4265.0-r1 to 87-4247.0-1600681610-benchmark-87.0.4265.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-broadwell-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: Ib4a7889d5791ccd3ba9865050c4504053cd7d26a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422186Reviewed-by:
-
chromium-autoroll authored
Roll ChromeOS Silvermont AFDO profile from 87-4247.0-1600080536-benchmark-87.0.4265.0-r1 to 87-4258.0-1600689257-benchmark-87.0.4265.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-silvermont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I56f13173cff64b8630070328cf938f958e2eb40b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422308Reviewed-by:
-
Olivier Yiptong authored
This change switches the Mac font enumeration API backend to use the browser-side implementation. This makes it in-line with all the other platforms and simplifies the code. The renderer-side implementation is removed as well. Fixed: 1119575,1061625,1063172 Bug: 2410594 Change-Id: I3751a5ac7496f6990f4e1f7132e068900e0a1cf2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2411330Reviewed-by:
Dominik Röttsches <drott@chromium.org> Reviewed-by:
Martin Barbella <mbarbella@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Commit-Queue: Olivier Yiptong <oyiptong@chromium.org> Cr-Commit-Position: refs/heads/master@{#808981}
-
John Delaney authored
What: Stop reporting the AsyncTask from LocalDomWindow::DisaptchPostMessage() to the ad tracker. Why: A common loading flow for pages is: - show an ad in an iframe - wait for a postmessage from the ad to indicate it has finished - render some content Currently, anything a non-ad script does in response to a postMessage from an ad iframe gets considered an ad. We would like to use the ad status of the script processing the postMessage as a sole indicator of whether an ad is being created, rather than the frame the message was sent from. This is only an issue for same-renderer postMessages, as we currently do not route any information alongside the messages sent to a different renderer. Bug: 1127829 Change-Id: Id3e5e8c9fa313ad50fa915c28114c7fc11bbc1f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416747 Commit-Queue: John Delaney <johnidel@chromium.org> Reviewed-by:
Nate Chapin <japhet@chromium.org> Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Cr-Commit-Position: refs/heads/master@{#808980}
-
Eric Lawrence authored
Update the code's comment to match the behavior; HKCU is checked first, and then HKLM is consulted. Bug: 1034919 Change-Id: I9e649766b6ce2328322b287267c97e9344449075 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2393975Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: Eric Lawrence [MSFT] <ericlaw@microsoft.com> Cr-Commit-Position: refs/heads/master@{#808979}
-
Glen Robertson authored
Exclusion was added as a workaround in crrev.com/c/2413427 Bug: 1126800 Change-Id: If0b09f564288810cd89e910aa8c463dd5bdef25f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417474 Auto-Submit: Glen Robertson <glenrob@chromium.org> Commit-Queue: Carlos Pizano <cpu@chromium.org> Reviewed-by:
Carlos Pizano <cpu@chromium.org> Cr-Commit-Position: refs/heads/master@{#808978}
-
Dominique Fauteux-Chapleau authored
This reverts commit a9fc4ecc. Reason for revert: b/169019687 Original change's description: > Remove UnsafeEventReportingEnabled policy > > This should not change deep scanning behaviour with Connectors since > OnSecurityEventEnterpriseConnector replaces this policy. Removing this > policy completely is safe since it was marked as future and it has only > been delivered as a cloud policy. > > Bug: 1103390 > Change-Id: Ie886239acd53e28c5a9104812738b7627d082a47 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414550 > Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org> > Reviewed-by: Owen Min <zmin@chromium.org> > Reviewed-by: Daniel Rubery <drubery@chromium.org> > Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> > Cr-Commit-Position: refs/heads/master@{#808361} TBR=rogerta@chromium.org,pastarmovj@chromium.org,zmin@chromium.org,drubery@chromium.org,domfc@chromium.org BYPASS_POLICY_COMPATIBILITY_CHECK='future was already in use on the policy' Bug: 1103390 Change-Id: I59f8bb3b5925acdbd6e66fdb80a592a898dde4eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422165 Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Reviewed-by:
Dominique Fauteux-Chapleau <domfc@chromium.org> Cr-Commit-Position: refs/heads/master@{#808977}
-
Aleks Totic authored
I believed that empty-cells:hide was a css attribute on table, that afffects how cells are drawn. This was wrong. empty-cells:hide is a css property of a cell, inherited via CSS. Old way made this test fail: external/wpt/css/CSS2/tables/empty-cells-applies-to-014.xht Bug: 958381 Change-Id: I0fcc09bec995fd743e31d9e9ad688431e92f666e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416840 Commit-Queue: Aleks Totic <atotic@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#808976}
-
Joon Ahn authored
Add escapes for special characters in param names and values. This is a reland of efbdaef4 Original change's description: > flags: Add support for FEATURE_WITH_PARAMS_VALUE_TYPE feature in switches > > Fixed:805766 > Test:autoninja -C out/mychrome components_tests && ./out/mychrome > components_tests > TESTED=autoninja -C out_hatch/Release chrome && deploy_chrome > --build-dir=out_hatch/Release --device=$DUT > > Verified by setting a feature with param in chrome://flags on hatch > > Change-Id: I83f8c81237c3db50a4f23bf5b17e73363bf10504 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401336 > Commit-Queue: Weilun Shi <sweilun@chromium.org> > Reviewed-by: Weilun Shi <sweilun@chromium.org> > Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> > Cr-Commit-Position: refs/heads/master@{#806278} Change-Id: If059b946bd8596aebec440e14e5f6a8a66b222da Fixed: 1130035 Bug: 805766 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419636 Auto-Submit: Joon Ahn <joonbug@chromium.org> Reviewed-by:
Weilun Shi <sweilun@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#808975}
-
nancylingwang authored
The ARC side has used the new icon request mojom interfaces, so the old icon request mojom interfaces in the Chromium side can be removed. BUG=1083331 Change-Id: I8421d58c035564ca6e9b944775bec85a11f4d5c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346093Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Long Cheng <lgcheng@google.com> Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#808974}
-
James Cook authored
There's no per-platform difference for this function, so consolidate the two copies into one in first_run.cc. No functional changes - this is just cleanup in preparation for a first-run change for the go/lacros project. Bug: 1129954 Test: existing unit_tests Change-Id: I9871f2501f87fdd88f2e7598d0d43cf14fef59ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418570 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#808973}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/078776328d3b..9f70b6b2054f 2020-09-21 jmadill@chromium.org Disable slow max uniform count test on D3D11/Intel. 2020-09-21 jmadill@chromium.org Rename ShaderImpl::mData to mState. 2020-09-21 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from d6935becabad to 0a863bc36554 (1 revision) 2020-09-21 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-Headers from f0e102e48197 to 7f9879b1b1fa (1 revision) 2020-09-21 angle-autoroll@skia-public.iam.gserviceaccount.com Roll glslang from 9eaa69c21c45 to 4dcc12d1a441 (1 revision) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: syoussefi@google.com Change-Id: I2063179b5616fa2fbb4dfd0e5d02f84179de1bbd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422202Reviewed-by:
-
Tarun Bansal authored
This allows us to experiment with larger values for retry delay (e.g., value of 5 seconds would ensure that most of the preconnects finish by that time). Larger values would result in subsequent preconnects being not no-op. Change-Id: I0f35fce774ee752ede434806e7b23f3d1b724e4e Bug: 1130607 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419556Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#808971}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chonggu@google.com Change-Id: I214994a5a3dc38959f60ac788bd41e3bcc0a1fa6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422212Reviewed-by:
-
Haiyang Pan authored
* StartSurfaceLayoutTest#testShowOnlyOneTabSuggestionMessageCard_withSoftCleanup * StartSurfaceLayoutTest#testShowOnlyOneTabSuggestionMessageCard_withHardCleanup Bug: 1130621 Change-Id: I47b1fb54d491fb9973ad2d3be564011775d5505a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422438 Auto-Submit: Haiyang Pan <hypan@google.com> Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#808969}
-
