- 14 Jul, 2017 40 commits
-
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/83d118550f72..cf79ee5626dd $ git log 83d118550..cf79ee562 --date=short --no-merges --format='%ad %ae %s' 2017-07-14 rmistry Publish uploaded RecreateSKPs CL Created with: roll-dep src/third_party/skia Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=ethannicholas@chromium.org Change-Id: I49e94ec456b566d09c9708f326625548e70782bc Reviewed-on: https://chromium-review.googlesource.com/570733Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#486760}
-
Hidehiko Abe authored
While migrating ArcService into BrowserContextKeyedService, it turned out the boilerplate looks much bigger than what we expected. To minimize it reasonably, this CL introduces ArcBrowserContextKeyedServiceFactoryBase and use it for already migrated service classes. BUG=739097 TEST=Ran trybot. Ran on DUT. Change-Id: I13a1e7019c06ea64fa48cec6ecf7a9e589e84b00 Reviewed-on: https://chromium-review.googlesource.com/569847Reviewed-by:
Paweł Hajdan Jr. <phajdan.jr@chromium.org> Reviewed-by:
Luis Hector Chavez <lhchavez@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Commit-Queue: Hidehiko Abe <hidehiko@chromium.org> Cr-Commit-Position: refs/heads/master@{#486759}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/a97abb90..3921afc2 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org Change-Id: Iaa2269f32243c34ca9813ed72c2650a4ab3f34db Reviewed-on: https://chromium-review.googlesource.com/571271Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#486758}
-
nednguyen authored
Bug: 742422 Change-Id: If2f10cf42ffad4c9767571b076242388d86c11c5 Reviewed-on: https://chromium-review.googlesource.com/570679 Commit-Queue: Ned Nguyen <nednguyen@google.com> Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#486757}
-
jdoerrie authored
This is a reland of 37c3e0b6 Original change's description: > Add Dictionary API to base::Value > > This change introduces |FindKey|, |FindKeyOfType|, |SetKey|, |DictEnd| and > |DictItems| to base::Value. These methods are part of the new API proposal and > abstract away the pointer based underlying storage of Dictionary Values. > > Bug: 646113 > Change-Id: I09150f3b2fd47e24074caa50a30a058fc4f558a7 > Reviewed-on: https://chromium-review.googlesource.com/561682 > Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> > Reviewed-by: Brett Wilson <brettw@chromium.org> > Reviewed-by: Vladimir Levin <vmpstr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#486709} TBR=brettw@chromium.org Bug: 646113 Change-Id: I76ee2149f18da83474a16586ee77b8e6be185814 Reviewed-on: https://chromium-review.googlesource.com/571805Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#486756}
-
Alexei Svitkine (slow) authored
This reverts commit 34b11e87. Reason for revert: Causing crashes: crbug.com/742707 Original change's description: > Add the VariationsFieldTrialCreator class > > This is part 3 of 6 for FieldTrial refactoring for WebView > > Part 1: https://chromium-review.googlesource.com/c/562098/ > Part 2: https://chromium-review.googlesource.com/c/561920/ > Part 3: https://chromium-review.googlesource.com/c/561922/ > Part 4: https://chromium-review.googlesource.com/c/561980/ > Part 5: https://chromium-review.googlesource.com/c/562417/ > Part 6: https://chromium-review.googlesource.com/c/562021/ > > This CL creates the VariationsFieldTrialCreator class. This class > contains the code previously in VariationsService that > is needed by both Chrome and WebView, mainly the portions > needed to call CreateTrialsFromSeed. The VariationsService > class now contains an instance of this new class. > > BUG=678288 > > Change-Id: Ic4340d5a0396cca56892a3b541e4cf6115bb8afb > Reviewed-on: https://chromium-review.googlesource.com/561922 > Commit-Queue: Kyle Milka <kmilka@google.com> > Reviewed-by: Alexei Svitkine (slow) <asvitkine@chromium.org> > Cr-Commit-Position: refs/heads/master@{#486590} TBR=asvitkine@chromium.org,timav@chromium.org,paulmiller@chromium.org,kmilka@google.com Change-Id: Idf0f12b5bd6d1bb7edf41cbdc6f767f8790de6e9 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 678288 Reviewed-on: https://chromium-review.googlesource.com/571920Reviewed-by:
Alexei Svitkine (slow) <asvitkine@chromium.org> Commit-Queue: Alexei Svitkine (slow) <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#486755}
-
rbpotter authored
Add tests to verify print preview behaves as expected when the "Open PDF in Preview" link is clicked on MacOS, and when "Print with System Dialog" is clicked on Windows. Bug: 741341, 741528 Change-Id: I1174ec935eeea1b90e7853eb1e13d1fe3c596809 Reviewed-on: https://chromium-review.googlesource.com/570831 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#486754}
-
Adam Rice authored
This CL was generated by running pyformat and then applying manual fixes to the result. The command-line used was: pyformat --indent_size=4 -r -i --force_quote_type single . Long comments, strings, if conditions and assignments that had been left behind by pyformat were manually broken to make the pep8 tool happy. There are still some things the pep8 tool complains about: * pyformat wraps to 80 columns, but pep8 wants lines to be at most 79 characters. 80-column lines have been left as-is as it doesn't seem worth fixing. * handshake-fail-by-maxlength_wsh.py and handshake-fail-by-prepended-null_wsh.py have copyright messages with lines longer than 80 columns. Not changed. Bug: 237056 Change-Id: I8ff73bc1e677975e1a99d86815971750b275a0a3 Reviewed-on: https://chromium-review.googlesource.com/570080Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#486753}
-
Michael van Ouwerkerk authored
Bug: 739664 Change-Id: I0f847bec2b9034206588aad4aedfc3703d49ee7c Reviewed-on: https://chromium-review.googlesource.com/571001 Commit-Queue: Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Cr-Commit-Position: refs/heads/master@{#486752}
-
Vaclav Brozek authored
Vasilii is the password manager team's expert on Objective C, knows password manager code thoroughly and has experience in iOS codebase as well. An ideal //ios/chrome/browser/passwords/OWNERS. Bug: None Change-Id: I5725b9da385fd73d97e71e8b9368841da3974130 Reviewed-on: https://chromium-review.googlesource.com/571224Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#486751}
-
Bernhard Bauer authored
This works around an issue where in official builds of unit_tests the ThreadTaskRunnerHandle is null when calling into native code from Java. Bug: 739510 Change-Id: Ide93e67076f905d03a6a9271a812e49553dcf0d8 Reviewed-on: https://chromium-review.googlesource.com/570251Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Bernhard Bauer <bauerb@chromium.org> Cr-Commit-Position: refs/heads/master@{#486750}
-
Brian White authored
This is temporary to try to discover the source of the memory corruption and possible deduce where it is happening. Bug: 736675 Change-Id: I08f3b8cbfe1ae47b6872694300a7eb87c14fa7f0 Reviewed-on: https://chromium-review.googlesource.com/570458Reviewed-by:
Alexei Svitkine (slow) <asvitkine@chromium.org> Commit-Queue: Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#486749}
-
Friedrich Horschig authored
Following Mac10.10, Mac10.11 broke, too. Mark flaky for all Mac platforms so sheriffs don't have to look for this when it hits Mac10.9. TBR=dcheng@chromium.org TBR_REASON=Update test expectations NOTRY=true Bug: 676229,742742 Change-Id: Iecda3eb55b891dc35ed47552b43786e80f9f4aa3 Reviewed-on: https://chromium-review.googlesource.com/571788Reviewed-by:
Friedrich Horschig <fhorschig@chromium.org> Commit-Queue: Friedrich Horschig <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#486748}
-
Becca Hughes authored
Record the Media Engagement score at playback to a histogram so we can see if the playback would have been blocked. BUG=740106 Change-Id: I7ed9659e64fd9ffcae3eafaccdf32e6755165ccb Reviewed-on: https://chromium-review.googlesource.com/566862 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Cr-Commit-Position: refs/heads/master@{#486747}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/a29b8877..a97abb90 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org Change-Id: I8f2f3087cca1f5aa2da0edeef6f65e6ed829bdd6 Reviewed-on: https://chromium-review.googlesource.com/571260Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#486746}
-
Takashi Toyoshima authored
Current implementation dispatch MIDIConnectionEvent synchronously, but this should be done asynchronously according to the spec. BUG=735058 Change-Id: If49d588e36e092aa6fc40625fd88483c9ae1719d Reviewed-on: https://chromium-review.googlesource.com/545577 Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#486745}
-
dskiba authored
> Reason for revert: > This broke Win 64: > https://build.chromium.org/p/chromium.win/buildstatus?builder=Win%20x64%20Builder%20%28dbg%29&number=56316 > > Original issue's description: > > [tracing] Add heap profiler perftests. > > > > This CL creates a generic place for heap profiler perftests, and adds > > couple of stack frame deduplicator related perftests. > > > > BUG=739378 > > > > Review-Url: https://codereview.chromium.org/2976843002 > > Cr-Commit-Position: refs/heads/master@{#486544} > > Committed: https://chromium.googlesource.com/chromium/src/+/f43d398eac5c9d4c2bccda6d2630d108bbed1c99 > > TBR=primiano@chromium.org,dskiba@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=739378 > > Review-Url: https://codereview.chromium.org/2981833002 > Cr-Commit-Position: refs/heads/master@{#486555} TBR=primiano@chromium.org BUG=739378 Review-Url: https://codereview.chromium.org/2975133004 Cr-Commit-Position: refs/heads/master@{#486744}
-
Nicolas Dossou-gbete authored
In addition to the All Dismissed item, we now also hide the footer that holds the Learn More link and the space at the bottom of the NTP when remote suggestions are disabled. Bug: 721407 Change-Id: I660f627c0d6fb0f9370e9604437d43227a5dafae Reviewed-on: https://chromium-review.googlesource.com/570447 Commit-Queue: Nicolas Dossou-Gbété <dgn@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Cr-Commit-Position: refs/heads/master@{#486743}
-
Hector Dearman authored
A refactor (crrev.com/c/555497) I made to ProcessMetricsMemoryDumpProvider which split logic out by platform introduced a bug. The bug caused us to double count rss anon bytes and never count vm swap bytes when computing the 'private footprint' UMA on all processes on Linux and Android. This produced a large increase in those UMA metrics. This fixes the bug. Bug: 742958 Change-Id: I893774e95154f50be0f30698b17c01ec4bfbcb1d Reviewed-on: https://chromium-review.googlesource.com/571804 Commit-Queue: Hector Dearman <hjd@chromium.org> Reviewed-by:
Primiano Tucci <primiano@chromium.org> Cr-Commit-Position: refs/heads/master@{#486742}
-
Mounir Lamouri authored
Adding the necessary scaffolding to compute the CTR of media controls elements with as much precision as possible. This is not computing CTR using visibility to the user but hypothetical visibility on the page in the sense that the element was displayed in the controls but maybe never scrolled into view. In order for an element to be marked as displayed, the element has to have metadata downloaded or be set to not preload by the page or the browser. This CL also removes the CTR code for the download button and the cast overlay button given that this code is more precise and more generic. Bug: 651644 Change-Id: I86c2bc4d1a19ab99a211082d8b3546b79ea71144 Reviewed-on: https://chromium-review.googlesource.com/567194 Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Jennifer Apacible <apacible@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#486741}
-
Hiroki Nakagawa authored
To improve code maintainability, this CL clarifies thread affinity of initialization and shutdown functions in worker classes. This does not change any existing behavior. Bug: 741227 Change-Id: I25fe7278130c90292b79cdd5607f10a0ef92f198 Reviewed-on: https://chromium-review.googlesource.com/567609 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#486740}
-
tommi authored
Revert of Override rtc::Event with Chromium's implementation (patchset #2 id:20001 of https://codereview.chromium.org/2975553002/ ) Reason for revert: Reverting temporarily until the webrtc change can be rolled with it. Original issue's description: > Preparation of overriding WebRTC's rtc::Event with Chromium's implementation. > This change will give WebRTC the benefits of Chromium's checks and integration with thread and sequence runners (e.g. io and waitable checks). > > Followup changes include enabling the code from the WebRTC side (requires build file changes) and integrating the TaskQueue implementation in Chromium with sequence runners. > > BUG=689520 > NOTRY=true > > Review-Url: https://codereview.chromium.org/2975553002 > Cr-Commit-Position: refs/heads/master@{#486737} > Committed: https://chromium.googlesource.com/chromium/src/+/07019da77f12dc06fd8a2e66061c8a79c90bc439 TBR=grunell@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=689520 Review-Url: https://codereview.chromium.org/2981863002 Cr-Commit-Position: refs/heads/master@{#486739}
-
Rob Buis authored
Bug: 402536 Change-Id: I502447b230e2b587e4fd5f921be86053cf9830ed Reviewed-on: https://chromium-review.googlesource.com/568564Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Rob Buis <rob.buis@samsung.com> Cr-Commit-Position: refs/heads/master@{#486738}
-
tommi authored
This change will give WebRTC the benefits of Chromium's checks and integration with thread and sequence runners (e.g. io and waitable checks). Followup changes include enabling the code from the WebRTC side (requires build file changes) and integrating the TaskQueue implementation in Chromium with sequence runners. BUG=689520 NOTRY=true Review-Url: https://codereview.chromium.org/2975553002 Cr-Commit-Position: refs/heads/master@{#486737}
-
Friedrich Horschig authored
TBR=dcheng@chromium.org TBR_REASON=Update test expectations NOTRY=true Bug: 676229,742742 Change-Id: I1aaf376ad020c6a4d8c2aec85714ef627132c7a2 Reviewed-on: https://chromium-review.googlesource.com/571704 Commit-Queue: Friedrich Horschig <fhorschig@chromium.org> Reviewed-by:
Friedrich Horschig <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#486736}
-
Daniel Bratell authored
Some global "using namspace WTF" caused problems with jumbo builds and since WTF is also meant to be used without using namespace WTF this patch just replaces them with explicit namespaces. Bug: Change-Id: Ifc06e163c095de0e2ce5a8c69123578557ef0dee Reviewed-on: https://chromium-review.googlesource.com/565413Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: bratell at Opera <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#486735}
-
Juan A. Navarro Perez authored
Use --browser=android-webview on trybot command when selected bots include webview. NOTRY=True Bug: 740845 Change-Id: Ib1d7f436a6d290a9cb63a3f7aaebfb92581e07d8 Reviewed-on: https://chromium-review.googlesource.com/567933 Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> Reviewed-by:
Simon Hatch <simonhatch@chromium.org> Cr-Commit-Position: refs/heads/master@{#486734}
-
Alexander Timin authored
R=rmcilroy@chromium.org BUG=739750 Change-Id: Iccb5f8ecaf72f2c73b2d23bd2c29bc2e2cb88cfe Reviewed-on: https://chromium-review.googlesource.com/570420Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Commit-Queue: Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#486733}
-
Tatsuhisa Yamaguchi authored
TEST=manually tested get-info command enabled for single selection and disabled for multiple selection TEST=manually tested chrome://histograms records the new way to open QuickView as #2. Bug: 740842 Change-Id: I3c9d58f7d3877e7b059bb386a56cdc8d4e54a43b Reviewed-on: https://chromium-review.googlesource.com/571380 Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Reviewed-by:
Naoki Fukino <fukino@chromium.org> Cr-Commit-Position: refs/heads/master@{#486732}
-
Friedrich Horschig authored
This reverts commit 37c3e0b6. Reason for revert: Breaks some bots[1] due to ValueIteratorsTest.ConstDictIteratorOperatorNE attempting to compare iterators from different sequences. Did you mean to compare contents? [1] e.g. https://uberchromegw.corp.google.com/i/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%281%29/builds/28161 Original change's description: > Add Dictionary API to base::Value > > This change introduces |FindKey|, |FindKeyOfType|, |SetKey|, |DictEnd| and > |DictItems| to base::Value. These methods are part of the new API proposal and > abstract away the pointer based underlying storage of Dictionary Values. > > Bug: 646113 > Change-Id: I09150f3b2fd47e24074caa50a30a058fc4f558a7 > Reviewed-on: https://chromium-review.googlesource.com/561682 > Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> > Reviewed-by: Brett Wilson <brettw@chromium.org> > Reviewed-by: Vladimir Levin <vmpstr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#486709} TBR=vmpstr@chromium.org,brettw@chromium.org,jdoerrie@chromium.org Change-Id: I1f0e287a99fb5ebd6f228b762d77e446bac5b3af No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 646113 Reviewed-on: https://chromium-review.googlesource.com/571782Reviewed-by:
Friedrich Horschig <fhorschig@chromium.org> Commit-Queue: Friedrich Horschig <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#486731}
-
Yutaka Hirano authored
This CL cleans up preload related states in Resource as following: - Removes preload_count_ and introduces is_unused_preload_. With this change, a resource can be a preload for only one request, and hence tied to one ResourceFetcher at a time. - Renames IncreasePreloadCount and DecreasePreloadCount to MarkAsPreload and MatchPreload respectively. - Removed preload_result_. - Changes the timing of kPreloadNotReferenced => kPreloadReferenced (i.e., true => false for is_unused_preload_) state transition from when a ResourceClient is added to when MatchPreload is called. - Removes PreloadReferencePolicy. Bug: 652228 Change-Id: I6564c0eed24f19051ee49c429cf87db746414023 Reviewed-on: https://chromium-review.googlesource.com/544363 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Yoav Weiss <yoav@yoav.ws> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Takeshi Yoshino <tyoshino@chromium.org> Cr-Commit-Position: refs/heads/master@{#486730}
-
Marc Treib authored
Hidden behind new feature CaptureThumbnailOnNavigatingAway. This is very similar to what NavigationEntryScreenshotManager does. Hopefully this is a better time for capturing screenshots than when a page load finishes (see crbug.com/737396 and crbug.com/741856). Bug: 718413 Change-Id: I0fbcc7964b9f89c7ce589a197ac85b85a41385ba Reviewed-on: https://chromium-review.googlesource.com/570318Reviewed-by:
Friedrich Horschig <fhorschig@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#486729}
-
Dominic Battre authored
Replace constexpr char[] with extern const char[] in header because we are unsure whether the former does the right thing or whether there is a risk of unnecessary overhead. NOTRY=true Bug: 732846 Change-Id: Ic328d6568325072cef6ab7b9b9b0ce36bb587cb0 Reviewed-on: https://chromium-review.googlesource.com/571747 Commit-Queue: Dominic Battré <battre@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#486728}
-
Kunihiko Sakamoto authored
This adds UMA to track the peak number of requests with "running" state in ResourceLoadScheduler. The value is reported when the frame is reached the network 2-quiet state. Bug: 729951 Change-Id: I6d2c6f5f5094a0a8071904484cb10d14de087e7c Reviewed-on: https://chromium-review.googlesource.com/564872Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#486727}
-
Kouhei Ueno authored
The task handle is never cancelled, so it can be replaced w/ a simple PostTask. The task lifetime is managed by weakPersistent anyways. Bug: None Change-Id: I191c9cad4982c42ba5d0177d1464d32b31bc2354 Reviewed-on: https://chromium-review.googlesource.com/571110Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#486726}
-
Yoichi Osato authored
This is preparation to split LayoutSelection start/end calculation w/o canonicalization. Bug: 739062 Change-Id: I8574fec9a82433e0b7313499db2f3068d9388b22 Reviewed-on: https://chromium-review.googlesource.com/571523Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#486725}
-
yhanada authored
Android notifications from ARC++ implement inline reply feature, so it needs to be able to open the virtual keyboard and the message center simultaneously. - Pass the hit NativeView instead of the hit Widget to OnPointerEventObserved. - Do not call ClickedOutsideBubble when clicking on the virtual keyboard. Bug: 722248 Test: Unit tests are added. Change-Id: I7df8a1ec6cf2c1af4a5e7274cb93c8af6b3e1022 Reviewed-on: https://chromium-review.googlesource.com/532768 Commit-Queue: Yuichiro Hanada <yhanada@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#486724}
-
Nicolas Dossou-gbete authored
This is a reland of 139a79ec Original change's description: > [Suggestions] Remove CTAs when feature is disabled > > Stops showing the Sign in Promo and the All Dismissed item when remote > suggestions are disabled and performing the advertised actions would not > provide the user with new suggestions. > > Part of this CL involves making the SuggestionsSources notifies a list > of observer rather than a single one. > > Bug: 738872 > Change-Id: I16c300fb14a1d5780578387d48d848570339befe > Reviewed-on: https://chromium-review.googlesource.com/567182 > Reviewed-by: Bernhard Bauer <bauerb@chromium.org> > Commit-Queue: Nicolas Dossou-Gbété <dgn@chromium.org> > Cr-Commit-Position: refs/heads/master@{#486034} Bug: 738872 Change-Id: Ifc5f6643b4402657b9a62e08596d9e3267ce79a8 Reviewed-on: https://chromium-review.googlesource.com/571722Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Commit-Queue: Nicolas Dossou-Gbété <dgn@chromium.org> Cr-Commit-Position: refs/heads/master@{#486723}
-
Takeshi Yoshino authored
Bug: Change-Id: Ib3b20abc3e21e02bca2aa597342ad9907c1b23aa Reviewed-on: https://chromium-review.googlesource.com/571252Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Takeshi Yoshino <tyoshino@chromium.org> Cr-Commit-Position: refs/heads/master@{#486722}
-
jdoerrie authored
This change adds support for app display names to Password UI Utils. This is useful for the more human friendly display of Android credentials, as this will display the Play Store name of the App, if available. Bug: 628988, 617094, 679434 Change-Id: Ide7bc694805ce40cbbccf8e8496c32bcb677de25 Reviewed-on: https://chromium-review.googlesource.com/567936 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Reviewed-by:
Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#486721}
-