- 07 Feb, 2020 24 commits
-
-
Carlos Knippschild authored
This reverts commit e80df6f2. Reason for revert: seems to have broken builder "Network Service Linux" Original change's description: > [Extensions] Revert changes to icon loading JS function. > > Bug: 1049214 > Change-Id: I64018260d06070da03821bbcb72578de62359be3 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042313 > Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org> > Commit-Queue: David Bertoni <dbertoni@chromium.org> > Cr-Commit-Position: refs/heads/master@{#739076} TBR=lazyboy@chromium.org,dbertoni@chromium.org Change-Id: I4cf9a417bdf5b13aad77d6a4cb054a27dbe6a42f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1049214, 1049467 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2043003Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Commit-Queue: Carlos Knippschild <carlosk@chromium.org> Cr-Commit-Position: refs/heads/master@{#739198}
-
Yuichiro Hanada authored
All usages of the old RewriteEvent() method are removed from event_rewriter_unittest.cc by this CL. Bug: 1049489 Test: unit_tests Change-Id: Id11990b3fa421df6de8d6ddefd60c96dae95b573 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041151Reviewed-by:
Kevin Schoedel <kpschoedel@chromium.org> Commit-Queue: Yuichiro Hanada <yhanada@chromium.org> Cr-Commit-Position: refs/heads/master@{#739197}
-
Brian White authored
Updates the expires_after attribute for 39 histograms that have been used to generate alerts in the past 90 days and do not already have a date later than or within 30 days of 2020-08-24. Change-Id: I9f5fee9ee82d0b76b50cd2b311cd07d9b6556646 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042261 Commit-Queue: Brian White <bcwhite@google.com> Commit-Queue: Brian White <bcwhite@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#739196}
-
John Budorick authored
Bug: 1048790 Change-Id: Id9cecf0c6a621c4688fe8b4a8961d7dee5f466d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2038079 Commit-Queue: John Budorick <jbudorick@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#739195}
-
Olivier Li authored
Currently even if hangs are detected they will not be reported. See https://crbug.com/440885. Furthermore we are actively developing the replacement to this solution which aims to eliminate the false positives that caused the deactivation in the first place. Bug: 1034046 Change-Id: Ifc29ae961bc8b75d04fe6bdc6e205c72a763a9da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042292Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Oliver Li <olivierli@chromium.org> Cr-Commit-Position: refs/heads/master@{#739194}
-
Omer Katz authored
This is part of an ongoing effort to simplify heap collections and limit the types they can support (specifically, this CL removes the only existing non-member usage of HeapDeque). Bug: 1047147 Change-Id: I55995763db8c36d893a57a32ea04e38981917d36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013243 Commit-Queue: Omer Katz <omerkatz@chromium.org> Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#739193}
-
Ovidio Henriquez authored
This change allows the permissions for Web Bluetooth to go through the BluetoothChooserContext when NewWebBluetoothPermissionsBackend is enabled. Since the Web Bluetooth API implementation is in content/ a delegate class is required to allow WebBluetoothServiceImpl to access the BluetoothChooserContext in chrome/. Design doc: https://docs.google.com/document/d/1h3uAVXJARHrNWaNACUPiQhLt7XI-fFFQoARSs1WgMDM/edit?usp=sharing Bug: 589228 Change-Id: Ie95bd78368d9891168a50c280ca06dd0d8feff9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949530 Commit-Queue: Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#739192}
-
Austin Eng authored
These tests are having flaky timeouts very often. Tbr=kbr@chromium.org Bug: 1049138 Change-Id: I5e9ee1f4499c74b8c039e42077fad8210b0104b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042303Reviewed-by:
Austin Eng <enga@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Austin Eng <enga@chromium.org> Cr-Commit-Position: refs/heads/master@{#739191}
-
Ken MacKay authored
Change-Id: If7c10365ff4b69c543150cd51dd74a50662bac07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042325Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Commit-Queue: Kenneth MacKay <kmackay@chromium.org> Cr-Commit-Position: refs/heads/master@{#739190}
-
Kent Tamura authored
If 'display' property value is one of 'inline-grid', 'grid', 'inline-flex', and 'flex', <button> doesn't use LayoutButton. This behavior follows https://html.spec.whatwg.org/C/#button-layout . Bug: 700029 Change-Id: I017734ad773eed6531e0dc665f80b99e8f14d1d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040796 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#739189}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/4f68f5398d7f..f12231d74209 git log 4f68f5398d7f..f12231d74209 --date=short --first-parent --format='%ad %ae %s' 2020-02-06 mmoroz@chromium.org Add wildcard visibility to video_replay to make it buildable in Chromium. 2020-02-06 terelius@webrtc.org Move packet type enum from RtpPacketToSend to rtp_rtcp_defines.h 2020-02-06 sprang@webrtc.org Revert "Remove PlayoutDelayOracle and make RtpSenderVideo guarantee delivery" 2020-02-06 minyue@webrtc.org Add clock skew estimate between sender and receiver in RemoteNtpTimeEstimator. Created with: gclient setdep -r src/third_party/webrtc@f12231d74209 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:942546 Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I8fcb60c807f19a03b4379f2761a532373229fb2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042778Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#739188}
-
Kent Tamura authored
This is a reland of 882f5709 There are no differences from the original CL, which was reverted due to a dependency. Original change's description: > Remove GetText(), ClientPaddingLeft(), and ClientPaddingRight() of LayoutMenuList > > Fold them into their callsites. > This CL has no behavior changes. > > Bug: 1040828 > Change-Id: Iac6c8c1e061993534e7f7ed45d60139ec9cd63e3 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2038196 > Reviewed-by: Yoshifumi Inoue <yosin@chromium.org> > Commit-Queue: Kent Tamura <tkent@chromium.org> > Cr-Commit-Position: refs/heads/master@{#738490} Tbr: yosin@chromium.org Bug: 1040828 Change-Id: Ifec8fec3ed80c1cdfc92661b8ea9387c8c5d1c17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041372Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#739187}
-
David Tseng authored
Change-Id: Icedbb49a07fd4ba258b94d9bb30509adbfc42f9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2039346Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#739186}
-
chromium-autoroll authored
https://chromium.googlesource.com/openscreen.git/+log/39dda173e881..7d8b92dfc7b5 git log 39dda173e881..7d8b92dfc7b5 --date=short --first-parent --format='%ad %ae %s' 2020-02-06 jophba@chromium.org Fix fuzzing 2020-02-06 jophba@chromium.org Add multithreaded decoding Created with: gclient setdep -r src/third_party/openscreen/src@7d8b92dfc7b5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/openscreen-chromium Please CC jophba@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: jophba@chromium.org Change-Id: I5ee069ffd16023b972d8b8cb43bbd5949aa589e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042774Reviewed-by:
-
Tommy Li authored
I've been investigating why the realbox has such worse ToPaint metrics than the omnibox. I discovered that the realbox is ignoring all autocomplete results other than the final "done()" one, which won't come in until we get results from the Suggest server, often 60ms away at the fastest. This CL makes the realbox paint incomplete results, just like the omnibox does. For the user, it's going to make the realbox feel much more responsive, like the omnibox, but also introduces the same asynchronous result-changing-after-the-fact issue that the omnibox has. I think it's best to just keep the behavior the same between the UIs. It also improves the ToPaint time on my machine from ~70ms to ~15ms, which is quite competitive with the actual omnibox. Some history: In the original implementation of the realbox, there was a one-time-use callback, which is probably why the original implementer waited until the autocomplete machinery was done(). This limitation was removed by this CL: https://chromium-review.googlesource.com/c/chromium/src/+/1875030 This CL takes advantage of that new ability by reporting the incomplete states as well. (i.e. history provider has returned but search suggest has not gotten the remote results yet). Bug: 1046561 Change-Id: I8f7fc5760bfefb0e9aa0d3642cde0e30185e71be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036259Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#739184}
-
Xianzhu Wang authored
This reverts commit 617a9c19. Reason for revert: Broke some browser tests. The tests flakily crash when pushing scroll properties at impl-side. Original change's description: > Ensure cc::Layer's NeedsPushProperties when blink directly sets scroll offset > > When blink directly sets scroll offset in the scroll tree, we need to > set the associated cc::Layer's NeedsPushProperties to ensure update of > cc::LayerImpl's scroll related properties > (see cc::LayerImpl::UpdateScrollable()). > > This reverts the change about cc::LayerTreeHost::LayerByElementId() in > https://chromium-review.googlesource.com/c/chromium/src/+/2020554 > because we still need it in layer list mode. > > Bug: 1048113 > Change-Id: I686beebcf54e96cc517700c0f987aaceec880c58 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036834 > Reviewed-by: Philip Rogers <pdr@chromium.org> > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#739043} TBR=wangxianzhu@chromium.org,pdr@chromium.org Change-Id: Ib52291c52f8bac3f4a3c9fe0248f55d0162c556c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1048113 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042763Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#739183}
-
Ian Kilpatrick authored
As above. There should be no behaviour change. Change-Id: I322c8878600e2044f2a9bd635f7005f471f5ba24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042318Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#739182}
-
Karan Bhatia authored
This CL changes the AhoCorasickNode class to store pointers to other nodes directly instead of their index in the trie array. This makes the code clearer and reduces redundant indirection. Also, add some code comments related to the algorithm. This should have no behavior change. BUG=974391 Change-Id: I2e1d89556fb064bdb1643ab7e10005d674bc8d6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037734 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#739181}
-
Pavel Yatsuk authored
When search engine has valid prepopulate_id, DefaultSearchManager will replace it with the entry from prepopulated list. This is not desired behavior for Play API search engines as it will reset created_from_play_api flag and search engine name and URLs. This CL prevents DefaultSearchManager from modifying Play API search engine. BUG=1048713 R=pkasting@chromium.org,krb@chromium.org Change-Id: I5e9a5e523f419b8a28953ce8f26003c1d207a451 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037830Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Pavel Yatsuk <pavely@chromium.org> Cr-Commit-Position: refs/heads/master@{#739180}
-
Lukasz Anforowicz authored
This CL changes how navigations result in focusing the tab contents: 1. Browser-initiated navigations: - Before this CL: Focus done in FocusTabAfterNavigationHelper which covers both OpenURL and BeginNavigation code paths. - After this CL: Focus done in Browser::UpdateUIForNavigationInTab (similarly to pre-r737502) which covers only the OpenURL code path. 2. NTP-initiated navigations: - No change: Focus done in FocusTabAfterNavigationHelper. This CL makes sure that the text in the Omnibox is not temporarily selected during a navigation, by ensuring that the Omnibox is not focused when OmniboxViewViews::Update runs (see also https://crbug.com/1048742#c4 and #c5 and #c7). Regression tests are added for this problem. This CL also makes sure that DevTools-initiated navigations (browser-initiated navigations which go through the BeginNavigation path) do not result in focus changes (see also https://crbug.com/1048591). This CL might also (speculating here) address the performance bugs tracked in bugs 1048333, 1048556, 1048565, 1048988, 1048988. Fixed: 1048742, 1048591 Bug: 1048333, 1048556, 1048565, 1048988, 1048988 Change-Id: Ia00cd9143991c260615663fae06f096e9d7cf0f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040234 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by: -
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/999642323280..e6a829e67854 git log 999642323280..e6a829e67854 --date=short --first-parent --format='%ad %ae %s' 2020-02-06 fmayer@google.com Allow ObfuscateMember to fully qualify field name. Created with: gclient setdep -r src/third_party/perfetto@e6a829e67854 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:149006783 Tbr: perfetto-bugs@google.com Change-Id: I85549f8a42a95a6c6f0218d8745f21a6b354d67d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042246Reviewed-by:
-
Mason Freed authored
See the linked bugs, which make clear that the functions touched in [1] and [2] are very hot code paths, at least for the blink microbenchmarks. This CL marks those functions ALWAYS_INLINE and optimizes access to IsElementNode() which is the most-likely used of the DOMNodeType accessors. [1] https://chromium-review.googlesource.com/c/chromium/src/+/1962631 [2] https://chromium-review.googlesource.com/c/chromium/src/+/1965945 Bug: 1036543, 1036088, 1036536, 1036089 Change-Id: If07e3dfc051ed5abd152ac758d27113b63080fee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042374 Auto-Submit: Mason Freed <masonfreed@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
-
Will Harris authored
Since https://crrev.com/c/1912502 only enabled DPI awareness for browser process, this meant utility process showing system UI was not running at correct DPI. This adds an explicit call to EnableHighDPISupport in the mojo IPC to display a file dialog. BUG=1049324 TEST=Enable high DPI. Load Chrome and push Ctrl-O. Dialog should be shown in High DPI and not blurry. Change-Id: Ica591e65ba25f3c45485f6676c26436f0d3eb57c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042744Reviewed-by:
Patrick Monette <pmonette@chromium.org> Commit-Queue: Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#739176}
-
Austin Eng authored
This reverts commit 50fdef03. Reason for revert: The root cause of the slowness is elsewhere, and the tests will be removed from the configurations they're timing out on. Original change's description: > Mark two virtual/android tests as Slow for causing flaky timeouts > > virtual/android/url-bar/bottom-fixed-adjusted-when-showing-url-bar.html > and virtual/android/fullscreen/video-scrolled-iframe.html are causing > flaky timeouts. > > TBR=nator@chromiun.org > > Bug: 1049138 > No-Try: true > Change-Id: If30b1c39d7b73354e782458c924708bc820934c7 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2039143 > Reviewed-by: Austin Eng <enga@chromium.org> > Commit-Queue: Austin Eng <enga@chromium.org> > Cr-Commit-Position: refs/heads/master@{#738592} TBR=nator@chromium.org,enga@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1049138, 1049138 Change-Id: I4d3135d309c1bf4ca1fc7531fa970d80468d7c76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042321Reviewed-by:
-
- 06 Feb, 2020 16 commits
-
-
Ovidio Henriquez authored
This change updates the Migration guide to contain more up to date information about the PPAPI to Web API gaps. Change-Id: Ic5f952e805a656cebf9540fa9c8301fc7160527e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031939Reviewed-by:
Ben Smith <binji@chromium.org> Commit-Queue: Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Cr-Commit-Position: refs/heads/master@{#739174}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f5e5312d2154..4db6affff29a Created with: gclient setdep -r src-internal@4db6affff29a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1015113,chromium:1029449,chromium:1031084,chromium:1049659 Tbr: jbudorick@google.com Change-Id: I1332a27e6bbb87f598bbb73a1b687475c03834a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042659Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#739173}
-
Colin Blundell authored
This CL changes ChromeMetricsHelper::StartRecordingCaptivePortalMetrics() to take in the CaptivePortalService instance rather than obtaining it internally from the Profile and similarly changes ChromeMetricsHelper to take in the HistoryService instance in its constructor. The motivation is to enable this class to be componentized in a followup in order to make it available to WebLayer. Bug: 1030692 Change-Id: I6447dcc21e317d7ed4ba2b01b821575028066d4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040412 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Carlos IL <carlosil@chromium.org> Cr-Commit-Position: refs/heads/master@{#739172}
-
Mandy Chen authored
This CL removes the `errors` from Page.getInstallabilityErrors since it's not used by DevTools anymore. Bug: 946860 Change-Id: I87a8421aedcec4864b364cdcedc4d21c04821bec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026381Reviewed-by:
Lorne Mitchell <lomitch@microsoft.com> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
-
Sajjad Mirza authored
When compiling with coverage flags enabled, this class caused a missing key function error at link-time. [https://lld.llvm.org/missingkeyfunction] The fix is to ensure that all non-pure, non-inline, virtual functions are properly defined somewhere. Given the way this class is used, the most appropriate response appears to be marking its member functions as pure virtual. Bug: 1049383 Change-Id: I2f4c063bb151ac409f41f12c6da6e7f71c0d2a4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040680 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#739170}
-
Gary Kacmarcik authored
This change breaks non-curtained multimon since you can no longer switch between monitors. This reverts commit d8b19b69. Reason for revert: <INSERT REASONING HERE> Original change's description: > Enable cursor compositing for uncurtained Mac. > > I previously thought that the cursor was always part of the captured > screen on Mac, but it turns out that's only true if curtain mode is > active. This CL makes creating of a composing capturer conditional > on the curtain mode setting, which should give the correct beheviour > for both remote support and uncurtained remote access. > > Bug: 1048774 > Change-Id: I28cc01b0b615794e06cd31308c10a40af550e0e1 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036546 > Commit-Queue: Jamie Walch <jamiewalch@chromium.org> > Reviewed-by: Joe Downing <joedow@chromium.org> > Cr-Commit-Position: refs/heads/master@{#738347} TBR=jamiewalch@chromium.org,joedow@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1048774 Change-Id: I3063609e5a8f7f16e791222fe1782f28a3e37ac6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042537Reviewed-by:
Gary Kacmarcik <garykac@chromium.org> Reviewed-by:
Joe Downing <joedow@chromium.org> Commit-Queue: Gary Kacmarcik <garykac@chromium.org> Cr-Commit-Position: refs/heads/master@{#739169}
-
Jason Lin authored
* Rename menu item "Options" to "Settings" * Remove menu item "Find" since we are not supporting it for now. Bug: 1016190 Change-Id: I632cbe04c52e83822ffa40a423d96d004f57153e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040503Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Auto-Submit: Jason Lin <lxj@google.com> Commit-Queue: Jason Lin <lxj@google.com> Cr-Commit-Position: refs/heads/master@{#739168}
-
Trent Apted authored
Some undocumented functionality regressed in r713537 with the feature removal. Skip presubmit. Change has +1/OWNERS approval, but a linter complains about changes outside the scope of this CL. No-Presubmit: true Bug: 1035051 Change-Id: Ie106df252fcf1784fdeffbcf1d789df5c8b7ea40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040754 Commit-Queue: Trent Apted <tapted@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#739167}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/e9dc0201af3a..463c318ab759 git log e9dc0201af3a..463c318ab759 --date=short --first-parent --format='%ad %ae %s' 2020-02-06 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/vulkan-loader/src b932cf53f769..c731adec183b (4 commits) Created with: gclient setdep -r src/third_party/angle@463c318ab759 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: cnorthrop@google.com Change-Id: I4599c43246bc494d01b5d9de16cd38b526da66d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042336Reviewed-by:
-
minch authored
This is an initial cl for the contextual nudge of the back gesture. See screenshot: https://screenshot.googleplex.com/CAagJhL5f7z Following up work: 1. Add animation for the nudge based on the spec. 2. Add the condition to show the nudge. Bug: 1009005b Change-Id: I28471c9f5281b0d1af8e16f3598d802a803d91f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040059Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Min Chen <minch@chromium.org> Cr-Commit-Position: refs/heads/master@{#739165}
-
Demetrios Papadopoulos authored
Bug: 1026426 Change-Id: I17c488f5e50eaa35522aa39fc395726432ec9a7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040686Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#739164}
-
Hugo Benichi authored
This patch adds a number of fields to NetworkConfiguration objects defined in net.mojom in order to pass to ARC information it currently lacks or infers from the environment: - Explictly passing the host IPv4 configuration and DNS addresses: this effectively replaces the ip_configs field which is both incovenient to parse on ARC side and not necessary for IPv6 outside of DNS. Instead it is more straightforward and easier on both sides to directly pass the IPv4 configuration and IPv4 + IPv6 DNS settings. This matches better with the interface of android.net.LinkProperties. - List of DNS search domains: similarly to DNS addresses, ARC should use the settings set for the host during layer3 provisioning or set statically. This is important for managed networks and necessary for resolving "short" hostnames inside ARC. Like DNS addresses, search domains are aggregated over both v4 and v6 and passed as an explicit array. - Static IPv4 configuration for ARC: this replaces the legacy mechanism of arc-networkd setting the IPv4 address assigned to an Android virtual network by directly entering the ARC container namespace and setting the address on Android virtual interface. This is necessary for using ARC's ArcNetworkService in ARCVM where ns-enter cannot be used. - MTU value: ARC currently does not set the MTU correctly for network with non-standard MTUs (like some cellular networks) and always use a default MTU value. Follow-up patches will start populating these fields. BUG=b:123431422 BUG=b:143258259 BUG=b:145960788 BUG=crbug:795603 TEST=Compiled Change-Id: I08dfd5daa9ba2946a847e555bb94a01da3866eb9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1959203Reviewed-by:
Jorge Lucangeli Obes <jorgelo@chromium.org> Commit-Queue: Hugo Benichi <hugobenichi@google.com> Cr-Commit-Position: refs/heads/master@{#739163}
-
Chris Lu authored
This brings in the new library files as a CIPD package and update DEPS to refer to this updated library. Fixed: 1049042 Change-Id: I874f1a148bd7c47a4756d25f5edb590a39709b0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042215Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Cr-Commit-Position: refs/heads/master@{#739162}
-
chrome://flagsTommy Steimel authored
Bug: 1046682 Change-Id: I9a3addb2f5415b371cd65537223df664215ae8ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2039311Reviewed-by:
Jazz Xu <jazzhsu@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#739161}
-
Austin Eng authored
This test is no longer flaky. TBR=kbr@chromium.org Bug: chromium:928989 Change-Id: I61a0d0a97356a2f4a6d9ef8745fa4d9846063df6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042685Reviewed-by:
-
Robert Flack authored
Suspect this is also related to the devtools frontend roll in https://chromium-review.googlesource.com/c/chromium/src/+/2038189 Sample failure at https://ci.chromium.org/p/chromium/builders/ci/WebKit%20Linux%20MSAN/4217 TBR=tvanderlippe@chromium.org Bug: 1049641 Change-Id: Ic6d75cb6e3644c5fbf2fcbb0e955120ae442e3c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042796Reviewed-by:
Robert Flack <flackr@chromium.org> Commit-Queue: Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#739159}
-
