GitLab

Chrome iOS is moving to Objective-C Automatic Reference Counting. Under
it, arguments are supposed to be autoreleased. This CL changes the constructor to retain its argument..
This is a part of a multiple CL setup that will change the Image(UIImage*) constructor from consuming +1 refcount to retaining the argument.

TEST=none
BUG=645125

Review-Url: https://codereview.chromium.org/2500373004
Cr-Commit-Position: refs/heads/master@{#438223}

We have already landed rappor metrics for cross-origin autoplay muted
experiment, we should land corresponding histogram metrics as well.

BUG=672526

Review-Url: https://codereview.chromium.org/2576463002
Cr-Commit-Position: refs/heads/master@{#438222}

Revert of Move onReceivedError and onReceivedHttpError out of AwContentsIoThreadClientImpl (patchset #7 id:120001 of https://codereview.chromium.org/2558223002/ )

Reason for revert:
BUG=673736

Original issue's description:
> Move onReceivedError and onReceivedHttpError out of AwContentsIoThreadClientImpl
>
> Move onReceivedError and onReceivedHttpError out of AwContentsIoThreadClientImpl to AwContentsClientBridge. This is a continuation of the work started in
> https://codereview.chromium.org/2425423004/ and is the third patch.
>
> BUG=645983
>
> Committed: https://crrev.com/f199141ef70d76697647830f498b25706c0b0d0a
> Cr-Commit-Position: refs/heads/master@{#437688}

TBR=sgurun@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=645983

Review-Url: https://codereview.chromium.org/2567043003
Cr-Commit-Position: refs/heads/master@{#438221}

gl_context_egl isn't being compiled on Mac so we can't run the ANGLE GPU
fuzzer on that platform. Ideally we would like to gate it on use_egl but
this variable is only defined in ui/gl/BUILD.gn and not gpu/BUILD.gn.
Gating the fuzzer on is_linux will not lose coverage as the code run is
completely platform-independent.

BUG=chromium:673276
TBR=kbr@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2572473002
Cr-Commit-Position: refs/heads/master@{#438220}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/e6e0862c8165..bf0f62a28351

$ git log e6e0862c8..bf0f62a28 --date=short --no-merges --format='%ad %ae %s'
2016-12-13 nednguyen [Telemetry] Disable testBattOrTracing on linux

BUG=673761

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2577433002
Cr-Commit-Position: refs/heads/master@{#438219}

BUG=None

Review-Url: https://codereview.chromium.org/2571833002
Cr-Commit-Position: refs/heads/master@{#438218}

BUG=None

Review-Url: https://codereview.chromium.org/2572473005
Cr-Commit-Position: refs/heads/master@{#438217}

Leaving fields uninitialized results in fewer compiled bytes than
initializing fields to default values. This CL shrinks the uncompressed
size of classes.dex by 8.6 kb for proguarded chrome_public_apk.

Change was made with Android Studio (Analyze > Run inspection by name >
Redundant field initialization), and fixes all instances in projects
currently generated by build/android/gradle/generate_gradle.py.

NOPRESUBMIT=true

BUG=670001

Review-Url: https://codereview.chromium.org/2548013002
Cr-Commit-Position: refs/heads/master@{#438216}

Make the developer mode checkbox on chrome://extensions adhere to the DeveloperToolsDisabled policy. If it is disabled, display an indicator.
Add corresponding indicator test to policy_prefs_browsertest.
Add an end-to-end test to policy_browsertest.

BUG=633684
TEST=browser_tests *PolicyPrefIndicatorTest*, PolicyTest.DeveloperToolsDisabledExtensionsDevMode
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2529083002
Cr-Commit-Position: refs/heads/master@{#438215}

The browser crashes when trying to run this story.

BUG=673775

Review-Url: https://codereview.chromium.org/2570883002
Cr-Commit-Position: refs/heads/master@{#438214}

This is preparation for exposing new api for immediate procesing.

BUG=672584

Review-Url: https://codereview.chromium.org/2572503002
Cr-Commit-Position: refs/heads/master@{#438213}

BUG=631181
TEST=Plug in unsupported monitor, note that error notification string
has changed to

"This monitor isn't getting along with your Chromebook (the monitor is
not supported)."

Also, "Send a feedback report" should be in a lower button.

Review-Url: https://codereview.chromium.org/2490323003
Cr-Commit-Position: refs/heads/master@{#438212}

This is a fairly mechanical change:
 - Replace WTF::monotonicallyIncreastingTime -> WTF::TimeTicks::Now()
 - Replace 0 -> WTF::TimeTicks()
 - create appropriate seconds <-> TimeTicks conversions where event
   timestamp needs to be used elsewhere in Blink

BUG=625680

Review-Url: https://codereview.chromium.org/2542693002
Cr-Commit-Position: refs/heads/master@{#438211}

This CL re-adds some layout tests to the layout test filter for
PlzNavigate. These tests pass locally but are failing on the bot.
Marking this as NOTRY since this is only affecting the FYI bot
LinuxBrowserSideNavigation.

BUG=576261
NOTRY=TRUE
TBR=nasko@chromium.org

Review-Url: https://codereview.chromium.org/2573843002
Cr-Commit-Position: refs/heads/master@{#438210}

https://skia.googlesource.com/skia.git/+log/941e7e2c9567..18b4f981aeda

$ git log 941e7e2c9..18b4f981a --date=short --no-merges --format='%ad %ae %s'
2016-12-13 jvanverth Fix doc typo
2016-12-10 bsalomon Remove antialias axis from GrPathRendererChain::DrawType
2016-12-13 fmalita Avoid int64 overflow in SkClampRange

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
TBR=msarett@google.com

Review-Url: https://codereview.chromium.org/2567243004
Cr-Commit-Position: refs/heads/master@{#438209}

Details:
- Collection was added in https://codereview.chromium.org/2544853003/
- log messages are added to the stability report's top level and not to the process level. We may want to revisit that if/when reports start containing multiple processes

BUG=620813

Review-Url: https://codereview.chromium.org/2554423002
Cr-Commit-Position: refs/heads/master@{#438208}

BUG=673644

Review-Url: https://codereview.chromium.org/2572483004
Cr-Commit-Position: refs/heads/master@{#438207}

This CL prepares for later renaming updateIce to setConfiguration in
Blink, once it has an Intent to Ship.

updateIce was never functional in the first place (in the native webrtc
library), always throwing the same exception. SetConfiguration is
functional, and will allow an application to change the set of ICE
servers and ICE candidate policy. Soon, also the ICE candidate pool
size.

updateIce will no longer be tracked after this CL, which should be ok
since it has always been nonfunctional and stats show zero use.

BUG=chromium:587453

Review-Url: https://codereview.chromium.org/2511633002
Cr-Commit-Position: refs/heads/master@{#438206}

Implement it for Android, Desktop, and iOS.

This largely supersedes chrome://popular-sites-internals/. Relative to
that, it lacks a way to see the cached JSON and the status of a manual
fetch.

BUG=655622

Review-Url: https://codereview.chromium.org/2557103004
Cr-Commit-Position: refs/heads/master@{#438205}

Without this, an assertion is triggered, since inSearchMode is updated
before the element is attached.

BUG=NONE
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2562153002
Cr-Commit-Position: refs/heads/master@{#438204}

BUG=672763

Review-Url: https://codereview.chromium.org/2568233003
Cr-Commit-Position: refs/heads/master@{#438203}

This CL initializes TaskScheduler in renderers using
default arguments. ContentRenderClient may provide
different arguments.

Initially, no threads will be created by TaskScheduler
in renderers because no tasks are posted to it and
pools are initialized with StandbyThreadPolicy::LAZY.

In a separate, we will start running v8 tasks in
TaskScheduler rather than WorkerPool
(https://cs.chromium.org/chromium/src/gin/v8_platform.cc?sq=package:chromium&l=70&dr=C).

BUG=664996

Review-Url: https://codereview.chromium.org/2491823005
Cr-Commit-Position: refs/heads/master@{#438202}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/8d822ae6..0948a26d

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2570063002
Cr-Commit-Position: refs/heads/master@{#438201}

BUG=672950

Review-Url: https://codereview.chromium.org/2563103002
Cr-Commit-Position: refs/heads/master@{#438200}

The expectations don't differ anymore.

TBR=haraken@chromium.org
NOTRY=true
BUG=chromium:468240

Review-Url: https://codereview.chromium.org/2574583003
Cr-Commit-Position: refs/heads/master@{#438199}

This patch splits the Network.getCookies command into
Network.getCookies, which returns the cookies for the current URL and
Network.getAllCookies, which returns all the cookies in the cookie jar.

BUG=668932,166637

Review-Url: https://codereview.chromium.org/2568503002
Cr-Commit-Position: refs/heads/master@{#438198}

This patch optimizes KURL::protocol and KURL::protocolIs by keeping
an AtomicString m_protocol on KURL. This reduces string allocations
throughout the code using KURL::protocol().

This also fixes an inconsistency with KURL::protocolIs that will return
true for invalid URLs.

BUG=348655

Review-Url: https://codereview.chromium.org/2463703002
Cr-Commit-Position: refs/heads/master@{#438197}

* affects system menu, message center, palette bubble, ime bubble, etc.
* WM shadow aperture calculation is adjusted to work better for small
  windows (like the message center when it's empty). There's a TODO
  here which will have to wait for Sebastien to get back so he can give
  feedback on what to do in this case.
* fix alignment of NO_ASSETS bubble --- don't account for
  non-existent stroke.
* existing BubbleBorder tests applied to more different kinds of bubble

BUG=608852

Review-Url: https://codereview.chromium.org/2555373004
Cr-Commit-Position: refs/heads/master@{#438196}

purely a renaming from Foo_SkClipOp to SkClipOp::Foo
plus one static_cast to treat the enum as an index into array.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
TBR=

Review-Url: https://codereview.chromium.org/2575533002
Cr-Commit-Position: refs/heads/master@{#438195}

BUG=642059
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2561243002
Cr-Commit-Position: refs/heads/master@{#438194}

crrev.com/2533163002 changed the way we allocate modeset buffers.
Unfortunately the new use flags introduced a regression that makes it
not possible to pageflip from a modeset buffer to a buffer queue buffer.
This CL restores the old modeset buffer use flags in order to fix the
regression, while we work on a long term solution.

BUG=673026
TEST=manually tried the step described in the bug and verified it now works.

Review-Url: https://codereview.chromium.org/2568243004
Cr-Commit-Position: refs/heads/master@{#438193}

GlobalErrorService ownership was crazy; sometimes the error objects contained were owned, and sometimes they weren't. This separates the two cases into clear statements of ownership, and deprecates the case where the error objects are unowned.

BUG=555865,673578

Review-Url: https://codereview.chromium.org/2409443002
Cr-Commit-Position: refs/heads/master@{#438192}

Revert of Mark org.chromium.android_webview.test.ClientOnPageFinishedTest#testPassesCorrectUrl flaky (patchset #1 id:1 of https://codereview.chromium.org/2568413003/ )

Reason for revert:
Infra problem, not test problem. And the problematic bot has been taken off of cq.

Original issue's description:
> Mark org.chromium.android_webview.test.ClientOnPageFinishedTest#testPassesCorrectUrl flaky
>
> BUG=672885
> TBR=boliu@chromium.org
>
> Committed: https://crrev.com/7d0a2e6fd2a182eb8fa8888cd9539c6072bbf136
> Cr-Commit-Position: refs/heads/master@{#438190}

TBR=nednguyen@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=672885

Review-Url: https://codereview.chromium.org/2573833002
Cr-Commit-Position: refs/heads/master@{#438191}

BUG=672885
TBR=boliu@chromium.org

Review-Url: https://codereview.chromium.org/2568413003
Cr-Commit-Position: refs/heads/master@{#438190}

These are third party libraries used by Chrome for iOS.

BUG=none

Review-Url: https://codereview.chromium.org/2551963004
Cr-Commit-Position: refs/heads/master@{#438189}

Revert of [ObjC ARC] Converts ios/chrome/browser/ui/autofill:autofill to ARC. (patchset #3 id:40001 of https://codereview.chromium.org/2569713003/ )

Reason for revert:
Breaks compilation of autofill_controller_unittest.mm

Original issue's description:
> [ObjC ARC] Converts ios/chrome/browser/ui/autofill:autofill to ARC.
>
> Automatically generated ARCMigrate commit
> Notable issues:None
> BUG=624363
> TEST=None
>
> Committed: https://crrev.com/01e99d0af3a84ae96857d34e096ff4f876e56c2a
> Cr-Commit-Position: refs/heads/master@{#438167}

TBR=noyau@chromium.org,stkhapugin@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=624363

Review-Url: https://codereview.chromium.org/2577443002
Cr-Commit-Position: refs/heads/master@{#438188}

Using a dialog is a much cleaner solution because it handles all focus
trapping without attempting to capture TAB or require updating all
tabindex properties.

We removed the ability to swipe the drawer open in order to keep the
code simple.

BUG=633858
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2465433002
Cr-Commit-Position: refs/heads/master@{#438187}

BUG=651041

Review-Url: https://codereview.chromium.org/2569223002
Cr-Commit-Position: refs/heads/master@{#438186}

BUG=673362

Review-Url: https://codereview.chromium.org/2555033003
Cr-Commit-Position: refs/heads/master@{#438185}

This CL triages the currently failing layout tests. Marking this as
NOTRY since this is only affecting the FYI bot
LinuxBrowserSideNavigation.

BUG=576261
NOTRY=TRUE
TBR=nasko@chromium.org

Review-Url: https://codereview.chromium.org/2572783003
Cr-Commit-Position: refs/heads/master@{#438184}