GitLab

FocusableLabelButton already sets its own focus ring. It is meant to be
focusable as well. So explicitly set its focus behavior in this class
instead of setting it for each instance.

Bug: 1001103
Change-Id: Ie2169e9bf8a3d27200444c03da86f69eae6ee725
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495702Reviewed-by: Denis Kuznetsov [CET] <antrim@chromium.org>
Commit-Queue: Wei Li <weili@chromium.org>
Cr-Commit-Position: refs/heads/master@{#820788}

TBR=kbr@chromium.org

Bug: chromium:982292
Bug: angleproject:5221
Bug: angleproject:5222
Bug: angleproject:5223
Bug: angleproject:5224
Bug: angleproject:5225
Bug: angleproject:5226
Bug: angleproject:5227
Change-Id: I5f0bc53c2f6a2f207b5e53799ece6a733736728c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495284Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Auto-Submit: Geoff Lang <geofflang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#820787}

In preparation for CBCM reporting unit tests, this extends the mock
infrastructure for policy objects that will be involved. In particular:

- A new mock BrowserStatePolicyConnector was added
- The TestChromeBrowserState builder now supports building the browser
  state with a mock BrowserStatePolicyConnector
- The TestChromeBrowserStateManager can return a TestChromeBrowserState
  by path
- The TestingApplicationContext now creates a real
  BrowserPolicyConnector if its accessor is called

These are all needed for the ProfileReportGeneratorIOS unit tests, which
will come in a separate CL.

Bug: 1055318
Change-Id: I3428e56d695c014d63245be6493d527787343cce
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495265Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Guillaume Jenkins <gujen@google.com>
Cr-Commit-Position: refs/heads/master@{#820786}

The pixel_buffer_transferer_mac_unittest.mm defines several helper
functions for creating ARGB and YUVS buffers from a single color or
with a checker pattern, converting between the two formats, and
verifying the color or number of tiles of a pixel buffer.

Because these are useful for sanity checks involving creating or
modifying pixel buffers, we move these to a separate utilities file
(only available in testing). To be used by future CLs' unittests.

Bug: chromium:1132299
Change-Id: Idd6c3f8918b540240f515e2761695e9b5bc9caa2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2498564
Commit-Queue: Markus Handell <handellm@google.com>
Reviewed-by: Markus Handell <handellm@google.com>
Cr-Commit-Position: refs/heads/master@{#820785}

BUG=1137452

Change-Id: Ic9796c43893f63142835a78d4b5bfc08b8b67b90
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495421Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Toni Baržić <tbarzic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#820784}

This is the exact change (after conflict resolution) as the one reviewed in https://chromium-review.googlesource.com/c/chromium/src/+/2446546 which was reverted in https://chromium-review.googlesource.com/c/chromium/src/+/2453393 due to breaking component builds. That issue has been fixed.

When cloud policies is enabled, GCPW will try to read the list of allowed domains from Omaha policy if they have been fetched already. If not it will fall back to the registry entry as before.

Bug: 1134817
Change-Id: If4e50a4c9532e897fabf7470688a83b3653a56bc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2496183Reviewed-by: S. Ganesh <ganesh@chromium.org>
Reviewed-by: Rakesh Soma <rakeshsoma@google.com>
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Reviewed-by: Yusuf Sengul <yusufsn@google.com>
Commit-Queue: Robin Lewis <wrlewis@google.com>
Cr-Commit-Position: refs/heads/master@{#820783}

With the DestroyProfileOnBrowserClose experiment, there may be a lot
more use-after-free bugs in ~PrefChangeRegistrar(), so add a comment
explaining this and giving a point-of-contact.

Bug: 1141952
Change-Id: Ie3887151d511fdd965763598d6fc33599cdf60dc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2497989
Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org>
Commit-Queue: Dominic Battré <battre@chromium.org>
Reviewed-by: Dominic Battré <battre@chromium.org>
Cr-Commit-Position: refs/heads/master@{#820782}

https://dawn.googlesource.com/tint.git/+log/f81c1081ea7d..1bafdc3c45e7

2020-10-26 dneto@google.com spirv-writer: Generate load for return value, when needed

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/tint-chromium-autoroll
Please CC rharrison@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: rharrison@google.com
Change-Id: Iac9aae898db8826b961557681ca52dce7aa682a5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2498843Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#820781}

It's one of two tests across all of Chrome using
BrowserTestBase::spawned_test_server(), which we should remove.

Also re-enable the test on Windows. It was disabled due to
https://crbug.com/1140928, the underlying cause of which has now been
fixed.

Fixed: 997823
Bug: 492672
Change-Id: I2eb43613aac3b05299fbb15d37967a3de30a2380
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2499081Reviewed-by: Steven Valdez <svaldez@chromium.org>
Commit-Queue: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#820780}

This CL brings WebAssembly UMA metrics to the v8-browsing benchmark in
Telemetry.

R=mythria@chromium.org, clemensb@chromium.org

Bug: chromium:1084929
Change-Id: I28e72378774c3d599da1ad670ba036a3f0ea84e0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2497164Reviewed-by: Mythri Alle <mythria@chromium.org>
Reviewed-by: John Chen <johnchen@chromium.org>
Commit-Queue: Andreas Haas <ahaas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#820779}

Bug: 1138612, 1104132, 1006430
Change-Id: Ie9cb6105cb7612f56caa2d23b4cae010702f443d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2497441
Commit-Queue: Reda Tawfik <redatawfik@google.com>
Reviewed-by: Ioana Pandele <ioanap@chromium.org>
Reviewed-by: Friedrich [CET] <fhorschig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#820778}

This CL also adds test for non primary OTR profiles and refactors the
tests as well.

Bug: 1060940
Change-Id: Idd05876d98a058d0695829d75561aec9a2b67277
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494868Reviewed-by: Christian Dullweber <dullweber@chromium.org>
Commit-Queue: Rohit Agarwal <roagarwal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#820777}

The bisect-builds.py script is easier to use if the good and bad points
can be specified as M85 (stable branch releases only) or 85.0.4183.121
instead of just 782793. This change adds support for translating
stable milestone numbers into their most recent version numbers, and
translating version numbers into commit positions (also known as
revision numbers).

Bug: 1141177
Change-Id: I0526ab4d1b472558d9c93e26c8561a8ef7f31277
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491052
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
Reviewed-by: Greg Thompson <grt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#820776}

This removes the features:
 - kRecentHttpSameSiteAccessGrantsLegacyCookieSemantics
 - kRecentCreationTimeGrantsLegacyCookieSemantics
which would modify SameSite cookie access semantics based on how
recently the cookie was accessed or created.

These features were never enabled, experimented with, or standardized,
and are now obsolete.

Bug: 1029099, 1029098
Change-Id: I0e91a29447f8a7579f1247797eb7aa644762390a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495350Reviewed-by: Maksim Orlovich <morlovich@chromium.org>
Commit-Queue: Lily Chen <chlily@chromium.org>
Cr-Commit-Position: refs/heads/master@{#820775}

Replace dozens of content setting specific functions with generic
functions.

Change-Id: I52d5058ed1b6e1fd7f69baf25813ced83ad17ac3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494936
Commit-Queue: Christian Dullweber <dullweber@chromium.org>
Reviewed-by: Peter Conn <peconn@chromium.org>
Reviewed-by: Andy Paicu <andypaicu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#820774}

Bug: 1140998
Change-Id: Ibf5c415e21cc0fd974be55c2628c712ba7205c9e
TBR: aluo@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2499163Reviewed-by: Patrick Noland <pnoland@chromium.org>
Commit-Queue: Patrick Noland <pnoland@chromium.org>
Cr-Commit-Position: refs/heads/master@{#820773}

This is a reland of 8a1b573d

Original change's description:
> media/gpu/vaapiWrapper: Add WARN_UNUSED_RESULT to critical functions
>
> This adds WARN_UNUSED_RESULT to VaapiWrapper functions whose
> result should have the critical impact enough to regard its
> failure as video processing fatal.
> VaapiVideoDecoder actually doesn't handle the failure of
> VaapiWrapper::CreateContext. This CL also fixes it.
>
> Bug: b:171536540
> Test: Build media_unittest and vaapi_unittest
> Change-Id: Iba6924849bfe8627fd328c3541c7a2c5cb0f0371
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493742
> Commit-Queue: Hirokazu Honda <hiroh@chromium.org>
> Reviewed-by: Andres Calderon Jaramillo <andrescj@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#820164}

Bug: b:171536540
Change-Id: Ia10cad9549d099d1823419647f0f6473b6bc24dc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2497964
Auto-Submit: Hirokazu Honda <hiroh@chromium.org>
Commit-Queue: Jeffrey Kardatzke <jkardatzke@google.com>
Reviewed-by: Jeffrey Kardatzke <jkardatzke@google.com>
Cr-Commit-Position: refs/heads/master@{#820772}

This is lifted from Pat's change at
https://chromium-review.googlesource.com/c/chromium/src/+/2355089

Bug: 993029, 1088353, 1121069
Change-Id: Ibdc91c07a235be347cbe1704f0fe5e77cff73470
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490221Reviewed-by: Patrick Monette <pmonette@chromium.org>
Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#820771}

Adds three browser tests for ephemeral Guest profiles.

Bug: 1125474
Change-Id: I0a110ed75eef13a664f95e86628749c9ffecda38
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489632Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Cr-Commit-Position: refs/heads/master@{#820770}

This CL adds detailTextColor property to SettingsImageDetailTextItem and
some unittests.
It also replaces TableViewItem refererences by
SettingsImageDetailTextItem in the SettingsTableViewController.

Bug: 922511
Change-Id: I56ec9e5a841f30510505630de65a8e97b58c02f3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461113
Commit-Queue: Ewann Pellé <ewannpv@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Nohemi Fernandez <fernandex@chromium.org>
Cr-Commit-Position: refs/heads/master@{#820769}

We don't currently need it, and cmake currently fails when it's on.

Bug: 1142191
Change-Id: I76a75c04884c57afb49f2f5d0ff989ada0c32d08
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2497807Reviewed-by: Hans Wennborg <hans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#820768}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/5d039126f32d..ac42b7968549

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC cfroussios@google.com,avi@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: chromium:1139339
Tbr: cfroussios@google.com,avi@google.com
Change-Id: If51173498986decdc71965fea01db0c4b4f30f4a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2498841Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#820767}

Add feature to kEnableExperimentalCookieFeatures.

Update test expectations for failing tests.

Invert virtual test to check disabled feature code paths for
regressions.

Update a failing test to match expected behavior.

Bug: 1030938
Change-Id: I65d42efcc79c2601129b7df441968b9bb868b488
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493261Reviewed-by: Lily Chen <chlily@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
Commit-Queue: Steven Bingler <bingler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#820766}

unique_renderer_id.

Though unique renderer IDs are already available for iOS Password
Manager, I noticed they were not used in fetching the right field
in server predictions processing in FormDataParser.

Change-Id: Id67a520a94c3a53ab4cd9b02d7c840d0235c5468
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2498601Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Commit-Queue: Maria Kazinova <kazinova@google.com>
Cr-Commit-Position: refs/heads/master@{#820765}

https://skia.googlesource.com/skia.git/+log/aea82732415c..c493eabd56d0

2020-10-26 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from ade9a5235c73 to 42103bc2e911 (12 revisions)
2020-10-26 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from e47bf15e to d37162e0 (552 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC jcgregorio@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Cq-Do-Not-Cancel-Tryjobs: true
Bug: None
Tbr: jcgregorio@google.com
Change-Id: Ida430fcb5dd0e144645cc2cfba3650efa1cd3fd2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2498788Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#820764}

Using wpt-import in Chromium 2c2f19bc.
With Chromium commits locally applied on WPT:
2c2f19bc "[mathml] Support scriptlevel attribute"


Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
foolip@chromium.org, lpz@chromium.org, robertma@chromium.org:
  external/wpt/tools

NOAUTOREVERT=true
TBR=foolip@google.com

No-Export: true
Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-payments-fyi-rel
Change-Id: Icf304b76a61e443dbb3b8f01f365a8c44cd68d5e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2497152Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#820763}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/73fe59b5..da8c46c5

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I0d51a459f6dfae19bdf33282d61580076ae4263c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2497805Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#820762}

This test was disabled due to flake. The flake was caused by a bug which
was fixed by crrev.com/ae1a0ae1 quite a while ago.

Fixed: 995181
Change-Id: Ic1afcbb3b25cdcf70d6179bf365dc4729e1c451d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495512
Auto-Submit: Ken Rockot <rockot@google.com>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#820761}

Release_Notes: http://go/media_app-x20/relnotes/Main/media_app_202010260700_RC00.html

https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/media_app/app/+/d_W31KKgRgYuvgrFL3we1kiiq2UPrniL8Q6CCbFkclAC

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/media-app-chromium-autoroll
Please CC media-app@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: b/165720635,b/171275495
Tbr: media-app@grotations.appspotmail.com
Change-Id: Ia260895dcdcae8741cd2445944ff43d04376b1a6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2498842Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#820760}

These requests are not blocked by content/, so there is no point in
counting them in Blink. When we get closer to having a plan for these
requests, we will want to revisit this so as to gather data.

Bug: chromium:1129326
Change-Id: Ib5829385727db3a29955c5246aa9c0ce07d55f09
Fixed: chromium:1134601
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489918
Commit-Queue: Steve Kobes <skobes@chromium.org>
Reviewed-by: Steve Kobes <skobes@chromium.org>
Reviewed-by: Pâris Meuleman <pmeuleman@chromium.org>
Auto-Submit: Titouan Rigoudy <titouan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#820759}

This change adds C++ syntax highlighting to the code blocks found in
//docs/pattern and removes unnecessary leading whitespace.

While this highlighting is not visible in Code Search's markdown view,
it is supported when viewed through gitiles:
https://github.com/google/gitiles/blob/master/Documentation/markdown.md#compiled

Bug: None
Change-Id: Id2d4298fc69f57b7abe1aa589f547221785791ac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494580Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#820758}

The PasswordInfobarModalOverlayRequestCallbackInstaller class was
written to handle both Save and Update Password Infobar Overlay actions.
However, this caused problems with the overlay callback manager logic,
which executed all callbacks that matched a request's config.
Thus, each PasswordInfobarModalOverlayRequestCallbackInstaller instance
needs to know which Password type it is handling, so that it can only
handle logic if the triggering request was of the same type.

Bug: 1141708
Change-Id: I12a6eb14a30ed9308c58a1cd7a1568da9736cb0d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493433
Commit-Queue: Chris Lu <thegreenfrog@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#820757}

As part of http://crbug.com/1064647 this CL removes Flash from the
Settings page and UI tests.

Bug: 1133888
Change-Id: Iabe202b9d1c3529b117a4ec045bddb689cc80f29
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461344Reviewed-by: Christian Dullweber <dullweber@chromium.org>
Reviewed-by: Theodore Olsauskas-Warren <sauski@google.com>
Reviewed-by: Esmael Elmoslimany <aee@chromium.org>
Commit-Queue: Illia Klimov <elklm@google.com>
Cr-Commit-Position: refs/heads/master@{#820756}

With this change, it becomes possible, in Selectors, to evaluate a CSS
expression against an element that was found previously and weed out
elements that don't match that expression, such as:

filters { css_selector: "label" }
filters { inner_text { re2: "text" } }
filters { labelled {} }
filters { match_css_selector: ":checked" }

This is necessary for the "check box" actions, that guarantee that
they're going to check the checbox, not uncheck it. Currently, scripts
cannot use labelled checkbox, because they can't figure out whether
clicking on them will check or uncheck them.

This change also allows checking the type of elements found with
labelled:

filters { css_selector: "label" }
filters { inner_text { re2: "text" } }
filters { labelled {} }
filters { match_css_selector: "input[type='checkbox']" }

Bug: b/171537366
Change-Id: Ifc9475b00d2ddf526c62ecca70aae5905ad5c093
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494931
Commit-Queue: Stephane Zermatten <szermatt@chromium.org>
Reviewed-by: Sandro Maggi <sandromaggi@google.com>
Cr-Commit-Position: refs/heads/master@{#820755}

This objects holds an sql::Database, so its destructor can do IO. But
it was destroyed on the UI thread.

Bug: 1141999, 88586
Change-Id: I5ad15deaf7eb3ab5c234d1d4b629dc65216d780b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495351Reviewed-by: Christian Dullweber <dullweber@chromium.org>
Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org>
Cr-Commit-Position: refs/heads/master@{#820754}

Background::get_color() doesn't return the actual color for painter
background. This caused wrong color for the dark theme.

Also updated ink drop opacity because now buttons match row background.
The base color now is darker so it would be darker than row background
with default hover opacity.

Bug: 1133847
Change-Id: Iaa942fbd4dc133cd64a671c105c31c45919c14ac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2498602Reviewed-by: Tommy Li <tommycli@chromium.org>
Commit-Queue: Olesia Marukhno <olesiamarukhno@google.com>
Cr-Commit-Position: refs/heads/master@{#820753}

This is the only remaining occasion, as far as I can tell, where we
are still forgetting to set the parent of a child object properly.
All other cases have been fixed either by my previous patches or by
patches recently authored by aleventhal@.
Also added a few DCHECKs in AXSlider and AXMenuList.

AX-Relnotes: n/a.

R=dmazzoni@chromium.org, aleventhal@chromium.org

Change-Id: I22af3f276cc325a71968f6b2956d17120ce03320
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2356484
Commit-Queue: Nektarios Paisios <nektar@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#820752}

Incognito mode is not available in ephemeral Guest profiles, but other
OTR profiles are allowed.

Bug: 1125474
Change-Id: I78f5b86f11dac8572ab5198cb8e07012e87fd4db
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494940Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Cr-Commit-Position: refs/heads/master@{#820751}

Before this CL, upon sign-out, Sync.StopSource was recorded both in the
SIGN_OUT bucket and in one of the auto-sync buckets, i.e.
ANDROID_MASTER_SYNC or ANDROID_CHROME_SYNC. This CL fixes this by
adding a check for whether there's still a primary account by the time
the auto-sync buckets are recorded.

Bug: 1140912
Change-Id: Id00d0da70571a05c19af50a576b8cb1cb60ad2c7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495145Reviewed-by: Marc Treib <treib@chromium.org>
Commit-Queue: Victor Vianna <victorvianna@google.com>
Cr-Commit-Position: refs/heads/master@{#820750}

This CL uses FieldRendererIds to retrieve an AutofillField from the
FormStructure cache of AutofillHandler.

Before this CL, the first AutofillField that satisfied SameFieldAs()
was considered a hit. For forms with multiple identical fields, this
may have been a false positive.

In particular, this fixes the filling of the wrong section in forms
like billing+shipping forms with multiple identical fields.

Bug: 1141847
Change-Id: Ib95aef11be43ece7db001eb02c495ac14cc21685
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495063Reviewed-by: Matthias Körber <koerber@google.com>
Commit-Queue: Christoph Schwering <schwering@google.com>
Cr-Commit-Position: refs/heads/master@{#820749}