- 20 Dec, 2018 40 commits
-
-
Steven Bennetts authored
Previously the translation code assumed that onc::ipconfig::kIPAddress would never be empty, however that is not enforced in ONC. If the address is empty it should be treated as if it is not present. With this change the code will fall back to a Saved or Static IP Address if the value is missing or if it is empty. If none are available the IP Address will not be set. Bug: 902713 Change-Id: I2f9880966661a85a8aace04e56bdac8516e5b3e4 Reviewed-on: https://chromium-review.googlesource.com/c/1379207 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Cr-Commit-Position: refs/heads/master@{#618388}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/e4beab79cd67..578b089986fa git log e4beab79cd67..578b089986fa --date=short --no-merges --format='%ad %ae %s' 2018-12-20 jvanverth@google.com Revert "Tweak Plot size to try to get better perf." 2018-12-20 herb@google.com Convert GrGlyph::PackedID to SkPackedGlyphID 2018-12-20 reed@google.com add gm and fix origin for xform-based blobs 2018-12-20 recipe-roller@chromium.org Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@578b089986fa The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=halcanary@chromium.org Change-Id: Ifd8c78a579a8634b7ce0e327d6a8947f3935557c Reviewed-on: https://chromium-review.googlesource.com/c/1387660Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#618387}
-
Nick Harper authored
Removal request received via email and validated via DNS. Change-Id: Iec03253374fc203a7c9785511151771ccc0162d7 Reviewed-on: https://chromium-review.googlesource.com/c/1387605Reviewed-by:
Bence Béky <bnc@chromium.org> Commit-Queue: Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#618386}
-
Kristi Park authored
TBR=sdefresne@chromium.org Bug: 893362 Change-Id: I9ad091f564dfc9d0e1772fb34222007e7cc51388 Reviewed-on: https://chromium-review.googlesource.com/c/1387910Reviewed-by:
Kristi Park <kristipark@chromium.org> Commit-Queue: Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/heads/master@{#618385}
-
Sergey Ulanov authored
Previusly when ssh port forwarding command exits with exitcode != 0 the script was trying to format error message with output.returncode, where output is a pipe, i.e. it doesn't have returncode field. Updated the script to use task.returncode instead. Change-Id: I132f7de42344244dfbdf16f4f4a500ac1a48b7df Reviewed-on: https://chromium-review.googlesource.com/c/1387726Reviewed-by:
Fabrice de Gans-Riberi <fdegans@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#618384}
-
Peter Wen authored
This option no longer exists in Android Studio 3.4+. Bug: 917016 Change-Id: I533d40288faf2693ad32fe9646d48073c30ac7c8 Reviewed-on: https://chromium-review.googlesource.com/c/1387155 Commit-Queue: Peter Wen <wnwen@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#618383}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Headers.git/+log/bbf63435c37a..17da9f8231f7 git log bbf63435c37a..17da9f8231f7 --date=short --no-merges --format='%ad %ae %s' 2018-11-30 cepheus@frii.com Reserve tokens for float controls and no integer wrapping: Created with: gclient setdep -r src/third_party/spirv-headers/src@17da9f8231f7 The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-headers-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Ied8db2e8b2d87d962c41bc8b0854b04e2bc8c551 Reviewed-on: https://chromium-review.googlesource.com/c/1387673Reviewed-by:
-
Abhishek Bhardwaj authored
This change removes a separate test implementation of wake locks. This results in more production code being unit tested. BUG=chromium:913353 TEST=Run WakeLockTest unit tests. Change-Id: Ie4b3d3384c148c90c6ee937b91710bfe9b87d9c8 Reviewed-on: https://chromium-review.googlesource.com/c/1379704 Commit-Queue: Abhishek Bhardwaj <abhishekbh@chromium.org> Reviewed-by:
Dan Erat <derat@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#618381}
-
Jay Harris authored
An instance of the badge service can be moved between different browsers so we should find the delegate/hosted_app as needed instead of storing them at instantiation. Bug: 916904 Change-Id: Ia91875f3342be0bb7b2e7dd1807efd2cdd36206c Reviewed-on: https://chromium-review.googlesource.com/c/1385726 Commit-Queue: Jay Harris <harrisjay@chromium.org> Reviewed-by:
Matt Giuca <mgiuca@chromium.org> Cr-Commit-Position: refs/heads/master@{#618380}
-
Dave Tapuska authored
Remove the paused_calls vector on WorkerGlobalScope because all the calls executed occur on pausable task queues after http://crrev.com/1eb2d22. BUG=907125 Change-Id: I42ad827eb1131f643158f9c6e565d69886896ccc Reviewed-on: https://chromium-review.googlesource.com/c/1385015 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#618379}
-
Tomasz Wiszkowski authored
Presentation is done by Mediator instead. Bug: 871798 Change-Id: If7fc3d1243990580d3e95c6ce3023fe23f03cd65 Reviewed-on: https://chromium-review.googlesource.com/c/1384632 Commit-Queue: Tomasz Wiszkowski <ender@google.com> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#618378}
-
James Robinson authored
This function shadowed the 'package_name' local so it always ended up running the most recently installed package instead of the specified package. This works fine for invocations with a single package, or with the target package last, but not for tests with multiple package dependencies. Change-Id: I1fe16ab22bd46970a99043fa42c810c32d323701 Reviewed-on: https://chromium-review.googlesource.com/c/1387905Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
-
Matthew Denton authored
This missing space may have screwed up WHERE statements when creating indexes (or might not have, since I don't see any errors. Adding anyway) R=metzman@chromium.org, pwnall@chromium.org Bug: 909886 Change-Id: Idd322f43a2b715d1d282546df4c504148a5014a4 Reviewed-on: https://chromium-review.googlesource.com/c/1387837 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Jonathan Metzman <metzman@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#618376}
-
Leonard Grey authored
This change: - Mostly implements UX's secondary UI spec - Switches topchrome to use the same colors as incognito, though this may be temporary - Replaces some temp colors Bug: 912375, 850098 Change-Id: I447c3062455330b01c0e7381d3a9eabd2709a970 Reviewed-on: https://chromium-review.googlesource.com/c/1378408 Commit-Queue: Leonard Grey <lgrey@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#618375}
-
CJ DiMeglio authored
This reverts commit b5126abd. Reason for revert: Breaks build Original change's description: > Revert "Add verification of e-mails being signed in using GCPW." > > This reverts commit 42eeddf5. > > Reason for revert: <INSERT REASONING HERE> > > Original change's description: > > Add verification of e-mails being signed in using GCPW. > > > > - Remove use of 'ep' registry for e-mail patterns and instead use 'ed' to > > specify valid e-mail domains. > > - Allow multiple valid e-mail domains > > - Check Gaia signed in user has a valid e-mail / gaia id > > > > Bug: 914366, 913977 > > Change-Id: Icb2a3281f2381d5c64200cafbfb2f452f5d0aecf > > Reviewed-on: https://chromium-review.googlesource.com/c/1381726 > > Commit-Queue: Tien Mai <tienmai@chromium.org> > > Reviewed-by: Roger Tawa <rogerta@chromium.org> > > Reviewed-by: Nico Weber <thakis@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#618215} > > TBR=rogerta@chromium.org,thakis@chromium.org,tienmai@chromium.org > > Change-Id: I82bfd838901dd7cd2730c4a0a1c8d0a4886b4c83 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 914366, 913977 > Reviewed-on: https://chromium-review.googlesource.com/c/1387961 > Reviewed-by: CJ DiMeglio <lethalantidote@chromium.org> > Commit-Queue: CJ DiMeglio <lethalantidote@chromium.org> > Cr-Commit-Position: refs/heads/master@{#618371} TBR=rogerta@chromium.org,thakis@chromium.org,lethalantidote@chromium.org,tienmai@chromium.org Change-Id: I8888a63d3d14387a954b45cdbc306292ba97059c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 914366, 913977 Reviewed-on: https://chromium-review.googlesource.com/c/1388028Reviewed-by:
CJ DiMeglio <lethalantidote@chromium.org> Commit-Queue: CJ DiMeglio <lethalantidote@chromium.org> Cr-Commit-Position: refs/heads/master@{#618374}
-
Sadrul Habib Chowdhury authored
Add a test to make sure that already removed presentation callbacks for submitted compositor frames do not cause crashes. BUG=915458 Change-Id: Ia0ae709a6a6792564a01d3086369f32850cf14fb Reviewed-on: https://chromium-review.googlesource.com/c/1381778 Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#618373}
-
Zhenyao Mo authored
This reverts commit 6b713ba7. Reason for revert: This doesn't fix the test failure on Linux/AMD Original change's description: > Clamp texture BASE/MAX_LEVEL for GenerateMipmap on Linux AMD > > The conformance test fails on Linux/AMD. Let's see if the workaround may fix it. > > BUG=913301 > TEST=Linux AMD bot on GPU/FYI > R=kbr@chromium.org > > Change-Id: I15c73bfc36f621b3bc02d678be70727bb3995d42 > Reviewed-on: https://chromium-review.googlesource.com/c/1385106 > Commit-Queue: Zhenyao Mo <zmo@chromium.org> > Reviewed-by: James Darpinian <jdarpinian@chromium.org> > Cr-Commit-Position: refs/heads/master@{#618010} TBR=zmo@chromium.org,kbr@chromium.org,jdarpinian@chromium.org Change-Id: I49f854d90ae1df1dc1b3eb70c8584d2d98355848 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 913301 Reviewed-on: https://chromium-review.googlesource.com/c/1388025Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#618372}
-
CJ DiMeglio authored
This reverts commit 42eeddf5. Reason for revert: <INSERT REASONING HERE> Original change's description: > Add verification of e-mails being signed in using GCPW. > > - Remove use of 'ep' registry for e-mail patterns and instead use 'ed' to > specify valid e-mail domains. > - Allow multiple valid e-mail domains > - Check Gaia signed in user has a valid e-mail / gaia id > > Bug: 914366, 913977 > Change-Id: Icb2a3281f2381d5c64200cafbfb2f452f5d0aecf > Reviewed-on: https://chromium-review.googlesource.com/c/1381726 > Commit-Queue: Tien Mai <tienmai@chromium.org> > Reviewed-by: Roger Tawa <rogerta@chromium.org> > Reviewed-by: Nico Weber <thakis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#618215} TBR=rogerta@chromium.org,thakis@chromium.org,tienmai@chromium.org Change-Id: I82bfd838901dd7cd2730c4a0a1c8d0a4886b4c83 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 914366, 913977 Reviewed-on: https://chromium-review.googlesource.com/c/1387961Reviewed-by:
-
Brian White authored
More than 1000 buckets is probably an error and so make it obvious to the user by a DCHECK and a reduced output. Some histograms are known to already have more than this number of buckets; whitelist those. Bug: 915892 Change-Id: I79a562ec7b883f57b5721e2f0ecd52f955044f39 Reviewed-on: https://chromium-review.googlesource.com/c/1385120 Commit-Queue: Brian White <bcwhite@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#618370}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/7b72af28fb84..f5b3ad2f705e git log 7b72af28fb84..f5b3ad2f705e --date=short --no-merges --format='%ad %ae %s' 2018-12-20 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-12-20 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-12-20 recipe-roller@chromium.org Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@f5b3ad2f705e The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: Ie43e1f06714f7d58d8e1024cc38e37a2a7566d26 Reviewed-on: https://chromium-review.googlesource.com/c/1387833Reviewed-by:
-
Avi Drissman authored
This switches them to use Optional, and makes them clonable in preparation for linked_ptr removal. BUG=582001 Change-Id: I1ba6bb559b6fec703f41ad22ad670799ec61c91d Reviewed-on: https://chromium-review.googlesource.com/c/1380819 Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#618368}
-
Mustafa Emre Acer authored
The top domain heuristic incorrectly marks certain domains as lookalikes, despite the fact that the domain itself is a top domain. As a result of this bug, tést[.]blogspot[.]com displays a "Did you mean to go to blogspot.com". This happens because: - We currently use INCLUDE_PRIVATE_REGISTRIES flag when computing eTLD+1s via net::registry_controlled_domains::GetDomainAndRegistry. - This results in the eTLD+1 of "tést[.]blogspot[.]com" being computed as "tést[.]blogspot[.]com" instead of just "blogspot[.]com". - Since the eTLD+1 contains IDN, we perform the top domain skeleton check. - This check compares "tést[.]blogspot[.]com" against top domains and finds "blogspot[.]com" as a match. - This in turn records metrics and shows the UI. This CL excludes private registries in eTLD+1 computation. As a result, eTLD+1 of private registries will exclude the subdomain, e.g. eTLD+1 of "tést[.]blogspot[.]com" will now be computed as "blogspot[.]com". Since the new eTLD+1 does not have IDN, it will not trigger any further checks and the navigation will not be treated as a lookalike. Bug: 843361 Change-Id: Iaec1a0af61fa7aa9a2091bff3212171ba36034ad Reviewed-on: https://chromium-review.googlesource.com/c/1387670Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#618367}
-
Esmael El-Moslimany authored
Patchset 1 is the revert. Patchset 2 is the fix. Bug: 916888 Change-Id: I16e2fc111c8ca6e3477414f4ed893bd4da0e2087 Reviewed-on: https://chromium-review.googlesource.com/c/1387386Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#618366}
-
Peter Kotwicz authored
This CL switches WebApkIntegrationTests to use HTTPS instead of HTTP. This is in preparation for landing https://chromium-review.googlesource.com/c/chromium/src/+/1359452 which would make the WebApkIntegrationTests fail if they kept on using HTTP. https://chromium-review.googlesource.com/c/chromium/src/+/1359452 changes HTTP pages to be marked as dangerous. This affects the return value of WebappBrowserControlsDelegate#shouldShowBrowserControls(). This CL: - Switches WebApkIntegrationTest to use HTTPS - Moves ChromeMockCertVerifier into its own file - Introduces MockCertVerifierRuleAndroid which makes Chrome use a MockCertVerifier. BUG=None Change-Id: Ibdecad77fdd3456dcae9a4965c1ec07653f49e2a Reviewed-on: https://chromium-review.googlesource.com/c/1378816 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Misha Efimov <mef@chromium.org> Cr-Commit-Position: refs/heads/master@{#618365}
-
Devlin Cronin authored
Rename some UserScriptLoader members to be a bit more clear. - Rename "pending_load_" to "queued_load_". This better explains that a load is queued up, but not yet started. - Rename "user_scripts_" to "loaded_scripts_". This more accurately indicates that the scripts contained within |loaded_scripts_| are the ones that have been fully loaded, rather than those that are queued up to load. Also expose a UserScriptLoader getter on SharedUserScriptMaster, and remove the forwarding method to UserScriptLoader::initial_load_complete. Bug: None Change-Id: I9276387a888572cf3e9575b5e2a2a1ee4dd47e07 Reviewed-on: https://chromium-review.googlesource.com/c/1387394Reviewed-by:
-
Joshua Peraza authored
Monochrome uses /system/bin/app_process to load a Java class, CrashpadMain, to start the Crashpad handler process. In order for app_process to locate this class and for CrashpadMain to be able to load the native libraries for Crashpad, CLASSPATH and LD_LIBRARY_PATH need to be set with all the paths containing code that the Chrome package depends on. Add PackagePaths to build these paths. This work is normally done internally by the Android framework: https://cs.corp.google.com/android/frameworks/base/core/java/android/app/LoadedApk.java?rcl=7b2b4c838be94e6ca7cfbb255523c800da4a0cce&l=422 Bug: 912739 Change-Id: I30e4952fb17fea42bdc995296c47cf8a9f440866 Reviewed-on: https://chromium-review.googlesource.com/c/1366763Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Joshua Peraza <jperaza@chromium.org> Cr-Commit-Position: refs/heads/master@{#618363}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 2048b2aa. With Chromium commits locally applied on WPT: 1c633d48 "Snap the snapped_dest_rect for backgrounds" 1061788d "Reland "Add quota usage details tests for all other storage backends."" 23a658b9 "WebBluetooth Scanning API" 09f60d66 "[LayoutNG] Don't allow line height quirk inside list items." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: jsbell@chromium.org: external/wpt/resources NOAUTOREVERT=true TBR=raphael.kubo.da.costa No-Export: true Change-Id: I142fbf3b825f9755ff4c7b1ef962f9e9f6aa9541 Reviewed-on: https://chromium-review.googlesource.com/c/1387744Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#618362}
-
Tomasz Wiszkowski authored
Bug: 871798 Change-Id: Icef80d21688e7777d17f551b2eacceeb62904c7c Reviewed-on: https://chromium-review.googlesource.com/c/1383447 Commit-Queue: Tomasz Wiszkowski <ender@google.com> Reviewed-by:
-
Kristi Park authored
NTP thumbnails have been deprecated as of M69. Remove forced URLs and thumbnail data from TopSitesDatabase. This includes renaming the "thumbnails" table to "top_sites"; removing all columns except url, url_rank, title, and redirects; and all rows for forced sites. Forced sites were only used to store thumbnails for Most Likely sites. Bug: 893362 Change-Id: I0fe5662869db014d62002575fdaaebf29ece9359 Reviewed-on: https://chromium-review.googlesource.com/c/1383139 Commit-Queue: Kristi Park <kristipark@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#618360}
-
Fabrice de Gans-Riberi authored
These tests hang and time out regularly. Bug: 913037 Change-Id: I0cca43ecf5ce6320371885d07c50c90986afd137 Reviewed-on: https://chromium-review.googlesource.com/c/1387389 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
-
Mason Freed authored
With this CL, the border box of the element containing backdrop-filter is plumbed through to viz, so that the backdrop-filter effect can be properly clipped at the border box of the element itself. This will keep it from "bleeding" outside to the border rect of the entire layer (including children). This should fix most of the reported bugs related to the filtered effect extending beyond the proper bounds. Bug: 497522, 813796, 767997, 659501, 632979, 618913, 593307 Change-Id: I5f24ac79053b3779cea128aacabd60f9d66702f4 Reviewed-on: https://chromium-review.googlesource.com/c/1378811Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Commit-Queue: Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#618358}
-
John Lee authored
History WebUI: Move sidebar and content within scrolling containers with tabindex of -1 and no outlines Bug: 906729 Change-Id: I11248b67f99cf6cfcc44d765ff9778ffcf6116b0 Reviewed-on: https://chromium-review.googlesource.com/c/1385852Reviewed-by:
Scott Chen <scottchen@chromium.org> Commit-Queue: John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#618357}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/cdef3415..77c3fa73 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Idc59f0459cced4cd5de49a65b923ab29fc22e9dd Reviewed-on: https://chromium-review.googlesource.com/c/1387190Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#618356}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/9fbd2ad38c75..e4beab79cd67 git log 9fbd2ad38c75..e4beab79cd67 --date=short --no-merges --format='%ad %ae %s' 2018-12-20 egdaniel@google.com Disable vulkan specific code in GrAHardwareBufferImageGenerator when not building vulkan. 2018-12-20 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-12-20 herb@google.com Remove PackedID from the strike call chain 2018-12-20 brianosman@google.com Add wide color support to stroke rect op and default GP 2018-12-20 reed@google.com remove some dead debugger command types 2018-12-20 herb@google.com Make and use a ctor for GrGlyph Created with: gclient setdep -r src/third_party/skia@e4beab79cd67 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=halcanary@chromium.org Change-Id: I6c880e82e9110a81924db38eeb5a2fe07ab0135b Reviewed-on: https://chromium-review.googlesource.com/c/1387825Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b903bc0f5428..82c17e7b8d31 Created with: gclient setdep -r src-internal@82c17e7b8d31 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ibd8616a82847ab0b4da8f9d6cd73219f2ff5346b Reviewed-on: https://chromium-review.googlesource.com/c/1387824Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#618354}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/44d98b424db4..4626e207e285 git log 44d98b424db4..4626e207e285 --date=short --no-merges --format='%ad %ae %s' 2018-12-20 tsepez@chromium.org Remove CFX_FloatRect::Reset(). 2018-12-20 tsepez@chromium.org Remove CFX_RectF::Reset(). 2018-12-20 thestig@chromium.org Fix a crash in FPDFPage_TransFormWithClip(). 2018-12-20 thestig@chromium.org Change FPDFPage_TransFormWithClip() to take const pointers. 2018-12-20 thestig@chromium.org Implement CFXMatrixFromFSMatrix(). 2018-12-20 thestig@chromium.org Reorder cpdfsdk_helpers.cpp to match its header. 2018-12-20 tsepez@chromium.org Pass matrix to CPDF_ClipPath::Transform() by const-ref. Created with: gclient setdep -r src/third_party/pdfium@4626e207e285 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I5b2457adb2149a3650839d3b099ffb29da93216a Reviewed-on: https://chromium-review.googlesource.com/c/1387648Reviewed-by:
-
Nico Weber authored
1. Don't create a temporary zip list just for element-wise comparison. 2. Only enter the streams loop if we don't end up throwing away all computation in it. On my machine, reduces runtime on a synthetic benchmark (comparing base_unittests and all deps between a release and a debug component build) from 37s to 20s. Bug: 314403 Change-Id: Id425c3fbab99981391ec9de8887defc00d0da0af Reviewed-on: https://chromium-review.googlesource.com/c/1387609Reviewed-by:
Erik Chen <erikchen@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#618352}
-
Vladimir Levin authored
This patch changes the display locking update() function to not paint. The reason for this is that update cannot release the lock on its own and painted information is not needed for any information that script might want. Note that this updates the budget to actually check if any work is required since we cannot reliably wait for any lifecycle phase. Previously we waited for paint which was always guaranteed to happen. Note that this updates the budget API to have NeedsLifecycleUpdates instead of DidFinishLifecycleUpdates, which now checks the dirty bits for any phases that might need updating. It might be nice to implement co-operative painting that stashes the paint for later use, but at this point it is only doing extra work. R=chrishtr@chromium.org Bug: 882663 Change-Id: Ie426dc75ea036b6f2e16b1b592763267957685ce Reviewed-on: https://chromium-review.googlesource.com/c/1383324 Commit-Queue: vmpstr <vmpstr@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#618351}
-
Kristi Park authored
NTP thumbnails have been deprecated as of M69. As such, data stored in TopSitesDatabase for thumbnails/forced sites is unused. Refactor TopSitesDatabase to not return forced sites/thumbnail data. If a database entry is updated, the entry's thumbnail data will be overridden and discarded. New entries will not contain thumbnail data, and forced sites will no longer be stored. Bug: 893362 Change-Id: I6fc0bd8b7c04c7451bfe7ec1a072a7ac66df7c52 Reviewed-on: https://chromium-review.googlesource.com/c/1368778 Commit-Queue: Kristi Park <kristipark@chromium.org> Reviewed-by:
-
Robert Flack authored
Blink animations, which make up the majority of cc::Animations, always set ElementId on the KeyframeModel. In the longterm this will be the case for all animations. Optimize for this case to address the branch performance cost in issue 909054. Bug: 909054 Change-Id: I4e34607dc3c17040afa3199bc8a675d5d84cd520 Reviewed-on: https://chromium-review.googlesource.com/c/1378585Reviewed-by:
-
