GitLab

$('alertOverlay') is null so the call for classList failed.  Guard the
condition to see if the element exists.

BUG=379194

Review URL: https://codereview.chromium.org/301223009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273956 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/309623003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273954 0039d316-1c4b-4281-b951-d872f2087c98

This is a minimal diff that refactors the key/value stash into a class.
The next step is to pull the class implementation out to a separate
implementation file and add a unittest.
Also normalizes the use of the anonymous namespace to exclude functions
that are DLL exports.

BUG=378916

Review URL: https://codereview.chromium.org/302033002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273953 0039d316-1c4b-4281-b951-d872f2087c98

Device pixel ratio is used to scale test rect and sampling locations.
It can be non-integral on some devices. For example it is 1.325 on
Nexus 7. The scaled quantities - dimensions of screenshot and sampled
pixel locations - need to be converted to integers before they can
be used.

BUG=368495

Review URL: https://codereview.chromium.org/303113004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273951 0039d316-1c4b-4281-b951-d872f2087c98

BUG=377636
TEST=run the test 50 times and no flakiness observed

Review URL: https://codereview.chromium.org/306953004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273950 0039d316-1c4b-4281-b951-d872f2087c98

BUG=239879

Review URL: https://codereview.chromium.org/308713006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273949 0039d316-1c4b-4281-b951-d872f2087c98

BUG=364821
NOTRY=true
R=thestig@chromium.org
TBR=thestig@chromium.org

Review URL: https://codereview.chromium.org/306033005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273945 0039d316-1c4b-4281-b951-d872f2087c98

Right now ubsan=1 doesn't work with Chromium-packaged Clang because of missing libraries.

BUG=174801
R=thakis@chromium.org

Review URL: https://codereview.chromium.org/299403007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273944 0039d316-1c4b-4281-b951-d872f2087c98

BUG=379359
R=thestig@chromium.org
TBR=thestig@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/307993008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273940 0039d316-1c4b-4281-b951-d872f2087c98

R=binji@chromium.org

Review URL: https://codereview.chromium.org/304393006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273938 0039d316-1c4b-4281-b951-d872f2087c98

This fixes a problem I saw this morning where we were alerting on any movement
in jank, including improvements.

BUG=

Review URL: https://codereview.chromium.org/308863002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273937 0039d316-1c4b-4281-b951-d872f2087c98

Improve the verification routines especially in the case that no count
is necessary.

Also add a test.

R=darin@chromium.org

Review URL: https://codereview.chromium.org/304303006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273936 0039d316-1c4b-4281-b951-d872f2087c98

(manifest or permission features). This fixes the availability data on
accessibilityFeatures and bluetoothLowEnergy, among others; anywhere the API
and dependency name differ.

BUG=375615
R=rockot@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/302143003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273935 0039d316-1c4b-4281-b951-d872f2087c98

Otherwise if the initial load does not induce a replaceState, there is not
pageId in the history state to route to. Instead, always route from the URL.
This allows us to just pass-through the page state.

BUG=348948
TEST=See bug

Review URL: https://codereview.chromium.org/306043002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273934 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273932 0039d316-1c4b-4281-b951-d872f2087c98

Widens an existing suppression to account for more script state leaks.

BUG=364821
NOTRY=true
R=thestig@chromium.org
TBR=thestig@chromium.org

Review URL: https://codereview.chromium.org/302093007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273931 0039d316-1c4b-4281-b951-d872f2087c98

This brings in
dbd4c06  In linux and mac, use Arial to replace Tahoma for displaying east europe characters
64ab40e  Fix xcode build.
961a34a  Followup comments from https://codereview.chromium.org/298893007/
40c4fb8  Fix a security issue in FPDF_GetMetaText by Bo Xu - 2 days ago
17211ae  Do not use FX_BOOL for int values.
6387aff  Fix licenses in headers to pass Chromium's checklicenses tool.
33729cd  Add Lei to AUTHORS
9ea3da2  adjust output dir for msvs to fix msvs link error
2296d76  Change cc list to be pdfium-reviews@googlegroups.com
db140c8  Use unsigned type for decoding in _A85Decode.
282e53d  Fix memory leak on array size overflow.
2611932  Fix build error on Windows stand alone build

Review URL: https://codereview.chromium.org/302143005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273930 0039d316-1c4b-4281-b951-d872f2087c98

BUG=379195

Review URL: https://codereview.chromium.org/306023008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273929 0039d316-1c4b-4281-b951-d872f2087c98

ContextFactory::Set/GetInstance is going away and not necessary
anymore.

BUG=none
TEST=none
R=ben@chromium.org

Review URL: https://codereview.chromium.org/306123007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273926 0039d316-1c4b-4281-b951-d872f2087c98

happen if the URL is bookmarked and all its visits are deleted.

BUG=377711

Review URL: https://codereview.chromium.org/300843004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273925 0039d316-1c4b-4281-b951-d872f2087c98

patch from issue 308103003

BUG=none
TEST=none
TBR=samarth@chromium.org,sky@chromium.org,jered@chromium.org

Review URL: https://codereview.chromium.org/308653007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273922 0039d316-1c4b-4281-b951-d872f2087c98

Drop ENABLE_NEW_GAMEPAD_API build flag as it is no longer needed now that
the Blink side has been updated and all the #ifdefs have been removed.

R=dmichael@chromium.org, brettw@chromium.org
BUG=344556

Review URL: https://codereview.chromium.org/302893002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273921 0039d316-1c4b-4281-b951-d872f2087c98

Adds resource and host, unit test for the resource, and an example plugin.
Implements only the hardware accelerated case. Software fallback will be
in a follow-on CL.

Adds two new PP_Error codes:
PP_ERROR_UNREADABLE_INPUT
PP_ERROR_PLATFORM_FAILED

BUG=281689
R=dmichael@chromium.org, fischman@chromium.org, jar@chromium.org, piman@chromium.org, tsepez@chromium.org

Review URL: https://codereview.chromium.org/270213004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273920 0039d316-1c4b-4281-b951-d872f2087c98

R=yzshen@chromium.org

Review URL: https://codereview.chromium.org/304233011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273919 0039d316-1c4b-4281-b951-d872f2087c98

This change contains most of the changes that clang-format
wanted to make to nacl_io.  I left out a few that we not
obviously better, mostly related to complex PPAPI macros.

R=binji@chromium.org, binji
BUG=

Review URL: https://codereview.chromium.org/303223007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273918 0039d316-1c4b-4281-b951-d872f2087c98

The very first invocation of [NSCursor push]/[NSCursor set] leaks,
intentionally. Suppress all invocations for now. ([NSCursor set] only
in the suppressions, seems -push seems to get inlined.

BUG=257276, 379331
TBR=thestig@chromium.org, shess@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/303123009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273917 0039d316-1c4b-4281-b951-d872f2087c98

Chrome OS specific garbage collection in addition to profile specific
clean up also cleans up shared location but only once regardless number
of logged in users.

BUG=235263
TEST=unittest

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273763

R=asargent@chromium.org

Review URL: https://codereview.chromium.org/303693011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273916 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://codereview.chromium.org/308843002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273915 0039d316-1c4b-4281-b951-d872f2087c98

> skia: Use medium filter quality in PaintSimplifier.
> 
> Preventing all bitmap filtering in the paint simplifier is a bad
> idea as it's very cache unfriendly when down-sampling due to
> requiring both the full size decoded image and the high/medium
> quality image normally used to be cached for good performance.
> 
> However, forcing medium quality filtering is worthwhile as it's
> faster than high quality and still provides caching benefits.
> 
> BUG=
> 
> Review URL: https://codereview.chromium.org/305623008

Looks like this had a negative effect on memory usage.

TBR=reveman@chromium.org
BUG=379164

Review URL: https://codereview.chromium.org/308703006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273914 0039d316-1c4b-4281-b951-d872f2087c98

The cloud policy server is now controlling the amount of delay through policy, so the flag is no longer needed. This change also lowers the default amount of delay (in absence of policy) to a more reasonable value based on observations of traffic to the cloud policy server.

BUG=379010

Review URL: https://codereview.chromium.org/305073002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273913 0039d316-1c4b-4281-b951-d872f2087c98

R=darin@chromium.org, darin
BUG=

Review URL: https://codereview.chromium.org/304273004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273912 0039d316-1c4b-4281-b951-d872f2087c98

Privet v2 was renamed to privet v3

BUG=
NOTRY=true

Review URL: https://codereview.chromium.org/306073006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273911 0039d316-1c4b-4281-b951-d872f2087c98

BUG=372403
TEST=manual

Review URL: https://codereview.chromium.org/289133002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273910 0039d316-1c4b-4281-b951-d872f2087c98

This CL introduces HostExtension, an interface for classes that
extend the host with non-core functionality.

Extensions are added to the ChromotingHost. They are used to compile
the list of capabilities reported to the client, which can be used by
the client to determine the availability of the extension.

When a client connects, a HostExtension has the opportunity to create
an HostExtensionSession to hold client/extension state, and to handle
extension messages from that client.

BUG=

NOTRY=true

Review URL: https://codereview.chromium.org/301453003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273901 0039d316-1c4b-4281-b951-d872f2087c98

TBR=scottmg

Review URL: https://codereview.chromium.org/307133002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273900 0039d316-1c4b-4281-b951-d872f2087c98

More suppressions for pre-existing ResourceFetcher leak.

This leak was reintroduced in r273149 which reverted a CL that fixed it.

BUG=328092
R=thestig@chromium.org
TBR=mmemnke@chromium.org, thestig@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/307993006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273899 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=None
R=phajdan.jr@chromium.org

Review URL: https://codereview.chromium.org/296113011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273898 0039d316-1c4b-4281-b951-d872f2087c98

BUG=
TBR=michaeln@chromium.org

Review URL: https://codereview.chromium.org/309643002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273897 0039d316-1c4b-4281-b951-d872f2087c98

BUG=379276
TBR=mmoss@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/304373007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273896 0039d316-1c4b-4281-b951-d872f2087c98

Currently, subprocess_mu_ is held the entire time the llc subprocess is
starting. This blocks a larger refactor that I'd like to make as part of nexe
loading.

I'd like to change ServiceRuntime::LoadModule() to be asynchronous to simplify
threading behavior on the plugin side when loading nexe modules. However, this
requires that many methods are made asynchronous, including
Plugin::LoadHelperNaClModule().

PnaclTranslateThread will need to use a pattern similar to WaitForSelLdrStart()
to resume execution on a background thread. However, I don't like the idea of
introducing another mutex and condvar to deal with while holding
subprocess_mu_.

This change narrows the time that subprocess_mu_ is held to make that refactor
possible. I'll make a similar change for the ld subprocess, but I wanted to get
this reviewed before proceeding further.

BUG=333950
R=bbudge@chromium.org

Review URL: https://codereview.chromium.org/308013002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273895 0039d316-1c4b-4281-b951-d872f2087c98