- 22 Jan, 2018 40 commits
-
-
Evan Stade authored
For the changes to FileManagerBrowserTestBase, you can run affected tests with --gtest_filter=DriveSpecific* Bug: 783018 Change-Id: I30c06c731181a31197edef5e856ac3e6dd8d5554 Reviewed-on: https://chromium-review.googlesource.com/877004Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#531061}
-
Ria Jiang authored
1. If the target hit-test region we find in HitTestQuery has kHitTestAsk flag set, we need to fall back to the slow path - ask renderer to do the targeting. Return the viz::Target we find with kHitTestAsk in that case. 2. In RenderWidgetHostInputEventRouter::FindViewAtLocation, set RenderWidgetTargetResult::should_query_view to be true if kHitTestAsk is set in the target we received. Bug: 803548 Test: viz_unittests Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: I7df66f2e09a15308ee02ee4918ab1f43077b1fbd Reviewed-on: https://chromium-review.googlesource.com/876997Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Commit-Queue: Ria Jiang <riajiang@chromium.org> Cr-Commit-Position: refs/heads/master@{#531060}
-
Alexei Filippov authored
This is an experimental feature. BUG=803276 Change-Id: I03280510fd494ea3162f5ecbef00aa47cd4d9f6f Reviewed-on: https://chromium-review.googlesource.com/877511 Commit-Queue: Alexei Filippov <alph@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#531059}
-
MinChen authored
changes in this cl, 1. Create power button menu if ash::switches::kShowPowerButtonMenu is set. Create the corresponding view hierarchy of the menu. 2. Add PowerButtonScreenshotShowMenuTest* and TabletPowerButtonControllerShowMenuTest*. Following up cls, 1. Add corresponding switch in chromeos. 2. Adjust the menu position according to the position of the power button. The menu is put at the center of the screen currently. Bug: 799524 Change-Id: Id435328537fe08c7faf3e073564ba81498a86f56 Reviewed-on: https://chromium-review.googlesource.com/874784 Commit-Queue: min c <minch@chromium.org> Reviewed-by:
Dan Erat <derat@chromium.org> Reviewed-by:
Qiang(Joe) Xu <warx@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#531058}
-
pdfium-deps-roller@chromium.org authored
https://pdfium.googlesource.com/pdfium.git/+log/1fa1b1f771dd..ec06e1186d0d $ git log 1fa1b1f77..ec06e1186 --date=short --no-merges --format='%ad %ae %s' 2018-01-22 dsinclair Change GetContainerWidgetAcc to GetContainerNode 2018-01-22 dsinclair Move WidgetAcc and IsWidgetReady to CXFA_Node 2018-01-22 thestig Support jumbo build in XFA targets. 2018-01-22 thestig Break xfa target into smaller pieces. 2018-01-22 dsinclair Move IsNull and PreNull to CXFA_Node 2018-01-22 dsinclair Move the UI elements from CXFA_WidgetAcc to CXFA_Node 2018-01-22 dsinclair Add flag to notify if a node widget is ready 2018-01-22 adamk Use MaybeLocal versions of v8::Script APIs Created with: roll-dep src/third_party/pdfium The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I57b25ae44febfba39ea551f5512daa6ea149d3d9 Reviewed-on: https://chromium-review.googlesource.com/879397 Reviewed-by: <pdfium-deps-roller@chromium.org> Commit-Queue: <pdfium-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#531057}
-
angle-deps-roller@chromium.org authored
https://chromium.googlesource.com/angle/angle.git/+log/0e99b7a3bc8b..66f73b731e97 $ git log 0e99b7a3b..66f73b731 --date=short --no-merges --format='%ad %ae %s' 2018-01-22 lucferron Improve the dev setup instructions on Linux Created with: roll-dep src/third_party/angle The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=ynovikov@chromium.org Change-Id: Ifd063f8adb5f5876305f34be0254c41c8e39cd1b Reviewed-on: https://chromium-review.googlesource.com/879544 Commit-Queue: angle-deps-roller . <angle-deps-roller@chromium.org> Reviewed-by:
angle-deps-roller . <angle-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#531056}
-
Tommy C. Li authored
Add a new GetURLForDisplay method to sit alongside GetFormattedFullURL. This will be used in the Omnibox if the feature flag is on. The actual implementation knows nothing about the feature flag, since the feature flag is an Omnibox concern rather than a components/toolbar concern. Bug: 797354 Change-Id: I61fe6a70a5d7bb990a52866a9a28da8bc50d8a36 Reviewed-on: https://chromium-review.googlesource.com/877040 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#531055}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/5d750edfdd4f..baafcdcd5435 $ git log 5d750edfd..baafcdcd5 --date=short --no-merges --format='%ad %ae %s' 2018-01-22 reed move zero-init to sk_malloc for masks 2018-01-22 halcanary fetch-clang-format: better error checking 2018-01-19 halcanary SkQP: replace blacklist with: DoNotExecuteInExperimentalMode and NoScoreInCompatibilityTestMode 2018-01-22 wangxianzhu Set empty device clip when an image filter has zero bounds 2018-01-21 scroggo Add SkAnimatedImage::isFinished 2018-01-22 jvanverth Fix startup for SampleSlide 2018-01-20 scroggo Respect repetition count in SkAnimatedImage 2018-01-12 halcanary https://skia.org/skqp 2018-01-22 fmalita [sksg] Animator, Scene Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=robertphillips@chromium.org Change-Id: Ifa11f6f012d81029c5e27ae43e93636265ac5d20 Reviewed-on: https://chromium-review.googlesource.com/879483Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#531054}
-
Fan Yang authored
Let OnFrameAcked return true if any new data gets acked, false otherwise. The return value is not used currently. No functional change expected. Not protected. Merge internal change: 181662703 Change-Id: Iab2531029c58ff75663162a38c695d56db2b6fa9 Reviewed-on: https://chromium-review.googlesource.com/878442Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Fan Yang <fayang@chromium.org> Cr-Commit-Position: refs/heads/master@{#531053}
-
Tarun Bansal authored
The RTT and ECT is in navigator.connection API is set to the same value as the throttling value specified. The setNetworkConnectionInfoOverride() and setNetworkQualityInfoOverride() have been combined into a single API. Bug: 727911 Change-Id: I7bf809bd4f8bfa8f4256bad2f038ba5123cdc8a1 Reviewed-on: https://chromium-review.googlesource.com/860321 Commit-Queue: Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#531052}
-
kylechar authored
ConnectWithInProcessFrameSinkManager() isn't used anymore. Bug: none Change-Id: Ie8177debbfae168be7297fa925a574b2298a523a Reviewed-on: https://chromium-review.googlesource.com/879487 Commit-Queue: kylechar <kylechar@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#531051}
-
Xianzhu Wang authored
Embedded frame invalidation/painting goes through PlatformChromeClient. - Invalidate PlatformChromeClient when any content in the embedded frame is invalidated; - Apply InnerBorderRadiusClip when painting embedded contents. Bug: 771643 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I1b2796a45f4e48f6912dddd820f33e18ec62e9f1 Reviewed-on: https://chromium-review.googlesource.com/879127 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#531050}
-
Xiaohan Wang authored
This new interface serves two purposes: 1. By holding this class, we can make sure the underlying CDM or CdmProxy are kept alive. This provides a unified way to support both CDM and CdmProxy. 2. This helps avoid the need to hold a reference to the CDM directly, further separating the media stack and the EME stack. After this change, we should be able to move content_decryption_module.h from media/base to media/cdm (in a later CL). This CL also adds CdmContextRefImpl, a default CdmContextRef impl that holds a reference to a media::ContentDecryptionModule. BUG=799310,786736,803710 TEST=No functionality change. All existing tests pass. Change-Id: I64bae76d5a5a0912728ebd8af7ea1ef57a638305 Reviewed-on: https://chromium-review.googlesource.com/876767 Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
John Rummell <jrummell@chromium.org> Cr-Commit-Position: refs/heads/master@{#531049}
-
yucliu authored
KEY_STATUS_MAX is the last key status, the total count should + 1. BUG=internal b/72168172 TEST=cast_cdm_widevine_test Change-Id: I6348e2ace9353655a3c31fc009d462a6ce6ebff1 Reviewed-on: https://chromium-review.googlesource.com/879561 Commit-Queue: Yuchen Liu <yucliu@chromium.org> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#531048}
-
Lei Zhang authored
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ia528746c57f22dec5476ca374699a4cdf0a5f93e Reviewed-on: https://chromium-review.googlesource.com/877516Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#531047}
-
Yafei Duan authored
Fixed a bug which would start a clearing of cached pages on Chrome startup that might have impact on startup related perf metrics. Bug: NONE Change-Id: Ide9143e381c9aa85c44729f1a12312ce710c5a85 Reviewed-on: https://chromium-review.googlesource.com/872112 Commit-Queue: Yafei Duan <romax@chromium.org> Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Cr-Commit-Position: refs/heads/master@{#531046}
-
Nate Chapin authored
This reverts commit 45582a71. Reason for revert: Reneable framebusting on trunk now that this is merged to M64 branch. Original change's description: > Disable framebusting intervention for M64. > > Bug: 624061 > Change-Id: I0b863938467b81dae3fbecd17b23aaf6faffe2a7 > Reviewed-on: https://chromium-review.googlesource.com/876508 > Reviewed-by: Ojan Vafai <ojan@chromium.org> > Reviewed-by: Nasko Oskov <nasko@chromium.org> > Commit-Queue: Nate Chapin <japhet@chromium.org> > Cr-Commit-Position: refs/heads/master@{#530608} TBR=nasko@chromium.org,ojan@chromium.org,japhet@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 624061 Change-Id: I0d3963d7746944cd37123f9d4d8b88549c12e6c1 Reviewed-on: https://chromium-review.googlesource.com/878924Reviewed-by:
Nate Chapin <japhet@chromium.org> Commit-Queue: Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#531045}
-
Daniel Park authored
Dynamically sets clip bounds while animating Bug: 769810 Change-Id: Iabde490af4d134aeee7d0a0c10bf13bbf98f70cc Reviewed-on: https://chromium-review.googlesource.com/871412Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Daniel Park <danielpark@chromium.org> Cr-Commit-Position: refs/heads/master@{#531044}
-
Jeremy Roman authored
This and subsequent tests necessitate some slightly complex logic for ensuring that the resposne callback is invoked appropriately. Rather than reinvent an ad-hoc mocking framework, make reasonable use of the one already in use in other content_junit_tests. Bug: 794320 Change-Id: I4f39f5c3ca531b6c802da49e0bb2067d0b6e3045 Reviewed-on: https://chromium-review.googlesource.com/879342Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#531043}
-
Cathy Li authored
Bug: 796247 Change-Id: I5614ab12b396f86f6c385d80ecc72c8f59fc0778 Reviewed-on: https://chromium-review.googlesource.com/834450Reviewed-by:
Peter Williamson <petewil@chromium.org> Commit-Queue: Cathy Li <chili@chromium.org> Cr-Commit-Position: refs/heads/master@{#531042}
-
webrtc-autoroll@chromium.org authored
https://webrtc.googlesource.com/src.git/+log/9c1848952ede..700ef33edcb5 $ git log 9c1848952..700ef33ed --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I5affe04ad7bf41797611934b0c09d5b0b9037df2 Reviewed-on: https://chromium-review.googlesource.com/879485Reviewed-by:
WebRTC Roll Bot <webrtc-autoroll@chromium.org> Commit-Queue: WebRTC Roll Bot <webrtc-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#531041}
-
Yafei Duan authored
Fixing request job unit tests. The test was using an empty file path which will make the pages deleted due to quota-based temporary page clearing. Also rearranged the order of model initialization to inject clock and set testing switches before tasks gets executed. Bug: NONE Change-Id: I639d6e90bbf29d23313c11ba54374edeba120da0 Reviewed-on: https://chromium-review.googlesource.com/877045Reviewed-by:
Jian Li <jianli@chromium.org> Commit-Queue: Yafei Duan <romax@chromium.org> Cr-Commit-Position: refs/heads/master@{#531040}
-
Daniel Bratell authored
Jumbo build experiments noticed that no code ever read engine_ in XmppIqEntry in libjingle_xmpp. Normal build didn't because "friend class XmppEngineImpl" required the compiler to know what XmppEngineImpl does as well. Bug: 777434 Change-Id: I661a5346617a92ee912060bebf35801dbe1a8797 Reviewed-on: https://chromium-review.googlesource.com/873371Reviewed-by:
Tommi <tommi@chromium.org> Commit-Queue: Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/master@{#531039}
-
Jun Choi authored
Change |input_data| parameter of CBORReader::Read() from const std::vector<uint8_t>& to base::span<uint8_t const> to prevent unnecessary intermediate copies. Bug: 803605 Change-Id: Id96df6a9c806bb39549f5696f73853faf71c3a94 Reviewed-on: https://chromium-review.googlesource.com/875006Reviewed-by:
Kim Paulhamus <kpaulhamus@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Commit-Queue: Jun Choi <hongjunchoi@chromium.org> Cr-Commit-Position: refs/heads/master@{#531038}
-
Luum Habtemariam authored
Now correctly sanitizing effective-make-and-models at all ppd_provider entrypoints. BUG=chromium:804014 TEST=checked manually that fixed worked; updated unitests to follow Change-Id: Ib437dadb3d669f670a0d2142445ac49644c5705d Reviewed-on: https://chromium-review.googlesource.com/877323Reviewed-by:
Sean Kau <skau@chromium.org> Commit-Queue: Luum Habtemariam <luum@chromium.org> Cr-Commit-Position: refs/heads/master@{#531037}
-
Scott Violet authored
Currently a handful of low level places depend upon //services/ui. This was done at a time when the only way to launch a service was via the service. Now that services may be packaged in other ways (such as baked into a binary), these dependencies on the service may result in unnecessarily building the target. This patch pushes the dependencies into the actual exe targets as they are the best place to make this decision as to whether the ui service is needed. BUG=783326 TEST=none, build only changes Change-Id: I40f5773400b9d22a694b56f66e92b8965e9cc3e9 Reviewed-on: https://chromium-review.googlesource.com/879108Reviewed-by:
Michael Wasserman <msw@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#531036}
-
Trent Apted authored
Bug: 637098 Change-Id: I18ddab35db1ff3155b847576880de4df4e1290ba Reviewed-on: https://chromium-review.googlesource.com/875522Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#531035}
-
Rob Dodson authored
If a <progress> element has its appearance removed with -webkit-appearance:none, it should still retain its role for accessibility. This CL also adds a test to check that various other control types are not affected by this issue. R=aboxhall@chromium.org Bug: 687828 Change-Id: I1a30e581dd109b34cae69ec9737cb233ceb5f1fb Reviewed-on: https://chromium-review.googlesource.com/861054Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Rob Dodson <robdodson@chromium.org> Cr-Commit-Position: refs/heads/master@{#531034}
-
Jinsuk Kim authored
One of the consequence of https://crrev.com/c/867177 is that you can't get ImeAdapter any longer with WebContents from CVC once |CVC.destroy()| is called. #onCreateInputConnection can occur afterwards, which needs to be treated as handled with the default action returning null. This helps the failing test pass again. The test is for tablet only, therefore evaded the trybot step. Bug: 803995 Change-Id: Ia4de2199737aba7ec49d820fc5237a20f96690e7 Reviewed-on: https://chromium-review.googlesource.com/878079 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
-
Eric Karl authored
We were incorrectly purging unlocked discardable to "make room" in the cache, although unlocked entries don't take up room. This resulted in non-optimal cache purging when we hit at-raster scenarios. Now that all cached items are discardable, this change removes all purging other than that needed to handle our max items in cache limit. Bug: 802819, 804328 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: I5cece605bbd40283073c075e78b36867c8c7efbf Reviewed-on: https://chromium-review.googlesource.com/879064 Commit-Queue: Eric Karl <ericrk@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#531032}
-
Jacob Dufault authored
Bug: 803727 Change-Id: I2fc28069cd33106b3c9019b402e9f549d956e54c Reviewed-on: https://chromium-review.googlesource.com/879466Reviewed-by:
-
Evan Stade authored
These were removed from the build in 7426194d but accidentally left in the tree. TBR=peter@chromium.org Bug: 755413 Change-Id: Iba88cc7091f897c00a9d2b2173482f2fbaf86317 Reviewed-on: https://chromium-review.googlesource.com/878909Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#531030}
-
Tommy C. Li authored
In preparation for eliding parts of the displayed URL in the steady state Omnibox, we are going to introduce a GetURLForDisplay method. To keep things clear, we're renaming the old method from GetFormattedURL to GetFormattedFullURL to clarify that this old method (generally) yields a string with the equivalent meaning to the input URL. This is in contrast to the new GetURLForDisplay method which may perform destructive (meaning-changing) elisions. Bug: 797354 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I8dbcffe47dd4252b6f1dd589e58583f851965d55 TBR=rohitrao@chromium.org Change-Id: I8dbcffe47dd4252b6f1dd589e58583f851965d55 Reviewed-on: https://chromium-review.googlesource.com/876646 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by:
-
Siddhartha authored
The native functions invoked are sometimes not run as a task which is registered with TaskAnnotator. Add events on generated jni functions to be able to trace them. Causes 80KB regression on the binary size, so use for temporary debugging in Dev channel and revert CL. BUG=801260 Change-Id: I80931fc07d74ed27edebe3cf35bce689f8138099 Reviewed-on: https://chromium-review.googlesource.com/853081 Commit-Queue: Siddhartha S <ssid@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#531028}
-
Dmitry Gozman authored
This patch moves message handling logic to DevToolsSession, removes duplicated logic from several DevToolsAgentHost implementations and hides multiple public methods exposed by the session. Bug: 776009 Change-Id: Id38a2bc2fa24591c04d9f1b0400fa522dd54d329 Reviewed-on: https://chromium-review.googlesource.com/875141Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#531027}
-
Dave Schuyler authored
These files appear to be disconnected and unused. I contacted the original author (rlp@) for their thoughts. If they recall correctly this feature was removed. It sounds like these are just orphans. (code health) Bug: None Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ib632f0e92f0bb6eeb40cacb42fbb2bd655c76bf2 Reviewed-on: https://chromium-review.googlesource.com/877514Reviewed-by:
-
Joy Ming authored
Before this change, the behavior between the having the flag (#enable-downloads-foreground) enabled or not was different. With the flag enabled, swiping away a paused download notification cancels it and without the flag enabled, swiping away did not cancel. This change makes the behavior consistent in that swiping away a paused download does not cancel the download, rather, allows the user to go through downloads home to cancel it themselves. Bug: 803999 Change-Id: I1bd413575629885f7caeda11c0a5eff59f6c7375 Reviewed-on: https://chromium-review.googlesource.com/877187Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Joy Ming <jming@chromium.org> Cr-Commit-Position: refs/heads/master@{#531025}
-
Wei-Yin Chen (陳威尹) authored
Bug: None Change-Id: I6e4717ab767dfc7b9f65e2621faf14237c65ab54 Reviewed-on: https://chromium-review.googlesource.com/879400Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#531024}
-
Wei-Yin Chen (陳威尹) authored
Bug: None Change-Id: I8e007ad264c7cc0f20b7e0a6a2b7e3c266d54e25 Reviewed-on: https://chromium-review.googlesource.com/879393Reviewed-by:
-
Nate Chapin authored
Bug: 624061 Test: http/tests/security/frameNavigation/xss-ALLOWED-same-origin-top-navigation-without-user-gesture.html Change-Id: I78909ab0726b85881225de413302886479761a8f Reviewed-on: https://chromium-review.googlesource.com/877407 Commit-Queue: Nate Chapin <japhet@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#531022}
-
