GitLab

If windows isn't using overlays then it's more efficient to use a
B8G8R8A8 swapchain instead of YUY2, as then windows won't have to do its
own colorspace conversion.

BUG=678800
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2809473003
Cr-Commit-Position: refs/heads/master@{#464272}

Adds --apk-file flag to archive action. When passed, section sizes are
taken from the .so within the .apk rather than from the one in
lib.unstripped.

Also removes "symbols" from console.py, which was missed in
previous rename commit. The reason to not expose this top-level
is that it in the future, we don't want to also expose java_symbols,
pak_symbols, etc.

BUG=681694

Review-Url: https://codereview.chromium.org/2807343005
Cr-Commit-Position: refs/heads/master@{#464271}

Bad android implementation can sometimes throw exceptions. Just swallow
it and pretend MediaCodecList is not supported.

BUG=695248, 709631

Review-Url: https://codereview.chromium.org/2817663004
Cr-Commit-Position: refs/heads/master@{#464270}

dependence on Tab.

BUG=Sad Tab works as expected

Review-Url: https://codereview.chromium.org/2807843002
Cr-Commit-Position: refs/heads/master@{#464269}

Cr-Commit-Position: refs/heads/master@{#464268}

The OverscrollActionController adds a UIPanGestureRecognizer.
When text is selected and SelectionSpeak is enabled, the
UIPanGestureRecognizer's end state is not always communicated to the
OverscrollActionController.

This CL calls the OverscrollActionController whenever the
UIPanGestureRecognizer is reset.

patchset from jif@chromium.org

TEST=Enable SelectionSpeak. Visit a page. Select text. In a single gesture, scroll a
little bit up and down. Once you lift your finger from the screen, the browser
should not be frozen, i.e. you should be able to scroll the page.
BUG=699655

patch from issue 2787723003 at patchset 40001 (http://crrev.com/2787723003#ps40001)

Review-Url: https://codereview.chromium.org/2817483002
Cr-Commit-Position: refs/heads/master@{#464267}

elide HTML lang and Content-Language.

The histogram actually tracks the so-called "server language" (i.e. the
HTML lang attribute if it exists, otherwise the header Content-Language
value) of loaded pages, not their Content-Language. The histogram
description now accurately reports this.

Review-Url: https://codereview.chromium.org/2785573002
Cr-Commit-Position: refs/heads/master@{#464266}

https://docs.google.com/document/d/1Q0kuHgU1d-sj8gePjEU9nHtlQzz5rNvvGH8fCJ3iBq4/edit?usp=sharing

Devtools side, add a new UI domain and methods:
method: getWindowForTarget, param: targetID, return: windowID, bounds.
method: setWindowBounds, param: windowID, bounds
method: getWindowBounds, param: windowID, return: bounds

bounds object: left, top, width, height, window_state (minimized, maximized, fullscreen, normal)

BUG=604324

Review-Url: https://codereview.chromium.org/2813553005
Cr-Commit-Position: refs/heads/master@{#464265}

The flake was likely a result of this change:
https://codereview.chromium.org/2776973004/diff/80001/ui/compositor/layer_unittest.cc

That change is now reverted in https://codereview.chromium.org/2815073002/
Restoring the test.

BUG=709080
TBR=ellyjones@chromium.org

Review-Url: https://codereview.chromium.org/2812403002
Cr-Commit-Position: refs/heads/master@{#464264}

The comment says its safe to remove at the end of 2011.

BUG=98458

Review-Url: https://codereview.chromium.org/2815923004
Cr-Commit-Position: refs/heads/master@{#464263}

BUG=671420

Review-Url: https://codereview.chromium.org/2786173003
Cr-Commit-Position: refs/heads/master@{#464262}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/e9a711fa..a478c171

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2814233003
Cr-Commit-Position: refs/heads/master@{#464261}

Review-Url: https://codereview.chromium.org/2812223002
Cr-Commit-Position: refs/heads/master@{#464260}

As specified in the latest specs.

BUG=706384

Review-Url: https://codereview.chromium.org/2810333003
Cr-Commit-Position: refs/heads/master@{#464259}

This CL:
* Adds some additional bluetooth event logging (USER events).
* Fixes the toggle logic so as not to set powered=false before the
  adapter state is received or when the toggle state matches the
  adapter state.
* Disables the toggle until the adapter state changes (not normally
  observable, but can prevent rapid toggling artifacts).
* Modifies BluetoothEventRouter to stop discovery when all WebUI tabs
  (or all tabs/windows associated with an extension) are closed.

BUG=703694,703698
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2801403002
Cr-Commit-Position: refs/heads/master@{#464258}

BUG=710855

Review-Url: https://codereview.chromium.org/2814083002
Cr-Commit-Position: refs/heads/master@{#464257}

Review-Url: https://codereview.chromium.org/2803413002
Cr-Commit-Position: refs/heads/master@{#464256}

Previously, InterceptablePrefFilter reset |filter_on_load_interceptor_|
after calling it. However, the callback could result in the object being
deleted, resulting in the callback being freed before Reset() is called.

This CL fixes this by using ResetAndReturn to move the callback into a
temporary before calling it.

Bug: 710655
Change-Id: I841c4157d54e0a31364237f4495384de6664e535
Reviewed-on: https://chromium-review.googlesource.com/476390Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Commit-Queue: Sam McNally <sammc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#464255}

* Rename an internal-only overload of a web exposed method.
* Fix method/identifier names that appear in comments.
* Fix mocked method arguments.
* Follow style guide for function argument comments.

Review-Url: https://codereview.chromium.org/2814253002
Cr-Commit-Position: refs/heads/master@{#464254}

The fix for Issue 672895 made these video rendering and upload paths
fragile if the video's metadata caused the natural size to differ in
certain ways from the coded size. Make the code robust to this case by
reverting to CopyTextureCHROMIUM in most cases, and allocating the
texture to the correct sizes in others.

Tested with new WebGL conformance test to be incorporated in a
forthcoming roll: https://github.com/KhronosGroup/WebGL/pull/2359 .

BUG=701060
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2791813003
Cr-Original-Commit-Position: refs/heads/master@{#463925}
Committed: https://chromium.googlesource.com/chromium/src/+/0cc4c62a163318c06636916b7e2b2c6a56f16b74
Review-Url: https://codereview.chromium.org/2791813003
Cr-Commit-Position: refs/heads/master@{#464253}

The clang tool had a bug in how it processes variables named
fooBARsBaz into foo_ba_rs_baz rather than foo_bars_baz.  Examples
include URLs -> ur_ls and XHRs -> xh_rs.

No intended behavior change.

BUG=675877

Review-Url: https://codereview.chromium.org/2810073002
Cr-Commit-Position: refs/heads/master@{#464252}

To avoid unexpected shutdowns during migration, we should ensure that the
battery level is enough before starting migration.

The expected behavior is as follows:
1) When "Upgrade" button is pressed and battery is enough,
start migration immediately.
2) When "Upgrade" button is pressed and battery is low,
ask the user to charge the device on the UI, disable the "Upgrade" button,
and start migration once the battery level gets enough.
3) When resuming previous migration and battery is enouch,
start migration immediately.
4) When resuming previous migration and battery is low,
ask the user to charge the device on the UI, hide all action buttons,
and start migration once the battery gets enough.

BUG=706017
TEST=manually tested the described expected behaviors.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2818433002
Cr-Commit-Position: refs/heads/master@{#464251}

BUG=527631
TEST=covered by unittests. Also tested in the step described in the bug.

Review-Url: https://codereview.chromium.org/2811153002
Cr-Commit-Position: refs/heads/master@{#464250}

BUG=710207

Review-Url: https://codereview.chromium.org/2807063004
Cr-Commit-Position: refs/heads/master@{#464249}

This is the upstream portion of https://chromereviews.googleplex.com/583857013
After downstream portion is submitted, no one will be using these contants.

BUG=710069

Review-Url: https://codereview.chromium.org/2813023003
Cr-Commit-Position: refs/heads/master@{#464248}

Adds a simple test for the mediator and creates a placeholder test file for the coordinator.

BUG=682880

Review-Url: https://codereview.chromium.org/2812463002
Cr-Commit-Position: refs/heads/master@{#464247}

Conformance test is uploaded: https://github.com/KhronosGroup/WebGL/pull/2364

BUG=708730
TEST=conformance2/rendering/clearbuffer-sub-source.html
R=kbr@chromium.org,kainino@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2809873003
Cr-Commit-Position: refs/heads/master@{#464246}

BUG=

Review-Url: https://codereview.chromium.org/2816833002
Cr-Commit-Position: refs/heads/master@{#464245}

Remove the flaky label from testBrowsingPostEntryWithKeyboard since it
has not flaked over the past few days. Also adds a TODO to move the
test to forms_egtest.mm.

BUG=704618

Review-Url: https://codereview.chromium.org/2813363002
Cr-Commit-Position: refs/heads/master@{#464244}

Performs the computation on a background thread, so the UI is responsive
while a result from this API is pending.

BUG=710745

Review-Url: https://codereview.chromium.org/2813153002
Cr-Commit-Position: refs/heads/master@{#464243}

If a client requests to set window bounds directly, Ash should not
interfere, e.g. by constraining them to the workspace size.

ARC windows are maximized to the display rather than the workspace.
However, Ash would constrain the ShellSurface bounds to the workspace
size. As a result, if the shelf was positioned to the left, the right
edge of the window would be displaced from that of the display by the
width of the shelf, so the app was unresponsive to input in that gap.

BUG=709616
TEST=Print window hierarchy using debug shortcut, and verify that the
     bounds of a maximized ShellSurface match the display bounds.

Review-Url: https://codereview.chromium.org/2806783002
Cr-Commit-Position: refs/heads/master@{#464242}

https://chromium.googlesource.com/chromiumos/platform/system_api.git/+log/b78cb488..19115ef1

$ git log b78cb488..19115ef1 --date=short --no-merges --format='%ad %ae %s'
2017-04-10 xiyuan@google.com system-api: Add cryptohome NeedsDircryptoMigration name
2017-03-27 ejcaruso@chromium.org system_api: remove unused debugd D-Bus method name

BUG=706307
TEST=Manual.

Change-Id: I51afd2afc614a0bc5d754a48b3f1e6c6352fccf1
Reviewed-on: https://chromium-review.googlesource.com/476094Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Commit-Queue: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#464241}

BUG=704008
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2813193003
Cr-Commit-Position: refs/heads/master@{#464240}

BUG=638281

Review-Url: https://codereview.chromium.org/2811273004
Cr-Commit-Position: refs/heads/master@{#464239}

Revert of [Android][Telemetry] Disable failing key_mobile_sites benchmarks. (patchset #1 id:1 of https://codereview.chromium.org/2781713005/ )

Reason for revert:
The root cause should already be fixed.

Original issue's description:
> [Android][Telemetry] Disable failing key_mobile_sites benchmarks.
>
> BUG=702194
> TBR=nednguyen@google.com
>
> Review-Url: https://codereview.chromium.org/2781713005
> Cr-Commit-Position: refs/heads/master@{#460362}
> Committed: https://chromium.googlesource.com/chromium/src/+/908b7419b238a50d685634fa7844fd690830fa9c

TBR=rnephew@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=702194

Review-Url: https://codereview.chromium.org/2815003004
Cr-Commit-Position: refs/heads/master@{#464238}

BUG=711095
TEST=no test, just resource addition.

Review-Url: https://codereview.chromium.org/2815773005
Cr-Commit-Position: refs/heads/master@{#464237}

This is basically https://codereview.chromium.org/2692093003 with the changes to
make DocumentMarkerController use SynchronousMutationObserver split off into a
separate CL (https://codereview.chromium.org/2755953004).

I need DocumentMarkerController to update markers more gracefully in response to
edits in order to implement SuggestionSpan support on Android. For example, if
we have the string "word1 word2" marked with a DocumentMarker and
CompositeEditCommand::replaceTextInNode() is used to replace word1 or word2 with
different text, the new text should still be inside the marked range.

There's currently a method
CompositeEditCommand::replaceTextInNodePreservingMarkers(), which was added to
fix some particular case to support a marker type which no longer exists
(DeletedAutocorrection): https://bugs.webkit.org/show_bug.cgi?id=60555

This is no longer necessary after this CL since we can handle all the updates
more correctly inside DocumentMarkerController. For example, if we have a string
like "Initial text blah" and we add a marker around " text " and delete
"Initial" and "blah", we end up with " text ". Then
DeleteSelectionCommand::fixupWhitespace() runs, and replaces the spaces with
non-breaking spaces. The current behavior is that the NBSPs are no longer in the
marked range, since DocumentMarkerController doesn't currently support keeping
the replaced text in the marked range, but replaceTextInNodePreservingMarkers()
runs and adds new markers to the NBSPs. So we still end up with " text " being
marked but now we have three separate markers, which is undesirable for some
use cases (e.g. text suggestions, because we don't know what range of text we're
actually supposed to replace now). With the changes in this CL,
DocumentMarkerController is able to keep a single marker around " text ".

The changes to the expected output for InputMethodControllerTest may be helpful
in understanding the behavioral changes here.

BUG=672259

Review-Url: https://codereview.chromium.org/2755013004
Cr-Commit-Position: refs/heads/master@{#464236}

BUG=691703
TEST=chrome
R=piman@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2812003006
Cr-Commit-Position: refs/heads/master@{#464235}

BUG=710607

Review-Url: https://codereview.chromium.org/2815913003
Cr-Commit-Position: refs/heads/master@{#464234}

We currently aren't processing the normal vsync/BeginFrame events
during WebVR presentation, this means that only vrDisplay.rAF
callbacks get executed, not window.rAF callbacks. This breaks
applications that depend on window.rAF for background processing,
so we should continue executing those callbacks too.

This patch does not enable requestIdleCallback handling, that is
significantly more complex and we're looking into that separately.

BUG=704341

Review-Url: https://codereview.chromium.org/2812253004
Cr-Commit-Position: refs/heads/master@{#464233}