GitLab

Add OnSuggestionInvalidated methods to the ContentSuggestionsProvider,
the ContentSuggestionsService and its observer and to the SnippetsBridge.

Remove suggestions from the UI immediately when they're invalidated.

Invalidate offline page suggestions when the referenced offline page is
deleted, and also clear it from the dismissed_ids list.

Add new unit tests for the UI layer and the service layer.

BUG=628198

Review-Url: https://codereview.chromium.org/2244793002
Cr-Commit-Position: refs/heads/master@{#412813}

We should ignore pointer events on disabled buttons.
It prevents unexpected command dispatches, and it is consistent with paper-button.

BUG=632270
TEST=manually

Review-Url: https://codereview.chromium.org/2256143002
Cr-Commit-Position: refs/heads/master@{#412812}

https://chromium.googlesource.com/skia.git/+log/36e5adbaaac9..2a43fe2723cb

$ git log 36e5adbaa..2a43fe272 --date=short --no-merges --format='%ad %ae %s'
2016-08-18 anmittal Add executable bit and shebang to python files

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
TBR=robertphillips@google.com

Review-Url: https://codereview.chromium.org/2258843002
Cr-Commit-Position: refs/heads/master@{#412811}

BUG=588956

Review-Url: https://codereview.chromium.org/2257043002
Cr-Commit-Position: refs/heads/master@{#412810}

The relaxation that landed in https://codereview.chromium.org/2002943002
was a bit too relaxed, and leaks navigation targets cross-origin for
'frame-src' and 'object-src' violations.

This patch reverts to the old behavior for those two directives.

BUG=633306

Review-Url: https://codereview.chromium.org/2255103002
Cr-Commit-Position: refs/heads/master@{#412809}

Original CL description (from https://codereview.chromium.org/2199393002/):

Android: Make the spare renderer accessible to all Chrome tabs.

In Custom Tabs, an external application can "warm up" Chrome. This
creates and initializes a spare renderer, and has been found to be a
significant optimization for loading performance.

This patch moves the spare renderer logic out of Custom Tabs, and makes
it accessible and useful for regular navigations in Chrome. Note that
this patch doesn't add new call sites for the spare renderer creation.

TBR=yusufo,maria # trivial fix to a test.
BUG=633964

Review-Url: https://codereview.chromium.org/2254063003
Cr-Commit-Position: refs/heads/master@{#412808}

In RenderFrameImpl::OnFailedNavigation, when loading an unreachable
URL, the condition : ShouldDisplayErrorPageForFailedLoad(..) return true the
first time. But the auto_reload feature ask for navigating again some time
later multiple times. These times, ShouldDisplayErrorPageForFailedLoad(..)
returns false because auto_reload_in_flight_ is true and we don't want to
display the error page again.

Thus, putting here the Macro NOTREACHED() causes crashs for every
failed navigation.

I restored the behavior found in RenderFrameImpl::DidFailProvisionalLoad, which
is the non-PlzNavigate counterpart of this function and stop the navigation.

TEST=Try to navigate to an unexisting url  (unreachableurl.com for instance)
and see if it crashs. Use --enable-browser-side-navigation.
R=clamy@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2248013003
Cr-Commit-Position: refs/heads/master@{#412807}

This test uses testharness.js to test whether image
load event is fired even if the image is the last one we
loaded successfully.

BUG=637859.

Review-Url: https://codereview.chromium.org/2251413002
Cr-Commit-Position: refs/heads/master@{#412806}

SpdyDeframerVisitor reconstructs SpdyFrameIR instances from callbacks to
SpdyFramerVisitorInterface.

This CL lands server changes 122860864, 122867216, 126441874, and 126727481
by jamessynge.

BUG=488484

Review-Url: https://codereview.chromium.org/2248343004
Cr-Commit-Position: refs/heads/master@{#412805}

Changes: https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git/+log/933964d..434afe6

$ git log 933964d..434afe6 --date=short --no-merges --format=%ad %ae %s
2016-08-18 sakal@webrtc.org GN: Add Android support to video_engine_tests.
2016-08-17 honghaiz@webrtc.org Do not switch to a high-cost connection that is not receiving.
2016-08-17 tkchin@webrtc.org Nil out EAGLContext explicitly on RTCEAGLVideoView dealloc.
2016-08-17 glaznev@google.com Disable Intel VP8 HW encoder.
2016-08-17 noahric@chromium.org Add code for dummy file audio to fallback to dummy audio.
2016-08-17 glaznev@google.com Avoid null pointer exception if Android getCameraInfo fails.
2016-08-17 noahric@chromium.org Close input file in FileAudioDevice::StopRecording.
2016-08-17 magjed@webrtc.org Expose media constraint string constants as ObjC NSStrings
2016-08-17 kwiberg@webrtc.org FilePlayer: Remove unused default values for arguments
2016-08-17 henrika@webrtc.org Removes redundant log warning in WebRtcAudioManager.
2016-08-17 danilchap@webrtc.org Revert of StartTimestamp generated randomly in RtpSender constructor (patchset #4 id:60001 of https://codereview.webrtc.org/2241193002/ )
2016-08-17 kwiberg@webrtc.org FileRecorder + FilePlayer: Let Create functions return unique_ptr

TBR=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng
BUG=

Review-Url: https://codereview.chromium.org/2258783002
Cr-Commit-Position: refs/heads/master@{#412804}

SyncSetupWebUITestAsync.RestoreSyncDataTypes
SearchEngineManagerWebUITest.testOpenSearchEngineManager

TBR=dbeam@chromium.org
BUG=638884

Review-Url: https://codereview.chromium.org/2247033007
Cr-Commit-Position: refs/heads/master@{#412803}

This is a follow-up on crrev.com/2244083002 to clean-up
spelling_service_client.cc in the old location because it
has been moved to components/spellcheck/browser/

BUG=583616, 629609
TBR=rouslan@chromium.org

Review-Url: https://codereview.chromium.org/2260463002
Cr-Commit-Position: refs/heads/master@{#412802}

This patch takes care of TODO to replace
eventsender with document.ElementFromPoint.

BUG=637859

Review-Url: https://codereview.chromium.org/2244333004
Cr-Commit-Position: refs/heads/master@{#412801}

https://chromium.googlesource.com/chromium/src/+/197723886

BUG=632274
TBR=guidou@chromium.org

Review URL: https://codereview.chromium.org/2257493005 .

Cr-Commit-Position: refs/heads/master@{#412800}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/abe40ccd..34775e7b

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2257773002
Cr-Commit-Position: refs/heads/master@{#412799}

When resetting the timeline to t=0, we may up generating syncbase
notification, which sets up a timer (to update any possibly dependent
intervals.) Since resetAnimation() is what's called when the (SVG)Image
no longer has any clients, we should try to make sure it is indeed
idle after that happens. This avoids trying to update animation state
while the image is otherwise dead, leaving "reactivation" to the time
it is next painted.

BUG=627418

Review-Url: https://codereview.chromium.org/2247783003
Cr-Commit-Position: refs/heads/master@{#412798}

In the long run, it should probably be removed.

BUG=638713

Review-Url: https://codereview.chromium.org/2252173002
Cr-Commit-Position: refs/heads/master@{#412797}

https://chromium.googlesource.com/chromium/src/+/524ac838e

BUG=632274
TBR=rjwright@chromium.org

Review URL: https://codereview.chromium.org/2254133003 .

Cr-Commit-Position: refs/heads/master@{#412796}

https://chromium.googlesource.com/chromium/src/+/bb6578fd9

BUG=510908
TBR=wangxianzhu@chromium.org

Review URL: https://codereview.chromium.org/2245063007 .

Cr-Commit-Position: refs/heads/master@{#412795}

This patch converts "editing/deleting/delete-block-merge-contents-0{18,19,20,21}.html" to
use w3c test harness to simplify test script for improving readability, and
consolidates into "delete_block_merge_end_of_line.html" since samples of them
are similar.

BUG=n/a
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2254933003
Cr-Commit-Position: refs/heads/master@{#412794}

TBR=schenney@chromium.org
BUG=638850

Review-Url: https://codereview.chromium.org/2255813003
Cr-Commit-Position: refs/heads/master@{#412793}

PasswordFormManagerState has 3 states: pre-matching, matching and post-matching
phase. After https://codereview.chromium.org/2256703002, none of its public
methods can be called during the pre-matching phase.

Therefore only the matching and post-matching phase values are needed. This CL:
* Removes the "pre-matching phase" value
* Renames the remaining values to better describe what they mean
* Removes duplicity from the enum name, makes it an enum class and fixes its
  position in the class declaration

R=dvadym@chromium.org
BUG=621355

Review-Url: https://codereview.chromium.org/2250133003
Cr-Commit-Position: refs/heads/master@{#412792}

This CL:
- Lets WebView ask a content provider (the name of which is set by a
WebView policy) whether a URL should be accessible.
- Implements an error page when a URL is not accessible, that, if it
is supported by the content provider, lets the user request access
- Makes some fixes to the supervised user content provider so that
this works with WebView.

BUG=604330

Review-Url: https://codereview.chromium.org/1890203002
Cr-Commit-Position: refs/heads/master@{#412791}

r409635 added some new tests that need the same fix introduced in
r410945 in response to r409132.

BUG=633490
TBR=calamity@chromium.org

Review-Url: https://codereview.chromium.org/2258753003
Cr-Commit-Position: refs/heads/master@{#412790}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/36345583..abe40ccd

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2248963006
Cr-Commit-Position: refs/heads/master@{#412789}

iOS10 does not trigger UIPasteboardChangedNotification notifications
on pasteboard change ( filed bug with Apple: rdr://27477065 ).
This CL is a workaround where we check if the pasteboard changed
when we attempt to display its content.

BUG=628592

Review-Url: https://codereview.chromium.org/2230983002
Cr-Commit-Position: refs/heads/master@{#412788}

BUG=575210

Review-Url: https://codereview.chromium.org/2251733002
Cr-Commit-Position: refs/heads/master@{#412787}

This patch converts "editing/delete-by-word-00[12].html" to use w3c test harness
and integrates into "delete_by_word.html", since both test cases are
very similar, to simplify test script for improving readability.

BUG=n/a
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2252153004
Cr-Commit-Position: refs/heads/master@{#412786}

Revert of Roll clang 277962:278861 (patchset #5 id:80001 of https://codereview.chromium.org/2241413003/ )

Reason for revert:
This is suspect of breaking Mac 10.9 builder.

See
https://build.chromium.org/p/chromium.mac/builders/Mac10.9%20Tests%20%28dbg%29/builds/28850

Sample logs:
Retrying 1 test (retry #1)
[0817/224954:ERROR:kill_posix.cc(84)] Unable to terminate process group 8687: No such process
[ RUN      ] ThreadTest.StartWithOptions_StackSize
[2060/2060] ThreadTest.StartWithOptions_StackSize (CRASHED)
Retrying 1 test (retry #2)
[0817/224955:ERROR:kill_posix.cc(84)] Unable to terminate process group 8688: No such process
[ RUN      ] ThreadTest.StartWithOptions_StackSize
[2061/2061] ThreadTest.StartWithOptions_StackSize (CRASHED)
Retrying 1 test (retry #3)
[0817/224955:ERROR:kill_posix.cc(84)] Unable to terminate process group 8689: No such process
[ RUN      ] ThreadTest.StartWithOptions_StackSize
[2062/2062] ThreadTest.StartWithOptions_StackSize (CRASHED)
1 test crashed:
    ThreadTest.StartWithOptions_StackSize (../../base/threading/thread_unittest.cc:135)
Tests took 21 seconds.
Additional test environment:
    CHROME_DEVEL_SANDBOX=/opt/chromium/chrome_sandbox
    LANG=en_US.UTF-8
Command: ./base_unittests --brave-new-test-launcher --test-launcher-bot-mode --test-launcher-summary-output=/b/swarm_slave/w/ionk6XHB/output.json

Original issue's description:
> Roll clang 277962:278861
>
> BUG=636558,637866
>
> Committed: https://crrev.com/29ecb32ba7b5ca183782c5f5d2b7a1ae23309edb
> Cr-Commit-Position: refs/heads/master@{#412745}

TBR=rnk@chromium.org,dcheng@chromium.org,dpranke@chromium.org,inferno@chromium.org,hans@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=636558,637866

Review-Url: https://codereview.chromium.org/2249163007
Cr-Commit-Position: refs/heads/master@{#412785}

BUG=612908

Review-Url: https://codereview.chromium.org/2253043002
Cr-Commit-Position: refs/heads/master@{#412784}

BUG=580068
R=tyoshino

Review-Url: https://codereview.chromium.org/2257053002
Cr-Commit-Position: refs/heads/master@{#412783}

This fallback is active when we have less bookmarks with last visit info than specified by Finch (defaults to 3). This is relevant for existing users after they update to m54.

In this fallback mode, we
 - use creation date instead of (missing) last visit date and
 - do not impose age limit on bookmarks to show

BUG=638538

Review-Url: https://codereview.chromium.org/2256643002
Cr-Commit-Position: refs/heads/master@{#412782}

This patch converts "editing/deleting/delete-at-paragraph-boundaries-00[1-5].html" to
use w3c test harness to simplify test script for improving readability, and
consolidates into "delete_at_paragraph_boundaries.html" since samples of them
are similar.

BUG=n/a
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2255063002
Cr-Commit-Position: refs/heads/master@{#412781}

There are situations where getSelectedList_ returns nothing and unselectAllItems
triggered by polymer fails if nothing is selected.Page shifted downwards since
polymer can't generate custom style for history-sidebar after the failure.

BUG=637196
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2248223003
Cr-Commit-Position: refs/heads/master@{#412780}

As detailed in the bug, Signed Certificate Timestamps (SCTs) can be marked as invalid for two reasons. This change splits the invalid SCT status into two:
* Invalid timestamp.
* Invalid signature.

Since right now we'd only like to collect data on whether invalidity is due to an ecosystem problem (invalid signatures) or misconfigured clients (invalid timestamp), the change only affects the metrics we collect.
All other consumers of the SCT verification status have been adjusted to treat both statuses the same.

Per rsleevi's recommendation, the SCTVerifyStatus enum has been expanded and the value for the old invalid status is no longer used.

BUG=634006

Review-Url: https://codereview.chromium.org/2241213002
Cr-Commit-Position: refs/heads/master@{#412779}

Add missing support to GN files.
Properly set nonsfi and glibc dependencies.

BUG=GN gen failure
TEST=Run GN gen with: target_cpu="mipsel" mips_arch_variant="r2" enable_nacl=true

Review-Url: https://codereview.chromium.org/2242893002
Cr-Commit-Position: refs/heads/master@{#412778}

BUG=638189

Review-Url: https://codereview.chromium.org/2244123004
Cr-Commit-Position: refs/heads/master@{#412777}

The failure seems to occurs on Win10 only, but these tests already had entries and it was not possible to add a new Win10-specific entry.

TBR=ericrk@chromium.org
BUG=638843

Review-Url: https://codereview.chromium.org/2242173007
Cr-Commit-Position: refs/heads/master@{#412776}

Revert of Fix ineffective --disable-gpu-driver-bug-workarounds (patchset #11 id:200001 of https://codereview.chromium.org/2195743005/ )

Reason for revert:
Cause failures on Nexus 9 GPU bot https://build.chromium.org/p/chromium.gpu.fyi/builders/Android%20Release%20%28Nexus%209%29/builds/1385

Original issue's description:
> Fix ineffective --disable-gpu-driver-bug-workarounds
>
> It was hidden to the user since chrome://gpu was not showing
> any workarounds, but they were still applied in the gpu process.
>
> Also add a gpu test that sets
> --disable-gpu-driver-bug-workarounds --use_gpu_driver_workaround_for_testing
> and verifies that the only active workaround is USE_TESTING_GPU_DRIVER_WORKAROUND
> in both browser and gpu processes.
>
> BUG=359367
>
> R=kbr@chromium.org, zmo@chromium.org
>
> TEST=./content/test/gpu/run_gpu_test.py gpu_process --show-stdout --browser=exact --extra-browser-args="--no-sandbox" --browser-executable=./out/build/chrome
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
>
> Committed: https://crrev.com/d18006d595e7b6bf070f9ab9777d353ac8457755
> Committed: https://crrev.com/7eee382917c50ad10a487ef1c1402adc8c84e9fd
> Cr-Original-Commit-Position: refs/heads/master@{#409197}
> Cr-Commit-Position: refs/heads/master@{#412685}

TBR=kbr@chromium.org,zmo@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=359367

Review-Url: https://codereview.chromium.org/2253413002
Cr-Commit-Position: refs/heads/master@{#412775}

BUG=633185,633229

Review-Url: https://codereview.chromium.org/2253073002
Cr-Commit-Position: refs/heads/master@{#412774}