GitLab

Notable changes:
 * CRWWebViewProxyImpl now uses synthesized getter and ivar for
property contentView
 * CRWJSPOSTRequestLoader now does not create a retain cycle of
CRWWKScriptMessageRouter objects. The cycle seems to have been harmless,
but it definitely brings no value, and it's better to not have it.

BUG=651830

Review-Url: https://codereview.chromium.org/2380323002
Cr-Commit-Position: refs/heads/master@{#422776}

Before this CL, any task posted to a SequencedWorkerPool redirected to
TaskScheduler after
SequencedWorkerPool::Shutdown(int max_new_blocking_tasks_after_shutdown)
returned was ignored.

With this CL, |max_new_blocking_tasks_after_shutdown| BLOCK_SHUTDOWN
tasks are allowed to be posted after SequencedWorkerPool::Shutdown
returns.

BUG=622400

Review-Url: https://codereview.chromium.org/2389923004
Cr-Commit-Position: refs/heads/master@{#422775}

The constructor parameters can be provided directly, and after doing so it
fits on one (80-column) line.

Review-Url: https://codereview.chromium.org/2389013003
Cr-Commit-Position: refs/heads/master@{#422774}

https://chromium.googlesource.com/skia.git/+log/2ebd0c80a2a9..ee843b2ae4d7

$ git log 2ebd0c80a..ee843b2ae --date=short --no-merges --format='%ad %ae %s'
2016-10-04 robertphillips Revert of Make GrResourceCache dynamically change between LRU and random replacement strategies. (patchset #8 id:140001 of https://codereview.chromium.org/2321563006/ )

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
TBR=stephana@google.com

Review-Url: https://codereview.chromium.org/2389163002
Cr-Commit-Position: refs/heads/master@{#422773}

Before this change, the only way to scan all keys was to call LoadEntries() which loads the whole database. In our use case, this means copying a lot of image data which is wasteful.
With LoadKeys(), we still need to iterate the whole database but we don't have to copy out (and parse) the values -- just the keys. LoadKeys() is useful when storing relatively large values and only access to the keys is required.

We'll use LoadKeys() for NTP content suggestions to garbage collect data. We do that at times when we have a list of all still alive elements and need to intersect that with the elements stored in the db.

BUG=649009

Review-Url: https://codereview.chromium.org/2379113002
Cr-Commit-Position: refs/heads/master@{#422772}

BUG=642994
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2387173002
Cr-Commit-Position: refs/heads/master@{#422771}

It is no longer compiled.

BUG=None

Review-Url: https://codereview.chromium.org/2392893002
Cr-Commit-Position: refs/heads/master@{#422770}

Creates FaviconAttributesProvider, FaviconAttributes and FaviconViewNew
classes to present favicons. These classes intend to replace FaviconView
and FaviconViewProvider downstream.

BUG=None

Review-Url: https://codereview.chromium.org/2361393004
Cr-Commit-Position: refs/heads/master@{#422769}

This is a follow-up CL to https://codereview.chromium.org/2363183002/.

Review-Url: https://codereview.chromium.org/2388813002
Cr-Commit-Position: refs/heads/master@{#422768}

Revert of Automatically copy the DIA DLL in the Syzygy binaries directory. (patchset #11 id:240001 of https://codereview.chromium.org/2365893002/ )

Reason for revert:
Break gclient for the open contributors.

Original issue's description:
> Automatically copy the DIA DLL in the Syzygy binaries directory.
>
> Committed: https://crrev.com/f34c072397b99c313e79cd10a77f5ca397154399
> Cr-Commit-Position: refs/heads/master@{#422655}

TBR=chrisha@chromium.org,siggi@chromium.org,scottmg@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review-Url: https://codereview.chromium.org/2390993002
Cr-Commit-Position: refs/heads/master@{#422767}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/6b7a634b..4e2b1f13

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2387383002
Cr-Commit-Position: refs/heads/master@{#422766}

The registered histograms on the native side are exposed
as JSON text from the FeedbackCollector. The histograms are
exposed only if:
(i)  "Include screenshot and logs" is checked when
the feedback was collected, and
(ii) The feedback is submitted from a non-incognito
profile.

In the next CL, these would be attached to the feedback
report.

BUG=651621

Review-Url: https://codereview.chromium.org/2378773010
Cr-Commit-Position: refs/heads/master@{#422765}

Otherwise, the overflow menu stays visible while the controls are hidden
which is fairly odd. Hiding the overflow menu would not be a good
experience either because the timer to hide is fairly short.

BUG=None
R=zqzhang@chromium.org

Review-Url: https://codereview.chromium.org/2386273003
Cr-Commit-Position: refs/heads/master@{#422764}

Revert of Refactor WebappRegistry into a singleton instance. (patchset #11 id:200001 of https://codereview.chromium.org/2351113005/ )

Reason for revert:
chrome_public_test_apk failed.

https://uberchromegw.corp.google.com/i/chromium.linux/builders/Android%20Tests%20%28dbg%29/builds/36476

Original issue's description:
> Refactor WebappRegistry into a singleton instance.
>
> This CL refactors WebappRegistry and WebappDataStorage to make most of
> the methods synchronous. WebappRegistry is now a singleton instance that
> is instantiated at browser startup. This allows all SharedPreferences files to
> be pre-warmed before the class is used; new web apps open new
> SharedPreferences on a background thread when registered, after which the
> preferences are cached automatically.
>
> Most static methods on WebappRegistry and WebappDataStorage have been
> converted to instance methods or removed. This makes the code much
> cleaner and more efficient; each static method had to independently open
> their SharedPreferences, which minimally performs a stat() on the
> underlying XML file to see if it has changed. Now the singleton
> WebappRegistry caches all WebappDataStorage objects on startup and
> whenever new ones are added. This reduces disk IO overhead.
>
> This CL allows all calls to SharedPreferences.Editor.apply() in
> WebappRegistry and WebappDataStorage to occur on the main thread,
> mostly removing the need for unwieldy callback interfaces and bare
> pointer passing across the JNI.
>
> BUG=633791
>
> Committed: https://crrev.com/78cf6596040662c0a73c0e4038bc84fb2b3c470a
> Cr-Commit-Position: refs/heads/master@{#422703}

TBR=dfalcantara@chromium.org,wnwen@chromium.org,msramek@chromium.org,dominickn@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=633791

Review-Url: https://codereview.chromium.org/2384413003
Cr-Commit-Position: refs/heads/master@{#422763}

BUG=388194,649710

Review-Url: https://codereview.chromium.org/2390553003
Cr-Commit-Position: refs/heads/master@{#422762}

In order to avoid re-entrancy issues, this CL modifies sensor event
dispatching code and uses postTask to schedule event dispatch.
New test is added to ambient-light-sensor.html that checks if generic
sensor code works correctly when sensor is not supported

BUG=606766

Review-Url: https://codereview.chromium.org/2381913002
Cr-Commit-Position: refs/heads/master@{#422761}

It is useless to launch a rename process directly from a system-level
Chrome. That process can't rename the Chrome executables since it isn't
elevated.

BUG=650981

Review-Url: https://codereview.chromium.org/2382493002
Cr-Commit-Position: refs/heads/master@{#422760}

Notable changes:none

BUG=651816
TEST=none

Review-Url: https://codereview.chromium.org/2375023006
Cr-Commit-Position: refs/heads/master@{#422759}

If-statement prevents a crash in a unittest that would occur if rolling
after the WebRTC change.

The WebRTC change: https://codereview.webrtc.org/2387343002/

BUG=chromium:627816

Review-Url: https://codereview.chromium.org/2390743003
Cr-Commit-Position: refs/heads/master@{#422758}

1. Update to match new signature of WebContentsCreated.

2. Allow IO in the newly added renderer command prefix test.

Review-Url: https://codereview.chromium.org/2394463002
Cr-Commit-Position: refs/heads/master@{#422757}

Revert of Prune createVisibleSelectionDeprecated from SelectionAdjuster (patchset #1 id:1 of https://codereview.chromium.org/2389653002/ )

Reason for revert:
Suspected of causing crbug.com/652301

Original issue's description:
> Prune createVisibleSelectionDeprecated from SelectionAdjuster
>
> BUG=651373
>
> Committed: https://crrev.com/1301c7b47926fa0d435c2f396a6aeba2a4d179c1
> Cr-Commit-Position: refs/heads/master@{#422380}

TBR=yosin@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=651373

Review-Url: https://codereview.chromium.org/2391973002
Cr-Commit-Position: refs/heads/master@{#422756}

BUG=563793

Review-Url: https://codereview.chromium.org/2391943003
Cr-Commit-Position: refs/heads/master@{#422755}

These benchmarks were failing for the same underlying reason as
smoothness.tough_webgl_ad_cases, which was fixed by
https://codereview.chromium.org/2373983005.

BUG=647413
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq

Review-Url: https://codereview.chromium.org/2386093002
Cr-Commit-Position: refs/heads/master@{#422754}

This changes the way the resource score is computed in the
resource_prefetch_predictor. It takes into account the request priority
as the most important feature, then resource type, then average position.

The rationale is that resource priority surfaces the render-blocking
resources, that are the most critical to prefetch.

BUG=631966

Review-Url: https://codereview.chromium.org/2385173002
Cr-Commit-Position: refs/heads/master@{#422753}

BUG=651431

Review-Url: https://codereview.chromium.org/2382233002
Cr-Commit-Position: refs/heads/master@{#422752}

This does not change the generated code at all.

BUG=460722

Review-Url: https://codereview.chromium.org/2380383003
Cr-Commit-Position: refs/heads/master@{#422751}

WebPermissionClient.h was removed in
crrev.com/9f21f26b

Removing some remnants

Review-Url: https://codereview.chromium.org/2387053002
Cr-Commit-Position: refs/heads/master@{#422750}

Notable changes:none

BUG=651816
TEST=none

Review-Url: https://codereview.chromium.org/2380933005
Cr-Commit-Position: refs/heads/master@{#422749}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/eb2b7fdc..6b7a634b

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2389833003
Cr-Commit-Position: refs/heads/master@{#422748}

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/fee67c6802805c049ddf19e436fb00ad8416032f Revert of Disable local fallback in goma staging environment (patchset #2 id:20001 of https://codereview.chromium.org/2392853002/ ) (tikuta@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG=

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2391733003
Cr-Commit-Position: refs/heads/master@{#422747}

Before this CL the http/tests/webaudio/autoplay-crossorigin.html layout
test would fail if the main frame and the cross-origin frame are in
different renderer processes.  After this CL, the internal settings are
set from the same frame that hosts AudioContext object - this ensures
that setting the settings and getting the settings happens from the same
renderer process (and consequently ensures that the test passes both
with and without --site-per-process flag).

BUG=652366

Review-Url: https://codereview.chromium.org/2389963002
Cr-Commit-Position: refs/heads/master@{#422746}

e2df1d70 adds a new parameter to
WebContentsDelegate::WebContentsCreated. This CL updates the
implementation in headless_web_contents_impl.cc accordingly.

BUG=649855
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2385123004
Cr-Commit-Position: refs/heads/master@{#422745}

A permission descriptor is a structure describing a permission that an
origin may request. Most permissions are only identified by their names
but some have additional parameters. For example, a Bluetooth device
permission may include the MAC address of the device (or other unique
identifier) so that the permission applies to only the device selected
by the user through some sort of chooser interface.

BUG=638721

Review-Url: https://codereview.chromium.org/2255933002
Cr-Commit-Position: refs/heads/master@{#422744}

It is uncommon to use command-line-switch-style for base::Feature
names. This CL fixes the feature name for kFlashJoinsMediaSession.

BUG=619084

Review-Url: https://codereview.chromium.org/2390633002
Cr-Commit-Position: refs/heads/master@{#422743}

This CL replaces createDoneDataConsumerHandle and
createUnexpecteErrorDataConsumerHandle with BytesConsumer::createDone
and BytesConsumer::createErrored respectively. This CL also makes
BodyStreamBuffer update its status synchronously at the construction
time.

This CL also removes a BodyStreamBuffer constructor that takes a
FetchDataConsumerHandle.

BUG=610195

Review-Url: https://codereview.chromium.org/2392823002
Cr-Commit-Position: refs/heads/master@{#422742}

9-16 bit video channel will use it.

BUG=445071, 624436
TEST=gl_tests --gtest_filter=GpuMemoryBufferTest*
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2376293003
Cr-Commit-Position: refs/heads/master@{#422741}

The counter was separated from the container in
https://codereview.chromium.org/588583002, in preparation for componentisation
which never happened. As jam@ points out in
https://codereview.chromium.org/2375333003/#msg9, it should be cleaned-up.

This is in effect a revert of https://codereview.chromium.org/588583002 and https://codereview.chromium.org/640733002, only done manually, because the code has changed since those CLs landed.

BUG=384873

Review-Url: https://codereview.chromium.org/2380943004
Cr-Commit-Position: refs/heads/master@{#422740}

On Android (and soon iOS), we track what kind of tile we show on the NTP
so that we can compare different kinds of clicks in UMA. The results are
probably no surprise: click rate for colored tiles is about twice that
of default-colored tiles (though it's not necessarily clear how much to
attribute that to our presentation and how much to the fact that good
sites generally have favicons).

Right now we have the default background color hard-coded in a few
places and use that to determine when a tile is default-colored. This is
possibly incorrect (when #787878 is in fact the dominant color) and
generally bad (constants can get out of sync).

This CL adds `bool FallbackIconStyle::is_default_background_color`, so
we can check that instead of comparing colors, and threads it through to
Android. It also deletes a few copies of the color constant. Three
copies remain: the authoritative copy in fallback_icon_style.cc, one in
its test, and one in Android's colors.xml.

BUG=651056

Review-Url: https://codereview.chromium.org/2374753002
Cr-Commit-Position: refs/heads/master@{#422739}

Revert of Integrate registry_hash_store_contents with the rest of tracked prefs. (patchset #24 id:460001 of https://codereview.chromium.org/2204943002/ )

Reason for revert:
This CL is suspect of breaking WebRTC Windows bots.
I will reland if it doesn't fix the problem.

See, for example, https://build.chromium.org/p/chromium.webrtc/builders/Win7%20Tester/builds/30007/steps/browser_tests/logs/stdio

[4936:6236:0930/181348:INFO:webrtc_video_quality_browsertest.cc(245)] Running "C:\b\depot_tools\python276_bin\python.exe" -u "C:\b\c\b\Win7_Tester\src\third_party/webrtc/tools/compare_videos.py" --label=720p_VP9 --ref_video "C:\b\c\b\Win7_Tester\src\chrome\test\data\webrtc/resources\reference_video_1280x720_30fps.yuv" --test_video "C:\Users\CHROME~1.LAB\AppData\Local\Temp\scoped_dir4936_9527\captured_video.yuv" --frame_analyzer "C:\b\c\b\Win7_Tester\src\out\Release\frame_analyzer.exe" --yuv_frame_width 1280 --yuv_frame_height 720 --zxing_path "C:\b\c\b\Win7_Tester\src\chrome\test\data\webrtc/resources\tools\win\zxing.exe" --ffmpeg_path "C:\b\c\b\Win7_Tester\src\chrome\test\data\webrtc/resources\tools\win\ffmpeg.exe" --stats_file "C:\Users\CHROME~1.LAB\AppData\Local\Temp\scoped_dir4936_9527\stats.txt"
[4936:6236:0930/181420:INFO:user_input_monitor_win.cc(171)] RegisterRawInputDevices() failed for RIDEV_REMOVE: The parameter is incorrect. (0x57)
[4936:6236:0930/181421:FATAL:json_pref_store.cc(385)] Check failed: !has_pending_write_callbacks_.
Backtrace:
	base::debug::StackTrace::StackTrace [0x02BA3CF7+23]
	logging::LogMessage::~LogMessage [0x02B5B061+49]
	JsonPrefStore::RegisterOnNextWriteSynchronousCallbacks [0x03668FDF+154]
	JsonPrefStore::SerializeData [0x03669601+179]
	base::ImportantFileWriter::DoScheduledWrite [0x02BE4B15+149]
	JsonPrefStore::CommitPendingWrite [0x0366803E+120]
	JsonPrefStore::~JsonPrefStore [0x03667DF8+21]
	scoped_refptr<TestingPrefStore>::Release [0x056591C1+23]
	SegregatedPrefStore::~SegregatedPrefStore [0x04359463+95]
	scoped_refptr<TestingPrefStore>::Release [0x056591C1+23]
	PrefService::~PrefService [0x03663ED9+141]
	syncable_prefs::PrefServiceSyncable::~PrefServiceSyncable [0x04088703+93]
	syncable_prefs::PrefServiceSyncable::`scalar deleting destructor' [0x04088714+11]
	ProfileImpl::~ProfileImpl [0x02C5706B+271]
	ProfileDestroyer::DestroyProfileWhenAppropriate [0x02D1A381+484]
	ProfileManager::ProfileInfo::~ProfileInfo [0x02C04D62+14]
	std::_Tree<std::_Tmap_traits<base::FilePath,linked_ptr<ProfileManager::ProfileInfo>,std::less<base::FilePath>,std::allocator<std::pair<base::FilePath const ,linked_ptr<ProfileManager::ProfileInfo> > >,0> >::_Erase [0x02B54889+41]
	std::_Tree<std::_Tmap_traits<base::FilePath,linked_ptr<ProfileManager::ProfileInfo>,std::less<base::FilePath>,std::allocator<std::pair<base::FilePath const ,linked_ptr<ProfileManager::ProfileInfo> > >,0> >::clear [0x02B548B2+13]
	std::_Tree<std::_Tmap_traits<base::FilePath,linked_ptr<ProfileManager::ProfileInfo>,std::less<base::FilePath>,std::allocator<std::pair<base::FilePath const ,linked_ptr<ProfileManager::ProfileInfo> > >,0> >::~_Tree<std::_Tmap_traits<base::FilePath,linked_p [0x02C04D0E+21]
	ProfileManager::~ProfileManager [0x02C04DAF+54]
	BrowserProcessImpl::StartTearDown [0x02DD70E9+458]
	ChromeBrowserMainParts::PostMainMessageLoopRun [0x02E333B0+304]
	content::BrowserMainLoop::ShutdownThreadsAndCleanUp [0x024E327A+350]
	content::BrowserMainRunnerImpl::Shutdown [0x024E4498+632]
	content::BrowserMain [0x024DFE41+139]
	content::RunNamedProcessTypeMain [0x02B46FAB+206]
	content::ContentMainRunnerImpl::Run [0x02B46EAC+274]
	content::ContentMain [0x02B46275+35]
	content::BrowserTestBase::SetUp [0x02F73565+964]
	InProcessBrowserTest::SetUp [0x02BF45D7+268]
	testing::internal::HandleExceptionsInMethodIfSupported<testing::TestCase,void> [0x033F7AB9+32]
	testing::Test::Run [0x033FEAA3+51]
	testing::TestCase::Run [0x033FEB79+133]
	testing::internal::UnitTestImpl::RunAllTests [0x033FEEF8+433]
	testing::internal::HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl,bool> [0x033F7AFD+32]
	testing::UnitTest::Run [0x033FED22+133]
	base::TestSuite::Run [0x02BFD110+95]
	ChromeTestSuiteRunner::RunTestSuite [0x052456CE+40]
	content::LaunchTests [0x02F6D485+585]
	LaunchChromeTests [0x052456A1+49]
	main [0x052454BA+63]
	__scrt_common_main_seh [0x0520AD1F+249] (f:\dd\vctools\crt\vcstartup\src\startup\exe_common.inl:253)
	BaseThreadInitThunk [0x75A0338A+18]
	RtlInitializeExceptionChain [0x77899902+99]
	RtlInitializeExceptionChain [0x778998D5+54]

Original issue's description:
> Integrate registry_hash_store_contents with the rest of tracked prefs.
>
> This change adds Windows-only logic to the PrefHashFilter such that it
> verifies preferences against MACs stored in the registry. Unlike the
> current tracked preference logic, this extra check does NOT reset
> settings.
>
> To avoid inconsistent state with the MACs in secure_preferences, we
> clear the registry MACs before writing secure_preferences, and write
> the registry MACs after the file is successfully written.
>
> BUG=624858
>
> Committed: https://crrev.com/4683dfcecfa72a73e00498d7c06fcf6716f8366c
> Cr-Commit-Position: refs/heads/master@{#422240}

TBR=gab@chromium.org,proberge@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=624858

Review-Url: https://codereview.chromium.org/2396443002
Cr-Commit-Position: refs/heads/master@{#422738}

Now that we keep track of subframe navigations in FrameNavigationEntry,
this CL move the redirect_chain field from NavigationEntry to
FrameNavigationEntry.

BUG=649879
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2368183004
Cr-Commit-Position: refs/heads/master@{#422737}