GitLab

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2874303002
Cr-Commit-Position: refs/heads/master@{#471059}

We were recording the first character of the selection to use as
a hint for triggering.  We don't currently have permission to send
this to Ranker so it's being removed for now, and the histogram being
marked obsolete.

We don't yet have permission to send any content signals to Ranker
so removing some promising ones like word-length from the send-to-ranker
list but keeping the underlying data collection for now.

Remove the entire blacklist and obsoleting the associated histogram.

BUG=720193

Review-Url: https://codereview.chromium.org/2875553002
Cr-Commit-Position: refs/heads/master@{#471058}

BUG=717538,715704

Review-Url: https://codereview.chromium.org/2874043003
Cr-Commit-Position: refs/heads/master@{#471057}

Memory-mapped files cause crashes if there are I/O problems. By ensuring
that the file is fully realized on disk, we eliminate a disk-full condition
from causing a crash down the road.

BUG=715523, 717331

Review-Url: https://codereview.chromium.org/2860943005
Cr-Commit-Position: refs/heads/master@{#471056}

Revert of [PageLoadMetrics] Reenable AdsMetrics and handle case where navigation aborts (patchset #7 id:340001 of https://codereview.chromium.org/2861433005/ )

Reason for revert:
Test is flaky, see https://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/452154

Original issue's description:
> [PageLoadMetrics] Reenable AdsMetrics and handle case where navigation aborts
>
> It turns out that a frame can abort and continue to load resources even if it
> has no previous navigation. This happens if a doc.write overwrites the frame
> navigation while the navigation is still provisional.
>
> This CL now labels all finished frame navigations (regardless of success) and
> removes an incorrect dcheck.
>
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
>
> BUG=708570
>
> Review-Url: https://codereview.chromium.org/2861433005
> Cr-Commit-Position: refs/heads/master@{#470701}
> Committed: https://chromium.googlesource.com/chromium/src/+/6f3a10ddea2ee602ff61267ce3ed6a60c8e6ff71

TBR=bmcquade@chromium.org,csharrison@chromium.org,jkarlin@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=708570

Review-Url: https://codereview.chromium.org/2876823003
Cr-Commit-Position: refs/heads/master@{#471055}

This assertion adds no value, and can trigger warnings (and errors if
you build with -Werror). I think it should be removed. If it is really
important, a comment where the variable is defined would suffice.

Patch submitted upstream:

https: //github.com/gperftools/gperftools/pull/885
Change-Id: Ife6de127928bfdd0c3861b65cdeb8e5ccbfee16d
Reviewed-on: https://chromium-review.googlesource.com/503034Reviewed-by: Will Harris <wfh@chromium.org>
Commit-Queue: Mostyn Bramley-Moore <mostynb@opera.com>
Cr-Commit-Position: refs/heads/master@{#471054}

BUG=676220
R=peter@chromium.org

Review-Url: https://codereview.chromium.org/2875443002
Cr-Commit-Position: refs/heads/master@{#471053}

Revert of Change TBR on import CLs to jeffcarp. (patchset #1 id:1 of https://codereview.chromium.org/2827093004/ )

Reason for revert:
Switching TBR back to qyearsley

Original issue's description:
> Change TBR on import CLs to jeffcarp.
>
> Review-Url: https://codereview.chromium.org/2827093004
> Cr-Commit-Position: refs/heads/master@{#466348}
> Committed: https://chromium.googlesource.com/chromium/src/+/91d68416a8808790a8d721a5ebe0accdafbcc066

TBR=jeffcarp@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.

Review-Url: https://codereview.chromium.org/2871603003
Cr-Commit-Position: refs/heads/master@{#471052}

Make Metalayer mode visibility dependent on the container side
setting.

BUG=b:37997351
TEST=Manual ("Metalayer mode" visible only when screenshots
  are enabled on the container side).

Review-Url: https://codereview.chromium.org/2871583003
Cr-Commit-Position: refs/heads/master@{#471051}

This change updates OWNERS files for device sensors-related directories
to point to the Blink>Sensor and Blink>Sensor>DeviceOrientation
components and device-dev@chromium.org team mailing list.

BUG=None

Review-Url: https://codereview.chromium.org/2774433002
Cr-Commit-Position: refs/heads/master@{#471050}

BUG=677365
R=tbansal@chromium.org

Review-Url: https://codereview.chromium.org/2873133004
Cr-Commit-Position: refs/heads/master@{#471049}

The folder will be used to host benchmarks for measuring perf of Chrome with
the network service enabled.

Eventually we won't need this folder when the network service is enabled by
default and the old network-in-browser-process code path is removed.

BUG=717738,598073
R=nednguyen@google.com

Review-Url: https://codereview.chromium.org/2877553003 .
Cr-Commit-Position: refs/heads/master@{#471048}

BUG=714769

Review-Url: https://codereview.chromium.org/2848923002
Cr-Commit-Position: refs/heads/master@{#471047}

Reland of build: Enable optimize_for_size unconditionally. (patchset #1 id:1 of https://codereview.chromium.org/2881503002/ )

Reason for revert:
Relanding now that the msan issue is fixed: https://codereview.chromium.org/2876693003

Original issue's description:
> Revert of build: Enable optimize_for_size unconditionally. (patchset #1 id:1 of https://codereview.chromium.org/2864383003/ )
>
> Reason for revert:
> Causes failures on a MSAN bot.
> https://uberchromegw.corp.google.com/i/chromium.memory/builders/Linux%20ChromiumOS%20MSan%20Tests/builds/440
>
>
> Original issue's description:
> > build: Enable optimize_for_size unconditionally.
> >
> > This change causes us to favor size over speed on Linux and Mac,
> > which aligns the build config for those platforms with that of the
> > other supported platforms, and should reduce the binary size impact
> > of enabling ThinLTO. This change is expected to reduce binary size
> > for Linux official builds by about 15%.
> >
> > There may be unacceptable perf regressions associated with this
> > change, but the perf bots should at least let us know where those
> > regressions are. I plan to monitor the Linux and Mac perf bots once
> > it lands.
> >
> > BUG=660216
> > R=thakis@chromium.org
> >
> > Review-Url: https://codereview.chromium.org/2864383003
> > Cr-Commit-Position: refs/heads/master@{#470606}
> > Committed: https://chromium.googlesource.com/chromium/src/+/c1269ce7fec8568a1789e07b2b5bb3b630a67f5f
>
> TBR=thakis@chromium.org,pcc@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=660216
>
> Review-Url: https://codereview.chromium.org/2881503002
> Cr-Commit-Position: refs/heads/master@{#470793}
> Committed: https://chromium.googlesource.com/chromium/src/+/2a6f440fa84a584d916254f9a4c4e4d83c53435f

TBR=thakis@chromium.org,yhirano@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=660216

Review-Url: https://codereview.chromium.org/2870393005
Cr-Commit-Position: refs/heads/master@{#471046}

The libtxc_dxtn.so library supports loading textures in S3TC
format. This change disables code in mesa that loads libtxc_dxtn.so
if msan is enabled, as the library will be loaded from a system
directory, which may cause spurious msan reports because msan expects
most libraries in the process to be compiled with msan.

For some reason, msan only appears to break when compiling with -Os,
as revealed by a recent attempt [0] to enable -Os on Linux and Mac.

[0] https://codereview.chromium.org/2864383003/

BUG=660216
R=senorblanco@chromium.org,thakis@chromium.org

Review-Url: https://codereview.chromium.org/2876693003
Cr-Commit-Position: refs/heads/master@{#471045}

No behavior change.

BUG=675877

Review-Url: https://codereview.chromium.org/2875703003
Cr-Commit-Position: refs/heads/master@{#471044}

https://pdfium.googlesource.com/pdfium.git/+log/4da1e7623c52..dbc3d3e1e0b2

$ git log 4da1e7623..dbc3d3e1e --date=short --no-merges --format='%ad %ae %s'
2017-05-11 dsinclair Fixup Initialize spelling
2017-05-11 npm Stop rendering if a span length overflowed in AGG
2017-05-11 npm LibOpenJPEG: undefined shift in opj_t1_dec_clnpass

Created with:
  roll-dep src/third_party/pdfium


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


TBR=dsinclair@chromium.org

Change-Id: I0a5c3a4534b3b10949d8cb28df03f6b01c49e9d6
Reviewed-on: https://chromium-review.googlesource.com/503427
Reviewed-by: <pdfium-deps-roller@chromium.org>
Commit-Queue: <pdfium-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#471043}

BUG=720605

Review-Url: https://codereview.chromium.org/2874873002
Cr-Commit-Position: refs/heads/master@{#471042}

Replaces these APIs with IncomingBrokerClientInvitation usage.
This new API more accurately reflects the intended design of
the system and forces developers to select a transport protocol
when joining a Mojo embedder process graph.

BUG=696031
TBR=jam@chromium.org

Change-Id: I90460badec6622447432b0bb76b202c8a14270ed
Reviewed-on: https://chromium-review.googlesource.com/502548Reviewed-by: Ken Rockot <rockot@chromium.org>
Reviewed-by: Jay Civelli <jcivelli@chromium.org>
Commit-Queue: Ken Rockot <rockot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#471041}

This was incorrectly removed in r412736, but this bug was not noticed
due to an implementation detail of devtools that would trigger the
DidAccessInitialDocument() call via a different code path. When the
devtools changed in r465484, this revealed the bug.

This also improves the tests to try to catch any future instances of
tests that incorrectly pass when they shouldn't by adding baseline
tests that assert that DidAccessInitialDocument() isn't called when
it shouldn't be.

Bug: 718946, 719122
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation
Change-Id: I3262f5f4367eeaeae1d24f145136773263610f77
Reviewed-on: https://chromium-review.googlesource.com/502347Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Charlie Reis <creis@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#471040}

This CL uses a std::deque<std::unique_ptr<media::AudioBus>> instead
of an AudioFifo, to avoid copying data needlessly.

BUG=None

Review-Url: https://codereview.chromium.org/2854363002
Cr-Commit-Position: refs/heads/master@{#471039}

This CL fixes :
1 - Highlighting of menu icons in the footer in chrome home mode
2 - Highlighting of data saver footer
3 - Y inset of the text bubble in the chrome home mode

BUG=721088

Review-Url: https://codereview.chromium.org/2872023004
Cr-Commit-Position: refs/heads/master@{#471038}

//ios/chrome/browser/tabs details:
tab.h includes files from these targets, therefore they are part of //ios/chrome/browser/tabs public interface.

Example error:
In file included from ../../ios/chrome/browser/ui/stack_view/stack_view_egtest.mm:13:
In file included from ../../ios/chrome/browser/tabs/tab.h:17:
In file included from ../../ios/web/public/web_state/ui/crw_web_delegate.h:15:
In file included from ../../ios/web/public/ssl_status.h:12:
In file included from ../../net/cert/x509_certificate.h:25:
../../third_party/boringssl/src/include/openssl/base.h:71:10: fatal error: 'openssl/is_boringssl.h' file not found

//ios/chrome/browser/ui/tabs details:
tab_view.h includes headers from these targets, thus they are part of //ios/chrome/browser/ui/tabs public interface.

Example error:
In file included from ../../ios/chrome/browser/ui/tabs/tab_strip_egtest.mm:9:
In file included from ../../ios/chrome/browser/ui/tabs/tab_view.h:11:
In file included from ../../ios/chrome/browser/tabs/tab.h:17:
In file included from ../../ios/web/public/web_state/ui/crw_web_delegate.h:15:
In file included from ../../ios/web/public/ssl_status.h:12:
In file included from ../../net/cert/x509_certificate.h:25:
../../third_party/boringssl/src/include/openssl/base.h:71:10: fatal error: 'openssl/is_boringssl.h' file not found

//ios/web:web_arc details:
ssl_status.h includes headers from net, thus they are part of //ios/web:web_arc public interface.

Example error:
    In file included from ../../ios/chrome/browser/ui/payments/payment_request_manager.mm:31:
    In file included from ../../ios/web/public/ssl_status.h:12:
    In file included from ../../net/cert/x509_certificate.h:25:
    ../../third_party/boringssl/src/include/openssl/base.h:71:10: fatal error: 'openssl/is_boringssl.h' file not found

BUG=none

Review-Url: https://codereview.chromium.org/2873203002
Cr-Commit-Position: refs/heads/master@{#471037}

This CL has these fixes:
1. Removed the glViewport call since it doesn't account for the screen DPI in
    iOS client and it isn't required by either the Android or the iOS client. See
    explanation in comments.
2. Do not reset the viewport if the new screen/desktop size have not changed,
   since viewDidLayoutSubviews: may be called while the frame size is not
   changed.
3. Fix the issue that the first rendered frame may not be shown on the screen
   and explain with comments.
4. Releases the GlDisplayHandlerCore when disconnected.

Review-Url: https://codereview.chromium.org/2874143002
Cr-Commit-Position: refs/heads/master@{#471036}

We have several independent places where we decided how extension icon
is represented. We have separate logic for the shelf, recent view, app
list and app info icons. Icon look depends on type of app and some
external conditions. This leads to situation that extension App icon
looks differently in different places. Yet another problem is non-stable
applying Chrome badging in case corresponded ARC app is installed or
uninstalled.

Solution is to provide centrilized place where app icon is processed
and all consumers should use. ChromeAppIcon is introduced that applies all necessary effects based on current environment and app type. ChromeAppIconService is introduced to refer all created icons,
monitor environment changes and updating the icon. Resulting icon
image is sent to consumer via ChromeAppIconDelegate interface.

BUG=712729
BUG=703366
BUG=b/37418449
Test=Manually on device. Existing tests passed.

TBR=yoshiki@chromium.org

Review-Url: https://codereview.chromium.org/2819413003
Cr-Commit-Position: refs/heads/master@{#471035}

Bug: 721157
Change-Id: I180cb4df0839deb0fb23e0ff962b172bd2517f5e
Reviewed-on: https://chromium-review.googlesource.com/502628Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#471034}

Revert of Update ozone/drm proxy_helpers.h to support move-only types. (patchset #1 id:1 of https://codereview.chromium.org/2873963004/ )

Reason for revert:
ozone_unittests has been failing continuously since this landed:

https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Ozone%20Tests%20%281%29/builds/46812

[ RUN      ] ProxyHelpersTest.PostTask
../../ui/ozone/platform/drm/gpu/proxy_helpers_unittest.cc:69: Failure
Value of: main_checker_.CalledOnValidThread()
  Actual: true
Expected: false
../../ui/ozone/platform/drm/gpu/proxy_helpers_unittest.cc:50: Failure
Value of: main_checker_.CalledOnValidThread()
  Actual: true
Expected: false
../../ui/ozone/platform/drm/gpu/proxy_helpers_unittest.cc:75: Failure
Value of: drm_checker_.CalledOnValidThread()
  Actual: true
Expected: false

Original issue's description:
> Update ozone/drm proxy_helpers.h to support move-only types.
>
> As a helpful prerequisite for the use of mojo IPC in ozone/drm,
> support move only types in proxy_helpers.h callback sequences.
>
> BUG=620927
>
> Review-Url: https://codereview.chromium.org/2873963004
> Cr-Commit-Position: refs/heads/master@{#470715}
> Committed: https://chromium.googlesource.com/chromium/src/+/a82a006f8420ecc7c75deab4f1e9d23c43616e1f

TBR=dnicoara@chromium.org,rjkroege@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=620927

Review-Url: https://codereview.chromium.org/2873153005
Cr-Commit-Position: refs/heads/master@{#471033}

BUG=721475

TBR=dmazzoni@chromium.org

Review-Url: https://codereview.chromium.org/2874293002
Cr-Commit-Position: refs/heads/master@{#471032}

BUG=673362

Review-Url: https://codereview.chromium.org/2878563002
Cr-Commit-Position: refs/heads/master@{#471031}

This allows users to turn client-side LoFi on android.

BUG=720920

Review-Url: https://codereview.chromium.org/2870263004
Cr-Commit-Position: refs/heads/master@{#471030}

This CL modify the FrameLoadType of frames such that the
ReloadBypassingCache load type gets propagated to every subframe during
a reload.

It fixes ReloadCacheControlBrowserTest.BypassingReload test with
PlzNavigate. Every ReloadCacheControlbroserTest are passing now.

BUG=671545
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_browser_side_navigation_rel

Review-Url: https://codereview.chromium.org/2863683003
Cr-Commit-Position: refs/heads/master@{#471029}

This tries to mimic the current commandline opion of
./third_party/WebKit/Tools/Scripts/run-perf-tests. i.e: user now can run
test case in WebKit/PerformanceTests/.. directory using the command:

./tools/perf/run_benchmark blink_perf --test-path=<path to test cases>

For examples, after this CL, users can invoke:
* './tools/perf/run_benchmark blink_perf --test-path=third_party/WebKit/PerformanceTests/TestData/color-changes-measure-frame-time.html'
command to run only color-changes-measure-frame-time.html test.

* './tools/perf/run_benchmark blink_perf --test-path=TestData/'
command to run all the tests in WebKit/PerformanceTests/TestData/ directory.

This is a lot more convenient for users who are wanting to add new test cases in
directories that aren't already covered by existing blink_perf.* benchmarks.

This benchmark is added to tools/perf/contrib/ directory because it isn't meant
to be scheduled on the perf waterfall.

BUG=720772

Review-Url: https://codereview.chromium.org/2874653002
Cr-Commit-Position: refs/heads/master@{#471028}

This was part of an aborted refactor, which was abandoned due to memory coordinator work (which has deprecated the memory pressure subsystem).
When memory coordinator is finished all uses of memory pressure will be migrated to it.

BUG=
TBR=sdefresne@chromium.org, halliwell@chromium.org

Review-Url: https://codereview.chromium.org/2874553004
Cr-Commit-Position: refs/heads/master@{#471027}

BUG=

Review-Url: https://codereview.chromium.org/2877723003
Cr-Commit-Position: refs/heads/master@{#471026}

Nothing seems to reference this.

Review-Url: https://codereview.chromium.org/2877503003
Cr-Commit-Position: refs/heads/master@{#471025}

https://skia.googlesource.com/skia.git/+log/a9d9ab368318..eb7a693e0f6d

$ git log a9d9ab368..eb7a693e0 --date=short --no-merges --format='%ad %ae %s'
2017-05-11 msarett Move SK_API from namespace to function
2017-05-11 mtklein remove TODO in SkGradientShader.cpp
2017-05-11 bsalomon Workaround for Intel 6xxx clear to opaque black bug
2017-05-11 stephana Enable debug output on iOS
2017-05-11 jvanverth Fix transparent ambient shadows
2017-05-11 jvanverth Fix transparent ambient for perspective shadows
2017-05-11 msarett Add SkJpegEncoder and SkWebpEncoder to public API

Created with:
  roll-dep src/third_party/skia


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=stani@chromium.org

Change-Id: I940fc0e66a4ade56bedfa65aeb8d3d9ed16fbe86
Reviewed-on: https://chromium-review.googlesource.com/502612Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org>
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#471024}

Add gn args and BUILDFLAGS for OfflinePages, instead on relying on is_android and is_official_build.
This will reliably remove the manual test harness code from the builds tested on waterfall.
Also it's in preparation for potential move of OfflinePages to other platforms (like ChromeOS).

BUG=NONE

Review-Url: https://codereview.chromium.org/2875853003
Cr-Commit-Position: refs/heads/master@{#471023}

Still causing crashes, so disable.

I have a fix in the works but it will take a bit more time so disabling in the meanwhile.

TBR=bmcquade
NOTRY=true

BUG=721369

Review-Url: https://codereview.chromium.org/2876693005
Cr-Commit-Position: refs/heads/master@{#471022}

The old Audit implementation is not used anywhere anymore except in
two tests that tested the old implmentation.  Remove these tests as
well.

BUG=704967
TEST=none

Review-Url: https://codereview.chromium.org/2872703004
Cr-Commit-Position: refs/heads/master@{#471021}

Changes:
On kevin, audio input source dropdown list displays both "Mic" and "Built-in mic". This is not expected.
For new devices, like kevin, internal-mic/mic and internal-speaker/headphone may not share the same device index, meanwhile, headphone and line-out may share the same device index. This cl is to fix this by creating virtual device name only when two audio nodes sharing the same device index.
Currently will cover three cases:
(1) Show "Built-in mic" when internal-mic and mic share dev_index, otherwise show "Mic" and "Internal mic" separately.
(2) Show "Built-in speaker" when internal-speaker and headphone share dev_index, otherwise show "Speaker" and "Headphone" separately.
(3) Show "Headphone/Line Out" when headphone and line-out share dev_index, otherwise show "Headphone" and "Line Out" separately.

TBR=dgreid@chromium.org
BUG=718220
TEST=tested on kevin and veyron_minnie, the label name works properly on https://webrtc.github.io/samples/src/content/devices/input-output/.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2869933002
Cr-Commit-Position: refs/heads/master@{#471020}