GitLab

If a StreamReader is found that it can no longer write any data, we should
clear its callback.
Otherwise, the StreamReader can  still report an error and interrupt the download.

BUG=717719

If the data has already been written

Review-Url: https://codereview.chromium.org/2861443005
Cr-Commit-Position: refs/heads/master@{#469193}

WorkerPool is being deprecated in favor of TaskScheduler.

BUG=659191

Review-Url: https://codereview.chromium.org/2855543003
Cr-Commit-Position: refs/heads/master@{#469192}

Want to move resources.zip files out of gen/ directory since they
won't get packaged by several of the Builder bots. We will need
these resources.zip files for JUnit tests.

BUG=693573

Review-Url: https://codereview.chromium.org/2862603002
Cr-Commit-Position: refs/heads/master@{#469191}

This CL does the following:
- Move strings into page_info_strings.grdp
- Organize the strings into sections with comment headings, based on the order and role they have in the UI.
- Remove old "chrome/grit/generated_resources.h" includes in C++ files where possible.
- Replace IDS_PAGE_INFO_TITLE_SITE_DATA with IDS_PAGE_INFO_COOKIES (crbug.com/716296)
- Remove dead strings and their associated code (crbug.com/709701)
- Rename remaining IDS_PAGEINFO_* strings to IDS_PAGE_INFO_* (crbug.com/716305)
- Unfork IDS_PAGE_INFO_NON_SECURE_TRANSPORT into IDS_PAGEINFO_NOT_SECURE_SUMMARY

BUG=663975, 709701, 716296, 716296, 716305
TBR=meacer@chromium.org, asanka@chromium.org, kkhorimoto@chromium.org

Review-Url: https://codereview.chromium.org/2849713003
Cr-Commit-Position: refs/heads/master@{#469190}

This was an oversight when I originally implemented kCompositingInputsUpdate;
the early-exit from UpdateLifecyclePhasesInternal meant that some necessary
logic was being skipped accidentally.

BUG=716150
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2844993004
Cr-Commit-Position: refs/heads/master@{#469189}

This is required for GCC builds with is_official_build=true.

BUG=464797

Review-Url: https://codereview.chromium.org/2858723002
Cr-Commit-Position: refs/heads/master@{#469188}

BUG=

Review-Url: https://codereview.chromium.org/2854973004
Cr-Commit-Position: refs/heads/master@{#469187}

Revert "Revert of Fix omnibox suggestions being overdrawn with the nav bar. (patchset #1 id:1 of https://codereview.chromium.org/2849283002/ )"

This reverts commit 50e675c5.

findViewById(android.R.id.content) can return null if called early
enough.

BUG=669150

Review-Url: https://codereview.chromium.org/2856943002
Cr-Commit-Position: refs/heads/master@{#469186}

Revert of Add more strict DCHECKs around context state. (patchset #1 id:1 of https://codereview.chromium.org/2852353003/ )

Reason for revert:
Breaks an optimization needed on some Android devices for performance.

Original issue's description:
> Add more strict DCHECKs around context state.
>
> Upon processing commands in the GLES2Decoder, assert that the context
> is current.
>
> Make virtual contexts' definition of "current" more strict. This
> required moving a DCHECK inside the base GLContext class.
>
> These aren't needed, but were useful during recent debugging to
> confirm that the bug wasn't in these areas.
>
> BUG=694359
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
>
> Review-Url: https://codereview.chromium.org/2852353003
> Cr-Commit-Position: refs/heads/master@{#469115}
> Committed: https://chromium.googlesource.com/chromium/src/+/a21cb49e77bf727d692bbe8dd8eda85a9d089e93

TBR=jbauman@chromium.org,zmo@chromium.org,piman@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=694359

Review-Url: https://codereview.chromium.org/2859963002
Cr-Commit-Position: refs/heads/master@{#469185}

https://codereview.chromium.org/2838033002/ unintentionally removed
layers with singular transform and copy requests from the list of layers
that draw. This CL fixes that.
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2856043002
Cr-Commit-Position: refs/heads/master@{#469184}

Since all actual semantic clips are represented by the clip tree, this code
was only necessary to check for cases when a surface exceeded the maximum
texture size. Since the rendering would already be broken in such cases,
it seems ok to not count that as a clip, which is correct w.r.t. the semantics
of the web page, even if it disagrees with the apparent rendering.

Note: the relevant code was added in https://codereview.chromium.org/1551333003.

BUG=718149
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2858053003
Cr-Commit-Position: refs/heads/master@{#469183}

The declarativeContent API exposes constructors that initialize certain
types. These constructors (sometimes) take arguments that need to be
validated against the schema. Add native support for this validation by
allowing native hooks to modify the API binding's object template, and
using this to expose the constructor methods rather than relying on the
JS custom bindings.

Add additional declarativeContent-related tests and unittests for hooks
modifying the API binding template.

BUG=653596

Review-Url: https://codereview.chromium.org/2853023002
Cr-Commit-Position: refs/heads/master@{#469182}

JavaScriptDialogClosed walks up a list of frames. It shouldn’t be deleting frames and then calling functions on them.

BUG=717410
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2858743003
Cr-Commit-Position: refs/heads/master@{#469181}

Use a constexpr constructor that accepts traits in any order instead of
the builder pattern to construct TaskTraits in net.

BUG=713683
R=gab@chromium.org
TBR=jri@chromium.org

Review-Url: https://codereview.chromium.org/2854243003
Cr-Commit-Position: refs/heads/master@{#469180}

Only Windows was using ScopedHandle. Other platforms already used a
SharedMemoryHandle directly. The theoretical benefit of ScopedHandle is that it
correctly deals with ownership. But all that does is ensure that the handle is
closed during destruction of SharedMemory, which is already explicitly coded,
since it's needed on all platforms. Switching to SharedMemoryHandle is needed to
correctly propagate other state on SharedMemoryHandle, which is being added in
the near future.

BUG=713763

Review-Url: https://codereview.chromium.org/2854833004
Cr-Commit-Position: refs/heads/master@{#469179}

This CL remove some conditions that must never be true:

* (entry_count == 0 && pending_index ==  0) because
  (entry_count == 0 => pending_index == -1)

* (current_index == -1 && entry_count >  0) because
  (current_index == -1 => entry_count == 0)

A similar simplification can be found in:
https://codereview.chromium.org/2762363002/

This CL was done while trying to understand the crashes in:
https://crbug.com/709431

BUG=709431
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2802213002
Cr-Commit-Position: refs/heads/master@{#469178}

https://chromium.googlesource.com/libyuv/libyuv.git/+log/3b583396bf13..945ea1b74630

$ git log 3b583396b..945ea1b74 --date=short --no-merges --format='%ad %ae %s'
2017-05-02 fbarchard mips switch sgtu to sltu for clang in ndk r14
2017-04-25 vigneshv Fix mips build on android ndk r14+

The new llvm (3.8+) has a built assembler, but it was missing the sgtu (set greater than unsigned) pseudo op.  Its been fixed for 4.0, but the pseudo op just swaps the arguments and uses sltu.  In this change the source is switched to use sltu directly.

Created with:
  roll-dep src/third_party/libyuv

R=kjellander@chromium.org
BUG=libyuv:700
TEST=built under android with mips target

Review-Url: https://codereview.chromium.org/2854253003
Cr-Commit-Position: refs/heads/master@{#469177}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/647b1a635c82..5c834a1ca845

$ git log 647b1a635..5c834a1ca --date=short --no-merges --format='%ad %ae %s'
2017-05-03 dtu [pinpoint] Make API routes consistent.
2017-05-03 dtu [pinpoint] Add dtu to OWNERS for pinpoint.yaml
2017-05-03 benjhayden Synchronize HistogramSetViewState with location.search using HTML5 history API.

Created with:
  roll-dep src/third_party/catapult


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=sullivan@chromium.org

Change-Id: Ia50d25129294f5dc5b0245b478631eafc2ca562c
Reviewed-on: https://chromium-review.googlesource.com/494967
Reviewed-by: <catapult-deps-roller@chromium.org>
Commit-Queue: <catapult-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#469176}

A heap is created by CSR client that is used to share memory between the client and csrss.exe (the server). We destroy this heap to ensure all heaps are valid (that any callers of GetProcessHeaps() receive valid heaps).

BUG=464430
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win10_chromium_x64_rel_ng

Review-Url: https://codereview.chromium.org/2726733003
Cr-Commit-Position: refs/heads/master@{#469175}

Using wpt-import in Chromium 51b20818.

Build: https://build.chromium.org/p/chromium.infra.cron/builders/wpt-importer/builds/69

Directory owners for changes in this CL:
blink-network-dev@chromium.org:
  external/wpt/XMLHttpRequest
dom-dev@chromium.org:
  external/wpt/dom
  external/wpt/shadow-dom
  external/wpt/editing
  external/wpt/html
  external/wpt/selection
  external/wpt/custom-elements
domenic@chromium.org, ricea@chromium.org, tyoshino@chromium.org:
  external/wpt/streams
dtapuska@chromium.org:
  external/wpt/uievents
eroman@chromium.org, rsleevi@chromium.org:
  external/wpt/WebCryptoAPI
hongchan@chromium.org, rtoy@chromium.org:
  external/wpt/webaudio
hta@chromium.org:
  external/wpt/webrtc
jsbell@chromium.org:
  external/wpt/IndexedDB
  external/wpt/resources
  external/wpt/WebIDL
mek@chromium.org:
  external/wpt/webmessaging
rego@igalia.com:
  external/wpt/css/selectors4
rijubrata.bhaumik@intel.com, mcasas@chromium.org:
  external/wpt/html-media-capture
rouslan@chromium.org, mathp@chromium.org:
  external/wpt/payment-request
style-dev@chromium.org:
  external/wpt/cssom
  external/wpt/cssom-view
suzyh@chromium.org:
  external/wpt/web-animations
tyoshino@chromium.org, yhirano@chromium.org, mkwst@chromium.org, japhet@chromium.org:
  external/wpt/fetch
xlai@chromium.org, jinho.bang@samsung.com, hs1217.lee@samsung.com:
  external/wpt/css/geometry-1

TBR=jeffcarp@chromium.org
NOEXPORT=true

Change-Id: Ie596c148ad885e577210805bbd84bdfc57b2d84d
Reviewed-on: https://chromium-review.googlesource.com/490551Reviewed-by: Jeff Carpenter <jeffcarp@chromium.org>
Reviewed-by: Blink W3C Test Autoroller <blink-w3c-test-autoroller@chromium.org>
Reviewed-by: Adam Rice <ricea@chromium.org>
Commit-Queue: Jeff Carpenter <jeffcarp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#469174}

Use a constexpr constructor that accepts traits in any order instead of
the builder pattern to construct TaskTraits in device.

BUG=713683
R=gab@chromium.org,reillyg@chromium.org
TBR=mcchou@chromium.org

Review-Url: https://codereview.chromium.org/2855233002
Cr-Commit-Position: refs/heads/master@{#469173}

Revert of Global Resource Coordinator: Basic service internals (patchset #33 id:620001 of https://codereview.chromium.org/2798713002/ )

Reason for revert:
Reverting again as this is still breaking https://bugs.chromium.org/p/chromium/issues/detail?id=716553

Original issue's description:
> Reland: Global Resource Coordinator: Basic service internals
>
> This adds the basic internals of the GRC; CoordinationUnits which can form a DAG, receive events, and send back updated resource usage policies.
>
> A full prototype of GRC usage can be seen here: https://codereview.chromium.org/2710823003
>
> Service architecture doc: https://docs.google.com/document/d/1qec4DNDM2pLLIFfCBtnNQTxlNXQzjml69yC8SGU9bzI/edit#
>
> GRC parent doc (internal only): https://docs.google.com/document/d/1dx4KDbDFvP-GWwwrSPg8Gxx4kboIoPi8kDKTSXoTbC4/edit#heading=h.td4yhfm12fe3
>
> R=primiano@chromium.org,skyostil@chromium.org,fmeawad@chromium.org,rockot@chromium.org
> BUG=691886
>
> Review-Url: https://codereview.chromium.org/2798713002
> Cr-Original-Commit-Position: refs/heads/master@{#468002}
> Committed: https://chromium.googlesource.com/chromium/src/+/de0f39d2a625433e60b5e22e1d2d3803f3d219e5
> Review-Url: https://codereview.chromium.org/2798713002
> Cr-Commit-Position: refs/heads/master@{#469107}
> Committed: https://chromium.googlesource.com/chromium/src/+/8b47351be59f0d590d8d5fcffe1c07350ba110f2

TBR=chrisha@chromium.org,dcheng@chromium.org,fmeawad@chromium.org,jam@chromium.org,nasko@chromium.org,primiano@chromium.org,rockot@chromium.org,skyostil@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=691886

Review-Url: https://codereview.chromium.org/2856173003
Cr-Commit-Position: refs/heads/master@{#469172}

BUG=717761
TEST=Fullscreen/Maximize Play Store app, then minimize/unminmize.

Review-Url: https://codereview.chromium.org/2861523002
Cr-Commit-Position: refs/heads/master@{#469171}

BUG=718149
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2861593004
Cr-Commit-Position: refs/heads/master@{#469170}

https://codereview.chromium.org/2797043002

Made histogram checker raise exception for duplicated enum values.

BUG=711205

Review-Url: https://codereview.chromium.org/2835733002
Cr-Commit-Position: refs/heads/master@{#469169}

https://skia.googlesource.com/skia.git/+log/a9e241d35764..ab244f045a07

$ git log a9e241d35..ab244f045 --date=short --no-merges --format='%ad %ae %s'
2017-05-03 fmalita Revert "Revert "Reland: Remove SkLights include from SkCanvas.h""
2017-05-03 csmartdalton Convert GrMesh to a struct
2017-05-03 msarett Delete SkBitmap::copyTo()
2017-05-03 ethannicholas sksl SPIR-V sampledBuffer support
2017-05-03 mtklein dither stage
2017-05-02 benjaminwagner Upgrade Windows 10 to v1703.
2017-05-01 robertphillips Allow TextureSamplers to have null GrTexture pointer
2017-05-02 herb Add sweep gradient to SkRasterPipeline

Created with:
  roll-dep src/third_party/skia


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=scroggo@chromium.org

Change-Id: I0f5e0b06df0b82b3c9c831aa5b4eda69d275f997
Reviewed-on: https://chromium-review.googlesource.com/494795Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org>
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#469168}

Use a constexpr constructor that accepts traits in any order instead of
the builder pattern to construct TaskTraits in base.

BUG=713683
R=gab@chromium.org

Review-Url: https://codereview.chromium.org/2861833002
Cr-Commit-Position: refs/heads/master@{#469167}

https://pdfium.googlesource.com/pdfium.git/+log/0578244a1a68..0acfff302c03

$ git log 0578244a1..0acfff302 --date=short --no-merges --format='%ad %ae %s'
2017-05-02 thestig Actually build fuzzers with the pdfium_all target.

Created with:
  roll-dep src/third_party/pdfium


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


TBR=dsinclair@chromium.org

Change-Id: I9f4b828adb8a37c2a74d99879840e059268e3153
Reviewed-on: https://chromium-review.googlesource.com/495114
Reviewed-by: <pdfium-deps-roller@chromium.org>
Commit-Queue: <pdfium-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#469166}

This CL fixes the tooltip background color on the non-Dark variant of
Adwaita which requires tooltips have the "background" class [1].

Additionally, this CL avoids creating a selector with a GtkWindow
parent class on Gtk 3.20.  This avoids tinting the tooltip with the
window background color if tooltips have transparency (FYI: Chrome
tooltips are opaque, so the alpha will be ignored).

[1] https://github.com/GNOME/gtk/blob/ee3994f715a2f53519f1478d2f08c6548471a8ae/gtk/theme/Adwaita/gtk-contained.css#L4387

BUG=716599
R=erg@chromium.org

Review-Url: https://codereview.chromium.org/2855063002
Cr-Commit-Position: refs/heads/master@{#469165}

Use a constexpr constructor that accepts traits in any order instead of
the builder pattern to construct TaskTraits in extensions.

BUG=713683
R=gab@chromium.org
TBR=benwells@chromium.org

Review-Url: https://codereview.chromium.org/2859933002
Cr-Commit-Position: refs/heads/master@{#469164}

This code hasn't been building since the blink reformat, suggesting
it's unused.

BUG=675877

Review-Url: https://codereview.chromium.org/2863483002
Cr-Commit-Position: refs/heads/master@{#469163}

BUG=717889

Review-Url: https://codereview.chromium.org/2862583004
Cr-Commit-Position: refs/heads/master@{#469162}

The change in https://codereview.chromium.org/2853563002
introduced some extra log spam.

BUG=380937

Review-Url: https://codereview.chromium.org/2856313002
Cr-Commit-Position: refs/heads/master@{#469161}

-remove WillServiceRequest which wasn't used
-change ShouldServiceRequest to take in the required fields, which are url, context and process ID

BUG=717714

Review-Url: https://codereview.chromium.org/2856093004
Cr-Commit-Position: refs/heads/master@{#469160}

Use a constexpr constructor that accepts traits in any order instead of
the builder pattern to construct TaskTraits in media.

BUG=713683
R=gab@chromium.org
TBR=hubbe@chromium.org

Review-Url: https://codereview.chromium.org/2860573009
Cr-Commit-Position: refs/heads/master@{#469159}

Nothing ever defines WEBAUDIO_IPP, so this file is dead.

BUG=675877

Review-Url: https://codereview.chromium.org/2857853006
Cr-Commit-Position: refs/heads/master@{#469158}

LTR image diffs show this as:
- Identical to HEAD in retina
- In non-retina, some bookmarks at the width limit show an additional character vs. HEAD. I think this is more true to the spec and is closer to Views (though it's hard to compare directly since views fades instead of cutting off with an ellipsis)

This is a semi-manual rebase of
https://codereview.chromium.org/2511973002/

BUG=648561, 648560

Review-Url: https://codereview.chromium.org/2845003003
Cr-Commit-Position: refs/heads/master@{#469157}

BUG=675877

Review-Url: https://codereview.chromium.org/2858053002
Cr-Commit-Position: refs/heads/master@{#469156}

Multiple users have reported stack overflow errors in JavaScript code
used by ChromeDriver. This is generally triggered by web pages that
modify built-in types. In particular, adding named properties to Array
prototype has been very problematic.

This CL handles this issue by ignoring named properties in arrays.

BUG=chromedriver:1114

Review-Url: https://codereview.chromium.org/2854823003
Cr-Commit-Position: refs/heads/master@{#469155}

BUG=636993

Review-Url: https://codereview.chromium.org/2856273002
Cr-Commit-Position: refs/heads/master@{#469154}