GitLab

Implements a state machine to bridge the gap between
chrome_pdf::UrlLoader's pull model and blink::WebAssociatedURLLoader's
push model.

This change only handles the basic state transitions; this is sufficient
to simulate an empty response. A future change will deal with handling
the data received by DidReceiveData().

Also fills in a basic blink::WebURLRequest, since BlinkUrlLoader calls
WebAssociatedLoader::LoadAsynchronously() now. Note that RequestContext
and RequestDestination must be set to pass certain security checks.

Bug: 1099022
Change-Id: I20840e44adda63816f8c7d6a531ffe106dd8bfdf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2411547
Commit-Queue: K. Moon <kmoon@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Daniel Hosseinian <dhoss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#807345}

In this CL, has_potential_filter_animation, has_potential_backdrop_filter_animation are considered while calculating node_or_ancestor_has_filters, affected_by_backdrop_filter to avoid rerasterization during the animation.

Bug: 1115564
Change-Id: If58e1e71477758fc0c56e46f5dfd5ad6687cd43e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412028
Commit-Queue: jongdeok.kim <jongdeok.kim@navercorp.com>
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#807344}

This reverts commit f1458788.

Reason for revert: Still flaky on mac: https://ci.chromium.org/p/chromium/builders/ci/Mac10.10%20Tests/58334

Original change's description:
> [WebOTP] Fix flaky test SameSiteNavigationResetsDocumentUsedWebOTP
> 
> Gives more time to propagate the WebOTP bit.
> 
> Bug: 1120305
> Change-Id: Id350a03de42d3ea5895f01f47cdb5fff7ce801e5
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2405374
> Reviewed-by: Ken Buchanan <kenrb@chromium.org>
> Commit-Queue: Yi Gu <yigu@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#807065}

TBR=kenrb@chromium.org,yigu@chromium.org

Change-Id: I00eaf5dad7403127a62af0d8c6e67c580846df9d
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1120305
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409466Reviewed-by: Yoichi Osato <yoichio@chromium.org>
Commit-Queue: Yoichi Osato <yoichio@chromium.org>
Cr-Commit-Position: refs/heads/master@{#807343}

This is in preparation for giving this class additional functionality
unrelated to BLE.

Bug: 1106937
Change-Id: Ib060a446580310df97651d0145e6f7e0d0784961
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412835
Auto-Submit: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: James Vecore <vecore@google.com>
Reviewed-by: James Vecore <vecore@google.com>
Cr-Commit-Position: refs/heads/master@{#807342}

#1. Remove importScripts() special handling

WorkerOrWorkletScriptController has a special logic for
exceptions in importScripts(), which plumbs ErrorEvent
outside V8 (i.e. via error_event_from_imported_script_)
while rethrowing exceptions in V8, in order to transmit
the original exception location information, eventually
to WorkerGlobalScope's error event.

In order to merge WorkerOrWorkletScriptController logic
with its counterpart in ScriptController, this CL removes
this importScripts() special logic and makes the logic
look more spec conformant. This CL:

- Uses v8::TryCatch::ReThrow() instead of
  ExceptionState::RethrowV8Exception(), because
  ReThrow() seems to preserve the original exception location
  while RethrowV8Exception() doesn't seem so.
- Uses `v8::TryCatch::SetVerbose(true)` to #report-the-error,
  instead of `DispatchErrorEvent()`. After this CL,
  WorkerGlobalScope's error event is triggered from inside V8,
  and the original exception location is plumbed through V8.

By doing so, the original exception location is passed using
V8's error rethrowing mechanism, and thus the followings are removed:

- ExecutionState
- RethrowExceptionFromImportedScript

This CL makes exceptions around cross-origin importScripts()
spec conformant:

- Previously cross-origin importScripts() throws `null` when
  there are parse errors or evaluation errors, and
  muted errors ("Script error.") is reported to
  WorkerGlobalScope error event handler.
  After this CL, it throws and reports to error event handler
  NetworkError DOMException as spec'ed. (crbug.com/1111750)
- This CL also fixes exceptions around same- and cross-origin
  importScripts() from setTimeout().

As a result of switching to `v8::TryCatch::SetVerbose(true)`,
the following things are achieved:

#2. Fire WorkerGlobalScope error events before a microtask checkpoint

Before this CL:
1. Script evaluation (top-level worker script or setTimeout(string))
2. Microtasks checkpoint in V8ScriptRunner::RunCompiledScript()
3. WorkerGlobalScope error events in EvaluateAndReturnValue()

After this CL:
1. Script evaluation (top-level worker script or setTimeout(string))
3. WorkerGlobalScope error events in v8::Script::Run()
2. Microtasks checkpoint in V8ScriptRunner::RunCompiledScript()

observable changes are: crbug/1114028 and crbug/1120293 are fixed.

#3. Fix error's `message` value.

This CL fixes the `message` field values of `Error` objects
reported to WorkerGlobalScope error events,
because the code path for `v8::TryCatch::SetVerbose(true)` handles
such cases appropriately while `DispatchErrorEvent()` doesn't.

For background and previous attempts, see crbug/590219 and
https://codereview.chromium.org/2090953006/#msg42.

#4. Use `v8::TryCatch::SetVerbose(true)` for all classic script evaluation

This makes easier to unify script evaluation code paths
(crbug.com/1111134).

An alternative considered was to switch all classic script evaluation
to `V8ScriptRunner::ReportException()`, but it would be much harder:

- We'll need to fix `V8ScriptRunner::ReportException()` and its
underlying V8 code to handle cases like #3 appropriately.
_ We'll need more subtle behavior/ordering changes, affecting
  broader range of script evaluation (i.e. not limited to workers).

Bug: 1111134, 1111750, 1114028, 1120293, 590219
Change-Id: I9395088a73ed76e241e89ce7d15e95417ca829d9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2328394
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Dominic Farolino <dom@chromium.org>
Reviewed-by: Kenichi Ishibashi <bashi@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#807341}

Disable failing story system_health.memory_mobile/load:tools:dropbox:2019
on Nexus 5X.

TBR=wenbinzhang@google.com
NOTRY=true

Bug: 1128019
Change-Id: I6ab6b976b57d644d56db92423b2881a4d27fae1d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412980Reviewed-by: John Chen <johnchen@chromium.org>
Commit-Queue: John Chen <johnchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#807340}

This reverts commit 93d899e2.

Reason for revert: Breaks on official build due to inclusion of 
//chromeos/components/telemetry*

Original change's description:
> Enable `gn check` on //chrome/browser.
> 
> Changes are:
> - adding deps when missing.
> - adding "nogncheck" when needed (see below explanation).
> - deleting nonexistent files from sources.
> - new target :net_dns_access for files that depend on
>   //net/dns:host_resolver (which has restricted visibility).
>   Alternative: could open visibility to all of //chrome/browser instead
>   of adding a new target that has visibility.
> - moving //c/b:test_support sources to //c/b/chromeos:test_support or
>   //c/test:test_support when they depended on headers there (cannot
>   add a dependency, there is a cycle).
> - moving includes to conditional sections when they are used only in
>   conditional sections (where it caused deps issues).
> - removing unused includes of test code from non-test code.
> - merging sections in //c/b/BUILD.gn that had the same if() conditions.
>   Alternative: revert these changes, they are cosmetic.
> - adding some asserts/conditional blocks in build files that only work
>   under those conditions.
> 
> "gn check" does not understand #if statements in cc/h files so it
> complains about missing deps in configurations where those deps were
> never actually included. "nogncheck" has been added to the include lines
> to suppress these spurious errors where necessary (sometimes it is not
> necessary because the include is used outside of #if statements in other
> files).
> 
> Bug: 898837, 1125897
> Change-Id: I77e7dd3780fb93edb2b555a82b681a870990b496
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2383400
> Reviewed-by: Dominick Ng <dominickn@chromium.org>
> Reviewed-by: Eric Orth <ericorth@chromium.org>
> Reviewed-by: Colin Blundell <blundell@chromium.org>
> Reviewed-by: Dirk Pranke <dpranke@google.com>
> Commit-Queue: Glen Robertson <glenrob@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#807321}

TBR=dpranke@google.com,blundell@chromium.org,dominickn@chromium.org,ericorth@chromium.org,glenrob@chromium.org

Change-Id: I13f4705899734213dd3f82fe60ac431f85584e70
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 898837
Bug: 1125897
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2413370Reviewed-by: Glen Robertson <glenrob@chromium.org>
Commit-Queue: Glen Robertson <glenrob@chromium.org>
Cr-Commit-Position: refs/heads/master@{#807339}

We will use UUIDs for the paths of shared external storage volumes
(MyFiles, removable devices) in ARC.

BUG=b:123377807
BUG=b:123641356
BUG=b:163951541
TEST=$ unit_tests --gtest_filter="FileManagerPathUtilConvertUrlTest.*"
TEST=$ unit_tests \
TEST=  --gtest_filter="NoteTakingHelperTest.LaunchAndroidAppWithPath"
TEST=Open image files in MyFiles / removable devices with the Android
TEST=Google Photos app from the Chrome OS Files app.

Change-Id: Id2166c3a793bf0eae25fbd5e07c5d1ec6b892067
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275514
Commit-Queue: Youkichi Hosoi <youkichihosoi@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: Yusuke Sato <yusukes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#807338}

Origin Trial on Android only for now.

Bug: 1032423,1096428
Change-Id: I8329c798138d800156bbe3f90de6d05f2d9662b2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404284Reviewed-by: Kentaro Hara <haraken@chromium.org>
Auto-Submit: Glen Robertson <glenrob@chromium.org>
Commit-Queue: Glen Robertson <glenrob@chromium.org>
Cr-Commit-Position: refs/heads/master@{#807337}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/52fdd1ffcefb..8e500174f4bb

2020-09-16 chanli@chromium.org [depot_tools] Roll led to latest

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/depot-tools-chromium-autoroll
Please CC apolito@google.com,ehmaldonado@google.com,sokcevic@google.com,ajp@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: chromium:1099018
Tbr: apolito@google.com,ehmaldonado@google.com,sokcevic@google.com,ajp@google.com
Change-Id: If1d95c2bf1b50ee7d3c87e271e645db5546c88b1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2413300Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#807336}

Context:
According to payment_request.idl, PaymentOptions and PaymentDetailsInit
are {} when missing, and so both impossible to be null in
non-compromised renderer.

When renderer delivers PaymentOptions to browser, it doesn't create
null for an empty PaymentOptions, so Java should expect options and
details to be non-null, reject the null cases from a compromised
renderer, and assert PaymentOptions in rest of the code to be not null.

Before this patch, the Java payment codebase does not treat null as
invalid for PaymentOptions, in many places spending extra effort in
considering this case. This CL changes the payment code to achieve
what it should be as stated above.

Change:
* Assert option not to be null in PaymentOptionsUtils.requestShipping(),
inline the method, and do the same for requestPayerName(),
requestPayerPhone(), requestPayerEmail(), getShippingType()
* CPRImpl adds invalid renderer data check for getShippingType.
* Correct the @Nullable annotation of PaymentDetails and
PaymentOptions in java payment code.

Bug: 1106563

Change-Id: I096cf67543bcba59e9555d157a093e99a47e2866
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404566
Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org>
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#807335}

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll
Please CC chonggu@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Tbr: chonggu@google.com
Change-Id: If5390bfa5184e5a83af221a6f4dfd6602b845dda
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2413302Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#807334}

https://skia.googlesource.com/skia.git/+log/d9c55ce8edbb..3e72b3ff8ca7

2020-09-16 mtklein@google.com jit q14x2 ops

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC scroggo@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Cq-Do-Not-Cancel-Tryjobs: true
Bug: None
Tbr: scroggo@google.com
Change-Id: Ib121a3b4ed3033ca56632548edccf3bb78f44ba0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2413294Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#807333}

Currently, PaintPropertyTreeBuilder makes an issue about z-order with 3D transform operations such as trasnalteZ().

So we need to check this issue on the tests whether wrong results or not.
In this patch, a test will check if rendered correctly.

Now it would be expected '[Failure]'
It will remove the expectation when we fix the issue

Bug: 1116358
Change-Id: I8f5be9e1ed186df1e779cf9e8a7f0462e079232b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409476
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#807332}

https://webrtc.googlesource.com/src.git/+log/e4642dac6c25..b10d4a612b87

2020-09-16 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 235f7418..dfb9023b (807145:807259)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/webrtc-chromium-autoroll
Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: webrtc-chromium-sheriffs-robots@google.com
Change-Id: I9ea7ad06d2bc6d1c154d7422513a07bc7a28f541
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2413295Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#807331}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/60b89e50eba2..d1be45d6b6ab

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC yoichio@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: None
Tbr: yoichio@google.com
Change-Id: Id530ec4c9fa15ac97373c0a86de96c8107505ba3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2413296Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#807330}

Add the skeleton for a new Drive zero-state provider, to eventually
replace the existing DriveQuickAccessProvider once it's finished.
Currently this does nothing and is unused, but will be expanded in
follow-up CLs.

The skeleton includes some bits of logic we'll need copied over from the
DriveQuickAccessProvider, including a check for the suggested files
flag and two weak pointer factories.

Bug: 1034842
Change-Id: Idc0883bcf5456cb2e0c1df2e838d6991eb43e458
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410142
Commit-Queue: Tony Yeoman <tby@chromium.org>
Reviewed-by: Rachel Wong <wrong@chromium.org>
Cr-Commit-Position: refs/heads/master@{#807329}

This directory has no errors now.
This CL has no behavior changes.

Bug: 800764
Change-Id: I84ec665b1e48e416ace523ac88b788cc1900b4d7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412114
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Auto-Submit: Kent Tamura <tkent@chromium.org>
Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#807328}

Add a new method to determine whether a feature flag is enabled or not.

Unfortunately, Chrome doesn't allow us to query feature flags by raw
name, only by base::Feature values. Hence, the API must use an enum
instead to represent the feature, and the implementation needs to
map the enum to a base::Feature value.

Add a feature to the enum as an example.

Bug: 1019541
Change-Id: I7e6274b70e7ba13c9bcc9dd0ee1fe3117614d06b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2397304
Commit-Queue: Darren Shen <shend@chromium.org>
Commit-Queue: Leo Zhang <googleo@chromium.org>
Reviewed-by: Leo Zhang <googleo@chromium.org>
Reviewed-by: Keith Lee <keithlee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#807327}

ExecutionContent-scoped BIB

Migrated PeriodicBackgroundSyncService interface; let it be obtained via
an ExecutionContent-scoped BrowserInterfaceBroker instead of a
Process-wide one. Then it can be controllable when prerendering a page.

Bug: 1126758
Change-Id: I8749d3bc6874ba5c04eb984642f9f1734dc8048f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412055
Commit-Queue: Lingqi Chi <lingqi@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#807326}

The stack sampler is broken for now on Arm Macs, so disable a failing
v8_unwinder unit test too.

Bug: 1102197, 1128464
Change-Id: Ie0091eb8efc7a96d4f917ed394585e1b6595c7d3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2413023Reviewed-by: Mark Mentovai <mark@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#807325}

https://chromium.googlesource.com/catapult.git/+log/0063ad80f210..511a82c95fc7

2020-09-16 heiserya@google.com Improve debugability of WPR when running record_wpr or run_benchmark.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/catapult-autoroll
Please CC zhanliang@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: None
Tbr: zhanliang@google.com
Change-Id: I69e0d50f311d7db35fe417731d46b6c6f04b647c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412766Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#807324}

Send message through AgentSchedulingGroup instead of RenderProcessHost.

Bug: 1111231
Change-Id: I24bc55d05a18da9e3f1d7eef64f593cb2b7c0e59
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409394Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Reviewed-by: Dominic Farolino <dom@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Reviewed-by: Tal Pressman <talp@chromium.org>
Commit-Queue: Minoru Chikamune <chikamune@chromium.org>
Cr-Commit-Position: refs/heads/master@{#807323}

Adapted from youkichi@'s prototype: https://chromium-review.googlesource.com/c/chromium/src/+/2275514/14

The change is simpler now after we split removable watchers to per
media watcher.

BUG=b:163951541
TEST=The images are indexed with UUID in Photos.

Change-Id: I42873445e9fb71947d029140fa9bcc4b512e8995
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409724Reviewed-by: Satoshi Niwa <niwa@chromium.org>
Commit-Queue: Risan <risan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#807322}

Changes are:
- adding deps when missing.
- adding "nogncheck" when needed (see below explanation).
- deleting nonexistent files from sources.
- new target :net_dns_access for files that depend on
  //net/dns:host_resolver (which has restricted visibility).
  Alternative: could open visibility to all of //chrome/browser instead
  of adding a new target that has visibility.
- moving //c/b:test_support sources to //c/b/chromeos:test_support or
  //c/test:test_support when they depended on headers there (cannot
  add a dependency, there is a cycle).
- moving includes to conditional sections when they are used only in
  conditional sections (where it caused deps issues).
- removing unused includes of test code from non-test code.
- merging sections in //c/b/BUILD.gn that had the same if() conditions.
  Alternative: revert these changes, they are cosmetic.
- adding some asserts/conditional blocks in build files that only work
  under those conditions.

"gn check" does not understand #if statements in cc/h files so it
complains about missing deps in configurations where those deps were
never actually included. "nogncheck" has been added to the include lines
to suppress these spurious errors where necessary (sometimes it is not
necessary because the include is used outside of #if statements in other
files).

Bug: 898837, 1125897
Change-Id: I77e7dd3780fb93edb2b555a82b681a870990b496
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2383400Reviewed-by: Dominick Ng <dominickn@chromium.org>
Reviewed-by: Eric Orth <ericorth@chromium.org>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@google.com>
Commit-Queue: Glen Robertson <glenrob@chromium.org>
Cr-Commit-Position: refs/heads/master@{#807321}

Bug: 1128703
Change-Id: I2769ea96b8982fdb3b777eebc97b558217fa7ba3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2413109
Commit-Queue: Charlene Yan <cyan@chromium.org>
Reviewed-by: Peter Boström <pbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#807320}

https://chromium.googlesource.com/webm/libvpx.git/+log/53747dfe65ea..97356acb50e2

$ git log 53747dfe6..97356acb5 --date=short --no-merges --format='%ad %ae %s'
2020-09-13 joelaf vp8: Remove sched_yield on POSIX systems
2020-09-10 sarahparker googletest: enable failure on uninstantiated tests
2020-09-09 sarahparker Upstream GTEST_ALLOW_UNINSTANTIATED_PARAMETERIZED_TEST
2020-05-11 marpan vp9-rtc: Add control to disable maxq on overshoot
2020-08-17 dcsommer Escape number sign in Makefiles
2020-08-15 jinbo-hf Refine MMI & MSA detection for mips

Created with:
  roll-dep src/third_party/libvpx/source/libvpx
R=jzern@google.com

Bug: b/168205004

Change-Id: I60a8471b89aea1c8e6ab63354f75b5dc9f10f4d6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410644
Commit-Queue: James Zern <jzern@google.com>
Reviewed-by: James Zern <jzern@google.com>
Cr-Commit-Position: refs/heads/master@{#807319}

See screen cast in bug comment 1 for a video of what is included and not
included in this CL.

Included:
  - Dragging to select a region
  - After first drag, fine tuning via affordance circles
  - Button to capture region (can be reused for fullscreen and window
    capture)
  - Switching to and from capture region source
Not included:
  - Nudge for tablet mode (see specs)
  - Motion/animations
  - Styling for buttons
  - Drop shadow for border and affordance circles
  - Partial magnifier for affordance circle presses
  - Cursor changes

The basics of this CL is to provide a UI to select a region. The
selection has two phases, a quick selection phase to quickly grab a
region, then a fine tuning phase where users can resize/reposition the
region with some drag affordances.

For a capture region session, we add two widgets to have supporting
text and buttons, and a struct that holds data needed to draw the rest
of the UI onto the layer. The layer is updated when the selection
region has been updated from drag events.

For phase two, we use a simple formula to determine which affordance
has been pressed down on, if any. If an affordance was pressed on, we
allow resizing, but one or two points stay the same. These are stored
in the struct as anchor points, and used to compute the new selection
region when there is a drag event.

Test: manual
Bug: 1120132
Change-Id: If9c461d82306666cbfa9be7fcd521bd6caeec331
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404945Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#807318}

ExecutionContent-scoped BIB

Migrated OneShotBackgroundSyncService interface; let it be obtained via
an ExecutionContent-scoped BrowserInterfaceBroker instead of a
Process-wide one. Then it can be controllable when prerendering a page.

Also fixed an error in webtest comments to make it be in accordance with
the error message.

Change-Id: I94ccdc65586b895f52f02972971338926e3b63a0
Bug: 1126758
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2395995Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Commit-Queue: Lingqi Chi <lingqi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#807317}

# This is an automated release commit.
# Do not revert without consulting chrome-pmo@google.com.
NOAUTOREVERT=true
TBR=srinivassista@chromium.org

Change-Id: I98043309b61ae24020ae796aff44c724474fb786
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2413024Reviewed-by: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#807316}

This CL removes logic that updated bubble visibility based on generic
RenderFrameHost update notifications. Instead the UI will be shown
when the Tab Search WebUI has notified us that the UI is ready to be
shown.

This eliminates stuttering caused by the bubble being shown when the
initial DOM was ready, but the tab list was still loading in.

Bug: 1099917
Change-Id: I40b592adcae38d6f21a60d79a0beab2d08970b7e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386426
Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Reviewed-by: Collin Baker <collinbaker@chromium.org>
Cr-Commit-Position: refs/heads/master@{#807315}

As content::WebPreferences was moved to Blink, we don't
need to keep AutoplayPolicy enum in WebSettings because
we can use it from WebPreferences directly.

Bug: 919392, 1097943
Change-Id: Ied0db3fa771416fcc5ce35f5c0a14889dcfa0866
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409690Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com>
Cr-Commit-Position: refs/heads/master@{#807314}

TBR=bling-team@google.com

Change-Id: Id950215e11501e726bfd7578f49203fdac70481f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2413113Reviewed-by: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#807313}

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/goldctl-linux-chromium-autoroll
Please CC bsheedy@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: bsheedy@chromium.org
Change-Id: I7a90b696047bb1a94bfcbcc868941a1341afbe55
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412764Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#807312}

Per the spec issue [1], this change disallows the use of
ElementInternals.shadowRoot for shadow roots created prior
to the custom element constructor being run. This protects
potentially-closed shadow roots, created outside of the
custom element, from being revealed to the custom element
itself. (Use case unclear, but this was the request.)

[1] https://github.com/w3c/webcomponents/issues/871

Bug: 1042130
Change-Id: I25192256e8b1334d09ea587f29d64f35d4f5f949
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412470
Commit-Queue: Kouhei Ueno <kouhei@chromium.org>
Auto-Submit: Mason Freed <masonfreed@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#807311}

Roll Chrome Win64 PGO profile from chrome-win64-master-1600148958-91c0cd454c0f8748eee83f19943ecba0f6b92ac0.profdata to chrome-win64-master-1600192792-f4ca908cacd319b04516240c34a315b960a046b2.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium
Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:win64-chrome
Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com
Change-Id: I1debf74aef82c162c05a6885ec49ffb71db21a42
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412787Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#807310}

https://skia.googlesource.com/skia.git/+log/9791e50e3da4..d9c55ce8edbb

2020-09-16 mtklein@google.com disable show-your-work bit of test

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC scroggo@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Cq-Do-Not-Cancel-Tryjobs: true
Bug: None
Tbr: scroggo@google.com
Change-Id: I41bd80f4666ac6468e45cfa6979f306539057ba9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412765Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#807309}

Both creaters of desk animations have a guard to stop creation of a new
animation. For enhanced desk animations, we will append to an existing
animation, so a vector is not needed anymore.

Test: manual
Bug: 1111445
Change-Id: Ic615e73cc28ac9bb1e7746782a1455c90e11a2a7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412687Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#807308}

This CL is a follow-up CL of converting
PrintHostMsg_DidGetPrintedPagesCount to mojo [1] and it updates the
type for the page number and counts with uint32_t as it couldn't
have a negative value.

It keeps using int for JNI and dictionary values and uses
'base::checked_cast<int>' to convert uint to int. In order to make
sure that the value is in the range to cast, this change also adds
the maximum limit for the page number and counts and checks the
value before passing it to JNI or dictionary. Given that the previous
type is int, the maximum limit is std::numeric_limits<int>::max().

[1] https://crrev.com/c/2326857

Bug: 1008939
Change-Id: I5c86514be4e7d549f888c9623136078a3b0c88c4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351580Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Julie Kim <jkim@igalia.com>
Cr-Commit-Position: refs/heads/master@{#807307}

The target is missing a dependency and cannot be built in isolation.

Bug: 1127044
Change-Id: I80b53f0d499e999182a2fc4daf6e24dac721b6c4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404741
Auto-Submit: Fabrice de Gans-Riberi <fdegans@chromium.org>
Commit-Queue: Nate Chapin <japhet@chromium.org>
Reviewed-by: Nate Chapin <japhet@chromium.org>
Cr-Commit-Position: refs/heads/master@{#807306}