GitLab

It seems in certain cases font fallback returns a fontconfig interface
id which can then later not be reused by Skia. This patch fixes an
incorrect fallback to using the family in that case and returns a nullptr
instead, which fixes the assertion failure. However, we need to
investigate why the Skia typeface creation with the returned
fciId is unsuccessful, filed crbug.com/403348 for this remaining question.

BUG=273261
R=eae,eseidel

Review URL: https://codereview.chromium.org/470493003

git-svn-id: svn://svn.chromium.org/blink/trunk@180214 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch adds the flag 'animatable' to CSSProperties.in, replacing the
existing switch statement in CSSAnimations.cpp. Setting the flag
indicates that the property can be animated by CSS animations and
transitions.

The added code will generate a function in CSSPropertyMetadata, which
will eventually also support functions like isInheritedProperty and
isValidFirstLetterStyleProperty. This means that the individual lines in
CSSProperties.in may start getting a bit long, although a centralized
specification of our supported CSS properties arguably helps developers
add new CSS properties, by reducing the lines they need to add and
adding documentation on what changes need to be made.

BUG=396992

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180039

Review URL: https://codereview.chromium.org/454423003

git-svn-id: svn://svn.chromium.org/blink/trunk@180213 bbb929c8-8fbe-4397-9dbb-9b2b20218538

not implemented and never used.

R=derat@chromium.org

Review URL: https://codereview.chromium.org/469873002

git-svn-id: svn://svn.chromium.org/blink/trunk@180210 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This CL removes the use of repaint in core/rendering/compositing in favour
of paintInvalidation.

BUG=338691

Review URL: https://codereview.chromium.org/468343002

git-svn-id: svn://svn.chromium.org/blink/trunk@180209 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The objective of this test to assert text returned from a SelectAll call on WebContent is same as text from WebLocalFrame::ContentAsText.

This is a patch that refers to the following CL
https://codereview.chromium.org/342143004/

Review URL: https://codereview.chromium.org/464613003

git-svn-id: svn://svn.chromium.org/blink/trunk@180208 bbb929c8-8fbe-4397-9dbb-9b2b20218538

A Skia roll has landed which reverts part of the change which caused this to start failing.


git-svn-id: svn://svn.chromium.org/blink/trunk@180207 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=388517

Review URL: https://codereview.chromium.org/466223002

git-svn-id: svn://svn.chromium.org/blink/trunk@180206 bbb929c8-8fbe-4397-9dbb-9b2b20218538

    
Some IndexedDB classes (IDBCursor, IDBRequest, IDBTransaction, and
IDBVersionChangeEvent) were using static local AtomicStrings on different
threads. This is safe, as long as these static strings are properly
created - which they were not. Switching to an initialization mechanism
which mirrors the Core static strings fixes this.

BUG=393728

Review URL: https://codereview.chromium.org/426063010

git-svn-id: svn://svn.chromium.org/blink/trunk@180205 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The patch does the following:
- adds tooltip for the "Insert New Rule" button
- repositions button via absolute positioning
- does not show "via inspector" title in "Insert New Rule" if it's going
to be added in actual stylesheet.

R=pfeldman, vsevik
BUG=402461

Review URL: https://codereview.chromium.org/468973002

git-svn-id: svn://svn.chromium.org/blink/trunk@180204 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TBR=zerny@chromium.org

Review URL: https://codereview.chromium.org/470703002

git-svn-id: svn://svn.chromium.org/blink/trunk@180203 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch is a hackish way to bring developer tools front-end to front
whenever Toolbox revealer asks to reveal something.

BUG=399259
R=pfeldman

Review URL: https://codereview.chromium.org/468193002

git-svn-id: svn://svn.chromium.org/blink/trunk@180202 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Cleanup blink:: prefix usage in Source/core/modules/[mediasource/*.cpp to websockets/*.cpp]

- Merge multiple |namespace blink {}| blocks
- Remove unnecessary blink:: prefixes
- Make blank lines consistent

BUG=None

Review URL: https://codereview.chromium.org/469773002

git-svn-id: svn://svn.chromium.org/blink/trunk@180201 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Previously, we could try to paint without having our painting state up-to-date.
The codepath for printing multiple pages updatesLayoutAndStyleForPainting. This
CL makes the code path for printing single pages do the same.

R=adamk@chromium.org

Review URL: https://codereview.chromium.org/471623003

git-svn-id: svn://svn.chromium.org/blink/trunk@180200 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=

Review URL: https://codereview.chromium.org/472453002

git-svn-id: svn://svn.chromium.org/blink/trunk@180199 bbb929c8-8fbe-4397-9dbb-9b2b20218538

DevTools: [network] make timing colors consistent in popover and tab, remove box shadows and round borders.

R=eustas@chromium.org, vsevik@chromium.org

Review URL: https://codereview.chromium.org/474453002

git-svn-id: svn://svn.chromium.org/blink/trunk@180198 bbb929c8-8fbe-4397-9dbb-9b2b20218538

In ES6, these are now allowed in both strict and sloppy mode.

These tests will fail when v8:3498 lands and gets rolled.

BUG=403353
R=dpranke@chromium.org

Review URL: https://codereview.chromium.org/467903003

git-svn-id: svn://svn.chromium.org/blink/trunk@180197 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=
NOTRY=true

Review URL: https://codereview.chromium.org/469673004

git-svn-id: svn://svn.chromium.org/blink/trunk@180196 bbb929c8-8fbe-4397-9dbb-9b2b20218538

NOTRY=true

Review URL: https://codereview.chromium.org/468203002

git-svn-id: svn://svn.chromium.org/blink/trunk@180195 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http/tests/security/mixedContent/insecure-audio-video-in-main-frame.html is leaking Resource (flaky)

TBR=hajimehoshi@chromium.org,tkent@chromium.org
NOTRY=true
BUG=403367

Review URL: https://codereview.chromium.org/466373003

git-svn-id: svn://svn.chromium.org/blink/trunk@180194 bbb929c8-8fbe-4397-9dbb-9b2b20218538

It does nothing as of Blink r178756:
https://codereview.chromium.org/414443006

It's never set as of Chromium r289294:
https://codereview.chromium.org/449393002

BUG=401887

Review URL: https://codereview.chromium.org/453813003

git-svn-id: svn://svn.chromium.org/blink/trunk@180193 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This CL updates the usage of repaint to be paintInvalidation inside the
various style/ classes.

BUG=338691

Review URL: https://codereview.chromium.org/470633002

git-svn-id: svn://svn.chromium.org/blink/trunk@180192 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Remove the specialized code for tracking touch events in favor of the
generic EventHandlerRegistry. Covered by existing tests.

See https://codereview.chromium.org/206603002/ for full review history.

BUG=347366
TEST=fast/events/touch*

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177812

Review URL: https://codereview.chromium.org/225903009

git-svn-id: svn://svn.chromium.org/blink/trunk@180191 bbb929c8-8fbe-4397-9dbb-9b2b20218538

DevTools: Make sure ElementsTreeOutline is correctly rendered when element's hasChildren state changes.

R=pfeldman,apavlov

Review URL: https://codereview.chromium.org/467233002

git-svn-id: svn://svn.chromium.org/blink/trunk@180190 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This ASSERT is triggering in some print previous browser_tests. I'm disabling
it temporarily while I investigate.

R=adamk@chromium.org

Review URL: https://codereview.chromium.org/470653002

git-svn-id: svn://svn.chromium.org/blink/trunk@180189 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This change did not contain the bug it just made it much more likely that we would see it. Reapplying (again). :)

original description:

"[oilpan]: Change marking to do precise roots first and conservative second.

This way we avoid conservatively scanning objects that were reachable through precise pointers."

Review URL: https://codereview.chromium.org/468083002

git-svn-id: svn://svn.chromium.org/blink/trunk@180188 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Following a discussion on the lack of support for <picture><source src></picture> 
that happened on https://github.com/ResponsiveImagesCG/picture-element/issues/224 
I would like to add a console warning to guide authors away from this pattern.

BUG=403260

Review URL: https://codereview.chromium.org/466353002

git-svn-id: svn://svn.chromium.org/blink/trunk@180187 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=316092

Review URL: https://codereview.chromium.org/467143002

git-svn-id: svn://svn.chromium.org/blink/trunk@180186 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Apparently you can spell words with uppercase characters as well as
lower case characters.

BUG=338691

Review URL: https://codereview.chromium.org/468933002

git-svn-id: svn://svn.chromium.org/blink/trunk@180185 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=391593

Review URL: https://codereview.chromium.org/472483002

git-svn-id: svn://svn.chromium.org/blink/trunk@180184 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Review URL: https://codereview.chromium.org/462403002

git-svn-id: svn://svn.chromium.org/blink/trunk@180183 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Cleanup namespace usage in Source/core/{dom/* and fileapi/*}

- Remove unnecessary blink:: prefixes
- Make blank lines consistent

BUG=None

Review URL: https://codereview.chromium.org/460393003

git-svn-id: svn://svn.chromium.org/blink/trunk@180182 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=

Review URL: https://codereview.chromium.org/468123002

git-svn-id: svn://svn.chromium.org/blink/trunk@180181 bbb929c8-8fbe-4397-9dbb-9b2b20218538

- Split compilation of private scripts from running installClass(), in order to distinguish a compile error with a runtime error that happens in installClass().

- Added ScriptOrigin to private scripts. By doing this, dumpV8Message() can print a file name and a line number where an error is triggered.

- Refactored PrivateScriptRunner.cpp a bit.

This just affects fprintf(stderr) and doesn't change any web-exposed behavior.

BUG=341031

Review URL: https://codereview.chromium.org/465283002

git-svn-id: svn://svn.chromium.org/blink/trunk@180180 bbb929c8-8fbe-4397-9dbb-9b2b20218538

To allow the embedder to distinguish POST requests emanating from
sendBeacon() from those from a <a ping>, assign a more precise target
type to the former.

This is done in preparation for adding Beacon-Age: headers to Beacon
requests.

R=mkwst@chromium.org
BUG=398167

Review URL: https://codereview.chromium.org/468853002

git-svn-id: svn://svn.chromium.org/blink/trunk@180179 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This is required to introduce a new "toolbox" application
within the new application loading scheme.

R=dgozman, pfeldman, vsevik
BUG=391566

Review URL: https://codereview.chromium.org/460673003

git-svn-id: svn://svn.chromium.org/blink/trunk@180178 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=sergeyv@chromium.org

Review URL: https://codereview.chromium.org/464343002

git-svn-id: svn://svn.chromium.org/blink/trunk@180177 bbb929c8-8fbe-4397-9dbb-9b2b20218538

See: https://codereview.chromium.org/449893002

BUG=
TBR=vsevik@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/471553003

git-svn-id: svn://svn.chromium.org/blink/trunk@180176 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Currently console gets scrolled to bottom whenever it gets resized.
The patch fixes this erroneous behavior.

R=vsevik, pfeldman

Review URL: https://codereview.chromium.org/462083002

git-svn-id: svn://svn.chromium.org/blink/trunk@180175 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Review URL: https://codereview.chromium.org/470553002

git-svn-id: svn://svn.chromium.org/blink/trunk@180174 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=ager@chromium.org, haraken@chromium.org
BUG=402426
NOTRY=true

Review URL: https://codereview.chromium.org/464283002

git-svn-id: svn://svn.chromium.org/blink/trunk@180173 bbb929c8-8fbe-4397-9dbb-9b2b20218538