- 12 Jan, 2021 40 commits
-
-
Josh Simmons authored
Expiry set to M92 for features such as Gallery and the Chrome Web Store dialog which will be deprecated or changed in the near future. Expiry set to M98 (slightly more than 1 year) for core metrics that are unlikely to be removed any time in the future. Bug: 1153738 Change-Id: I969265828bdeb0190a61d0e3cdd9ec4a689a67e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612871Reviewed-by:
Naoki Fukino <fukino@chromium.org> Reviewed-by:
Caitlin Fischer <caitlinfischer@google.com> Commit-Queue: Naoki Fukino <fukino@chromium.org> Cr-Commit-Position: refs/heads/master@{#842411}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/82b992a1656d..59b0ce20d3e5 2021-01-12 yyanagisawa@chromium.org Roll out new goma client binary VERSION=210 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: I8f7339232f66c05fbc49ca6e381cdd28a9ccc6dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623795Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#842410}
-
Yang Guo authored
Fixed: 1153862 Change-Id: If3dd79e6861164eb8d062cac4367cbffe2622c55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2605760Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Mark Pearson <mpearson@chromium.org> Auto-Submit: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#842409}
-
Regan Hsu authored
After the user successfully completes the PhoneHub Notifications setup flow in OS Settings, the feature will now be enabled automatically. Fixed: 1164973 Bug: 1106937 Change-Id: I7b59b5b8a19aabffe034763367c801288a43898d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622737Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Regan Hsu <hsuregan@chromium.org> Cr-Commit-Position: refs/heads/master@{#842408}
-
Matt Falkenhagen authored
ServiceWorkerSubresourceLoader::FollowRedirect() seems to be be getting called when there is no redirect_info_. Add crash keys to see whether a redirect was already followed, or was never received, or if something has gone wrong in the loader's state transitions. Bug: 1162035 Change-Id: I23ff73ca932d8ada60fe8156c9c33a132db42575 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617527Reviewed-by:
Asami Doi <asamidoi@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#842407}
-
Rainhard Findling authored
A small code health refactoring that: * Removes the redundant |SAFETY_CHECK| prefix as well as the additional |MANAGE_THROUGH| and |REVIEW_THROUGH| from some of the safety check metrics histogram variable names in metrics browser proxy. * Extends the |REVIEW_COMPROMISED_PASSWORDS| metric variable name for better clearity. Bug: 1015841 Change-Id: I032cc5c043acb961cb31d8feb69e4b9781618eb5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600738Reviewed-by:
Rainhard Findling <rainhard@chromium.org> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Commit-Queue: Rainhard Findling <rainhard@chromium.org> Cr-Commit-Position: refs/heads/master@{#842406}
-
Rainhard Findling authored
Add separate metrics for clicks on the safety check password check child in case weak but no compromised password have been found, so that compromised, weak only, and other cases can be distinguished. Bug: 1015841 Change-Id: I81904ac412088584cfbc9cff128e1de09e2ff81f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2599865Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/026943fd29be..53a231c0ae86 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I6586aaa57716fe7f0a4ccfb2175bf29716952ad1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622714Reviewed-by:
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-chrome TBR=chrome-os-gardeners@google.com Change-Id: I0aeccbb16345b860c646c763ed2ba6be187bc17b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623716Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#842403}
-
Regan Hsu authored
* Remove gap between rows in "Connect to Network" page. * eSIM cellular network list will have 8px padding top and bottom. * Add fake esim pending profile to fake hermes manager client. Screenshots (Note that the background colors are not part of the CL and are only there for visualization of different network row types): https://drive.google.com/drive/folders/1iMszYFuCE_HDxIVWUcbgi8QnNjzLwqHn?usp=sharing Fixed: 1162054 Change-Id: I904cb9d94fdef9e07968953807d209be3c5a77d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612521 Commit-Queue: Regan Hsu <hsuregan@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/026943fd29be..53a231c0ae86 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Id5a9e1766d5284f3b1b69b88a5230512b86db630 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622715Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/goldctl-win-chromium-autoroll Please CC bsheedy@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: bsheedy@chromium.org Change-Id: I9c5f284a6e1d10f526449574ce96df9f5a1b2225 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623788Reviewed-by:
-
Minoru Chikamune authored
This CL renames compositor_task_runner to compositor_task_queue when the type says it's queue. Bug: 1105403 Change-Id: I713784d2b42bc80aa3aa7d3fe6afabb98fa077e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617685Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Minoru Chikamune <chikamune@chromium.org> Cr-Commit-Position: refs/heads/master@{#842399}
-
chromium-autoroll authored
https://dawn.googlesource.com/tint.git/+log/1d9935cf37fd..987376cd21a8 2021-01-12 dsinclair@chromium.org Revert the namer changes. 2021-01-12 dsinclair@chromium.org Add a Unsafe SPIR-V generate call. 2021-01-11 dsinclair@chromium.org Update new entry points to use correct namer. 2021-01-11 bclayton@google.com Add std::hash<tint::Symbol> specialization 2021-01-11 bclayton@google.com TypeDeterminer: Fix type map iterations 2021-01-11 bclayton@google.com Add diag::Formatter::Style::print_newline_at_end 2021-01-11 bclayton@google.com Implement textureDimensions() 2021-01-11 dsinclair@chromium.org Fix const-ness of inspector constructor. 2021-01-11 dneto@google.com Fix doxygen comment 2021-01-11 dneto@google.com spirv-reader: convert arity of textureLoad on depth texture 2021-01-11 dj2@everburning.com Switch default to the MangleNamer. 2021-01-11 dj2@everburning.com Allow setting the namer into the inspector. 2021-01-11 dj2@everburning.com Change generators to take a pointer instead of move. 2021-01-11 dj2@everburning.com Use TestNamer in the SPIR-V backend. 2021-01-11 dj2@everburning.com Use TestNamer in HLSL tests. 2021-01-11 dj2@everburning.com Use a test namer in the MSL generator. 2021-01-11 dj2@everburning.com Remove name fields 2021-01-11 dj2@everburning.com Remove IdentifierExpression::name(). 2021-01-11 dj2@everburning.com Remove Function::name(). 2021-01-11 dj2@everburning.com Remove StructMember::name(). 2021-01-11 dj2@everburning.com Remove StructType::name() 2021-01-11 dj2@everburning.com Remove the AliasType::name() getter. 2021-01-11 dj2@everburning.com Remove Variable::name(). 2021-01-11 dj2@everburning.com Use the top level namer in the SPIR-V backend. 2021-01-11 dj2@everburning.com Use namer in the Inspector. 2021-01-11 dj2@everburning.com Convert HLSL to higher level namer. 2021-01-11 dj2@everburning.com Convert MSL generator to unsafe namer. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/tint-chromium-autoroll Please CC dsinclair@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: dsinclair@google.com Change-Id: I27e45b9e32620e7933bec51ef29d24b26a160ef2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623789Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/43ed322b..4281a3f2 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I8d34c0ea287367f7896ccaa0a1b78c4aa88b9863 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623715Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#842397}
-
Tibor Goldschwendt authored
Tests ModuleDescriptor.initialize, which is the only function of that class with non-trivial logic. Adding tests is a precursor to making changes to that class in subsequent CLs. Change-Id: Ib023f014f21e547bcbf38776781a95b6d83b3e2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623653 Auto-Submit: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
-
Nick Diego Yamane authored
So far, a RepeatingTimer is used to abort the ClipboardOzone's requests and it's not being properly stopped when it's triggered (timeout). This switches to a OneShotTimer as well as resets pending_request_ after the internal run loop quits, so covering both the successful and abortion cases. R=dcheng@chromium.org Bug: 1165466 Change-Id: I5e7108b93999aa4632a2834b1667cf75aa7d1cb9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622285Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Nick Yamane <nickdiego@igalia.com> Cr-Commit-Position: refs/heads/master@{#842395}
-
cfredric authored
This brings the implementation into alignment with the final paragraph of https://github.com/cfredric/sameparty#sameparty-vs-samesite-enforcement-modes, which states that if a site is not a member of a First-Party Set, its cookies will be subject to SameSite rules, rather than SameParty rules. Bug: 1143756 Change-Id: Ie4c9066c874d9e7a42a6d8504f33d4b6e669ff7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613194Reviewed-by:
Ayu Ishii <ayui@chromium.org> Reviewed-by:
Maksim Orlovich <morlovich@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Lily Chen <chlily@chromium.org> Commit-Queue: Chris Fredrickson <cfredric@chromium.org> Cr-Commit-Position: refs/heads/master@{#842394}
-
Yunke Zhou authored
Bug: 1130502 Change-Id: I7ac24f02a9ef1b41a7c3a25641069c38d85bee78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2620260Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Yunke Zhou <yunkez@google.com> Cr-Commit-Position: refs/heads/master@{#842393}
-
Shengsong Tan authored
This is part of the "Views Posse" effort. See this document: https://docs.google.com/document/d/1Rst3792TjXtVA8k8GXaPD8MnuB1JAneSOpIILdA4268/edit?usp=sharing Bug: 1159562 Test: build Change-Id: I776e58dc007726678b1a4d05ee0be8c91c2b6cf2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2601022 Commit-Queue: Shengsong Tan <sstan@google.com> Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#842392}
-
Yoichi Osato authored
TBR=paulirish@chromium.org Bug: 1163793 Change-Id: Ib5de555db523a6aaf48d4829b3323b8e3c8e22cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623731 Commit-Queue: Yoichi Osato <yoichio@chromium.org> Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#842391}
-
Michael Bai authored
- Records if AwG is current Android autofill service. - Records if and when the server type predication is available when feature is enabled. - Records if AwG provides the suggestion and if user accepts the suggeston. Bug: 1151542 Change-Id: I246aee27cdef757902351a5e43973bea2e6f15e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612220 Commit-Queue: Michael Bai <michaelbai@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Shimi Zhang <ctzsm@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#842390}
-
Luciano Pacheco authored
Generate JS modules for file in //ui/file_manager/file_manager/foreground/js/ui, files: - multi_menu.js - mult_menu_button.js - munit_menu_unittest.m.js Bug: 1133186 Change-Id: I9cdd0b22118a2ae7bc578aae40c5eeb16022759c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2621856Reviewed-by:
Jeremie Boulic <jboulic@chromium.org> Commit-Queue: Jeremie Boulic <jboulic@chromium.org> Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#842389}
-
Nancy Wang authored
Modify the full restore component parameter to use the consistent parameter name 'profile_path'. BUG=1146900 Change-Id: I9dadccd5811eb1ad56c9e01149941a65ff8912cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2620119 Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#842388}
-
Jonah Chin authored
This reverts commit 4107e01f. Reason for revert: https://crbug.com/1164407 This CL is to test if this codepath can be reverted, or if follow up code depends on it too much. Original change's description: > Change texture subset logic in PaintCanvasVideoRenderer > > This CL is to simplify how PaintCanvasVideoRenderer::Cache manages > video frames whose |visible_rect| is smaller than their |coded_size|. > By always using SkImage::MakeFromAdoptedTexture, texture lifetime > management is now always handled internally by skia. This will make the > transition to OOPR here much simpler. > > More details about overall PaintImage effort: crbug.com/1023259 > Info about the OOPR-Canvas2D project: crbug.com/1018894 > > Bug: 1115217 > Change-Id: I2177b2deeea893fa5331afbe8796761253db2759 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2451213 > Commit-Queue: Jonah Chin <jochin@microsoft.com> > Reviewed-by: Dale Curtis <dalecurtis@chromium.org> > Reviewed-by: Khushal <khushalsagar@chromium.org> > Cr-Commit-Position: refs/heads/master@{#818045} TBR=dalecurtis@chromium.org,khushalsagar@chromium.org,jochin@microsoft.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1164407 Change-Id: Icf21a46f0917345030942d35ba77b58557b5f72c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2621783Reviewed-by:
Jonah Chin <jochin@microsoft.com> Commit-Queue: Jonah Chin <jochin@microsoft.com> Cr-Commit-Position: refs/heads/master@{#842387}
-
Louise Brett authored
Bug: 1157273 Change-Id: I5531b30ccc8c2ce4d956c67880d1a74d93754073 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2619243Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Commit-Queue: Louise Brett <loubrett@google.com> Cr-Commit-Position: refs/heads/master@{#842386}
-
Cammie Smith Barnes authored
This CL is part of the Code Health Rotation (https://sites.google.com/corp/google.com/chrome-code-health/) and changes the two remaining occurrences in chrome/test/base of base::Closure to base::OnceClosure, as they are used in a waiter method that can only be invoked once. Bug: 1007643 Change-Id: If7040fe9041e88cfa89314224d98423aa6696432 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623193Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Cammie Smith Barnes <cammie@chromium.org> Cr-Commit-Position: refs/heads/master@{#842385}
-
Caroline Rising authored
Bug: 1163938 Change-Id: I03c223c41de3196be12d9d4283087dfa04ec38e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2621676Reviewed-by:
Connie Wan <connily@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Caroline Rising <corising@chromium.org> Cr-Commit-Position: refs/heads/master@{#842384}
-
David Bertoni authored
Service Worker support is now available in the Stable channel, so there is no longer a need for channel overrides. Bug: 1165397 Change-Id: Ie5a7e5a0b58814b40bcb94f437b784904f6164f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612028Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: David Bertoni <dbertoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#842383}
-
Tsuyoshi Horo authored
This member variable was introduced for Service Worker link registration by https://codereview.chromium.org/1781783002. Service Worker link registration was removed from the specification. And the logic was removed by http://crrev.com/c/792731. So this variable is not used anymore. Bug: 788604 Change-Id: Ieaf4f3cb31526d9767f4a6666f2c26a1109d0605 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622357Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Auto-Submit: Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#842382}
-
Sara Kato authored
Bug: 1159562 Test: build Change-Id: I9619c4861c34dc6bcd537d752b4b57602ec4fdd6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2615722 Commit-Queue: Sara Kato <sarakato@chromium.org> Auto-Submit: Sara Kato <sarakato@chromium.org> Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Reviewed-by:
-
Reilly Grant authored
This change expands the manual test for transferIn() to send much more data and assert that many overlapping transfers will still complete in the correct order. Two changes are necessary to make these tests pass. First, when aborting a transfer on device close the ERROR_REQUEST_ABORTED should be mapped to an AbortError DOMException. Second, transfers should be tracked in a list rather than a map so that iteration order is well defined. Bug: 1153647 Change-Id: I248ce4724e391216783a6873809aca43e4690b96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2591928 Commit-Queue: Reilly Grant <reillyg@chromium.org> Reviewed-by:
James Hollyer <jameshollyer@chromium.org> Cr-Commit-Position: refs/heads/master@{#842380}
-
Harry Cutts authored
Bug: none Test: check virtual keyboard still appears with drawing tablets connected to a device in tablet mode, and that buttons on the drawing tablet (if any) still work. Change-Id: I7502a585443bda79c448c46e379703258d62ba81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622759Reviewed-by:
Michael Spang <spang@chromium.org> Commit-Queue: Michael Spang <spang@chromium.org> Auto-Submit: Harry Cutts <hcutts@chromium.org> Cr-Commit-Position: refs/heads/master@{#842379}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/de32c3d2de00..2c65da28a2ee 2021-01-12 natsu@google.com Default roll_aosp.sh to copy artifacts to vendor partition 2021-01-12 jmadill@chromium.org Vulkan: Use angle::FormatID instead of VkFormat. 2021-01-11 stha09@googlemail.com libstdc++: fix incomplete type for FramebufferCache If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: chromium:957519 Tbr: timvp@google.com Test: Test: ./scripts/roll_aosp.sh and build in AOSP Change-Id: Id14dfd0c2c2df4159dcb6a052a826ca031b9323c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622299Reviewed-by:
-
Ian Kilpatrick authored
Previously if our initial block-size was indefinite, and we were a flexbox - we'd apply a series of additional invalidations to ensure correctness. These are cases where we can't guarantee "trust" in the value of NGLayoutResult::IntrinsicBlockSize, as it depends on "extrinsic" constraints such as a parent forcing a fixed-block-size or a %-block-size changing. In an upcoming patch, there are more cases where we treat an *initial* block-size as indefinite, even though ComputeBlockSizeForFragment will return a definite size. E.g. there will be a difference between ComputeBlockSizeForFragment, and ComputeInitialBlockSizeForFragment. This change makes the cache more precise in the above case, by always calling ComputeBlockSizeForFragment, but (importantly) giving an indefinite intrinsic-block-size where we can't trust NGLayoutResult::IntrinsicBlockSize. Bug: 1033476 Change-Id: I798fe7d50247a4eec0131ec46061b33484347e8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2621976 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
David Grogan <dgrogan@chromium.org> Cr-Commit-Position: refs/heads/master@{#842377}
-
Corentin Wallez authored
This avoids doing the conversion from WTF::String to an enum once in the Blink bindings and once in the WebGPU module. Bug: chromium:852089 Change-Id: I8765631c2b0562bdabfc6af246cab0453de63593 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2621754 Auto-Submit: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Kai Ninomiya <kainino@chromium.org> Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Austin Eng <enga@chromium.org> Cr-Commit-Position: refs/heads/master@{#842376}
-
Yoichi Osato authored
This reverts commit f4b58578. Reason for revert: caused layout test CRASH: https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20Tests%20(dbg)(1)/94262/overview Original change's description: > service worker: Simplify main resource "handler" & "interceptor" (3/3) > > Bug: 1138155 > Change-Id: Iafb12ae9de19e68e637e7fb990bb8439ec4df848 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2602307 > Reviewed-by: Asami Doi <asamidoi@chromium.org> > Commit-Queue: Matt Falkenhagen <falken@chromium.org> > Cr-Commit-Position: refs/heads/master@{#842305} TBR=falken@chromium.org,mstensho@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com,asamidoi@chromium.org Change-Id: I5b4756817dd149a9f721c5aaeb2da54aadaf4308 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1138155 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623572Reviewed-by:
-
Zufeng Wang authored
Makes subcategories searchable, but they don't appear in the search result snippets. Bug: b/172533871 Change-Id: I6b1e053929bc1a4ecada135ae582a5deba1e673a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2620740 Commit-Queue: Zufeng Wang <zufeng@google.com> Reviewed-by:
dstockwell <dstockwell@google.com> Cr-Commit-Position: refs/heads/master@{#842374}
-
Clark DuVall authored
This was reverted because the latest androidx.lifecycle library performs thread checks in the ComponentActivity constructor. The constructor calls LifecycleRegistry.addObserver(), so we can just override that method and make it a no-op when loading on a background thread. Bug: 1150600, 1160614 Change-Id: I52e6eb63ce0b4a9c90c002fe34281298b02ef9d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622005Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#842373}
-
Alan Cutter authored
This CL does 3 things: - Hides the Extensions menu item from web app windows when no Extensions are installed. - Fixes a bug exposed by the updated test where the Extensions puzzle piece would show when an Extension was installed due to the layout animation. - Addresses comments from https://chromium-review.googlesource.com/c/chromium/src/+/2602305 Bug: 1164829 Change-Id: I75e3fc5e8a7262316947b7322b825a10be3bb848 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2621512 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#842372}
-
