- 29 Aug, 2019 40 commits
-
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/8624d125dc22..8c4bce8edcd8 Created with: gclient setdep -r src-internal@8c4bce8edcd8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I0c5577190c88779203b548a9c8e85e9993fdc4bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775579Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#691442}
-
Wez authored
Configurations to attach an async:Loop to be the default dispatcher for the current thread are being moved to a dedicated libasync-loop-default package, and renamed. Bug: fuchsia:31742 Change-Id: Ie141bee150f5a614fe04e043df13500bcefcb5e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775387 Commit-Queue: Wez <wez@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Auto-Submit: Wez <wez@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#691441}
-
Eric Foo authored
This is CL is generated by a script. Data is pulled from review conducted in Q2 2019. See https://tinyurl.com/yxau5sc4 for context. Using TBR due to pexpect/OWNERS owners no longer in Chrome. Received LGTM from simonhatch@ and all other OWNERS. NOPRESUBMIT=true TBR=tonyg@chromium.org Bug: 977050 Change-Id: I3171c6b2aadafbdee6acc71b645d009134d11bb9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700828Reviewed-by:
Simon Hatch <simonhatch@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Commit-Queue: Eric Foo <efoo@chromium.org> Auto-Submit: Eric Foo <efoo@chromium.org> Cr-Commit-Position: refs/heads/master@{#691440}
-
Leon Han authored
According to spec at https://w3c.github.io/web-nfc/#web-nfc-author-records-tnf-4, this CL changes it from "w3.org:webnfc" to "w3.org:A". BUG=520391 Change-Id: Ieb422420bc860f90f43fb7ce97b87961daf9b52a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769488 Commit-Queue: Leon Han <leon.han@intel.com> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Rijubrata Bhaumik <rijubrata.bhaumik@intel.com> Cr-Commit-Position: refs/heads/master@{#691439}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/63655b5a21eb..a4b448831cee git log 63655b5a21eb..a4b448831cee --date=short --no-merges --format='%ad %ae %s' 2019-08-28 michaelludwig@google.com Reland "Calculate draw bounds in drawEdgeAAImageSet" 2019-08-28 michaelludwig@google.com Reland "Combine snapBackImage and snapSpecial" 2019-08-28 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-08-28 brianosman@google.com Revert "Pin the GLSL version to be no larger than the GL version" 2019-08-28 michaelludwig@google.com Fix non-zero special-image subsets in magnifier filter 2019-08-28 michaelludwig@google.com Revert "Fix flutter roll" 2019-08-28 scroggo@google.com SkAnimatedImage: Update HEIF duration 2019-08-28 jvanverth@google.com Implement fences and semaphores for Metal. Created with: gclient setdep -r src/third_party/skia@a4b448831cee If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC stani@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=stani@google.com Bug: chromium:139815242 Change-Id: I6208b81128808494ce739953c46fe78a955c9e4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775275Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#691438}
-
Aaron Colwell authored
This sets |origin_to_commit| to an opaque origin with precursor information that is consistent with the URL we were trying to navigate to. This allows the origin at commit time to match the commit URL in situations where we end up displaying an error page in response to a navigation. Bug: 991607 Change-Id: I3aee10268be70f9cc500fbecd638e587bc0bd7c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768711 Commit-Queue: Aaron Colwell <acolwell@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#691437}
-
Nigel Tao authored
Bug: 826982 Change-Id: If549cb46f4f806e80b0fac5b5c3ba19b1855bac1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1767289 Commit-Queue: Nigel Tao <nigeltao@chromium.org> Reviewed-by:
Yury Khmel <khmel@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#691436}
-
Eric Foo authored
This is CL is generated by a script. Data is pulled from review conducted in Q2 2019. See https://tinyurl.com/yxau5sc4 for context. Bug: 977050 Change-Id: I0c96b2eade460f27d3623fb9de9efed0e63cc0f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700836Reviewed-by:
Jeffrey Yasskin <jyasskin@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Commit-Queue: Eric Foo <efoo@chromium.org> Auto-Submit: Eric Foo <efoo@chromium.org> Cr-Commit-Position: refs/heads/master@{#691435}
-
Gyuyoung Kim authored
This CL converts mojo::Binding to mojo::Receiver as well as MediaStreamDeviceObserverRequest to mojo::PendingReceiver in MediaStreamDeviceObserver::BindMediaStreamDeviceObserverRequest. Bug: 955171 Change-Id: I166d3415373ce9cd0c2d49e3645fa2fe03b05af8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768514Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#691434}
-
Yuwei Huang authored
The USER message class sends GCM tickle. We have never set up GCM project nor do we rely on tickle, so this CL changes the message class to STATUS, so that the FTL server doesn't send a tickle to the receiver for signaling messages. Bug: 992563 Change-Id: Ie3528b9586ef67115a7ccfa5782461aad9167dc7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757068Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Commit-Queue: Yuwei Huang <yuweih@chromium.org> Cr-Commit-Position: refs/heads/master@{#691433}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/25af6422926b..b72c39d07778 git log 25af6422926b..b72c39d07778 --date=short --no-merges --format='%ad %ae %s' 2019-08-29 andrewlamb@chromium.org Set NINJA_CORE_MULTIPLIER to 1. Created with: gclient setdep -r src/third_party/chromite@b72c39d07778 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I2de33e12470a3aae3e255237ffa71620bd84a2a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775556Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#691432}
-
Paul Dyson authored
The MlAppRankProvider class may have been destroyed by the time it is called in the background thread. So use a callback instead of directly accessing the class mmebers. Tested: ExecutionAfterDestructorTest in ml_app_rank_provider_unittest.cc crashes without this cl. Bug: 991433 Change-Id: I473db4e34f2b31e77a5ba83732e1ce34c4446f92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771359Reviewed-by:
Tony Yeoman <tby@chromium.org> Reviewed-by:
Andrew Moylan <amoylan@chromium.org> Commit-Queue: Paul Dyson <pdyson@chromium.org> Cr-Commit-Position: refs/heads/master@{#691431}
-
Daksh Idnani authored
This change refactors GPU switching code for MacOS to a centralized GPU switching manager, that will only allocate a single discrete pixel format object instead of each GL context allocating its own object. Bug: 681341 Change-Id: I4b41273321f840bba4d7b3fcff1ee60761d771af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771048 Commit-Queue: Daksh Idnani <dakshidnani@google.com> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#691430}
-
Toni Barzic authored
BUG=976947 Change-Id: I1fe1788345a4dcdb0f155cc3283995c2336e6607 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774878 Commit-Queue: Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#691429}
-
Yoshisato Yanagisawa authored
W: 149, 4: No exception type(s) specified (bare-except) Change-Id: I16ba670a7d9aa45fad57e9a87c1583ec4a44dd4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768586Reviewed-by:
Michael Moss <mmoss@chromium.org> Commit-Queue: Yoshisato Yanagisawa <yyanagisawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#691428}
-
Ahmed Fakhry authored
This is the ToT version of the M-77 CL https://crrev.com/c/1773959. TBR=sammiequon@chromium.org BUG=998321 Change-Id: Id5acbb90947aa6b461ec6ef6086fc0f3e5c7d191 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774198Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#691427}
-
Piotr Bialecki authored
Change-Id: If219d3ca8460c8a16c8ad2e5bf78ea1dd9d37fc8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775599 Commit-Queue: Piotr Bialecki <bialpio@chromium.org> Commit-Queue: Klaus Weidner <klausw@chromium.org> Auto-Submit: Piotr Bialecki <bialpio@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Cr-Commit-Position: refs/heads/master@{#691426}
-
Tim Song authored
Because the button is disabled on the lockscreen, the tooltip should not prompt an action. BUG=997133 Change-Id: I8a8aae9767f872f71fca3a80f0eb10e84d8430e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773208 Commit-Queue: Tim Song <tengs@chromium.org> Reviewed-by:
Tim Song <tengs@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#691425}
-
Jesse Schettler authored
Open Chrome print preview in an ARC Custom Tab when printing from an ARC app. Chrome print preview in an ARC Custom Tab Bug: b:132802107 Test: Print from an ARC app and verify the print document is opened in Change-Id: I22ba96a95ba32b42f0e93521ab2475f4df293e10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1755012Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Jesse Schettler <jschettler@chromium.org> Cr-Commit-Position: refs/heads/master@{#691424}
-
Jun Mukai authored
This CL introduces a new layer for scrolled content of apps grid. Currently, the apps-grid is drawn in a layer (because I removed layers on individual items), and scrolling requires to redraw the content of the layer. This could be time-consuming, especially on low-end devices. This CL changes the layer structure a bit: - AppsGridView hosts a LAYER_NOT_DRAWN layer for clipping and the mask layer. - Inside, a new items_container view hosts a layer. It has size of the entire grid (i.e. page_size * pages). - On page-switch or drag-to-scroll, it modifies the transform of the layer, so the view moves without views::View::Paint. This CL includes a few tricky parts: - when it needs to jump to a far page, the animation should skip intermediate pages. The offset code takes care of this, but it needs a repainting. It happens only once when the animation started, the repainting won't happen during the animation. - when the page is fully switched, the transform should be cleared and then the items_container_ needs to be repositioned properly. This is done on SelectedPageChanged() with Layout(). Again this happens only once at the end of the animation. This improves LauncherPageSwitchTest and LauncherPageDragTest on scarlet; - PresentationTime -- ~80msecs to 45msecs - AnimationSmoothness -- 45% to 95% in clamshell mode, 20% to 36% in tablet mode Bug: 987311 Test: interactive_ui_tests, app_list_unittests Change-Id: I4d23b408e741ca1ea221b7f0919f9334d8547af1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769797 Commit-Queue: Jun Mukai <mukai@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#691423}
-
dalyk authored
Now marks SystemNetworkContextManagerBrowsertests as non-enterprise- managed. > Original change's description: > > Add domain joined check to managed device detection for DoH. > > > > Some devices may be domain joined but not have any active policies. > > We should also disable DoH by default for that scenario. > > > > Bug: 955454 > > Change-Id: I50ad015e9e5d072dddcaa72524e5d39ffb2e005c > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773397 > > Reviewed-by: Eric Orth <ericorth@chromium.org> > > Commit-Queue: Katharine Daly <dalyk@google.com> > > Cr-Commit-Position: refs/heads/master@{#690809} Change-Id: I3840ffecaea5f7be465f6b08da4340be0e9503cc Bug: 955454 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773750 Commit-Queue: Katharine Daly <dalyk@google.com> Reviewed-by:
Eric Orth <ericorth@chromium.org> Cr-Commit-Position: refs/heads/master@{#691422}
-
Ryan Sturm authored
Three bugs here: int member always casted to 0. Metric wasn't scaled to percent. Other percent scaled metrics were not percent scaled when calculating the score. Change-Id: I1409be0fbc893f996c64c4622e763b33730db8cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774324Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#691421}
-
minch authored
See https://docs.google.com/document/d/1DFKZsXCU4GySB9Ry8Bhd8k8sB7pO5wOz0GBcFmAq5B4/edit#heading=h.ekjb61oacmwf for the corresponding colors. Bug: 982950 Change-Id: I78299244e9e900ac8e713463a8d976700eaacb6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772453 Commit-Queue: Min Chen <minch@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#691420}
-
Kenichi Ishibashi authored
Starting service workers on the IO thread turns out causing mysterious race conditions (see the comment #3 of linked bug). It's hard to avoid such race conditions. This CL uses a background thread to start service workers. Some methods in blink::scheduler::WorkerThread and blink::WorkerThread use base::WaitableEvent and will be execution on a background thread so we need to allow them to use base::ScopedAllowBaseSyncPrimitives. This CL fixes wpt/shape-detection/idlharness.https.any.html when OffMainThreadServiceWorkerStartup is enabled. Bug: 996567 Change-Id: Id987e19e8874d471a961993eca842961c0b0d119 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768490 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#691419}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/217195ca2ce8..ee8d9ce83d7c git log 217195ca2ce8..ee8d9ce83d7c --date=short --no-merges --format='%ad %ae %s' 2019-08-28 ellyjones@chromium.org owners: add owners_rooted_at_file() 2019-08-28 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@ee8d9ce83d7c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: chromium:None Change-Id: I21123cc2dc01bfc6caf6030241910a0f4a3e0672 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775181Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#691418}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/043d1dc002f7..635d14bb29d0 git log 043d1dc002f7..635d14bb29d0 --date=short --no-merges --format='%ad %ae %s' 2019-08-28 pmuetschard@google.com Merge changes I975aa3e0,Ibbf96b20,I4cf87db6,I5933e598 2019-08-29 primiano@google.com Even better speculative fix of chromium roll 2019-08-28 treehugger-gerrit@google.com Merge "Show rect on chrome slice selection" 2019-08-28 primiano@google.com Merge "Speculative fix of chromium roll" 2019-08-28 mikaelpessa@google.com Add trace parser for SurfaceFlinger graphics frame events 2019-08-28 primiano@google.com Merge "Further minor GN & scripts cleanups" Created with: gclient setdep -r src/third_party/perfetto@635d14bb29d0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: Ibae729969c8636328984e15de1e6f2702f6820c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775288Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#691417}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/6c9bdb56..ed2f5ecd Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I5c31311bde7bcc6305cc2a4651bcc2dd5c86390d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775006Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#691416}
-
Xing Liu authored
This CL does the following: 1. When notification deliver time window has passed, we can delete them. 2. Polish the initialization sequence of ScheduledNotificationManager. 3. Delete the icons when deleting notification, wrap to a helper function. 4. Polish the unit tests. Bug: 996016 Change-Id: I43dd93eee2b59ac2ace153b4c0d9912b0462a259 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769485 Commit-Queue: Xing Liu <xingliu@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Hesen Zhang <hesen@chromium.org> Cr-Commit-Position: refs/heads/master@{#691415}
-
Zhenyao Mo authored
BUG=998766 TEST=gpu_unittests R=kbr@chromium.org Change-Id: I31da9d7215090e5eeff4f6d064af253cbec131ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774982 Auto-Submit: Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#691414}
-
Nigel Tao authored
Change-Id: I861ddadd6f4003e36b581d382b2fab9d1a99e8c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763563 Commit-Queue: Nigel Tao <nigeltao@chromium.org> Reviewed-by:
Yury Khmel <khmel@chromium.org> Cr-Commit-Position: refs/heads/master@{#691413}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/8e42ececca71..4b46042d2a25 git log 8e42ececca71..4b46042d2a25 --date=short --no-merges --format='%ad %ae %s' 2019-08-28 bsheedy@chromium.org Revert "Reland "Support minidump symbolization on ChromeOS"" 2019-08-28 bsheedy@chromium.org Reland "Support minidump symbolization on ChromeOS" 2019-08-28 perezju@chromium.org [Telemetry] Record shard index as tag in test results entry Created with: gclient setdep -r src/third_party/catapult@4b46042d2a25 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC skyostil@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=skyostil@google.com Bug: chromium:978952,chromium:978952,chromium:981349 Change-Id: I3c122622039891331d9ba85883882f7ed6eaedae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775417Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#691412}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/10b636138d77..703ea953f0f0 git log 10b636138d77..703ea953f0f0 --date=short --no-merges --format='%ad %ae %s' 2019-08-28 mellem@webrtc.org Only create a datagram RTP transport if the datagram transport should be used for RTP. 2019-08-28 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision f706cf73..8538f0b7 (690793:691247) 2019-08-28 eladalon@webrtc.org Remove unused using statements in webrtc_sdp.cc Created with: gclient setdep -r src/third_party/webrtc@703ea953f0f0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None,chromium:None Change-Id: I0a6e084570f8f3307881382f2af570dfbc890b73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772312Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#691411}
-
Daniel Rubery authored
Use a combination of the DomainsToCheckComplianceOfDownloadedContent, CheckContentCompliance, and SendFilesForMalwareCheck policies to decide whether to send downloads for DLP scans, malware scans, or both. This CL also moves the uploading to CheckClientDownloadRequest::FinishRequest, since we may want to do DLP scanning on files that are whitelisted by SB. Change-Id: Ia9f8afb36d1732ea8c4721e52d362a76fee2ff5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1767362 Commit-Queue: Daniel Rubery <drubery@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Reviewed-by:
Roger Tawa <rogerta@chromium.org> Cr-Commit-Position: refs/heads/master@{#691410}
-
Charlene Yan authored
Bug: 985382 Change-Id: I9bcc3f7429b0c2a2e697f6e2cfae5888448249c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775102 Commit-Queue: Charlene Yan <cyan@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#691409}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/83785d063c61..378c18813b5a git log 83785d063c61..378c18813b5a --date=short --no-merges --format='%ad %ae %s' 2019-08-28 lujc@google.com Use ProgramPipelineID in place of GLuint handle 2019-08-28 syoussefi@chromium.org Vulkan: Expose EXT_instanced_arrays 2019-08-28 lujc@google.com Use PathID in place of GLuint handle Created with: gclient setdep -r src/third_party/angle@378c18813b5a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cwallez@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Bug: None Change-Id: I3e4b4d16cc291937fd9140d158f2086d7a70c338 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775362Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#691408}
-
Darren Shen authored
This reverts commit 524aa9d4. Reason for revert: Possible cause of crbug.com/998978 Original change's description: > Do not perform font scanning when cache directory not configured > > Fixes flakiness in unit testing due to DWriteFontLookupTableBuilder > spuriously trying to index fonts when it should not. > > In order to test DWriteFontLookupTableBuilder a cache directory is > configured for persisting the built table. The same happens when a full > browser runs with a profile - in which case a subdirectory of the > USER_DATA directory is used. Do not scan fonts if a directory is not > configured. > > This situation happens in unit tests in tests other than the > DWriteFontLookupTableBuilder unit tests, as ContentClient and > BrowserClient do not return a path for GetFontLookupTableCacheDir() in > testing. It is sufficient to test DWriteFontLookupTableBuilder in its > own unittests. If local unique font matching on Windows 7 is required in > a unit test, a cache directory can be configured using > DWriteFontLookupTableBuilder::GetInstance()-> > SetCacheDirectoryForTesting(...) > > Thanks to etienneb@ for spotting this problem and initial fix proposals. > > Bug: 996167 > Change-Id: Iccac27225d7be7fc464a645e7e7689eba3680efa > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769437 > Reviewed-by: Etienne Bergeron <etienneb@chromium.org> > Commit-Queue: Dominik Röttsches <drott@chromium.org> > Auto-Submit: Dominik Röttsches <drott@chromium.org> > Cr-Commit-Position: refs/heads/master@{#691074} TBR=drott@chromium.org,etienneb@chromium.org Change-Id: Id60995dd4584df96b354a38779d76056dfd946eb No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 996167 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775638Reviewed-by:
Darren Shen <shend@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#691407}
-
Min Qin authored
The function has no ReferrerURL and the TODO has no ldap associated. The LOG was added by accident. Change-Id: Id90e4c3011ae9d06eca21fed51a5ca74e622dd00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775367Reviewed-by:
Xing Liu <xingliu@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#691406}
-
Sophie Chang authored
This will be populated by the first call to CanApplyOptimization and used in subsequent calls to the same method. Since a hint may have a lot of page hints, this is an optimization to short circuit that loop and only perform matching if necessary. Bug: 969558 Change-Id: I07ce231c862a6d1fb63260655480c243292a47d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775320Reviewed-by:
Doug Arnett <dougarnett@chromium.org> Commit-Queue: Sophie Chang <sophiechang@chromium.org> Cr-Commit-Position: refs/heads/master@{#691405}
-
Oksana Zhuravlova authored
This change modifies BrowserInterfaceBrokerProxy::SetBinderForTesting() to remove the override if the passed callback is null, which is now done in MojoInterfaceInterceptor::stop(). Bug: 985118 Change-Id: I67ad6a6d8fcd3414d51f27f0b7b3cfa41f289e69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773577 Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#691404}
-
Dominic Battre authored
Bug: 984214 Change-Id: I0b90216bd601b0c8db7f56bf4c669e569e61e574 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771396 Auto-Submit: Dominic Battré <battre@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#691403}
-