GitLab

Use the active window-placement repo url and name instead.
Leaves some mentions that are still abstractly applicable.
Copy Screen TODO from third_party/blink/renderer/core/frame/screen.h

Bug: 897300
Change-Id: I134516e21a74f0cec5f543306efa39fad6d76dc1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358134Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#799460}

* Make more things constexpr and/or make it possible to do so later
* Inline SaturatedAdd/Sub(), FromDouble(), FromProduct()
* Order the FromUnits{,D}() pairs together
* Init members in declaration
* Briefer implementations of various functions
* IWYU
* Fix declared-but-not-defined issue for FromTimeSpec() w/OS_FUSCHIA
* Use more specific DCHECKs
* No else after return
* Omit needless qualifiers
* EXPECT -> static_assert where possible
* <atomic> is legal now
* Don't handle DCHECK failure

The inlines don't hurt size: this saves 4 KB off chrome.dll in my local
release build.

Bug: none
TBR: stevenjb@chromium.org
Change-Id: I269d6426ac1587569e7a4c785250a4dd5e95d5bf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358997Reviewed-by: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Yuri Wiitala <miu@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#799459}

This CL addresses an issue where the users where not able to enter data
into the text fields of the color picker when the elements are inside
a cross-domain iframe.

For the top-level page and for same-domain iframes, when a char event
is received while a popup is open, the event is routed from
RenderWidgetInputHandler to WebViewFrameWidget shim, which hands it to
the WebView. WebViewImpl::HandleCharEvent has code to check for an open
popup and the event is sent to the popup if one exists.

For the cross-domain iframe case, the RenderWidgetInputHandler hands
the event to WebFrameWidgetImpl, but WebFrameWidgetImpl::HandleCharEvent
doesn't check for an open popup, so the event goes to the page
containing the popup.

This CL adds the same popup check to WebFrameWidgetImpl as the one that
WebViewImpl::HandleCharEvent already has.

Bug: 1114052
Change-Id: I33f2b10b4ae5aa538ebb0d22c1d55f5d97019216
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364008Reviewed-by: Kent Tamura <tkent@chromium.org>
Commit-Queue: Ionel Popescu <iopopesc@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#799458}

Intent to ship:
https://groups.google.com/a/chromium.org/g/blink-dev/c/Jdw3VWbKvLY/m/0YBXYr-lBwAJ

Bug: 869308
Change-Id: I75cab8d0c7c117ce67a8962a903b534e11620f95
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358608Reviewed-by: Mason Freed <masonfreed@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#799457}

This reverts commit 80207c25.

Reason for revert: Flaking tests, see crbug.com/1117683

Original change's description:
> Redesign ATrace integration
>
> Chrome and WebView have supported basic Android ATrace tracing, but the
> current approach has some shortcomings:
>
> 1) Android R changes the way atrace session activations are broadcast,
>    breaking the code in WebView listening for activations
>    (OnTraceEnabledChangeListener). This means you can't trace a running
>    WebView app with atrace.
>
> 2) Neither Chrome nor WebView record early startup events to atrace,
>    which means all events before the native library has loaded are
>    lost.
>
> 3) It's not possible to specify trace categories via atrace, which means
>    we need more cumbersome alternative solutions (i.e., command line
>    flags) for startup tracing.
>
> 4) Writing ATrace events is only supported in WebView.
>
> This patch reworks the ATrace integration to resolve these problems and
> to align the Chrome and WebView implementations. In short, ATrace
> session management is moved to the common (TraceEvent) layer, and Chrome
> and WebView only differ by which trace tags they listen to (APP vs.
> WEBVIEW).
>
> We also add a way to declare trace categories through per-app tags:
>
> $ atrace -a org.chromium.chrome,org.chromium.chrome/<category_filter>
>
> (Note that the plain package name without any category filters must
> always appear in the list on its own.)
>
> Multiple categories can be separated with a double colon:
>
> $ atrace -a org.chromium.chrome,org.chromium.chrome/cat1:cat2
>
> Or by specifying the the app several times to get around the 91
> character limit for each entry:
>
> $ atrace -a org.chromium.chrome,\
>             org.chromium.chrome/cat1,\
>             org.chromium.chrome/cat2
>
> Finally, to capture Java startup events into a tracing session
> controlled by the system's Perfetto service instead of atrace, a
> special "-atrace" category can be used to only write events into
> Chrome's own tracing service instead of atrace. This way when we
> connect to Perfetto later in the startup sequence and establish
> the real tracing session, startup-related events can be flushed
> into that session without emitting duplicate events into ATrace.
>
> # Basic trace while Chrome is running. Generates ATrace with Chrome
> # events.
> TEST=atrace -a org.chromium.chrome
>
> # Ditto for WebView.
> TEST=atrace webview
>
> # Startup trace -- open Chrome after running this. Results in an ATrace
> # with Chrome pre- and post-startup events.
> TEST=atrace -a org.chromium.chrome
>
> # Ditto for WebView.
> TEST=atrace webview
>
> # Trace with custom categories. Results in a ATrace with only
> # "cc" events from Chrome.
> TEST=atrace -a org.chromium.chrome,org.chromium.chrome/-*:cc
>
> # Ditto for WebView, using GMail as a test app.
> TEST=atrace -a com.google.android.gm,com.google.android.gm/-*:cc webview
>
> # Chrome-only trace. No Chrome events written in the resulting ATrace.
> TEST=atrace -a org.chromium.chrome,org.chromium.chrome/-atrace
>
> Bug: 1095587, b/160768681
> Change-Id: Ia0bee252ce398804c00be8a4179241b75479bf5e
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332664
> Reviewed-by: Bo <boliu@chromium.org>
> Reviewed-by: Andrew Grieve <agrieve@chromium.org>
> Reviewed-by: Eric Seckler <eseckler@chromium.org>
> Commit-Queue: Bo <boliu@chromium.org>
> Auto-Submit: Sami Kyöstilä <skyostil@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#798791}

TBR=boliu@chromium.org,skyostil@chromium.org,agrieve@chromium.org,eseckler@chromium.org,nuskos@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1095587, 1117683
Bug: b/160768681
Change-Id: Iffcaebb70c6eb92da1cb3080e8034ea5c36e5394
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363564
Commit-Queue: Sky Malice <skym@chromium.org>
Reviewed-by: Sky Malice <skym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#799456}

This reverts commit 9881e6cd.

Reason for revert: Needs a follow up crrev.com/c/2362068, but
the code is still faulty because it'd hit a DCHECK. Let's revert
this one and land a correct CL instead.

Original change's description:
> media/gpu/vaapi: use new |va_buffer_for_vpp_| for Vpp/BlitSurface()
> 
> ToT VaapiWrapper uses |va_buffers_| for internal Vpp uses and also for
> external VEA/JEA use. This CL starts refactoring these VABufferIDs
> lifetime, by splitting the Vpp VABufferID out of |va_buffers_| and
> into a ScopedID |va_buffer_for_vpp_|.
> 
> Bug: b:162962069
> Change-Id: Ic54d0d26f5d17ea49fe896cf7ca5e1c931d07e0f
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352522
> Commit-Queue: Miguel Casas <mcasas@chromium.org>
> Reviewed-by: Hirokazu Honda <hiroh@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#799410}

TBR=mcasas@chromium.org,hiroh@chromium.org

Change-Id: I2b13e096fb7fce00c4dbbaed64bd4d231de34d15
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: b:162962069
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363798Reviewed-by: Miguel Casas <mcasas@chromium.org>
Commit-Queue: Miguel Casas <mcasas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#799455}

Explicitly remove the copy constructor and assignment operator with
the delete keyword.

Bug: 1010217
Change-Id: I8fc2a1e0e44808fc356a1cf370afed5d62528827
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362350Reviewed-by: Kent Tamura <tkent@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Commit-Queue: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#799454}

This CL adds `kn, ko, lt, lv, ml, mr, ms, nl, pl, pt-BR, pt-PT, ro, ru`
to the set of languages supported by Pedals.

Bug: 893183
Change-Id: Ib942aa1b3ef8d55727c66538a221c840ae004919
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363709
Commit-Queue: Orin Jaworski <orinj@chromium.org>
Commit-Queue: Tommy Li <tommycli@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Auto-Submit: Orin Jaworski <orinj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#799453}

BUG=crbug:1062407
TEST=./decode_test -video=bear-vp9.ivf -profile=vp9profile0
-out-prefix=bear/frame on nautilus

Change-Id: I3dad8056acb44c9e3e8424be3175b0f017f098f3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2296874
Commit-Queue: Jao-ke Chin-Lee <jchinlee@chromium.org>
Reviewed-by: Miguel Casas <mcasas@chromium.org>
Reviewed-by: Andres Calderon Jaramillo <andrescj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#799452}

Bug: 1084281
Change-Id: I9086434a4f95f820da89c998ee9a652741398b82
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358908
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Peter Boström <pbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#799451}

Add a temporary, to-be-deleted method, gfx::DisplayColorSpaces::
GetScreenInfoColorSpace, which returns the particular
gfx::ColorSpace that would have been in blink::ScreenInfo.

With this in place, the next sequence of patches can carefully
handle each instance of GetScreenInfoColorSpace more appropriately.
In particular:
- LayerTreeHost::SetRasterColorSpace will use gfx::DisplayColorSpaces
  directly (and will change raster color space appropriately based
  on content).
- GetColorSpaceGamut::GetColorGamut can operate directly only the
  DisplayColorSpaces.
- The video-related "target space" will need to be replaced with
  the relevant information (which is most likely a single bit about
  HDR support).

Bug: 1116870
Change-Id: I796c720cfc6796b3bb285cee27b98ae77650ea18
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360549Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: ccameron <ccameron@chromium.org>
Cr-Commit-Position: refs/heads/master@{#799450}

This is required as we want to rollout finch experiment to beta.

Bug: 1042084
Change-Id: I7921f0434192f51b6942e13fc2307badf3c21c07
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359789
Commit-Queue: Jing Wang <jiwan@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Cr-Commit-Position: refs/heads/master@{#799449}

See bug. I was unable to reproduce the error, it's likley due to
some experiment. I suspect it may be related to instant start,
as this line would result in creating the wrong feed if the
coordinator is made too soon:
https://source.chromium.org/chromium/chromium/src/+/master:chrome/android/feed/core/java/src/org/chromium/chrome/browser/feed/FeedSurfaceCoordinator.java;l=223

For now, just DCHECK if this happens.

Bug: 1117680
Change-Id: Iecc2690698b34a04151b62b684a6b8b955055fe4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363809Reviewed-by: Carlos Knippschild <carlosk@chromium.org>
Commit-Queue: Dan H <harringtond@chromium.org>
Cr-Commit-Position: refs/heads/master@{#799448}

Roll Chrome Mac PGO profile from chrome-mac-master-1597773485-0de81363c6e29d47e12bedb85e74c4f66df8cd46.profdata to chrome-mac-master-1597795195-73a3893f6ac2e232e6f2551f9490f3476218900c.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-chromium
Please CC liaoyuke@google.com,sebmarchand+pgo_roller@google.com,jeffyoon@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: chrome/try:mac-chrome
Tbr: liaoyuke@google.com,sebmarchand+pgo_roller@google.com,jeffyoon@google.com
Change-Id: I67f9a7ad31c101f84051e5182898a6ddbf355429
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364088Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#799447}

Most search result data is stored in a SearchResultMetadata object,
which is synced between the ash and chrome objects representing results.
One exception is the ash::SearchResultType enum which, confusingly
named, is only used for metrics.

Currently this enum is available via a virtual method on the chrome-side
only. To fix a race condition in the impressions system, we now need to
treat it like other search result data.

This CL adds methods to SearchResultMetadata, deletes the old chrome
getter, updates all ChromeSearchResult subclasses to correctly set the
metadata.

The ChromeSearchResult subclass updates are mostly trivial, these have
slightly more logic:
 - chrome_search_result itself
 - arc_app_data_search_result
 - omnibox_result

Bug: 1076270
Change-Id: I1b1da0e3248031df3f31c2cd8b622dfb0487e390
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352256Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Thanh Nguyen <thanhdng@chromium.org>
Commit-Queue: Tony Yeoman <tby@chromium.org>
Cr-Commit-Position: refs/heads/master@{#799446}

This is Windows only.

DWM won't consider a swap chain as an overlay candidate
unless it's updating at high enough fps with full damages.

So we need to force full damage when the actual damage is
closer to full damage in order to promote the main back
buffer as an overlay.

This CL also added the bit to allow viz to make sure
swap chain's buffers always have up to date pixels
inside or outside damage rects. This enables us to
force full damage.

BUG=1117185
TEST=manual
R=sunnyps@chromium.org,magchen@chromium.org

Change-Id: Idff7a90952c810a07992df0ace040be92b63e4d3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359730
Commit-Queue: Zhenyao Mo <zmo@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Rafael Cintron <rafael.cintron@microsoft.com>
Reviewed-by: Jonathan Backer <backer@chromium.org>
Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org>
Reviewed-by: Maggie Chen <magchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#799445}

CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-chrome
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-chrome
TBR=chrome-os-gardeners@google.com

Change-Id: I6de3fb6e0c3130e3b9736498a1fa531b988fabb6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363919Reviewed-by: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com>
Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com>
Commit-Queue: Aga Wronska <agawronska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#799444}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/df143e8b..6a992541

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I0409b008138e655fae909cef8643af7227038641
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362336Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#799443}

Bug: None
Change-Id: I3557fcc552ca4e5505226dd20f978949bbae0de5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363491Reviewed-by: Bo <boliu@chromium.org>
Commit-Queue: Yi Gu <yigu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#799442}

These histograms are needed because we can
know how often synced account passwords are
used and how often both synced and non-synced
passwords are changed in comparison to how often
they're reused.

Bug: 1117113,1117111
Change-Id: I1ab9d79196f28fadeabbe9177052f85bf8523064
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358595Reviewed-by: Mark Pearson <mpearson@chromium.org>
Reviewed-by: Varun Khaneja <vakh@chromium.org>
Commit-Queue: Bettina Dea <bdea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#799441}

This CL replaces the placeholder English strings with their
internationalized equivalent.

Bug: 893183
Change-Id: I62f828c6db7fb40a421feb2352fb4f49a5fa1738
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363641
Commit-Queue: Tommy Li <tommycli@chromium.org>
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Cr-Commit-Position: refs/heads/master@{#799440}

This introduces DialogModelField::AsButton, etc. instead of having
DialogModelHost and DialogModel both downcast.

Also adds DialogModel::AddField to make sure OnFieldAdded() is called
from all call sites that add a field.

Bug: 1106422
Change-Id: I512f5df9cf642314de7bde5b9ef4fe1d7c3efedc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363870
Commit-Queue: Peter Boström <pbos@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Auto-Submit: Peter Boström <pbos@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#799439}

Valid for five milestones: 86-90.

In the chrome://flags UI, the entry looks like this:
  Enable AVIF image format
  Adds image decoding support for the AVIF image format. – Mac, Windows,
  Linux, Chrome OS
  #enable-avif

Test:
Manual test in chrome://flags.
unit_tests --gtest_filter=AboutFlagsHistogramTest.CheckHistograms
unit_tests --gtest_filter=AboutFlagsTest.EveryFlagHasMetadata

Bug: 1117843
Change-Id: If293557d795c192c62918c932a72edf3b2d265e9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363718
Commit-Queue: Wan-Teh Chang <wtc@google.com>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#799438}

The path to disks has changed recently, so update the path we expect.

Bug: chromium:1114826
Test: Manual, CQ
Change-Id: I9f9bb5271d57021dd1c9559e9e7f858ce83dc059
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362163
Auto-Submit: David Munro <davidmunro@google.com>
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Commit-Queue: David Munro <davidmunro@google.com>
Cr-Commit-Position: refs/heads/master@{#799437}

Bug: 1116210
Change-Id: I09a3ddbea5756cc569d38805b5c11e4f06ecee6a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357679
Commit-Queue: Mehrdad Hessar <mehrdadh@google.com>
Reviewed-by: Michael Crouse <mcrouse@chromium.org>
Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#799436}

In preparation for per-profile SafeBrowsingNetworkContexts, we add a
check to SafeBrowsingRemoveCookies in
ChromeEnterpriseRealTimeUrlLookupServiceFactory, which will start using
the Profile URLLoaderFactory with no credentials.

Bug: 1049833
Change-Id: Ib2999c188ae3a4e49c1fd784816c0115c288b9d7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360553Reviewed-by: Xinghui Lu <xinghuilu@chromium.org>
Commit-Queue: Daniel Rubery <drubery@chromium.org>
Cr-Commit-Position: refs/heads/master@{#799435}

LayoutNGButton inherits from LayoutNGFlexibleBox.  However it's an
implementation detail, and we might change the base class in the future.

This CL has no behavior changes.

Bug: 1040826
Change-Id: I71aabd4b3bfdc9d1b6612c97aeb1fd3bff08a15d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362347
Commit-Queue: Yoshifumi Inoue <yosin@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#799434}

Switches several GPU pixel tests on Fuchsia to use the new full
screenshot capabilities in Telemetry instead of the version that only
captures the visible portion of the web contents. This fixes the tests
on Fuchsia, where the device screen is significantly smaller than
previously tested devices. This path is not used everywhere because
capturing the screenshot using fromSuface: True is less likely to catch
GPU issues.

Bug: 1115680
Change-Id: I69423b4995978c1455978b7d9bdc6e80192b6ccd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355133Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#799433}

Add a histogram named "SafeBrowsing.Settings.UserAction" to log user
actions on the Safe Browsing settings page. The metrics are suffixed
with AccessPoint. Currently the AccessPoint can be either the
privacy page or the safety check page. In the future, we will likely
introduce more access points to promote Enhanced Safe Browsing.

The enums are added on the native side, because they will be reused on
the desktop setting page in the future.

Bug: 1115758
Change-Id: I90ff69ddd3f6a7bf836e06cf69f63ea02cdf7344
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357677
Commit-Queue: Xinghui Lu <xinghuilu@chromium.org>
Reviewed-by: Natalie Chouinard <chouinard@chromium.org>
Reviewed-by: Andrey Zaytsev <andzaytsev@google.com>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Reviewed-by: Varun Khaneja <vakh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#799432}

This adds the ability to selectively ignore HID FIDO devices by VID/PID
during discovery in FidoHidDiscovery and ignores the ChromeOS u2fd
virtual HID device during WebAuthn requests that don't originate from
cryptoken if the ChromeOS platform authenticator is flag-enabled.

The virtual HID device and the platform authenticator are both
implemented in u2fd and both bring their own UI, so having a single
WebAuthn request target both would cause all kinds of trouble.

The platform authenticator will be able to challenge credentials
registered by the virtual HID device via the appID extension. So
eventually we might want to make the platform authenticator feature flag
disable the virtual HID device during cryptotoken requests as well, and
advise users to switch to the WebAuthn API instead.

Change-Id: Ic19152fa76bf75079310719e3dcd2bd35466b3dd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351139
Commit-Queue: Martin Kreichgauer <martinkr@google.com>
Reviewed-by: Adam Langley <agl@chromium.org>
Cr-Commit-Position: refs/heads/master@{#799431}

For SBER users, we send the SHA256 hash of the blurred image data
along with the screenshot_phash.

Fixed: 1115720
Change-Id: Ia9ecbbb3e83bd927a12590934492bc1d3f4d5c3b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363952
Commit-Queue: Daniel Rubery <drubery@chromium.org>
Reviewed-by: Bettina Dea <bdea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#799430}

Every time we update the background image URL the background image fades
in. If the new URL is identical to the old URL the fade in is
unnecessary.

Fixed: 1116936
Change-Id: I58c880dd55dc50528c03614d4d4606c44c1254ed
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360339
Auto-Submit: Tibor Goldschwendt <tiborg@chromium.org>
Commit-Queue: Esmael Elmoslimany <aee@chromium.org>
Reviewed-by: Esmael Elmoslimany <aee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#799429}

This reverts commit af48c8e6.

Reason for revert: Test works now.

Original change's description:
> [Sheriff] Disable the test
> 
> Disable the failing test on Linux.
> 
> Bug=1108205
> TBR=miu@chromium.org
> 
> Change-Id: Ie388ca75a2fadce937d613994847217e7f9579fc
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310271
> Reviewed-by: Hayato Ito <hayato@chromium.org>
> Commit-Queue: Hayato Ito <hayato@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#790745}

TBR=miu@chromium.org,hayato@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Change-Id: I4c43284f7d4a0fec1cd4c05fc375f1f4d406526b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2361023Reviewed-by: Yuri Wiitala <miu@chromium.org>
Commit-Queue: Yuri Wiitala <miu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#799428}

We use IOSurfaceSetColorSpace's return value to determine
if an IOSurface can be an overlay. Continue to return true
for these formats, because the HDRCopier will be used
to composite them (https://crbug.com/1101041).

Bug: 1108627
Change-Id: I06d5282bc508ec61698112f58a1c5f18efe68ebf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363950Reviewed-by: Mark Mentovai <mark@chromium.org>
Commit-Queue: Mark Mentovai <mark@chromium.org>
Commit-Queue: ccameron <ccameron@chromium.org>
Cr-Commit-Position: refs/heads/master@{#799427}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c24096ed3b5c..1d251f6f077f

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC tommycli@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: chromium:1105096
Tbr: tommycli@google.com
Change-Id: Ic53b9fc2f026bab45f8b26a9c9a6670a40b79332
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363426Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#799426}

The newly failing block tests are because this does not yet
support min-height: auto.

I will investigate the newly failing flex test later.

Bug: 1083010
Change-Id: Iedfa1c442d4a7d24a474642c882fe6238fd6f1a4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357460
Commit-Queue: Christian Biesinger <cbiesinger@chromium.org>
Auto-Submit: Christian Biesinger <cbiesinger@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#799425}

Multiple tests were creating and deleting the same file path, which
looks like it lead to the flakes when tests run simultaneously. Now
using scoped dirs for each test.

Bug: 1117356
Change-Id: I4d949f5dfe735ea084f1a09f2b2f282eb7b1b004
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362355
Auto-Submit: Joel Hockey <joelhockey@chromium.org>
Commit-Queue: Fergus Dall <sidereal@google.com>
Reviewed-by: Fergus Dall <sidereal@google.com>
Cr-Commit-Position: refs/heads/master@{#799424}

This CL add icons for overflow menu, the icon will be in front of each
menu item.

Icons defined in main_menu.xml, and AppMenuPropertiesDelegate will
decide show them or not. And then AppMenuAdapter will choose layout
depending on AppMenuPropertiesDelegate#shouldMenuItemStartWithIcon.

Bug:1114440

Change-Id: I160020cb2210053ce904af185c059af25b168580
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335389
Commit-Queue: Gang Wu <gangwu@chromium.org>
Reviewed-by: Theresa  <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#799423}

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/560b983ff5a9..fb33bb85a9f7

2020-08-18 brgoddar@microsoft.com Performance: Fix perf issue with Event Log

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: chromium:1112663
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: Ib219661dae063202feb8df5b884fb5b4a188074e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363955Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#799422}

Allow client to display a "Suggest password..." suggestion to the user.
Upon tapping this suggestion, trigger delegate method asking the user
to accept the suggested password.

Bug: 1022906
Change-Id: I5a7264eb4efaab3c6bfcafe0a35d82f5eead6e53
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316847
Commit-Queue: John Wu <jzw@chromium.org>
Reviewed-by: Hiroshi Ichikawa <ichikawa@chromium.org>
Cr-Commit-Position: refs/heads/master@{#799421}