- 09 Dec, 2020 1 commit
-
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: I2d5b27e7d6c6480b57a34ed6ffa8cdef5a91d2b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2579727Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#834957}
-
- 08 Dec, 2020 39 commits
-
-
Shimi Zhang authored
This test was added before we introduced AwOriginMatcher. Previously, we use ProxyBypassRule which has implicit rule by default and we don't want when no any rule specified and then the origin is matched by implicit rule, see crrev/c/1924874 However, after we introduced AwOriginMatcher, the new matcher doesn't have implicit rule, this test is not necessary anymore. See crrev/c/2069024 Bug: 1030110 Change-Id: Ief6c67c7e46aae1341cfc778caf6e0530b3e072c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580105 Auto-Submit: Shimi Zhang <ctzsm@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#834956}
-
Nancy Wang authored
BUG=1146900 Change-Id: I3063503edd5942983cd51d14ef5a74d03cf12978 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2563150 Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#834955}
-
Alexander Surkov authored
Bug: 1133330 Change-Id: I91a7ea05fc01c171ad6075a145abb8dba4530d1d AX-Relnotes: n/a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2571797 Commit-Queue: Alexander Surkov <asurkov@igalia.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#834954}
-
Alex Gough authored
This helper is only used in integration.cc so can be moved out of the header. No functional changes. Change-Id: Ia9670e58feb4d6123610545ffdfe941f8cb2c084 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580499 Commit-Queue: Alex Gough <ajgo@chromium.org> Auto-Submit: Alex Gough <ajgo@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#834953}
-
Marijn Kruisselbrink authored
This method was recording its start time, but not its end time. Bug: 1156511 Change-Id: I9318e64d65c95dbd844878428cff2e78c221ecc5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580004Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Commit-Queue: Daniel Murphy <dmurph@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#834952}
-
Robert Ma authored
This is required by rebaseline-cl. Note that this is in fact a JSONP file. The file name is an unfortunate historical artifact. See comments for more details. Bug: 1154085 Change-Id: I0868bcc8a08f2a8bfd3a60176879f9d67c252239 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575584 Commit-Queue: Robert Ma <robertma@chromium.org> Reviewed-by:
Luke Z <lpz@chromium.org> Cr-Commit-Position: refs/heads/master@{#834951}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/56b18c5a..42f37e5c Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I0afe34156b6a1d32ea229870229286ddebd3d7e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2579665Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#834950}
-
Sven Zheng authored
Symbol level was not correctly set and some symbols are missing. Bug: 1156216 Change-Id: I2ac40fedc69a9f8b486420ec8f9bbda03b7c6ad4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576033 Commit-Queue: Sven Zheng <svenzheng@chromium.org> Auto-Submit: Sven Zheng <svenzheng@chromium.org> Reviewed-by:
Michael Moss <mmoss@chromium.org> Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#834949}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b57da84fcd71..4997984ca190 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jrw@google.com,domfc@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1156216 Tbr: jrw@google.com,domfc@google.com Change-Id: I23768022fb71b56ab94902f3c2db92fec5b979ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580759Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#834948}
-
Yulun Wu authored
Bug: 1154906 Change-Id: Iccfe3922f1139e552e78dd4f283f19f94d4e0958 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575558Reviewed-by:
Yulun Wu <yulunwu@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Reviewed-by:
-
Min Qin authored
BUG=1155639 Change-Id: I76c425702d914c77e7eb80779957a6d656b823d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574066Reviewed-by:
Xing Liu <xingliu@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#834946}
-
cfredric authored
These methods will be called in later CLs by the implementation of the SameParty attribute. Bug: 1143756 Change-Id: Id256e2a3971dccd4339f167516275a8dbcb46167 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576110Reviewed-by:
Eric Orth <ericorth@chromium.org> Reviewed-by:
Lily Chen <chlily@chromium.org> Commit-Queue: Chris Fredrickson <cfredric@chromium.org> Cr-Commit-Position: refs/heads/master@{#834945}
-
danakj authored
These bitmaps are safer for transport from untrustworthy sources since all bitmaps should be in N32 format and the browser can make bad assumptions as a result. Bug: 1144462 Change-Id: I9f568aeb1a29c546250d7088cb392fe2f1967301 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580010Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#834944}
-
Jonathan Wright authored
https://chromium.googlesource.com/chromium/deps/libjpeg_turbo.git/+log/bbb828223e9c..e9a659a09e96 $ git log bbb828223..e9a659a09 --date=short --no-merges --format='%ad %ae %s' 2020-12-08 jonathan.wright Cherry-pick upstream fix for uninitialised reads Created with: roll-dep src/third_party/libjpeg_turbo Bug: 1156513 Change-Id: I28130aae7f67cfcb174e064d598d869c83ffb3bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580778 Commit-Queue: Jonathan Wright <jonathan.wright@arm.com> Commit-Queue: Leon Scroggins <scroggo@google.com> Reviewed-by:
Leon Scroggins <scroggo@google.com> Cr-Commit-Position: refs/heads/master@{#834943}
-
danakj authored
When ImageSkiaRep makes its bitmap internally, it makes an N32 bitmap, but it also allows callers to pass a bitmap in. Often, these bitmaps come from untrustworthy places. Consumers of ImageSkia assume that bitmaps they pull out of it are N32 color type and use the pixel pointer or getAddr32() to manipulate the contents of the bitmap. If a malicious bitmap was inserted this could lead to out-of-bounds accesses to the SkBitmap. getAddr32() is guarded by an assert but that doesn't protect us from bad actors in the wild. So we add a CHECK() in ImageSkiaRep to ensure all bitmaps coming out of the class will be N32 format. R=sky@chromium.org Bug: 1155258 Change-Id: I3f90e550d8728fce145013b9887987741f1aa1b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574025Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#834942}
-
danakj authored
These bitmaps are safer for transport from untrustworthy sources since all bitmaps should be in N32 format and the browser can make bad assumptions as a result. Bug: 1144462 Change-Id: Ia485df7965d957c908636671ba674d8b5164d4b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575262Reviewed-by:
-
Kinuko Yasuda authored
Bug: 862175 Change-Id: I6c2db4246f2e332c60df9c208def7a3fd6e75391 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576879Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#834940}
-
danakj authored
These bitmaps are safer for transport from untrustworthy sources since all bitmaps should be in N32 format and the browser can make bad assumptions as a result. Bug: 1144462 Change-Id: Ic7703565594544e958da1e8709d9de55741c1762 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580462Reviewed-by:
-
Aleks Totic authored
The test asserted that: <table style="table-layout:fixed; width:auto"> getComputedStyle().tableLayout == "auto" This is incorrect per spec: https://drafts.csswg.org/cssom-1/#resolved-values table-layout is not defined as "Resolved value" No existing browsers passed this test. Change-Id: Icf411e47ed8da1d53e59dea16796dc3a7e48a221 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580359 Commit-Queue: Aleks Totic <atotic@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
David Grogan <dgrogan@chromium.org> Auto-Submit: Aleks Totic <atotic@chromium.org> Cr-Commit-Position: refs/heads/master@{#834938}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/26a24ee9aebf..a737e5f65ca1 2020-12-08 treehugger-gerrit@google.com Merge "tp: implement support for scoped slices in async track set" 2020-12-08 delphick@google.com Merge "metrics: Add test for cpu_by_combined_rail_mode table" 2020-12-08 lalitm@google.com Merge "tp: minor refactoring of async track set tracker for scoped slices" 2020-12-08 lalitm@google.com Merge "ui: fix displaying CPU profiles with sample id 0" 2020-12-08 lalitm@google.com Merge "tp: fix nest count handling for async slices" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I41e92854ee29379c39f44037162d1b84337484f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2579998Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#834937}
-
Rachel Carpenter authored
Also add buganizer/os for help_app_ui, media_app_ui and release_notes. Bug: b/175135936, b/175151096 Change-Id: I7bceda1959c133e585637b000586729947e1dc81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2579926Reviewed-by:
Bugs Nash <bugsnash@chromium.org> Commit-Queue: Rachel Carpenter <carpenterr@chromium.org> Cr-Commit-Position: refs/heads/master@{#834936}
-
Evan Stade authored
This change also combines two callbacks into one, since exactly one of them should be called. Bug: 1152276 Change-Id: If607bc48d34993a4ae73dc53e968afa553f9e66b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577013Reviewed-by:
-
Xing Liu authored
waitForOfflinePageSaved should poll and wait instead of only blocking the UI thread for once. Also use OfflineTestUtil to simplify the code. TBR=dtrainor@chromium.org Bug: 1155401 Change-Id: I81f6d00ef6337d4e9d656cdf04720c16c4ca5698 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2579719 Commit-Queue: Xing Liu <xingliu@chromium.org> Reviewed-by:
Brandon Wylie <wylieb@chromium.org> Cr-Commit-Position: refs/heads/master@{#834934}
-
Michael Liao authored
This CL adds the fontEditor experiment to the backend enum. Font Editor frontend CL: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2305613 Bug: 1156523 Change-Id: If6954fed13c244765454cbcd0986ef8bf8540cca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2579564Reviewed-by:
Alex Rudenko <alexrudenko@chromium.org> Commit-Queue: Michael Liao <michael.liao@microsoft.com> Cr-Commit-Position: refs/heads/master@{#834933}
-
Hui Yingst authored
This CL migrates uses of base::Closure to base::OnceClosure and base::Bind to base::BindOnce for GCCallback constructors in extensions/renderer/. Bug: 1152265 Change-Id: I2486e9f0d9a92d375ac31a6659d4bd7fa07ca639 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570316 Commit-Queue: Hui Yingst <nigi@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#834932}
-
Gavin Mak authored
Generate DIR_METADATA files and remove metadata from OWNERS files for directories under //chrome/browser. Bug: 1113033 Change-Id: I46a589187c446acb1cb0679605507969e5d5f5db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577009Reviewed-by:
Filip Gorski <fgorski@chromium.org> Commit-Queue: Gavin Mak <gavinmak@google.com> Cr-Commit-Position: refs/heads/master@{#834931}
-
Vladimir Levin authored
This patch ensures that we use a pre-margin version of the target rect if we are checking whether it was empty. This is to make sure that we compute a "1" intersection ratio in cases where an ancestor of a margin-padded target causes it to be empty. In this case, we should report 1 intersection, because we are intersecting and target is an empty rect. However, because we padded the target with a margin, we ended up doing the wrong check and ultimately compute 0 intersection in a different conditional branch (before this patch). This patch restores correct behavior. R=szager@chromium.org, chrishtr@chromium.org Fixed: 1156815 Change-Id: I1697388dd127737a0203d1c3ff15095de4ab41df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580046Reviewed-by:
Stefan Zager <szager@chromium.org> Commit-Queue: vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#834930}
-
Weiliang Chen authored
This CL adds a separator line between the CoreWebVital metrics and cc perf metrics, and also increases text size and HUD size on all platforms. The display on Android is less readable with default size, so increases the text size and display size further on Android. Screenshot link: https://bugs.chromium.org/p/chromium/issues/attachment?aid=478920&signed_aid=udKG5ymcIhZcc-c-kpDDNQ==&inline=1 R=sadrul Bug: 1152165 Change-Id: I30fe0a6405f6bbaa85642ac4e28ab9d26dc4c672 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568615 Commit-Queue: weiliangc <weiliangc@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#834929}
-
Mihai Sardarescu authored
The existing PrimaryAccountMutator::ClearPrimaryAccount with options to keep or remove all accounts was very confusing and it lead to bug http://crbug.com/1155042 This CL fixes the public API with 2 clear methods: * RevokeSyncConsent: replaces the version to clear the primary account when with kDefault action and leaves the primary account in ConsentLevel::kNotRequired on ChromeOS and DICE. * ClearPrimaryAccount: clears the primary account (revokes all consents) and also removes all accounts. A series of follow-up CLs will clean the internals of the PrimaryAccountManager as they become obsolete. Some additional considerations: * iOS and Android do *not* use RevokeSyncConsent(), except from the unexpected call from ProfileSyncService. We could ifdef out RevokeSyncConsent() on iOS and Android, which will force callers like the ProfileSyncService to simply force clear the primary account when this happens. * ChromeOS ASH cannot clear the primary account, so the method ClearPrimaryAccount() does not exist on this platform. Bug: 1155505 Change-Id: I9e8b0764599d38d53063764695d91d29de05d154 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2573082Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#834928}
-
Trent Begin authored
Remove outdated information from function comment. Bug: None Change-Id: I892cffea3f6a64cf1160d97102fe3778d2d1c3bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580599 Commit-Queue: Trent Begin <tbegin@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Auto-Submit: Trent Begin <tbegin@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#834927}
-
Andrew Xu authored
Sometime disabling a view is a part of implementation details. For example, a view is removed in asynchronous way. For safety, the view is disabled to prevent it from handling events before the callback runs. In this case, an a11y user cares more about the view's removal. Hence, announcing the change in view enabling state is redundant here. This CL creates an API to override the view enabling state. Bug: 1150503 Change-Id: I92150d949cf6d0ffc45e463116248bd8e8057c4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576342Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/3bf980426002..26a24ee9aebf If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ie937929fd7e579fab03bdf23ee7a1927839122a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580541Reviewed-by:
-
Lan Wei authored
Use testdriver Action API to simulate key actions in input-events/input-events-cut-paste.html. We have to disable it because we do not support key actions in gpuBenchmarking when running the tests in our chromium bots. We added a duplicate web_test fast/events/inputevents/input-events-cut-paste.html to maintain Chrome's test coverage. Bug: 1145677 Change-Id: I1a1453bc7c4ff279c5c91ddf8b679230e92a1e08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2524512Reviewed-by:
Lan Wei <lanwei@chromium.org> Reviewed-by:
Mustaq Ahmed <mustaq@chromium.org> Commit-Queue: Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/heads/master@{#834924}
-
Andres Calderon Jaramillo authored
This is needed so that use_vaapi is false on Chromecast. Before this CL, this was causing troubles with a build [1, 2]. [1] https://chromium-review.googlesource.com/c/chromium/src/+/2578836 [2] https://ci.chromium.org/ui/p/chromium/builders/ci/Cast%20Audio%20Linux/92923/overview Bug: b:173167846 Test: None Change-Id: I5d33790d81e50f099decc1ae03c159a3dc575dcf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580449Reviewed-by:
Ted Meyer <tmathmeyer@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Andres Calderon Jaramillo <andrescj@chromium.org> Cr-Commit-Position: refs/heads/master@{#834923}
-
Chong Gu authored
Add --code-coverage flag for gathering profiling information. Allow Target class to copy directories from the Fuchsia target. Bug: 1156292,1156768 Change-Id: I1fac55bc23f06f5a46f7fef355087f79f9cd0727 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577998 Commit-Queue: Chong Gu <chonggu@google.com> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Auto-Submit: Chong Gu <chonggu@google.com> Cr-Commit-Position: refs/heads/master@{#834922}
-
Tanya Gupta authored
Change-Id: I169709713c74ba23a0721484cf7be483d87552a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552574Reviewed-by:
Calder Kitagawa <ckitagawa@chromium.org> Reviewed-by:
Kyle Milka <kmilka@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Jinsuk Kim <jinsukkim@chromium.org> Commit-Queue: Tanya Gupta <tgupta@chromium.org> Cr-Commit-Position: refs/heads/master@{#834921}
-
Ali Juma authored
Now that WKBasedNavigationManagerImpl is the only kind of NavigationManagerImpl, merge it back into NavigationManagerImpl to simplify code. Bug: 738020 Change-Id: I64e6b856df89a96a6c6d363b6e99ad5cfaa524a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580460Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Ali Juma <ajuma@chromium.org> Cr-Commit-Position: refs/heads/master@{#834920}
-
Josh Santana authored
Renamed methods and variables that use the term "blacklist" for "never prompt" and fixed affected files. Bug: 1028966 Change-Id: Id6145a9410feeb26c6c1e4b8fd9c5cd552c398c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576948 Commit-Queue: Joshua Santana <joshsantana@google.com> Reviewed-by:
Josh Simmons <jds@google.com> Reviewed-by:
Trevor Perrier <perrier@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Megan Jablonski <megjablon@chromium.org> Cr-Commit-Position: refs/heads/master@{#834919}
-
Nancy Wang authored
This CL adds the SaveAppLaunchInfo interface, and the class AppLaunchInfo, as the parameter for SaveAppLaunchInfo. Modify web apps publisher to call SaveAppLaunchInfo to save the launch parameters for system web apps, and web apps not opened as a browser's tab. BUG=1146900 Change-Id: Ide9b461835c0d554b60ddf1d47a673d2b41c8a22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576069Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
-
