GitLab

BUG=388194,649710

Review-Url: https://codereview.chromium.org/2390553003
Cr-Commit-Position: refs/heads/master@{#422762}

In order to avoid re-entrancy issues, this CL modifies sensor event
dispatching code and uses postTask to schedule event dispatch.
New test is added to ambient-light-sensor.html that checks if generic
sensor code works correctly when sensor is not supported

BUG=606766

Review-Url: https://codereview.chromium.org/2381913002
Cr-Commit-Position: refs/heads/master@{#422761}

It is useless to launch a rename process directly from a system-level
Chrome. That process can't rename the Chrome executables since it isn't
elevated.

BUG=650981

Review-Url: https://codereview.chromium.org/2382493002
Cr-Commit-Position: refs/heads/master@{#422760}

Notable changes:none

BUG=651816
TEST=none

Review-Url: https://codereview.chromium.org/2375023006
Cr-Commit-Position: refs/heads/master@{#422759}

If-statement prevents a crash in a unittest that would occur if rolling
after the WebRTC change.

The WebRTC change: https://codereview.webrtc.org/2387343002/

BUG=chromium:627816

Review-Url: https://codereview.chromium.org/2390743003
Cr-Commit-Position: refs/heads/master@{#422758}

1. Update to match new signature of WebContentsCreated.

2. Allow IO in the newly added renderer command prefix test.

Review-Url: https://codereview.chromium.org/2394463002
Cr-Commit-Position: refs/heads/master@{#422757}

Revert of Prune createVisibleSelectionDeprecated from SelectionAdjuster (patchset #1 id:1 of https://codereview.chromium.org/2389653002/ )

Reason for revert:
Suspected of causing crbug.com/652301

Original issue's description:
> Prune createVisibleSelectionDeprecated from SelectionAdjuster
>
> BUG=651373
>
> Committed: https://crrev.com/1301c7b47926fa0d435c2f396a6aeba2a4d179c1
> Cr-Commit-Position: refs/heads/master@{#422380}

TBR=yosin@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=651373

Review-Url: https://codereview.chromium.org/2391973002
Cr-Commit-Position: refs/heads/master@{#422756}

BUG=563793

Review-Url: https://codereview.chromium.org/2391943003
Cr-Commit-Position: refs/heads/master@{#422755}

These benchmarks were failing for the same underlying reason as
smoothness.tough_webgl_ad_cases, which was fixed by
https://codereview.chromium.org/2373983005.

BUG=647413
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq

Review-Url: https://codereview.chromium.org/2386093002
Cr-Commit-Position: refs/heads/master@{#422754}

This changes the way the resource score is computed in the
resource_prefetch_predictor. It takes into account the request priority
as the most important feature, then resource type, then average position.

The rationale is that resource priority surfaces the render-blocking
resources, that are the most critical to prefetch.

BUG=631966

Review-Url: https://codereview.chromium.org/2385173002
Cr-Commit-Position: refs/heads/master@{#422753}

BUG=651431

Review-Url: https://codereview.chromium.org/2382233002
Cr-Commit-Position: refs/heads/master@{#422752}

This does not change the generated code at all.

BUG=460722

Review-Url: https://codereview.chromium.org/2380383003
Cr-Commit-Position: refs/heads/master@{#422751}

WebPermissionClient.h was removed in
crrev.com/9f21f26b

Removing some remnants

Review-Url: https://codereview.chromium.org/2387053002
Cr-Commit-Position: refs/heads/master@{#422750}

Notable changes:none

BUG=651816
TEST=none

Review-Url: https://codereview.chromium.org/2380933005
Cr-Commit-Position: refs/heads/master@{#422749}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/eb2b7fdc..6b7a634b

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2389833003
Cr-Commit-Position: refs/heads/master@{#422748}

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/fee67c6802805c049ddf19e436fb00ad8416032f Revert of Disable local fallback in goma staging environment (patchset #2 id:20001 of https://codereview.chromium.org/2392853002/ ) (tikuta@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG=

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2391733003
Cr-Commit-Position: refs/heads/master@{#422747}

Before this CL the http/tests/webaudio/autoplay-crossorigin.html layout
test would fail if the main frame and the cross-origin frame are in
different renderer processes.  After this CL, the internal settings are
set from the same frame that hosts AudioContext object - this ensures
that setting the settings and getting the settings happens from the same
renderer process (and consequently ensures that the test passes both
with and without --site-per-process flag).

BUG=652366

Review-Url: https://codereview.chromium.org/2389963002
Cr-Commit-Position: refs/heads/master@{#422746}

e2df1d70 adds a new parameter to
WebContentsDelegate::WebContentsCreated. This CL updates the
implementation in headless_web_contents_impl.cc accordingly.

BUG=649855
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2385123004
Cr-Commit-Position: refs/heads/master@{#422745}

A permission descriptor is a structure describing a permission that an
origin may request. Most permissions are only identified by their names
but some have additional parameters. For example, a Bluetooth device
permission may include the MAC address of the device (or other unique
identifier) so that the permission applies to only the device selected
by the user through some sort of chooser interface.

BUG=638721

Review-Url: https://codereview.chromium.org/2255933002
Cr-Commit-Position: refs/heads/master@{#422744}

It is uncommon to use command-line-switch-style for base::Feature
names. This CL fixes the feature name for kFlashJoinsMediaSession.

BUG=619084

Review-Url: https://codereview.chromium.org/2390633002
Cr-Commit-Position: refs/heads/master@{#422743}

This CL replaces createDoneDataConsumerHandle and
createUnexpecteErrorDataConsumerHandle with BytesConsumer::createDone
and BytesConsumer::createErrored respectively. This CL also makes
BodyStreamBuffer update its status synchronously at the construction
time.

This CL also removes a BodyStreamBuffer constructor that takes a
FetchDataConsumerHandle.

BUG=610195

Review-Url: https://codereview.chromium.org/2392823002
Cr-Commit-Position: refs/heads/master@{#422742}

9-16 bit video channel will use it.

BUG=445071, 624436
TEST=gl_tests --gtest_filter=GpuMemoryBufferTest*
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2376293003
Cr-Commit-Position: refs/heads/master@{#422741}

The counter was separated from the container in
https://codereview.chromium.org/588583002, in preparation for componentisation
which never happened. As jam@ points out in
https://codereview.chromium.org/2375333003/#msg9, it should be cleaned-up.

This is in effect a revert of https://codereview.chromium.org/588583002 and https://codereview.chromium.org/640733002, only done manually, because the code has changed since those CLs landed.

BUG=384873

Review-Url: https://codereview.chromium.org/2380943004
Cr-Commit-Position: refs/heads/master@{#422740}

On Android (and soon iOS), we track what kind of tile we show on the NTP
so that we can compare different kinds of clicks in UMA. The results are
probably no surprise: click rate for colored tiles is about twice that
of default-colored tiles (though it's not necessarily clear how much to
attribute that to our presentation and how much to the fact that good
sites generally have favicons).

Right now we have the default background color hard-coded in a few
places and use that to determine when a tile is default-colored. This is
possibly incorrect (when #787878 is in fact the dominant color) and
generally bad (constants can get out of sync).

This CL adds `bool FallbackIconStyle::is_default_background_color`, so
we can check that instead of comparing colors, and threads it through to
Android. It also deletes a few copies of the color constant. Three
copies remain: the authoritative copy in fallback_icon_style.cc, one in
its test, and one in Android's colors.xml.

BUG=651056

Review-Url: https://codereview.chromium.org/2374753002
Cr-Commit-Position: refs/heads/master@{#422739}

Revert of Integrate registry_hash_store_contents with the rest of tracked prefs. (patchset #24 id:460001 of https://codereview.chromium.org/2204943002/ )

Reason for revert:
This CL is suspect of breaking WebRTC Windows bots.
I will reland if it doesn't fix the problem.

See, for example, https://build.chromium.org/p/chromium.webrtc/builders/Win7%20Tester/builds/30007/steps/browser_tests/logs/stdio

[4936:6236:0930/181348:INFO:webrtc_video_quality_browsertest.cc(245)] Running "C:\b\depot_tools\python276_bin\python.exe" -u "C:\b\c\b\Win7_Tester\src\third_party/webrtc/tools/compare_videos.py" --label=720p_VP9 --ref_video "C:\b\c\b\Win7_Tester\src\chrome\test\data\webrtc/resources\reference_video_1280x720_30fps.yuv" --test_video "C:\Users\CHROME~1.LAB\AppData\Local\Temp\scoped_dir4936_9527\captured_video.yuv" --frame_analyzer "C:\b\c\b\Win7_Tester\src\out\Release\frame_analyzer.exe" --yuv_frame_width 1280 --yuv_frame_height 720 --zxing_path "C:\b\c\b\Win7_Tester\src\chrome\test\data\webrtc/resources\tools\win\zxing.exe" --ffmpeg_path "C:\b\c\b\Win7_Tester\src\chrome\test\data\webrtc/resources\tools\win\ffmpeg.exe" --stats_file "C:\Users\CHROME~1.LAB\AppData\Local\Temp\scoped_dir4936_9527\stats.txt"
[4936:6236:0930/181420:INFO:user_input_monitor_win.cc(171)] RegisterRawInputDevices() failed for RIDEV_REMOVE: The parameter is incorrect. (0x57)
[4936:6236:0930/181421:FATAL:json_pref_store.cc(385)] Check failed: !has_pending_write_callbacks_.
Backtrace:
	base::debug::StackTrace::StackTrace [0x02BA3CF7+23]
	logging::LogMessage::~LogMessage [0x02B5B061+49]
	JsonPrefStore::RegisterOnNextWriteSynchronousCallbacks [0x03668FDF+154]
	JsonPrefStore::SerializeData [0x03669601+179]
	base::ImportantFileWriter::DoScheduledWrite [0x02BE4B15+149]
	JsonPrefStore::CommitPendingWrite [0x0366803E+120]
	JsonPrefStore::~JsonPrefStore [0x03667DF8+21]
	scoped_refptr<TestingPrefStore>::Release [0x056591C1+23]
	SegregatedPrefStore::~SegregatedPrefStore [0x04359463+95]
	scoped_refptr<TestingPrefStore>::Release [0x056591C1+23]
	PrefService::~PrefService [0x03663ED9+141]
	syncable_prefs::PrefServiceSyncable::~PrefServiceSyncable [0x04088703+93]
	syncable_prefs::PrefServiceSyncable::`scalar deleting destructor' [0x04088714+11]
	ProfileImpl::~ProfileImpl [0x02C5706B+271]
	ProfileDestroyer::DestroyProfileWhenAppropriate [0x02D1A381+484]
	ProfileManager::ProfileInfo::~ProfileInfo [0x02C04D62+14]
	std::_Tree<std::_Tmap_traits<base::FilePath,linked_ptr<ProfileManager::ProfileInfo>,std::less<base::FilePath>,std::allocator<std::pair<base::FilePath const ,linked_ptr<ProfileManager::ProfileInfo> > >,0> >::_Erase [0x02B54889+41]
	std::_Tree<std::_Tmap_traits<base::FilePath,linked_ptr<ProfileManager::ProfileInfo>,std::less<base::FilePath>,std::allocator<std::pair<base::FilePath const ,linked_ptr<ProfileManager::ProfileInfo> > >,0> >::clear [0x02B548B2+13]
	std::_Tree<std::_Tmap_traits<base::FilePath,linked_ptr<ProfileManager::ProfileInfo>,std::less<base::FilePath>,std::allocator<std::pair<base::FilePath const ,linked_ptr<ProfileManager::ProfileInfo> > >,0> >::~_Tree<std::_Tmap_traits<base::FilePath,linked_p [0x02C04D0E+21]
	ProfileManager::~ProfileManager [0x02C04DAF+54]
	BrowserProcessImpl::StartTearDown [0x02DD70E9+458]
	ChromeBrowserMainParts::PostMainMessageLoopRun [0x02E333B0+304]
	content::BrowserMainLoop::ShutdownThreadsAndCleanUp [0x024E327A+350]
	content::BrowserMainRunnerImpl::Shutdown [0x024E4498+632]
	content::BrowserMain [0x024DFE41+139]
	content::RunNamedProcessTypeMain [0x02B46FAB+206]
	content::ContentMainRunnerImpl::Run [0x02B46EAC+274]
	content::ContentMain [0x02B46275+35]
	content::BrowserTestBase::SetUp [0x02F73565+964]
	InProcessBrowserTest::SetUp [0x02BF45D7+268]
	testing::internal::HandleExceptionsInMethodIfSupported<testing::TestCase,void> [0x033F7AB9+32]
	testing::Test::Run [0x033FEAA3+51]
	testing::TestCase::Run [0x033FEB79+133]
	testing::internal::UnitTestImpl::RunAllTests [0x033FEEF8+433]
	testing::internal::HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl,bool> [0x033F7AFD+32]
	testing::UnitTest::Run [0x033FED22+133]
	base::TestSuite::Run [0x02BFD110+95]
	ChromeTestSuiteRunner::RunTestSuite [0x052456CE+40]
	content::LaunchTests [0x02F6D485+585]
	LaunchChromeTests [0x052456A1+49]
	main [0x052454BA+63]
	__scrt_common_main_seh [0x0520AD1F+249] (f:\dd\vctools\crt\vcstartup\src\startup\exe_common.inl:253)
	BaseThreadInitThunk [0x75A0338A+18]
	RtlInitializeExceptionChain [0x77899902+99]
	RtlInitializeExceptionChain [0x778998D5+54]

Original issue's description:
> Integrate registry_hash_store_contents with the rest of tracked prefs.
>
> This change adds Windows-only logic to the PrefHashFilter such that it
> verifies preferences against MACs stored in the registry. Unlike the
> current tracked preference logic, this extra check does NOT reset
> settings.
>
> To avoid inconsistent state with the MACs in secure_preferences, we
> clear the registry MACs before writing secure_preferences, and write
> the registry MACs after the file is successfully written.
>
> BUG=624858
>
> Committed: https://crrev.com/4683dfcecfa72a73e00498d7c06fcf6716f8366c
> Cr-Commit-Position: refs/heads/master@{#422240}

TBR=gab@chromium.org,proberge@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=624858

Review-Url: https://codereview.chromium.org/2396443002
Cr-Commit-Position: refs/heads/master@{#422738}

Now that we keep track of subframe navigations in FrameNavigationEntry,
this CL move the redirect_chain field from NavigationEntry to
FrameNavigationEntry.

BUG=649879
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2368183004
Cr-Commit-Position: refs/heads/master@{#422737}

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/32eebb8c482d73dbc453dfdce62e46d4c8ee19a1 Disable local fallback in goma staging environment (tikuta@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG=

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2396453002
Cr-Commit-Position: refs/heads/master@{#422736}

Revert of Send a TrackedPreference incident when registry pref validation fails. (patchset #3 id:40001 of https://codereview.chromium.org/2384213002/ )

Reason for revert:
Parent CL https://codereview.chromium.org/2204943002 is suspect of breaking WebRTC Win Tester bots.

See https://build.chromium.org/p/chromium.webrtc/builders/Win8%20Tester/builds/28938

Original issue's description:
> Send a TrackedPreference incident when registry pref validation fails.
>
> Note that the new incident types (BYPASS_CLEARED and BYPASS_CHANGED) are only
> used when external (registry) validation fails and existing
> (secure_preferences-based) validation succeeds.
>
> BUG=624858
>
> Committed: https://crrev.com/1ba5bcd1a74380bb398eeab3787ede5620b5130c
> Cr-Commit-Position: refs/heads/master@{#422545}

TBR=jialiul@chromium.org,caitkp@chromium.org,gab@chromium.org,proberge@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=624858

Review-Url: https://codereview.chromium.org/2390213002
Cr-Commit-Position: refs/heads/master@{#422735}

Currently, the responsibility of the ARC auth code
control flow was distributed across ArcAuthService
ArcSupportHost and background.js etc. This CL removes
it from background.js, as a preparation to move all
of them into a manageable form.

Now, background.js has two types of messages. 1) Action,
which is sent from the native code, to do something in
extension, and 2) Event to notify to the native code
that something (e.g., user clieck etc.) is happend in the
extension

BUG=b/31079732
TEST=Ran on test device. Ran tests.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2388763002
Cr-Commit-Position: refs/heads/master@{#422734}

This DCHECK was commented out in Apr 2014
(https://chromium.googlesource.com/chromium/src/+/8a343ad96e4ca48eb665a77a6db8beb4357fe67c)
because it was causing Chrome OS test failures. Since this assertion has been
ignored for 2.5 years and the logic in this part of the code has since changed,
it is not clear that this assertion would be useful if it were ever re-enabled.

BUG=365507

Review-Url: https://codereview.chromium.org/2390803004
Cr-Commit-Position: refs/heads/master@{#422733}

This CL prevents redirect timing to be set to zero when there is no
redirection.

BUG=576261

Review-Url: https://codereview.chromium.org/2368883003
Cr-Commit-Position: refs/heads/master@{#422732}

This patch avoids using raw pointers to AtomicString contents for
animation PropertyHandles. By making the AtomicString class a member
all the necessary reference counting occurs.

BUG=652127

Review-Url: https://codereview.chromium.org/2390203002
Cr-Commit-Position: refs/heads/master@{#422731}

The BluetoothAudioSink code does not seem to be used from anywhere. The
code is currently just bloat. If we decide in the future to use this code,
we can always re-add it back again by reverting this CL.

Reviews requested,
ortuno@ or scheib@ - OWNERs
mcchou@ - original author of the code, hence general review.

R=mcchou@chromium.org, ortuno@chromium.org, scheib@chromium.org
BUG=None

Review-Url: https://codereview.chromium.org/2389753003
Cr-Commit-Position: refs/heads/master@{#422730}

This CL implements mojom client on blink side.
 - FaceDetector::detect() sends an image to the browser through shared_buffer;
 - FaceDetector::onDetectFace() receives a list of boundingBoxes from Chrome.
A mock mojom server is added to test the connection.

This CL also reduces the API surface by removing Detector and DetectedObject
interface, so that the hierarchy is simpler and cleaner.

BUG=646083
TEST=Pass LayoutTest detectface.html

Review-Url: https://codereview.chromium.org/2369693002
Cr-Commit-Position: refs/heads/master@{#422729}

Cr-Commit-Position: refs/heads/master@{#422728}

BUG=314403

Review-Url: https://codereview.chromium.org/2374943002
Cr-Commit-Position: refs/heads/master@{#422727}

Generated with https://codereview.chromium.org/2056153003/.

BUG=581865
R=sky@chromium.org,xiyuan@chromium.org
TBR=stevenjb@chromium.org

Review-Url: https://codereview.chromium.org/2392693002
Cr-Commit-Position: refs/heads/master@{#422726}

This CL adds a check of synchronousPolicy to
ResourceLoaderOptions::canReuseRequest() to avoid Resources to be reused
between sync and async requests.
This CL also removes a condition from
ResourceFetcher::determineRevalidationPolicy() that is covered by the newly
added check.

CachingCorrectnessTest is updated so that it doesn't use synchronous
RawResource requests.

BUG=652172

Review-Url: https://codereview.chromium.org/2391523002
Cr-Commit-Position: refs/heads/master@{#422725}

Cr-Commit-Position: refs/heads/master@{#422724}

Currently ArcDownloadsWatcherService requests Android media provider to
scan every new/modified files under the Downloads directory. It causes
heavy load when many files are created/deleted there.

This change excludes files not supported by Android media scanner.

BUG=chromium:651731
TEST=touch a.txt  # Not scanned
TEST=touch a.png  # Scanned
TEST=unit_tests --gtest_filter='ArcDownloadsWatcherServiceTest.*'

Review-Url: https://codereview.chromium.org/2379323002
Cr-Commit-Position: refs/heads/master@{#422723}