- 05 Jun, 2019 40 commits
-
-
Xiyuan Xia authored
Bug: 958229 Change-Id: I444c8a563c328efcbfebe1426ddec692d41a171a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1643757Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#666268}
-
Xida Chen authored
TBR=gayane@chromium.org NOTRY=true Bug: 922951 Change-Id: Icdf09cc7c60f19ef7aaf8fa32503445f5c3c617c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1645202Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#666267}
-
Pavel Shmakov authored
Based on flakiness dashboard: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=network_service_out_of_process_chrome_public_test_apk&tests=org.chromium.chrome.browser.profiling_host.ProfilingProcessHostAndroidTest TBR=erikchen@chromium.org,tedchoc@chromium.org Bug: 970205 Change-Id: Ia2164945ceecab937403e4c69e0d407b454e61d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1645228 Commit-Queue: Pavel Shmakov <pshmakov@chromium.org> Reviewed-by:
Pavel Shmakov <pshmakov@chromium.org> Cr-Commit-Position: refs/heads/master@{#666266}
-
Mario Sanchez Prada authored
This is no longer used now that we have removed PushMessagingClient from //content/renderer, so we can safely remove it. Bug: 939943 Change-Id: If7074fb428b25f16482d91940d84c48fd71bc3bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631403 Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#666265}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f6dc12884b53..bc5e8283ebb0 Created with: gclient setdep -r src-internal@bc5e8283ebb0 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=xidachen@google.com,gayane@google.com,calamity@google.com,kinuko@google.com Change-Id: I78823431426d4de688a5c4c1adde19a018626765 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1645176Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#666264}
-
Elly Fong-Jones authored
On the slower macOS bots, this test sometimes takes ~150ms longer than kLargeResponseTimeoutMs for some of the timeout tests, so bump up the threshold for success. Bug: 905265 Change-Id: I0a968a0075d5ea7448f327a07ec36389de25fe7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642737 Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Joe Downing <joedow@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#666263}
-
Tanmoy Mollik authored
This cl is part of the effort to use CoreAccountId instead of std::string to denote account_id. Bug: 959157 Change-Id: Ib0b41739551932824fc383dc869a3f9f5ab7dcf7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642637 Commit-Queue: Tanmoy Mollik <triploblastic@google.com> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#666262}
-
Jit Yao Yap authored
Change-Id: I41a7558c411870a106a7f5766f68c91a136ad579 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1645354Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Jit Yao Yap <jityao@google.com> Cr-Commit-Position: refs/heads/master@{#666261}
-
Pavel Shmakov authored
Disable flaky ServicificationBackgroundServiceTest#testHistogramsPersistedWithServiceManagerOnlyStart TBR=hanxi@chromium.org,tedchoc@chromium.org Bug: 970190 Change-Id: Iddad9df7ad507ede7f164e6702a535fd0ae2bcbf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1645227Reviewed-by:
-
arthursonzogni authored
Previously, navigation to a MHTML subframe was handled by the renderer process. This CL makes it use the normal path (e.g. driven by the browser process). After this and two other edge cases (about:blank, about:srcdoc) will be removed, then every navigation to a new document will be driven by the browser process. * Stricter enforcement could be added for https://crbug.com/943610. * It unblocks RenderDocument https://crbug.com/936696. Note: Some error pages will still be able to be driven by the renderer process. Others related CLs: * https://chromium-review.googlesource.com/c/chromium/src/+/1578544 * https://chromium-review.googlesource.com/c/chromium/src/+/1547522 Bug: 936696 Change-Id: If030dcc43dcc038a588285a639ea08b755310094 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1547521 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#666259}
-
Xida Chen authored
TBR=gayane@chromium.org NOTRY=true Bug: 856601 Change-Id: I03801abfea02047bbe200958d7a8bc7a560c7710 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1644994Reviewed-by:
-
Denis Kuznetsov authored
Bug=b:133461735 Change-Id: Ib75f9977dd9b5aa044fa9844dfcf35f27e0fd548 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628718Reviewed-by:
Sergey Poromov <poromov@chromium.org> Commit-Queue: Denis Kuznetsov <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#666257}
-
Xida Chen authored
This is MSAN only. TBR=gayane@chromium.org NOTRY=true Bug: 856601 Change-Id: I623d7f5833d92aa5d9227c623069e7c53810cda3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1644993Reviewed-by:
-
Mario Sanchez Prada authored
Now that we have blink::PushMessagingClient, which is also frame-bound, we no longer need this helper class since we'll communicate over mojo right from Blink, without needing to interact with //content at all. Thus, we can remove this class, as it's no longer used anywhere. Bug: 939943 Change-Id: I41528d3c7048040b2cf854ee7991f0a21e8b6e1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631595 Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Reviewed-by:
-
Mario Sanchez Prada authored
We now use DocumentInterfaceBroker to communicate with the RenderFrame in the browser process, so we don't need to pass a routing ID for the render frame anymore. This CL removes the parameter and all its references from callsites, which were already passing -1 (invalid ID) anyway. Bug: 939943 Change-Id: I3cecd93de28feff24722a7870673225512dfd8ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1638545 Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#666254}
-
Antonio Gomes authored
This CL removes the redundant enum MediaStreamRequestResult, defined in [1], in favor of the mojom existing variant in [2]. [1] third_party/blink/public/common/mediastream/media_stream_request.h [2] third_party/blink/public/mojom/mediastream/media_stream.mojom The associated typemap [3] and traits declarations [4][5] are also removed. [3] third_party/blink/public/common/mediastream/media_stream.typemap [4] third_party/blink/common/mediastream/media_stream_mojom_traits.cc [5] hird_party/blink/public/common/mediastream/media_stream_mojom_traits.h TBR=haraken@chromium.org BUG=923394,919392 This is a reland of https://crrev.com/c/1639237. Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1639237 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#665431} Change-Id: I7af5c650648c53f1ef9763fb5a12b32fa0c0544c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642734 Cr-Commit-Position: refs/heads/master@{#666253}
-
Pavel Shmakov authored
TBR=szermatt@chromium.org Bug: 970219 Change-Id: I00ac5f6d684a6be77eb692f901fafd323227aebd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1645226Reviewed-by:
Stephane Zermatten <szermatt@chromium.org> Commit-Queue: Pavel Shmakov <pshmakov@chromium.org> Cr-Commit-Position: refs/heads/master@{#666252}
-
Xida Chen authored
The specific one is virtual/blink-cors/http/tests/security/contentSecurityPolicy/require-sri-for/require-sri-for-script-preload-allowed.php The original test is already marked flaky. TBR=gayane@chromium.org NOTRY=true Bug: 678499 Change-Id: I7d220e6aa12bd4079d392021e387e7cac1422fb1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1644935Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/082a93c5faa3..a6e239978796 git log 082a93c5faa3..a6e239978796 --date=short --no-merges --format='%ad %ae %s' 2019-06-05 perezju@chromium.org [Telemetry] Add story_run.AsDict method Created with: gclient setdep -r src/third_party/catapult@a6e239978796 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:966835 TBR=skyostil@google.com Change-Id: I3b917cc089811a3c77ce590a645c14c2129f1fb3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1645125Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#666250}
-
Xida Chen authored
The specific test is virtual/blink-cors/http/tests/security/offscreencanvas-placeholder-read-blocked-no-crossorigin.html is comes from a virtual test suite. The original version of this is already skipped and has a bug associated with it. TBR=gayane@chromium.org NOTRY=true Bug: 922951 Change-Id: I091ddd40fa96f73ac4d832920cdcf2b002d978bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1645374Reviewed-by:
-
Roman Sorokin authored
Both oobe_dialog_host.css and screen_gaia_signin.css had :host rules. Removed one from screen_gaia_signin.css Also removed v2 class - introduced saml-interstitial class. Alternative would be to keep saml-interstitial with the same size and not shirk it Bug: 971172 Change-Id: Ib9e93c4bc347910286812114df29579467c0b2cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1645360Reviewed-by:
Denis Kuznetsov <antrim@chromium.org> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#666248}
-
Stephen Chenney authored
Drawing a 100px x 100px div with border radius 50px is not the same as with border radius calc(100% - 1px) = 99px. R=foolip@chromium.org BUG=968430 Change-Id: I953c26b72d55d930cdbbcfa969f38b892e3151f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1639566 Auto-Submit: Stephen Chenney <schenney@chromium.org> Commit-Queue: Philip Jägenstedt <foolip@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#666247}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/80255d87a852..f6dc12884b53 Created with: gclient setdep -r src-internal@f6dc12884b53 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=xidachen@google.com,gayane@google.com,calamity@google.com,kinuko@google.com Change-Id: I88f5e59de71b08e8f1394e82eca55a053e42884b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1645175Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/82e7e7a3..13da560b Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ic7cb18c61ebee265facd13e6bd32db77a56e3516 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1645372Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#666245}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 40bc2a0e. With Chromium commits locally applied on WPT: e90c6ef0 "NG/DL: Implement size containment (and display lock) for NG fieldset algo" abf2ac5e "webrtc wpt: avoid race conditions" 1bbbd106 "Add feature policy for client hints, used for third-party subresources." ab94a58b "Add the remaining Client Hints to Feature Policy." a5b31124 "DetachLayoutTree clear hover/active state on dom removal." 04c3df15 "Canvas::TestMetrics: Measure the TextMetrics info after loading the font" 2d4812d4 "[css-contain] Fix <select> dimensions with size containment" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: igrigorik@chromium.org, yoavweiss@chromium.org: external/wpt/preload NOAUTOREVERT=true TBR=foolip No-Export: true Change-Id: Ie398bf1d5ba104960265ed368d0bf31dfb9e032d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1645492Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#666244}
-
Mythri A authored
We would like to run a finch trial on this feature. Bug: v8:8394 Change-Id: Iecac081955574c4add95627e10c3dbd5eda547c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642640Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Commit-Queue: Mythri Alle <mythria@chromium.org> Cr-Commit-Position: refs/heads/master@{#666243}
-
Eugene But authored
This target does not include sources yet, because existing tests are not EG2 compatible yet. Bug: 922813 Change-Id: I75aac839686946eb73cc893ae3235ca7fed9ba48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642113 Auto-Submit: Eugene But <eugenebut@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#666242}
-
Carlos Caballero authored
It is no longer used, and you should be posting tasks with BEST_EFFORT priority instead. Bug: 887407 Change-Id: I3792d648a5a9702ccdf08859b7bf65b58c5dbafe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1645215 Auto-Submit: Carlos Caballero <carlscab@google.com> Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#666241}
-
Eugene But authored
This test will be ported to EG2 and EG2 can not depend on chrome app classes like OmniboxPopupRow. Bug: 922813 Change-Id: I5b1ae3f263b18117f52322d22266c4db6fad4bf3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642138 Auto-Submit: Eugene But <eugenebut@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
-
Henrique Ferreiro authored
After some of the CLs from https://crbug.com/952766, SigninManager no longer needs access to some of SigninManagerBase members. These CL makes those member private instead of protected. Bug: 952766 Change-Id: I8b6e190a027234cb931de05d0d2969289bd6f4b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1643538Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Cr-Commit-Position: refs/heads/master@{#666239}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/ac79ca16c651..9893f8e15152 git log ac79ca16c651..9893f8e15152 --date=short --no-merges --format='%ad %ae %s' 2019-06-05 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 2dd40a44d1a6..3c219171135d (5 commits) 2019-06-05 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src ce989eac..72cb69b7 (348 commits) 2019-06-05 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 79d4ac9ab695..5b424e69101a (2 commits) 2019-06-05 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-06-04 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-06-04 mtklein@google.com print 1/K floats as fractions 2019-06-04 mtklein@google.com move peepholes where they're relevant 2019-06-04 fmalita@chromium.org [skottie] Initial text range selector support 2019-06-04 mtklein@google.com print SKVM test failures 2019-06-04 mtklein@google.com allow two immediates 2019-06-04 robertphillips@google.com Make color initialization version of createBackendTexture public 2019-06-04 mtklein@google.com add SkVMBuilders.* to DM deps in G3 2019-06-04 michaelludwig@google.com Extract GrQuadList into separate header 2019-06-04 borenet@google.com [infra] Fixes for chrome_release_branch 2019-06-04 mtklein@google.com dump register and instruction count 2019-06-04 mtklein@google.com add extract instruction 2019-06-04 mtklein@google.com add pack instruction 2019-06-04 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-06-04 mtklein@google.com add mul_unorm8 instruction 2019-06-04 mtklein@google.com centralize test/bench SkVM builders Created with: gclient setdep -r src/third_party/skia@9893f8e15152 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jcgregorio@google.com Change-Id: Ib407a179e3d2c135e8f676685de2cec37e8044f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1645054Reviewed-by:
-
Henrique Ferreiro authored
This CL moves SigninManager’s observing of ProfileOAuth2TokenService::OnRefreshTokensLoaded() to SigninManagerBase, if’def-d out on ChromeOS. This is a step in eliminating the inheritance relationship between SigninManager and SigninManagerBase, as motivated in this design doc: https://docs.google.com/document/d/15y-Db27BV08vrIyelHB-3CwiAfDYh-FigNKGXrqSWto/edit#heading=h.8jjdy95t6p7x and described concretely here: https://docs.google.com/document/d/15y-Db27BV08vrIyelHB-3CwiAfDYh-FigNKGXrqSWto/edit#heading=h.mbkrv9nkb93w The functionality is ifdef-d out on ChromeOS, as it is currently not used on that platform. Bug: 952766 Change-Id: Icafd01997b140c34c560fca642356c41197eb24a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635614 Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Reviewed-by:
-
Mario Sanchez Prada authored
As part of the Onion Soup effort to move the PushMessaging feature into Blink, we need to get rid of this class now that is no longer used, since the implementation of mojom::PushMessaging inside of //content/browser (content::PushMessagingManager) communicates now directly with Blink's blink::PushMessagingClient. Bug: 939943 Change-Id: Ibe2eefce97a0bf52e98f28a7c540b998afc6fd3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631402 Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Reviewed-by:
-
Dominik Röttsches authored
https://chromium.googlesource.com/external/github.com/harfbuzz/harfbuzz.git/+log/97b926857759..659eeddb2df5 $ git log 97b926857..659eeddb2 --date=short --no-merges --format='%ad %ae %s' 2019-06-03 bruce.mitchener Use C++11 override keyword. 2019-06-01 corbett.dav [myanmar] Make medial_group match the OT spec 2019-05-29 qxliu [subset] Hmtx/vmtx tables to use subset2 and new iterator frameworks 2019-06-03 ariza added parentheses to FDSelect::sanitize as well 2019-06-03 ariza added test data 2019-06-03 ariza parenthesized cond-exp in CFF2FDSelect::sanitize 2019-06-03 ebrahim Reapply possible bsearch overflow fix 2019-06-03 bruce.mitchener test: Use nullptr in C++ code. (#1744) 2019-06-02 ebrahim [ci] revert to xenial 2019-06-02 ebrahim minor 2019-06-02 ebrahim Use a unified bsearch (#1741) Created with: roll-dep src/third_party/harfbuzz-ng/src R=bashi@chromium.org,behdad@chromium.org,bungeman@chromium.org,drott@chromium.org,eae@chromium.org,jshin@chromium.org Bug: 969261 Tbr: bungeman, eae Change-Id: Ib7c0a4cc9fec1d8f390a8d41dc5cb2ff2b0ffdd1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1645212Reviewed-by:
Dominik Röttsches <drott@chromium.org> Commit-Queue: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#666235}
-
Jan Krcal authored
Bug: 836718 Change-Id: Ie8e1a039d8ef653b5377bb57638cd180dd87e1c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642551Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Commit-Queue: Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#666234}
-
Darren Shen authored
In a previous patch, we changed the MODECHANGE key behaviour so that pressing it once will only show the current input method. This was to follow the UX specs. However, upon consideration, we're going to change it back to the original behaviour of switching to next input method on first key press. The original code used a event rewriter to convert the MODECHANGE key into Ctrl-Shift-Space (which switches to the next key press). We then changed the code to be in ash accelerators because of the extra logic involved. Now that we don't need this extra logic, we could revert back to event rewriter, but we think it's better to keep it in accelerators because we still have some extra logic around histogram logging. TBR=holte@chromium.org Bug: 953901 Change-Id: I2cf4dc41300b62ee6f57085408e199a2a55062b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642487 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by:
-
Sergio Villar Senin authored
They belong to wtf/ and the WTF:: namespace. They're currently placed in the top-level platform/ directory under blink namespace. Bug: 968504 Change-Id: Iea6bb38e5b4406b18c4a264d7ded6d2065a73d58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635821 Commit-Queue: Sergio Villar <svillar@igalia.com> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
-
Friedrich Horschig authored
This CL collapses all code-paths for accessory sheets into one. All sheets now have common classes for coordinator, mediator and model. For the ViewBinders, this would make no sense (since they are static classes used to implement interfaces anyway) and Views are largely shared anyway. The wiring is only partly hidden in these super classes since it would be too difficult to find the connection between ViewBinder, Model and Coordinator if we would just require interfaces [1]. Minor, intentional clean-ups: - Credit Cards now have a UserInfo type representation. - The address sheet isn't any longer in V2 but instead guarded by the same flag as the credit card sheet. [1] I tried and reverted it. It pretty much takes 300 more lines away but then, the whole component becomes very in-transparent. Details to follow. Bug: 902425 Change-Id: Ia44694f72418b5f27a021569bfb3e70a19f24201 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1634736 Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/master@{#666231}
-
Alex Chau authored
- Introduce encryption result enum and callback - Added encryption logic in GcmEncryptionProvider based on EncryptionRoundTrip unit test Bug: 966035 Change-Id: I390651722f89eaf380c8a2e8d43a76ad72d447c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635610Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Alex Chau <alexchau@chromium.org> Auto-Submit: Alex Chau <alexchau@chromium.org> Cr-Commit-Position: refs/heads/master@{#666230}
-
Jan Wilken Dörrie authored
This change removes code duplication between base::BindOnce and base::BindRepeating by introducing a generic base::internal::BindImpl. Bug: 554299 Change-Id: Ia06233baf973d62b458ed5cb3fbded0da865f83b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617775Reviewed-by:
-
