- 03 Mar, 2020 40 commits
-
-
Robbie Gibson authored
Before, if there were suggestions on the NTP, they would immediately appear. The better animation is to scroll the fakebox up to the top of the screen and then present the suggestions. To do this, when entering the omnibox from NTP, we only focus the location bar, which causes the scrolling animation. -fakeboxFocused is already called in the animation completion block, which does the actual work to make the omnibox text field first responder, causing the suggestions to appear. To finish off, the -locationBarDidBecomeFirstResponder code now only focuses the location bar if we are not on the regular NTP. Bug: 1057643 Change-Id: I472ee1ee5693fa4102717275bf266f4ab97e121a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082556 Commit-Queue: Robbie Gibson <rkgibson@google.com> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#746450}
-
Garrett Beaty authored
Mac Builder Next doesn't use a builderless machine; there's one machine that is allocated to it. When the machine was updated to Mac 10.15, its tasks started expiring because the machine no longer matched the os dimension. Change-Id: I039c61f381d0a65204a62b9c1333b1f6b652a416 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083561 Auto-Submit: Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Aaron Gable <agable@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#746449}
-
Jérôme Lebel authored
AdvancedSettingsSigninCoordinator present the advanced settings during sign-in process. This patch add the implementation of AdvancedSettingsSigninCoordinator, and removes the old implementation. See http://go/chrome-ios-signin-migration Bug: 971989 Change-Id: Id60834f575284ba48cdafc4a3b9a8e227a2a43ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050568 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/d5ae9bf042df..f57a5e85c09d git log d5ae9bf042df..f57a5e85c09d --date=short --first-parent --format='%ad %ae %s' 2020-03-03 aerotwist@chromium.org [e2e] Migrates http/tests/devtools/user-metrics-perf.js to e2e 2020-03-03 sigurds@chromium.org [Issues] Add revealer for issues 2020-03-03 tvanderlippe@chromium.org Fix jsdoc for ls function 2020-03-03 gabriel.luong@gmail.com Typecheck common/Console.js with TypeScript 2020-03-03 tvanderlippe@chromium.org Reland "Typecheck Object.js" 2020-03-03 szuend@chromium.org Prepare ResourceMapping.js for asynchronous live locations 2020-03-03 tvanderlippe@chromium.org Add tests to verify sources panel shows lazy-loaded files 2020-03-03 jacktfranklin@chromium.org Remove `String#reverse` in favour of a utility function 2020-03-03 aerotwist@chromium.org [e2e] Adds licences; updates expectations 2020-03-03 szuend@chromium.org [utilities] Use Map + Set instead of Object + Array in ExtensionServer 2020-03-03 liviurau@chromium.org Exception cannot be converted to string 2020-03-03 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. 2020-03-03 wolfi@chromium.org Add button to clear filter in network tab Created with: gclient setdep -r src/third_party/devtools-frontend/src@f57a5e85c09d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1011811,chromium:1032016,chromium:1032561,chromium:1044632,chromium:1046784,chromium:1050549,chromium:1057642,chromium:1057979 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ie39bf2e24076850c7ed2670fb870c9dd07fbbf53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2085018Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#746447}
-
Jose Lopes authored
This is a repeating callback because it's called from a while loop: * https://cs.chromium.org/chromium/src/media/formats/mp2t/es_adapter_video.cc?rcl=3ebd977605c09c89a0205af40d95c4814eed78f0&l=138 This is part of the base::Callback migration. Context: https://cs.chromium.org/chromium/src/docs/callback.md?rcl=9fcc3764aea8f97e9f6de4a9ee61d554e67edcda&l=40 Bug: 714018 Change-Id: I2a8a3c8a75fd8d2ac73ae71082dadf4f0f40af0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080240 Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Auto-Submit: Jose Lopes <jabolopes@google.com> Cr-Commit-Position: refs/heads/master@{#746446}
-
Xing Liu authored
This reverts commit 60d219b6. Reason for revert: breaks android downstream. https://logs.chromium.org/logs/chrome/buildbucket/cr-buildbucket.appspot.com/8886827242049965872/+/steps/compile/0/stdout Original change's description: > [webauthn] Don't adjust timeout when testing > > Move the timeout adjustment from blink to the browser and avoid > adjusting it if we detect a discovery factory override is in place. > > This change makes authenticator browser tests and WPTs 3X faster. > > Fixed: 976428 > Change-Id: Iaea88f356a6d090c14474151b29c04e912c471b8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079043 > Commit-Queue: Nina Satragno <nsatragno@chromium.org> > Reviewed-by: Ken Buchanan <kenrb@chromium.org> > Reviewed-by: Jared Saul <jsaul@google.com> > Cr-Commit-Position: refs/heads/master@{#746432} TBR=kenrb@chromium.org,nsatragno@chromium.org,jsaul@google.com Change-Id: Iab40100ead5acdbc6dc631461470314f9eafc815 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083564Reviewed-by:
Xing Liu <xingliu@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#746445}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/176f3a3dbbc9..abc7a30a06c7 git log 176f3a3dbbc9..abc7a30a06c7 --date=short --first-parent --format='%ad %ae %s' 2020-03-03 capn@google.com Fix ASTC support for GN build Created with: gclient setdep -r src/third_party/swiftshader@abc7a30a06c7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: Ic3790a24502823869e16cc3268d9688b8752aa0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2085015Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/db533a37a8ca..f8a16ac6d467 Created with: gclient setdep -r src-internal@f8a16ac6d467 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: Ifacdc85ce44f0b57c1254ccdff9cb0d6ea1b5471 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2085013Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#746443}
-
Andrew Grieve authored
Stack is: Caused by: android.util.AndroidRuntimeException: Calling startActivity() from outside of an Activity context requires the FLAG_ACTIVITY_NEW_TASK flag. Is this really what you want? at android.app.ContextImpl.startActivity (ContextImpl.java: 952) at android.content.ContextWrapper.startActivity (ContextWrapper.java: 405) at org.chromium.chrome.browser.ChromeApplication.startActivity (ChromeApplication.java: 206) at org.chromium.chrome.browser.ChromeApplication.startActivity (ChromeApplication.java: 199) at org.chromium.chrome.browser.DelayedScreenLockIntentHandler.onReceive (DelayedScreenLockIntentHandler.java: 40) at android.app.LoadedApk$ReceiverDispatcher$Args.lambda$getRunnable$0$LoadedApk$ReceiverDispatcher$Args (LoadedApk.java: 1550) ... From history on DelayedScreenLockIntentHandler, repro steps involve launching a page via NFC while locked. This restriction is listed as a new one in Android P: https://developer.android.com/about/versions/pie/android-9.0-changes-all#fant-required Bug: 1034440 Change-Id: Ibe13fb99a34d36a15e266d9369393dd6060a1e93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1972135 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#746442}
-
Daniel Vogelheim authored
This CL renames/refactors three loosely related things: - renames API methods from GetStringFrom(Specific)?TrustedXXX to TrustedTypesCheckForXXX. - renames the SpecificTrustedType enum class values (removes the redundant 'Trusted', since C++ enum classes are always used with their class name, and are hence naturally unambiguous) - re-writes the union-type methods in terms of the string-based ones. The earlier implementation used the union-type methods as the core implementation, and all other methods called those. This made the code a bit more complicated, and will make subsequent work harder because we will eliminate the union types. This re-works this so that the core checking logic is always in the string-based methods, and all union-type based ones call those instead. This is follow-on work from review crrev.com/c/2066730. Bug: 739170 Change-Id: I8716b5310e6c2d9f419efe2c5a3b660ad4d1af42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078254Reviewed-by:
Yifan Luo <lyf@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Daniel Vogelheim <vogelheim@chromium.org> Cr-Commit-Position: refs/heads/master@{#746441}
-
Gabriel Charette authored
Analysis of experiment results: https://docs.google.com/document/d/13PIBPuSPJbrgHAgyRbY22EWAfH2narnxpa_CgBmZbSY/edit#heading=h.4fo2tzjehwu7 Updated documentation accordingly. The Java changes should be no-ops (the previous Java default was left as USER_VISIBLE unintentionally in crrev.com/664726 but never kicked in when !mPrioritySetExplicitly). R=fdoray@chromium.org Fixed: 1022972 Change-Id: Iab8219e68ab703e0cc9ceeb16ef70b78cf43a50a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063150 Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Auto-Submit: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#746440}
-
John Delaney authored
Moves the expiry for these flags from M82->M85 as this feature is still under experiment. Change-Id: Ibbe51f5347b659886264838b1cb62cd706a1767e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083450Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Commit-Queue: John Delaney <johnidel@chromium.org> Cr-Commit-Position: refs/heads/master@{#746439}
-
Vasiliy Telezhnikov authored
After BeginWrite was moved out of critical path SkiaOutputDeviceBufferQueue::Image is often in the middle of write. When resize or reallocation of display happen (e.g rotate screen on Android) we need to call EndWrite on the image before destruction to ensure all necessary semaphores are submitted. Bug: 1056221 Change-Id: Id55c25f43cbb4bf082ad3e3ef6cd1b59e164937d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083835 Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> Reviewed-by:
Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#746438}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Ia29f89b3066ea48480a59b9a56482e44758e6970 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2085017Reviewed-by:
-
Anders Hartvoll Ruud authored
I forgot to actually set the CSSValue (i.e. cache key), which means the cache was never used. This CL adds a performance test for this which should catch regressions in the future. The test works by specifying a couple of shorthands, each of which has a large number of var() references that needs resolving. Local testing on my machine shows ~170ms with the cache enabled, and over 500ms with the cache disabled. Change-Id: I867679969bb6617219388e0b6f28adc3ae223f5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080262Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#746436}
-
Maksim Ivanov authored
This fixes the UX glitch that pressing the "Back" button in the SAML smart card PIN dialog (<security-token-pin> Polymer element) was triggering the "Network Error" screen. The underlying issue is that cancelling the PIN dialog indeed aborts the TLS handshake with an error, but it doesn't make sense to show this error to the user. The proposed fix is to remember whether the PIN dialog was canceled during the current authentication attempt, and suppress the network error in that case. Bug: 1052409 Test: start SAML login via a smart card, proceed to PIN dialog, press "Back", verify that no Network Error screen is shown Change-Id: If54dbd067da763afca7ceec4957bebf0d748da9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2069542 Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#746435}
-
Rune Lillesveen authored
Sadly, we do SetInlineStyleProperty() for UA shadow DOM during style recalc in some cases. Make sure that we don't schedule any invalidation while in style reacalc as that would leave use with a dirty tree for style invalidations after UpdateStyle(). This fixes a regression introduced in [1] where we unified the invalidation code for the various ways of changing the inline style. [1] https://crrev.com/2faf55836255e6762141712d943c47f3208c8ac4 Bug: 1057210 Change-Id: I0edab4acc03baefe0fb386c15dce78e0f8e041ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082382 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#746434}
-
Reilly Grant authored
This is a follow-up to r689238 which makes sure that the file descriptor watchers are always removed before closing the serial port. The previous fix handled most cases but left open the possibility that a watcher was still registered if there wasn't a pending read or write operation to cancel. Bug: 1057858 Change-Id: I0c760b84cbad2ec4632c9d99e8c5b2550d770ebc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083922 Auto-Submit: Reilly Grant <reillyg@chromium.org> Reviewed-by:
Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#746433}
-
Nina Satragno authored
Move the timeout adjustment from blink to the browser and avoid adjusting it if we detect a discovery factory override is in place. This change makes authenticator browser tests and WPTs 3X faster. Fixed: 976428 Change-Id: Iaea88f356a6d090c14474151b29c04e912c471b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079043 Commit-Queue: Nina Satragno <nsatragno@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/heads/master@{#746432}
-
Ovidio Henriquez authored
This change fixes the icon for the Payment Handler site setting. This icon was mistakenly set to "settings:bluetooth-scanning" in https://crrev.com/c/2058064. Change-Id: I092f85624d6442edbb1258ee3cc23fc90370d785 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082907 Auto-Submit: Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Commit-Queue: Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Cr-Commit-Position: refs/heads/master@{#746431}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/83762b21dbd2..496a335a8700 git log 83762b21dbd2..496a335a8700 --date=short --first-parent --format='%ad %ae %s' 2020-03-03 jonaso@webrtc.org Add field trials for sending ping on network switches 2020-03-03 srte@webrtc.org Makes Thread::Send execute sent messages after pending posted messages. 2020-03-03 marinaciocea@webrtc.org Transform encoded frame in RTPSenderVideo. Created with: gclient setdep -r src/third_party/webrtc@496a335a8700 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I81f92d715644ef4645972b7eceac2be7ee03f9fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083970Reviewed-by:
-
Ovidio Henriquez authored
This change implements FakeBluetoothDelegate which fakes the behavior of the new Web Bluetooth permissions implemented behied the WebBluetoothNewPermissionsBackend flag. Therefore, the web-bluetooth-new-permissions-backend virtual test suite runs the Web Bluetooth tests with this flag enabled. Design doc: https://docs.google.com/document/d/1h3uAVXJARHrNWaNACUPiQhLt7XI-fFFQoARSs1WgMDM/ Bug: 577953 Change-Id: I5f81b92433009fc34a6a5e5495fdba72500db41e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080813 Commit-Queue: Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Vincent Scheib <scheib@chromium.org> Cr-Commit-Position: refs/heads/master@{#746429}
-
Maksim Moskvitin authored
When signin cookies are cleared, then related data like locally stored trusted vault keys should be cleared. This CL adds RemoveAllStoredKeys() function to TrustedVaultClient interface. The contract is that this function should clear all keys previously stored by StoreKeys(). Since mobile OSs fetches the keys outside the browser and doesn't store anything within the browser data, there is nothing to clean. The implementation relies on IdentityManager::Observer::OnAccountsCookieDeletedByUserAction() call and analogous to autofill::prefs::ClearSyncTransportOptIns() and password_manager_util::ClearAccountStorageSettingsForAllUsers(). Bug: 1019658 Change-Id: I4993bf63cd777e652055b13be29987ef5eee6dac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080484 Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#746428}
-
Josh Nohle authored
Do not assume the local device has an Instance ID in the DeviceSync client if v2 DeviceSync is enabled. The local device will always have an Instance ID with CryptAuth, but there might be a race condition while v1 and v2 DeviceSync are running in parallel; the v1 local device data--which does not contain an Instance ID--might be returned before the v2 local device data. Bug: 951969, 1019206 Change-Id: I46882202d99cde87efc60cdd60628053a96c74f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078749 Commit-Queue: James Vecore <vecore@google.com> Reviewed-by:
James Vecore <vecore@google.com> Auto-Submit: Josh Nohle <nohle@chromium.org> Cr-Commit-Position: refs/heads/master@{#746427}
-
Mohsen Izadi authored
For injected scroll gesture events, we are incorrectly logging EventLatency of the original event leading to the injected event, rather than the injected event itself. Bug: 1054007 Change-Id: I8a95fbdb6b5eb05a5cf6d7797951098d15141809 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2070372Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Commit-Queue: Mohsen Izadi <mohsen@chromium.org> Cr-Commit-Position: refs/heads/master@{#746426}
-
Sylvain Defresne authored
As iOS has fully migrated to ARC (automatic reference counting) and there is no traction to migration macOS to ARC, remove the support allowing to use scoped_{nsobject,block} in files build with ARC. The guards are not necessary as scoped_{nsobject,block} won't build with ARC since they contains calls to -release and cast blocks to void*. However, they make it easier to understand that this is not supported, so add them for documentation. Bug: 1051997 Change-Id: I3db04ec645cb1830b92003723631c119e6e4a94c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082385 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:Mark Mentovai <mark@chromium.org> Cr-Commit-Position: refs/heads/master@{#746425}
-
Stephen Chenney authored
The goal is to gain a better understanding of the effective zoom seen by users so that we can properly prioritize sub-pixel work (non-integral zoom results in pixel aligned content becoming un-aligned) and triage bugs related to zoom and sub-pixel rendering. Bug: 1040550 Change-Id: Iab1eb8b0cfcf5c1ee2fb75c6653deadc50c7a5c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071329 Commit-Queue: Stephen Chenney <schenney@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#746424}
-
behdad authored
Removed the code for the expired metric of MainAndImplFrameTimeDelta2 in compositor_timing_history. Bug: chromium:1037242 Change-Id: Ib5e6537275b4c585a9a4b031801d8ff042f15706 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2075042 Commit-Queue: Behdad Bakhshinategh <behdadb@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#746423}
-
Yue Zhang authored
Original change's description: > Currently, when a tab in group is selected or a new tab is created > within group, the tab strip doesn't scroll to the position of the > currently selected tab. This could lead to a state where user needs to > scroll by themselves to find their selected tab in strip. This CL fixes > this issue by making following changes: > * Always scroll the strip to the last position when new tab is added > in group. > * When selected a tab in group (through tab grid dialog etc), try to > scroll to a state where the selected tab is in the middle of the > strip, if possible, > > Bug: 1054079 Change-Id: I8397d2fbd1cdff340fc1ad221abb3a54baa16514 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078901 Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#746422}
-
Haiyang Pan authored
Also enable some tests that work fine after switching to playstore image Bug: 1046059 Change-Id: Iaaf02429d35dc63716d221728c40009cc328a8ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2084090Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/96c2eb6258ae..94b928cd7d3d git log 96c2eb6258ae..94b928cd7d3d --date=short --first-parent --format='%ad %ae %s' 2020-03-03 michaelludwig@google.com Fix GM for preAbandonGpu flag 2020-03-03 michaelludwig@google.com Don't draw as sprite when alpha, CF, or MF are present 2020-03-03 robertphillips@google.com Add onPrePrepareDraws & createProgramInfo methods to GrDrawVerticesOp (take 2) 2020-03-03 reed@google.com switch to virtual with no bones Created with: gclient setdep -r src/third_party/skia@94b928cd7d3d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC herb@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: herb@google.com Change-Id: I508531537324896dbc6eb0e7ed643ee37c3ff38b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2085011Reviewed-by:
-
Ahmed Fakhry authored
This provider runs only when chrome is started with the flag --task-manager-show-extra-renderers (which is the case from the crash report). The task manager can stop updating; instructing all the providers to clear their data, and suspend all updating. However, RenderProcessHostTaskProvider used to observe RenderProcessHost lifetime events and update the task manager regardless, which causes a crash if the task manager has stopped updating. BUG=1043379 Change-Id: I6fd57125eae09e00ab5aed10f6c6b3336145933b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083955Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#746419}
-
henrika authored
Adds more detailed native logging for the lowest audio layers for both input and output sides (Linux PulseAudio and Windows Core Audio). Focus is on Windows since that is where we have the most users and we see most error reports. Example of new output: https://paste.googleplex.com/6563757645889536 Bug: 1017219 Change-Id: If0f4f157e57f5a387b20fdffe41198f83e2fb9d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062428Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Henrik Andreasson <henrika@chromium.org> Cr-Commit-Position: refs/heads/master@{#746418}
-
Alison Maher authored
The ForcedColors flag will be expiring from about:flags after the branch for 82. Extending the expiration to branch 85. Bug: 970285 Change-Id: I788ac31e6053c8577b291815973781b8aec79a78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083951Reviewed-by:
-
Paul Lewis authored
This removes the user-metrics-perf.js layout test in preference to the end-to-end test in the DevTools repo, created in this CL: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2084582 Bug: 1032561, 1046784 Change-Id: Iebe9baf872302579af89cea3542e343c9681a185 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2084557Reviewed-by:
Tim van der Lippe <tvanderlippe@chromium.org> Commit-Queue: Paul Lewis <aerotwist@chromium.org> Cr-Commit-Position: refs/heads/master@{#746416}
-
Greg Thompson authored
- ReportGenerator can now optionally generate a report lacking full profile info. - BrowserReportGenerator and ReportGenerator are now stateless. - ReportScheduler now observes BuildState and generates/updates a minimal report for desktop Chrome when an update is available. If a trigger to generate a report arrives while a report is in-flight, its handling is deferred until the previous completes. BUG=1043624 R=zmin@chromium.org Change-Id: I7864ee467bd681869ba0a57015c718cd811dc4e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036072 Commit-Queue: Greg Thompson <grt@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#746415}
-
Yuki Shiino authored
Bug: 839389 Change-Id: I8d84f37600e97535466d8c5da717fec7fff56b6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2084673Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#746414}
-
Sammie Quon authored
Shelf animations have operations to animate bounds to and from empty rects, so I had to make some changes to BoundsAnimator. To empty dst rect is fine, modified code that BoundsAnimator uses in ui/gfx to accept calculating transforms to empty dst rect. For empty src rect, the use_transforms option will fallback to using a bounds animation. Test: manual Bug: 1051492 Change-Id: Icbed996a77a31db9d989435b6815294b1067a87c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079607Reviewed-by:
-
Alison Maher authored
Both LinkSystemColors and NewSystemColors have been stable for several months. Removing the flags as a result. http://crrev.com/c/1829645 Bug: 1015968 Change-Id: I8e4926941c634349ff47c0c9dd86ae4d0e7749ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082996Reviewed-by:
-
Alison Maher authored
The initial value for color has recently been updated from black to CanvasText: http://crrev.com/c/2033144. As a result, forced_colors.css and svg.css no longer need to apply this style after reverting for forced colors mode. This change should have no functional effect. Bug: 970285 Change-Id: I50bcacb1ef355ef26def9fc6768aa1aa654688c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082997Reviewed-by:
-
