- 16 Jul, 2019 40 commits
-
-
Ahmed Fakhry authored
In order to provide a better user experience, we allow cancelling drag-to-close and switch it to normal drag once the drag location enters the desks bar bounds. This way users won't have to drop the item first and start dragging again. Demo: https://bugs.chromium.org/p/chromium/issues/detail?id=972371#c3 BUG=866622, 972371 TEST=Manually, Added a new test. Change-Id: I9c5683ed04eff230633d09f81837c1db45883f81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1703544Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#678024}
-
Matt Simmons authored
This CL adds the following counts: 1. Tabs.TabCountOnStartScreenShown - Logs the number of open tabs (total) when triggering the return to chrome experiment. 2. Tabs.TabCountInSwitcher - Logs the number of open tabs any time the GridTabSwitcher is shown. 3. Tabs.IndependentTabCountInSwitcher - Logs the number of entries in the tab switcher where an entry is either a) an independent tab or b) a tab group. R=yusufo@chromium.org Bug: 979344 Change-Id: Ibdcb7d98efdd85abdc581f6629228c7ac82faffb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699371 Commit-Queue: Matt Simmons <mattsimmons@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Cr-Commit-Position: refs/heads/master@{#678023}
-
Chromium WPT Sync authored
Using wpt-import in Chromium ef0633a4. With Chromium commits locally applied on WPT: 250461b3 "Worker: Register a service worker just once for worker subresource interception tests" 1e9c7b68 "[Client hints] Enable ACHL persistence in content shell, refactor tests" ee7626e7 "Fixing tranferFromimageBitmap-toBlob-offscreen.html to not be flaky" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: chcunningham@chromium.org, wolenetz@chromium.org: external/wpt/media-source NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: Ic8d6da14ae3cefb0a9830d34d407027a63058313 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1704750Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#678022}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ded8bf94b4c3..7438850501ca Created with: gclient setdep -r src-internal@7438850501ca The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=holte@google.com,shimazu@google.com,mohsen@google.com,pmarko@google.com,mamir@google.com Change-Id: I1a357026dc60102e519540f3ab8859616b490662 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1704753Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#678021}
-
Xing Liu authored
Deleted metrics: 1. Android.DownloadManager.NotificationLaunch: The relaunch happens for less than 0.0001%, this metric should be deleted, and we can consider to delete the mitigation for the flicker issue as well, since the occurrence is too low. 2. Android.DownloadManager.NotificationsCount.ForegroundDisabled: This is related to the feature flag, the feature is shipped. 3. Android.DownloadManager.NotificationsCount.ForegroundEnabled: Not actionable, we know users may have multiple download notifications. Other metrics are kept and is treated as important stability metrics. Bug: 975207,975228 Change-Id: I0f841c2e09aa475c8bd66da0ce4e8f0be12cd1ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699096 Commit-Queue: Xing Liu <xingliu@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
-
Matthew Mourgos authored
This will make it easier to change shelf height for dense shelf changes and other shelf changes moving forward. Bug: 973483 Change-Id: Ie4c062d7c9b84c4a97f2c58b66774fa1c48eb87c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1704856Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Commit-Queue: Matthew Mourgos <mmourgos@chromium.org> Cr-Commit-Position: refs/heads/master@{#678019}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/google/shaderc/+log/72988e40a45e..ef2b7a6d5aed git log 72988e40a45e..ef2b7a6d5aed --date=short --no-merges --format='%ad %ae %s' 2019-07-16 dneto@google.com Avoid C-style cast for constants definitions (#760) 2019-07-16 jbolz@nvidia.com SetBeforeHlslLegalization to use more relaxed validation rules (#676) Created with: gclient setdep -r src/third_party/shaderc/src@ef2b7a6d5aed The AutoRoll server is located here: https://autoroll.skia.org/r/shaderc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=radial-bots+chrome-roll@google.com Change-Id: Iad53571ec368a5d8218bd42408d0fad4fa6d7fd9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1704751Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#678018}
-
Bret Sepulveda authored
In this patch, TabStripModel::AddWebContents(), which is already documented to alter the target index of a new tab in some cases, will now move a new tab to enforce contiguity in a group if the requested point of insertion would create a gap. Forked from crrev.com/c/1703291, since dfried@ is on vacation. Bug: 984112 Change-Id: I15224efc85c0565db7474cfd7dad7f0b4849cf9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1704935 Commit-Queue: Bret Sepulveda <bsep@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#678017}
-
John Emau authored
This is a reland of 3582475b The reland is expected pass with an upgraded eslint@6.0.1 in https://crrev.com/c/1703126. For more information see: https://crbug.com/983016#c4 Original change's description: > DevTools: Use object spread operator in AxeCoreTestRunner.js > > Support for ES9 features like object spread was enabled in https://crrev.com/d2af1fc > > Change-Id: I938768072adc451d006f6f7d374bd7148a3bf084 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1689002 > Reviewed-by: Erik Luo <luoe@chromium.org> > Commit-Queue: John Emau <johnemau@microsoft.com> > Cr-Commit-Position: refs/heads/master@{#676239} Change-Id: Ice995a5e4bbd76abc762ca311cc1ea0972caee54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1703026 Commit-Queue: John Emau <johnemau@microsoft.com> Reviewed-by:
Joel Einbinder <einbinder@chromium.org> Cr-Commit-Position: refs/heads/master@{#678016}
-
Wei-Yin Chen (陳威尹) authored
Add base="true" for UMA added in https://crrev.com/c/1696533. Bug: 971802 Change-Id: I226b04fe3bb90a2ac9e387bb85c2f7fbaacf78e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1702582Reviewed-by:
-
Owen Min authored
Bug: 956237 Change-Id: Id42d2b7fc863d007154d6c2c63dc68493bc2a6ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1695929 Commit-Queue: Owen Min <zmin@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#678014}
-
Yuly Novikov authored
TBR=kbr Bug: 981736 Change-Id: I6e3298a8ff460f691a6e22e6ad889a971065d4cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1704040Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#678013}
-
Cameron authored
Bug: 981023 (marked fixed by CL above) Change-Id: I7757b24f08ad7b718b2ad6b209f79d302290c223 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1703005Reviewed-by:
-
Brian Sheedy authored
Changes how the temporary image uploading on test failure in the GPU pixel tests works. Previously, it was re-using the old code used by the non-Gold version of the test to upload images to the GS bucket. This didn't work well since the image was stored in various subdirectories prefixed with the build revision, making it difficult to search for all failed images produced in the Gold version for a particular test. Instead, just upload all the images to a single directory and include the machine name/build revision in the image name. Bug: 983600 Change-Id: I80785bd622ee1383c2afb7379687b503b27b1481 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1703275 Auto-Submit: Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
-
Wei-Yin Chen (陳威尹) authored
Bug: 971939 Change-Id: I324ed6a30b0a395bcd9ad2fa4c707c34a653c7b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1702588Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
-
Sophie Chang authored
Bug: 969558 Change-Id: Ie39a9a28373a50b7d4cecdc6554f173fd5c4c77c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1704524Reviewed-by:
Robert Ogden <robertogden@chromium.org> Commit-Queue: Sophie Chang <sophiechang@chromium.org> Cr-Commit-Position: refs/heads/master@{#678009}
-
Eric Stevenson authored
This CL adds support for printing the components of string, class and method item in a dex file. Bug: 976358 Change-Id: I9862a52ef812b8b8e3f502f5da488a0e215a24e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1687301 Commit-Queue: Eric Stevenson <estevenson@chromium.org> Reviewed-by:
Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#678008}
-
ssid authored
Change-Id: I518c49873f0d8fd5b5e2b0e26f6eb653798ee586 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1703381Reviewed-by:
oysteine <oysteine@chromium.org> Commit-Queue: ssid <ssid@chromium.org> Cr-Commit-Position: refs/heads/master@{#678007}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/6448bd660639..763b77946e17 git log 6448bd660639..763b77946e17 --date=short --no-merges --format='%ad %ae %s' 2019-07-16 sugoi@google.com MAX_DESCRIPTOR_SET_COMBINED_BUFFERS_DYNAMIC related assert fix Created with: gclient setdep -r src/third_party/swiftshader@763b77946e17 The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@google.com Change-Id: Ibcb4ee6bd550f74a6d5f0d9b5afa47ed1e5fd5e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1704748Reviewed-by:
-
Sam Maier authored
Bug: 957737 Change-Id: I0ad87488e64b0e233a8fdc16399947b6c1362897 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1697313 Auto-Submit: Sam Maier <smaier@chromium.org> Commit-Queue: Jesse Doherty <jwd@chromium.org> Reviewed-by:
-
Ian Vollick authored
SafeBrowsingTest's testSafeBrowsingProceedThroughInterstitialForSubresource Appears to be flaky. This CL disables it for now. Bug: 984705 Change-Id: Ifb04e59e80331d3f1a36cddc1a5dac1f76b6384c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1704747Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Commit-Queue: Ian Vollick <vollick@chromium.org> Cr-Commit-Position: refs/heads/master@{#678004}
-
Joey Arhar authored
These new protocol events will contain request information from network service and will be initiated from the browser. Bug: 856777, 849483, 868407 Change-Id: I3f25e0d0b8b7f29102d143a40e7a733a03eae5c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1592771 Commit-Queue: Joey Arhar <jarhar@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#678003}
-
Philip Rogers authored
There are three cases that need to cause cc::Layer damage: 1) A property tree node's value changes, such as a transform changing from translate(0, 0) to translate(10px, 10px). This damage occurs via PaintArtifactCompositor::Update with a check of the property node's changed bits. 2) Content within a layer changes. This damage occurs via the raster invalidator. 3) The layer's property tree state changes. This third case was not covered which led to underinvalidation. This patch ensures a layer is damaged if the property tree state changes. This third case can happen when a clip node is deleted. In this case, no property node will be marked as being changed (case 1). If content (a PaintChunk) referencing the deleted clip node is composited (has a cc::Layer), there will not be raster invalidation within the chunk (case 2). Therefore, a new invalidation is needed (case 3). Bug: 981630 Change-Id: I0b122e3e2a2b91b9290c656329acfe9e5a70870e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1703384 Auto-Submit: Philip Rogers <pdr@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#678002}
-
Caleb Rouleau authored
https://bugs.chromium.org/p/chromium/issues/detail?id=984565#c9 explains what is broken. I added test "test_last_shard_has_no_tests" and made sure it caught this when I disabled my fix. Bug: 984565 Change-Id: Ia86ea039eb7cb8b2c8a7cd64048537b341a232d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1703385 Auto-Submit: Caleb Rouleau <crouleau@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#678001}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/3d5856c03a84..a7fc7a353fbd git log 3d5856c03a84..a7fc7a353fbd --date=short --no-merges --format='%ad %ae %s' 2019-07-16 rsavitski@google.com PagedMemory: fix move-assignment (call dtor) + formatting Created with: gclient setdep -r src/third_party/perfetto@a7fc7a353fbd The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I9fedb991eab26abe01ce592695c9735c6400866c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1704799Reviewed-by:
-
Chase Phillips authored
Bug: 984521 Change-Id: I7b89323f4fcb8fadcc9926387729fa508463c6a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1704858Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Commit-Queue: Chase Phillips <cmp@chromium.org> Cr-Commit-Position: refs/heads/master@{#677999}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/ec9ff8ce3909..f92fc916887e git log ec9ff8ce3909..f92fc916887e --date=short --no-merges --format='%ad %ae %s' 2019-07-16 syoussefi@chromium.org Vulkan: Compute shader support 2019-07-16 clemendeng@google.com Generate openGL32.dll in a separate output folder Created with: gclient setdep -r src/third_party/angle@f92fc916887e The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=geofflang@chromium.org Bug: None Change-Id: Ib79f68afc8f6479dc0f53108c461428b7433f93e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1704801Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/0fb33b26eb53..282a1f2f7798 git log 0fb33b26eb53..282a1f2f7798 --date=short --no-merges --format='%ad %ae %s' 2019-07-16 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@282a1f2f7798 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: Ia919b614a0d6c16ab8022b87b49a07ca5ac05d66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1704800Reviewed-by:
-
John Emau authored
For the devtools-node-modules change see: https://github.com/ChromeDevTools/devtools-node-modules/commit/08f835aae2a552cd8b449ec1be9d292cbacbfb8b Change-Id: Ie69565ee2eba491e5d9c4674967bab0cfbe39da9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1703126Reviewed-by:
-
Jeroen Dhollander authored
This is a reland of 31b40abf The original push failed because there was an API change in |ScopedTaskEnvironment| between the time I implemented this CL, and the time it was submitted. Original change's description: > Respect assistant notification expiration > > Assistant notifications can now be given an expiration time through the > |expiry_timestamp_ms| field. > > A new AssistantNotificationExpiryMonitor class will monitor all > notifications and remove them (from the AssistantNotificationModel) > when they expire. > > BUG=b/116618188 > TEST=unittests and manual create notification with expiry_timestamp_ms > > Change-Id: I5d0c0b3bcd3a26d772bccb883a5a8d5914d9c929 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1688019 > Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Tao Wu <wutao@chromium.org> > Commit-Queue: Jeroen Dhollander <jeroendh@google.com> > Cr-Commit-Position: refs/heads/master@{#677864} Bug: b/116618188 Change-Id: I93281eba85fb532877f409637d8f82820756d614 TBR=dcheng@chromium.org,xiaohuic@chromium.org,wutao@chromium.org Change-Id: I93281eba85fb532877f409637d8f82820756d614 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1704674 Commit-Queue: Jeroen Dhollander <jeroendh@google.com> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#677995}
-
Wez authored
This reverts commit eb26f201. Reason for revert: This was relanded without any changes to address the LOG(ERROR) debugging issues that prompted it to be reverted the first time. Original change's description: > Reland "[Logging] Disable always-log-ERRORs-to-stderr unless LOG_TO_FILE is set." > > This reverts commit c6b8b53b. > > Reason for revert: Fixing the debugging issues. > > Original change's description: > > Revert "[Logging] Disable always-log-ERRORs-to-stderr unless LOG_TO_FILE is set." > > > > This reverts commit ffa05b99. > > > > Reason for revert: This breaks a lot of debugging workflows. > > > > Original change's description: > > > [Logging] Disable always-log-ERRORs-to-stderr unless LOG_TO_FILE is set. > > > > > > logging::LogMessage has a special-case to write LOG_ERROR messages > > > to stderr, even if LOG_TO_STDERR is not enabled, to make ERROR and > > > FATAL messages more visible, especially in tests. > > > > > > Restrict this behaviour to apply only if LOG_TO_FILE is set, so that > > > binaries which only LOG_TO_SYSTEM_DEBUG_LOG will never emit logspam > > > to stderr. > > > > > > Tested by adding a unit test for this case. > > > > > > Bug: 968387 > > > Change-Id: Icfe094e7d7bf9697a70a589eab48edbe79c36091 > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1638782 > > > Commit-Queue: Sharon Yang <yangsharon@chromium.org> > > > Reviewed-by: Wez <wez@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#666507} > > > > TBR=wez@chromium.org,kmarshall@chromium.org,yangsharon@chromium.org > > > > Change-Id: I857fd9bc95afedf204a5e981e6a362cd8990b4a8 > > No-Presubmit: true > > No-Tree-Checks: true > > No-Try: true > > Bug: 968387 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1647361 > > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > > Commit-Queue: Daniel Cheng <dcheng@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#666753} > > TBR=dcheng@chromium.org,wez@chromium.org,kmarshall@chromium.org,yangsharon@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 968387 > Change-Id: Id656bff53e3b53e4df981ca8e819f33900c966f4 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1682954 > Reviewed-by: Will Harris <wfh@chromium.org> > Commit-Queue: Aidan Wolter <awolter@chromium.org> > Auto-Submit: Aidan Wolter <awolter@chromium.org> > Cr-Commit-Position: refs/heads/master@{#677030} TBR=wez@chromium.org,agl@chromium.org,wfh@chromium.org,awolter@chromium.org,yangsharon@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 968387, 984379 Change-Id: I46779692208bef6db0fb442df22868fdeecf932e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1704681Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Adam Langley <agl@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#677994}
-
yilkal authored
Bug: 977019 Change-Id: Ie6547867532f9883a84713cde0d39b8c40a07fce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1686052 Commit-Queue: Yilkal Abe <yilkal@chromium.org> Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#677993}
-
Devlin Cronin authored
Postpone the expiration of Extensions.HasPermissions_WebStoreInstall3 and Extensions.HasPermissions_WebStoreInstallCancel3 until June 2020. We'll be looking at the install prompt more in the future, and these could prove useful. Bug: 975451 Change-Id: I202e214dda5d0de37f6d0be3cd752d239031d3a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1703303Reviewed-by:
-
Brian Sheedy authored
Unsuppresses Pixel_Canvas2DRedBox and Pixel_CanvasLowLatency2D failures on Nexus 5 devices. Both of these appear to have been initially suppressed due to the produced image changing without the reference image being updated accordingly. Now that the tests use Skia Gold and the currently produced images are marked as approved, the tests are no longer failing. Bug: 957714, 900706 Change-Id: Ibf5180c52ec26230e0b491b89f1f8a424af272ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1703144 Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Auto-Submit: Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
-
Owen Min authored
Add zmin@ to chrome/brwoser/policy/* chrome/browesr/ui/webui/policy* components/policy/* Change-Id: I8fbb4a247afa8f877952ec93b77214884b39c72b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699267Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
-
Jarryd authored
Change-Id: I23cb1e95a45482f1e43a734231dd52ce432f868f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1703266Reviewed-by:
-
Wez authored
This function is used by code under //fuchsia/engine, so must be tagged for NET_EXPORT in order for component builds to succeed. Change-Id: I4a8e721749e1636dfb77128bbf3130e54f6de7f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1703343Reviewed-by:
Eric Roman <eroman@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#677988}
-
Takuto Ikuta authored
linux-archive-rel and code coverage builder do not run any tests. Bug: 954450 Change-Id: I254004a9d232f3328a0fab8b8288e7611b1e85e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1703224 Commit-Queue: John Budorick <jbudorick@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#677987}
-
Alex Cooper authored
Updates the MockXRInputSource to match the newly added gamepad support and also ports related gamepad tests to external wpts. Bug: 984154 Change-Id: I29ce501bcbea0f7bcfef6de60f17a6961fa165c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1704387Reviewed-by:
Brandon Jones <bajones@chromium.org> Commit-Queue: Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#677986}
-
Eric Roman authored
It was only used by unittests, for which the same effect can be accomplished by removing and then adding back the observer. Change-Id: Ibc79006379e8e8c550e2fe99fd9d10a06cd64f39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1703285 Commit-Queue: Eric Roman <eroman@chromium.org> Auto-Submit: Eric Roman <eroman@chromium.org> Reviewed-by:
Robbie McElrath <rmcelrath@chromium.org> Reviewed-by:
David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#677985}
-
