- 05 Sep, 2018 40 commits
-
-
Nick Harper authored
TBR=bnc@chromium.org Change-Id: I74bdbf6694bdd7f5cec878ec6c4be259fed79421 Reviewed-on: https://chromium-review.googlesource.com/1205100Reviewed-by:
Nick Harper <nharper@chromium.org> Reviewed-by:
Bence Béky <bnc@chromium.org> Commit-Queue: Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#588912}
-
Stefan Teodorescu authored
Create basic chrome://management page to contain the template for the disclosure page, which describes administrator's capabilities in a managed environment, like policies which report information, local trust roots or force installed extensions. Bug: 879146 Change-Id: I621bed79843b2a677ed1df82b90043bc8937e44a Reviewed-on: https://chromium-review.googlesource.com/1196548 Commit-Queue: Stefan Teodorescu <fane@google.com> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#588911}
-
Chromite Chromium Autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/bf7940726346..797fd93eccde git log bf7940726346..797fd93eccde --date=short --no-merges --format='%ad %ae %s' 2018-09-05 chrome-bot@chromium.org Update config settings by config-updater. Created with: gclient setdep -r src/third_party/chromite@797fd93eccde The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: Ib74d213cf88913296fe82593df5427d6bfff5096 Reviewed-on: https://chromium-review.googlesource.com/1207070Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#588910}
-
Etienne Pierre-doray authored
This CL uses ScopedBlockingCall to mark blocking calls in /chrome/browser/ui/ash. This CL was created by replacing calls to AssertBlockingAllowed() with instantiations of ScopedBlockingCall(MAY_BLOCK). I kindly ask the reviewer to make sure of the following: - ScopedBlockingCall is instantiated in a scope with minimal CPU usage. If this is not the case, ScopedBlockingCall should be instantiated closer to the blocking call. See scoped_blocking_call.h for more info. Please let me know when/where the blocking call happens if this needs to be changed. - Parameter |blocking_type| matches expectation (MAY_BLOCK/WILL_BLOCK). See BlockingType for more info. While I assumed MAY_BLOCK by default, that might not be the best fit if we know that this callsite is guaranteed to block. - The ScopedBlockingCall's scope covers the entirety of the blocking operation previously asserted against by the AssertBlockingAllowed(). This CL was uploaded by git cl split. R=derat@chromium.org Bug: 874080 Change-Id: I478ab0929c7bba7131b214205041e66bb23de087 Reviewed-on: https://chromium-review.googlesource.com/1191182Reviewed-by:Dan Erat <derat@chromium.org> Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#588909}
-
fuchsia-sdk-chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia_arm64_cast_audio;luci.chromium.try:fuchsia_x64_cast_audio TBR=cr-fuchsia+bot@chromium.org Change-Id: I8be34d04fd8af7c530c7109f0ff378f0c2aeff61 Reviewed-on: https://chromium-review.googlesource.com/1207352 Commit-Queue: Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#588908}
-
Vadym Doroshenko authored
In the following case false positive on accounts.google.com happens: 1.Suppose that the user has 2 Gaia credentials (with usernames and passwords u1/p1 and u2/p2). Let u1 be saved in Password Manager. 2.The user go to accounts.google.com, u1/p1 are autofilled by CPM (a username field is visible, a password field is invisible). 3.The user is typing u2 in the username field and is clicking next button. 4.At that moment the page removes password form from the DOM and Password Manager incorrectly thinks that it was successful submission with u2/p1 Video is on bug 764663 (actual_bubble). This CL fixes this by ignoring for saving accounts.google.com forms without a visible password field. Similar issues might be on different sites, this CL fixes only accounts.google.com, because 1.A general solution is unlikely without more complex changes and server-side support. 2.accounts.google.com is crucial for Chrome, in particular because it serves the Chrome sign-in page. Bug: 758155, 764663, 880876 Change-Id: I57bbe94ea0a6d101c6a5a33cf354b42f0d0353fc Reviewed-on: https://chromium-review.googlesource.com/1206476 Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#588907}
-
Clark DuVall authored
Bug: 878574 Change-Id: I8d5b0be24be4db3d117d2b1edcca1c39ab93e2c9 Reviewed-on: https://chromium-review.googlesource.com/1206072Reviewed-by:
Ken Rockot <rockot@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#588906}
-
Matthew Jones authored
This patch updates Duet's IPH to work on the NTP which has no visible toolbar (which the bubble whould ordinarily anchor to). Instead, the bubble takes the place of the toolbar and removes the arrow. Bug: 862611 Change-Id: I523d8d14748ff2668101ec1890e36decd5c07213 Reviewed-on: https://chromium-review.googlesource.com/1207311 Commit-Queue: Matthew Jones <mdjones@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#588905}
-
Yue Li authored
This is a reland for https://chromium-review.googlesource.com/c/chromium/src/+/1195662 except for the wizard_controller changes TBR=xiyuan@chromium.org, xiaohuic@chromium.org Bug: b/78190629 Test: Manual Test Change-Id: I9064ae4017a2b848e00522bcbecf8d93e5e99e4a Reviewed-on: https://chromium-review.googlesource.com/1205208Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Yue Li <updowndota@chromium.org> Commit-Queue: Yue Li <updowndota@chromium.org> Cr-Commit-Position: refs/heads/master@{#588904}
-
Fritz Koenig authored
DRM does not support overlay rotation well. NV12 planes are supported, but they need to be tiled. That information is not available currently. BUG=872901 TEST=browser Change-Id: Ide9c837dca62a6db9d13e6fedaaf5b256e4bcb79 Reviewed-on: https://chromium-review.googlesource.com/1196019 Commit-Queue: Fritz Koenig <frkoenig@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Cr-Commit-Position: refs/heads/master@{#588903}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/f056cc5a549e..638bda3a17c0 git log f056cc5a549e..638bda3a17c0 --date=short --no-merges --format='%ad %ae %s' 2018-09-05 anthonyalridge@google.com Create link for relevant metric. 2018-09-05 nastasoiuf@google.com Update the UI: table structure Created with: gclient setdep -r src/third_party/catapult@638bda3a17c0 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:866423,chromium:866423 TBR=sullivan@chromium.org Change-Id: I7b6ece1a6cc01ec30a5e14e11cf55577e14c3550 Reviewed-on: https://chromium-review.googlesource.com/1207153Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#588902}
-
Joel Einbinder authored
When a script has a function with multiple const declarations for the same variable, ex: function hey(){ const duplicate = 0; const duplicate = 1; } The script that contains this function will parse correctly, but when the function `hey` is run a scriptFailedParse event will be emitted. DevTools only ever expects to get one script parsing event per scriptId, and this causes flickering of the script in the Sources panel. This patch swallows subsequent script parsing events for a script. Bug: 864296 Change-Id: I55a2e865b665e8fe1283a3dd19e9f152d0982b97 Reviewed-on: https://chromium-review.googlesource.com/1140782 Commit-Queue: Joel Einbinder <einbinder@chromium.org> Reviewed-by:Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Reviewed-by:
Andrey Lushnikov <lushnikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#588901}
-
Kush Sinha authored
ChromeOSOAuth2TokenServiceDelegate should notify SigninErrorController about auth error updates. These updates will be provided for Device Account and Secondary Accounts, both. Bug: 820046 Test: unit_tests --gtest_filter="*CrOSOAuthDelegateTest*" Change-Id: I1e3d218969350a3dc3b11755870b2e281045f2ef Reviewed-on: https://chromium-review.googlesource.com/1202802 Commit-Queue: Kush Sinha <sinhak@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#588900}
-
Sammie Quon authored
The backdrop now moves with the window when swiping up or down to use home launcher gestures. This also allows non resizable windows to be swiped up or down now. Test: manual Bug: 880605 Change-Id: I020f21fc04f95da55cd2c897841ade0b105d66ed Reviewed-on: https://chromium-review.googlesource.com/1205593 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#588899}
-
Vladimir Levin authored
This patch adds a notion of IsParentAlias to paint property tree nodes. In this patch, we make the root transform be an "alias for parent". Also, this adds some tests for various interactions with these nodes, as well as code in PaintChunksToCcLayer to ensure we don't emit unnecessary save/concat/restores for these nodes. We also need to do this for clips and effects, but this patch can land on its own. R=trchen@chromium.org, chrishtr@chromium.org Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ibf1a0cd21754dc226f7c19716028eafad63339c9 Reviewed-on: https://chromium-review.googlesource.com/1200382 Commit-Queue: vmpstr <vmpstr@chromium.org> Reviewed-by:
Tien-Ren Chen <trchen@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#588898}
-
James Wallace-Lee authored
Refactoring code from BrowserView and ViewAXPlatformNodeDelegate into a static helper. Change-Id: I247ca4c8a7da4eeb02dfd0cd7886ae82c2bc3280 Reviewed-on: https://chromium-review.googlesource.com/1195898Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: James Wallace-Lee <jamwalla@chromium.org> Cr-Commit-Position: refs/heads/master@{#588897}
-
Eric Orth authored
Added injectable TickClock to MockHostResolver to fix some timing issues I ran into while debugging some of the new cache tests. Note: HostResolverSource still has an ANY value for now, despite recent conversations that it's not the clearest name. Still trying to decide on the best name for that value, so not renamed yet. Bug: 846423 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I22431d47f76d831bbf67d0f4010c1753093a3f32 Reviewed-on: https://chromium-review.googlesource.com/1195550Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Commit-Queue: Eric Orth <ericorth@chromium.org> Cr-Commit-Position: refs/heads/master@{#588896}
-
Lei Zhang authored
cr.isWin() does not exist. Also fix formatting for some TODO entries. Change-Id: Ib64b2eeac0166484e60bf93c5a60159def81afec Reviewed-on: https://chromium-review.googlesource.com/1204590Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#588895}
-
Evan Stade authored
The client-side window frame/client layout code uses a per-window property (the pre-existing kTopViewInset) to layout the contents, rather than hardcoded values plus logic related to window state. This is necessary so that apps will be laid out appropriately in immersive mode when not fullscreened (i.e. maximized in tablet mode). Also, propagate some window properties across processes. Bug: 640365 Change-Id: I485920c242e1c98450d0868e078f534489525f7c Reviewed-on: https://chromium-review.googlesource.com/1195886Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#588894}
-
Misha Efimov authored
Bug: 744567 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;master.tryserver.chromium.android:android_cronet_tester Change-Id: I34b5f7c5446ab88a6a66acad8c77c99a8dcb984b Reviewed-on: https://chromium-review.googlesource.com/1191464Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Misha Efimov <mef@chromium.org> Cr-Commit-Position: refs/heads/master@{#588893}
-
Karan Bhatia authored
This CL removes the UrlPattern constructor which takes a proto::UrlRule. It is not used anywhere. BUG=None Change-Id: I011a45cf35000d359aad5f5c59cf5f5bf9664bcd Reviewed-on: https://chromium-review.googlesource.com/1205494Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#588892}
-
Mihai Sardarescu authored
Unified Consent feature is no longer dependent on Desktop Identity Consistency being enabled. This means that the Unified Consent feature is no longer a per-profile feature. This CL removes the argument profile from IsUnifiedConsentFeatureEnabled and IsUnifiedConsentFeatureWithBumpEnabled and moves these functions in the unified consent component. Bug: 873064 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: Ifc338dbcb48500bc17d52bf5bcf52a45ea46860d Reviewed-on: https://chromium-review.googlesource.com/1202702 Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#588891}
-
Clark DuVall authored
This is a reland of 6493250f There were reports of crashes when opening devtools because of a DCHECK deep inside GetActiveUserProfile. This switches to using the system network context, as suggested by mmenke@. This also simplifies things quite a bit as we don't have to pass around a BrowserContext. Original change's description: > Reland "Convert tcp_device_provider.cc to mojo host resolver" > > This is a reland of ac880b3a > > Switched to using > ChromeDevToolsManagerDelegate::GetDefaultBrowserContext() which > outlives TCPDeviceProvider. The original was reverted because of a > crash when TCPDeviceProvider tried to access a destroyed > BrowserContext, see http://crbug.com/879060. > > Original change's description: > > Convert tcp_device_provider.cc to mojo host resolver > > > > Bug: 874653 > > Change-Id: I95b968427344a4c9821c0985ae1f89c153036bcd > > Reviewed-on: https://chromium-review.googlesource.com/1185626 > > Commit-Queue: Clark DuVall <cduvall@chromium.org> > > Reviewed-by: Andrey Kosyakov <caseq@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#586738} > > Bug: 874653 > Change-Id: Ia6c00ba51020473f820add8c4257f3bf16fd5b24 > Reviewed-on: https://chromium-review.googlesource.com/1197265 > Reviewed-by: Andrey Kosyakov <caseq@chromium.org> > Commit-Queue: Clark DuVall <cduvall@chromium.org> > Cr-Commit-Position: refs/heads/master@{#587750} Bug: 874653 Change-Id: Ifc6eddc0d05bd65792165d5542fe98b09ff0fb05 Reviewed-on: https://chromium-review.googlesource.com/1199848Reviewed-by:
Eric Orth <ericorth@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#588890}
-
Becky Zhou authored
Bug: 880185 Change-Id: Iab70cc35d97c809b8e28d59e22d45b8bc54f18df Reviewed-on: https://chromium-review.googlesource.com/1205373 Commit-Queue: Becky Zhou <huayinz@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#588889}
-
src-internal-chromium-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d636bf7f5a63..09307abef3dd Created with: gclient setdep -r src-internal@09307abef3dd The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ia3fcde501f3a5e47e207ae20202fb399ec5375ad Reviewed-on: https://chromium-review.googlesource.com/1207150Reviewed-by:
src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#588888}
-
Sergey Ulanov authored
This is a reland of e6df6345 Original change's description: > Cleanup lifetime handling in P2P sockets. > > Several fixes for P2P sockets: > 1. P2PSocketTcpBase no longer posts tasks with base::Unretained(). > 2. Previously P2P sockets were destroyed only in response to Mojo > interfaces errors. They were not destroyed on other error. Fixed > it now. > 3. Simplified TCP server socket protocol. Now the accepted socket is > passed directly in IncomingTcpConnection. > 4. Updated unittests to verify that P2P sockets are destroyed in > response to errors. > 5. Other minor cleanups, particularly moved packet dump logic to > SocketManager and removed some unittests that are not relevant > after migration to mojo. > > Bug: 877515, 877514 > Cq-Include-Trybots: luci.chromium.try:linux_mojo > Change-Id: I55276e372185c558667289a1efdfcf0421c3d7bc > Reviewed-on: https://chromium-review.googlesource.com/1189083 > Reviewed-by: Nasko Oskov <nasko@chromium.org> > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#588430} TBR=jam@chromium.org,wfh@chromium.org Bug: 877515, 877514,880218 Change-Id: I0cc79616b70f7900e6c551a7c91e404de2fb7dd3 Cq-Include-Trybots: luci.chromium.try:linux_mojo Reviewed-on: https://chromium-review.googlesource.com/1206338 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#588887}
-
Wez authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia_arm64_cast_audio;luci.chromium.try:fuchsia_x64_cast_audio Change-Id: If8e680c80def495222aee51056c919e961f0c098 Reviewed-on: https://chromium-review.googlesource.com/1206006 Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#588886}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/86b118ed994e..f056cc5a549e git log 86b118ed994e..f056cc5a549e --date=short --no-merges --format='%ad %ae %s' 2018-09-05 anthonyalridge@google.com Implements error bars for bar plotter. Created with: gclient setdep -r src/third_party/catapult@f056cc5a549e The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:866423 TBR=sullivan@chromium.org Change-Id: Icdc22b70d6b92f04b242ba4f9b05705ea34058a2 Reviewed-on: https://chromium-review.googlesource.com/1207072Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#588885}
-
Javier Ernesto Flores Robles authored
self.browserState was nil at the point of initialization. Bug: 845472 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: Id3fb457b493cecc1686144160a486fb6446fdea2 Reviewed-on: https://chromium-review.googlesource.com/1186334 Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#588884}
-
kereliuk authored
Change-Id: Ib619f3bdc7f3c6e6da3a0f16b2b3feddf9592478 Reviewed-on: https://chromium-review.googlesource.com/1207010Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Jonathon Kereliuk <kereliuk@google.com> Cr-Commit-Position: refs/heads/master@{#588883}
-
perfetto-chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/a8d99e51faf0..1d289218f53f git log a8d99e51faf0..1d289218f53f --date=short --no-merges --format='%ad %ae %s' 2018-09-05 hjd@google.com perfetto-ui: Plumb notifyEof from UI to WASM Created with: gclient setdep -r src/third_party/perfetto@1d289218f53f The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: Ibb3e2a2619a1f0c3f09df4337e0f8f5846bfcd5c Reviewed-on: https://chromium-review.googlesource.com/1207030Reviewed-by:
perfetto-chromium-autoroll <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: perfetto-chromium-autoroll <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#588882}
-
Eric Roman authored
Bug: 880608 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I065803782935f7e69310a791ecb3053d573fcc61 Reviewed-on: https://chromium-review.googlesource.com/1205534Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#588881}
-
Peng Huang authored
We would like to verify Skia DDL correctness for rastering work. So a new flag --enable-oop-rasterization-ddl is added. With this flag, the raster decoder will record raster work into a DDL first, and then play it back into a SkSurface. Right now, recording and playing back are on the GPU main thread. In future, the recording could be moved to raster worker threads. Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Iba462c6a2376b9ab6fc663c97b913e568a5a8bce Reviewed-on: https://chromium-review.googlesource.com/1169150Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#588880}
-
webrtc-chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/b29409064e87..e10f3b7403d0 git log b29409064e87..e10f3b7403d0 --date=short --no-merges --format='%ad %ae %s' 2018-09-05 yinwa@webrtc.org Reland "Remove steveanton from api/ watchlist" 2018-09-05 sakal@webrtc.org Update Android to use limited range YCbCr. 2018-09-05 ssilkin@webrtc.org Test setting of spatial index. 2018-09-05 danilchap@webrtc.org Replace WeakPtr with CancelablePeriodicTask in RtcpTransceiverImpl 2018-09-05 henrika@webrtc.org Relands Adds WebRTC.Audio.Record/PlayoutSampleRateOffsetInPercent UMA stats to native WebRTC Created with: gclient setdep -r src/third_party/webrtc@e10f3b7403d0 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:None,chromium:b/113648245 TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I27e09caa0437a51fcf4b874c7de14cff6f62f53b Reviewed-on: https://chromium-review.googlesource.com/1206931Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#588879}
-
Mike Klein authored
Some of these files were including SkColorSpaceXform.h where they really just wanted SkColorSpace.h. One file was including SkColorSpaceXformCanvas.h but not using it, and relying on a transitive include for SkColorSpaceXform.h from another header that wasn't using it at all. Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: I62774b88da06b98899aa9ed52633aa4acbb0073f Reviewed-on: https://chromium-review.googlesource.com/1203912Reviewed-by:
Florin Malita <fmalita@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#588878}
-
Andres Calderon Jaramillo authored
This CL moves features::kVaapiJpegImageDecodeAcceleration so that it can be accessed easily by GpuServiceImpl. GpuServiceImpl will use it to decide whether it should instantiate an implementation of the image decode acceleration mojo interface when requested by a renderer. Bug: 868400 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I93aa630792adae723236c8403ff807a31469ea8c Reviewed-on: https://chromium-review.googlesource.com/1203430Reviewed-by:
Camille Lamy <clamy@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Commit-Queue: Andres Calderon Jaramillo <andrescj@chromium.org> Cr-Commit-Position: refs/heads/master@{#588877}
-
Andrew Grieve authored
Can repro the failure via: cd out/Debug rm gen/arsc/apks/MonochromePublicTestAr.ap_ rm lib.java/third_party/android_system_sdk/android_system.jar ninja gen/arsc/apks/MonochromePublicTestAr.ap_ Change-Id: I6885219d272510ec024263a3567fb27acf68050f Reviewed-on: https://chromium-review.googlesource.com/1205500Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#588876}
-
Chris Lu authored
[ios] Subclass MDCAppBarViewController to prevent it from dismissing on Accessibility Z-gesture in Settings This is already managed well by SettingsNavigationController. Video: https://drive.google.com/open?id=1P3kKX_m8_xnaS2lF58BKvaRL5tTbsuyw Bug: 877162, 874471 Change-Id: Ieb95fe427cece1d1fdb8f223bb16c0f0bbf05ce3 Reviewed-on: https://chromium-review.googlesource.com/1197411 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#588875}
-
danakj authored
Split the condition on viewport-enabled between the gpu-raster decision and the setting-up-the-viewport state. Expand the comment about the gpu-raster decision. Remove an if condition for a possible null pointer that was already dereferenced above. R=bokan@chromium.org Change-Id: I93110b078cc372fde1b1e490101d879a392acdd1 Reviewed-on: https://chromium-review.googlesource.com/1205310Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#588874}
-
danakj authored
R=enne@chromium.org Bug: 854256 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ieeae7911be96a95f961062262d24a454ec10da26 Reviewed-on: https://chromium-review.googlesource.com/1204925Reviewed-by:
enne <enne@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#588873}
-