- 25 Nov, 2019 40 commits
-
-
Eric Willigers authored
When using minimal-ui on Windows 10, the icons are now consistent with the native Windows 10 Back and Reload icon style. The main browser toolbar is unchanged. TBR=antrim@chromium.org Bug: 1026069 Change-Id: Ic243e22f08f4ce7467db1058e2fff948a0be854e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1924180 Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Reviewed-by:
Collin Baker <collinbaker@chromium.org> Cr-Commit-Position: refs/heads/master@{#718559}
-
Yuki Shiino authored
Bug: 839389 Change-Id: I460a9d7fa5f9f0e0c25eee3a75b0813524ec937a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932148 Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#718558}
-
Yuki Shiino authored
Bug: 839389 Change-Id: I41642b09c0fe8a24c9d32eb29b82f9c4a58fd698 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932147 Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
-
Ian Struiksma authored
For each input element, we grab the autofill information from the html element and log it. FormCache writes to 2 elements, and sometimes title is used on the page, so switching to use "autofill-information" instead Also, making the lack of this element a simple log line instead of a failure as it doesn't affect validation or execution of test. Bug: 984664 Change-Id: I934db1eb8d787a8fe799525bda14a33ee0cfa72d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931656 Auto-Submit: Ian Struiksma <ianstruiksma@google.com> Reviewed-by:
Dominic Battré <battre@chromium.org> Commit-Queue: Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#718556}
-
Yuki Shiino authored
This patch implements the algorithm, plus introduces EffectiveOverloadItem for type safety and ease of access. Bug: 839389 Change-Id: I6e7bafc0f36336f26f699031df53d0f419a20927 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932138 Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/4ec3efef499f..4706026ed847 git log 4ec3efef499f..4706026ed847 --date=short --no-merges --format='%ad %ae %s' 2019-11-25 abennetts@google.com Wait for Polymer to be initialized before invoking it. 2019-11-25 fancl@chromium.org Dockerized dashboard testing & deploying Created with: gclient setdep -r src/third_party/catapult@4706026ed847 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC crouleau@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1026356 Tbr: crouleau@chromium.org Change-Id: If19f69b9cf0c386d89bb7e816c2d0fe76d1956fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932031Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#718554}
-
Alexey Baskakov authored
Implement the following API to support user initiated installation from UI. - CanUserUninstallExternalApp - UninstallExternalAppByUser - WasExternalAppUninstalledByUser For example: it implements the scenario if a user uninstalls a default app ('default apps' are considered external apps). This code is disabled by default behind kDesktopPWAsWithoutExtensions base feature. Bug: 901226 Change-Id: I13149af5cfce83a2e4aa2ee15c9dcc1c031b4717 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1933680 Commit-Queue: Alexey Baskakov <loyso@chromium.org> Reviewed-by:Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#718553}
-
yu han authored
Previous to this CL, clicking on an inline element embedded in an anchor placed inside a <summary> tag will expand the <details> section instead of navigating to the anchor's href. However, when the anchor is placed outside of <summary>, it behaves correctly. The error is caused by DOMActivate event generated by the inline element. As DOMActivate bubbles up, it bypasses the anchor's event handler, reaches the <summary>, and is handled there. Once DOMActivate is handled, the original click event stops propagating and terminates. This behavior, however, differs from when the anchor tag is placed outside of the summary. DOMActivate isn't handled, and the original click event keeps bubbling up till it's handled by the anchor. DOMActivate event is deprecated: https://developer.mozilla.org/en-US/docs/Web/API/Element/DOMActivate_event. However, since blink still has code that depends on it, replacing it is outside of the scope for this fix. Instead, this fix is for the anchor element to handle the DOMActivate event as it bubbles up. The anchor event handler checks the underlying event of DOMActivate and handles it if it's a click. I also looked at an alternative fix by trying to prevent the DOMActivate event from bubbling up. But calling event.stopPropagation() doesn't work as the EventDispatcher::DispatchEventPostProcess doesn't check this status. Bug: 538283 Change-Id: I11fb072faa0563279d43a28e5dc19cee89906bf0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928234Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Commit-Queue: Yu Han <yuzhehan@chromium.org> Cr-Commit-Position: refs/heads/master@{#718552}
-
Yuki Shiino authored
IdlType.unwrap supports variadic={True,False} in addition to nullable and typedef. Bug: 839389 Change-Id: I2f2d2cb2a79e0c33f56ab9df4d322f778c756dee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932137Reviewed-by: -
Colin Blundell authored
Helps to clarify what the //chrome dependencies in CaptivePortalBlockingPage actually are in starting to analyze strategy for sharing captive portal implementation with WebLayer. Bug: 1025059 Change-Id: Iaf27f63e4cb595e927c674a761c028fb56190ef2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929237Reviewed-by:
Carlos IL <carlosil@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#718550}
-
Hitoshi Yoshida authored
'dict_' is commonly used in dictionary.py, but it's obvious the file focuses on dictionary classes. This CL drops the redundant common prefix. Plus, make it consistent, put 'dict_' prefix on 'member' in function names. This change makes it clear "dict_member" figures dictionary members from the scope of *public* functions. Bug: 839389 Change-Id: I0e8662c323c0dce5a4edfc70d39966434aebb6f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1933853Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#718549}
-
Yuki Shiino authored
Supports expression objects, which are constructible from web_idl.Exposure, and basic logical operations. Bug: 839389 Change-Id: I8d402a41cdd0f3fc185c8302578605f560af1472 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930760Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/d8bfc516141d..9c0c92b2db86 git log d8bfc516141d..9c0c92b2db86 --date=short --no-merges --format='%ad %ae %s' 2019-11-25 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 4c7db77e0185..e9b68f332a30 (5 commits) Created with: gclient setdep -r src/third_party/skia@9c0c92b2db86 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC bungeman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:None Tbr: bungeman@google.com Change-Id: Ie16b783d9e279050ad9d512f3f8089e07233f21e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1933646Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/4fae2545ff9e..e1b0b37898a3 Created with: gclient setdep -r src-internal@e1b0b37898a3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:None,chromium:None Tbr: jbudorick@google.com Change-Id: I8ddd2b16e8c62648e113cb57c552289cc2eddf01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1933645Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#718546}
-
Kenichi Ishibashi authored
To avoid unwanted diffs when we move these files into a different place. This CL also replaces direct use of SequenceChecker with SEQUENCE_CHECKER() macro as `git cl upload` suggested. Bug: N/A Change-Id: I7aa8a0d805783d2dd4e42cbd9e9c7b87a5010f64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1933675 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#718545}
-
Ramin Halavati authored
Size 25 is added to incognito icons (formerly 24 and 20) for better support of scale factor 125%. Bug: 997054 Change-Id: Ia1028f2262490d4aa6d78e69fa0e90638f993b28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886330 Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Auto-Submit: Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
-
Adam Rice authored
Error the stream if the input to DecompressionStream is truncated, or there is junk after the end of the stream. This will help avoid accidental loss of data. Also add a thorough test of the behaviour when various fields of a compressed stream are corrupted. Also test that errors are correctly issued when the stream is truncated or has trailing junk. BUG=1014422 Change-Id: I8aceeafd279b75d4fea76d7edca19024856417c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928428Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#718543}
-
Yutaka Hirano authored
Files I'm familar with have been moved to /services/network, so I am no longer a good reviewer for changes on this directory. NOTRY=true Bug: None Change-Id: I8e4439486735dd319a2ef2ed63b316b997509f35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1933857Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#718542}
-
Emircan Uysaler authored
This CL would allow us to enable work that are behind feature flags. Bug: 1026011 Change-Id: Ifaa69e184811ffe0062cc10389b31e54fc8a76db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931657 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#718541}
-
Peter Kasting authored
This is a regression fix from https://chromium-review.googlesource.com/c/chromium/src/+/1920433 , where labels with STYLE_SECONDARY changed from "secondary" to "primary" foreground color. Make use of this in a few places where people were using LabelDisabledColor to mean "hint/secondary" instead of "disabled". Bug: 1024091 Change-Id: I9917995edbadf596a57f192ef1b8b8044b815aa8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931505 Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Commit-Queue: Yuichiro Hanada <yhanada@chromium.org> Cr-Commit-Position: refs/heads/master@{#718540}
-
Adam Rice authored
The CHECKs added in https://chromium-review.googlesource.com/c/chromium/src/+/1837445 indicate that |consumer_| is being cleared in the BodyStreamBuffer constructor during the call to ReadableStream::CreateWithCountQueueingStrategy(). There's no apparent way this can happen. Add new temporary CHECKs to the places where |consumer_| is cleared to verify that we are not inside the call to ReadableStream::CreateWithCountQueueingStrategy(). These should result in a stack trace at the point where the problem occurs. BUG=1007162 Change-Id: I571214597ff714f34b2cfb63d2c42f42d53733d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928513Reviewed-by:
-
Noel Gordon authored
Fix test after CL:1933859, now the background color is transparent. No-try: true No-presubmit: true Bug: 742944 Change-Id: Ib9af5c847f5453394d8f2062f3bd97f9d2a1c901 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1933864Reviewed-by:
Austin Tankiang <austinct@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#718538}
-
Hiroki Nakagawa authored
This is a part of the effort to split ServiceWorkerProviderHost into ServiceWorkerHost and ServiceWorkerContainerHost. This CL moves |controller_| and relevant functions from ServiceWorkerProviderHost to ServiceWorkerContainerHost. Design doc: https://docs.google.com/document/d/1epWIgelE-7uwxJHrYPKlbwqMRP9in2xLUR6mpiU_afY/edit?usp=sharing Bug: 931087 Change-Id: I5071af71eaa5e75ef70142d2a06b8c962a938a9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1933854Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
-
Kenichi Ishibashi authored
Remove some service_worker_{database,storage}.h includes which aren't required. Bug: N/A Change-Id: Ia54a2ac5b18fd74676275f164a076cc08078f7ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1933667Reviewed-by:Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#718536}
-
Chromium WPT Sync authored
Using wpt-import in Chromium e4fe6876. With Chromium commits locally applied on WPT: e83dd93c "Limit backtracking on regexp called from blink." 500a74f5 "Add a runtime flag to enforce strict MIME type checks for workers." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: rego@igalia.com: external/wpt/css/css-grid NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I0d027cf9728dfcd6b8f5c918907a1049f8300395 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1933472Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#718535}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/59327542f41b..4ec3efef499f git log 59327542f41b..4ec3efef499f --date=short --no-merges --format='%ad %ae %s' 2019-11-25 abennetts@google.com Add origin-trial tokens to pinpoint's index.html for prod and local dev (localhost:8080). Created with: gclient setdep -r src/third_party/catapult@4ec3efef499f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC crouleau@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1026356 Tbr: crouleau@chromium.org Change-Id: Ie27a6caf7436423ede16ab2bfacff02dccc7d877 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1933637Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/e43b53126600..2ad66eccb5d5 git log e43b53126600..2ad66eccb5d5 --date=short --no-merges --format='%ad %ae %s' 2019-11-25 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 126f20ed..0ec8ef3c (718412:718517) 2019-11-23 mbonadei@webrtc.org Revert "Reland "Make webrtc_fuzzer_main depend on webrtc_component in Chromium."" 2019-11-23 mbonadei@webrtc.org Reland "Make webrtc_fuzzer_main depend on webrtc_component in Chromium." 2019-11-23 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 53149b64..126f20ed (718304:718412) 2019-11-23 peah@webrtc.org Changed the digital AGC1 gain to properly support multichannel 2019-11-23 mbonadei@webrtc.org Revert "Make webrtc_fuzzer_main depend on webrtc_component in Chromium." 2019-11-22 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 5395db8b..53149b64 (718200:718304) 2019-11-22 peah@webrtc.org AGC: Removing unnneccessary copying and changing to using const 2019-11-22 jonaso@webrtc.org Make IceController injectable 2019-11-22 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 022da7ca..5395db8b (716991:718200) 2019-11-22 saza@webrtc.org Add multi-channel support to AECM 2019-11-22 mellem@webrtc.org Add TimeController to api/test/ and add a CreateTimeController API. 2019-11-22 peah@webrtc.org Making the Analog AGC properly support multi-channel 2019-11-22 peah@webrtc.org Adding VoIP specific channel adjustments 2019-11-22 jonaso@webrtc.org Move IceFieldTrials into own .h-file 2019-11-22 mbonadei@webrtc.org Make webrtc_fuzzer_main depend on webrtc_component in Chromium. 2019-11-22 henrika@webrtc.org Improves device enumeration in ADM2 for Windows. Created with: gclient setdep -r src/third_party/webrtc@2ad66eccb5d5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:None,chromium:896154,chromium:896154,chromium:None,chromium:896154,chromium:None,chromium:1024965,chromium:None,chromium:1027117,chromium:896154 Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I3ba939153caa74ee66136c256a2b608b635701c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1933636Reviewed-by:
-
Yoshifumi Inoue authored
This patch makes |LayoutInline::InvalidateDisplayItemClients()| to utilize |NGInlineCursor| for preparation of migrating to |NGFragmentItem|. Bug: 982194 Change-Id: I95b2e8669eb2ede4724cad72275f9ffd98e7af7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930287 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#718532}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/61ad456558ce..d8bfc516141d git log 61ad456558ce..d8bfc516141d --date=short --no-merges --format='%ad %ae %s' 2019-11-25 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src 137e8082..0ec8ef3c (1040 commits) Created with: gclient setdep -r src/third_party/skia@d8bfc516141d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC bungeman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:None Tbr: bungeman@google.com Change-Id: Ic7a1424a46f90a843250b0082425340029f0225b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1933635Reviewed-by:
-
Dominic Farolino authored
R=kinuko@chromium.org Change-Id: Ieb2b39c2156521d93ed3cd4a1eb0d8ebb46f2536 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931161Reviewed-by:
-
Noel Gordon authored
CL:720656 injected CSS into the QuickView <webview> for PDF/Text. PDF does not inject CSS after CL:1933850 and moreover, keeps the <webview> transparent. We can use that fact to fix the text file rendering issue introduced by CL:720656. From https://bugs.chromium.org/p/chromium/issues/detail?id=742944#c37, using webview.insertCSS() sometimes works, and sometimes does not, due to <webview> permissions check races. And the result is different text renderings of the same text file, depending on race results. The cause is calling insertCSS in the loadstart event i.e., too early. Delay it until contentload fires; that avoids the permissions race. Bug: 742944 No-try: true Change-Id: I0c637d5366ee6cf3448c65035b2932a62f925d91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1933859Reviewed-by:
-
David Lei authored
Remove chromeos/resources/media_app_resources.grdp from WATCHLISTS as we are now using a grd file that we own. No functional change. Bug: 996088 Change-Id: Ia10f0f326127653589ce8141bfea26d1aa1eff8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1933835Reviewed-by:
Trent Apted <tapted@chromium.org> Commit-Queue: David Lei <dlei@google.com> Cr-Commit-Position: refs/heads/master@{#718528}
-
Ilia Samsonov authored
googletest will no longer support empty prefix for parameterized INSTANTIATE_TEST_SUITE_P. Adding "All" prefix to existing empty prefix test suites. This CL was uploaded by git cl split. R=edman@chromium.org Bug: 1023677 Change-Id: I62e49b6a82c96b1268889793d777f85a8be29341 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1926917 Auto-Submit: Ilia Samsonov <isamsonov@google.com> Reviewed-by:
Edman Anjos <edman@chromium.org> Commit-Queue: Edman Anjos <edman@chromium.org> Cr-Commit-Position: refs/heads/master@{#718527}
-
Adam Rice authored
Previously, invalid URLs passed to the QuicTransport constructor would result in an exception message that was missing the URL that was passed. Pass the original input string to QuicTransport::Init so that it can be used in exception messages even if it is not a valid URL. BUG=1011392 Change-Id: I8423e357d32054b58fbf067ff132167934c06fd6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919520Reviewed-by:
-
Noel Gordon authored
The MimeHandlerViewInCrossProcessFrame feature has shipped in ChromeOS and the QuickView PDF tests should no longer crash on the MSAN bots as a result. Re-enable these tests on MSAN. Tbr: slangley Bug: 768070 Change-Id: I77d195ffec0ea620c8681d3c3dc64406832b7674 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1933834Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/6c4c685b2b8b..61ad456558ce git log 6c4c685b2b8b..61ad456558ce --date=short --no-merges --format='%ad %ae %s' 2019-11-25 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader c8d4d4254ca1..d44d61514749 (4 commits) Created with: gclient setdep -r src/third_party/skia@61ad456558ce If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC bungeman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:None Tbr: bungeman@google.com Change-Id: I8ce2ea4592c792575a38da3dd9e03d2f4342de2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1933929Reviewed-by:
-
Reilly Grant authored
Bug: 1007786, 1007635 Change-Id: I9ad54b444749ccb93d7c16422b64a8ff39bfc618 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931150 Auto-Submit: Reilly Grant <reillyg@chromium.org> Commit-Queue: Sam McNally <sammc@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#718523}
-
Reilly Grant authored
Bug: 1007656 Change-Id: Ie20d3f1931a279fa1c6a2bd5d40d64848f6f37eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929394 Auto-Submit: Reilly Grant <reillyg@chromium.org> Commit-Queue: Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#718522}
-
Noel Gordon authored
QuickView renders PDF/Text content in a <webview>. Change the style of of that <webview> to be fully transparent. And, in the case of the PDF viewer, do not inject any CSS into the viewer at all, so the viewer is in complete control of when/what things draw inside the <webview>. Thus, if there is any color flashing / FOUC during <webview> rendering in Files app QuickView, then the PDF/Text rendering JS/C++ sub-systems are to blame. Bug: 1001034 No-try: true Change-Id: I7d6c4ea178548a97777d81651087ceb8fad6bb45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1933850 Commit-Queue: Noel Gordon <noel@chromium.org> Auto-Submit: Noel Gordon <noel@chromium.org> Reviewed-by:
Stuart Langley <slangley@chromium.org> Cr-Commit-Position: refs/heads/master@{#718521}
-
Hiroki Nakagawa authored
This is a part of the effort to split ServiceWorkerProviderHost into ServiceWorkerHost and ServiceWorkerContainerHost. This CL moves |frame_tree_node_id_|, |fetch_request_window_id_|, and |web_contents_getter| from ServiceWorkerProviderHost to ServiceWorkerContainerHost. Design doc: https://docs.google.com/document/d/1epWIgelE-7uwxJHrYPKlbwqMRP9in2xLUR6mpiU_afY/edit?usp=sharing Bug: 931087 Change-Id: Ia95c3dbc70d3e8d55727dfbb65905beb674ca3ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930366 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
-
