GitLab

R=brianderson, enne
BUG=251936

Review URL: https://codereview.chromium.org/279013002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270841 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none

Review URL: https://codereview.chromium.org/287563008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270840 0039d316-1c4b-4281-b951-d872f2087c98

Ensure that any IPC sent from a child process that couldn't be deserialized causes that process to be killed.

Today we do this only for a subset of IPCs and not all process types.

R=jar@chromium.org, tsepez@chromium.org

Review URL: https://codereview.chromium.org/283313002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270839 0039d316-1c4b-4281-b951-d872f2087c98

Retry: The first attempt had a memory leak.  It seems that this leak existed
before this CL, but no code exercised it.  This updated CL includes a scoped
deleter that should fix it.

Original commits message was:

Makes the client assign a valid position to incoming bookmarks if the
server has not populated the required fields.  This code should never be
triggered unless there is a bug in the server.  This risks reordering
users' bookmarks, but that's probably preferable to a crash.  This
fallback code is still protected by a NOTREACHED(), as before.

Detects bookmarks that do not have valid position information during
database load.  If these corrupted bookmarks are detected, the entire
database is declared to be corrupt.  Sync will then re-download
all of the user's data, which should fix the problem.

BUG=367247

Review URL: https://codereview.chromium.org/283143002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270837 0039d316-1c4b-4281-b951-d872f2087c98

AudioAndroidOutputTest.StartOutputStreamCallbacksNonDefaultParameters
checks to make sure the callbacks are not exceeding 1.3x the average callback
time, but this appears to be a bit too aggressive on some android devices,
and bots are failing the test.

Increasing the threshold to 1.35x for now until some code owner can look at
this and see if there is a better fix.

TBR=dalecurtis@chromium.org, tommi@chromium.org, henrika@chromium.org
BUG=373945

Review URL: https://codereview.chromium.org/289073003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270836 0039d316-1c4b-4281-b951-d872f2087c98

Moves the definition of some invalidations-related swtiches into the
newly-created components/invalidation/invalidation_switches.{cc,h}.

Moves invalidation_service_util.{cc,h} into the component, since those
files no longer depend on chrome/common/chrome_switches.h

Moves p2p_invalidation_service.{cc,h} into the component, since its only
chrome/ dependency was invalidation_service_util.h.

TBR=ben
BUG=336571

Review URL: https://codereview.chromium.org/283673003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270835 0039d316-1c4b-4281-b951-d872f2087c98

This test is still disabled pending resolution of some mojo message
validation issues, but this version sould be correct given a correct
message validator.

In other words, running this with --gtest_also_run_disabled_tests is
a good way to test a message validator.

BUG=366797

Review URL: https://codereview.chromium.org/284243002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270834 0039d316-1c4b-4281-b951-d872f2087c98

This will replace the repeated PerfDataProto field in the UMA protobuf. It
provides for more metadata surrounding the collection of each profile. It
also allows for more types of profiles to be collected, other than perf.

BUG=chromium:358778
TEST=build successfully
Signed-off-by: Simon Que <sque@chromium.org>

Review URL: https://codereview.chromium.org/226273004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270832 0039d316-1c4b-4281-b951-d872f2087c98

All the known issues with these telemetry benchmarks have been fixed.

BUG=355952

Review URL: https://codereview.chromium.org/279853002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270830 0039d316-1c4b-4281-b951-d872f2087c98

So that eula-extra-controls container div does not cover buttons and
make them not mouse clickable.

BUG=372098

Review URL: https://codereview.chromium.org/289043002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270827 0039d316-1c4b-4281-b951-d872f2087c98

This also fix a typo in ninja_toolchain_writer.h:

s/assicoated/associated

R=scottmg@chromium.org

Review URL: https://codereview.chromium.org/283193002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270826 0039d316-1c4b-4281-b951-d872f2087c98

Otherwise, when display.dll is built in component it won't generated display.dll.lib (the import library). This is empty on non-cros.

This causes dependents to fail to link with:

FAILED: C:\b\depot_tools\python276_bin\python.exe gyp-win-tool link-with-manifests environment.x64 True ash_shell_unittests.exe "C:\b\depot_tools\python276_bin\python.exe gyp-win-tool link-wrapper environment.x64 False link.exe /nologo /OUT:ash_shell_unittests.exe @ash_shell_unittests.exe.rsp" 1 mt.exe rc.exe "obj\ash\ash_shell_unittests.ash_shell_unittests.exe.intermediate.manifest" obj\ash\ash_shell_unittests.ash_shell_unittests.exe.generated.manifest ..\..\build\win\compatibility.manifest
LINK : fatalerror LNK1104: cannot open file 'display.dll.lib'

This only occurs on x64 because the x86 is non-component. It didn't get caught on the waterfall because there's no clobber x64 builder yet.

R=huangs@chromium.org, wfh@chromium.org
BUG=

Review URL: https://codereview.chromium.org/287013005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270825 0039d316-1c4b-4281-b951-d872f2087c98

Also remove gcm_service_unittest that is forgot to delete last time

BUG=356716
TEST=existing tests
TBR=kalman@chromium.org

Review URL: https://codereview.chromium.org/284193005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270822 0039d316-1c4b-4281-b951-d872f2087c98

actually do anything (they're implemented by hand) so it just confuses
the docs.

R=rockot@chromium.org

Review URL: https://codereview.chromium.org/291493002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270821 0039d316-1c4b-4281-b951-d872f2087c98

BUG=362729

Review URL: https://codereview.chromium.org/274403003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270820 0039d316-1c4b-4281-b951-d872f2087c98

The kernel_wrap_test.cc tests were previously relying on the global
errno value being non-zero before they ran.

This change makes the kernel_wrap_ functions do the right thing even
when the kernel proxy function don't see errno (as is the case for the
mock kernel proxy) and initialises the global errno before each test
run.

BUG=
R=binji@chromium.org

Review URL: https://codereview.chromium.org/271513002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270819 0039d316-1c4b-4281-b951-d872f2087c98

Call OnTextInputTypeChanged, instead of explicitly calling OnBlur or OnFocus on the input method, to let IMF sort out updating the text input client. 

BUG=365741

Review URL: https://codereview.chromium.org/289713002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270818 0039d316-1c4b-4281-b951-d872f2087c98

TSANv2: Remove race suppression in cc::RenderingStatsInstrumentation::AccumulateAndClearImplThreadStats.

Race is fixed.

R=thestig@chromium.org,glider@chromium.org
NOTRY=True
BUG=370244

Review URL: https://codereview.chromium.org/282263003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270817 0039d316-1c4b-4281-b951-d872f2087c98

Split out the platform-event dispatch specific code out of the 'events'
target into its own 'events_platform' target, and the x11-specific code
into 'x11_events_platform' target.

BUG=361137
R=sky@chromium.org

Review URL: https://codereview.chromium.org/284743009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270816 0039d316-1c4b-4281-b951-d872f2087c98

Extend PR_ParseTimeString() to accept some ISO 8601 formats to fix timezone parsing in SyslogParser.

Previously, SyslogParser::ParseTime() would parse time, reformat it in a way that is understood by NSPR and then hand it off to PR_ParseTimeString() where it is parsed again.  This double-parsing is unnecessarily convoluted and slow.  Extending PR_ParseTimeString() simplifies and speeds up SyslogParser::ParseTime() which is time-critical in case of large log files.

BUG=370509

Review URL: https://codereview.chromium.org/266193002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270815 0039d316-1c4b-4281-b951-d872f2087c98

Cast Streaming API should call stop callback only after started.

BUG=373443

Review URL: https://codereview.chromium.org/281333002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270814 0039d316-1c4b-4281-b951-d872f2087c98

BUG=373482
TBR=xiyuan@chromium.org

Review URL: https://codereview.chromium.org/282313002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270813 0039d316-1c4b-4281-b951-d872f2087c98

EventFactoryEvdev does nothing without a DeviceManger. Remove the
constructor that doesn't have one and make test/egltest explicitly
pass NULL for cursor delegate.

TBR=dnicoara
BUG=none
TEST=content_shell --ozone-platform=test
NOTRY=true

Review URL: https://codereview.chromium.org/281283002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270812 0039d316-1c4b-4281-b951-d872f2087c98

Delete the "Example" benchmarking extension, as no one's using it, and
we have better tools, like WebPageReplay.  This keeps the benchmarking
API, is it's used by telemetry and WebPageReplay, but does remove the
function to enable/disable SPDY support at runtime.

This is one step towards getting rid of the SPDY configuration globals.
There are no tests for enabling/disabling SPDY when a URLRequestContext has
in-flight requests, and supporting it really doesn't get us anything.

BUG=372533

Review URL: https://codereview.chromium.org/280383008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270811 0039d316-1c4b-4281-b951-d872f2087c98

A new target 'cast_tools' is created to include:
cast_sender_app
cast_receiver_app
udp_proxy

cast_unittests now depends on cast_tools such that we have build
coverage with trybots.

Review URL: https://codereview.chromium.org/282103002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270810 0039d316-1c4b-4281-b951-d872f2087c98

This CL makes BrowserPluginGuestDelegate::HandleKeyboardEvent match WebContentsDelegate::HandleKeyboardEvent.

BUG=364141, 330264

Review URL: https://codereview.chromium.org/288113005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270809 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
NOTRY=true

Review URL: https://codereview.chromium.org/286113005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270808 0039d316-1c4b-4281-b951-d872f2087c98

Queued immediately after an OnSettings() visitor call.

Use a placeholder frame as needed in impacted tests,
so that test flow isn't protocol-version dependent.

BUG=345769

Review URL: https://codereview.chromium.org/289823002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270807 0039d316-1c4b-4281-b951-d872f2087c98

I don't really this is the root cause of r371851, but anyway,
tighten up the logic seems reasonable.

BUG=371851
TEST=
R=kbr@chromium.org

Review URL: https://codereview.chromium.org/283823002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270806 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270805 0039d316-1c4b-4281-b951-d872f2087c98

BUG=373500

Review URL: https://codereview.chromium.org/288243003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270804 0039d316-1c4b-4281-b951-d872f2087c98

This is a poor-man's solution to unblock the apps v2 release. It causes an
existing Chrome window (or a new one if there aren't any) to download the
installer. This is needed because the v2 app doesn't have a brower context,
which means no download shelf for the user to click when the download completes.
The UX is pretty horrible because the Chrome window pops on top of the app
window, typically obscuring the instructions. I'm open to better solutions.

This also fixes a bug in the host setup and install dialogs, which were not
showing the translucent screen that normally obscures the main UI while a
modal dialog is open.

Review URL: https://codereview.chromium.org/282113002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270802 0039d316-1c4b-4281-b951-d872f2087c98

    
We will be using ImageStore with
BrowserThread::PostBlockingPoolSequencedTask which doesn't always
guarantee same thread execution.
    
BUG=368034

Review URL: https://codereview.chromium.org/288573003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270801 0039d316-1c4b-4281-b951-d872f2087c98

BUG=371295

Review URL: https://codereview.chromium.org/271853002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270800 0039d316-1c4b-4281-b951-d872f2087c98

Speciffically, handle case when a non ASCII UTF8 character is read
partially from the process output. Instead of reporting read character
bytes imediatelly, cache them until the rest of the character is read
from the process output.

BUG=278340
TEST=in crosh (see comment #1 in the bug):
$python
>>> print(u"\u20ac" * 10000)
Verify a series of EURO signs is displayed (without "unknown" characters)

Review URL: https://codereview.chromium.org/261743002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270799 0039d316-1c4b-4281-b951-d872f2087c98

Causing Android Tests failure in telemetry_perf_unittests.

> [telemetry] Make testMeasurementSmoke generate separate tests.
> 
> This way failures in one benchmark won't stop the rest of the tests, and it'll print separate GTest steps for each benchmark.
> The test names follow the format BenchmarkSmokeTest.benchmark.name so you can still find BenchmarkSmokeTest with a search.
> 
> Also:
> - Rename it to the more apt BenchmarkSmoke.
> - Print Chrome stack trace when there's a tab crash at Chrome startup.
> 
> 
> BUG=368401,371613,373385
> TEST=tools/perf/run_tests benchmark
> NOTRY=true
> 
> Review URL: https://codereview.chromium.org/287773002

TBR=dtu@chromium.org

Review URL: https://codereview.chromium.org/289053002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270798 0039d316-1c4b-4281-b951-d872f2087c98

> Suppressed screen rotation notifications triggeres by the accelerometer
> 
> BUG=364949
> Test=MaximizeModeControllerTest.BlockRotationNotifications
> 
> Review URL: https://codereview.chromium.org/267743010

TBR=bruthig@chromium.org

Review URL: https://codereview.chromium.org/290563003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270793 0039d316-1c4b-4281-b951-d872f2087c98

BUG=322664

Review URL: https://codereview.chromium.org/278113002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270791 0039d316-1c4b-4281-b951-d872f2087c98

Remove include of Xlib.h in x11_atom_cache.h and forward declare the necessary X11 types. This is needed for tests because the definition of None in X.h conflicts with the definition of None in gtest-type-util.h

BUG=None
TEST=None
TBR=sadrul

Review URL: https://codereview.chromium.org/286103003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270790 0039d316-1c4b-4281-b951-d872f2087c98

Instead of skipping the interception, abort the prerender so that the prerender
doesn't cause the actual navigation to bypass the interception.

BUG=370519

Review URL: https://codereview.chromium.org/265293011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270789 0039d316-1c4b-4281-b951-d872f2087c98