- 05 Oct, 2017 23 commits
-
-
Xianzhu Wang authored
This class is seperated from ContentLayerClientImpl so that it can be used from GraphicsLayer to generate raster invalidations based on paint chunks for SPv175. Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Icd83f4767788c49fa86f9676e85751e15158b5c6 Reviewed-on: https://chromium-review.googlesource.com/698873 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Tien-Ren Chen <trchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#506596}
-
Eric Stevenson authored
Record UMA once during startup only for the browser process. Bug: 768497 Change-Id: I24fa3eebe812ee4dc423390535e7b52ab8c6fcd1 Reviewed-on: https://chromium-review.googlesource.com/699697 Commit-Queue: Eric Stevenson <estevenson@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#506595}
-
Naoki Fukino authored
Since the tooltip can overlap with mainPanel, files-tooltip should be placed after the mainPanel in DOM order. Bug: 771106 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I81bbdae1548bee3d431f4029cb323a6e5ddf43b3 Reviewed-on: https://chromium-review.googlesource.com/700117 Commit-Queue: Naoki Fukino <fukino@chromium.org> Reviewed-by:
Keigo Oka <oka@chromium.org> Cr-Commit-Position: refs/heads/master@{#506594}
-
Philip Rogers authored
PaintControllerPaintTest is useful to test with Root Layer Scrolling (RLS) enabled. This patch removes the special test configuration that did not include RLS and runs the tests with the default paint test configurations which has RLS. The following tests failed with root layer scrolling and SPV1: FullDocumentPaintingWithCaret and InlineRelayout. These failures were due to how the background display item client works in the SPV1+RLS case, and these tests have been updated to have different clients in this case. Bug: 769465 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Ib2c46aeb57b386635740918c073965257c08f17d Reviewed-on: https://chromium-review.googlesource.com/699518Reviewed-by:
Steve Kobes <skobes@chromium.org> Reviewed-by:
Stefan Zager <szager@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#506593}
-
Devlin Cronin authored
crrev.com/1f2b58d7 removed the old settings page code, but missed cleaning up the strings. Remove some that are no longer used. Bug: 771795 Change-Id: Ide2ee7e5a55395dc63f46fa2d54bf047739402ec Reviewed-on: https://chromium-review.googlesource.com/701640Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#506592}
-
Sarah Hu authored
Bug: 719015 Change-Id: I6f7cb61a81efdad03d2128484dfb831787fb350a Reviewed-on: https://chromium-review.googlesource.com/701404 Commit-Queue: Xiaoyin Hu <xiaoyinh@chromium.org> Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Cr-Commit-Position: refs/heads/master@{#506591}
-
Hidehiko Abe authored
BUG=234457 TEST=Ran bots. Change-Id: I59af0f6fba215a0eac5ae18a5cf2abf03d4d0077 Reviewed-on: https://chromium-review.googlesource.com/700337Reviewed-by:
Dan Erat <derat@chromium.org> Commit-Queue: Hidehiko Abe <hidehiko@chromium.org> Cr-Commit-Position: refs/heads/master@{#506590}
-
Kenneth Russell authored
BUG=770924 Change-Id: Ic9ec7d08da3e907a006a5284ecfdeaadd5149ff4 Reviewed-on: https://chromium-review.googlesource.com/701402Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#506589}
-
Benjamin Shaya authored
Some Post Processors prefer system volume, some need the actual dbfs applied. Solve this by providing both. Merge-With: eureka-internal/104865 BUG=internal b/65652496 TEST=cast_alsa_cma_backend_unittests Change-Id: I6aecdf3c70e65927972de25569b3a56d2fb5f7d2 Reviewed-on: https://chromium-review.googlesource.com/666043 Commit-Queue: Benjamin Shaya <bshaya@google.com> Reviewed-by:
Stephen Lanham <slan@chromium.org> Cr-Commit-Position: refs/heads/master@{#506588}
-
Nicolas Pena authored
Bug: chromium:764851 Change-Id: I10fbb98f9e18e013ce4ad8a7ae5f0a74c585d114 Reviewed-on: https://chromium-review.googlesource.com/688385 Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Cr-Commit-Position: refs/heads/master@{#506587}
-
Peter Kotwicz authored
BUG=713655 Change-Id: Ie0d98bb91de833328472f4455661665013ff0296 Reviewed-on: https://chromium-review.googlesource.com/698953 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#506586}
-
Vlad Tsyrklevich authored
This blacklist entry was required to work around a symbol compression mangling bug in clang after the libstdc++ blacklist entries were deleted. That bug was fixed in r310132. Bug: 751385 Change-Id: I90b856bd1b8e1d9e9680a530010c79d276fcb1f2 Reviewed-on: https://chromium-review.googlesource.com/691213Reviewed-by:
Peter Collingbourne <pcc@chromium.org> Commit-Queue: Peter Collingbourne <pcc@chromium.org> Cr-Commit-Position: refs/heads/master@{#506585}
-
Peng Huang authored
When a surface becomes fully transparent, we will not include a TextureDrawQuad for the resource, so the resource will be released. When the surface becomes non transparent, we need update the resource again to avoid using an invalid resource. Bug: 757717 Change-Id: I10c1754497fb539070560946eaf17faee7260e32 Reviewed-on: https://chromium-review.googlesource.com/701235 Commit-Queue: Peng Huang <penghuang@chromium.org> Reviewed-by:
David Reveman <reveman@chromium.org> Cr-Commit-Position: refs/heads/master@{#506584}
-
Devlin Cronin authored
Use the ExtensionId typedef instead of std::string in RendererMessagingService method. Bug: None Change-Id: Ibdf8e9ee5a0de65c220d70c255ffd58f52e0f451 Reviewed-on: https://chromium-review.googlesource.com/699753Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#506583}
-
Devlin Cronin authored
Run extension messaging tests with both JS-based and native extension bindings. This will be useful in detecting any regressions (in either version) as we develope native extension messaging bindings. Bug: 653596 Change-Id: I19e58d385da9c134142c39465358d7bbfed7bef0 Reviewed-on: https://chromium-review.googlesource.com/699751Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#506582}
-
Stephen Martinis authored
I had it set to be an android compile, because I copy pasted from the other compile builders on fyi. Bug: 758630 Change-Id: I351cb22173dff6c24b249cda6044a4869c1edbd1 Reviewed-on: https://chromium-review.googlesource.com/701374Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#506581}
-
Will Chen authored
Now that all of the DevTools integration tests live in one folder (http/tests/devtools/) I can do some clean-up in test_interfaces.cc This also moves a test that accidentally got left behind. Bug: 667560 Change-Id: I5922fd17d3d2006b74971d3a37e086d2d3e5d3db Reviewed-on: https://chromium-review.googlesource.com/696485Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Will Chen <chenwilliam@chromium.org> Cr-Commit-Position: refs/heads/master@{#506580}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 407d6db9. With Chromium commits locally applied on WPT: 54c54afc "Introduce NavigatorAutomationInformation interface" Build: https://build.chromium.org/p/chromium.infra.cron/builders/wpt-importer/builds/2560 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md TBR=qyearsley@chromium.org No-Export: true Change-Id: I4cb74855ac719ef520d8f5ac5a2c8e47c42a28ad Reviewed-on: https://chromium-review.googlesource.com/701477 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#506579}
-
Yoland Yan authored
For more on JUnit4 migration, please check src/testing/android/docs/junit4.md Bug: 640116 Change-Id: Icbd7c78acda5897a983cfe8fcafb2ffc4ead94d8 Reviewed-on: https://chromium-review.googlesource.com/701596Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Yoland Yan <yolandyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#506578}
-
Kevin Bailey authored
This reverts commit 3aae0039. Reason for revert: Increase in crashes on Android, surrounding 'AutocompleteController::DeleteMatch'. crbug.com/771603 Original change's description: > [omnibox] Change ACMatches from vector to list > > The bulk of heavy work done on ACMatches is std::sort() and > std::rotate. This process takes a noticeable amount of time, and it's > run several times per user keystroke. Making ACMatches a list instead > of a vector means that elements can be moved around trivially, instead > of being copied. The execution time for the "long poles" goes down to > a tenth of the previous time. > > Bug: > Change-Id: Id663a58c05e39f7a2310d97cbccaa679fc3d1b70 > Reviewed-on: https://chromium-review.googlesource.com/667436 > Commit-Queue: Kevin Bailey <krb@chromium.org> > Reviewed-by: Peter Kasting <pkasting@chromium.org> > Cr-Commit-Position: refs/heads/master@{#503015} TBR=pkasting@chromium.org,krb@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: If4b0eee9705613d57b8a743ca693fff4e4e0cc00 Reviewed-on: https://chromium-review.googlesource.com/700854 Commit-Queue: Kevin Bailey <krb@chromium.org> Reviewed-by:
Kevin Bailey <krb@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#506577}
-
Avi Drissman authored
BUG=771142 TEST=crashes go away Change-Id: I6bb1c0986bc16aba253129c57db08eaefc4cc83a Reviewed-on: https://chromium-review.googlesource.com/698666Reviewed-by:
Mike Wittman <wittman@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#506576}
-
Trent Apted authored
RenderWidgetHostViewGuest started generating synthetic keyboard NSEvents from blink::WebInputEvent in r489154. These events didn't include an NSWindow which meant that a fallback path was triggered in -[CommandDispatcher redispatchKeyEvent] which caused a second NSEvent to be synthesized, to add the NSWindow back on. This "worked" for Cocoa (NativeAppWindowCocoa), but not for views- backed guest views, causing WebViewInteractiveTest.EditCommands/0 to regress and WebViewInteractiveTest.TextSelection/1 to time out. Fix those by passing GetNativeView() to the NativeWebKeyboardEvent constructor in RenderWidgetHostViewGuest::OnHandleInputEvent(). This also avoids triggering the fallback path in CommandDispatcher, so only one synthetic NSEvent is created. Bug: 770547 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation Change-Id: I50ded74f7563f755dd6d735750437bbbafff39e2 Reviewed-on: https://chromium-review.googlesource.com/700174Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#506575}
-
Greg Thompson authored
On Windows, SendMouseMove must transform a point in screen coordinates into the range (0..2^16-1) for consumption by SendInput. Windows then converts this back to screen coordinates. This change rounds up rather than down in the initial conversion so that Windows lands on the correct point when it seemly truncates. Previously, we'd see off-by-one errors from time to time. While this may seem insignificant at first blush, it's problematic when SendMouseMove is called to move the mouse to a point where it already resides. No events are generated by SendInput in this case, so the hook proc will never be called. This shouldn't be a problem since SendMouseMove detects this case and short-circuits the request. With the ob1, however, SendMouseMove thinks it needs to move the mouse by one point, yet the bad math results in a call to SendInput to move the mouse to its current position. This makes tests timeout and all of us sad. BUG=390564,639940,710436,726659,728488,764415 R=mathp@chromium.org, sky@chromium.org Change-Id: I1daebe8281db0a799ef7266c3c1765de65580f03 Reviewed-on: https://chromium-review.googlesource.com/686898Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Commit-Queue: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#506574}
-
- 04 Oct, 2017 17 commits
-
-
Helen Li authored
Make sure CronetUploadDataStream always initializes mRequest in the constructor. TBR=kapishnikov@chromium.org Bug: 771366 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester Change-Id: I608ff1a8c47e1860fa598dac81ecc957b26f0312 Reviewed-on: https://chromium-review.googlesource.com/701476 Commit-Queue: Helen Li <xunjieli@chromium.org> Reviewed-by:
Andrei Kapishnikov <kapishnikov@chromium.org> Reviewed-by:
Helen Li <xunjieli@chromium.org> Cr-Commit-Position: refs/heads/master@{#506573}
-
dpapad authored
This is a remainder from removing md-settings as a valid host. Bug: None Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I1f5a910859b83f9330522b4a9270c6c1bd1627d6 Reviewed-on: https://chromium-review.googlesource.com/699750Reviewed-by:
Dan Beam (no longer on Chrome) <dbeam@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#506572}
-
Mustafa Emre Acer authored
It no longer seems flaky, at least on local runs. Bug: 396458 Change-Id: I1162035b5d2b1049d4fa22597a3bd57c05e7e00c Reviewed-on: https://chromium-review.googlesource.com/701655Reviewed-by:
Adrienne Porter Felt <felt@chromium.org> Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#506571}
-
Will Harris authored
Bug: Cq-Include-Trybots: master.tryserver.chromium.win:win10_chromium_x64_rel_ng Change-Id: I40efef37375249997ebeeec2cf596fce7f6c78d3 Reviewed-on: https://chromium-review.googlesource.com/695705 Commit-Queue: Will Harris <wfh@chromium.org> Reviewed-by:
Penny MacNeil <pennymac@chromium.org> Cr-Commit-Position: refs/heads/master@{#506570}
-
Bo Liu authored
Old behavior before PlzNavigate was that resource for a LoadDataWithBaseURL navigation does *not* trigger shouldInterceptRequest. Also add tests to verify shouldInterceptRequest with various load data calls. This CL adds a hack to get back to the same behavior. Hack works by filtering out empty data URLs, which through a quirk in content is what's sent up for the shouldInterceptRequest call. This is a hack because it's relying on a content implementation detail which can change at any time. It is also risky if there are legitimate cases where an empty data URL is used in practice. This is short term fix to ship PlzNavigate in webview, but this hack should definitely be revisited soon after. Bug: 769126 Change-Id: I70b5ca44a33126f6470978a9ffe8f7d8126c15bd Reviewed-on: https://chromium-review.googlesource.com/698724Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#506569}
-
Ken Rockot authored
This corrects some invalid DCHECKs in the Blink MojoWatcher implementation to account for cases where a handle is closed while being watched. The invalid assumption was leading to potential use of an uninitialized value. The bug does not affect any production code, but was triggered by clusterfuzz. Also adds an OWNERS to Blink mojo code with an appropriate component tag. R=yzshen@chromium.org Bug: 770458 Change-Id: I06ad446e3a3ae13545737c578d1180ff438c49d7 Reviewed-on: https://chromium-review.googlesource.com/700807Reviewed-by:
Yuzhu Shen <yzshen@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#506568}
-
Lei Zhang authored
One can simply refer to FooClass::Bar as Bar inside FooClass and derived classes. Change-Id: I992e50e16d68b5d77f64e63e4c5ffb7dcd98c434 Reviewed-on: https://chromium-review.googlesource.com/701366Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#506567}
-
Steven Bennetts authored
This also moves the 'RequestSignOut' interface used within Ash to LockStateController which is a more logical place for the UI to call into, and sets the code up for some day handing signout directly. Bug: 665582 Change-Id: I8624a071a825a33f95ba2b33a0ff1809e477754e Reviewed-on: https://chromium-review.googlesource.com/701497Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#506566}
-
Raymond Toy authored
Just a rename of the files so that the related oscillator sweep tests are grouped together when listed No functional changes. Bug: 771696 Test: none Change-Id: Ife3d04e1e3bec7e69378abb00e676fa4637fe4eb Reviewed-on: https://chromium-review.googlesource.com/700800Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Commit-Queue: Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#506565}
-
mark a. foltz authored
Fix Android implementation of Media Router to handle empty (unique) origins properly through custom comparison. Adds unit tests and removes redundant code from existing tests. Bug: 685358 Change-Id: I051e5d7856f4fb9476166aa1ddda170bef2d5983 Reviewed-on: https://chromium-review.googlesource.com/699738 Commit-Queue: mark a. foltz <mfoltz@chromium.org> Reviewed-by:
Zhiqiang Zhang <zqzhang@chromium.org> Reviewed-by:
Derek Cheng <imcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#506564}
-
catapult-deps-roller@chromium.org authored
https://chromium.googlesource.com/catapult.git/+log/8894309be5ce..5ced63b1db3f $ git log 8894309be..5ced63b1d --date=short --no-merges --format='%ad %ae %s' 2017-10-04 oysteine Wrap a performance.now call in a try/catch to use in contexts without it 2017-10-04 wkorman Simplify asDict field copy for maintainability. Created with: roll-dep src/third_party/catapult Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I90413399c4b55f5c3aa89f24a24376a4dd153d0f Reviewed-on: https://chromium-review.googlesource.com/701463 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#506563}
-
Liquan (Max) Gu authored
Probe:v8Compile used to use null for execution context for the unavailability of execution context. Now the execution context has been available and the comment is no longer valid. Bug: 738495 Change-Id: Ic2c107e8c4f6ff22d470b56e16864c309d3d93b9 Reviewed-on: https://chromium-review.googlesource.com/701475Reviewed-by:
Nate Chapin <japhet@chromium.org> Commit-Queue: Liquan Gu <maxlg@chromium.org> Cr-Commit-Position: refs/heads/master@{#506562}
-
Jungshik Shin authored
The current script mixing policy (moderately restricitive) allows mixing of Latin-ASCII and one non-Latin script (unless the non-Latin script is Cyrillic or Greek). This CL tightens up the policy to block mixing of Latin-ASCII and a non-Latin script unless the non-Latin script is Chinese (Hanzi, Bopomofo), Japanese (Kanji, Hiragana, Katakana) or Korean (Hangul, Hanja). Major gTLDs (.net/.org/.com) do not allow the registration of a domain that has both Latin and a non-Latin script. The only exception is names with Latin + Chinese/Japanese/Korean scripts. The same is true of ccTLDs with IDNs. Given the above registration rules of major gTLDs and ccTLDs, allowing mixing of Latin and non-Latin other than CJK has no practical effect. In the meantime, domain names in TLDs with a laxer policy on script mixing would be subject to a potential spoofing attempt with the current moderately restrictive script mixing policy. To protect users from those risks, there are a few ad-hoc rules in place. By switching to highly restrictive those ad-hoc rules can be removed simplifying the IDN display policy implementation a bit. This is also coordinated with Mozilla. See https://bugzilla.mozilla.org/show_bug.cgi?id=1399939 . BUG=726950, 756226, 756456, 756735, 770465 TEST=components_unittests --gtest_filter=*IDN* Change-Id: Ib96d0d588f7fcda38ffa0ce59e98a5bd5b439116 Reviewed-on: https://chromium-review.googlesource.com/688825Reviewed-by:
Brett Wilson <brettw@chromium.org> Reviewed-by:
Lucas Garron <lgarron@chromium.org> Commit-Queue: Jungshik Shin <jshin@chromium.org> Cr-Commit-Position: refs/heads/master@{#506561}
-
pdr authored
longer implemented. ObjectPaintProperties also had quite a few unnecessary includes that have been removed. ObjectPaintProperties: :ContentsProperties was declared but is no Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I8fa46a22866855d3e381d5b2493436f65abf620c Reviewed-on: https://chromium-review.googlesource.com/695810Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#506560}
-
Justin Schuh authored
This reverts commit ffc71c03. Reason for revert: Didn't improve the perf issue. Original change's description: > Reorder saturation calculation for ClampAddOp and ClampSupOp > > The order of operations changed in crrev.com/505494 with C++14 > constexpr optimizations. However, that change appears to have regressed > performance in some cases. So, this CL tweaks the code to match the > old structure and trigger the same compiler optimization heuristics. > > Bug: 770832 > Change-Id: I28f57ddf53825619eb73c9a92c663fc8463e16a7 > Reviewed-on: https://chromium-review.googlesource.com/696721 > Reviewed-by: Tom Sepez <tsepez@chromium.org> > Commit-Queue: Justin Schuh <jschuh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#506078} TBR=jschuh@chromium.org,tsepez@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 770832 Change-Id: I076c93215b422e321ad4bf39a72bab144cc0195d Reviewed-on: https://chromium-review.googlesource.com/700775Reviewed-by:
Justin Schuh <jschuh@chromium.org> Commit-Queue: Justin Schuh <jschuh@chromium.org> Cr-Commit-Position: refs/heads/master@{#506559}
-
Dan Beam authored
This was needed when the "uber" page hosted multiple different iframes: <iframe src="chrome://settings"></iframe> <iframe src="chrome://extensions"></iframe> <iframe src="chrome://history"></iframe> <iframe src="chrome://about"></iframe> for code separation purposes. Because the "uber" page UI has been replaced and the replacements don't use <iframe>s, the code can be removed. R=creis@chromium.org BUG=683418,666525 Change-Id: I1ee60a3fe74af3bfc78503740cbccf134ea41bd8 Reviewed-on: https://chromium-review.googlesource.com/696718Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Commit-Queue: Dan Beam (no longer on Chrome) <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#506558}
-
Lukasz Anforowicz authored
Bug: 758075, 700535, 582522, 602497, 616905 Bug: 623268, 623265, 678492 Change-Id: I1bdc648c9aeb97cc1d16b0d8693d04e0c76030de Reviewed-on: https://chromium-review.googlesource.com/700983 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#506557}
-