- 20 Dec, 2017 40 commits
-
-
Mostyn Bramley-Moore authored
Change-Id: I63d49a3954e939adfd4337ef8e81498e1cdf3643 Reviewed-on: https://chromium-review.googlesource.com/836888Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Mostyn Bramley-Moore <mostynb@vewd.com> Cr-Commit-Position: refs/heads/master@{#525347}
-
rhalavati@google.com authored
Added last updated place holder and content hash code to network traffic annotation auditor's TSV report, to be used for keeping up the annotations trix. Bug: 656607 Change-Id: If7e998250d827daedb9653e0a5d20135130a7325 Reviewed-on: https://chromium-review.googlesource.com/836589Reviewed-by:
Martin Šrámek <msramek@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#525346}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/6a279326..cead990c Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I291ed6166fc55c165f68b08e395bff783d8652c0 Reviewed-on: https://chromium-review.googlesource.com/836668Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#525345}
-
Peter Wen authored
https://groups.google.com/d/topic/error-prone-announce/-ExdzeDOURY/discussion BUG=793900 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ic4e3c7b3a39a64a4c1ef85c0ce5db770b33dba4b Reviewed-on: https://chromium-review.googlesource.com/820530Reviewed-by:
agrieve <agrieve@chromium.org> Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Commit-Queue: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#525344}
-
Jiaquan He authored
This is a pre-flight commit for refactoring ChromeAppListItem, which: - uses ChromeAppListItem in chrome AppListModelUpdater interfaces instead of AppListItem, since they're always instances of ChromeAppListItem and we won't have AppListItem included in chrome; - changes test APIs to accept the an item's id instead of its pointer; - removes item order checks to care about the item set only; - removes AppListModelUpdater::MoveItem since it's only used in order-related tests. Bug: 733662 Change-Id: I118a1649cd2468dce586486043662f33dc9ad394 Reviewed-on: https://chromium-review.googlesource.com/832378Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Nicolas Zea <zea@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Jiaquan He <hejq@google.com> Cr-Commit-Position: refs/heads/master@{#525343}
-
Koji Ishii authored
Following bot results are included. 2562 2563 2564 2567 2569 2571 2573 2579 2581 2582 2585 917 lines were removed by consecutive passes since 2537. TBR=eae@chromium.org NOTRY=true Bug: 591099 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I9bf666bfc006ef869f4e1efa6d762af13b5bda57 Reviewed-on: https://chromium-review.googlesource.com/836827 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#525342}
-
Mike Klein authored
There may not be anything to rebaseline here after all. We'll see. Bug: skia:5733 Change-Id: Ia58097395850ec15a840bd99ed85e4109bcac607 Reviewed-on: https://chromium-review.googlesource.com/836807Reviewed-by:
Florin Malita <fmalita@chromium.org> Commit-Queue: Mike Klein <mtklein@chromium.org> Cr-Commit-Position: refs/heads/master@{#525341}
-
Andrew Grieve authored
It's unused and the functionality is duplicated in dist_jar(). Change-Id: I9d689e4bb310412a1e1a883bc0fb9f46f7cd1ede Reviewed-on: https://chromium-review.googlesource.com/833157Reviewed-by:
-
Donn Denman authored
The native ContextualSearchRankerLoggerImpl was holding on to a WebContents pointer, which is somewhat dangerous. We're seeing crashes due to the WebContents going stale. This change just uses the WebContents to get the UKM SourceId and hangs on to it instead. The SourceId is all that's needed when we write the log. Now we also invalidate the SourceId when the log is written to ensure that we don't try to write more than once per SetupLoggingAndRanker call. BUG=795936 Change-Id: I4d1363ae709263bc76fc54f4c6316963c12f5018 Reviewed-on: https://chromium-review.googlesource.com/836127Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Roger McFarlane <rogerm@chromium.org> Commit-Queue: Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#525339}
-
Gauthier Ambard authored
This CL moves the ownership of the OmniboxPopupViewIOS to the OmniboxPopupCoordinator. The coordinator is now owned by the toolbar, where the popup view was previous owned. It also changes the PopupView so it communicates with the mediator and has now no knowledge of the coordinator. Bug: 788640 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I530562cc0e52ed8ede575fc689a5326faf978e81 Reviewed-on: https://chromium-review.googlesource.com/833878 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#525338}
-
Lily Houghton authored
Setting the QUIC user agent ID to a non-default value should be done using the experimental options API. Bug: 670686 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I79bdbde1b1f8be0af3eff7d8d6080974e322b33c Reviewed-on: https://chromium-review.googlesource.com/822811 Commit-Queue: Lily Houghton <lilyhoughton@chromium.org> Reviewed-by:
Misha Efimov <mef@chromium.org> Cr-Commit-Position: refs/heads/master@{#525337}
-
Boris Sazonov authored
This CL removes support for old generic signin promos from Bookmarks and RecentTabs. These promos were superseded by personalized signin promos. Old promos were implemented in SigninAndSyncView, so this CL also removes support for signin promos from this class. SigninAndSyncView will be renamed in follow-up CLs. Bug: 792430 Change-Id: I752f90339377e34c70766109a13f5e92e5ef1ea7 Reviewed-on: https://chromium-review.googlesource.com/836867Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#525336}
-
Charlie Andrews authored
This reverts commit af0c9396. The underlying problem was that disables without an associated reason weren't having any effect. I already had a fix for this in the most recent build, so this additional disable shouldn't be necessary. TBR=oysteine@chromium.org, aseemgarg@chromium.org, nednguyen@google.com NOTRY=true Bug: 796547 Change-Id: Idfc6e3b90619d54630125753ea76abb2dfa939ee Reviewed-on: https://chromium-review.googlesource.com/836948 Commit-Queue: Charlie Andrews <charliea@chromium.org> Reviewed-by:
Charlie Andrews <charliea@chromium.org> Cr-Commit-Position: refs/heads/master@{#525335}
-
Peter Beverloo authored
Instead use the Permission Service directly from Blink. TBR=thakis for header *removal* from //chrome/browser/DEPS Bug: 612312 Change-Id: I88e7a2f8913bdd0e97521b11193ff0ccd96c6aad Reviewed-on: https://chromium-review.googlesource.com/822936Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#525334}
-
Daniel Bratell authored
There was still two NOTIFY_OBSERVERS macros and in jumbo builds they triggered an error about macros being redeclared. This patch renames the macro that implements observer handling methods for Windows from NOTIFY_OBSERVERS to NOTIFY_OBSERVERS_METHOD. Bug: 773275 Change-Id: Ie58fd1793b144b694a0a34bfa552569db3f8a200 Reviewed-on: https://chromium-review.googlesource.com/836611Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#525333}
-
John Abd-El-Malek authored
This is already the case for chrome & content_shell, but wasn't for android_webview or headless. This is split off from https://chromium-review.googlesource.com/c/chromium/src/+/826303 which needs this behavior. Bug: 769401 Change-Id: I9777d85de6206ba932a83d6b48516acdf5de1671 Reviewed-on: https://chromium-review.googlesource.com/836069Reviewed-by:
Eric Seckler <eseckler@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#525332}
-
Colin Blundell authored
WebHistoryService is a client of SigninManager and ProfileOAuth2TokenService. Its unittest creates fakes of these classes to supply them to the WebHistoryService instance under test. However, these dependencies are actually unnecessary: - WebHistoryService's only usage of these classes is to pass them to an internal RequestImpl class that makes access token requests. - The unittest deliberately eschews usage of RequestImpl, replacing it with a TestRequest class that makes no usage of //components/signin. Note that changing the tests to actually exercise RequestImpl would be a non-trivial amount of work, as RequestImpl has substantial other interactions that would need to be stubbed out (e.g., with the network). This CL simply eliminates the unused dependencies from the test. Bug: 796545 Change-Id: I45c55684e119ece7172c8ee406486a46faca815e Reviewed-on: https://chromium-review.googlesource.com/835109Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#525331}
-
clamy authored
This CL ensures that PlzNavigate aka browser-side navigation is always enabled. Renderer-side navigation is no longer supported. BUG= 789577 Change-Id: Icc8f99966ae562799ebd44d077287970702d642f Reviewed-on: https://chromium-review.googlesource.com/832651 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#525330}
-
Adithya Srinivasan authored
When the type of an HTMLInputElement changes, the labels LiveNodeList inconsistently gets invalidated (depending whether the shadow subtree of the input element changes). This CL causes invalidation of the labels nodelist to happen any time any of the name/id/type/for/form attributes changes for an element. Bug: 795910 Change-Id: Ice58060e06150f58b4fb5c8771a413091446ff62 Reviewed-on: https://chromium-review.googlesource.com/833249Reviewed-by:
Keishi Hattori <keishi@chromium.org> Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Cr-Commit-Position: refs/heads/master@{#525329}
-
Oystein Eftevaag authored
CC=aseemgarg@chromium.org NOTRY=true TBR=nednguyen@chromium.org BUG=796547 Change-Id: I96d814ed8c23d539cb17b448521c4a009d22a275 Reviewed-on: https://chromium-review.googlesource.com/836598 Commit-Queue: oysteine <oysteine@chromium.org> Reviewed-by:
oysteine <oysteine@chromium.org> Cr-Commit-Position: refs/heads/master@{#525328}
-
Jochen Eisinger authored
Otherwise, the traces won't include events from renderers R=skyostil@chromium.org Change-Id: I40e33b3191c3e1d58a77aadf57583600286430df Reviewed-on: https://chromium-review.googlesource.com/833880Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#525327}
-
Balazs Engedy authored
Move method definitions after type definitions to comply with style guide, and rearrange methods to make more sense. Bug: 740081 Change-Id: I0c77ac065203d9d917815151417ea1d24de56b61 Reviewed-on: https://chromium-review.googlesource.com/833887 Commit-Queue: Balazs Engedy <engedy@chromium.org> Reviewed-by:
-
Morten Stenshorne authored
This is about implementing the "forced break" values for the CSS properties break-after and break-before. The legacy page-break-before:always and page-break-after:always declarations also work, if in paged media. For multicol, on the other hand, it's more about supporting break-before:column and break-after:column. Forced fragmentainer breaks may only occur at class A break points [1]. If there's a forced break-before value on a first in-flow child, or a break-after value on a last in-flow child, the values are to be propagated through the containing block chain, until we find a suitable place to break. [2] If we don't find a suitable break point, no break will be inserted. Initial and final break values inside a block are propagated upwards via NGLayoutResult. A few more layout tests pass. A few regress, too, among other things because we don't handle borders at column boundaries too well yet, and that we don't disable fragmentation inside scrollable containers. Some of the code in this CL is taken from LayoutBox in the legacy engine. [1] https://www.w3.org/TR/css-break-3/#possible-breaks [2] https://www.w3.org/TR/css-break-3/#break-between Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: Id67f2ed2d008a6d98a7c7a43d98c345964035e7b Reviewed-on: https://chromium-review.googlesource.com/835110 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#525325}
-
Yuki Shiino authored
IntersectionObservers are usually made alive through the observation target elements (ElementIntersectionObserverData). However, it's possible that the target element gets detached from the document while an observation event is being scheduled (while it's pending). Considering this corner case, IntersectionObserverController should take responsibility to make the sheduled IntersectionObservers alive. Bug: 792604 Change-Id: I63a435173d51025dcd4fd4276bc7cc1788e9a2bf Reviewed-on: https://chromium-review.googlesource.com/836575Reviewed-by:
-
Friedrich Horschig authored
This CL removes the following metrics and code that records them: Favicons.CandidatesCount Favicons.CandidatesWithDefinedSizesCount Favicons.CandidatesWithTouchIconsCount Favicons.DownloadOutcome Favicons.DownloadAttempts.{Favicons,LargeIcons,TouchIcons} Bug: 794047 Change-Id: Idc063fc86f449b2d64269b95e403291a5e4db504 Reviewed-on: https://chromium-review.googlesource.com/827079 Commit-Queue: Friedrich Horschig <fhorschig@chromium.org> Reviewed-by:Jan Krcal <jkrcal@chromium.org> Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#525323}
-
stkhapugin@chromium.org authored
Wraps omnibox textfield into a container that positions the textfield inside of itself and clips its bounds so that the optimal clipping is used. The clipping logic replicates that of the pre-iOS 11 solution with UITextField overrides that are now broken in iOS 11. To mask the clipped ends of the omnibox, a ClippingMaskView is used as a maskView of the clipping view. All of this is behind kClippingTextfield flag that is enabled by default. Bug: 749788 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ia03649618397d19990d39914fe1fb1b152b2760d Reviewed-on: https://chromium-review.googlesource.com/779191 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
-
Ran Ji authored
Fail back to shortcut if there is no enough space to install WebApk even after freeing cache. Free cache and install if there is no enough space but the space requirement can be satisfied using the cache storage. Bug: 774513,736457 Change-Id: I1beec2b3c26ebfb09e03014038a2657b27185284 Reviewed-on: https://chromium-review.googlesource.com/794532Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/59c19a3877cb..0dec3af001ac $ git log 59c19a387..0dec3af00 --date=short --no-merges --format='%ad %ae %s' 2017-12-20 reed cleanup unused fields/includes Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=csmartdalton@chromium.org Change-Id: I525baf31554f5378e81f313211d81709532e2bff Reviewed-on: https://chromium-review.googlesource.com/836687Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#525320}
-
stkhapugin@chromium.org authored
The test was flaky on iOS 9 device bots that we don't have anymore. Bug: 591379 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I21dc7f3a76739a82b77ee1a5d7fd920cc419545e Reviewed-on: https://chromium-review.googlesource.com/836595Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#525319}
-
Eric Seckler authored
Implemented using a new DevTools method to override certificate error handling browser-wide. This allows ignoring certificate errors in headless mode, too. Bug: 721739 Change-Id: I99d1962147ae638ef83dad5cad6fe1311e7c98b1 Reviewed-on: https://chromium-review.googlesource.com/810790 Commit-Queue: Eric Seckler <eseckler@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#525318}
-
Dominik Röttsches authored
Roll HarfBuzz to 1.7.3 to incorporate hb_set changes which improve dealing with fonts containing incorrectly sorted range information, such as the Chandas Devanagari font part of the ttf-devanagari-fonts package, as identified in https://bugs.chromium.org/p/chromium/issues/detail?id=794896 Cherry-pick 2fe5f885..a9432bde on top of 1.7.3 to incorporate hb_set regression fixes. Bug: 794896, 796124 Change-Id: I9256018b6ec6c7e84f9261c97758b2bee2d410a2 Tbr: kojii, eae, behdad Reviewed-on: https://chromium-review.googlesource.com/831946 Commit-Queue: Dominik Röttsches <drott@chromium.org> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#525317}
-
Ross McIlroy authored
Change-Id: Iba70082c0c8cb01c8bcb8c5c6e7f0fa237184f30 Reviewed-on: https://chromium-review.googlesource.com/834088Reviewed-by:
-
Gauthier Ambard authored
The omnibox popup is currently positioned using frames. It is not very practical as it means that the frames need to be recalculated when the UI changes, for example during rotations. This CL adds a UILayoutGuide to the toolbar, allowing the popup to be positioned and sized using the guide, including when its frame needs to be changed after a rotation. Bug: 795660, 788640, 786940 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I761a433f84a9c52fd73728b2c83a9ecc15f7fc02 Reviewed-on: https://chromium-review.googlesource.com/831518Reviewed-by:
-
Henrik Grunell authored
Don't get channel layout for input element since that's not supported on AUHAL[1], instead get the channel count from the stream layout. Plus fixes in ScopedAudioUnit: * Enable IO before setting current device which is a requirement. * Use element 0 with global scope, which is the element to use with that scope. (This didn't cause a failure.) [1] Follow-up on this to confirm: https://crbug.com/796163 Bug: 794501 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I3879989e30449000dc9d75f756c69738ac54615a Reviewed-on: https://chromium-review.googlesource.com/823972 Commit-Queue: Henrik Grunell <grunell@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#525314}
-
Lalit Maganti authored
Doing this refactoring cleans the way for a much nicer looking CL for https://chromium-review.googlesource.com/c/chromium/src/+/830946 as it can just use QueuedRequest::Args instead of adding more fields to the mojo struct or to QueuedRequest directly. Bug: 703184 Change-Id: Ia5c08d9173f351484b3b6ab14e10958995ac8588 Reviewed-on: https://chromium-review.googlesource.com/830846 Commit-Queue: Lalit Maganti <lalitm@chromium.org> Reviewed-by:
Hector Dearman <hjd@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#525313}
-
Noel Gordon authored
Comparison of a pointer difference to a size_t cause the compiler to whine about the different signs: 'long' and 'unsigned long' in this case. Fix that by using ptrdff_t for these comparisons. No change in behavior, no new tests. Tbr: mtklein@chromium.org Bug: 796470 Change-Id: Ie585ba45f1e09f31f7d4cf48c41f2378a1b0808b Reviewed-on: https://chromium-review.googlesource.com/836291 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#525312}
-
Joel Hockey authored
* Moved mojom definitions from content(/public)/common to WebKit/common/color_chooser. * Mojo calls are now made directly from blink in ColorChooserUIController. * Deleted unneeded implementation files: - content/renderer/renderer_webcolorchooser_impl.[h|cc] - third_party/WebKit/public/web/WebColorChooser.h - third_party/WebKit/public/web/WebColorChooserClient.h - third_party/WebKit/public/web/WebColorSuggestion.h - third_party/WebKit/Source/core/exported/WebColorSuggestion.cpp - third_party/WebKit/Source/platform/ColorSuggestion.h * Deleted unneeded test mock files: - content/shell/test_runner/mock_color_chooser.[h|cc] - replaced with mock-colorchooser.js to intercept mojo calls. Bug: 788960 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_dbg_ng Change-Id: I305a2abb3cba457042c877e6401abbe383611c75 Reviewed-on: https://chromium-review.googlesource.com/821954Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
-
Rob Buis authored
Both setting size IDL attribute directly as well as indirectly setting using setAttribute were not treating values bigger than 2147483647 correctly, so fix both code paths. Behavior matches Firefox and Safari. Bug: 651762 Change-Id: I6b3f2060eac9cfa6b1b8ad1898159c632257d625 Reviewed-on: https://chromium-review.googlesource.com/812010 Commit-Queue: Rob Buis <rob.buis@samsung.com> Reviewed-by:
-
Jérôme Lebel authored
When the user taps on the "Continue as ..." button in the sign-in promo, of the Other Devices tab, the user is signed in at the beginning of the sync confirmation animation. Therefore the TabSwitcherModel receives the sign-in notification and send a notification to the TabSwitcherController to reload before the end of the animation. While reloading the TabSwitcherController removes the current TabSwitcherPanelOverlayView that contains the sign-in promo view and its SigninPromoViewMediator. The issue is that SigninPromoViewMediator is supposed to live until the end of the sign-in to handle correctly the metrics (histograms and user actions). To avoid that, the SigninPromoViewMediator is now owned by the TabSwitcherController. And TabSwitcherModel asks its delegate if a sign-in is in progress. In that case, the sign-in notification is ignored. Therefore the UI is not updated while the sign-in interaction is appearing (see crbug.com/725925) Once the sign-in is finished (cancel or success), the TabSwitcherController is notified by SigninPromoViewMediator and then the TabSwitcherModel can be reloaded. Bug: 795895, 725925 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Iefff5975bc251ea39cb06c5d73a4adc135ce317b Reviewed-on: https://chromium-review.googlesource.com/832391 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#525309}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/acd59ef08512..59c19a3877cb $ git log acd59ef08..59c19a387 --date=short --no-merges --format='%ad %ae %s' 2017-12-20 angle-deps-roller Roll skia/third_party/externals/angle2/ ffd27d853..37385e11d (2 commits) Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=csmartdalton@chromium.org Change-Id: Icc1871c584ccd8372343509c2a5eb14a6fde58e3 Reviewed-on: https://chromium-review.googlesource.com/836409Reviewed-by:
-
