- 09 Apr, 2014 40 commits
-
-
yfriedman@chromium.org authored
ContentViewRenderView's usage of ContentView is historical. Everything just forwards to ContentViewCore. Cleaning this up, allows further distinction between the two. Some misc changes in TabUtils.java to appease presubmit. BUG=360664 Use CVC as appropriate in content shell Review URL: https://codereview.chromium.org/227803004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262838 0039d316-1c4b-4281-b951-d872f2087c98
-
piman@chromium.org authored
- fixes ui::Layer::SetTextureMailbox to not be hard-coded for software frames. - adds a ui::Layer::SetTextureSize to update the size without sending a new mailbox (since it doesn't change). - entirely removes ui::Layer::SetExternalTexture and ui::Texture, and derived classes. - significantly changes the ReflectorImpl implementation: * an OwnedMailbox is created on the main thread, using the shared main thread context. * the mailbox is passed to the impl thread, that creates a texture out of it with the OutputSurface context, and does operations on that. * the mailbox is passed to the layer. * if the OutputSurface is recreated (assuming, after a lost context), the OwnedMailbox is recreated, and passed to the impl side again, together with the new surface. * the OwnedMailbox takes care of deleting the texture, whether because of a lost context, or when the ReflectorImpl is shut down. BUG=333408 R=danakj@chromium.org, oshima@chromium.org, sky@chromium.org Review URL: https://codereview.chromium.org/228083002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262836 0039d316-1c4b-4281-b951-d872f2087c98
-
spang@chromium.org authored
We already do this in the non-udev case, and X11 does this as well. We only want the evdev devices, which are named /dev/input/eventN. BUG=none TEST=content_shell --ozone-platform=test Review URL: https://codereview.chromium.org/230883005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262830 0039d316-1c4b-4281-b951-d872f2087c98
-
hamaji@chromium.org authored
Also now we always use WriteToStderr and move comments to appropriate positions. TEST=trybots BUG=359285 Review URL: https://codereview.chromium.org/231423002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262829 0039d316-1c4b-4281-b951-d872f2087c98
-
xhwang@chromium.org authored
This CL relands r262568 with NO additional changes. The original CL was reverted to help investigate some test failure, which turned out to be unrelated to this CL. Android MediaDrm API supports container mime type check in isCryptoSchemeSupported (UUID uuid, String mimeType): http://developer.android.com/reference/android/media/MediaDrm.html#isCryptoSchemeSupported(java.util.UUID, java.lang.String) This CL hook this API up in MediaDrmBridge. Also, Chromium will always query the codec/container type it is interested in (e.g. MP4 and WebM). TBR=ddorwin@chromium.org,qinmin@chromium.org,dmazzoni@chromium.org BUG=350481 Review URL: https://codereview.chromium.org/230843004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262828 0039d316-1c4b-4281-b951-d872f2087c98
-
tapted@chromium.org authored
BUG=361359 TBR=wolenetz@chromium.org Review URL: https://codereview.chromium.org/231123004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262827 0039d316-1c4b-4281-b951-d872f2087c98
-
noms@chromium.org authored
BUG=NONE TEST=Existing unit tests. Review URL: https://codereview.chromium.org/229163004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262826 0039d316-1c4b-4281-b951-d872f2087c98
-
dyen@chromium.org authored
BUG= https://code.google.com/p/nativeclient/issues/detail?id=3816 TEST= trybots Review URL: https://codereview.chromium.org/229283003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262825 0039d316-1c4b-4281-b951-d872f2087c98
-
mpearson@chromium.org authored
In OmniboxEditModel::OpenMatch, the difference between popup_model->selected_index() and index is confusing. This change removes references to the former from within that function. BUG= Review URL: https://codereview.chromium.org/229583002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262824 0039d316-1c4b-4281-b951-d872f2087c98
-
tdresser@chromium.org authored
BUG=361685 TEST=TouchDispositionFilterTest.ConsumedScrollUpdateMakesFlingScrollEnd Review URL: https://codereview.chromium.org/231333003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262823 0039d316-1c4b-4281-b951-d872f2087c98
-
mfomitchev@chromium.org authored
The flicker was introduced in https://codereview.chromium.org/217373003/ Sometimes the overlay would get dismissed based on the paint event from the previous page which happens just before the navigation. This CL addressed the problem by ensuring a. The navigation is initiated before the overlay starts listening to events. b. We keep track of the pending id of the loading page and the paiting page. BUG=357751 Review URL: https://codereview.chromium.org/224253002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262822 0039d316-1c4b-4281-b951-d872f2087c98
-
sbc@chromium.org authored
R=binji@chromium.org Review URL: https://codereview.chromium.org/225293010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262821 0039d316-1c4b-4281-b951-d872f2087c98
-
rmcilroy@chromium.org authored
BUG=354405,346626 Review URL: https://codereview.chromium.org/229653003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262820 0039d316-1c4b-4281-b951-d872f2087c98
-
vrk@chromium.org authored
> Implement a source for remote video tracks. > MediaStreamRemoteVideoSource implements the MediaStreamVideoSource interface > for video tracks received on a PeerConnection. The purpose of the class is > to make sure there is no difference between a video track where the source is > a local source and a video track where the source is a remote video track. > > BUG=334243 > > Review URL: https://codereview.chromium.org/201583003 This caused remote video to appear unexpectedly zoomed and cropped. BUG=334243,361770 TBR=perkj@chromium.org Review URL: https://codereview.chromium.org/231963002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262819 0039d316-1c4b-4281-b951-d872f2087c98
-
noms@chromium.org authored
Broken in the sense that it no longer gets shown :) BUG=NONE TEST=With --new-profile-management enabled, create a new profile, and press the "Not X" button. The user manager should show up, and it should display a tutorial. Review URL: https://codereview.chromium.org/229333002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262818 0039d316-1c4b-4281-b951-d872f2087c98
-
davidben@chromium.org authored
Specifically counts only the first CertVerifer job in order to capture any initialization costs. BUG=361166 Review URL: https://codereview.chromium.org/225583009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262816 0039d316-1c4b-4281-b951-d872f2087c98
-
maruel@chromium.org authored
osmesa.so is now a required dependency for this test to pass. R=danakj@chromium.org BUG=361362 Review URL: https://codereview.chromium.org/227673004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262815 0039d316-1c4b-4281-b951-d872f2087c98
-
karen@chromium.org authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262813 0039d316-1c4b-4281-b951-d872f2087c98
-
rbyers@chromium.org authored
With the blink fixes for layer squashing in in https://src.chromium.org/viewvc/blink?view=rev&revision=171103, there's no longer any reason to disable cc touch hit testing when squashing is enabled. BUG=336560 Review URL: https://codereview.chromium.org/224803003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262810 0039d316-1c4b-4281-b951-d872f2087c98
-
vmpstr@chromium.org authored
This patch fixes IsHigherPriorityThan to return correct values. It also adds a unittest. R=enne Review URL: https://codereview.chromium.org/230983004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262809 0039d316-1c4b-4281-b951-d872f2087c98
-
alemate@chromium.org authored
This CL allows displaying to user and selection of country-specific language codes for which we do not have actual translation. A base language locale will be used instead. BUG=357481 TEST=browsertest To test manually: 1) Set VPD value of initial_locale to country-specific language codes, for which only the translation to base language exist. For example: "fr-CH,it-CH,de-CH" 2) Start OOBE and check they are displayed and selectable like any other languages. Review URL: https://codereview.chromium.org/224093013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262808 0039d316-1c4b-4281-b951-d872f2087c98
-
tdresser@chromium.org authored
This is required for Aura to use ui::GestureProvider. BUG=360790 TEST=GestureProviderTest.{GestureBeginAndEnd, GestureTapTap, ...} Review URL: https://codereview.chromium.org/227743007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262807 0039d316-1c4b-4281-b951-d872f2087c98
-
sdefresne@chromium.org authored
The warning -Wshorten-64-to-32 is automatically enabled by Xcode 5.1 when building for 64-bit architecture. Disable when the generator is Xcode, not ninja. BUG=359107 Review URL: https://codereview.chromium.org/231023002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262805 0039d316-1c4b-4281-b951-d872f2087c98
-
guohui@chromium.org authored
See mock at slide 19 https://docs.google.com/a/google.com/presentation/d/1UMAexroivw01osOXpnEqbQcE3FMyDkc9eZoIszm4DP4/edit#slide=id.g12716c62f_012 BUG=345075 Review URL: https://codereview.chromium.org/225963004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262804 0039d316-1c4b-4281-b951-d872f2087c98
-
viettrungluu@chromium.org authored
Don't enable the DCHECK, since it blows things up. Note that this doesn't actually fix the bug. Also fix RemoteMessagePipeTest.Multiplex, which is actually currently broken[3]. (Though one might think that MessagePipe's destructor would detect the missing Close()s, one would be wrong: Without closing, the reference cycle wouldn't get broken (by design[4]), so nothing gets destroyed. Oops.) [1] Currently, usually (always?) one side will leak. The problem is that we (only) detach on receiving a kSubtypeMessagePipePeerClosed control message. But then we won't send one of our own.[2] [2] The solution is probably to send an ack for these messages, and detach on receiving the ack instead. This is tricky since you have to handle the case when both sides simultaneously send the peer-closed control message. [3] That is, when this bug is fixed and the DCHECK enabled, the test would still blow up. [4] Possibly a bad design. R=sky@chromium.org BUG=360081 Review URL: https://codereview.chromium.org/231483002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262803 0039d316-1c4b-4281-b951-d872f2087c98
-
erikchen@chromium.org authored
This is in preparation for bringing the bookmark undo manager to ios. BUG=NONE Review URL: https://codereview.chromium.org/230003002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262802 0039d316-1c4b-4281-b951-d872f2087c98
-
avi@chromium.org authored
BUG=304341 TEST=modal dialogs still work R=dmazzoni@chromium.org, nasko@chromium.org Review URL: https://codereview.chromium.org/231213002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262801 0039d316-1c4b-4281-b951-d872f2087c98
-
kalman@chromium.org authored
a crash which might be caused by this. BUG=360461 R=rdevlin.cronin@chromium.org Review URL: https://codereview.chromium.org/230503005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262800 0039d316-1c4b-4281-b951-d872f2087c98
-
hfung@chromium.org authored
BUG=278442 Review URL: https://codereview.chromium.org/217573003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262799 0039d316-1c4b-4281-b951-d872f2087c98
-
nasko@chromium.org authored
--site-per-process This test checks how we combine renderers across processes. --site-per-process does not allow combining renderers from different SiteInstances, so this test is not expected to work properly. BUG= Review URL: https://codereview.chromium.org/230883003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262798 0039d316-1c4b-4281-b951-d872f2087c98
-
cmumford@chromium.org authored
When the transaction timeout expires Timeout is called, which in turn calls Abort(). Making the test a friend so that Timeout can be called makes this a more realistic test. Also checking for correct diagnostic values. BUG= Review URL: https://codereview.chromium.org/228843002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262797 0039d316-1c4b-4281-b951-d872f2087c98
-
miu@chromium.org authored
This change not only adds audio playback, but also adds an implementation that delays rendering of video/audio frames to the desired playout_times. In addition, console logging has been added to expose: 1) Whether frames were skipped because playback was running behind; 2) Whether frames were skipped by the receiver because packets were too late; 3) When frames are actually being played versus the desired playout_time. BUG=360776 R=imcheng@chromium.org Review URL: https://codereview.chromium.org/229463002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262796 0039d316-1c4b-4281-b951-d872f2087c98
-
mithro@mithis.com authored
When "linux_use_gold_binary" is set, we now use gold from third_party/binutils rather than third_party/gold (allowing us to remove third_party/gold dependency). As third_party/binutils is 2.24, this also satisfies the binutils version requirements for Debug Fission. Thus, when building with clang on Ubuntu Precise it should now be enabled. This should cause a significant speedup in linking for most chrome developers on Linux. Requires; * https://codereview.chromium.org/209853003/ - Adding binutils as a DEPS to allow DebugFission on Ubuntu Precise when compiling with clang. BUG=352046 Review URL: https://codereview.chromium.org/196573022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262794 0039d316-1c4b-4281-b951-d872f2087c98
-
ahernandez.miralles@gmail.com authored
BUG=275039 NOTRY=true Review URL: https://codereview.chromium.org/228723005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262792 0039d316-1c4b-4281-b951-d872f2087c98
-
wfh@chromium.org authored
This binary includes recent changes to pdb_source_line_writer for emitting STACK CFI lines for 64bit PDBs. This was built using the GYP build files, MSVS 2013 and DIA SDK 12.0. NOTRY=true BUG=none R=mark@chromium.org TBR=mark@chromium.org Review URL: https://codereview.chromium.org/229293004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262791 0039d316-1c4b-4281-b951-d872f2087c98
-
rsadam@chromium.org authored
Limits the range of touch fuzzing on the virtual keyboard. This prevents typing on the right margins form triggering keyevents. BUG=361131 Review URL: https://codereview.chromium.org/230993003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262789 0039d316-1c4b-4281-b951-d872f2087c98
-
miu@chromium.org authored
The solution is to simply to call setNeedsDisplay:YES whenever the subviews are swapped in/out of the TabContentsContainerView. BUG=361424 Review URL: https://codereview.chromium.org/229743004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262788 0039d316-1c4b-4281-b951-d872f2087c98
-
agl@chromium.org authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262787 0039d316-1c4b-4281-b951-d872f2087c98
-
rsesek@chromium.org authored
BUG=358713 R=jln@chromium.org, thakis@chromium.org Review URL: https://codereview.chromium.org/197213015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262786 0039d316-1c4b-4281-b951-d872f2087c98
-
andrewhayden@chromium.org authored
BUG= Review URL: https://codereview.chromium.org/227703004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262785 0039d316-1c4b-4281-b951-d872f2087c98
-