GitLab

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/46541b4996f2..3ade6e121416

$ git log 46541b499..3ade6e121 --date=short --no-merges --format='%ad %ae %s'
2018-02-15 alemate Override temporary directory before spawning subprocess.

Created with:
  roll-dep src/third_party/depot_tools


The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=agable@chromium.org

Change-Id: Ic6c37717aba6df5ece34cb9983b37f21eec01144
Reviewed-on: https://chromium-review.googlesource.com/923381
Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#537175}

and SafeBrowsingMsg_GetThreatDOMDetails to use mojo.

- Remove SafeBrowsingHostMsg_ThreatDOMDetails,
SafeBrowsingHostMsg_ThreatDOMDetails_Node and
SafeBrowsingMsg_GetThreatDOMDetails from
//components/safe_browsing/common/safebrowsing_messages.h.

- Implement a corresponding interface and struct in
safe_browsing.mojom

- Update /safe_browsing/renderer/threat_dom_details.h/cc and
/safe_browsing/browser/threat_details.h/cc + unittests
to use mojo

- Add provides/requires as needed to
aw_renderer_manifest_overlay.json and
chrome_content_renderer_manifest_overlay.json

- Add DEPS rules to allow components/safe_browsing to include
"services/service_manager/public/cpp"

Change-Id: I27baf7c2ac5bae2afa116b4314f5db8f9eac579d
Reviewed-on: https://chromium-review.googlesource.com/899405Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Varun Khaneja <vakh@chromium.org>
Reviewed-by: Sam McNally <sammc@chromium.org>
Reviewed-by: Chris Watkins <watk@chromium.org>
Commit-Queue: Eve Martin-Jones <evem@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537174}

This is a short term fix until child-allocated LocalSurfaceIDs are implemented
for auto-resize.

Prior to surface synchronization, child renderers would allocate LocalSurfaceIds
for auto-resize. When the renderer receives a DidReceiveCompositorFrameAck
message then it knows the compositor has received the frame, and informs the
browser process which then resizes the associated aura window to match the
frame generated by the child. This ensured that the aura window would only be
resized to a size that had a surface.

With surface synchronization, every auto-resize resulted in a request for a
LocalSurfaceId from the parent. The parent would immediately resize the aura
window and embed the newly allocated LocalSurfaceId and then tell the child
about it. In the meantime, the child may auto-resize again. Surface
synchronization would block the parent on that LocalSurfaceId
that never resolves until the child makes another request. After the deadline
passes, the user sees flicker.

This CL does not address the root cause of the problem (allocating IDs for
surfaces that are never created), but it does significantly reduce the problem.

Instead of immediately informing the browser when an auto-resize happens in the
renderer. The ACK is posted as a task on the renderer's queue. The renderer may
auto-resize multiple times until that task is handled, and so we effectively
coalesce resize requests before making a request to the browser.

This significantly reduces flicker.

This is not the final state of auto-resize, though. In the future, the renderer
will immediately allocate a LocalSurfaceId and submit a CompositorFrame, and
then tell the browser about it to embed it. Occasionally, there will be a
conflict between browser and renderer changes, but this should be very rare.

Bug: 812127, 811181, 672962
Change-Id: I08839c4b498b68ba06bb5d818337738e191cf9be
Reviewed-on: https://chromium-review.googlesource.com/920341
Commit-Queue: Fady Samuel <fsamuel@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537173}

Bug: 773295
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo;master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I4a49df1ef8e84953b0945ed133b17e2272dc8b14
Reviewed-on: https://chromium-review.googlesource.com/823222Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537172}

BUG=none
TEST=none
TBR=dcheng

Change-Id: I1393d84231c1693756cb571661ff0d1fda5259da
Reviewed-on: https://chromium-review.googlesource.com/923401
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537171}

There's only one such bot in the Swarming pool so this is necessary to
prevent webgl2_conformance_tests' shards from timing out.

NOTRY=true
TBR=jmadill@chromium.org, ynovikov@chromium.org

Bug: 764803
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I9b65abf59136238ec89ce3ec2294e4449921b1b9
Reviewed-on: https://chromium-review.googlesource.com/923415
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537170}

Bug: 805814
Change-Id: I58df2b83b9caa6bd049e14cdfae67e259eb3bba5
Reviewed-on: https://chromium-review.googlesource.com/921341Reviewed-by: Gabriel Charette <gab@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537169}

Blink relies on //build/config/compiler configs for the symbol level
selection. "full_symbols" is not a valid config, it was renamed to
"symbols". This patch updates the Blink build to use that.

R=chrishtr@chromium.org

Change-Id: I0187a3192a6c931062fd752e61dc298043150d37
Reviewed-on: https://chromium-review.googlesource.com/923104Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: vmpstr <vmpstr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537168}

The mock is at: goo.gl/kGgEVr

TBR=cpu@chromium.org

Bug: 811619
Change-Id: I1b3c773bae64031e47a9e7ab2aee65da9bb0c2f0
Reviewed-on: https://chromium-review.googlesource.com/922399
Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537167}

Each WebApplication sends the supported audio codecs to its
CastContentRendererClient using Mojo.

Bug: internal b/73180315
Test: cast to Chromecast
Change-Id: I405f2765ede611ed81488f78bca7bb9b2734f769
Reviewed-on: https://chromium-review.googlesource.com/910711
Commit-Queue: James West <jameswest@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Stephen Lanham <slan@chromium.org>
Reviewed-by: Luke Halliwell <halliwell@chromium.org>
Reviewed-by: Kenneth MacKay <kmackay@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537166}

Bug: 782025
Change-Id: I144d650ff86af288a22afbc4173c94de46da4faf
Reviewed-on: https://chromium-review.googlesource.com/834749
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537165}

Bug: 769401
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I5d6f976b69e0c5191ec275a0f8eb7c4d0f6bc34a
Reviewed-on: https://chromium-review.googlesource.com/896554Reviewed-by: David Roger <droger@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537164}

Several spellcheck classes hold a LocalInterfaceProvider pointer,
which is always non-null in production code, but can be null in unit
tests. This makes the production code performing unnecessary nullptr
checks and doing hacky things.

This patch adds a dummy LocalInterfaceProvider that doesn't bind any
remote application, and uses it in test code, so that spellcheck
production code no longer needs to perform nullptr checks.

Bug: 714480
Change-Id: I30a9c82efd4298a62bda52d357fcfa9a6c6d991b
Reviewed-on: https://chromium-review.googlesource.com/910650
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537163}

Change-Id: Icae0663f2df7b84dd207dc040d820c9c4bf057b2
Reviewed-on: https://chromium-review.googlesource.com/916732
Commit-Queue: Evan Stade <estade@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537162}

Add new feature flag disable_idle_socket_close_on_memory_pressure. If
the flag is turned on, cast_shell won't close idle sockets when memory
pressure happens.

BUG=786585, internal b/73351220, internal b/73495670
TEST=Lauch cast_shell with enable-features=disable_... and watch logs

Change-Id: I5aa22a20103624c3114bc8de34412a9ace0dfa29
Reviewed-on: https://chromium-review.googlesource.com/922902Reviewed-by: Sergey Volk <servolk@chromium.org>
Commit-Queue: Yuchen Liu <yucliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537161}

spec: https://mccanny.users.x20web.corp.google.com/www/splitscreen-motion/index.html

The attached spec wants phantom windows to animate out from the "Drag window here"
indicators. This changes phantom windows from being a separate widget to being part
of the same widget which controls the splitview text. This will allow the animations
in the spec to happen.

The phantom windows are now part of those highlights which are part of the splitview
text. When an item reaches the phantom threshold, the highlight will expand and the
text will disappear. There is some difficult getting the phantom windows to have
rounded corners like they should, but the old ones did not either, so I think it is
ok for now.

The highlights and text layers have their transform and opacity altered rather than
using SetBounds or SetVisible so it will be easier to animate in a follow up cl.

Manually tested using all orientations and multiple divider positions.

Test: ash_unittests SplitViewWindowSelectorTest.*
Bug: 808283
Change-Id: I4b61e5dce394ac05abd4038aee3a07067727f625
Reviewed-on: https://chromium-review.googlesource.com/898247Reviewed-by: Mitsuru Oshima (In Tokyo) <oshima@chromium.org>
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537160}

BUG=none
TEST=none

Change-Id: I038b815518a6b27dcdb4e303edec4c02fcde9072
Reviewed-on: https://chromium-review.googlesource.com/923095Reviewed-by: Michael Wasserman <msw@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537159}

So far flakes only observed on win7.

No-Try: true

Bug: 812941
Change-Id: I4ffdb918bcded59a4d760bd3deb563c3adc61ce6
Reviewed-on: https://chromium-review.googlesource.com/922896Reviewed-by: Chrome Cunningham <chcunningham@chromium.org>
Reviewed-by: Takeshi Yoshino <tyoshino@chromium.org>
Commit-Queue: Chrome Cunningham <chcunningham@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537158}

Increases the timeout of VR tests running on Nougat to 30 minutes (from
16). The number of tests has grown to the point where 16 minutes can
end up being flaky. The number should go back down eventually once WebVR
is completely replaced by WebXR, but that's still a ways off.

Bug: 812306
Change-Id: Ia3b74c8f11c524b3b01121e8842e1051692efce0
Reviewed-on: https://chromium-review.googlesource.com/920661
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537157}

Increase max of UKM.Entries.SerializedCount to a larger value. Start tracking #entries dropped from sampling

Bug: 0
Change-Id: I08ddba346f8f8347840462d46a45166d9d33c14f
Reviewed-on: https://chromium-review.googlesource.com/922781
Commit-Queue: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537156}

They're running 10.12, not 10.10 as I thought.

NOTRY=true
TBR=jmadill@chromium.org, ynovikov@chromium.org

Bug: 764803
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Ibbe5f33ee540ff8f471932ad0753b7b1f9ee0214
Reviewed-on: https://chromium-review.googlesource.com/923411
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537155}

Historically, the on-disk Cookie DB has required unique creation time across
all cookies, which is not a restriction classes higher in the stack have
or enforce.  This CL shifts the unique constraint over to (name, domain, path),
which is supported by the spec.

Bug: 800414
Change-Id: I8ab14f2a2cf81257ef51a34aca78a80f1886e356
Reviewed-on: https://chromium-review.googlesource.com/906675
Commit-Queue: Randy Smith <rdsmith@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Reviewed-by: Helen Li <xunjieli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537154}

We should delay completing a resource request until all data has
been received. Before this CL, we completed a request immediately after
the response header comes in. To delay completing requests this CL
introduces ServiceWorkerSubresourceLoader::StreamWaiter, which is
similar to ServiceWorkerURLLoaderJob::StreamWaiter. It completes
a request after OnCompleted() callback is called (or OnAborted() is
called).

This CL also fixes some typos.

Bug: 778110
Change-Id: I6f3292eeb483b83e74f0d0be1df8b5e555e8c8f5
Reviewed-on: https://chromium-review.googlesource.com/920045
Commit-Queue: Kenichi Ishibashi <bashi@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537153}

Bug: 762667
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Iebf2bf6bc2adf62e723013602f92f3451aed8038
Reviewed-on: https://chromium-review.googlesource.com/920203Reviewed-by: Tatsuhisa Yamaguchi <yamaguchi@chromium.org>
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537152}

This change is built off of https://crrev.com/c/887858 which added basic
verification to user-selected PPD files in order to provide them with
more immediate feedback when they select an invalid file. This change is
simply adding an error message that is displayed to the user.

Here are some screenshots of what this change looks like in the UI:

  - invalid PPD (https://screenshot.googleplex.com/YKH4CPFTJpV.png)
  - valid PPD (https://screenshot.googleplex.com/ube7K8v9QtT.png)

R=dpapad@chromium.org, xdai@chromium.org

Bug: 778462,806915
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I6992a594cbf0c086e136c32814b8070724b1ed71
Reviewed-on: https://chromium-review.googlesource.com/898432Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Commit-Queue: David Valleau <valleau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537151}

Bug: 810911
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I97693b9e6cb628ef98b7fca20f7c0d17defc0749
Reviewed-on: https://chromium-review.googlesource.com/919664Reviewed-by: Danyao Wang <danyao@chromium.org>
Commit-Queue: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537150}

We used to pass through html and body style recalc twice for viewport
style propagation. When we moved to propagating such styles to after the
style recalc, the viewport style is not up-to-date right after body style
is calculated and overlay scrollbar theming did not update correctly.
Instead move the theme update to PropagateStyleToViewport after style is
set on LayoutView.

Bug: 811725
Change-Id: If51c580b7162f512377eecb48d85ca71bd5e7628
Reviewed-on: https://chromium-review.googlesource.com/921801Reviewed-by: Steve Kobes <skobes@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537149}

This is a preflight commit for switching AppList calls into mojo
interfaces. Since we'll have AppListModel in ash, we want to make sure
chrome tests are using FakeAppListModelUpdater. Specifically, this
commit:

- renames ChromeAppListModelUpdaterDelegate to AppListModelUpdaterDelegate;
- puts more shared interfaces into AppListModelUpdater so that we can
  switch between ChromeAppListModelUpdater and FakeAppListModelUpdater
  in more cases;
- overrides with a FakeAppListModelUpdater in tests;
- fixes previous typo "preffer" -> "prefer".

Bug: 733662
Change-Id: I0dec61341ae5cee772ae07afaed3e43fa4a52fbb
Reviewed-on: https://chromium-review.googlesource.com/917003
Commit-Queue: Jiaquan He <hejq@google.com>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537148}

changes:
This CL includes Is{Set}VirtualKeyboardEnabled and
Is{Set}StickKeysEnabled.

Bug: 594887
Test: device test, observing tray accessibility updates.
Change-Id: I6a790bd883969e0c457361ab29260210fb4db43a
Reviewed-on: https://chromium-review.googlesource.com/912514
Commit-Queue: Qiang Xu <warx@google.com>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537147}

To optimize baselines properly, rebaseline-cl needs mac10.13_blink_rel
in its try bot set, because mac10.13 is the only port whose baseline
search path begins with "platform/mac".  If BaselineOptimizer doesn't
see a baseline in platform/mac, it will consolidate matching baselines
from other Mac ports under platform/mac-mac10.12, and fail to merge them
with matching baselines in platform/win into the generic path.

Bug: 812784, 774301
Change-Id: Ifda7a0051bed79a044ab516b40c0795242247b46
Reviewed-on: https://chromium-review.googlesource.com/922791
Commit-Queue: Steve Kobes <skobes@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Quinten Yearsley <qyearsley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537146}

Adds a affordance for keyboard users to open PDFs for accessibility.

Bug: 737787, 800399
Change-Id: Ifc234ab950357a512818ae0875fa6c156bc2ba1e
Reviewed-on: https://chromium-review.googlesource.com/922681Reviewed-by: Anthony LaForge <laforge@chromium.org>
Commit-Queue: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537145}

This change fixes lifetime issues where the mojo service, created with
mojo::MakeStrongBinding, stayed alive after the Profile, AppCache
service, and things like the URLRequestContext have been destroyed.

This is a little scary, as the AppCacheDispatcherHost and general
AppCache code holds lots of raw pointers, and I'm sure this was the
cause of other strange bugs.

Prior to r522566 (when IPCs were converted to Mojo), the dispatcher
object was owned by the RenderProcessHostImpl, and created during
message filter creation. The filters were explicitly destroyed,
which made the lifetime deterministic.

Bug: 800391
Change-Id: Ie56839de3202be5c63080cf31e7a1391eb7ce405
Reviewed-on: https://chromium-review.googlesource.com/922919Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Commit-Queue: Daniel Murphy <dmurph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537144}

This re-introduces the fast path implemented in PLC::FrameViewDidScroll.

Test coverage: all layout tests which use main-thread scrolling of a
composited layer (e.g. using window.scrollBy or gestures on scrollbars).

Bug: 770343
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I93a43072d19871611fa8845758410b094d67a8f7
Reviewed-on: https://chromium-review.googlesource.com/923089Reviewed-by: Steve Kobes <skobes@chromium.org>
Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537143}

CreateNotificationBridgeLinux() used to take 5 arguments, and if the caller
wanted to change just one of them from the default, they would have to
redundantly supply the defaults for the other 4.  This CL makes
CreateNotificationBridgeLinux() take a structure instead.

R=thestig
BUG=None

Change-Id: I04c3dfedc9e4bac5d869adf3138bc24750254fb1
Reviewed-on: https://chromium-review.googlesource.com/923219
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537142}

GetNativeWidgetForNativeWindow() will later interrogate the NSWindow
delegate, but we can't trust that delegate to be a valid object.

Bug: 788271
Change-Id: Icc6b9b3738c553ec66f28c4154ad9d4a12581216
Reviewed-on: https://chromium-review.googlesource.com/920564Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537141}

Instant Tethering only uses BLE connections. This filter was not
previously used due to a potential workaround which had been resolved
(see https://crbug.com/759090).

Bug: 759091, 672263
Change-Id: I161efd638f683d21596e445a5f1db2f90a838e75
Reviewed-on: https://chromium-review.googlesource.com/919426Reviewed-by: Rahul Chaturvedi <rkc@chromium.org>
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537140}

The modern tab buttons was at the top of the tab switcher. Moved them to
the bottom and make the tab button indicator appear on the top.

Bug: 803090
Change-Id: I1eedd513b0acc63657719ff4f67aeaddb7f2e202
Reviewed-on: https://chromium-review.googlesource.com/907316
Commit-Queue: Becky Zhou <huayinz@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537139}

This is a first pass at GridCell. Icon, title, close button, and
the snapshot were added. Styling is already pretty close but will
require more tweaking. A showcase entry displays various uses of this
cell including different sizes and dark/light themes.

This approach attempts to solve for dark variants without the need to
subclass.

Bug: 804526
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I5bbeb5d8adb5ee93e6941d77bcac2b481569da74
Reviewed-on: https://chromium-review.googlesource.com/920627
Commit-Queue: edchin <edchin@chromium.org>
Reviewed-by: edchin <edchin@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537138}

Unless GPU process launching with real GPU already has crashed enough times.

BUG=812406
TEST=GpuProcess telemetry test (newly added)
R=piman@chromium.org

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Ic07d7007e39705dbd2b9c9391072b6626062c843
Reviewed-on: https://chromium-review.googlesource.com/920501
Commit-Queue: Zhenyao Mo <zmo@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537137}

An accessor that was missed when the first round of string accessors
were implemented. Follows the same pattern as all other accessors.

BUG=792783

Change-Id: Ida6967a152c565b44d32d928156801d13ed13a42
Reviewed-on: https://chromium-review.googlesource.com/920042
Commit-Queue: Meredith Lane <meredithl@google.com>
Reviewed-by: Alice Boxhall <aboxhall@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537136}