- 28 Nov, 2017 40 commits
-
-
Dan Zhang authored
The old way of initialize QuicStreamSequencerBuffer::block_count_ may assign it to 2049 instead of 2048 (16MB / 8KB = 2k). This cl fix this bug and also make the condition check of a QUIC_BUG to check this value correctly. R=rch@chromium.org Merge internal change: 164489401, 174343515 Bug: Change-Id: Iaadc4084c470277d0f0882d75b4a61539c780aad Reviewed-on: https://chromium-review.googlesource.com/793977Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Dan Zhang <danzh@chromium.org> Cr-Commit-Position: refs/heads/master@{#519814}
-
David Tseng authored
- some Android apps require focusable nodes have either focus or makeVisible actions performed on them for some UI to show up (e.g. Assistant) - ChromeVox, as a result, needs to observe more containers. For focusable nodes, ChromeVox will not typically descend into their descendants unless the node's role is explicitly known to be a container. In Android, this is mostly nodes with role 'list'. their contents shown Navigate in other apps with many focusable containers e.g. Play Store. Verify navigation continues into descendants. Test: navigate in Assistant. Verify that invisible listItem nodes have Bug: 788650 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I3a6b512b3d133f6bae9e89dd11488229c0fe4660 Reviewed-on: https://chromium-review.googlesource.com/792098Reviewed-by:
Yuki Awano <yawano@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#519813}
-
Will Chen authored
TBR=luoe@chromium.org Bug: 789225 Change-Id: I1453c23aa6ccd1c5db9b96423e8e5d9061bc412f Reviewed-on: https://chromium-review.googlesource.com/794393 Commit-Queue: Will Chen <chenwilliam@chromium.org> Reviewed-by:
Will Chen <chenwilliam@chromium.org> Cr-Commit-Position: refs/heads/master@{#519812}
-
Kurt Horimoto authored
This CL adds ChromeBroadcastObserverBridge, which allows C++ objects to register as observers for broadcasted UI state. Bug: 785663 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I5ee8ffdfd2173a8a57b16e0e2ad9d1634dcbd4ea Reviewed-on: https://chromium-review.googlesource.com/780810 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#519811}
-
Aleksei Seren authored
Shutdown histograms were not properly written because of several issues: 1) There is an incorrect calculation of current open browsers which have not yet started to close. This leads to the fact that browser_shutdown::OnShutdownStarting() is not called in case of several browsers shutdown. 2) During the closure of the browser we are trying to find if there is any background Chrome applications with help of KeepAliveRegistry::IsKeepingAlive() function call, which is actually tracking running Browsers also (i.e. it can return true even if there is no background application). So it is needed to introduce new function to track background applications only. R=sky@chromium.org BUG=707147 BUG=707144 Change-Id: If4f7c080965c95e2c0b810817e94a09f3a52ba51 Reviewed-on: https://chromium-review.googlesource.com/760356 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Nicolas Dossou-Gbété <dgn@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#519810}
-
Reid Kleckner authored
These bots are timing out near the end of the build. Our theory is that LTCG is slowing down the link steps. There are probably other official MSVC builders out there, but we are probably the only ones seeing these timeouts because we configure out bots to build *all* test targets, not just chromium_builder_tests or chrome. While I'm here, completely rewrite the configs used by the MSVC bots on the clang waterfall. This has the side effect of enabling DCHECKs on the 32-bit shared+release bot to make it consistent with the 64-bit bot. I don't think the inconsistency was intentional. R=dpranke@chromium.org, hans@chromium.org Change-Id: Ia54a297714f4217e9614616ac2c2dafd8fbdfc5e Reviewed-on: https://chromium-review.googlesource.com/794311 Commit-Queue: Reid Kleckner <rnk@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#519809}
-
sebsg authored
Bug: 789059 Change-Id: I60aee9281d367fe8df545fef59ad920462d10a87 Reviewed-on: https://chromium-review.googlesource.com/794095Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#519808}
-
Robert Sesek authored
ee84ce22bb89 fuchsia: Set kOS in MinidumpMiscInfoDebugBuildString 1020a6147d3d fuchsia: Use crashpad_info section matching Linux/Android for now 050d111bf986 fuchsia: Set METRICS_OS_NAME 4ee20f583191 Add Fuchsia clang and sdk to DEPS 0d05b0d59e19 fuchsia: Use RandBytes UUID generator af28b83eb7b6 In Annotation::SetSize, use AnnotationList::Register rather than Get Bug: 598854 Change-Id: Iccbc85ad93f03385bf0b4623f48046050f424062 Reviewed-on: https://chromium-review.googlesource.com/794036Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#519807}
-
angle-deps-roller@chromium.org authored
https://chromium.googlesource.com/angle/angle.git/+log/df68ca50b310..5201ce127afe $ git log df68ca50b..5201ce127 --date=short --no-merges --format='%ad %ae %s' 2017-11-28 geofflang Fix MSVC 2015 warnings. Created with: roll-dep src/third_party/angle The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=jmadill@chromium.org Change-Id: Ie1fefe6b20ff809f01d80640ad082a99474755a5 Reviewed-on: https://chromium-review.googlesource.com/794291Reviewed-by:
angle-deps-roller . <angle-deps-roller@chromium.org> Commit-Queue: angle-deps-roller . <angle-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#519806}
-
Scott Little authored
TBR=anthonyvd@chromium.org Bug: 789214 Change-Id: Ifb45f9ae00bd60ee377402aae2c7066bd114cae8 Reviewed-on: https://chromium-review.googlesource.com/794337Reviewed-by:
Scott Little <sclittle@chromium.org> Commit-Queue: Scott Little <sclittle@chromium.org> Cr-Commit-Position: refs/heads/master@{#519805}
-
Dominik Röttsches authored
SimpleFontData was abused for carrying flags for canvas rotation in the painting stage, specifically in ShapeResultBloberizer. Internally, SimpleFontData was carrying a is_text_orientation_fallback_ flag representing whether this font was used for upright in vertical, and thus triggering reversing the vertical text rotation canvas operation in ShapeResultBloberizer. In this CL, we remove this magic, make the canvas rotation explicit and store it outside of SimpleFontData. This removes a critical blocker in unifying FontPlatformData and SimpleFontData. It also helps clean up the blurry semantics of SimpleFontData. Bug: 506224 Change-Id: I1356fe8454feeeb26a648d78e19dfc69537628fa Reviewed-on: https://chromium-review.googlesource.com/790510 Commit-Queue: Dominik Röttsches <drott@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Florin Malita <fmalita@chromium.org> Cr-Commit-Position: refs/heads/master@{#519804}
-
Mohamad Ahmadi authored
Bug: 785429 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I23c008943b60e89b9b58265cdad3293b3dda2bb5 Reviewed-on: https://chromium-review.googlesource.com/793983Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#519803}
-
David Trainor authored
We were previously trimming the string with the wrong prefix, which meant that querying the Cpu brand from /proc/cpuinfo could be wrong if the string matched "Processor\t: ". We would use "model name\t: " length to trim instead of the correct "Processor\t: " length. BUG=788934 Change-Id: I1cc99e6c64ca89b25f53c51624db40cdafe24a6b Reviewed-on: https://chromium-review.googlesource.com/791998Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#519802}
-
Lei Zhang authored
Change-Id: I1ca7920be4c0b2e5888d30239d733244b498f800 Reviewed-on: https://chromium-review.googlesource.com/786634 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#519801}
-
kapishnikov authored
BUG=787148 Change-Id: I3b8de35f8179f6f45679d75ef210b9ec8500dab2 Reviewed-on: https://chromium-review.googlesource.com/794070 Commit-Queue: Andrei Kapishnikov <kapishnikov@chromium.org> Reviewed-by:
Helen Li <xunjieli@chromium.org> Cr-Commit-Position: refs/heads/master@{#519800}
-
Sammie Quon authored
Test: browser_tests CrSettingsPeoplePageQuickUnlockAuthenticateTest.* Bug: 786930 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I658551a326421e94933b071ddc218979b7d8de86 Reviewed-on: https://chromium-review.googlesource.com/792096Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#519799}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/12b69eedeed5..0f8e4dbd28d1 $ git log 12b69eede..0f8e4dbd2 --date=short --no-merges --format='%ad %ae %s' 2017-11-28 rmistry Make RecreateSKPs bot fail if capturing SKPs fails + exclude failing page sets 2017-11-28 benjaminwagner Upgrade GalaxyS6. 2017-11-28 mtklein remove clip-bounds query overrides from SkColorSpaceXformCanvas 2017-11-28 angle-deps-roller Roll skia/third_party/externals/angle2/ 0b684ce3c..df68ca50b (1 commit) Created with: roll-dep src/third_party/skia BUG=781238 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=allanmac@chromium.org Change-Id: Id2a7286132925b14aae4d1358ddb0b1c32ad01e0 Reviewed-on: https://chromium-review.googlesource.com/794019Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#519798}
-
Myung-jong Kim authored
Bug: 706285 Change-Id: I21524ca6076351b4fd056443add699dbad62841b Reviewed-on: https://chromium-review.googlesource.com/789734Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#519797}
-
Ovidio Henriquez authored
This change updates the connect-disconnect-twice.html test to use the Web Bluetooth Test interface. This will help us migrate the test to the wpt/ directory, since testRunner is not going to be used anymore. BUG=509038 Change-Id: I612742525eb7299e4014ac65df569d338485345d Reviewed-on: https://chromium-review.googlesource.com/786632Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Vincent Scheib <scheib@chromium.org> Reviewed-by:
Conley Owens <cco3@chromium.org> Commit-Queue: Ovidio Henriquez <odejesush@google.com> Cr-Commit-Position: refs/heads/master@{#519796}
-
Eugene But authored
This CL adds kNewPassKitDownload and kNewFileDownload flags usage to the web layer. Turning on kNewPassKitDownload flag will disable CRWPassKitDownloader and webController:didLoadPassKitObject: callback. Turning on kNewFileDownload will disable controllerForUnhandledContentAtURL: callback. Turning either of these flags on will add a logic, which discards pending item if that item is download. Both flags are turned off by default and there is no way to enable them via chrome://flags yet. This CL slightly changes the code inside WKNavigationDelegate's webView:decidePolicyForNavigationResponse:decisionHandler: as follows: - CRWPassKitDownloader download is moved behind |!allowNavigation| - allowNavigation is not set to no if MIME type is PassKit These are non functional changes because if MIME type is PassKit, then |allowNavigation| is always NO. Bug: 780646 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I948ae3e1f38d266eda8aa7b99900900d8c02fef3 Reviewed-on: https://chromium-review.googlesource.com/783671 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by:
Gregory Chatzinoff <gchatz@chromium.org> Cr-Commit-Position: refs/heads/master@{#519795}
-
Shanfeng Zhang authored
Before this change, we know how many people submit with an invalid card. With this change, we know whether the invalid card is empty, has wrong size or does not pass Luhn check. Design doc: go/chrome-autofill-more-log Change-Id: I2a2be6a275564b73008b67d004679b349916707f Reviewed-on: https://chromium-review.googlesource.com/773484Reviewed-by:
Roger McFarlane <rogerm@chromium.org> Commit-Queue: Shanfeng Zhang <szhangcs@google.com> Cr-Commit-Position: refs/heads/master@{#519794}
-
Geoff Lang authored
BUG=602688 Change-Id: If13efb71c6d3c471c95aa2e5649e943dad25a9d7 Reviewed-on: https://chromium-review.googlesource.com/781800Reviewed-by:
Gayane Petrosyan <gayane@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org> Cr-Commit-Position: refs/heads/master@{#519793}
-
Devlin Cronin authored
Update ExtensionMsg_ExecuteCode_Params::run_at to be a bounded enum (extensions::UserScript::RunLocation) rather than an unbounded integer. Bug: None Change-Id: I6be743cde03e07c6665c71ed11c4302016f3b3e2 Reviewed-on: https://chromium-review.googlesource.com/792294Reviewed-by:
Tom Sepez <tsepez@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#519792}
-
catapult-deps-roller@chromium.org authored
https://chromium.googlesource.com/catapult.git/+log/230a61040fc8..65711d3e974c $ git log 230a61040..65711d3e9 --date=short --no-merges --format='%ad %ae %s' 2017-11-28 simonhatch Dashboard - Swallow all exceptions for /add_histograms 2017-11-22 dproy Fix long_running_tasks_mapper Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I53273399d8388e34dacfb8783333430d604ff4bf Reviewed-on: https://chromium-review.googlesource.com/794013 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#519791}
-
Nicolas Pena authored
This CL adds a test to make sure that there are no paint entries when a sibling frame paints an image. Bug: 736114 Change-Id: Ie65dc1f3aea6d67f690164ba9007950eba7a5c6d Reviewed-on: https://chromium-review.googlesource.com/769929 Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Cr-Commit-Position: refs/heads/master@{#519790}
-
Lei Tian authored
ResourcesCompat and ApiCompatibilityUtils cannot get drawable corrrectly for vector drawable on pre-L devices. AppCompatResources has problem to get LayerDrawable and AnimationDrawable. By combing them together, it will have a good coverage for different types of drawable on different os. Bug: 775798 Change-Id: Id6e407260323bd1c43ea301c9952bc49725dd066 Reviewed-on: https://chromium-review.googlesource.com/792129 Commit-Queue: Lei Tian <ltian@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#519789}
-
Alex Clarke authored
We had a report of truncation for posts over 4k. Add some tests and fix one possible cause of truncation (multiple UploadElementReaders). Bug: Change-Id: I7b5c67ee56db435f5e3901c283533111e97f50a0 Reviewed-on: https://chromium-review.googlesource.com/793836 Commit-Queue: Alex Clarke <alexclarke@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#519788}
-
Koji Ishii authored
Following bot results are included. 2270 2272 2276 2277 2278 2282 2286 2289 2290 4 lines were removed by consecutive passes since 2263. TBR=eae@chromium.org NOTRY=true Bug: 591099 Change-Id: I546459c02fb6f08c37d7759b8427b2b1a90406db Reviewed-on: https://chromium-review.googlesource.com/793492Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#519787}
-
Sorin Jianu authored
The change to use task scheduler in update_client has incorrectly made some of the update_client::ActionRunner code run on the UI thread, therefore, the unpacker code is asserting that IO is not allowed. See change https://chromium-review.googlesource.com/c/chromium/src/+/770050 Bug: 740992 Change-Id: I27a7ce650a1bf06ba76aac913d741c9adf5f6424 Reviewed-on: https://chromium-review.googlesource.com/792333Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#519786}
-
Adam Langley authored
jyasskin notes in [1] that the CTAP rules for sorting map entries are slightly different than the suggestions in the RFC. This change highlights that difference in the comment. Additionally, by using StringPiece, some copies can be eliminated. [1] https://chromium-review.googlesource.com/716573 Change-Id: Ida2687dde4036058613cb060e738fd9484deae02 Bug: None Reviewed-on: https://chromium-review.googlesource.com/775473 Commit-Queue: Adam Langley <agl@chromium.org> Reviewed-by:
Jeffrey Yasskin <jyasskin@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#519785}
-
liberato@chromium.org authored
8k video could cause LayoutUnit to saturate multiplication when computing the correct aspect ratio. This CL does the calculation in floating point, instead. Bug: 728303 Test: LayoutSizeTest Change-Id: I632777e2f140b8203577b3e5e0761f3e7f891aa2 Reviewed-on: https://chromium-review.googlesource.com/773108Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#519784}
-
Roger McFarlane authored
This CL makes Chrome treat a field with autocomplete=false the same as one with autocomplete=off, instread of treating autocomplete=false as an unrecognized/unsupported type identifier. Bug: 789193 Change-Id: I80b4690e904b549775a0f055fa7f5df13d519e14 Reviewed-on: https://chromium-review.googlesource.com/794034 Commit-Queue: Roger McFarlane <rogerm@chromium.org> Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#519783}
-
Min Qin authored
The values are not set correctly, causing some tests to fail BUG=789081 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I9619e747ba87f376bddbd3bf9b5275e495d74fe0 Reviewed-on: https://chromium-review.googlesource.com/794012Reviewed-by:
Xing Liu <xingliu@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#519782}
-
Hajime Hoshi authored
As the number of callers is not big, let's not use default arguments for code health. Another motivation of this CL is that we (people working on schedulers) would like to do our local experiment to investigate task runner usages: we plan to add an argument base::Location to TTRH::Get() and collect the data on our local machine. Replacing TTRH::Get() with e.g. TTRH::Get(FROM_HERE) would not be simple without this CL since we can't compile default arguments' arguments. Change-Id: I305cc3def1f24035ceb303019e35dcc0fa2b849e Reviewed-on: https://chromium-review.googlesource.com/792318Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#519781}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/e1591d9c..834c8ace Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: Ic45ddcabdc77de9fb9973c2f2fc409d2a0f9d1ce Reviewed-on: https://chromium-review.googlesource.com/793953Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#519780}
-
Fredrik Söderquist authored
Since <line> elements are just a two point line segment, it does not have any line joins and thus needn't apply any correction for the miter. Bug: 435097, 788340 Change-Id: Ie7e9d89e0f7c741cf7cf40b3af82521869bb5b54 Reviewed-on: https://chromium-review.googlesource.com/790294Reviewed-by:
Florin Malita <fmalita@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#519779}
-
Kurt Horimoto authored
StopLoading() discards non-committed items, meaning that a refresh for a pending load would reload the previous page rather than retrying the pending load. Bug: 787795 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I186fdd847d7a738dec6cb62125ff83c491a3ae72 Reviewed-on: https://chromium-review.googlesource.com/794014Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#519778}
-
Robert Ma authored
Some methods are not currently supported by common.checkout.git, and Git.run is used in such cases for now. Later we would like to port some of them (the reusable ones) to common.checkout.git. Bug: 676399 Change-Id: I42459221c684f8ffeabb9991a64dea3489663d19 Reviewed-on: https://chromium-review.googlesource.com/793984Reviewed-by:
Quinten Yearsley <qyearsley@chromium.org> Commit-Queue: Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#519777}
-
Tom Sepez authored
Turns out its still doing some FS access via stat() and readlink(). TBR=piman@chromium.org Change-Id: I927f55eaec732bcf600d3f43a135f2680d9b424f Reviewed-on: https://chromium-review.googlesource.com/792296Reviewed-by:
Tom Sepez <tsepez@chromium.org> Commit-Queue: Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#519776}
-
Tom Sepez authored
Change-Id: I96707a3d692c0065f5ab9f87e7265df14b5e82de Reviewed-on: https://chromium-review.googlesource.com/786095Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#519775}
-