GitLab

Move the following classes to components/browser_ui/widget/
 - FeatureHighlightProvider
 - InsetObserverView
 - MenuOrKeyboardActionController

BUG=951455,1010176

Change-Id: I7eac449f45b52f243fea468554b2a9f6c4868d32
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040002
Commit-Queue: Theresa  <twellington@chromium.org>
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#738708}

This reverts commit f8a4ba13.

Reason for revert:
GN modifications broke components_background_task_scheduler_junit_tests

Original change's description:
> Background task scheduler : Split code into public and internal
> 
> This CL separates the public interfaces from the internal code of background
> task scheduler's Java code.
> 
> 1 - The public classes/interfaces are left at top level components/background_task_scheduler
>     while the implementation code is moved to internal/
> 2 - Internal code is moved to a separate package as well.
> 3 - The factory will be a separate target that depends on public and internal.
> 4 - Some classes need to be referenced from both chrome/ and internal code,
>   e.g. BackgroundTaskSchedulerFactory, Uma classes, SharedPref. To handle this,
>   have two classes, e.g. BackgroundTaskSchedulerFactory and BackgroundTaskSchedulerFactoryInternal
> 
> We should probably move the NativeBackgroundTask as well to components/ which
> will greatly help the dependent code to live in components/. Will think about it in a future CL.
> 
> Bug: 1045765
> Change-Id: Idddb3ed33789a735e920f33b7c0f3cb40e5e844a
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2021857
> Commit-Queue: Shakti Sahu <shaktisahu@chromium.org>
> Reviewed-by: David Trainor <dtrainor@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#738560}

TBR=nyquist@chromium.org,dtrainor@chromium.org,shaktisahu@chromium.org

Change-Id: I33c04539e01afae186023e7e011842994d8589ec
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1045765
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040373Reviewed-by: Peter Kotwicz <pkotwicz@chromium.org>
Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#738707}

Bug: 1034915
Change-Id: Ida5008f8292c1f885c18ead46a04d3c456857674
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031025
Auto-Submit: Marc Treib <treib@chromium.org>
Commit-Queue: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#738706}

Bug: 946001
Change-Id: I9131bb30d774cd38d169cb92d41fd357cdf0d71c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040000
Auto-Submit: Gary Kacmarcik <garykac@chromium.org>
Reviewed-by: Jamie Walch <jamiewalch@chromium.org>
Commit-Queue: Jamie Walch <jamiewalch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#738705}

Some users are reporting that badging stops working after several days
of leaving the app open. We do not have steps to repro, so I'm
speculating that it's caused by the mojo connection failing. To test
this, I'm going to create a new connection each time we set the badge.

If the issue continues to be seen after this CL lands, it can be
reverted.

Bug: 1048880
Change-Id: Idbcca7be2d08ed8011f05351482705af8f0fea92
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035521Reviewed-by: Alan Cutter <alancutter@chromium.org>
Commit-Queue: Jay Harris <harrisjay@chromium.org>
Cr-Commit-Position: refs/heads/master@{#738704}

Bug: 984869
Change-Id: I1376a7ca637041c4d71bea60c6354b6a63054958
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2038810
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#738703}

This reverts commit e6780b7e.

Reason for revert: seems to be breaking "browser_tests" on "linux-chromeos-chrome"

Original change's description:
> Add browser tests for Reader Mode omnibox icon.
> 
> Bug: 992074
> Change-Id: I2b54639a15222d2c30cf419c606b62ebd28597e1
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951893
> Commit-Queue: Katie Dektar <katie@chromium.org>
> Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
> Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#738661}

TBR=ellyjones@chromium.org,dmazzoni@chromium.org,katie@chromium.org,gilmanmh@google.com

Change-Id: I96214b491da480cd85f809ddb451c48f8a358ba2
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 992074, 1049350
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040069Reviewed-by: Carlos Knippschild <carlosk@chromium.org>
Commit-Queue: Carlos Knippschild <carlosk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#738702}

Was set to ENABLED_BY_DEFAULT in
https://chromium-review.googlesource.com/c/chromium/src/+/2017911

Change-Id: Ib93f62d678007d38043b59575cb9ee73f80f84d9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036355
Commit-Queue: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#738701}

Picks up a minor change to stop using a to-be-deprecated Skia API

Change-Id: I842ca9ddf7ff818f0ec975eb9f87ff2e461f7371
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040192
Commit-Queue: Brian Osman <brianosman@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
Cr-Commit-Position: refs/heads/master@{#738700}

Using the "max presentation time" concept we can greatly simplify the
"once" animation-policy by essentially letting it define a limited
window of the timeline in which the animation will be active. This
allows us to drop the associated timer and other doodads, leaving just a
fairly simple method that is called whenever the container's
presentation time is reset.

There is a small change in behavior in that the container is no longer
explicitly paused, but rather just halted after 3 seconds.

Replace the layout test with a set of unittests.

Bug: 998526
Change-Id: I2aaa927198bc7918b5767381753a5334ebcd115d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2030969Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#738699}

Remove Uses of Microsoft::WRL::ComPtr<T>::GetAddressOf() in //chrome/services/util_win/util_win_impl.cc

Microsoft::WRL::ComPtr<T>::GetAddressOf() is banned due to the ease
of causing memory leaks.

BUG=914910
TBR=pmonette@chromium.org

Change-Id: Ib7f6b2a03ead757f5b7d3897c2eb788104cc15db
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040004Reviewed-by: Robert Liao <robliao@chromium.org>
Reviewed-by: Patrick Monette <pmonette@chromium.org>
Commit-Queue: Robert Liao <robliao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#738698}

- Setup prefetch notification service, factory and client code.

Bug: 1047037
Change-Id: Iccc82d8b49f63213294eb0440fc59138db756912
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2029293
Commit-Queue: Hesen Zhang <hesen@chromium.org>
Auto-Submit: Hesen Zhang <hesen@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Xing Liu <xingliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#738697}

Since Tango is being shut down & feature "Cloud Policy over FCM" is
being enabled:
* Enabled on ToT (M81)
* Enabled 100% on Finch experiment starting from M78

Bug: 1048214
Change-Id: Ie69bf1b89d2b9c4496479374b310eae9394be1fa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035880
Commit-Queue: Askar Aitzhan <askaraitzhan@google.com>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#738696}

Bug: b:148080975
Change-Id: Iaaca31713f62f0b0ea50e77dfdc2c0e2863273f3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037815
Commit-Queue: David Black <dmblack@google.com>
Reviewed-by: Tao Wu <wutao@chromium.org>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#738695}

Bug: 783819
Change-Id: Ib1970a41bb45a31907ea91358fd27bee6c6b20a7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2039301Reviewed-by: Bo <boliu@chromium.org>
Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#738694}

Add OverscrollActionCloseTab user action.
Mark MobileTabClosed as not_user_triggered.

This will help to better distinguish different ways
of closing the tab.

Bug: 1046223
Change-Id: I58ce36f51bb39f4d52e75633c2c6840ce4283b2e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032405
Auto-Submit: Eugene But <eugenebut@chromium.org>
Commit-Queue: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#738693}

Bug: 1049135
Change-Id: I7e06123068b09643e9063f2df9bb04ff1b8b2884
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2039133
Commit-Queue: Sam Maier <smaier@chromium.org>
Auto-Submit: Sam Maier <smaier@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#738692}

This CL simply sets up the finch flag for OOP-R canvas.
This flag flips the bits required for OOP-R when creating the context.

Bug: 1023277
Change-Id: Ic5da502ba1eaf8c01a308d1f88ec17a07e31f625
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036521Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Khushal <khushalsagar@chromium.org>
Commit-Queue: Jonah Chin <jochin@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#738691}

This is in preparation for autogenerating tests for the Polymer 3
version of settings-subpage.

Bug: 1026426
Change-Id: I32b119cf18f8b7f7f1053621a81e10f65ffcbc8f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2038491Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#738690}

TBR=govind@chromium.org

Change-Id: Ic425480d4269f08467fffd442b891153e6039ce7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2039296Reviewed-by: Ben Mason <benmason@chromium.org>
Reviewed-by: Krishna Govind <govind@chromium.org>
Commit-Queue: Krishna Govind <govind@chromium.org>
Cr-Commit-Position: refs/heads/master@{#738689}

This CL updates the Global Media Controls dialog to use 7 as the
minimum contrast ratio between the foreground and background colors
instead of using the default of 4.5.

Bug: 1049242
Change-Id: I81538040993cdd555cd1e6173554b9021018d18e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2039894
Commit-Queue: Tommy Steimel <steimel@chromium.org>
Reviewed-by: Becca Hughes <beccahughes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#738688}

Invalidations are needed for throttling when a frame's
cross-origin-to-main status changes (see https://crrev.com/451041 and

be set from javascript by modifying document.domain. We issue throttling
invalidations on the frame that changes origin, but missed the case when
a main frame origin change causes subframes to become
non-cross-origin-to-main. This patch invalidates all descendant frames
when the main frame's origin changes.

LocalFrameView: :UpdateRenderThrottlingStatus). The origin of a frame can
Change-Id: Ibd6b99f6666deb4f583f37cad9cfd2a823ea749e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036269Reviewed-by: Stefan Zager <szager@chromium.org>
Commit-Queue: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#738687}

- This patch added command line to write the minidump to log
- and enable it by default for WebView.

Bug: 979082
Change-Id: I9dd7fc282261356ec6d26b030333c0e86e92ea93
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037083Reviewed-by: Joshua Peraza <jperaza@chromium.org>
Reviewed-by: Mark Mentovai <mark@chromium.org>
Commit-Queue: Tao Bai <michaelbai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#738686}

The Baseline Content-Alignment feature is not implmemented yet, so the
tests realated to that feature should be skipped.

Additionally, the 'last baseline' keyword is marked as risk, so it's
not implemented yet; the related tests should be skipped as well.

Bug: 1047575
Change-Id: If9754ff23c111560398a37e0dd3da3f97c5fbd7b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2039191Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Commit-Queue: Javier Fernandez <jfernandez@igalia.com>
Cr-Commit-Position: refs/heads/master@{#738685}

This change makes two improvements to the distributed ThinLTO scripts:
 1. When no code generation is necessary, invokes the local linker
    correctly even when --gomacc or --jobs options are specified.
 2. Change create_file to ensure_file to only create files if they
    do not already exist, reducing unnecessary rebuilding.

R=gbiv,hans,rnk,thakis
BUG=877722

Change-Id: I29ffa028202c31f77df95d306432f726e3f7bda9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2039996
Auto-Submit: Bob Haarman <inglorion@chromium.org>
Reviewed-by: George Burgess <gbiv@chromium.org>
Commit-Queue: George Burgess <gbiv@chromium.org>
Cr-Commit-Position: refs/heads/master@{#738684}

iOS current writes out full_results.json, but moving forward the
Chromium recipe expects an output.json file. We write the same
contents of full_results.json to output.json such that the Chromium
recipe can collect_task and run the noop_merge merge script.

Changes to the content of output.json will be required for utilizing
the standard gtest merge script.

Bug: 1031338
Change-Id: Ifff558d37618afeb371944693a6b76a4be46547d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032809Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Commit-Queue: Jeff Yoon <jeffyoon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#738683}

By the time the GPU info collection is requested, the GPU vendor id
and device id should be available. Something must be wrong if the
device id is 0. In this case, no need to collect GPU info.

This CL also renames the info collection GPU process from
GPU_PROCESS_KIND_UNSANDBOXED_NO_GL to
GPU_PROCESS_KIND_INFO_COLLECTION

Bug: 896565
Change-Id: I00e1a70448f337f148ae7ad4f016d2308c284fba
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036940
Commit-Queue: Maggie Chen <magchen@chromium.org>
Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#738682}

So the name better matches the actual use.

Merge-With: eureka-internal/360190

Bug: none
Change-Id: Icad7d7496a67e6af96f72ccc73e41e0c2d68d935
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2039295Reviewed-by: Yuchen Liu <yucliu@chromium.org>
Commit-Queue: Kenneth MacKay <kmackay@chromium.org>
Cr-Commit-Position: refs/heads/master@{#738681}

Makes CircleHighlightPathGenerator use RoundedRect. Tested manually and
the highlights/ripples/focus rings look the same, minus the previous
extra renderpass.

Test: manual
Bug: 1042303
Change-Id: Ib2010b4b8ba9838bfee9f9d6eb696bb6fffb843f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037849
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Reviewed-by: Peter Boström <pbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#738680}

trybot_commit_size_checker.py now specifies if a metric delta is a large
improvment (greater than the limit, in the opposite direction). A
boolean is set on the binary size gerrit plugin json object for each
metric if it is a large improvement. This allows the plugin to showcase
those differently on the CL page.

Bug: 921090
Change-Id: I0b809835289f8af9046d477826abdd7d7d9a7387
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037958Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Mohamed Heikal <mheikal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#738679}

Change-Id: Iedce6a403777db230dcd959725f21c6cce2c0a41
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2039891
Commit-Queue: Herb Derby <herb@google.com>
Commit-Queue: Khushal <khushalsagar@chromium.org>
Auto-Submit: Herb Derby <herb@google.com>
Reviewed-by: Khushal <khushalsagar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#738678}

Modifying the set returned by SharedPreferences#getStringSet() is
forbidden by the API, but nothing stops the developer from doing so.
It can cause consistency issues resulting in loss of data.

Change-Id: I84907d4c4475d2a97974a6b57e16c50a411d915c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2039811
Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
Reviewed-by: Boris Sazonov <bsazonov@chromium.org>
Reviewed-by: Natalie Chouinard <chouinard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#738677}

This fixes a bug where some of the logging from the audio process is not
forwarded to chrome://media-internals.

Fixed: 1049114
Change-Id: I958e47557ba9b6bdc9c9d3e8352994bc140ffb3c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037677
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Commit-Queue: Ken Rockot <rockot@google.com>
Auto-Submit: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Ken Rockot <rockot@google.com>
Cr-Commit-Position: refs/heads/master@{#738676}

This verifies that the JSON which gets produced with the sampled
frames, matches the format that the internal processing pipelines
expect.

R=ssid@chromium.org,etienneb@chromium.org
BUG=1046918

Change-Id: Iaa4e853fe44f8ea16ac81410383413c55cbfbd6a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031941
Commit-Queue: oysteine <oysteine@chromium.org>
Reviewed-by: ssid <ssid@chromium.org>
Cr-Commit-Position: refs/heads/master@{#738675}

Fixed: 945966
Change-Id: I7f89e5a9df35cd615f7bd30d5725d7e3ac773801
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035951Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#738674}

Remove OAuth2LoginVerifier and make the OAuth2LoginManager observe
AccountReconcilor instead of doing /MergeSession.

DD: http://doc/1fACI5GQgXvmlmEJj6aPedazXeDZAZPw9jH_E91WGe3w

Bug: 977137
Change-Id: Iaa21dd12f0ca6568d920f135bbfdddf3f9def088
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674099Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: David Roger <droger@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Kush Sinha <sinhak@chromium.org>
Commit-Queue: Anastasiia Nikolaienko <anastasiian@chromium.org>
Cr-Commit-Position: refs/heads/master@{#738673}

This CL finishes off the componentization of
//chrome/browser/captive_portal by putting the componentized files in
the captive_portal namespace. The CL additionally removes all
now-unnecessary references to the captive_portal namespace from within
these files.

Bug: 1030692
Change-Id: Ia9bb3498413aa95cdd6eeb2a652061e6dbca6b11
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2038778
Commit-Queue: Colin Blundell <blundell@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#738672}

The Apps Foundation team is implementing metrics for measuring success
and OKR progress. This metric measures whether an app that is
uninstalled was within 7 days of having been installed. A new histogram
was created to track this metric.

BUG=1044710
REVIEWERS:
    bcwhite: please review histograms.xml

Change-Id: I030dfc65835118e2ba15480ad779db64d304e272
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035501Reviewed-by: Brian White <bcwhite@chromium.org>
Reviewed-by: Nancy Wang <nancylingwang@chromium.org>
Commit-Queue: Alex Linker <ajlinker@chromium.org>
Cr-Commit-Position: refs/heads/master@{#738671}

This reverts commit 3599b7a3.

Reason for revert: Incorrectly reverted...see https://bugs.chromium.org/p/chromium/issues/detail?id=1012527#c9

Original change's description:
> Revert "Reland "Call MFShutdown in places where MFStartup is called""
> 
> This reverts commit 5019665f.
> 
> Reason for revert: broke capture_unittests on chromeos-amd64-generic-rel per http://crbug.com/1048934
> 
> Original change's description:
> > Reland "Call MFShutdown in places where MFStartup is called"
> > 
> > This reverts commit 5be12bf8.
> > 
> > Reason for revert: Fixing the issue, and running on more trybots
> > 
> > Original change's description:
> > > Revert "Call MFShutdown in places where MFStartup is called"
> > > 
> > > This reverts commit abf9a1f5.
> > > 
> > > Reason for revert: Broke tests on Win7 dbg, see linked bug
> > > 
> > > Original change's description:
> > > > Call MFShutdown in places where MFStartup is called
> > > > 
> > > > Bug: 1012527
> > > > Fixed: 1012527
> > > > Change-Id: Id9ef248aadb0aa24704dec973b60ea23c9e1f1ed
> > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032332
> > > > Commit-Queue: Ted Meyer <tmathmeyer@chromium.org>
> > > > Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
> > > > Cr-Commit-Position: refs/heads/master@{#738063}
> > > 
> > > TBR=xhwang@chromium.org,tmathmeyer@chromium.org
> > > 
> > > Change-Id: I267213cc06b42769736c7eb337432ade7953de20
> > > No-Presubmit: true
> > > No-Tree-Checks: true
> > > No-Try: true
> > > Bug: 1012527
> > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036057
> > > Reviewed-by: Marc Treib <treib@chromium.org>
> > > Commit-Queue: Marc Treib <treib@chromium.org>
> > > Cr-Commit-Position: refs/heads/master@{#738130}
> > 
> > TBR=xhwang@chromium.org,treib@chromium.org,tmathmeyer@chromium.org
> > 
> > Change-Id: I8f87e933e133d0dcbf9904c002af7738af450f41
> > No-Presubmit: true
> > No-Tree-Checks: true
> > No-Try: true
> > Bug: 1012527
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037811
> > Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
> > Commit-Queue: Ted Meyer <tmathmeyer@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#738344}
> 
> TBR=xhwang@chromium.org,treib@chromium.org,tmathmeyer@chromium.org
> 
> Change-Id: Ieba1f172a5a2bed58e338f15c638c6deae8b0685
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 1012527, 1048934
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037855
> Reviewed-by: Kenneth Russell <kbr@chromium.org>
> Commit-Queue: Kenneth Russell <kbr@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#738410}

TBR=xhwang@chromium.org,kbr@chromium.org,treib@chromium.org,tmathmeyer@chromium.org

Change-Id: I6ca750208e811eeda8acd9c6f57924a9cb57f04d
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1012527, 1048934
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040191Reviewed-by: Ted Meyer <tmathmeyer@chromium.org>
Commit-Queue: Ted Meyer <tmathmeyer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#738670}

BUG=chromium:878390

Change-Id: I0a5dd1e09f42a0332fd107cdecb677d499d4cef6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020769
Auto-Submit: Ross McIlroy <rmcilroy@chromium.org>
Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#738669}