GitLab

Aura uses the views BalloonCollectionImpl, so this rewrites the test to use the generic BalloonCollection interface.

The test still fails, but will work when chromeos::SystemNotification is implemented on Aura.

BUG=104471
TEST=browser_tests

Review URL: http://codereview.chromium.org/8576010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110441 0039d316-1c4b-4281-b951-d872f2087c98

This time with unittest.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/8591005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110440 0039d316-1c4b-4281-b951-d872f2087c98

r1093: Default to make generator on FreeBSD9 and 10 as well.

BUG=None


Review URL: http://codereview.chromium.org/8588008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110439 0039d316-1c4b-4281-b951-d872f2087c98

Files under webkit/media/ are now under their very own webkit_media namespace.

Review URL: http://codereview.chromium.org/8570010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110438 0039d316-1c4b-4281-b951-d872f2087c98

BUG=97845
TEST=none


Review URL: http://codereview.chromium.org/8450018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110437 0039d316-1c4b-4281-b951-d872f2087c98

This allows the use of e.g.:

WeakHandle<T> weak_handle = MakeWeakHandle(WeakPtr<U>());

as long as U is convertible to T, instead of:

WeakHandle<T> weak_handle = WeakHandle<T>(WeakPtr<U>());

Fix all callers.

BUG=
TEST=


Review URL: http://codereview.chromium.org/8568041

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110436 0039d316-1c4b-4281-b951-d872f2087c98

This CL is part of a larger effort to replace opencryptoki as the PKCS #11 layer in Chrome OS.  In this first phase, libchaps.so forwards requests to a daemon (chapsd) which loads opencryptoki to service the requests.  You can find the Chaps design doc here: https://docs.google.com/a/google.com/document/d/1TQFc6GABKa1JgwUx2hIcxAHQ329fkd03yYlGxhfHQlQ/edit

Change-Id: I42962c4703413039641b6ede40caaf0c97ab900e

BUG=chromium-os:21005
TEST=* Ensure previously existing certs still exist.
     * Import new cert and private key from PKCS12 file.


Review URL: http://codereview.chromium.org/8527006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110435 0039d316-1c4b-4281-b951-d872f2087c98

Set the clipboard text initially rather than using
whatever happened to be in the clipboard at the time
of the test.

BUG=none
TEST=Copy some non-ASCII text before running TextfieldViewsModelTest.Clipboard.
Then, run the test. It should not fail.

Review URL: http://codereview.chromium.org/8486024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110434 0039d316-1c4b-4281-b951-d872f2087c98

BUG=103999
TEST=included
Review URL: http://codereview.chromium.org/8572036

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110433 0039d316-1c4b-4281-b951-d872f2087c98

BUG=70829
TEST=tree gets greener
TBR=mpcomplete
Review URL: http://codereview.chromium.org/8585021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110432 0039d316-1c4b-4281-b951-d872f2087c98

BUG=104582
TEST=bots go green
TBR=japhet
Review URL: http://codereview.chromium.org/8588022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110431 0039d316-1c4b-4281-b951-d872f2087c98

BUG=104578
TEST=none

Review URL: http://codereview.chromium.org/8586018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110430 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110422 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
TBR=sky
Review URL: http://codereview.chromium.org/8566027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110420 0039d316-1c4b-4281-b951-d872f2087c98

Revert "Fix leak in X509UtilNSSTest VerifyCertificateSignature."

BUG=88782
TEST=none
TBR=cpu@chromium.org

Review URL: http://codereview.chromium.org/8587018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110419 0039d316-1c4b-4281-b951-d872f2087c98

Forgot to initialize the ScopedPLArenaPool, so the ASN1 functions were
leaking.

BUG=88782
TEST=memory bots
TBR=cpu@chromium.org

Review URL: http://codereview.chromium.org/8588015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110417 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110415 0039d316-1c4b-4281-b951-d872f2087c98

BUG=93825
TEST=none

Review URL: http://codereview.chromium.org/8520024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110414 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
TBR=steveblock
Review URL: http://codereview.chromium.org/8479053

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110413 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none


Review URL: http://codereview.chromium.org/8585008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110412 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:14439
TEST=None

Change-Id: Iab663c8eaeea198f9d3d74e8f5f069d678ae9429

Review URL: http://codereview.chromium.org/8513021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110411 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/8526015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110410 0039d316-1c4b-4281-b951-d872f2087c98

The motivation is to solve a dependency issue between UpgradeDetectorChromeos
and DBusThreadManager, that'll replace CrosLibrary (i.e. UpgradeDetectorChromeos
will be using DBusThreadManager internally).

BUG=16564
TEST=Upgrade detector works as before. (create a new image, start dev server, and run update_engine_client --update, and confirm that an arrow is shown on the wrench menu icon, once the update is downloaded in the background).

Review URL: http://codereview.chromium.org/8568020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110409 0039d316-1c4b-4281-b951-d872f2087c98

Also fix a possible data race issue.

Also convert NewRunnableMethod to base::Bind.

BUG=103901,87747
TEST=run chrome, then "echo hi | nc -U /tmp/.org.chromium.Chromium.FOO/SingletonSocket"


Review URL: http://codereview.chromium.org/8571019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110408 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=trybots, local cros/arm build of chrome succeeds.


Review URL: http://codereview.chromium.org/8537032

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110407 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none


Review URL: http://codereview.chromium.org/8570011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110406 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=less CrOS Valgrind errors.
Review URL: http://codereview.chromium.org/8587015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110405 0039d316-1c4b-4281-b951-d872f2087c98

Move ShowPageInfoBubble to browser_dialogs.h, nix page_info_window.h.
Add BubbleDelegateView::SizeToContents(), slight refactoring.
Add non-const location_icon_view(), make animation impls protected.

BUG=97248,98312,98323
TEST=Page info bubble has the same behavior/appearance.

Review URL: http://codereview.chromium.org/8508048

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110403 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none


Review URL: http://codereview.chromium.org/8573031

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110402 0039d316-1c4b-4281-b951-d872f2087c98

The new method cancels channel creation for pending channel. This 
prevents some potential crashes.


Review URL: http://codereview.chromium.org/8573013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110401 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=Manual

Review URL: http://codereview.chromium.org/8568038

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110400 0039d316-1c4b-4281-b951-d872f2087c98

BUG=104039
R=ben@chromium.org

Review URL: http://codereview.chromium.org/8581003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110399 0039d316-1c4b-4281-b951-d872f2087c98

BUG=101724
TEST=Preview a webpage. Click "Open PDF In Preview" option Observe that the pdf is displayed in native preview app. Complete the printing workflow by clicking "Print" or
"Cancel" button at the bottom of the preview app.

Review URL: http://codereview.chromium.org/8425008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110398 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none


Review URL: http://codereview.chromium.org/8520032

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110397 0039d316-1c4b-4281-b951-d872f2087c98

BUG=104478
TEST=Hit tab mulitple times, browser should not crash, focus should cycle through printing options.


Review URL: http://codereview.chromium.org/8578010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110396 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=compiles and ProcessSingletonTest passes.


Review URL: http://codereview.chromium.org/8574030

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110395 0039d316-1c4b-4281-b951-d872f2087c98

The last try broke at least 2 things which I've fixed in this CL:
- Attempts to access geolocation from an extension would hang.
- We'd sometimes crash when shutting down the browser with an ExtensionPopup
open.

BUG=84146
TEST=extensions still work

Review URL: http://codereview.chromium.org/8587001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110394 0039d316-1c4b-4281-b951-d872f2087c98

BUG=88782
TEST=X509UtilNSSTest


Review URL: http://codereview.chromium.org/8537025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110393 0039d316-1c4b-4281-b951-d872f2087c98

Data that's only pertinent to initially loading the document is stored in LoadTimes. These are carried over when the NavigationState changes due to in-document navigation.

I'd be interested in feedback on the position of LoadTimes. I'm not happy with it. I'd prefer to have it on WebDataSource, but I expect NavigationState was hidden in ExtraData for a reason.

This also impacts PLT histograms. In-document navigation is the cause of some of the missing start types. So, by fixing this, we should get more complete page load data. There are probably whole classes of sites where we have no PLT data, such as Google Docs.

BUG=79078
TEST=ui_tests


Review URL: http://codereview.chromium.org/8404018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110392 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
TBR=OWNERS

Review URL: http://codereview.chromium.org/8539001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110391 0039d316-1c4b-4281-b951-d872f2087c98