GitLab

BUG=372069

Review URL: https://codereview.chromium.org/280063002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269677 0039d316-1c4b-4281-b951-d872f2087c98

BUG=365966

Review URL: https://codereview.chromium.org/273953002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269676 0039d316-1c4b-4281-b951-d872f2087c98

Flush() already accomplishes pausing by releasing all data and not
reading until Preroll() is called.

BUG=110814

Review URL: https://codereview.chromium.org/271923002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269675 0039d316-1c4b-4281-b951-d872f2087c98

These are setup to have almost no cpu-time noise. There is
always only one frame source, and we either scroll 4 times
or wait for 10 seconds worth of frames.

Since these are jsbin pages, I've added a '?' label to give
the URL more meaning.

BUG=None

Review URL: https://codereview.chromium.org/250813002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269674 0039d316-1c4b-4281-b951-d872f2087c98

No functional changes yet, just preparation for splitting NaCl's fork
delegate into two different implementations.

BUG=364945

Review URL: https://codereview.chromium.org/269413004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269673 0039d316-1c4b-4281-b951-d872f2087c98

BUG=348531

Review URL: https://codereview.chromium.org/267703003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269672 0039d316-1c4b-4281-b951-d872f2087c98

BUG=349065

Review URL: https://codereview.chromium.org/233623002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269671 0039d316-1c4b-4281-b951-d872f2087c98

UMA for the data reduction proxy was gated behind preprocessor
directives that resticted the logic to Android and iOS. This
change opens UMA calculations and collection up to all platforms.

BUG=369619

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269026

Review URL: https://codereview.chromium.org/266033002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269670 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269669 0039d316-1c4b-4281-b951-d872f2087c98

Contains fixes for uniform structure packing and polygon offset.

Review URL: https://codereview.chromium.org/271173003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269668 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Android-side of insertion/selection handles visibility. (https://codereview.chromium.org/188023002/)

Reason for revert:
There are a number of cases where this incorrectly hides the selection/insertion
handles in an editable node.

Original issue's description:
> Android-side of insertion/selection handles visibility.
> 
> This patch relies on other two patches:
> https://codereview.chromium.org/177903010/
> https://codereview.chromium.org/186753002/
> to correctly compute the visibility of selection and
> insertion handles when editing text input, text area
> and contenteditable elements.
> 
> BUG=236033
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=258839

BUG=372056
TBR=tedchoc@chromium.org

Review URL: https://codereview.chromium.org/278923003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269667 0039d316-1c4b-4281-b951-d872f2087c98

This changes the ExtensionDownloader to attempt multiple
sequential queries for CRX downloads, iterating over incremental
values for the authuser query parameter up to a max of 10.

This is a re-landing of http://codereview.chromium.org/279453002/
which was reverted due to a use-after-free bug in the unit tests.

BUG=370964
R=asargent@chromium.org

Review URL: https://codereview.chromium.org/274263002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269666 0039d316-1c4b-4281-b951-d872f2087c98

These tests are pixel tests and are using GetFramebufferPixels which
will go away with CompositeAndReadback.

R=enne
BUG=251936

Review URL: https://codereview.chromium.org/280043002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269665 0039d316-1c4b-4281-b951-d872f2087c98

Call WebContentsDelegate::CanDragEnter from WebContentsViewAura. Allows applications using the Content API to selectively cancel (disallow) drag&drop operations on a per-WebContents basis. For example, applications may want to disable drag&drop completely or may want to disallow a drop based on the drag contents (only certain data types, URL formats, etc).

BUG=224440
TEST=none

Review URL: https://codereview.chromium.org/267113008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269664 0039d316-1c4b-4281-b951-d872f2087c98

Makes WaitingCallback cancel a wait if there is a wait pending and
it's deleted.
Makes MessagePumpMojo deal with MOJO_RESULT_CANCELLED.

BUG=371755
TEST=see bug
R=darin@chromium.org, mpcomplete@chromium.org

Review URL: https://codereview.chromium.org/276093002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269663 0039d316-1c4b-4281-b951-d872f2087c98

BUG=371223

Review URL: https://codereview.chromium.org/271173005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269662 0039d316-1c4b-4281-b951-d872f2087c98

 Unscaled image only contains 1.0f image and used when it is the client responsibility to scale the image properly (Wallpaper for example)

 This is required for https://codereview.chromium.org/263253003/

BUG=None
TEST=covered by unit test

Review URL: https://codereview.chromium.org/277773002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269660 0039d316-1c4b-4281-b951-d872f2087c98

Only supports POD-types and strings currently.

BUG=320091

Review URL: https://codereview.chromium.org/268363003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269659 0039d316-1c4b-4281-b951-d872f2087c98

Previously "NTP clicks" (i.e., navigations on NTP suggestions) use AUTO_BOOKMARK transition type. Eventually we want to create a new transition type, but right now AUTO_BOOKMARK ambiguates NTP clicks with bookmark usage.  To prevent this, this CL make NTP clicks for *server-side suggestions* a LINK transition type.  This partially reverts the changes for https://chromiumcodereview.appspot.com/178253008/ .

Important: NTP clicks for client-side recommendations (i.e., Most Visited) remains at AUTO_BOOKMARK, as to not interfere with existing behavior in chain start detection.

BUG=
NOTRY=true

Review URL: https://codereview.chromium.org/274143002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269658 0039d316-1c4b-4281-b951-d872f2087c98

Make sure the monitor does not collect the proxy's address if one was used.
(In the process, refactor RequestInfo to contain the whole HttpResponseInfo,
tighten up OnRequestLegComplete, and poke at unittests a bit.)

Also, count network errors as well as HTTP errors as failures (!).

BUG=356791

Review URL: https://codereview.chromium.org/267633002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269657 0039d316-1c4b-4281-b951-d872f2087c98

Suppress uninitialized reads in IPC::Channel::ChannelImpl::ProcessOutgoingMessages while we analyze them.

BUG=371991
TBR=zhaoqin@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/274193003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269656 0039d316-1c4b-4281-b951-d872f2087c98

Will be used by chromium_trybot_arm recipe.

R=mseaborn@chromium.org, phajdan.jr@chromium.org
BUG=359338

Review URL: https://codereview.chromium.org/246623009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269655 0039d316-1c4b-4281-b951-d872f2087c98

BUG=367366

Review URL: https://codereview.chromium.org/277083002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269654 0039d316-1c4b-4281-b951-d872f2087c98

To avoid stack allocation of Skia effects we made their constructors non-public
and provide factory methods instead. This patch updates the remaining uses of
the constructors in Chrome.

BUG=skia:2187

Review URL: https://codereview.chromium.org/271073002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269653 0039d316-1c4b-4281-b951-d872f2087c98

It was just an alias for chromium_builder_asan and it was removed from
the buildbot scripts at https://codereview.chromium.org/257903004 (
svn://svn.chromium.org/chrome/trunk/tools/build@266374)

BUG=None
TEST=green trybots
R=dpranke@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/270623002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269652 0039d316-1c4b-4281-b951-d872f2087c98

R=brettw@chromium.org
BUG=

Review URL: https://codereview.chromium.org/279623002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269651 0039d316-1c4b-4281-b951-d872f2087c98

The position returned from last_mouse_position() is in screen
co-ordinates but the calculation steps for the composition expect that
the cursor position be relative to the desktop dimentions.

This change transforms the screen relative position into a position
relative to the desktop window and hence relative to the secondary
display.

BUG=371761
TEST=Under ChromeOS capture a secondary screen and observe that the
pointer is now composed into the video steam in the correct place

Review URL: https://codereview.chromium.org/278873002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269650 0039d316-1c4b-4281-b951-d872f2087c98

BUG=371881

Review URL: https://codereview.chromium.org/273123002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269649 0039d316-1c4b-4281-b951-d872f2087c98

Remove NOTIFICATION_EXTENSION_UNLOADED_DEPRECATED from image_writer_private and signed_in_devices API.

Use ExtensionRegistryObserver instead.

R=kalman@chromium.org
BUG=354458

Review URL: https://codereview.chromium.org/263393002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269648 0039d316-1c4b-4281-b951-d872f2087c98

This code path is disable by default, and is also tested in GestureProviderTest.

The test suite is currently running into some memory leaks, see
http://build.chromium.org/p/chromium.memory.fyi/builders/Chromium%20OS%20%28valgrind%29%283%29/builds/32287/steps/memory%20test%3A%20aura/logs/stdio
for an example.

BUG=371990

NOTRY=true

Review URL: https://codereview.chromium.org/271283002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269647 0039d316-1c4b-4281-b951-d872f2087c98

Import C++11 headers for unordered map and set when using libc++ in protobuf's config header to avoid warnings.
    
BUG=366218
TBR=brettw

Review URL: https://codereview.chromium.org/246633012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269646 0039d316-1c4b-4281-b951-d872f2087c98

Other bookmarks observer might make their own changes on add, triggering updates
before the add call arrives. Be resilient against this.

BUG=369728

Review URL: https://codereview.chromium.org/277033002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269645 0039d316-1c4b-4281-b951-d872f2087c98

Chromium started to use glib to parse .desktop file:
https://codereview.chromium.org/7000018

However, use_glib is not added when use_ozone is defined,
which causes a build error.
https://codereview.chromium.org/249583003

BUG=none

Review URL: https://codereview.chromium.org/276673002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269644 0039d316-1c4b-4281-b951-d872f2087c98

BUG=362288

Review URL: https://codereview.chromium.org/270763002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269643 0039d316-1c4b-4281-b951-d872f2087c98

If tab capture is enabled, but the window that is being displayed is
occluded, then the quality of the broadcast may be negatively impacted
by throttling of its presentation.

To avoid this, disable throttling the presentation of the windows that
are occluded but may be being captured.

Do not disable throttling for non-occluded windows, because that will
result in the renderer overloading the browser, and frames being dropped
by the browser, resulting in unsmooth animation.

BUG=350410

Review URL: https://codereview.chromium.org/279523003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269642 0039d316-1c4b-4281-b951-d872f2087c98

BUG=361761
TEST=no visible change

Review URL: https://codereview.chromium.org/274883002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269641 0039d316-1c4b-4281-b951-d872f2087c98

This limits the address space used for discardable memory on MacOSX
by using the DiscardableMemoryManager for userspace eviction.

Includes some minor refactoring to keep all code using
DiscardableMemoryManager consistent.

BUG=369246

Review URL: https://codereview.chromium.org/261993003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269640 0039d316-1c4b-4281-b951-d872f2087c98

The tests affected are:
    PolicyTest.ExtensionInstallSources
    PrefsFunctionalTest.TestDownloadDirPref
    WebNavigationApiTest.Download

BUG=372017
R=bauerb@chromium.org
TBR=jam, joaodasilva

Review URL: https://codereview.chromium.org/273233004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269639 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Some refactorings to facilitate a larger change to TemplateURLService. (https://codereview.chromium.org/270533007/)

Reason for revert:
See memory failure: bot: http://build.chromium.org/p/chromium.memory/builders/Mac%20ASan%2064%20Tests%20%281%29/builds/759/steps/unit_tests/logs/stdio

Original issue's description:
> Some refactorings to facilitate a larger change to TemplateURLService.
> 
> BUG=365762
> R=pkasting@chromium.org
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269310

TBR=pkasting@chromium.org,erikwright@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=365762

Review URL: https://codereview.chromium.org/279063002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269638 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Handle TemplateURLService load failure better, and make some test correctness fixes that will be ne… (https://codereview.chromium.org/272573004/)

Reason for revert:
Seems to be causing use after free on Mac: http://build.chromium.org/p/chromium.memory/builders/Mac%20ASan%2064%20Tests%20%281%29/builds/759

Original issue's description:
> Handle TemplateURLService load failure better, and make some test correctness fixes that will be needed later.
> 
> This also does a variety of miscellaneous cleanups to the modified files.
> 
> BUG=364183
> TEST=none
> R=jered@chromium.org, pkasting@chromium.org
> TBR=engedy
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269329

TBR=pkasting@chromium.org,zea@chromium.org,jered@chromium.org,engedy@chromium.org,erikwright@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=364183

Review URL: https://codereview.chromium.org/273153004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269637 0039d316-1c4b-4281-b951-d872f2087c98