- 03 Dec, 2020 40 commits
-
-
Matt Menke authored
I'm working on gettings things like 127.0.0.0.1, foo.0.1, and, potentially, foo.1 rejected at the GURL level. This CL updates a couple tests in advance of that so as to rely on URLs with hostnames like these being considered valid. Bug: 1143453 Change-Id: Iae326c3d5df58b6350fd0b89320f7bf64de9e1e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2565196Reviewed-by:
Eric Orth <ericorth@chromium.org> Reviewed-by:
Xinghui Lu <xinghuilu@chromium.org> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#833106}
-
Yuichiro Hanada authored
The proxy IME in Android sometimes fail to find the appropriate KeyboardCode for a Android's KEYCODE. The proxy IME uses ui::VKEY_UNKNOWN for the key event. However, it's rejected in a validation code and the mojo connection is closed as a result. This CL adds a new optional field in KeyEventData struct for a scan code of a key event. The field will be used when the proxy IME fails to find the appropriate KeyboardCode. Bug: b:174259561 Test: component_unittests Change-Id: If4cf5514bdb6cc7026964025e42e4ae6bc3e57b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567141 Commit-Queue: Yuichiro Hanada <yhanada@chromium.org> Reviewed-by:
Jorge Lucangeli Obes <jorgelo@chromium.org> Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#833105}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/95ffe036632c..bae138de13ac 2020-12-02 amaiorano@google.com Reactor: add Type* member to Value and remove vtable 2020-12-02 amaiorano@google.com Fix crash from rr::Array with ENABLE_RR_DEBUG_INFO enabled If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I6d20539afa18cd98bd20ca191d95da3bd75143cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570224Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#833104}
-
Hirokazu Honda authored
The test originally validates the entire bitstream. This CL enables the test to validate each temporal layer stream. For instance, when --num_temporal_layers=3, the test validates three streams, TL0, TL0+TL1 and TL0+TL1+TL2. BitstreamFileWriter and VideoFrameFileWriter ignore bitstreams and frames in upper layers than to be processed by them. VideoFrameFileWriter also writes a file with a different prefix from other VideoFrameFileWriter, so that multiple instances don't write to the same file names. Bug: b:174318867 Test: video_encode_accelerator_tests --codec=vp9 --num_temporal_layers=3 w/o output_bitstream --output_images=all Change-Id: Idf2a1e4d2a50e11ca359435ec4495a43b61139f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2562801Reviewed-by:
David Staessens <dstaessens@chromium.org> Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#833103}
-
Dmitry Torokhov authored
This reverts commit a96ef56c. Reason for revert: Parallels have upgraded to QT 5.15 hence the workaround is no longer needed. Original change's description: > exo: temporarily clamp display scale factor to 2 > > Version of QT currently in use by Parallels Desktop does not render > correctly when display scale factor is above 2, so let's use 2 as the > upper bound until they switch to a newer version of QT (5.15 should > have the fix). > > Bug: b/169984627 > Change-Id: Idd31b9a737833fa48ab6b20ae8da5f1bf951b3ff > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446720 > Commit-Queue: Dmitry Torokhov <dtor@chromium.org> > Reviewed-by: Mitsuru Oshima <oshima@chromium.org> > Cr-Commit-Position: refs/heads/master@{#816020} TBR=oshima@chromium.org,dtor@chromium.org,edcourtney@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: b/169984627 Bug: 1137268 Change-Id: Iba38d0df84c87ed7ade2986704f9d29d5ec75f78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570309Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Dmitry Torokhov <dtor@chromium.org> Cr-Commit-Position: refs/heads/master@{#833102}
-
Xianzhu Wang authored
This CL avoids the problem by - Disabling compositing of SVG child for will-change:top etc. which don't apply. - Including CompositingReason::kSVGRoot on the effect node (if exists) on SVG root to prevent the effect node from being decomposited during PaintArtifactCompositor::Update(), to ensure the composited layer for SVG root will create a render surface when needed. We still need to create a better solution for this (tracked by crbug.com/1154097). Because CompositingReason::kSVGRoot is for pre-CompositeAfterPaint CompositeSVG only to create a GraphicsLayer with ShouldCreateLayersAfterPaint, this CL also disable the logic for CompositeAfterPaint. Bug: 1152691 Change-Id: Ic194501698c0afd5a058647344f812077ed07709 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567614 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#833101}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/252a9ed0..5b8d12f1 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Iab08c3038c25cd5e9f3e92c0ea1eb16e8ab20662 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570330Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#833100}
-
Brandon Jones authored
Changes the function to accept a GPUAdapter instead of a GPUDevice and return a GPUTextureFormat synchronously rather than via a Promise. The previous function signature is left in place with a deprecation warning. Bug: 1154326 Change-Id: I0593d04933b5bf6d91c6428239fd04a32170210b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566885Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Commit-Queue: Brandon Jones <bajones@chromium.org> Cr-Commit-Position: refs/heads/master@{#833099}
-
Melissa Zhang authored
This CL refactors sharesheet_service_delegate to be identified by its native_window. This is so that we can ensure only one sharesheet for any one native_window at any time. Bug: 1142706 Change-Id: I7892bb5b95f6ab4fa17c772e173084b11e3ab69f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2563010Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Melissa Zhang <melzhang@chromium.org> Cr-Commit-Position: refs/heads/master@{#833098}
-
Mitsuru Oshima authored
instead of new layer. This will be used to address performance related issue. Bug: None Test: covered by unittest Change-Id: I3b6b0bfdd8ab4fb11b21fd7b84f677169023bfe9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560549 Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#833097}
-
Adam Langley authored
This #include pulls in quite a lot of headers in render_frame_host.h, a fairly core header. Change-Id: I17288f2e166ec15880ebac6a11f07c574b16d94b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2553021 Commit-Queue: Adam Langley <agl@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Auto-Submit: Adam Langley <agl@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#833096}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/40894189c86a..5334e8976d42 2020-12-02 mtklein@google.com Revert "restore murmur3 for older iOS devices" 2020-12-02 scroggo@google.com Expose more info in SkCodec::FrameInfo 2020-12-02 mtklein@google.com simplify SkSamplingOptions field names 2020-12-02 mtklein@google.com make SkSamplingOptions fields const 2020-12-02 bsalomon@google.com GPU clear values: just 4 floats 2020-12-02 tdenniston@google.com Add test for quadratic Wang's formula 2020-12-02 mtklein@google.com restore murmur3 for older iOS devices 2020-12-02 johnstiles@google.com Fix flipped array dimensions in SkSL. 2020-12-02 bungeman@google.com Subpixel anti-aliasing in FreeType 2.8.1+ 2020-12-02 robertphillips@google.com Revert "Fix bug in GrClearOp combining and remove some asserts" 2020-12-02 johnstiles@google.com Disable inliner on Functions.sksl. 2020-12-02 brianosman@google.com Remove unused inColor If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC westont@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: westont@google.com Change-Id: I2956ee5cbf737f00587f8c4a022b476af3377e90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2569516Reviewed-by:
-
Krishna Govind authored
TBR=benmason@chromium.org Change-Id: Ia1e0e2402789f0922099353b45edfe6e256596aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2569388Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#833094}
-
Zach Trudo authored
RecordHandlerImpl replaces Destination specific handlers with a handler that points directly to the new endpoint. Bug: chromium:1078512 Change-Id: I8dd7ceca2556ad032f2e398cde1987fa4100b016 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2555200 Commit-Queue: Zach Trudo <zatrudo@google.com> Reviewed-by:
Leonid Baraz <lbaraz@chromium.org> Cr-Commit-Position: refs/heads/master@{#833093}
-
Thanh Nguyen authored
Add new function to utility/services.cc that allows us to launch LocalSearchService out of process. Design doc: go/lss-sandboxing Implementation plan: go/lss-sandboxing-impl Bug: 1137560 Change-Id: I921281b6a309f8ffa66a3cd0e4f1e5119a824ec9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2562806Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Jia Meng <jiameng@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Commit-Queue: Thanh Nguyen <thanhdng@chromium.org> Cr-Commit-Position: refs/heads/master@{#833092}
-
Yao Xiao authored
Bug: 1154556 Change-Id: Ib4d6bbb1f94fac80823b729b963f36becd1f3792 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568939 Commit-Queue: Yao Xiao <yaoxia@chromium.org> Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Reviewed-by:
-
Asanka Herath authored
We are making a corresponding change to the server controlled experiment. This change brings the waterfall tests closer in character to what is in the field. Bug: 1154693 Change-Id: I47ec85a18c195b878ee1b0bc074c99417951a000 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568624 Commit-Queue: Asanka Herath <asanka@chromium.org> Reviewed-by:
Caitlin Fischer <caitlinfischer@google.com> Cr-Commit-Position: refs/heads/master@{#833090}
-
Noel Gordon authored
Due to issue 1152084 some users might have incorrectly EXIF orientated JPEG thumbnails in their image loader cache. Update the image loader's IDB cache version to reset (aka clear) the users image loader cache. Bug: 1152084 Change-Id: I3fee9a406c10cca435227418310379cda4b25fac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2569194Reviewed-by:
Alex Danilo <adanilo@chromium.org> Commit-Queue: Alex Danilo <adanilo@chromium.org> Auto-Submit: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#833089}
-
Brian Sheedy authored
The Windows Intel pool has had a mix of HD and UHD 630 GPUs for a while now, so there's no need to specifically test UHD 630 GPUs anymore. Bug: 1154460 Change-Id: I27d43dc6c74dd332fe7575743bb17007cb30617c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570124 Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Auto-Submit: Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#833088}
-
Brian Sheedy authored
We already have stable tests running on RX 5500 XTs with more capacity, so no reason to keep the old AMD builder around. Bug: 1154895 Change-Id: Idd16c259e8c74903b8def0289155444ebef85a91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570387 Auto-Submit: Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
-
David Trainor authored
This reverts commit dde99fda. Reason for revert: Reliably failing due to timeout on android-marshmallow-x86-rel-non-cq. Sample failure: https://ci.chromium.org/ui/p/chromium/builders/ci/android-marshmallow-x86-rel-non-cq/1034/overview Original change's description: > [remoteobjects] Add JavaBridgeBasicsTest#testWebViewAfterRenderViewSwapped > > This CL adds JavaBridgeBasicsTest#testWebViewAfterRenderViewSwapped > to recreate the regression scenario described in > https://crbug.com/572053, and to verify that the new code works as > expected. > > Bug: 1105935 > Change-Id: Ie527f0c452a9d3eac7fe0c91797b792eff15c23d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2564931 > Reviewed-by: Bo <boliu@chromium.org> > Reviewed-by: Oksana Zhuravlova <oksamyt@chromium.org> > Commit-Queue: Miyoung Shin <myid.shin@igalia.com> > Cr-Commit-Position: refs/heads/master@{#832636} TBR=boliu@chromium.org,oksamyt@chromium.org,myid.shin@igalia.com,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com Change-Id: Id346701be025b4b61e8eae07442a902c5c009bd0 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1105935 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570449Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#833086}
-
Bao-Duy Tran authored
This script is used for on-the-fly autogen of C++ code from legacy input_methods.txt [1] config file that's mostly obsolete and on track for full deprecation. This cleanup is in prep for trimming the script to just what's still really in use nowadays from input_methods.txt. [1] https://source.chromium.org/chromium/chromium/src/+/master:chromeos/ime/input_methods.txt;drc=5ab33d25bc676b63e4afbcfade6f9265a5f5a3ea Bug: 1134526,1134465 Change-Id: Id8b235958deaee0f2d935f8e384af9c4e0cc19c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568923Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Reviewed-by:
My Nguyen <myy@chromium.org> Commit-Queue: Bao-Duy Tran <tranbaoduy@chromium.org> Cr-Commit-Position: refs/heads/master@{#833085}
-
Victor Costan authored
//tools/mb/mb_config_expectations/tryserver.chromium.mac.json was updated by running "tools/mb/mb.py train" //infra/config/generated/* was updated by running "lucicfg generate infra/config/main.star" Bug: 1154062 Change-Id: I13a9e0bb1dd2a7f3ccdaf30fa600de4cedafa92c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566335Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#833084}
-
Olivier Yiptong authored
This makes a now unused histogram obsolete. It has been replaced by Fonts.AccessAPI.EnumerationCache.* Fixed: 1138245 Change-Id: I000d4f5c048706e8a518ee7c3b98ee128362c498 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2569979 Commit-Queue: Stephen Chenney <schenney@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Auto-Submit: Olivier Yiptong <oyiptong@chromium.org> Cr-Commit-Position: refs/heads/master@{#833083}
-
edchin authored
This CL adds utility functions that provide a cross-platform interface for obtaining the task runner for the IO and UI threads. Note that base::CreateSingleThreadTaskRunner() is an older approach to obtaining the task runners for the IO and UI threads. But it is still used in iOS. Bug: 1147967 Change-Id: I2d16613864f5a5b927157b5a26377d7513032905 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2559793 Commit-Queue: Varun Khaneja <vakh@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Reviewed-by:
Ali Juma <ajuma@chromium.org> Reviewed-by:
Bettina Dea <bdea@chromium.org> Cr-Commit-Position: refs/heads/master@{#833082}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/ae504d46b4c4..a45552c0f29d 2020-12-02 bhamrick@google.com Merge "Improve Fuchsia Importer" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I0d8fad7735f19faea5f13167dd925eb490c31038 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570165Reviewed-by:
-
Jan Wilken Dörrie authored
This change inlines the defaulted assignment operators in flat_tree. Furthermore, this works around a compiler bug exposed in old GCC versions. Fixed: 1154608 Change-Id: I488b6003de6630d2d18b7849bc903db2d41ed9bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566943 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Auto-Submit: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#833080}
-
Sophey Dong authored
Bug: 1151439 Change-Id: I515683feb913810f3e15428d3f7249c292552b9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552769Reviewed-by:
Donn Denman <donnd@chromium.org> Reviewed-by:
Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Kyle Milka <kmilka@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Sophey Dong <sophey@chromium.org> Cr-Commit-Position: refs/heads/master@{#833079}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/8e0ff2457021..46df5d14ee80 2020-12-02 tsepez@chromium.org Remove one form of CFXJSE_ScoeUtil_IsolateHandleContext constructor. 2020-12-02 tsepez@chromium.org Split up CFXJSE_ScopeUtil_IsolateHandleContext If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: pdfium-deps-rolls@chromium.org Change-Id: I7b924521b4d1461139ff600d690b964f0fa3f748 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570166Reviewed-by:
-
James Cook authored
This is a small step toward decoupling //chromeos/constants from //chromeos/dbus. Decoupling should make future code migrations slightly easier, e.g. code moves for lacros. Bug: none Change-Id: Icc27df24c9cfb8ed340da9c489be834ed56d83bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570104Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/d1655710f7a7..70828422634e 2020-12-02 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: If3c30f3f27a57f04d0e28c847f7401dcba27b322 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570223Reviewed-by:
-
Makoto Shimazu authored
This reverts commit a954ef5f. Reason for revert: https://crrev.com/c/2569026 has been reverted Original change's description: > Temporarily disable webaudio/DynamicsCompressor/compressor.html > > New test, fails on Mac. > > TBR: rtoy > Bug: 1154883 > Change-Id: I64534e6aa5ee39f928ff7a8c4df21b64a5e70901 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570019 > Reviewed-by: Dmitry Titov <dimich@chromium.org> > Reviewed-by: Raymond Toy <rtoy@chromium.org> > Commit-Queue: Dmitry Titov <dimich@chromium.org> > Cr-Commit-Position: refs/heads/master@{#833057} TBR=dimich@chromium.org,rtoy@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com Change-Id: Id448bf98326e5dec2d917d2c90e18a7f286fe955 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1154883 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568998Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#833075}
-
Makoto Shimazu authored
This reverts commit bb8326f6. Reason for revert: The test doesn't seem to pass on Mac and flaky on Linux too. sample build: https://ci.chromium.org/ui/p/chromium/builders/ci/Mac10.14%20Tests/11116/overview Original change's description: > Add test for DynamicsCompressor > > Add a simple test of the DynamicsCompressor using two oscillators and > a gain node to control the amplitude. We compare the output with a > reference file and also compare the reduction values with a known set. > > The reference output and reduction value files were created by saving > the output from the test. > > There's too much variation between browsers to make this a web > platform test. > > Bug: 1013248 > Test: webaudio/DynamicsCompressor/compressor.html > Change-Id: Ib7c68b5b8ffa79b0a78b5b842fef4b121e1bcf52 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364744 > Commit-Queue: Raymond Toy <rtoy@chromium.org> > Reviewed-by: Hongchan Choi <hongchan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#832890} TBR=rtoy@chromium.org,hongchan@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com Change-Id: I05d4fdbc0c90b57e354d3bc0537f962c6e437fa9 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1013248 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2569026Reviewed-by:
-
dpapad authored
This script: - Is basically unmaintained. - It's unclear if it still works - Has not been very helpful and does not justify the cost of maintaining it. - Is unlikely to be ported to work with Polymer3 JS imports in third_party/polymer/v3_0/ folder. Moreover, we have way less Polymer UI elemens dependencies than when this script was originally authored, and manually identifying unused elements has not been a problem. Fixed: 997850 Change-Id: Ic062bf1bc1cccf4bd2c98bb37a83b9103270dbb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2569372 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Auto-Submit: dpapad <dpapad@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#833073}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: I5f007ff9188166b6f4eff40a7c13cc3fb9314c8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570037Reviewed-by:
-
Jiewei Qian authored
SettingsWindowObserver is used to check if the number of OS Settings browser instances are correct. This can be performed in other ways without relying on SettingsWindowManager. SettingsWindowManager predates the SWA platform, which implements many features wanted by OS Settings, but were otherwise unavailable. After SWA platform launch, we have implemented these features in SWA platform, so it's no longer necessary for OS Settings to duplicate these logics. This is a preparation for implementing a new LaunchSystemWebApp API, which no longer returns the Browser object running the launched App. Bug: 1154540 Change-Id: I2c3322d30fbf2c288e03aa3cc139f9f3bbf74920 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2569191 Commit-Queue: Jiewei Qian <qjw@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#833071}
-
Charlie Hu authored
The fix to missing document policy in XSLT documents involves initialize document policy from previous security context, which results |DocumentLoader::document_policy_| not having correct policy content before document policy initialization in |SecurityContextInit|. This CL moves the check for ForceLoadAtTop feature after document policy initialization, so that its behaviour is consistent in XSLT documents. Bug: 1151954 Change-Id: I0a4061975a26cbf922b322c908ce8c2c88897715 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568439Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Ian Clelland <iclelland@chromium.org> Commit-Queue: Charlie Hu <chenleihu@google.com> Cr-Commit-Position: refs/heads/master@{#833070}
-
David Trainor authored
TBR=changwan@chromium.org Bug: 1153705 Change-Id: I94974a23a913f51046d0d092f0fb3b827a88cbcf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570208Reviewed-by:
Changwan Ryu <changwan@chromium.org> Commit-Queue: David Trainor <dtrainor@chromium.org> Commit-Queue: Changwan Ryu <changwan@chromium.org> Auto-Submit: David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#833069}
-
Daniel Hosseinian authored
PDFium's FPDFText_GetTextRenderMode() is technically an experimental API, but it guarantees to return enum values within a certain range. By statically asserting the bounds of FPDF_TEXT_RENDERMODE, we can simply DCHECK the returned value of FPDFText_GetTextRenderMode() against those bounds instead of handling an out-of-bounds value in runtime. Change-Id: I89d377eeaaab5186712e6b85683bf658590eab53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567452 Commit-Queue: Daniel Hosseinian <dhoss@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#833068}
-
danakj authored
Step 4 for bug 1125106. This is a subset of the mega-patch in https://chromium-review.googlesource.com/c/chromium/src/+/2462248. A same-document navigation is a request to navigate the currently loaded document to the specified anchor tag from the URL. Renderer-initiated navigations simply perform the scroll operation and update history. Browser-initiated ones are treated as a navigation. However there are many things that could cause the given URL to want to load in a different SiteInstance than what was used for the previous load. But using a different SiteInstance would also mean reloading the document - which means it is no longer a same-document navigation. Previous patches in this series have prevented us from trying to load a same-document navigation when there would be valid reasons to want to do a cross-document navigation. Follow-up patches will introduce CHECK()s in the renderer to show that we are in fact never trying to perform a same-document navigation anymore when we would have required a cross-document navigation (with the exception of navigating a frameset which must fallback to cross- document). R=nasko@chromium.org Bug: 1125106 Change-Id: I3603cb0a3698d9e6241aca4eb8895db4fcdfd139 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2558760 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#833067}
-
