GitLab

R=garykac@chromium.org
BUG=
TEST=


Review URL: http://codereview.chromium.org/10191002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133755 0039d316-1c4b-4281-b951-d872f2087c98

This change causes the syncer to exit from its download then commit
function if the download fails. This helps prevent the creation of
server-side conflicts, which would be more likely to happen if a
download failed but the following commit succeeded.

The main changes are as follows:
- Rather than proceed to the next step when a download updates failure
is detected, the syncer will exit. This should cause the
SyncScheduler to schedule a retry at a later time. 
- The definition of a download updates failure is now based on the
return code of the download attempt, rather than checking the contents
of the (possible non-existent) returned protobuf. This makes the error
detection logic used here more closely match the logic used to decide
whether or not to schedule retries.

This implementation has a side-effect on configure sync cycles. The old
behaviour was to handle failures by applying whatever updates we had
downloaded at that point. The new behaviour will leave updates
unapplied if any error occurs. This better matches a nearby comment's
assertion which states that we should not attempt to apply updates until
we have downloaded all of them. I believe the author of that comment
would approve of this change.

This change moves around some of the ExtensionActivityMonitor logic.
It's important that we not take the data from the extensions acitivity
monitor at the start of the cycle. Restoring that data is handled in
the commit building and response code, which might not be executed if we
need to break out early. This also fixes issue 123270.

Most of the diffs for this change are concentrated in the unit tests:
- Expose more of the SyncScheduler to the SyncerTest test harness.
- Add functions to SyncerTest for testing specific types of sync jobs.
- Add some functions that allow us to better control failures in
MockConnectionManager.
- Added tests for configure job success and failure.
- Added tests for update then commit job success and failure.
- Removed some redundant tests.
- Removed unused test infrastructure.

This change allows the integration tests to expose a bug that was
introduced back in r118572.  That commit assumed it was OK to not
retry a job that failed due to a MIGRATION_DONE response from the
server.  That is incorrect, and this error has been fixed.

BUG=122033, 123270
TEST=sync_unit_tests, specifically:
SyncerTest.UpdateThenCommit,
SyncerTest.UpdateFailsThenDontCommit,
SyncerTest.ConfigureDownloadsTwoBatchesSuccess,
SyncerTest.ConfigureFailsDontApplyUpdates


Review URL: http://codereview.chromium.org/10103017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133754 0039d316-1c4b-4281-b951-d872f2087c98

The source of the failures was not identified; there were no IDB
changes in range. Apparently they're passing again - re-enabling
to verify and catch regressions.

BUG=123045
TEST=python chrome/test/functional/indexeddb.py
R=nirnimesh@chromium.org


Review URL: http://codereview.chromium.org/10173003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133753 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:25280
TEST=Manual inspection in comparison to r19.
TBR=zelidrag

Review URL: http://codereview.chromium.org/10206008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133752 0039d316-1c4b-4281-b951-d872f2087c98

WaitUntilNavigationCompletes() can be determined.

TEST=none
BUG=124877
Review URL: https://chromiumcodereview.appspot.com/10217005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133751 0039d316-1c4b-4281-b951-d872f2087c98

Fix all tests in chromeos_wifi_sanity.py except testToggleNetworkDevic. I'll look at that separately.

R=stanleyw@chromium.org
BUG=None
TEST=chromeos_wifi_sanity in pyauto_functional

Review URL: https://chromiumcodereview.appspot.com/10209007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133750 0039d316-1c4b-4281-b951-d872f2087c98

The corresponding CL:
https://chromiumcodereview.appspot.com/10163002/

BUG=113688
TEST=none

Review URL: https://chromiumcodereview.appspot.com/10180002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133749 0039d316-1c4b-4281-b951-d872f2087c98

This fixes a crash that shows up when terminating from the system tray popup.

BUG=105151,124310
TEST=WidgetObserverTest.DestroyBubble

Review URL: https://chromiumcodereview.appspot.com/10204014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133748 0039d316-1c4b-4281-b951-d872f2087c98

Previously it was an immutable struct that was passed around by making
dynamic allocations and passing pointers. We now just have a class with
only getters and no setters, but support for default copy and assign.

This cleans up some code and makes some future work easier to pass snapshots
around.

BUG=none
TEST=sync_unit_tests


Review URL: http://codereview.chromium.org/10197004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133747 0039d316-1c4b-4281-b951-d872f2087c98

This caused chromium os tests to fail, http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%281%29/builds/1981/steps/unit_tests/logs/DefaultMigrationHomepageIsNTP

BUG=122936
TEST=Upgrade from 18 to 19
TBR=ben@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10049005

TBR=tbreisacher@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10173007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133746 0039d316-1c4b-4281-b951-d872f2087c98

This broke the SelectFileDialogExtensionBrowserTest.SelectFileAndOpen test on linux chromiumos browser_tests.

BUG=chromium-os:26471
TEST=After entering the folder none of the files is selected.
Review URL: https://chromiumcodereview.appspot.com/10204015

TBR=oleg@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10212005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133745 0039d316-1c4b-4281-b951-d872f2087c98

PrerenderLocalPredictor will now keep around a reference to the HistoryService
that it subscribed too, and will unsubscribe itself on destruction.
Since PrerenderLocalPredictor is owned by PrerenderManager, and both
PrerenderManager and HistoryService have the same lifetime as the underlying
profile, the HistoryService object will not be kept around unnecessarily
longer as a result of this.
R=brettw, cbentzel
Review URL: https://chromiumcodereview.appspot.com/10214004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133744 0039d316-1c4b-4281-b951-d872f2087c98

TBR=cmp@chromium.org
BUG=
TEST=try slaves will be faster


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133743 0039d316-1c4b-4281-b951-d872f2087c98

The OCSP test server works now. (fixed by http://src.chromium.org/viewvc/chrome?view=rev&revision=133704)

The on-demand OCSP test server is not supported on Android. Disable
these tests.

BUG=119642
TEST=green bots


Review URL: http://codereview.chromium.org/9837027

TBR=rsleevi@chromium.org

Review URL: http://codereview.chromium.org/10211002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133742 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none

Review URL: http://codereview.chromium.org/10204018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133741 0039d316-1c4b-4281-b951-d872f2087c98

BUG=122936
TEST=Upgrade from 18 to 19
TBR=ben@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10049005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133740 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/10207007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133739 0039d316-1c4b-4281-b951-d872f2087c98

BUG=117186	
TEST=

Review URL: http://codereview.chromium.org/10169030

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133738 0039d316-1c4b-4281-b951-d872f2087c98

Get rid of the multitude of close buttons.

BUG=124648
TEST=none
R=dbeam


Review URL: http://codereview.chromium.org/10187008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133737 0039d316-1c4b-4281-b951-d872f2087c98

BUG=119646
TEST=none
R=dbeam


Review URL: http://codereview.chromium.org/10200002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133734 0039d316-1c4b-4281-b951-d872f2087c98

BUG=115122
TEST=GPU win/linux debug bots
TBR=kbr
Review URL: https://chromiumcodereview.appspot.com/10209001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133733 0039d316-1c4b-4281-b951-d872f2087c98

In some cases, the TextureImageTransportSurface may get destroyed when no
context is current. When that's the case, glDeleteTextures becomes a noop and we
leak them.

BUG=123933
TEST=manual


Review URL: http://codereview.chromium.org/10200012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133732 0039d316-1c4b-4281-b951-d872f2087c98

Re-purpose linux-sdk-mono64 bot to build these release packages, since
all the continuous building is happening on linux-sdk-mono32, this one is free.

BUG=115363
TEST=bots,manual

Note: This CL only affects the Native Client SDK
Review URL: https://chromiumcodereview.appspot.com/10156003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133731 0039d316-1c4b-4281-b951-d872f2087c98

The SelectFileAndSave test was failing on linux chromiumos browsertests since r133663. This seems to be due to a name mismatch in the CL which renamed a method isFilterHiddenOn but attempted to call it as getFilterHidden. See https://chromiumcodereview.appspot.com/10206015.

TBR=oleg

BUG=None
TEST=SelectFileDialogExtensionBrowserTest.SelectFileAndSave

Review URL: https://chromiumcodereview.appspot.com/10215001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133730 0039d316-1c4b-4281-b951-d872f2087c98

BUG=121456
TEST=None


Review URL: http://codereview.chromium.org/10207016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133728 0039d316-1c4b-4281-b951-d872f2087c98

(Also fixing some minor lint errors...)

Review URL: http://codereview.chromium.org/10184011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133726 0039d316-1c4b-4281-b951-d872f2087c98

- Moving ByteQueue from ChunkDemuxer into WebMStreamParser to simplify handling
  multiple StreamParsers.
- Replacing OnAudioConfig & OnVideoConfig with a single OnNewConfigs method to
  make it easier to verify that initialization segments all contain the same
  number and type of streams.


BUG=122909
TEST=Existing ChunkDemuxer tests.


Review URL: http://codereview.chromium.org/10205004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133725 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133724 0039d316-1c4b-4281-b951-d872f2087c98

TBR=dglazkov@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10141012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133723 0039d316-1c4b-4281-b951-d872f2087c98

BUG=107216
TEST=ChromeAppAPITest.*

Review URL: http://codereview.chromium.org/10174001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133722 0039d316-1c4b-4281-b951-d872f2087c98

Triaged the bugs for one-click sign in and automated what was available.
Current set of automated tests do not include scenarios where sync is accepted as
there may be a UI change down the road related to those tests.

 -testDisplayOneClickInfobar
 -testNoOneClickInfobarAfterCancel
 -testDisplayOneClickInfobarAfterDismiss
 -testDisplayOneClickInfobarPerProfile
 -testNoSameIDSigninForTwoProfiles
 -testNoOneClickInfobarWhenCookiesBlocked
 -testOneClickInfobarShownWhenWinLoseFocus

TESTS=none
BUG=124326
Review URL: https://chromiumcodereview.appspot.com/10152004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133718 0039d316-1c4b-4281-b951-d872f2087c98

TEST=compiles
BUG=none

Review URL: https://chromiumcodereview.appspot.com/10169031

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133716 0039d316-1c4b-4281-b951-d872f2087c98

Issue 10146016 was the original issue. It failed on linux_chromeos.


TBR=ben,flackr
BUG=118651
TEST=


Review URL: http://codereview.chromium.org/10205013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133715 0039d316-1c4b-4281-b951-d872f2087c98

BUG=124464
TEST=none

Review URL: https://chromiumcodereview.appspot.com/10200006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133714 0039d316-1c4b-4281-b951-d872f2087c98

Move the suppression to Section 1: third party stuff we have no
control over.

Add the glibc bug number for a similar leak in dlopen.

R=thestig@chromium.org
BUG=51770,60958,124494
TEST=none
Review URL: https://chromiumcodereview.appspot.com/10206005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133711 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TBR=zelidrag@chromium.org
TEST=confirm that the string and the icon are updated in the file manager

Review URL: https://chromiumcodereview.appspot.com/10134034

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133710 0039d316-1c4b-4281-b951-d872f2087c98

Update run_test_from_archieve.py to check if a url is valid before downloading it to prevent grabbing files that are just 404s.


BUG=
TEST=


Review URL: http://codereview.chromium.org/10187007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133709 0039d316-1c4b-4281-b951-d872f2087c98

BUG=124592
TEST=none

Review URL: https://chromiumcodereview.appspot.com/10191006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133706 0039d316-1c4b-4281-b951-d872f2087c98

Previously the arguments to GenerateCertKeyAndOCSP were used in operations with
binary data directly. If they were unicode objects then their encoding may not
have supported the DER data causing an error.

By passing through bytes(), we get a str object and we make it clear that we'll
be using this with binary data.

BUG=119642
TEST=net_unittests

Review URL: http://codereview.chromium.org/10188005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133704 0039d316-1c4b-4281-b951-d872f2087c98

No functionality change. Found by clang.

BUG=none
TEST=none

Review URL: https://chromiumcodereview.appspot.com/10155029

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133703 0039d316-1c4b-4281-b951-d872f2087c98