GitLab

Revert of Use TaskScheduler instead of WorkerPool in gbm_surfaceless.cc. (patchset #2 id:20001 of https://codereview.chromium.org/2609733002/ )

Reason for revert:
Causes the UI to crash on peach_pit and multiple HWTest failures on the PFQ and the informational builder. See BUG=678296.

Original issue's description:
> Use TaskScheduler instead of WorkerPool in gbm_surfaceless.cc.
>
> The following traits are used:
>
> Priority: Inherited (default)
>   The priority is inherited from the calling context (i.e. TaskTraits
>   are initialized with the priority of the current task).
>
> Shutdown behavior: CONTINUE_ON_SHUTDOWN
>   Tasks posted with this mode which have not started executing before
>   shutdown is initiated will never run. Tasks with this mode running at
>   shutdown will be ignored (the worker will not be joined).
>
>   Note: Tasks that were previously posted to base::WorkerPool should
>   use this shutdown behavior because this is how base::WorkerPool
>   handles all its tasks.
>
> May Block:
>   Tasks posted with MayBlock() may block. This includes but is not
>   limited to tasks that wait on synchronous file I/O operations:
>   read or write a file from disk, interact with a pipe or a socket,
>   rename or delete a file, enumerate files in a directory, etc. This
>   trait isn't required for the mere use of locks.
>
> BUG=659191
>
> Committed: https://crrev.com/0127fd25bd985f1f5f87c0a7c060d3159142086a
> Cr-Commit-Position: refs/heads/master@{#441139}

TBR=dnicoara@chromium.org,fdoray@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=659191

Review-Url: https://codereview.chromium.org/2612853002
Cr-Commit-Position: refs/heads/master@{#441438}

Also, run clang-format to fix up styling.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2592143002
Cr-Commit-Position: refs/heads/master@{#441437}

The following traits are used:

Priority: Inherited (default)
  The priority is inherited from the calling context (i.e. TaskTraits
  are initialized with the priority of the current task).

Shutdown behavior: CONTINUE_ON_SHUTDOWN
  Tasks posted with this mode which have not started executing before
  shutdown is initiated will never run. Tasks with this mode running at
  shutdown will be ignored (the worker will not be joined).

  Note: Tasks that were previously posted to base::WorkerPool should
  use this shutdown behavior because this is how base::WorkerPool
  handles all its tasks.

May Block:
  Tasks posted with MayBlock() may block. This includes but is not
  limited to tasks that wait on synchronous file I/O operations:
  read or write a file from disk, interact with a pipe or a socket,
  rename or delete a file, enumerate files in a directory, etc. This
  trait isn't required for the mere use of locks.

BUG=659191

Review-Url: https://codereview.chromium.org/2603163002
Cr-Commit-Position: refs/heads/master@{#441436}

BUG=554289

Review-Url: https://codereview.chromium.org/2606293002
Cr-Commit-Position: refs/heads/master@{#441435}

BUG= internal b/32244773

Review-Url: https://codereview.chromium.org/2429963002
Cr-Commit-Position: refs/heads/master@{#441434}

All current Qualcomm GPUs are affected by a bug where program binaries
don't cache transform feedback varyings. Work around this by avoiding
the use of the in-memory and disk program caches when the transform
feedback varyings are non-empty.

BUG=658074
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2615573002
Cr-Commit-Position: refs/heads/master@{#441433}

The copy constructor breaks DisplayItemClient aliveness checking.
We could fix the copy constructor but it looks better not to support
the copy constructor.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2611923002
Cr-Commit-Position: refs/heads/master@{#441432}

BUG=678276

Review-Url: https://codereview.chromium.org/2610923002
Cr-Commit-Position: refs/heads/master@{#441431}

BUG=636977

Review-Url: https://codereview.chromium.org/2610803003
Cr-Commit-Position: refs/heads/master@{#441430}

This CL adds a few more methods that cause name collisions when Blink
is rewritten to match Chromium style. In addition, it removes the hash
method from the blacklist.

BUG=582312, 677166

Review-Url: https://codereview.chromium.org/2608423003
Cr-Commit-Position: refs/heads/master@{#441429}

The following traits are used:

Priority: Inherited (default)
  The priority is inherited from the calling context (i.e. TaskTraits
  are initialized with the priority of the current task).

Shutdown behavior: CONTINUE_ON_SHUTDOWN
  Tasks posted with this mode which have not started executing before
  shutdown is initiated will never run. Tasks with this mode running at
  shutdown will be ignored (the worker will not be joined).

  Note: Tasks that were previously posted to base::WorkerPool should
  use this shutdown behavior because this is how base::WorkerPool
  handles all its tasks.

May Block:
  Tasks posted with MayBlock() may block. This includes but is not
  limited to tasks that wait on synchronous file I/O operations:
  read or write a file from disk, interact with a pipe or a socket,
  rename or delete a file, enumerate files in a directory, etc. This
  trait isn't required for the mere use of locks.

BUG=659191

Review-Url: https://codereview.chromium.org/2611473002
Cr-Commit-Position: refs/heads/master@{#441428}

This CL adds a non-zero default bitrate for VEAEncoder. When given 0 bitrate,
Media Foundation H264 HW encoder does not output any results.

BUG=676421
TEST= Tested https://rawgit.com/Miguelao/demos/master/mediarecorder.html
H264 on Mac and Win.

Review-Url: https://codereview.chromium.org/2611843002
Cr-Commit-Position: refs/heads/master@{#441427}

The following traits are used:

Priority: BACKGROUND
  User won't notice if this task takes an arbitrarily long time
  to complete.

Shutdown behavior: CONTINUE_ON_SHUTDOWN
  Tasks posted with this mode which have not started executing before
  shutdown is initiated will never run. Tasks with this mode running at
  shutdown will be ignored (the worker will not be joined).

  Note: Tasks that were previously posted to base::WorkerPool should
  use this shutdown behavior because this is how base::WorkerPool
  handles all its tasks.

May Block:
  Tasks posted with MayBlock() may block. This includes but is not
  limited to tasks that wait on synchronous file I/O operations:
  read or write a file from disk, interact with a pipe or a socket,
  rename or delete a file, enumerate files in a directory, etc. This
  trait isn't required for the mere use of locks.

BUG=659191

Review-Url: https://codereview.chromium.org/2611463002
Cr-Commit-Position: refs/heads/master@{#441426}

This avoids accidental layering violations, by enforcing use of
GCMDriver::GetInstanceIDHandlerInternal (which is commented as "These
methods must only be used by the InstanceID system") to get access to
InstanceIDHandlers.

BUG=none

Review-Url: https://codereview.chromium.org/2610933002
Cr-Commit-Position: refs/heads/master@{#441425}

BUG=671805
R=dpranke@chromium.org,qyearsley@chromium.org

Review-Url: https://codereview.chromium.org/2591933002
Cr-Commit-Position: refs/heads/master@{#441424}

In particular:
* Fix conversion of UNIX file name "/////file" and "////" as a UNIX
  path.  Both of these were broken, due to the same bug.
* Remove a DCHECK that would trigger on "//" as a file name. It's a
  valid UNIX path, if not a file name, and can still be passed through
  the file name conversion code.  Since there's no code to prevent
  that from happening, and the conversion code handles "/", the DCHECK
  made no sense.

BUG=675111

Review-Url: https://codereview.chromium.org/2610973002
Cr-Commit-Position: refs/heads/master@{#441423}

Cr-Commit-Position: refs/heads/master@{#441422}

There are a number of privacy-sensitive checks that we make using this
function. In order to ensure that the URLs really belong to Google, add
a check that TLD has been registered by Google.

BUG=665624

Review-Url: https://codereview.chromium.org/2498113003
Cr-Commit-Position: refs/heads/master@{#441421}

As a part of presubmit, if an OWNERS file is modified or added the
following checks will be performed:

- Ensure that at most one line starts with `# COMPONENT: ` exists in the
  file.
- Ensure that at most one line starts with `# TEAM: ` exists in the
  file, and that it contains exactly one email address.

R=stgao@chromium.org,dpranke@chromium.org,phajdan.jr@chromium.org
BUG=667954

Review-Url: https://codereview.chromium.org/2601773004
Cr-Commit-Position: refs/heads/master@{#441420}

FRE was made to lazily load the libraries, but it attempts
to access the AccountManagerHelper before it has been
fully initialized.  To avoid this, use ChromeBrowserInitializer
to the pre native initialization early, which will call into:
ProcessInitializationHandler#handlePreNativeInitialization, which
does AccountManagerHelper.initializeAccountManagerHelper.

BUG=

Review-Url: https://codereview.chromium.org/2610173002
Cr-Commit-Position: refs/heads/master@{#441419}

The omnibox append button's normal (un-highlighted) image is correctly
reversed for RTL languages, but the imaged displayed when the button is
tapped is not.

BUG=678085

Review-Url: https://codereview.chromium.org/2606353004
Cr-Commit-Position: refs/heads/master@{#441418}

The old test checked the hit test results for individual tabs.  This assumed
that hitboxes for partly-occluded stacked tabs would themselves be partly
occluded, and basically verified that this occlusion made sense.

We changed this in r411197.  Now, individual tab hitboxes are the full size of
the tab, and instead tab occlusion is handled by functions like
FindTabForEvent(), which check tabs in the correct order.

The new test simply iterates across the tabstrip at three vertical positions,
checking what every pixel hits, and making sure the order (in tab model indexes)
of what's hit is:

-1 0 1 2 3 -1

I dunno that this is a very robust test, but I don't think we really had
anything else testing event handling for stacked tabs at all, so it seemed
better than deleting the test entirely.

BUG=575327
TEST=none

Review-Url: https://codereview.chromium.org/2593273002
Cr-Commit-Position: refs/heads/master@{#441417}

https://chromium.googlesource.com/external/github.com/google/compact_enc_det.git/+log/e57cdc44bd54..368a9cc09ad8

$ git log e57cdc44b..368a9cc09 --date=short --no-merges --format='%ad %ae %s'
2016-12-29 brucedawson Save 908,288 bytes by deleting 'const' three times

TBR=jinsukkim@chromium.org

BUG=677351,629332

Review-Url: https://codereview.chromium.org/2617463003
Cr-Commit-Position: refs/heads/master@{#441416}

TBR=dfalcantara,benwells
BUG=678210

Review-Url: https://codereview.chromium.org/2610913002
Cr-Commit-Position: refs/heads/master@{#441415}

BUG=

Review-Url: https://codereview.chromium.org/2613643002
Cr-Commit-Position: refs/heads/master@{#441414}

I only looked for calls to "bounds().origin()".  We could probably change a lot
more spots by fixing places that call both x() and y().

BUG=none
TEST=none

Review-Url: https://codereview.chromium.org/2595163002
Cr-Commit-Position: refs/heads/master@{#441413}

TBR=binji
BUG=676063

Review-Url: https://codereview.chromium.org/2612803002
Cr-Commit-Position: refs/heads/master@{#441412}

BUG=671816
TEST=TriView.SetMinHeight

Review-Url: https://codereview.chromium.org/2605513002
Cr-Commit-Position: refs/heads/master@{#441411}

It's impractical to merge them, so instead, allow overriding them.

Tested manually on Windows.

BUG=675582
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2617453002
Cr-Commit-Position: refs/heads/master@{#441410}

This should fix the http/tests/misc/resource-timing-sizes-tags.html layout test.
The other test http/tests/inspector/resource-har-conversion.html needs an expectation
change to allow the custom header which is passed for PlzNavigate. Will do that in a later
patchset.

Changes on this patch are to implement the GetTotalReceivedBytes() override for the StreamURLRequestJob class

BUG=673745

Review-Url: https://codereview.chromium.org/2612683002
Cr-Commit-Position: refs/heads/master@{#441409}

NOTRY=true
TBR=groby@chromium.org
BUG=678300

Review-Url: https://codereview.chromium.org/2611723003
Cr-Commit-Position: refs/heads/master@{#441408}

The original image baseline has the dropdown options hovering above the selector. This moves the <select> above the description/console and makes the dropdown appear in the correct position (i.e. directly below the selector)

BUG=

Review-Url: https://codereview.chromium.org/2611593003
Cr-Commit-Position: refs/heads/master@{#441407}

BUG=579229

Review-Url: https://codereview.chromium.org/2600783002
Cr-Commit-Position: refs/heads/master@{#441406}

For historical reasons, older tests are written using the js-test harness.
This harness is deprecated, and should not be used for new tests. So, rewrite
The layout test as following new tests guide[1].

[1] https://chromium.googlesource.com/chromium/src/+/master/docs/testing/writing_layout_tests.md#The-js_test_js-Legacy-Harness

BUG=678023

Review-Url: https://codereview.chromium.org/2611713002
Cr-Commit-Position: refs/heads/master@{#441405}

The layout tests have been using globals in skia to provide custom
font files. Skia would like to get rid of those globals. This change
adds a chromium-side SkFontMgr::Factory for the layout tests to use
instead.

BUG=chromium:567947,skia:2817

Review-Url: https://codereview.chromium.org/2599933002
Cr-Commit-Position: refs/heads/master@{#441404}

This reverts commit 6b24b79e.

The reason for this revert is that we want to remove the right-click
behavior from new user menu.

BUG=661289

Review-Url: https://codereview.chromium.org/2617493002
Cr-Commit-Position: refs/heads/master@{#441403}

While worker threads have no DOM access, they still get a scripting environment
and need wrapper tracing. Failing to invalidate and/or cleanup wrappers will leave
dangling pointers behind.

BUG=676700, 468240

Review-Url: https://codereview.chromium.org/2610853002
Cr-Commit-Position: refs/heads/master@{#441402}

I have made a truly wonderful mess of WebViewPlugin, via:
https://chromium.googlesource.com/chromium/src/+/8489f1bf78c2c6f296e0df6c529751d29e8a0188
https://chromium.googlesource.com/chromium/src/+/8ed4bf69eca5e2696aeab731a8e9a15e8f379f2b

My fundamental misunderstanding (I think!) was regarding what
WebViewPlugin is listening to via the various interfaces it subclasses.
It uses WebFrameClient and WebViewClient to observe its internal
WebView, while it uses WebPlugin and RenderViewObserver to interact
with the real external page. In the patches above, I mixed and matched
messages from those 2 sources because I thought they were coming from
the same context.

This patch reverts the damage done in those patches, and restores
ReplayReceivedData, more-or-less the way it was before I
started breaking stuff. It then continues the work I started in
https://chromium.googlesource.com/chromium/src/+/8e1badd5fbc054cf4ffc9303e8cb0aa22ce55ca6
and moves the subclassing of WebViewClient to a private helper class.
This helper, renamed to WebViewHelper, now handles all callbacks coming
from the internal WebView (i.e., the "WebView" in "WebViewPlugin"), and
WebViewPlugin continues subclassing WebPlugin and RenderViewObserver
to observe the outside world. This will hopefully make it harder to
screw things up in the same way in the future.

BUG=675585

Review-Url: https://codereview.chromium.org/2600253003
Cr-Commit-Position: refs/heads/master@{#441401}

A rewrite of the downstream orderfile recipe will call this script
rather than invoking AndroidProfileTool.CollectProfile directly.

BUG=639831

Review-Url: https://codereview.chromium.org/2614483002
Cr-Commit-Position: refs/heads/master@{#441400}

Move code from StoragePartitionHttpCacheRemover to CacheCountingHelper. Improve tests by adding a CacheTestUtil class for common functionality of cache counting and cache deletion tests.

BUG=671196
TBR=achuith@chromium.org

Review-Url: https://codereview.chromium.org/2556363003
Cr-Commit-Position: refs/heads/master@{#441399}