- 14 May, 2015 40 commits
-
-
reillyg authored
Fix one more instance of an OWNERS file living in an empty subdirectory of the directory it is supposed to be setting the owners of. Review URL: https://codereview.chromium.org/1135143004 Cr-Commit-Position: refs/heads/master@{#329876}
-
skyostil authored
The test is crashing flakily. BUG=488067 CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:linux_perf_bisect;tryserver.chromium.perf:mac_perf_bisect;tryserver.chromium.perf:win_perf_bisect;tryserver.chromium.perf:android_nexus5_perf_bisect NOTRY=true Review URL: https://codereview.chromium.org/1141863002 Cr-Commit-Position: refs/heads/master@{#329875}
-
tommycli authored
BUG=478309 Review URL: https://codereview.chromium.org/1140953003 Cr-Commit-Position: refs/heads/master@{#329874}
-
rdevlin.cronin authored
Adjust the strings in the extension message bubble to indicate which extension is overriding certain settings if it's not point to a specific one. If it is pointing to a specific one, use "This extension". BUG=485614 Review URL: https://codereview.chromium.org/1125403006 Cr-Commit-Position: refs/heads/master@{#329873}
-
skyostil authored
This test is consistently timing out on Android One. BUG=448092 CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:linux_perf_bisect;tryserver.chromium.perf:mac_perf_bisect;tryserver.chromium.perf:win_perf_bisect;tryserver.chromium.perf:android_nexus5_perf_bisect NOTRY=true Review URL: https://codereview.chromium.org/1141833002 Cr-Commit-Position: refs/heads/master@{#329872}
-
sbc authored
This is no longer needed as the underlying syscalls unlink/rmdir and both intercepted at the IRT level. I believe this was overlooked when we fixed: https://code.google.com/p/nativeclient/issues/detail?id=3709 This should fix the recent lua5.2 failures on the naclports waterfall. CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_nacl_sdk;tryserver.chromium.mac:mac_nacl_sdk;tryserver.chromium.win:win_nacl_sdk BUG=487701 Review URL: https://codereview.chromium.org/1136953014 Cr-Commit-Position: refs/heads/master@{#329871}
-
sohan.jyoti authored
Current interest/eventually/live rect is calculated based on max_tiles_for_interest_area setting which is not the best choice for determining the size. As part of this patch tiling interest rect is calculated based on viewport area. Which is multiplied by a constant factor. The factor is currently 9, viewport dist in all directions. Also, max_tiles_for_interest_area setting is removed and its associated switch and entries in chrome://flags. BUG=483520 Review URL: https://codereview.chromium.org/1126793002 Cr-Commit-Position: refs/heads/master@{#329870}
-
danakj authored
R=piman@chromium.org Review URL: https://codereview.chromium.org/1134783003 Cr-Commit-Position: refs/heads/master@{#329869}
-
antrim authored
BUG=484690,484734 R=nkostylev@chromium.org Review URL: https://codereview.chromium.org/1129293004 Cr-Commit-Position: refs/heads/master@{#329868}
-
nick authored
There is certainly a deeper issue here, but since I expect RenderFrameProxyHost::render_frame_host_ to be disappearing very soon, this small fix seems okay to suppress the crash. BUG=487406 Review URL: https://codereview.chromium.org/1134273002 Cr-Commit-Position: refs/heads/master@{#329867}
-
blink-deps-roller authored
Summary of changes available at: https://chromium.googlesource.com/chromium/blink/+log/6505e22..5b15054 TBR=jsbell@chromium.org,timvolodine@chromium.org Review URL: https://codereview.chromium.org/1145493002 Cr-Commit-Position: refs/heads/master@{#329866}
-
scheib authored
Removes need for allowing circular includes. Review URL: https://codereview.chromium.org/1123283007 Cr-Commit-Position: refs/heads/master@{#329865}
-
sky authored
Otherwise it exits before I've had a chance to attach the debugger. BUG=none TEST=none R=msw@chromium.org Review URL: https://codereview.chromium.org/1129233007 Cr-Commit-Position: refs/heads/master@{#329864}
-
lazyboy authored
Remove the old and disabled test. Previously we used to run the test partly in cpp and partly in JS. This CL changes the test code to run entirely in JS, requiring less context switches (== faster) and improving readability. BUG=248500, 160361 Test=None, no visible changes. Review URL: https://codereview.chromium.org/1144473003 Cr-Commit-Position: refs/heads/master@{#329863}
-
nednguyen authored
BUG=435757, 455391 CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:linux_perf_bisect;tryserver.chromium.perf:mac_perf_bisect;tryserver.chromium.perf:android_nexus5_perf_bisect Review URL: https://codereview.chromium.org/1142453002 Cr-Commit-Position: refs/heads/master@{#329862}
-
jeremyim authored
Currently, various methods related to marking proxies as bad in the ProxyList and ProxyService classes take a single ProxyServer for optionally marking an additional proxy as bad (i.e. ProxyList::UpdateRetryInfoOnFallback and ProxyService::MarkProxiesAsBadUntil). This is linked to fundamental assumptions in the Data Reduction Proxy that only two proxy servers are being used. As part of moving to a dynamic configuration, it is possible that more than 2 proxy servers could be used for the Data Reduction Proxy, so using a vector of ProxyServer objects makes more sense in the interface. BUG=470587 Review URL: https://codereview.chromium.org/1128823005 Cr-Commit-Position: refs/heads/master@{#329861}
-
qiankun.miao authored
-0 is treated as double 0.0f in V8. This makes GetAsInteger() return -0 is not an integer type. Extension APIs with integer parameters will fail to get the value using GetAsInteger(). This CL convert integer -0 to integer 0. BUG=471011 Review URL: https://codereview.chromium.org/1126983009 Cr-Commit-Position: refs/heads/master@{#329860}
-
radu.velea authored
Created an ETC1 encoder that uses SSE2 to improve compression speed. The SSE encoder extends TextureCompressor and uses the same algorithm as TextureCompressorETC1. Added unittest for TextureCompressorETC1. Moved shared code into a etc1 header. Added new performance test scenarios. Reland necessary for 32-bit GN issues. Performance difference on Ubuntu x64, Haswell Processor: Without SSE: *RESULT Compress256x256BlackAndWhiteGradientImage: ETC1 Low= 1.966321587562561 us *RESULT Compress256x256SolidBlackImage: ETC1 Low= .0956009104847908 us *RESULT Compress256x256SolidColorImage: ETC1 Low= .4367307722568512 us *RESULT Compress256x256RandomColorImage: ETC1 Low= 5.948055744171143 us With SSE: *RESULT Compress256x256BlackAndWhiteGradientImage: ETC1 Low= 1.0316201448440552 us *RESULT Compress256x256SolidBlackImage: ETC1 Low= .25716209411621094 us *RESULT Compress256x256SolidColorImage: ETC1 Low= .2768038809299469 us *RESULT Compress256x256RandomColorImage: ETC1 Low= 1.834145426750183 us BUG=434699 TEST=newly added unittest TextureCompressorETC1Test::Compress256x256CreateETC1, TextureCompressorETC1Test::Compress256x256RatioETC1 Committed: https://crrev.com/5f3849aa8307399b7e6dfe5665ed149594244077 Cr-Commit-Position: refs/heads/master@{#329840} Review URL: https://codereview.chromium.org/1096703002 Cr-Commit-Position: refs/heads/master@{#329859}
-
rdsmith authored
This is only done for main frame loads (so that it matches the behavior of Net.ErrorCodesForMainFrame3), and is done for the dominant errors seen in the wild. It also includes successful loads (for comparison) and all non-dominant errors in a final bucket (for completeness). BUG= 487663 R=mmenke@chromium.org R=jkarlin@chromium.org Review URL: https://codereview.chromium.org/1127383009 Cr-Commit-Position: refs/heads/master@{#329858}
-
rdsmith authored
BUG=487749 Review URL: https://codereview.chromium.org/1134353003 Cr-Commit-Position: refs/heads/master@{#329857}
-
reillyg authored
A number of browser and unit tests use mocks of the UsbService, UsbDevice and UsbDeviceHandle classes. This change de-duplicates them. Review URL: https://codereview.chromium.org/1144493003 Cr-Commit-Position: refs/heads/master@{#329856}
-
blink-deps-roller authored
Summary of changes available at: https://chromium.googlesource.com/chromium/blink/+log/9299220..6505e22 TBR=jsbell@chromium.org Review URL: https://codereview.chromium.org/1132453004 Cr-Commit-Position: refs/heads/master@{#329855}
-
skia-deps-roller authored
Summary of changes available at: https://chromium.googlesource.com/skia/+log/eea2ff7..7ae68a8 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel TBR=robertphillips@google.com Review URL: https://codereview.chromium.org/1145483002 Cr-Commit-Position: refs/heads/master@{#329854}
-
sky authored
The sequence leading to the crash is: . Enable sorting. . Have more than one selected row. . Remove one of the selected rows. The removed row must also contain the anchor. . Focus the table. The crash happened because we tried to get the view index for -1. In general the anchor shouldn't be -1 if there is at least one item in the selection. The only place anchor could be -1 and there is a selection is during removal. This patch fixes that. BUG=480296 TEST=covered by test now. R=sadrul@chromium.org Review URL: https://codereview.chromium.org/1129233006 Cr-Commit-Position: refs/heads/master@{#329853}
-
kenrb authored
In order to enable renderer processes to create SurfaceSequences, they have to receive Surface ID namespaces from the browser process so that they can avoid collisions. BUG=478802 Committed: https://crrev.com/c7a5afd66499fc8442e1b3146f55b227638934d8 Cr-Commit-Position: refs/heads/master@{#329708} Review URL: https://codereview.chromium.org/1129883003 Cr-Commit-Position: refs/heads/master@{#329852}
-
johnme authored
PushMessagingAppIdentifier currently generates app_id strings of the form: "wp:9CC55CCE-B8F9-4092-A364-3B0F73A3AB5F". This patch changes it to generate app_id strings of the form: "wp:https://foo.example.com:8443/#9CC55CCE-B8F9-4092-A364-3B0F73A3AB5F" BUG=458592,461867 Review URL: https://codereview.chromium.org/1141613003 Cr-Commit-Position: refs/heads/master@{#329851}
-
agrieve authored
Build rule is not hooked up to any targets yet, but will be used in a future commit to create split APKs. .gypi also forthcoming. BUG=447152 Review URL: https://codereview.chromium.org/1118403004 Cr-Commit-Position: refs/heads/master@{#329850}
-
avi authored
Revert of Ensure the new navigation classifier works in the real world. (patchset #1 id:1 of https://codereview.chromium.org/1136663004/) Reason for revert: Occasional crashes. Original issue's description: > Ensure the new navigation classifier works in the real world. > > BUG=369661 > TEST=No whammies! > > Committed: https://crrev.com/f97970c11c08a18e9ecea0b1b4c77122371a0e4f > Cr-Commit-Position: refs/heads/master@{#329497} TBR=creis@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=369661 Review URL: https://codereview.chromium.org/1140123002 Cr-Commit-Position: refs/heads/master@{#329849}
-
cmumford authored
This is the experimental IDBObjectStore.getAll implementation for retrieving multiple values in a single request as proposed in https://www.w3.org/2008/webapps/wiki/IndexedDatabaseFeatures In order to use run Chrome with: --enable-experimental-web-platform-features BUG=457450 Review URL: https://codereview.chromium.org/1074493002 Cr-Commit-Position: refs/heads/master@{#329848}
-
kpschoedel authored
BUG=487997 TBR=samuong@chromium.org Review URL: https://codereview.chromium.org/1137583003 Cr-Commit-Position: refs/heads/master@{#329847}
-
skyostil authored
This patch was mostly autogenerated with https://codereview.chromium.org/1010073002/. BUG=465354 Committed: https://crrev.com/adc9b4ed3d797c2990d682a3784d2e892198ce00 Cr-Commit-Position: refs/heads/master@{#329696} Review URL: https://codereview.chromium.org/1134113002 Cr-Commit-Position: refs/heads/master@{#329846}
-
sergeyv authored
Revert of Add ETC1 powered SSE encoder for tile texture compression (patchset #23 id:440001 of https://codereview.chromium.org/1096703002/) Reason for revert: Speculative revert. Looks like this change breaks compilation on win8 GN: http://build.chromium.org/p/chromium.win/builders/Win8%20GN Failure Example: http://build.chromium.org/p/chromium.win/builders/Win8%20GN/builds/7283 Original issue's description: > Add ETC1 powered SSE encoder for tile texture compression > > Created an ETC1 encoder that uses SSE2 to improve compression speed. > The SSE encoder extends TextureCompressor and uses the same algorithm as TextureCompressorETC1. > > Added unittest for TextureCompressorETC1. > > Moved shared code into a etc1 header. > > Added new performance test scenarios. > > Performance difference on Ubuntu x64, Haswell Processor: > Without SSE: > *RESULT Compress256x256BlackAndWhiteGradientImage: ETC1 Low= 1.966321587562561 us > *RESULT Compress256x256SolidBlackImage: ETC1 Low= .0956009104847908 us > *RESULT Compress256x256SolidColorImage: ETC1 Low= .4367307722568512 us > *RESULT Compress256x256RandomColorImage: ETC1 Low= 5.948055744171143 us > > With SSE: > *RESULT Compress256x256BlackAndWhiteGradientImage: ETC1 Low= 1.0316201448440552 us > *RESULT Compress256x256SolidBlackImage: ETC1 Low= .25716209411621094 us > *RESULT Compress256x256SolidColorImage: ETC1 Low= .2768038809299469 us > *RESULT Compress256x256RandomColorImage: ETC1 Low= 1.834145426750183 us > > BUG=434699 > TEST=newly added unittest TextureCompressorETC1Test::Compress256x256CreateETC1, TextureCompressorETC1Test::Compress256x256RatioETC1 > > Committed: https://crrev.com/5f3849aa8307399b7e6dfe5665ed149594244077 > Cr-Commit-Position: refs/heads/master@{#329840} TBR=reveman@chromium.org,christiank@opera.com,jie.a.chen@intel.com,robert.bradford@intel.com,radu.velea@intel.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=434699 Review URL: https://codereview.chromium.org/1136083003 Cr-Commit-Position: refs/heads/master@{#329845}
-
agrieve authored
There's a TODO for using split-select, but it won't be necessary until we have resource splits being generated. BUG=447152 Review URL: https://codereview.chromium.org/1134353002 Cr-Commit-Position: refs/heads/master@{#329844}
-
skia-deps-roller authored
Summary of changes available at: https://chromium.googlesource.com/skia/+log/c30806f..eea2ff7 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel TBR=robertphillips@google.com Review URL: https://codereview.chromium.org/1136393004 Cr-Commit-Position: refs/heads/master@{#329843}
-
blink-deps-roller authored
Summary of changes available at: https://chromium.googlesource.com/chromium/blink/+log/33861c9..9299220 TBR=jsbell@chromium.org Review URL: https://codereview.chromium.org/1141823002 Cr-Commit-Position: refs/heads/master@{#329842}
-
reed authored
see https://codereview.chromium.org/1140943004/ BUG= NOTRY=True just adds a new flag for future cls Review URL: https://codereview.chromium.org/1133403003 Cr-Commit-Position: refs/heads/master@{#329841}
-
radu.velea authored
Created an ETC1 encoder that uses SSE2 to improve compression speed. The SSE encoder extends TextureCompressor and uses the same algorithm as TextureCompressorETC1. Added unittest for TextureCompressorETC1. Moved shared code into a etc1 header. Added new performance test scenarios. Performance difference on Ubuntu x64, Haswell Processor: Without SSE: *RESULT Compress256x256BlackAndWhiteGradientImage: ETC1 Low= 1.966321587562561 us *RESULT Compress256x256SolidBlackImage: ETC1 Low= .0956009104847908 us *RESULT Compress256x256SolidColorImage: ETC1 Low= .4367307722568512 us *RESULT Compress256x256RandomColorImage: ETC1 Low= 5.948055744171143 us With SSE: *RESULT Compress256x256BlackAndWhiteGradientImage: ETC1 Low= 1.0316201448440552 us *RESULT Compress256x256SolidBlackImage: ETC1 Low= .25716209411621094 us *RESULT Compress256x256SolidColorImage: ETC1 Low= .2768038809299469 us *RESULT Compress256x256RandomColorImage: ETC1 Low= 1.834145426750183 us BUG=434699 TEST=newly added unittest TextureCompressorETC1Test::Compress256x256CreateETC1, TextureCompressorETC1Test::Compress256x256RatioETC1 Review URL: https://codereview.chromium.org/1096703002 Cr-Commit-Position: refs/heads/master@{#329840}
-
tommi authored
WebRTC 9187:9189 Changes: https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git/+log/65d8695..872cf25 TBR=sergeyu@chromium.org Review URL: https://codereview.chromium.org/1136483003 Cr-Commit-Position: refs/heads/master@{#329839}
-
jchuang authored
Calculates per-frame encode latency, which is basically the time delay from input of each VideoFrame (VEA::Encode()) to output of the corresponding BitstreamBuffer (VEA::Client::BitstreamBufferReady()). It calculates encode latency values at the 50th(median), 75th, and 95th percentiles. Also fix a wrong comment. BUG=345181 TEST=Check "Encode latency for the 50%/75%/95%" in output logs. Committed: https://crrev.com/b21ffeee2aff4da8edb9808b2227165c37e5ce86 Cr-Commit-Position: refs/heads/master@{#329819} Review URL: https://codereview.chromium.org/1117853002 Cr-Commit-Position: refs/heads/master@{#329838}
-
sacomoto authored
The current version does not handle messages larger than a single characteristic size (around 150 bytes). Message receiving functionality is not implemented yet. BUG=485123 Review URL: https://codereview.chromium.org/1116963002 Cr-Commit-Position: refs/heads/master@{#329837}
-