Skip to content

GitLab

T
tangled
Switch branch/tag
  1. 28 Jan, 2016 25 commits
  3. 27 Jan, 2016 15 commits
    • jbudorick's avatar
      Make content_gpu.gypi depend on content_common_mojo_bindings in gyp. · 12556951
      jbudorick authored 
      mirroring https://code.google.com/p/chromium/codesearch#chromium/src/content/gpu/BUILD.gn&l=53

BUG=581707
NOTRY=true
NOTREECHECKS=true
TBR=jam@chromium.org

Review URL: https://codereview.chromium.org/1648503002

Cr-Commit-Position: refs/heads/master@{#371910}
      12556951
    • yoav's avatar
      Fix an outdated picture removal test and comment · 605adccc
      yoav authored 
      One of the Client Hints tests contained an outdated comment about mutation
related issue that was since solved, as well as a workaround for that issue.

This CL removes the comment and makes sure that the test doesn't work around
that no-longer-relevant bug.

BUG=

Review URL: https://codereview.chromium.org/1644503002

Cr-Commit-Position: refs/heads/master@{#371909}
      605adccc
    • xunjieli's avatar
      Convert CookieMonster tests to use base::RunLoop · b2bec813
      xunjieli authored 
      CookieMonster tests post a
base::MessageLoop::QuitWhenIdleClosure task which
could be run at the start of some other test, since
the unit tests are invoked in the same fixture on
Android. This CL converts these CookieMonster tests
to use base::RunLoop so they don't influence other
tests.

BUG=568282

Review URL: https://codereview.chromium.org/1634803004

Cr-Commit-Position: refs/heads/master@{#371908}
      b2bec813
    • anthonyvd's avatar
      Implement the new Sync Confirmation dialog on Linux and Windows. · 72d9ed4e
      anthonyvd authored 
      This CL mostly implements the sync confirmation dialog that is shown at
the end of the tab modal signin flow described in the associated bug. It
allows the user to make an explicit decision about starting sync before
it's started and before sign in is completed.

TEST=
1. Enable the --enable-password-separated-signin-flow flag in
   chrome://flags and restart Chrome
2. In a non-signed in Chrome Profile, select "Sign in to Chrome" from
   the User Menu.
3. Enter valid credentials to sign in to Chrome, the sign in window
   should close and the sync confirmation window should be shown
4. From that window, clicking "Got it" should close the window and leave
   the user signed in with sync started. Clicking "Undo" should close
   the window and leave the user signed out with sync not started.

BUG=533004

Review URL: https://codereview.chromium.org/1487283005

Cr-Commit-Position: refs/heads/master@{#371907}
      72d9ed4e
    • estade's avatar
      [MD] Remove new incognito styling from guest mode. · 1257c400
      estade authored 
      Profile::IsOffTheRecord() surprisingly does not imply incognito; it also covers guest profiles.

BUG=none

Review URL: https://codereview.chromium.org/1638063003

Cr-Commit-Position: refs/heads/master@{#371906}
      1257c400
    • robertphillips's avatar
      Disable deprecated Skia xfermodes · 583be684
      robertphillips authored 
      This is a companion to https://codereview.chromium.org/1645633003/ (Hide SkPixelXorXfermode from Chrome)

Review URL: https://codereview.chromium.org/1644703002

Cr-Commit-Position: refs/heads/master@{#371905}
      583be684
    • estade's avatar
      Fix bug in browser action icon scaling for non-1x scale factors. · 52969d73
      estade authored 
      skia::ImageOperations::Resize needs pixels, and we were passing dp.

Also, ignore the icon size key and just use the icon size itself. This fixes a bug (evidenced again by Shoptagr) where an icon size such as

"19": "icons/19.png"  // 19.png is actually 50x50

would be scaled incorrectly. At this point, the API should take a list rather than a dict, but it's probably not possible to change that and maintain backcompat.

BUG=581232
TBR=benwells@chromium.org

Review URL: https://codereview.chromium.org/1637763002

Cr-Commit-Position: refs/heads/master@{#371904}
      52969d73
    • bnc's avatar
      Disable Alt-Svc in Crnet. · 44f9260b
      bnc authored 
      Alt-Svc is currently disabled in Cronet (in
components/cronet/android/*url_request_context_adapter.cc), until this feature
is thorougly tested in Chromium.  It should also be disabled in Crnet.

Review URL: https://codereview.chromium.org/1643463004

Cr-Commit-Position: refs/heads/master@{#371903}
      44f9260b
    • catapult-deps-roller's avatar
      Roll src/third_party/catapult/ fd3f2b38d..8283c4a90 (3 commits). · da4f79fe
      catapult-deps-roller authored 
      https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/fd3f2b38d1fb..8283c4a90352

$ git log fd3f2b38d..8283c4a90 --date=short --no-merges --format='%ad %ae %s'

CQ_INCLUDE_TRYBOTS=
TBR=catapult-sheriff@chromium.org

Review URL: https://codereview.chromium.org/1641773003

Cr-Commit-Position: refs/heads/master@{#371902}
      da4f79fe
    • mfomitchev's avatar
      Revert of Aura on Android: Fix link errors when building... · 3a9223ba
      mfomitchev authored 
      Revert of Aura on Android: Fix link errors when building content_unittests_apk. (patchset #1 id:1 of https://codereview.chromium.org/1466463004/ )

Reason for revert:
Reverting, since Android Aura has been cancelled

Original issue's description:
> Aura on Android: Fix link errors when building content_unittests_apk.
>
> * Do ui::RegisterUIAndroidJni() only when not using Aura.
> * Exclude desktop_aura from the build.
>
> BUG=507792
>
> Committed: https://crrev.com/ce62351f189643118e9d09bf06e128b75345ef36
> Cr-Commit-Position: refs/heads/master@{#360942}

TBR=sievers@chromium.org,sadrul@chromium.org,bshe@chromium.org,moshayedi@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=507792

Review URL: https://codereview.chromium.org/1647663002

Cr-Commit-Position: refs/heads/master@{#371901}
      3a9223ba
    • skia-deps-roller's avatar
      Roll src/third_party/skia/ 2bbc343c1..9ce4110a2 (7 commits). · cd843581
      skia-deps-roller authored 
      https://chromium.googlesource.com/skia.git/+log/2bbc343c1482..9ce4110a29b0

$ git log 2bbc343c1..9ce4110a2 --date=short --no-merges --format='%ad %ae %s'
2016-01-27 jcgregorio skiaserve: Enable /cmd endpoint.
2016-01-27 msarett Revert of Consolidate SkStream copying methods (patchset #1 id:1 of https://codereview.chromium.org/1640793002/ )
2016-01-27 msarett Suppress jpeg valgrind errors
2016-01-27 jcgregorio skiaserve: Set 303 status code on redirect.
2016-01-27 kjlubick Make fuzz output the words success for a 'clean exit'
2016-01-27 joshualitt Wire up JsonCanvas in skiaserve
2016-01-27 scroggo Consolidate SkStream copying methods

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=msarett@google.com

Review URL: https://codereview.chromium.org/1643743002

Cr-Commit-Position: refs/heads/master@{#371900}
      cd843581
    • ianwen's avatar
      Introduce Queue-Based Notification Snackbars · d117eb1c
      ianwen authored 
      Notification snackbars are low-priority snackbars that are stored in a
queue, contrary to tranditional "action" snackbars that ought to be
shown immediately and are stored in a stack.

When a queue snackbar is showing, a stack snackbar can always kick in
and override the snackbar; however when a stack snackbar is showing, a
queue snackbar will wait till the stack is cleared.

Queue snackbars are not dismissed in batch; instead, they will be shown
one by one, in FIFO order.

BUG=579347

Review URL: https://codereview.chromium.org/1635753002

Cr-Commit-Position: refs/heads/master@{#371899}
      d117eb1c
    • stanisc's avatar
      Reuse GLFenceNV when an existing CommandsCompletedQuery is reused · 1f3c2431
      stanisc authored 
      This is a first part of the fix for 573120. When Begin/End
are called again for a completed query that already has an
instance of GLFenceNV, the existing GLFenceNV instance is
reused rather than creating a new one.
For each frame that saves one call to glGenFencesNV and
one call to glDeleteFencesNV .
My estimation is that that saves about 0.2 Wt when playing
1080p @ 60Hz h.264 content.

The second part of the fix will add reusing instances of
CommandsCompletedQuery.

BUG=573120

Review URL: https://codereview.chromium.org/1637293002

Cr-Commit-Position: refs/heads/master@{#371898}
      1f3c2431
    • kcarattini's avatar
      Remove unused foreground member variable from SB Protocol Manager. · ab09c809
      kcarattini authored 
      BUG=543161,561867

Review URL: https://codereview.chromium.org/1640503003

Cr-Commit-Position: refs/heads/master@{#371897}
      ab09c809
    • lukasza's avatar
      OOPIF support for testRunner.dumpAsText and similar layout dumps. · a8960461
      lukasza authored 
      Layout Tests dump page contents (to compare against expected results).
The dump can include frame contents (i.e. dump as text, dump as markup,
dump scroll positions with extra flavors like dump as printed, dump line
box trees, etc.).  Since renderer process is (for security / by design)
not able to see frame contents of remote frames, it means that old
Layout Tests code is not able to dump frame contents when site isolation
is enabled (i.e. when running with --additional-drt-flag=--site-per-process).

This CL is a step toward making layout tests compatible with site
isolation.  After this CL, if recursing over all frames is required,
then BlinkTestRunner::CaptureDump will ask the browser process for
stiching together the frame contents, before continuing with the other
dump flavors in BlinkTestRunner::OnLayoutDumpCompleted.

The above means testRunner.notifyDone() might no longer perform dumps
synchronously.  This is okay, because:

  - The dumps were already performed asynchronously in some cases:
    - pixel dumps (i.e. see how dumping is resumed after
      BlinkTestRunner::CaptureDumpPixels aka OnPixelsDumpCompleted),
    - ShouldDumpBackForwardList (i.e. see how dumping is resumed after
      BlinkTestRunner::OnSessionHistory),
    - the case where notifyDone is called from a secondary window (i.e.
      see how BlinkTestRunner::TestFinished asks the browser to continue
      in the main window).

  - The synchronous dumps are still performed if the test didn't ask for
    recursing over all the frames.  Retaining the synchronous behavior
    in this case is needed, because in some tests the dump is captured
    while the frame is being detached (and would no longer be present
    after an extra hop to the browser process).

This CL doesn't affect the following dump modes (which for now remain
potentially incompatible with OOPIFs): dump as audio, dump as custom
text, dump pixels, dump back/forward list).  Additionally, setting and
reading of dump modes is done in a renderer process (which can be
incompatible with OOPIFs when testRunner.dumpAsText() and
testRunner.notifyDone() are called in cross-site frames running in
different renderer processes).

BUG=477150
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review URL: https://codereview.chromium.org/1589643003

Cr-Commit-Position: refs/heads/master@{#371896}
      a8960461