- 26 Sep, 2019 40 commits
-
-
Yuly Novikov authored
Pixel_Video_BackdropFilter on GL and Vulkan Pixel_Video_Context_Loss_VP9 on GL - already suppressed on Vulkan, but maybe for a different reason TBR=jonross Bug: 1008450, 1008456 Change-Id: I89c211af2efcaaf05cb7a5dbd0c50b485a1f9321 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827820Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Reviewed-by:
Jonathan Ross <jonross@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#700373}
-
Chris Harrelson authored
This code is not used now that BlinkGenPropertyTrees has launched. Bug: 993936,1008483 Change-Id: Ia253725e327c5d115c95e341f7791539e881cc9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817318 Auto-Submit: Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#700372}
-
Joey Arhar authored
Screenshot: https://imgur.com/UiJ8BhH Change-Id: I0a9b9440073b864516723400ebe73ca3d2c71f11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1799700 Commit-Queue: Joey Arhar <jarhar@chromium.org> Reviewed-by:
Erik Luo <luoe@chromium.org> Cr-Commit-Position: refs/heads/master@{#700371}
-
Yves Arrouye authored
This will be helpful e.g. when trying to match logs with behavior as reported e.g. in crbug.com/1002617 (where logs don't match with the customer story but we can't be 100% sure). We log usin LOG(WARNING) as we expect the first auth to work, so this is an exceptional condition. Bug: chromium:1002617 Test: N/A Change-Id: I4366445f9691e527218b907c5ce1debd19f37aa5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827937 Commit-Queue: Pavol Marko <pmarko@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Auto-Submit: Yves Arrouye <drcrash@chromium.org> Cr-Commit-Position: refs/heads/master@{#700370}
-
David Maunder authored
This component aggregates client side tab suggestions for closing tabs. Bug: 1005385 Change-Id: I797b983737441edd4f8e1a155ea94708219765c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1811717 Commit-Queue: David Maunder <davidjm@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Cr-Commit-Position: refs/heads/master@{#700369}
-
Shimi Zhang authored
See the corresponding AndroidX change: http://aosp/1099421 Bug: 918065 Change-Id: Iad8cd0cd273235de1105f04844891494f793af1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1745462 Commit-Queue: Shimi Zhang <ctzsm@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Cr-Commit-Position: refs/heads/master@{#700368}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/30d3c8afe19c..072466ad1fab git log 30d3c8afe19c..072466ad1fab --date=short --no-merges --format='%ad %ae %s' 2019-09-26 amaiorano@google.com Add swiftshader_optimized_debug_build gn arg Created with: gclient setdep -r src/third_party/swiftshader@072466ad1fab If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@google.com Bug: chromium:b/140251624 Change-Id: Ife341a8079ea5e736765c517f62b145ebcdcca3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827486Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#700367}
-
Moe Ahmadi authored
This method is almost identical to HistoryService::DeleteURL and nothing about it makes it suitable for testing only. Change-Id: I5516c6fb514b72b9fb22f7b9cba34fdaf6001b00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825466Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#700366}
-
Joey Arhar authored
This fixes a small issue where blocked request cookies aren't shown if there were no request cookies in the first place. It also fixes a spacing issue with the list of cookies in "Malformed Response Cookies" Screenshots before: https://imgur.com/SeCHwKm Screenshots after: https://imgur.com/M3NKlqQ Bug: 856777 Change-Id: I1a2039b535869f16280fd74a9ba7f1dfcdced160 Change-Id: I165ac29eaafb8a74c3483238bd42c5aca1e91555 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795316 Commit-Queue: Joey Arhar <jarhar@chromium.org> Reviewed-by:
-
Lukasz Anforowicz authored
After https://crrev.com/c/1776854 the extension-related browser-side checks should be a superset of renderer-side checks and we should be able to start removing extension-related renderer-side checks like ShouldFork. Bug: 1003957, 883549 Change-Id: I2954ab641b8234c2b3b18db69bf04caae437e989 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809814Reviewed-by:
Egor Pasko <pasko@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#700364}
-
Alex Keng authored
This change updates the SVGs (used by <color>) to use system colors so it render correctly in high contrast mode. Test: web_tests/fast/forms/controls-new-ui-high-contrast/color-picker.html Bug: 994219 Change-Id: Ia2d597cd8016a79afe2a72f50a518099e531f4bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1826290 Commit-Queue: Alex Keng <shihken@microsoft.com> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#700363}
-
Xiaoqian Dai authored
|window_values| is not needed for kDragWindowToHomeOrOverview case. Bug: 997885 Change-Id: I950d62a53421ccf91c20d73c54c76c71689fbeff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825479 Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#700362}
-
Mark Pearson authored
TBR=isherman Change-Id: Ie1a9cb60a136b93c9f22c67fec8d538c69962b91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827676 Commit-Queue: Mark Pearson <mpearson@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#700361}
-
Bin Du authored
Record thread types of ThreadPool* threads using the newly added THREAD_POOL_THREAD enum type, GpuMemory* threads using the newly added GPU_MEMORY_THREAD enum type, and Compositor/[0-9]+ thread using the existing COMPOSITOR_THREAD. BUG=b:130928904 Change-Id: I2f39cb84ee73658c84185d1e0b2e3513edb014d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816302 Commit-Queue: Bin Du <dubin@google.com> Reviewed-by:
Gabriel Marin <gmx@chromium.org> Cr-Commit-Position: refs/heads/master@{#700360}
-
Kurt Horimoto authored
- Move ivar underscores from suffix to prefix. - Move protocol declarations to .mm file. - Move ivars to properties where appropriate. - Reorder code in .mm to match protocol declaration order and added pragmas. Bug: none Change-Id: I47eddb9ad8669dd6f6d68da867d8e136c913c2dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824294 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#700359}
-
Christopher Grant authored
This reverts commit 7ca339e3. Reason for revert: Broke test targets in some builds. https://build.chromium.org/p/chromium.android/builders/Android%20arm64%20Builder%20%28dbg%29/builds/39819 Original change's description: > Modules: Introduce a generic DFM native library loading system > > DFMs that include both Java and native code will probably use JNI. This > change introduces a reusable mechanism to load the native library and > register its JNI methods. > > Key points: > > - There are 3 build variants supported: > 1. Production builds with lld-generated partitions. > 2. Component build (with feature code in a component). > 3. Fallback release build (feature code in the main library) > > - For consistency, explicit JNI registration is done in both > ChromeModern and Monochrome. > > - The Test Dummy module is moved over to use this new system. VR will > join the fun in a follow-on change. > > - Currently, modules must supply an explicit JNI registration method. > Common code will locate this method and call it, at the appropriate > time, on behalf of the module. > > Bug: 870055 > Change-Id: Id400ff00b4be65f71536a4acffdfcf93cc3bea58 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1822846 > Commit-Queue: Christopher Grant <cjgrant@chromium.org> > Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org> > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Cr-Commit-Position: refs/heads/master@{#700276} TBR=cjgrant@chromium.org,agrieve@chromium.org,tiborg@chromium.org Change-Id: Ia5f504c0da25c85805a8521991c6eed8eac15267 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 870055 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827245Reviewed-by:
Christopher Grant <cjgrant@chromium.org> Commit-Queue: Christopher Grant <cjgrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#700358}
-
John Lee authored
This CL copies over a SVG version of the tab alert indicator icons from /src/chrome/app/vector_icons/ and creates a custom element to display them. The icon dimensions have been customized for the WebUI version of the tab stirp and may change. The animations have been made to act as similar as possible with the existing implementations. Although the back-end has not yet been provided, this CL assumes there will be some mapping of TabAlertState to string, a string that will be used to update the |alert-state| property of the custom element. Note: this CL does not add theme colors for all icons (for example, the recording alert should display in red). https://i.imgur.com/dq2SARY.png Bug: 1004983 Change-Id: Ie0c20ae165bae935de1b21241815f7221351764a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825793Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#700357}
-
Jesse McKenna authored
The StackSamplingProfiler has been observed to cause crashes when running under Application Verifier, a Windows utility used to detect subtle programming errors. Samples collected by the StackSamplingProfiler while Application Verifier is running are unlikely to hold any value, as Application Verifier slows down execution significantly. Because StackSamplingProfiler and Application Verifier are not compatible, this change detects whether Application Verifier is running, and does not start up StackSamplingProfiler if so. This is not expected to impact data collection, as Application Verifier is used only by a few developers. Bug: 1004989 Change-Id: I014b3cee440e99d832ae8d84a03fe70777676a2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783735 Commit-Queue: Jesse McKenna <jessemckenna@google.com> Reviewed-by:
Mike Wittman <wittman@chromium.org> Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#700356}
-
Mohammad Refaat authored
Change RequestContextGetter to use CookieStoreIOS for web_view and for web shell. This is needed so i can remove NSHTTPCookieStorage and CookieStoreIOSPersistent and also to remove CookieMonster entirely from Chrome for iOS Bug: 989554 Change-Id: I2e2bf61a6638b47796c90c7012d1ac689960316e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1822418 Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> Reviewed-by:
Hiroshi Ichikawa <ichikawa@chromium.org> Reviewed-by:
-
Ionel Popescu authored
This change extends the key options used to open the date related pickers to also include Enter and Space. This behavior is aligned with opening the select, color popup. Tests were added to validate opening the popup with Enter/Space. Bug: 1004997 Change-Id: If61ba755aef5436d705cb3c3c28f1ebb0c787059 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825935Reviewed-by:
-
Ionel Popescu authored
This CL introduces popup support for input type="time" by adding a time picker. DateTimeFieldType is introduced and DateTimeFieldElement is plumbed to containd the field type in order to inform the time popup which fields are shown in the in-page control as the popup columns should match the fields. The popup functionality is present in time_picker.js and the style in time_picker.css Test have been added to validate the new popup UI, but more tests are going to be added with further CLs that are going to extend the functionality of the popup. The following CLs are: AM/PM support, keyboard navigation, step attribute support, infinite scroll. Bug: 1004997 Change-Id: Iaeb49fe684c3be6df920ae228668dc1430fa9aca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817346Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/197c3c97970b..da7bc7fa532d Created with: gclient setdep -r src-internal@da7bc7fa532d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I13d0d55f2c6fe5381eafae0808245d340da72ce6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827479Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#700352}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/3ef6d975b402..a7f82b08de68 git log 3ef6d975b402..a7f82b08de68 --date=short --no-merges --format='%ad %ae %s' 2019-09-26 jrosenth@chromium.org gob_util: Don't use message attribute on exceptions 2019-09-26 lamontjones@chromium.org SigningTests: signer source has finished moving. 2019-09-26 vapier@chromium.org commandline: rework _ShutDownException message 2019-09-26 vapier@chromium.org run_tests: add framework for running unittests under py2 & py3 2019-09-26 frankbozar@google.com cros_flash: Use oflag=direct in dd for better performance 2019-09-26 vapier@chromium.org osutils: drop MountImagePartition 2019-09-26 vapier@chromium.org osutils: drop unused MountImageContext 2019-09-26 vapier@chromium.org cros_event: rework Failure message 2019-09-26 tcwang@google.com afdo: Fix CWP regex for kernel profiles. 2019-09-26 saklein@chromium.org Build API: Add goma config to build chrome. 2019-09-26 saklein@chromium.org service/artifacts: Strip down images being archived by default. 2019-09-26 saklein@chromium.org chroot_lib: Remove CamelCase variant of get_enter_args. 2019-09-26 yshaul@google.com Move LKGM update logic to master-release builder 2019-09-25 mikenichols@chromium.org chromeos_config: Move veyron_mighty to experimental 2019-09-25 lamontjones@chromium.org cbuildbot/commands: fix typo Created with: gclient setdep -r src/third_party/chromite@a7f82b08de68 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I4b582d8d1803dc36e6c4d5b6268588df3af4aecb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827640Reviewed-by:
-
Eric Stevenson authored
This CL was generated by //base/android/jni_generator/jni_refactorer.py. //net/android/java/src/org/chromium/net/HttpNegotiateAuthenticator.java was omitted from this CL as it requires additional test refactoring before being converted to use @NativeMethods. Bug: 929661 Change-Id: I9bb82694017f792e59a488eb400173da515c3374 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809397Reviewed-by:
Paul Jensen <pauljensen@chromium.org> Commit-Queue: Eric Stevenson <estevenson@chromium.org> Auto-Submit: Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#700350}
-
Boris Sazonov authored
SigninManager should always use application context, thus there's no need to pass it to the ctor and ContextUtils.getApplicationContext can be used instead. Bug: 1007415 Change-Id: I8688889d52c71658183c7a4d32d36b7cf1378811 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1823197 Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Auto-Submit: Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Pâris Meuleman <pmeuleman@chromium.org> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#700349}
-
Tomasz Wiszkowski authored
Change-Id: I453ca43a33a0f37a0418d7d653f59c445154618b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825123Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Ender <ender@google.com> Cr-Commit-Position: refs/heads/master@{#700348}
-
Raul Tambre authored
Initial conversion performed using '2to3 -f print .'. Imports added and duplicate parentheses removed manually. Manually converted files, comments and inline code that 2to3 missed. Afterwards ran "git cl format --python" and cherry-picked the formatting changes. There are no intended behavioural changes. Bug: 941669 Change-Id: Ia6b0f45b817a3eaeaa8a796f885d99a06513e6f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1818480 Commit-Queue: Raul Tambre <raul@tambre.ee> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Auto-Submit: Raul Tambre <raul@tambre.ee> Cr-Commit-Position: refs/heads/master@{#700347}
-
Garrett Beaty authored
Change-Id: I9e5c5c12bc4c37d1aded50a8c230c1db3fca2587 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815458 Auto-Submit: Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Commit-Queue: Garrett Beaty <gbeaty@chromium.org> Cr-Commit-Position: refs/heads/master@{#700346}
-
Elly Fong-Jones authored
Previously initial focus in this dialog was the source list itself, which was weird - the source list was focusable but had no keyboard behavior or focus ring. An earlier change (28f16f08) made it unfocusable but left it as the initial focus view. When the initial focus view is unfocusable, Widget::SetInitialFocus does not activate the widget at all, which left it unusable with the keyboard. Oops! This change drops initial focus on the dialog's cancel button. In principle it would be nicer to drop focus on the first source in the list, except that: 1) These lists are constructed asynchronously after the dialog appears so that view is not yet present when GetInitiallyFocusedView is called, and 2) Focusing one of the source views serves to select it, which would be surprising Failing that it would be nice to use the dialog's default button, but the default button is OK, and the OK button is disabled until the user selects a source. We could change the default button to be Cancel but on Mac Cancel cannot be the default button :(. As a result, this change uses the Cancel button as the initially focused view but leaves Ok as the default button. Bug: 1007174 Change-Id: Ibc435b830394895551c99fd0fb4172729d981547 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825321 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#700345}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/39d142e89afb..2bdefbf8162d git log 39d142e89afb..2bdefbf8162d --date=short --no-merges --format='%ad %ae %s' 2019-09-26 jmadill@chromium.org Vulkan: Remove some redundant "vk" prefixes. Created with: gclient setdep -r src/third_party/angle@2bdefbf8162d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ynovikov@google.com Bug: None Change-Id: Ifcfd393254e031c68af5676e8a7b47d32bc67cc2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827480Reviewed-by:
-
Nate Fischer authored
This extends cts_config/README.md to clarify how to re-enable skipped tests. This also updates some markdown formatting errors I observed. Bug: 918221, 765873 Test: tools/md_browser/md_browser.py Test: Upload to gerrit > open file > click "gitiles" Change-Id: I1c11dc14c3b83b9a56b190e6ced9cb629b7a54cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825925 Commit-Queue: Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Andrew Luo <aluo@chromium.org> Cr-Commit-Position: refs/heads/master@{#700343}
-
Etienne Bergeron authored
This CL is adding a fuzzer for RenderText. The current fuzzer only call SetText(...) and perform the layout. This will give better coverage on 1) TextItemize(...) * Splitting text into runs. Rely on third_party/icu. 2) ShapeRuns(...) * Shape runs by finding fonts/glyphs Rely on DWrite, FontConfig, etc.. 3) GetFallbackFont(...) * Find a fallback font for a sequence of codepoint Rely on DWrite, FontConfig, etc.. R=robliao@chromium.org CC=etiennep@chromium.org Change-Id: Id6917e6b65c33be228b38705904134bc6cdbeb39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1826142 Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Reviewed-by:Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#700342}
-
Manu Cornet authored
Whether the home screen is available is strictly equivalent to whether tablet mode is on. I understand the desire for the extra level of indirection but it doesn't seem like this is changing anytime soon, and if/when it does, it won't be hard to re-add :-) In the mean time, I think we should favor readability / understandability. Bug: 982512 Change-Id: Ifb34f316ae0fe579ee2854b70025a0b2de216d93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1826198Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Reviewed-by:
-
Alex Cooper authored
Bump flags from 79->82, except for webvr which is updated to 80 since it is intended to be removed then. Bug: 1007559 Change-Id: I543d1f2ee7228b9f303089c4934adae1e41ad4a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824026 Auto-Submit: Alexander Cooper <alcooper@chromium.org> Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#700340}
-
Javier Ernesto Flores Robles authored
Fixes stop and start. Resetting now will stop the children. Updates tests to also verify the children are reset. Bug: 1007257, 1007928 Change-Id: I19f24fbf8d0bf3f5e761d394e1a357544bd9752f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1821905 Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#700339}
-
Clark DuVall authored
We were including build config and android support library files in the weblayer aar. We really only want to include the weblayer files in the aar, since the app including it will provide the support library and other things we need. This adds arguments to the dist_aar rule to filter what goes into the jar files, similar to other java rules. Change-Id: Id5393d06dac8b0d957469a3279c74199088f3732 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825567 Commit-Queue: Clark DuVall <cduvall@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
-
Sanket Joshi authored
Users should be able to change the active color format in the color picker via the keyboard. With this CL, users can press the down arrow or space to select the next color format. Users can also press the up arrow to select the previous color format. Bug: 1007048 Change-Id: Id12ef30d80cbc7f56e029847d29d8bcf33f1b8cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819840Reviewed-by:
-
Peter Boström authored
TabStrip doesn't semantically need to be a ContextMenuController, this hides that implementation detail as a nested class. Bug: None Change-Id: I2e46adbea0689300c964c8b8ceac3fe9ec12ee6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825789 Auto-Submit: Peter Boström <pbos@chromium.org> Commit-Queue: Taylor Bergquist <tbergquist@chromium.org> Reviewed-by:
Taylor Bergquist <tbergquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#700336}
-
Aran Gilman authored
It is unclear whether caching the settings improved performance. The performance regression resolved before the CL adding the caches landed, and there was no significant improvement to performance once the CL did land. However, it did make the code less clear and introduced greater potential for bugs (e.g. https://crbug.com/1002664). Bug: 991838 Change-Id: Ia67a693596ead2a3b392b6e1835e0a2963f47d84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1822477Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Aran Gilman <gilmanmh@google.com> Cr-Commit-Position: refs/heads/master@{#700335}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/403f2955e7f6..49c073257022 git log 403f2955e7f6..49c073257022 --date=short --no-merges --format='%ad %ae %s' 2019-09-26 fmalita@chromium.org [skottie] Add null sink option for skottie_tool 2019-09-26 herb@google.com Restrict SkStrikeInterface to GPU and rename to SkStrikeForGPU 2019-09-26 ethannicholas@google.com Revert "remove 'in uniform' support from GrSkSLFP, make rules more clear" 2019-09-26 fmalita@chromium.org [skottie] Minor MotionBlurEffect cleanup 2019-09-26 herb@google.com Blur both in x and y 2019-09-26 ethannicholas@google.com remove 'in uniform' support from GrSkSLFP, make rules more clear Created with: gclient setdep -r src/third_party/skia@49c073257022 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC bungeman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=bungeman@google.com Bug: None Change-Id: Id51f18a999186e37e291531f62dee43ac88bacba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827718Reviewed-by:
-
