GitLab

This also rolls custom-tabs-client, including the following changes
(only the most recent is directly depended upon):

https://chromium-review.googlesource.com/c/custom-tabs-client/+/1028234
https://chromium-review.googlesource.com/c/custom-tabs-client/+/1063970
https://chromium-review.googlesource.com/c/custom-tabs-client/+/1065875

Bug: 816798
Change-Id: I3ec9bdcb658af5a30ea8d09f5603b56441f7f367
Reviewed-on: https://chromium-review.googlesource.com/1064236
Commit-Queue: Peter Conn <peconn@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560255}

This will be necessary in order to properly use temporal and spatial
scalability in hardware accelerated video codecs.

Bug: chromium:794608
Change-Id: I029e044a33c95eb4bcc9db04b028d04a3cb7f922
Reviewed-on: https://chromium-review.googlesource.com/1016900
Commit-Queue: Erik Språng <sprang@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Emircan Uysaler <emircan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560254}

I was curious about the cost of locking in TaskQueueImpl and realised
we don't have coverage for non-delayed PostTask so I added one.

Change-Id: I765f3d4316e9e6c7bac01d7b2f3a1d02188a2185
Reviewed-on: https://chromium-review.googlesource.com/1065776Reviewed-by: Alexander Timin <altimin@chromium.org>
Commit-Queue: Alex Clarke <alexclarke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560253}

This reverts commit 34cc115e.
Originally reviewed at: https://chromium-review.googlesource.com/c/chromium/src/+/1065191

Broke Nexus 6 FYI bot:
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Android%20FYI%20Release%20(Nexus%206)/4593

TBR=piman@chromium.org

Bug: 839609,839618
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Ic4ebaedc578f8b32a5a423b73d2b7e29911c791c
Reviewed-on: https://chromium-review.googlesource.com/1067135
Commit-Queue: James Darpinian <jdarpinian@chromium.org>
Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560252}

TBR=charliea@chromium.org
NOTRY=true

Bug: 844541
Change-Id: If20fbd49f847b5bc7e47790b6f2738c6ab152382
Reviewed-on: https://chromium-review.googlesource.com/1066408
Commit-Queue: Emily Hanley <eyaich@chromium.org>
Reviewed-by: Emily Hanley <eyaich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560251}

AudioManagerBase input streams may contain fake streams, which are not
closed properly on Mac now. Fixing it.

Bug: 810321
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I117da2df47c99f43c2d122be8af4ca43da87531d
Reviewed-on: https://chromium-review.googlesource.com/1065679Reviewed-by: Max Morin <maxmorin@chromium.org>
Commit-Queue: Olga Sharonova <olka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560250}

Bug: 829383, 834027
Change-Id: I440f2b11b8cfe8499af913b508dcda535c554cf4
Reviewed-on: https://chromium-review.googlesource.com/1060873Reviewed-by: David Reveman <reveman@chromium.org>
Commit-Queue: Yuichiro Hanada <yhanada@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560249}

This CL adds Memory.AudioService.PrivateMemoryFootprint, SharedMemoryFootprint and
PrivateSwapFootprint metrics, and content::GetProcessIdForAudioService() to read audio
service process id.

Audio service design doc: https://docs.google.com/document/d/1s_Fd1WRDdpb5n6C2MSJjeC3fis6hULZwfKMeDd4K5tI/edit?usp=sharing

Bug: 843985
Change-Id: I8d8c9cd77c8dcd3a6ec836a8f74f36617a9e7f67
Reviewed-on: https://chromium-review.googlesource.com/1064064
Commit-Queue: Marina Ciocea <marinaciocea@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: Erik Chen <erikchen@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560248}

When mounting a fake removable volume (MTP or USB), allow the test case
to control filling the volume with entries or not.

Add a new file display test for USB. Comment file_display.js some more,
plus minor code and git cl format tweaks.

FileDisplay is not supported on Mash: add Mash filter bot exclusions.

Test=browser_test --gtest_filter="FileDisplay/FilesApp*"

Tbr: fukino-san
Bug: 845087,836254
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I841f21d6b737813fc8a59574bfe10abfdf0b6e0d
Reviewed-on: https://chromium-review.googlesource.com/1067219Reviewed-by: Noel Gordon <noel@chromium.org>
Commit-Queue: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560247}

Move ctor and assign of CallbackBase get marked as noexcept recently,
but they are not match to correspondings in .cc. That causes a build
failure on some of bots.

Change-Id: I0af0a3224147e13b526678c791199a54f87b988d
Reviewed-on: https://chromium-review.googlesource.com/1067318Reviewed-by: Shinya Kawanaka <shinyak@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Taiju Tsuiki <tzik@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560246}

As NotificationTray will be replaced by UnifiedSystemTray,
OpenMessageCenter request from ARC should be routed to
UnifiedSystemTray when --enable-features=SystemTrayUnified.

TEST=manual
BUG=837508

Change-Id: I652897f580dd98ae6f58c297c99d869221fc0a60
Reviewed-on: https://chromium-review.googlesource.com/1065550Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560245}

This CL adds a11y string of UnifiedSystemTray button, which is identical
to old SystemTray.
This a11y string is checked in the initialization of all browser_tests,
so lack of this makes all browser_tests fail.

TEST=out/Release/browser_tests --enable-features=SystemTrayUnified
BUG=none

Change-Id: I3d9d2cff593ee53da55c0c48ab70ab7de0a6cb41
Reviewed-on: https://chromium-review.googlesource.com/1065726Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560244}

In the current code, there are some consts that are unnecessary. For
example, returning by const-value has no effect and could harm
optimisations. Similary, taking const-value parameters in header files
don't add anything useful (but const-value parameters in CPP files are
important).

This patch deletes some unnecessary consts, and changes some
const-value parameters to const-ref parameters to save a copy.

Change-Id: Ibafbd348de4ddd3f44388d2e6d5d93816387d0ba
Reviewed-on: https://chromium-review.googlesource.com/1065725Reviewed-by: Yuichiro Hanada <yhanada@chromium.org>
Commit-Queue: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560243}

Replace split_name() in name_utilities.py with tokenize_name() defined
in name_style_converter.py.

split_name() had upper_first_letter() call. It had no effect because the
first letter of split_name() result was always converted to something.
join_names() just joins tokenized names, but join_names() result is
always tokenized and its first letter is always converted to something.

upper_first_letter() converts None input to ''.  It happens only for
functions with @naming_style. So this CL adds None-check to
naming_style().

Bug: 843927
Change-Id: I3b705fa46a8f04c37d2b571bfe2011dfe1ceaf3e
Reviewed-on: https://chromium-review.googlesource.com/1067298Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560242}

FileManagerBrowserTest was renamed in crrev.com/559833 so there are no
FileManagerBrowserTests anymore. Remove their Mash bot filter excludes
(and group the Files.App-related tests together) in the file.

Bug: 843030,836254
Change-Id: I865e22f6e9d762b9766a192ec038860eb591f01c
Reviewed-on: https://chromium-review.googlesource.com/1067317Reviewed-by: Tomasz Mikolajewski <mtomasz@chromium.org>
Reviewed-by: Naoki Fukino <fukino@chromium.org>
Commit-Queue: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560241}

Calling CalculatePreferredSize() can be expensive. The default
BubbleFrameView implmementations of GetMinimumSize() and
GetMaximumSize() invoke it, but popovers are not user-sizable, so
there is no point calculating anything other than the
preferred size. Popups also commonly change their preferred size
without calling Widget::OnSizeConstraintsChanged() so the min/max
sizes set will be wrong anyway.

Note that BubbleFrameView is also used for (non-bubble)
DialogDelegateView. These dialogs may be user-sizable, so that
implementation is unchanged.

Bug: 788597
Change-Id: I7473177eb3f0c9906c7a3191c776d2f36080cb26
Reviewed-on: https://chromium-review.googlesource.com/790175
Commit-Queue: Trent Apted <tapted@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560240}

In the upcoming version of the signed exchange format, the 3-byte big-endian
encoding would also be used to hold signature field length.
This CL renames the func so they are no longer "header" specific.

Bug: 803774
Change-Id: I15576ac789b9a95ae4e752cf305f1d73f05d72be
Reviewed-on: https://chromium-review.googlesource.com/1067277Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Tsuyoshi Horo <horo@chromium.org>
Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org>
Commit-Queue: Kouhei Ueno <kouhei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560239}

This commit adds IsMinimized/IsMaximized/IsFullscreen to
PlatformWindow and makes DesktopWindowTreeHostPlatform use it.

What is more, DesktopWindowTreeHostPlatform also updates
compositor's visibility based on OnWindowStateChanged's

ui::PlatformWindowState, and does relayouting to update
OpaqueBrowserFrameView's buttons.

TEST = ozone_unittests and manual testing with ./out/ozone/chrome
--ozone-platform=wayland --in-process-gpu.

Bug: 843018
Change-Id: Ic7d671a3954dc5a700b9f0ffecbba0b707a31ca9
Reviewed-on: https://chromium-review.googlesource.com/1058792Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Maksim Sisov <msisov@igalia.com>
Cr-Commit-Position: refs/heads/master@{#560238}

Fixes issue where Oilpan traces would not be closed when only the blink_gc category is enabled. (regressed in r558522)

Bug: 840789
Change-Id: Ie6e005e88b05db592f47655966ddff3fd8bf65c8
Reviewed-on: https://chromium-review.googlesource.com/1065723Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Keishi Hattori <keishi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560237}

Split the test for Ok button, Cancel button, ESC key, closing the open
file dialog into separate test cases.

Formerly the test tried to do all three per test case, but that causes
persistent TIMEOUT-PASS flakes on MSAN/ASAN/DEBUG bots [1].

Splitting the test into separate test cases will shorten the test-time
and hopefully minimize TIMEOUT-PASS flake likelihood on those bots.

FileDialog is not supported in Mash, so add Mash bot filter exclusions
for the new tests added in this change-set:

  FileDialog/FilesAppBrowserTest.Test/openFileDialogCancelDrive
  FileDialog/FilesAppBrowserTest.Test/openFileDialogEscapeDrive
  FileDialog/FilesAppBrowserTest.Test/openFileDialogCancelDownloads
  FileDialog/FilesAppBrowserTest.Test/openFileDialogEscapeDownloads

[1] See crbug.com/845054#c2

Test: browser_tests --gtest_filter="FileDialog/FilesApp*"
Bug: 845054
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Idaa629727fb78babe96a51d4e0b89e43fb9abc97
Reviewed-on: https://chromium-review.googlesource.com/1065718
Commit-Queue: Noel Gordon <noel@chromium.org>
Reviewed-by: Naoki Fukino <fukino@chromium.org>
Reviewed-by: Tomasz Mikolajewski <mtomasz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560236}

Update drive.proto for the ChromeOS Files app to store four extra entry
capabilities: can_read, can_delete, can_rename and can_add_children.
Also update the Drive SDK code to query for these capabilities and save
them in the DB accordingly.

Bug: 719959
Change-Id: I163c7562cdb0c13bac06b78da8fe794635df74b5
Reviewed-on: https://chromium-review.googlesource.com/1056948
Commit-Queue: Sasha Morrissey <sashab@chromium.org>
Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org>
Reviewed-by: Naoki Fukino <fukino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560235}

Add VP8Encoder, an implementation of AcceleratedVideoEncoder interface
for VP8, and a VA-API implementation of VP8Encoder::Accelerator.

Also introduce Vp8ReferenceFrameVector, to share reference frame
management code between encoder and decoder classes.

BUG=703988,794608
TEST=veaunittest,apprtc,vdaunittest

Cq-Include-Trybots: luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I7aa9bd9c110bf936728c2a5dab85649ca3328ed6
Reviewed-on: https://chromium-review.googlesource.com/918702
Commit-Queue: Pawel Osciak <posciak@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Miguel Casas <mcasas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560234}

Bug: 782320
Change-Id: I82a8af3958da1890211ba13a7afa85f145df59d6
Reviewed-on: https://chromium-review.googlesource.com/1063517Reviewed-by: Robert Flack <flackr@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Sammie Quon <sammiequon@chromium.org>
Commit-Queue: Manu Cornet <manucornet@google.com>
Cr-Commit-Position: refs/heads/master@{#560233}

'3d' should be recognized as a single token as well as '3D'.
tokenize_name() will handle 'matrix3d' in CSSValueKeywords.json5.

Bug: 843927
Change-Id: I409751a6dd19a02c457895a15b32680ca36f2dd7
Reviewed-on: https://chromium-review.googlesource.com/1065754Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560232}

This feature breaks non-exclusive WebXR sessions so it should not be enabled as
part of Experimental Web Platform Features.
We will still need it enabled when running the hit-test Layout Tests.

Bug: 844228, 833633, 828321
Change-Id: Id59268fae445f67c01c34f4b2e381988157387ae
Reviewed-on: https://chromium-review.googlesource.com/1066812Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Brandon Jones <bajones@chromium.org>
Commit-Queue: David Dorwin <ddorwin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560231}

TouchAccessibilityEnablerTest.InteractsWithTouchExplorationController
is flaky in ash_unittests because ScreenForShutdown persists between
tests. Clean up ScreenForShutdown at the end of each AshTestBase.

Bug: 844253
Test: ash_unittests
Change-Id: I4437fea28bc7757dc38d27db8bfbd173ddfba07a
Reviewed-on: https://chromium-review.googlesource.com/1065177Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560230}

This reverts commit 250e7ef1.

Reason for revert: oopif-performance-cpu-profiles.js failing
consistently in:
https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Linux%20Trusty%20MSAN/7812

Original change's description:
> Reland "DevTools: Support CPU profiles in OOPIFs"
> 
> This is a reland of 91d5ec53
> 
> Original change's description:
> > DevTools: Support CPU profiles in OOPIFs
> >
> > BUG=832313,820250
> >
> > Change-Id: I53d730d4ff7e747eb0ccfe9a055738c1fe9858cf
> > Reviewed-on: https://chromium-review.googlesource.com/1011350
> > Commit-Queue: Alexei Filippov <alph@chromium.org>
> > Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#553688}
> 
> TBR=dgozman
> 
> Bug: 832313, 820250
> Change-Id: I177e0d404b8efe595ddc680368b21c32160cd5de
> Reviewed-on: https://chromium-review.googlesource.com/1065230
> Commit-Queue: Alexei Filippov <alph@chromium.org>
> Reviewed-by: Alexei Filippov <alph@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#560049}

TBR=dgozman@chromium.org,alph@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 832313, 820250
Change-Id: Idf9a6925438105817159658fd8fa19ba00d1b530
Reviewed-on: https://chromium-review.googlesource.com/1065539Reviewed-by: calamity <calamity@chromium.org>
Commit-Queue: calamity <calamity@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560229}

".a+:matches(.c>.e)" requires the intersection of ".a+*" and ".c>.e",
not ".a+.c>.e".

WebKit passes the test, Blink's current implementation does not.

BUG=842157

Change-Id: I51566255006199c511b1d235232c0d9bef40035a
Reviewed-on: https://chromium-review.googlesource.com/1059982Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Eric Willigers <ericwilligers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560228}

Bug: 841587
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: I5454aa1fd7f48e4034b4379f5cd97ba17961c777
Reviewed-on: https://chromium-review.googlesource.com/1066929
Commit-Queue: Aleks Totic <atotic@chromium.org>
Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560227}

Following bot results are included.
5628 5629 5630 5638 5642 5646 5647 5648 5649 5654 5655 5656
5658 5659

116 lines were removed and 18 lines were deflaked by consecutive
results since 5630.

TBR=eae@chromium.org, mstensho@chromium.org
NOTRY=true

Bug: 591099
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: I8566e77b2ceeb0db44e704ca127263f3967b699a
Reviewed-on: https://chromium-review.googlesource.com/1065476
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560226}

The AutoRoll server is located here: https://fuchsia-sdk-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia_arm64_cast_audio;luci.chromium.try:fuchsia_x64_cast_audio
TBR=cr-fuchsia+bot@chromium.org

Change-Id: Iffd88ce923f335ee3b3b9979be0a252f9ef240e2
Reviewed-on: https://chromium-review.googlesource.com/1067237Reviewed-by: Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#560225}

The new behavior matches to name_utilities.py.
This CL has no behavior changes because the current users of
name_style_converter never pass names with such characters.

Bug: 843927
Change-Id: I8eeafb71ec85bb1a0f92eff317fb07eb2dc373ff
Reviewed-on: https://chromium-review.googlesource.com/1065959
Commit-Queue: Kent Tamura <tkent@chromium.org>
Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560224}

This reverts commit ffd43add.

Reason for revert: Suspected of causing
https://ci.chromium.org/buildbot/chromium.memory/Linux%20CFI/7978

Original change's description:
> Make TouchActionFilter::allowed_touch_action_ optional
> 
> The allowed_touch_action_ bit is set to Auto by default when a touch
> action filter is constructed. If we'd want to make a gesture that is
> hitting a main thread touch action region non blocking, we need to
> make this bit optional and set/reset at the right time.
> 
> In this CL, allowed_touch_action_ is set at touch start, and reset
> at GestureScrollEnd, and we also handle the scroll bubbling cases.
> 
> The intention of this CL is to NOT cause any behavior change, which
> can be verified by existing tests.
> 
> Bug: 772130
> Change-Id: I6d37fc4d1b99bddc334f28dc342c9b095a5f30c6
> Reviewed-on: https://chromium-review.googlesource.com/1042351
> Commit-Queue: Xida Chen <xidachen@chromium.org>
> Reviewed-by: Antoine Labour <piman@chromium.org>
> Reviewed-by: Robert Flack <flackr@chromium.org>
> Reviewed-by: Philip Rogers <pdr@chromium.org>
> Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
> Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#560146}

TBR=flackr@chromium.org,pdr@chromium.org,dtapuska@chromium.org,piman@chromium.org,xidachen@chromium.org,nzolghadr@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 772130
Change-Id: I866b91f13116a085f9956604f16324e373da540b
Reviewed-on: https://chromium-review.googlesource.com/1067217Reviewed-by: calamity <calamity@chromium.org>
Commit-Queue: calamity <calamity@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560223}

ARIAProperties.json5 represents the certain rules captured in the ARIA spec.
This change also uses it to generate the list of ARIA attribute name constants,
and to generate the ARIA autocompletion configuration for devtools.

Also adds pyjson5 as a third_party library.

Change-Id: I622e590196be667ed97288a73d040856380f3bf9
Reviewed-on: https://chromium-review.googlesource.com/737397
Commit-Queue: Alice Boxhall <aboxhall@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Joel Einbinder <einbinder@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560222}

In Document::UpdateStyleAndLayoutTree(), recalc slot assignments should be done
before checking NeedsLayoutTreeUpdate() to detect the need of layout tree update
surely. Without that, there is an edge case which causes a crash.

Bug: 776656,844301
Change-Id: I1ef7719216649019e07f2799ecd4f1fcb3d961a6
Reviewed-on: https://chromium-review.googlesource.com/1066030
Commit-Queue: Hayato Ito <hayato@chromium.org>
Reviewed-by: Takayoshi Kochi <kochi@chromium.org>
Reviewed-by: Rakina Zata Amni <rakina@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560221}

BUG=844325
TEST=covered by unittest

Change-Id: I85ba6c727c13e204a0db27f341e3af4ce189b2df
Reviewed-on: https://chromium-review.googlesource.com/1065693Reviewed-by: Ben Wells <benwells@chromium.org>
Commit-Queue: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560220}

The renderer OOM metrics are stored in shared memory buffer so that the
browser can read the metrics after renderer crashes (by OOM).

BUG=843419

Change-Id: I498256e473785051724efa80864f0292cc24362e
Reviewed-on: https://chromium-review.googlesource.com/1062211
Commit-Queue: Siddhartha S <ssid@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560219}

This reverts commit bdc9b10b.
Originally reviewed at: https://chromium-review.googlesource.com/c/chromium/src/+/1062585

Suspected of breaking WebGL conformance tests on FYI waterfall:
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win7%20FYI%20Release%20(AMD)/1241
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win7%20FYI%20Release%20(NVIDIA)/1013
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win7%20FYI%20x64%20Release%20(NVIDIA)/1071
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac%20FYI%20Release%20(Intel)/3022
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac%20FYI%20Experimental%20Retina%20Release%20(AMD)/1728

Bug: 844897,843290
No-Try: true
Tbr: fsamuel@chromium.org
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Change-Id: I7994694e057a08f2a27d4aedcfa369fd350f32b2
Reviewed-on: https://chromium-review.googlesource.com/1067142
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560218}

This CL fixes the URL formatting in ShortcutHelper#getScopeFromUrl().
Previously getScopeFromUrl() was decoding then re-encoding the path,
which does not round-trip correctly as it encodes characters like
'='.

This bug was causing the WebAPK to think that the start URL
was outside of the scope generated by
ShortcutHelper#getScopeFromUrl() and to launch a CCT

BUG=840271
TEST=ShortcutHelperTest

Change-Id: Ibf63a8b13717c33ce6e8f113d58192a964e53d2d
Reviewed-on: https://chromium-review.googlesource.com/1053491
Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Reviewed-by: Matt Giuca <mgiuca@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560217}

Bug: 689702
Change-Id: I2d42bdc23d384462955a70f53c6462298df30658
Reviewed-on: https://chromium-review.googlesource.com/1067102Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Commit-Queue: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560216}