- 09 Nov, 2018 40 commits
-
-
Yi Su authored
This CL changes how search engines are displayed in Search Engine Settings. Previous(1 list): 1. search engines that are prepopulated or created by policy. Current(2 lists): 1. Search engines that are prepopulated or created by policy, and possibly one custom search engine at the end if it's selected as default search engine; 2. All remaining search engines. Unittests are also updated. Bug: 433824 Change-Id: Ib70a18f0544101760c331bb349ee9818956ed231 Reviewed-on: https://chromium-review.googlesource.com/c/1323509Reviewed-by:Mark Cogan <marq@chromium.org> Commit-Queue: Yi Su <mrsuyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#606776}
-
Yutaka Hirano authored
Replace use of ReadableStreamOperations in BodyStreamBuffer with ReadableStream. This CL doesn't change the behavior. Bug: 894357, 888165, 902633 Change-Id: Icd478dcc59ca86e020d540229d69f0c61fb689c0 Reviewed-on: https://chromium-review.googlesource.com/c/1319408 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#606775}
-
Mario Sanchez Prada authored
Use IdentityTestEnvironmentChromeBrowserStateAdaptor instead of manually creating the browser's state by providing specific factories, and then use the APIs from IdentityTestEnvironment, instead of SigninManagerBase. Bug: 890826 Change-Id: Id9d422e002d8fd2edc0ef1ad158f29e95c6dce64 Reviewed-on: https://chromium-review.googlesource.com/c/1318974 Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#606774}
-
David Jean authored
Added base class that should be used in passwords later. Bug: 845472 Change-Id: I1c1d2204d920ae141448239cfeb1c1c5a0e93a20 Reviewed-on: https://chromium-review.googlesource.com/c/1319714 Commit-Queue: David Jean <djean@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#606773}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/27fe62b3b2f9..53aa50a0dced Created with: gclient setdep -r src-internal@53aa50a0dced The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I0ceb97585997b51d4374733c0324a20c8d817333 Reviewed-on: https://chromium-review.googlesource.com/c/1328724Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#606772}
-
Stephane Zermatten authored
This change allows a focus action to provide a list of elements that can be accessed. On a touch event, the position of the touch is compared against the position of the elements before forwarding the event to the webpage (or not). The position of the element is updated periodically or after a scroll event. Currently, touches are just swallowed. A follow-up change will make it clear what's going on and offer alternatives. By default, the new behavior is disabled. Bug: 806868 Change-Id: I5bce26d3a4a81a7167253b564ca416364d18b61e Reviewed-on: https://chromium-review.googlesource.com/c/1323489 Commit-Queue: Stephane Zermatten <szermatt@chromium.org> Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#606771}
-
Jia authored
Bug: 881215 Change-Id: I504764bd39f586d07e67eef1443565d4235a6a2c Reviewed-on: https://chromium-review.googlesource.com/c/1322256Reviewed-by:
Dan Erat <derat@chromium.org> Commit-Queue: Jia Meng <jiameng@chromium.org> Cr-Commit-Position: refs/heads/master@{#606770}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 7963defb. With Chromium commits locally applied on WPT: 270d4abd "ServiceWorker: Add new WPT tests to make sure to update a registration with different script type and identical script content." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: mstensho@chromium.org: external/wpt/css/css-multicol NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I19c1f1a503fec2ad9086489fb20d598cb03b8a1b Reviewed-on: https://chromium-review.googlesource.com/c/1328706 Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#606769}
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. The AutoRoll server is located here: https://autoroll.skia.org/r/afdo-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: I203aa13a2da986403ddb642a29a20ed3069e1e09 Reviewed-on: https://chromium-review.googlesource.com/c/1328725Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#606768}
-
Nick Harper authored
Bug: 875053 Change-Id: I4687640650ac9120acbacbc82dcfe9b0ccb87451 Reviewed-on: https://chromium-review.googlesource.com/c/1325567 Commit-Queue: Varun Khaneja <vakh@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#606767}
-
Mohamed Amir Yosef authored
This CL adds the skeleton of the PasswordSyncBridge and plumps it into PasswordStore. In addition it also include the feature toggle for Passwords USS migration. Bug: 902349 Change-Id: I343f2bb83ecf2c993bacab9e299e7d0deea868b2 Reviewed-on: https://chromium-review.googlesource.com/c/1323653 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#606766}
-
Jia authored
This cl removes white space when we read ALS path and spec from command line. Bug: 881215 Change-Id: I8a7373439793d0d3cd697c41ae882bbb10e7b455 Reviewed-on: https://chromium-review.googlesource.com/c/1328543 Commit-Queue: Jia Meng <jiameng@chromium.org> Reviewed-by:
-
Rakina Zata Amni authored
Currently when traversing to the next/prev sibling of a slot's assigned child, we find the current node's position by looping through a list of the slot's assigned child, taking O(N) time where N is the number of assigned children in that slot. This means traversing through a slot's children will take a total of O(N^2) time. This CL adds a node->index map for slot's children so that we will instead take O(1) time to find a node's position in the list. The downside of this is in cases where there are only a small number of children assigned to a slot, the performance will be slightly worse because of the hashmap lookup. Benchmarked with https://jsbin.com/ravolid/edit?html,output, comparing shadow dom v0 vs v1, where v0 already uses maps. For N = 500 (release build), v0 takes ~20ms, v1 without map takes ~200ms, so v0 is 10x faster than v1. For N = 500 (local build), v0 takes ~54ms, v1 with map takes ~90ms, so v0 is 1.8x faster than v1. Bug: 901063 Change-Id: Iec006fcafca1e368ab97f40d909362dbcf74a08e Reviewed-on: https://chromium-review.googlesource.com/c/1328622Reviewed-by:
Hayato Ito <hayato@chromium.org> Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Cr-Commit-Position: refs/heads/master@{#606764}
-
Marcin Wiacek authored
Error: ../../content/browser/service_worker/service_worker_database.h:398:5: error: declaration shadows a variable in namespace 'content::(anonymous)' [-Werror,-Wshadow] UNINITIALIZED, ^ ../../content/browser/service_worker/service_worker_storage.h:566:5: error: declaration shadows a variable in namespace 'content::(anonymous)' [-Werror,-Wshadow] UNINITIALIZED, ^ ./../../content/browser/browser_thread_impl.cc:36:3: note: previous declaration is here UNINITIALIZED = 0, ^ Example compilation settings: target_os="android" target_cpu="arm" enable_nacl=false symbol_level=0 remove_webcore_debug_symbols=true is_debug=false dcheck_always_on=false is_component_build=false use_jumbo_build=true BUG=903460 Change-Id: Ie8c6ef88ac299e02724bcbbeb1db69e67515f62b Reviewed-on: https://chromium-review.googlesource.com/c/1327213Reviewed-by:Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Marcin Wiącek <marcin@mwiacek.com> Cr-Commit-Position: refs/heads/master@{#606763}
-
Stuart Langley authored
- Fixes the spelling of "arbitrary" in the mojom. - Adds the fields specified in FolderFeature to EntryProperties so they are accessible from the app. - Updates the browser test code and fake_drivefs to support setting FolderFeature values in an entry. Bug: 884020 Change-Id: Ica46d66478e7352724454426a9306f8a447c1c55 Reviewed-on: https://chromium-review.googlesource.com/c/1322337 Commit-Queue: Stuart Langley <slangley@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#606762}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d864aa84bdd0..27fe62b3b2f9 Created with: gclient setdep -r src-internal@27fe62b3b2f9 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ide3feafba203193666bf297a61a2bb73768a55c5 Reviewed-on: https://chromium-review.googlesource.com/c/1328522Reviewed-by:
-
Marc Treib authored
Some const correctness, some control flow simplification, etc. Also contains one actual fix: Handling errors from |pending_customer_data_query_|. Bug: none Change-Id: I0300b04cc4c32dc9e52dde4a115031390f417e5c Reviewed-on: https://chromium-review.googlesource.com/c/1326483Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#606760}
-
Hiroshige Hayashizaki authored
As preparation for plumbing FetchClientSettingsObject via FetchContext rather than as an argument, this CL exposes GetFetchClientSettingsObject() in FetchContext. NullFetchContext is added just to make FetchContext::GetFetchClientSettingsObject() abstract and FetchContext::NullInstance()'s GetFetchClientSettingsObject() non-null. This CL doesn't change the behavior. Bug: 880027 Change-Id: I02a428d77d202ab88cffd22a3fdf3cd34eff4aca Reviewed-on: https://chromium-review.googlesource.com/c/1200042Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#606759}
-
Christopher Lam authored
System PWAs should not show the Hosted App Button Container UI. This CL hides it on all platforms for System Web Apps. Bug: 836128 Change-Id: I2dc87dea17aa77699f6d6639759645a1c184a2bd Reviewed-on: https://chromium-review.googlesource.com/c/1293294 Commit-Queue: calamity <calamity@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#606758}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/a1b4306966a4..22b0ec4f83aa git log a1b4306966a4..22b0ec4f83aa --date=short --no-merges --format='%ad %ae %s' 2018-11-09 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 8aa74a426521..635c9b33fe7c (1 commits) Created with: gclient setdep -r src/third_party/skia@22b0ec4f83aa The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=allanmac@chromium.org Change-Id: I9a4f337eeea51798accf1ef663f111d9524156fb Reviewed-on: https://chromium-review.googlesource.com/c/1328501Reviewed-by:
-
Mitsuru Oshima authored
Bug: 901538 Test: manually tested with squid. Change-Id: I06cf91e0bbcc5281f2f4caf65dc84b0f1833087c Reviewed-on: https://chromium-review.googlesource.com/c/1328161Reviewed-by:
Dominik Laskowski <domlaskowski@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#606756}
-
Hiroshige Hayashizaki authored
Already fixed by https://chromium-review.googlesource.com/1287208. Bug: 655458, 685303, 835717 Change-Id: Id6df7f593db95846375c77918ede9ffcff6316e6 Reviewed-on: https://chromium-review.googlesource.com/c/1328705Reviewed-by:
-
Roberto Carrillo authored
R=jbudorick,stgao,liaoyuke Change-Id: I5ce2f9c8aa14fe5114220ee2438ea48acec4f8a1 Reviewed-on: https://chromium-review.googlesource.com/c/1327165 Commit-Queue: Roberto Carrillo <robertocn@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#606754}
-
Cathy Li authored
Fix homepage IPH auto-disappearing by making it wait until overview mode has finished hiding before showing. Bug: 897600 Change-Id: I99e156e1477d4055333b8e10069959d7e9fefd12 Reviewed-on: https://chromium-review.googlesource.com/c/1318574Reviewed-by:
-
Yuta Kitamura authored
FakeRendererScheduler is a fake for WebThreadScheduler (formerly known as RendererScheduler), which is public to //content and other files outside Blink. This CL renames its now-obsolete class name. Bug: 826203 Tbr: sky@chromium.org Change-Id: I371bdccd22dc57536193486d72da1cced0d752c0 Reviewed-on: https://chromium-review.googlesource.com/c/1319228 Commit-Queue: Yuta Kitamura <yutak@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#606752}
-
Keishi Hattori authored
Convert bindings code allocations from new to MakeGarbageCollected Bug: 757708 Change-Id: Idb87bbbbd1628dc813140df3bf84608e0d103f46 Reviewed-on: https://chromium-review.googlesource.com/c/1326202Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/d856ca48f425..5d2dfa46c05c git log d856ca48f425..5d2dfa46c05c --date=short --no-merges --format='%ad %ae %s' 2018-11-09 jiajia.qin@intel.com ES31: Add array of arrays support in SSBO 2018-11-09 yizhou.jiang@intel.com Enable texture multisample extension on ES3 D3D Created with: gclient setdep -r src/third_party/angle@5d2dfa46c05c The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=syoussefi@chromium.org Change-Id: I0a5e0f4df77ae8710ae103b8346f78ad4f3c61cc Reviewed-on: https://chromium-review.googlesource.com/c/1328521Reviewed-by:
-
Yutaka Hirano authored
Introduce blink::ReadableStream which is a ScriptWrappable. This CL doesn't change the behavior because the interface is not (yet) exposed. Bug: 894357, 888165, 902633 Change-Id: Ie0f14e0efcc7d48034fff8317ba7f70f3f8ecd3b Reviewed-on: https://chromium-review.googlesource.com/c/1319222Reviewed-by:
-
Xiaocheng Hu authored
Currently, InlineContents creation and previous/next movement are done by different implementations: - When creating from a position, it traverses the flat tree until finding a node in a usable block flow; - When moving previous/next, it traverses the layout tree until finding a useable block flow. Since these operations are very similar, this patch change the latter to also traverse on flat tree and share the traversal algorithm to reduce duplicated logic. This also makes it easier to change TextOffsetMapping not to cross text control boundaries (*). (*) crrev.com/c/1327962 Bug: 901492 Change-Id: If7c3dd262903c1a0f81166f729614a8d810f5d27 Reviewed-on: https://chromium-review.googlesource.com/c/1327531Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#606748}
-
Sergei Datsenko authored
This allows proper unittests for this code and simplifies further caching of results. BUG=chromium:902600 Change-Id: Ife150c93225e54f6defab814ad5d9c12c8508106 Reviewed-on: https://chromium-review.googlesource.com/c/1327941 Commit-Queue: Sergei Datsenko <dats@chromium.org> Reviewed-by:
-
yiyix authored
When SetNeedsBeginFrame is set to false or it is not scrolling, update the SkippedFrameTracker to idle state. So that the skipped frame tracker only measures the skip frame count during scrolling. Design doc: https://docs.google.com/document/d/1SqqdQsdh9CA5SRHCvkI_FDcc-vBW-saEj1kh4-qTBwg/ Bug: 894149 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ifcc23fba56abb6213dcf593f8d272aeab322372a Reviewed-on: https://chromium-review.googlesource.com/c/1284432 Commit-Queue: Yi Xu <yiyix@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Cr-Commit-Position: refs/heads/master@{#606746}
-
Robbie McElrath authored
This reverts commit 7b0677dd. Reason for revert: findit says this broke something. I'll revert and see if it's right tomorrow. Original change's description: > Get NetworkChangeNotifier working on ChromeOS with network service. > > The current NetworkChangeNotifierChromeOS implementation won't work > with the network service enabled because it listens for network changes > from Shill, which only supports a single client. The browser process > has other dependencies on Shill, so it has to be the client for the time > being, meaning the network service can't directly listen for network > changes and has to be notified of them from the browser process. > > This CL splits the NetworkChangeNotifierChromeOS into two parts; > the first will live in the browser process and listen to Shill, while > the second is the actual NetworkChangeNotifierChromeOS implementation > which will have an instance in both the browser and network processes. > Since NetworkChangeNotifierChromeOS can't actually listen for network > changes itself, it just gets notified of changes from part 1 via a new > method in NetworkChangeManager. When the thing listening to Shill sees > a network change, it notifies its local NetworkChangeNotifierChromeOS > instance, and calls the new NetworkChangeManager method, the > implementation of which then notifies the network service's > NetworkChangeNotifierChromeOS instance. > > Bug: 882610 > Cq-Include-Trybots: luci.chromium.try:linux_mojo > Change-Id: Ib220575fbe42f026b1e5cb90d3bb6be9d0345414 > Reviewed-on: https://chromium-review.googlesource.com/c/1274445 > Reviewed-by: Paul Jensen <pauljensen@chromium.org> > Reviewed-by: Will Harris <wfh@chromium.org> > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Reviewed-by: Steven Bennetts <stevenjb@chromium.org> > Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> > Cr-Commit-Position: refs/heads/master@{#606665} TBR=stevenjb@chromium.org,jam@chromium.org,pauljensen@chromium.org,wfh@chromium.org,rmcelrath@chromium.org Change-Id: I1fa2bcabe73082e02e59f7c613d08aec4ac94e57 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 882610 Cq-Include-Trybots: luci.chromium.try:linux_mojo Reviewed-on: https://chromium-review.googlesource.com/c/1328701Reviewed-by:
Robbie McElrath <rmcelrath@chromium.org> Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Cr-Commit-Position: refs/heads/master@{#606745}
-
Sebastien Marchand authored
This feature is already enabled on Stable, see https://cs.chromium.org/chromium/src/third_party/blink/renderer/platform/runtime_enabled_features.json5?l=901&rcl=ba0d48f8b3e768e554f6b30d7ab04e3f0e907e61 Change-Id: I070350276f861f717bcb1cf51e45cb7dc8963c1b Reviewed-on: https://chromium-review.googlesource.com/c/1327445Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Cr-Commit-Position: refs/heads/master@{#606744}
-
Jia authored
All jobs will run on the main UI thread except the blocking ones that will run on a blocking task runner (created by the relevant object). The following tasks will run on a blocking task runner: 1. AlsReaderImpl (i). Running cmd to - Check if Als is enabled. - Get Als config. - Get path to Als file from which we'll read Als values. (ii). Reading Als values. 2. ModellerImpl (i). Load curve from disk and save curve to disk. (ii). Call trainer to - Set its initial curves. - Train a model. Hence trainer needs to be associated with the blocking task runner via base::OnTaskRunnerDeleter. Bug: 881215 Change-Id: Iecb5805304c5aa6e0a1b194e136b81ed97534d7b Reviewed-on: https://chromium-review.googlesource.com/c/1321655Reviewed-by:
Andrew Moylan <amoylan@chromium.org> Commit-Queue: Jia Meng <jiameng@chromium.org> Cr-Commit-Position: refs/heads/master@{#606743}
-
Trent Apted authored
Instead, load it lazily the first time a testing extension connects and wants to use the remote call APIs. This avoids having to parse the testing code every time any of the ui/file_manager apps start up (in release, or in tests). Note that current tests (e.g. gallery) may start up a background page with this test code up to *four times* for each test. After this change, only the app under test will load the testing code. There may still be some added latency. To help balance that, this CL caches the result of RemoteCall.isStepByStepEnabled(). That makes it consistent with the newly added function anyway. This still distributes the testing code in release, which is not ideal. Loading from a filesystem:// URL might avoid that in future. This should probably also use an ES6 module.. Baby steps. Bug: 903669 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I7acf6b55b10fa775d40bae48b81b0cfd1859df56 Reviewed-on: https://chromium-review.googlesource.com/c/1322340 Commit-Queue: Trent Apted <tapted@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#606742}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/93cd73d98000..98c0fdb927c4 git log 93cd73d98000..98c0fdb927c4 --date=short --no-merges --format='%ad %ae %s' 2018-11-09 yyanagisawa@chromium.org Add autoninja* to .gitattributes. Created with: gclient setdep -r src/third_party/depot_tools@98c0fdb927c4 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:b/77176746 TBR=agable@chromium.org Change-Id: I16257307b8e92d5b93736666ee2d76ce8e02e83a Reviewed-on: https://chromium-review.googlesource.com/c/1328101Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/1146fdaf9e34..d864aa84bdd0 Created with: gclient setdep -r src-internal@d864aa84bdd0 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ic4a67812b9b22953ac3f8b6efa1f8d1d625319fa Reviewed-on: https://chromium-review.googlesource.com/c/1328245Reviewed-by:
-
Yoichi Osato authored
This patch introduces DCHECK in FrameSelection::SetSelectionDeprecated so that user's selection start/end should have same editability for code sanity. Bug: 789870 Change-Id: Ia01192e61a9f27e2ddeef24e385b23a62a572174 Reviewed-on: https://chromium-review.googlesource.com/c/1325286Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
-
Yusuke Sato authored
Since we no longer ship 23, |is_M| is always false. BUG=None TEST=try Change-Id: Ia2e05b6d8c8c92c9dfa617644b861fff29695bbb Reviewed-on: https://chromium-review.googlesource.com/c/1327610Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Commit-Queue: Yusuke Sato <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#606738}
-
Zhuoyu Qian authored
This patch makes file_error::ErrorCode to be an enum class for better type safety and improving code health. Using forward declaration in other header files instead of including |file_error.h|. Change-Id: I53eae14c2972bb792b474d36e4b8c4bc52c09b0f Reviewed-on: https://chromium-review.googlesource.com/c/1314083Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Commit-Queue: Zhuoyu Qian <zhuoyu.qian@samsung.com> Cr-Commit-Position: refs/heads/master@{#606737}
-
