- 12 Sep, 2017 40 commits
-
-
Ondrej Skopek authored
Removed toggleStartStop and made start/stop public. Refactored placement of constants in files. Added unknown error string. Changed maxAlternative to 1. Bug: 583291 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I203636264c495dd6b450d80b60c5796f41bb73c1 Reviewed-on: https://chromium-review.googlesource.com/660281 Commit-Queue: Ondrej Škopek <oskopek@google.com> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#501230}
-
James Forshaw authored
This CL implements changes to the sandbox Sid class to support the creation of Capability Sid objects. It also contains a few refactoring efforts to cleanup up older code. Bug: 760977 Cq-Include-Trybots: master.tryserver.chromium.win:win10_chromium_x64_rel_ng Change-Id: Id9c05b8017abb81896c1bc30f23599441812d1fd Reviewed-on: https://chromium-review.googlesource.com/649026 Commit-Queue: James Forshaw <forshaw@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
Penny MacNeil <pennymac@chromium.org> Cr-Commit-Position: refs/heads/master@{#501229}
-
Nico Weber authored
Else lld gets confused about `/LIBPATH:..../DIA\ SDK/lib` in the rsp file for dump_syms.exe and fails to link it. See https://bugs.chromium.org/p/chromium/issues/detail?id=600223#c8 for discussion about the approach taken. lld-lib doesn't understand --rsp-quoting yet, so only pass this to link, not to lib. Luckily, we don't have files with spaces in their path in lib files in the build. Bug: 761850 Change-Id: I628439fa4103c8150a324ee314c4cfe5b259adb5 Reviewed-on: https://chromium-review.googlesource.com/659162Reviewed-by:
Peter Collingbourne <pcc@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#501228}
-
Edward Jung authored
Adding this option allows UI to set the visibility of the 'Back to safety' button. Webview: Set to false, so the button would only be shown where there is a page to go back to. Chromium: option is always set to true so always show the Back to safety button. Where there is no previous page, the user is taken to the new tab page. Bug: 760383 Change-Id: I8857b6bf2ff977c572f507f817bf815307453c13 Reviewed-on: https://chromium-review.googlesource.com/641435Reviewed-by:
Jialiu Lin <jialiul@chromium.org> Reviewed-by:
Adrienne Porter Felt <felt@chromium.org> Reviewed-by:
Selim Gurun <sgurun@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Commit-Queue: Edward Jung <edwardjung@chromium.org> Cr-Commit-Position: refs/heads/master@{#501227}
-
Dan Elphick authored
Instead check several conditions earlier to avoid getting (and thus creating) StoragePartitions that are never used. Also adds a new parameter to BrowserContext::GetStoragePartition to allow checking existence without creating the StoragePartition. Finally remove the hack in BackgroundFetchContext which preserved a scoped_refptr to URLRequestContextGetter to ensure it was deleted on the UI thread, now that the StoragePartition is not created and so won't create it. Bug: 762960 Change-Id: I57055c19f485be706485477125d1434e5ae99181 Reviewed-on: https://chromium-review.googlesource.com/654874 Commit-Queue: Dan Elphick <delphick@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#501226}
-
Alex Clarke authored
Sometimes in headless we need to emulate mobile devices including changing navigator.platform. This DevTools command achieves that. Bug: Change-Id: Id305db9fa595d527225c2e19bb269cb60f29110f Reviewed-on: https://chromium-review.googlesource.com/603715 Commit-Queue: Alex Clarke <alexclarke@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#501225}
-
David Vallet authored
Bug: Change-Id: I95354a0bdb4e700ec2fc9e8a2d8d079e5f153ab2 Reviewed-on: https://chromium-review.googlesource.com/662081 Commit-Queue: David Vallet <dvallet@chromium.org> Commit-Queue: Alex Clarke <alexclarke@chromium.org> Reviewed-by:
David Vallet <dvallet@chromium.org> Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Cr-Commit-Position: refs/heads/master@{#501224}
-
Emi Morikawa authored
Use counter instead of using pointers in ServiceWorkerVersion. Bug: 758455 Change-Id: I4fc5205940e18b130be17c52fbcea3e56246fd0e Reviewed-on: https://chromium-review.googlesource.com/662004 Commit-Queue: Emi Morikawa <emim@google.com> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#501223}
-
Austin James Ahlstrom authored
Bug: 745385 Change-Id: I4eb69d0acfdeafecff59251f53179bfd5241d8cd Reviewed-on: https://chromium-review.googlesource.com/647392 Commit-Queue: Austin James Ahlstrom <aahlstrom@google.com> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Takeshi Yoshino <tyoshino@chromium.org> Cr-Commit-Position: refs/heads/master@{#501222}
-
Eric Willigers authored
The following tests are no longer skipped: external/wpt/css/CSS2/cascade-import external/wpt/css/css-cascade-3 external/wpt/css/css-cascade-4 BUG=763610 Change-Id: I5d4b0f806d9deb160e4075d17754ea5729eae535 Reviewed-on: https://chromium-review.googlesource.com/662484 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#501221}
-
Ramin Halavati authored
test_tool.py updated to use c++14 for generated compile commands and ignore '\r' characters that emerge in concatanating llvm::outs() results on Windows. Bug: Change-Id: I68443f84054a6b9f5d7209725263e27ce343e654 Reviewed-on: https://chromium-review.googlesource.com/657758Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#501220}
-
Lisa Suzuki authored
This CL's intention is to adjust to the change of WebIDL's specification. Before this CL, type in Argument cannot be treated with Extended Attributes as a group: - ex1) ExtendedAttributeList optional Type ArgumentName Default - ex2) ExtendedAttributeList Type Ellipsis ArgumentName All ExtendedAttributes in ExtendedAttributeList are treated with ArgumentName in AST After this CL, however, type in Argument can be treated with Extended Attributes: - ex1) ExtendedAttributeList optional TypeWithExtendedAttributes ArgumentName Default - ex2) ExtendedAttributeList Type Ellipsis ArgumentName in ex1), all the ExtendedAttributes in TypeWithExtendedAttributes can be treated with Type in AST in ex2), ExtendedAttributes in ExtendedAttributeList which are applicable to types ([Clamp], [EnforceRange], [TreatNullAs]) can be treated with Type in AST In order to check if ASTs are dumped correctly, I also added pattern match based tests and TestInterface tests. Bug: 714866 Change-Id: I063dc2f88ed31cab36c614c4d4ab7c83591e1bed Reviewed-on: https://chromium-review.googlesource.com/662483 Commit-Queue: Lisa Suzuki <lisabelle@google.com> Reviewed-by:Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#501219}
-
tzik authored
This CL converts WTF::PassRefPtr to an alias of WTF::RefPtr, and removes the implementation. Bug: 494719 Change-Id: Ide96ef03dfa69668c1de87891a712bcd46470e13 Reviewed-on: https://chromium-review.googlesource.com/657786 Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#501218}
-
Yoichi Osato authored
We check more exactly. Especially this is important for PositionInFlatTree. Bug: Change-Id: I43edef60ca3b966cb5501eef241f12d99f40e0ae Reviewed-on: https://chromium-review.googlesource.com/662718Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#501217}
-
Yoichi Osato authored
Use Position::IsValidfor() and remove IsPositionValidFor() which was introduce to avoid jumbo build error?: https://chromium-review.googlesource.com/c/chromium/src/+/659658 Bug: Change-Id: I5b301e598ff3654a1f5e54192556991c9bdfed0b Reviewed-on: https://chromium-review.googlesource.com/662003Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#501216}
-
Ben Wells authored
This reverts commit 245abec2. Reason for revert: One of the exo tests is failing flakily now. See http://crbug.com/746227 Original change's description: > Run exo tests in parallel > > BUG=None > TEST=All tests still should pass > > Change-Id: I8a2cc5598baaa9692a33a79767f93869e5a75b9b > Reviewed-on: https://chromium-review.googlesource.com/657622 > Reviewed-by: David Reveman <reveman@chromium.org> > Commit-Queue: Mitsuru Oshima <oshima@chromium.org> > Cr-Commit-Position: refs/heads/master@{#500712} TBR=reveman@chromium.org,oshima@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: None Change-Id: I6a7d7bfef56b027a0ebf8b914f2967195029840b Reviewed-on: https://chromium-review.googlesource.com/662842Reviewed-by:
Ben Wells <benwells@chromium.org> Commit-Queue: Ben Wells <benwells@chromium.org> Cr-Commit-Position: refs/heads/master@{#501215}
-
Tetsui Ohkubo authored
In new-style notification, system notification has different style from other notifications such as web notifications. * The context header shows the title "Chrome OS system". * The context header has accent color. * New MD icon is used. TEST=manual BUG=761885 Change-Id: I8de0863bd95080f66123ae34704ccb6fa09e19b6 Reviewed-on: https://chromium-review.googlesource.com/649449Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#501214}
-
Peter E Conn authored
Remove a few unnecessary members and add @Nullable. Bug: 740534 Change-Id: Ia51ac1cd79d42d5be725856fcb81d987c1bc2662 Reviewed-on: https://chromium-review.googlesource.com/660337Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#501213}
-
Alice Boxhall authored
- Ensure moving the mouse off the accessibility tree causes the inspected node to be scrolled back into view; - Ensure that moving focus away and back to the tree re-focuses the inspected node, including if the tree pane is hidden and re-shown; - Avoid hover highlight "sticking" to the node above/below the inspected node; - Make the context menu for breadcrumbs work again; - Make sure treeitem role and tabindex are on the same DOM node. Bug: 560525 Change-Id: I27ced90eedc115fd93c9a65c8baefe87886c092e Reviewed-on: https://chromium-review.googlesource.com/625500 Commit-Queue: Alice Boxhall <aboxhall@chromium.org> Reviewed-by:
Joel Einbinder <einbinder@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#501212}
-
Yuichiro Hanada authored
This is a temporal fix for the issue that non-Latin IMEs doesn't work. The 'background.persistent' flag should be restored as soon as possible after fixing the root cause of the issue. Also, add some useful logs to debug the issue. chrome://inspect/#extensions. Bug: 761714 Test: Manual. Confirm that the extension always appears on Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ia0a12a33036919dc2bec213fd11b49d3b7b9d54f Reviewed-on: https://chromium-review.googlesource.com/660938 Commit-Queue: Yuichiro Hanada <yhanada@chromium.org> Reviewed-by:Shu Chen <shuchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#501211}
-
Ben Wells authored
This reverts commit 3c6304c0. Reason for revert: Doesn't compile on Mac. Original change's description: > Traffic annotation auditor and unittest updated. > > The following changes were done: > 1- Auditor adds a list of OSes that actively use each annotation to > annotations.xml, so that removing annotation from one OS and keeping > it in another would not result in marking it deprecated. > 2- A script is added to tools/traffic_anntotation/scripts, to call all > scripts that update a give file when annotations.xml is modified, or > to run unittests that ensure these files are up to date. > 3- 'test-only' switch added to Auditor. When this switch is present, > auditor only checks if annotations.xml is up to date and issues an > error it if is not. When switch is not specified, annotations.xml > may get updated and if so, the above mentioned script is called to > update downstream files. > 4- Auditor will prevent use of deprecated unique ids. > 5- Unittest checks that annotations.xml is loadable and its content are > valid. > 6- Unittest calls the script mentioned in (2) to test if downstream > files are correctly updated. > > Bug: 656607 > Bug: 690323 > Change-Id: I3cea4254dc4ff8bb2c31a8adc1ff5a7daf5006d7 > Reviewed-on: https://chromium-review.googlesource.com/645088 > Commit-Queue: Ramin Halavati <rhalavati@chromium.org> > Reviewed-by: Martin Šrámek <msramek@chromium.org> > Cr-Commit-Position: refs/heads/master@{#501206} TBR=msramek@chromium.org,rhalavati@chromium.org Change-Id: Id4c9b556ec5e93d7d5e4d0cd2bd60137811e663f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 656607, 690323 Reviewed-on: https://chromium-review.googlesource.com/662503Reviewed-by:
Ben Wells <benwells@chromium.org> Commit-Queue: Ben Wells <benwells@chromium.org> Cr-Commit-Position: refs/heads/master@{#501210}
-
Yutaka Hirano authored
Bug: 695939 Change-Id: I39a9e9ce3b030ec233a03912a3b55d25fffa46a4 Reviewed-on: https://chromium-review.googlesource.com/652208 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#501209}
-
Ben Wells authored
Bug: 757243 Tbr: xiyuan@chromium.org Change-Id: Icc3358ecd4970fdfba9ee7783c3ef130506e3723 Reviewed-on: https://chromium-review.googlesource.com/662083Reviewed-by:
Ben Wells <benwells@chromium.org> Commit-Queue: Ben Wells <benwells@chromium.org> Cr-Commit-Position: refs/heads/master@{#501208}
-
Ramya Sharma authored
- Move functionality for multiple Folder selection - Move functionality for multiple URL selection - Move functionality for multiple Folder / URL selection - Eg tests for the same. Bug: 695749 Change-Id: I5c64c6ddc10fb5e47e1fcd521afea9498f653ae4 Reviewed-on: https://chromium-review.googlesource.com/662538 Commit-Queue: Ramya Sharma <ramyasharma@chromium.org> Reviewed-by:
Marti Wong <martiw@chromium.org> Cr-Commit-Position: refs/heads/master@{#501207}
-
Ramin Halavati authored
The following changes were done: 1- Auditor adds a list of OSes that actively use each annotation to annotations.xml, so that removing annotation from one OS and keeping it in another would not result in marking it deprecated. 2- A script is added to tools/traffic_anntotation/scripts, to call all scripts that update a give file when annotations.xml is modified, or to run unittests that ensure these files are up to date. 3- 'test-only' switch added to Auditor. When this switch is present, auditor only checks if annotations.xml is up to date and issues an error it if is not. When switch is not specified, annotations.xml may get updated and if so, the above mentioned script is called to update downstream files. 4- Auditor will prevent use of deprecated unique ids. 5- Unittest checks that annotations.xml is loadable and its content are valid. 6- Unittest calls the script mentioned in (2) to test if downstream files are correctly updated. Bug: 656607 Bug: 690323 Change-Id: I3cea4254dc4ff8bb2c31a8adc1ff5a7daf5006d7 Reviewed-on: https://chromium-review.googlesource.com/645088 Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Reviewed-by:Martin Šrámek <msramek@chromium.org> Cr-Commit-Position: refs/heads/master@{#501206}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 285ef68a. Build: https://build.chromium.org/p/chromium.infra.cron/builders/wpt-importer/builds/1655 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: rouslan@chromium.org, mathp@chromium.org: external/wpt/payment-request TBR=qyearsley@chromium.org No-Export: true Change-Id: I81465305dcd669eba7a88697ba3fb764fa5ce0d7 Reviewed-on: https://chromium-review.googlesource.com/662619 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#501205}
-
Han Leon authored
This CL replaces native struct content::ServiceWorkerRegistrationOptions with mojom struct blink.mojom.ServiceWorkerRegistrationOptions. BUG=758151 Change-Id: Ic7142a0db0967fdb0e2c766f5b46d4ec1b4f66b4 Reviewed-on: https://chromium-review.googlesource.com/657257Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Han Leon <leon.han@intel.com> Cr-Commit-Position: refs/heads/master@{#501204}
-
Jay Civelli authored
Removing a constant now unused. Bug: none Change-Id: Icd6f33ab85d1d195d3c5a96bd1ebf85a45b9ed93 Tbr: tsepez Reviewed-on: https://chromium-review.googlesource.com/661143Reviewed-by:
Jay Civelli <jcivelli@chromium.org> Commit-Queue: Jay Civelli <jcivelli@chromium.org> Cr-Commit-Position: refs/heads/master@{#501203}
-
Chris Harrelson authored
1. Avoid multiple adjacent calls to MutableForPainting(). 2. Avoid computing the containing composited layer unless fragmentation is present. Bug: 763901 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Icea7cdd99c23860f6d853a3dbfcb51f10e8dd24d Reviewed-on: https://chromium-review.googlesource.com/660681 Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Tien-Ren Chen <trchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#501202}
-
Xianzhu Wang authored
crrev.com/c/515606 overly simplified table layout overflow which is expected to cover all collapsed border overflows. The CL added all visual overflow into layout overflow causing it to also unexpectedly cover all contents overflows (e.g. shadow and outlines of descendants). Fix the issue by just include collapsed border overflow. Bug: 763337 Change-Id: I6c53afba3f00729a483588dfea46c86a8b78562a Reviewed-on: https://chromium-review.googlesource.com/657815 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@opera.com> Cr-Commit-Position: refs/heads/master@{#501201}
-
Jeremy Roman authored
These callbacks would already be delivered by the similar scope inside the attribute implementation. Methods already have only the inner scope. Change-Id: I72bceec4d883d0dba5e93b2ec19156d3c88590e1 Reviewed-on: https://chromium-review.googlesource.com/662220Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#501200}
-
Brett Wilson authored
Part 4/4 to replace these namespace qualifications. TBR=dcheng@chromium.org Bug: 763556 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I31d6c69d73111165fb1bd8294cd0fe4e18ce96bd Reviewed-on: https://chromium-review.googlesource.com/662561 Commit-Queue: Brett Wilson <brettw@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Brett Wilson <brettw@chromium.org> Cr-Commit-Position: refs/heads/master@{#501199}
-
Kent Tamura authored
Bug: 578345 Change-Id: I2b7754a63b3ae5eb2487362ca1e17331a0d68b4a Reviewed-on: https://chromium-review.googlesource.com/662719Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#501198}
-
Giovanni Ortuño Urquidi authored
This is done only if the ExperimentalAppBanners feature is enabled. Also re-arranges the strings and guards in them the grd file instead of in c++. Bug: 629725 Change-Id: Iec496f5ee9c4729fdecc272223e66c5abd93a494 Reviewed-on: https://chromium-review.googlesource.com/658580 Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#501197}
-
Daichi Hirono authored
Bug: 750997 Test: exo_unittests --gtest_filter=DataDeviceTest.* Change-Id: I83c41477a945e363c70560595fe3a079ed62c2cb Reviewed-on: https://chromium-review.googlesource.com/624767 Commit-Queue: Daichi Hirono <hirono@chromium.org> Reviewed-by:
David Reveman <reveman@chromium.org> Cr-Commit-Position: refs/heads/master@{#501196}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/6bdbb1f1..19769c12 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org Change-Id: Icc5b6f10e91b838a5163625ac022e8d2fb219120 Reviewed-on: https://chromium-review.googlesource.com/662221Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#501195}
-
Jinsuk Kim authored
|ResolveTapDisambiguation| is left unused after CVC. This CL cleans it up. https: //crrev.com/c/630980 and should have been removed from Change-Id: I3b35fa741b9ee14626b14b9d26a5d132cf68fa78 Reviewed-on: https://chromium-review.googlesource.com/657785Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#501194}
-
Austin James Ahlstrom authored
Bug: 745385 Change-Id: I6592737458f684e65738ca45aa34a58d5e2ed8bd Reviewed-on: https://chromium-review.googlesource.com/647955 Commit-Queue: Austin James Ahlstrom <aahlstrom@google.com> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Takeshi Yoshino <tyoshino@chromium.org> Cr-Commit-Position: refs/heads/master@{#501193}
-
Brett Wilson authored
This removes the obsolete tracked_objects:: qualification on uses of Location in //base. TBR=dcheng@chromium.org Bug: 763556 Change-Id: Iffdbf067f65f6dbfe309413294b8ace2e8917617 Reviewed-on: https://chromium-review.googlesource.com/662597Reviewed-by:
Brett Wilson <brettw@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Brett Wilson <brettw@chromium.org> Cr-Commit-Position: refs/heads/master@{#501192}
-
Kent Tamura authored
Major part of bindings/scripts/ use single quotes. This CL improves code consistency. Change-Id: Ic21c8117fd34c0e13ee64540211ebc6012116067 Reviewed-on: https://chromium-review.googlesource.com/662499Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#501191}
-